12874c5fdSThomas Gleixner // SPDX-License-Identifier: GPL-2.0-or-later 2aaddd3eaSMichael Ellerman /* 3aaddd3eaSMichael Ellerman * Copyright 2008 Michael Ellerman, IBM Corporation. 4aaddd3eaSMichael Ellerman */ 5aaddd3eaSMichael Ellerman 6aaddd3eaSMichael Ellerman #include <linux/kernel.h> 771f6e58eSNaveen N. Rao #include <linux/kprobes.h> 8ae0dc736SMichael Ellerman #include <linux/vmalloc.h> 9ae0dc736SMichael Ellerman #include <linux/init.h> 1027ac792cSAndrea Righi #include <linux/mm.h> 1137bc3e5fSBalbir Singh #include <linux/cpuhotplug.h> 1237bc3e5fSBalbir Singh #include <linux/slab.h> 137c0f6ba6SLinus Torvalds #include <linux/uaccess.h> 14aaddd3eaSMichael Ellerman 1537bc3e5fSBalbir Singh #include <asm/pgtable.h> 1637bc3e5fSBalbir Singh #include <asm/tlbflush.h> 1737bc3e5fSBalbir Singh #include <asm/page.h> 1837bc3e5fSBalbir Singh #include <asm/code-patching.h> 19252eb558SChristophe Leroy #include <asm/setup.h> 2075346251SJordan Niethe #include <asm/inst.h> 21aaddd3eaSMichael Ellerman 2294afd069SJordan Niethe static int __patch_instruction(struct ppc_inst *exec_addr, struct ppc_inst instr, 2394afd069SJordan Niethe struct ppc_inst *patch_addr) 24aaddd3eaSMichael Ellerman { 25ef296729SRussell Currey int err = 0; 26b6e37968SSteven Rostedt 2794afd069SJordan Niethe __put_user_asm(ppc_inst_val(instr), patch_addr, err, "stw"); 28b6e37968SSteven Rostedt if (err) 29b6e37968SSteven Rostedt return err; 3037bc3e5fSBalbir Singh 318cf4c057SChristophe Leroy asm ("dcbst 0, %0; sync; icbi 0,%1; sync; isync" :: "r" (patch_addr), 328cf4c057SChristophe Leroy "r" (exec_addr)); 3337bc3e5fSBalbir Singh 34b6e37968SSteven Rostedt return 0; 35aaddd3eaSMichael Ellerman } 36aaddd3eaSMichael Ellerman 3794afd069SJordan Niethe int raw_patch_instruction(struct ppc_inst *addr, struct ppc_inst instr) 388cf4c057SChristophe Leroy { 398cf4c057SChristophe Leroy return __patch_instruction(addr, instr, addr); 408cf4c057SChristophe Leroy } 418cf4c057SChristophe Leroy 4237bc3e5fSBalbir Singh #ifdef CONFIG_STRICT_KERNEL_RWX 4337bc3e5fSBalbir Singh static DEFINE_PER_CPU(struct vm_struct *, text_poke_area); 4437bc3e5fSBalbir Singh 4537bc3e5fSBalbir Singh static int text_area_cpu_up(unsigned int cpu) 4637bc3e5fSBalbir Singh { 4737bc3e5fSBalbir Singh struct vm_struct *area; 4837bc3e5fSBalbir Singh 4937bc3e5fSBalbir Singh area = get_vm_area(PAGE_SIZE, VM_ALLOC); 5037bc3e5fSBalbir Singh if (!area) { 5137bc3e5fSBalbir Singh WARN_ONCE(1, "Failed to create text area for cpu %d\n", 5237bc3e5fSBalbir Singh cpu); 5337bc3e5fSBalbir Singh return -1; 5437bc3e5fSBalbir Singh } 5537bc3e5fSBalbir Singh this_cpu_write(text_poke_area, area); 5637bc3e5fSBalbir Singh 5737bc3e5fSBalbir Singh return 0; 5837bc3e5fSBalbir Singh } 5937bc3e5fSBalbir Singh 6037bc3e5fSBalbir Singh static int text_area_cpu_down(unsigned int cpu) 6137bc3e5fSBalbir Singh { 6237bc3e5fSBalbir Singh free_vm_area(this_cpu_read(text_poke_area)); 6337bc3e5fSBalbir Singh return 0; 6437bc3e5fSBalbir Singh } 6537bc3e5fSBalbir Singh 6637bc3e5fSBalbir Singh /* 6737bc3e5fSBalbir Singh * Run as a late init call. This allows all the boot time patching to be done 6837bc3e5fSBalbir Singh * simply by patching the code, and then we're called here prior to 6937bc3e5fSBalbir Singh * mark_rodata_ro(), which happens after all init calls are run. Although 7037bc3e5fSBalbir Singh * BUG_ON() is rude, in this case it should only happen if ENOMEM, and we judge 7137bc3e5fSBalbir Singh * it as being preferable to a kernel that will crash later when someone tries 7237bc3e5fSBalbir Singh * to use patch_instruction(). 7337bc3e5fSBalbir Singh */ 7437bc3e5fSBalbir Singh static int __init setup_text_poke_area(void) 7537bc3e5fSBalbir Singh { 7637bc3e5fSBalbir Singh BUG_ON(!cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, 7737bc3e5fSBalbir Singh "powerpc/text_poke:online", text_area_cpu_up, 7837bc3e5fSBalbir Singh text_area_cpu_down)); 7937bc3e5fSBalbir Singh 8037bc3e5fSBalbir Singh return 0; 8137bc3e5fSBalbir Singh } 8237bc3e5fSBalbir Singh late_initcall(setup_text_poke_area); 8337bc3e5fSBalbir Singh 8437bc3e5fSBalbir Singh /* 8537bc3e5fSBalbir Singh * This can be called for kernel text or a module. 8637bc3e5fSBalbir Singh */ 8737bc3e5fSBalbir Singh static int map_patch_area(void *addr, unsigned long text_poke_addr) 8837bc3e5fSBalbir Singh { 8937bc3e5fSBalbir Singh unsigned long pfn; 9037bc3e5fSBalbir Singh int err; 9137bc3e5fSBalbir Singh 9237bc3e5fSBalbir Singh if (is_vmalloc_addr(addr)) 9337bc3e5fSBalbir Singh pfn = vmalloc_to_pfn(addr); 9437bc3e5fSBalbir Singh else 9537bc3e5fSBalbir Singh pfn = __pa_symbol(addr) >> PAGE_SHIFT; 9637bc3e5fSBalbir Singh 97c766ee72SChristophe Leroy err = map_kernel_page(text_poke_addr, (pfn << PAGE_SHIFT), PAGE_KERNEL); 9837bc3e5fSBalbir Singh 9937bc3e5fSBalbir Singh pr_devel("Mapped addr %lx with pfn %lx:%d\n", text_poke_addr, pfn, err); 10037bc3e5fSBalbir Singh if (err) 10137bc3e5fSBalbir Singh return -1; 10237bc3e5fSBalbir Singh 10337bc3e5fSBalbir Singh return 0; 10437bc3e5fSBalbir Singh } 10537bc3e5fSBalbir Singh 10637bc3e5fSBalbir Singh static inline int unmap_patch_area(unsigned long addr) 10737bc3e5fSBalbir Singh { 10837bc3e5fSBalbir Singh pte_t *ptep; 10937bc3e5fSBalbir Singh pmd_t *pmdp; 11037bc3e5fSBalbir Singh pud_t *pudp; 11137bc3e5fSBalbir Singh pgd_t *pgdp; 11237bc3e5fSBalbir Singh 11337bc3e5fSBalbir Singh pgdp = pgd_offset_k(addr); 11437bc3e5fSBalbir Singh if (unlikely(!pgdp)) 11537bc3e5fSBalbir Singh return -EINVAL; 11637bc3e5fSBalbir Singh 11737bc3e5fSBalbir Singh pudp = pud_offset(pgdp, addr); 11837bc3e5fSBalbir Singh if (unlikely(!pudp)) 11937bc3e5fSBalbir Singh return -EINVAL; 12037bc3e5fSBalbir Singh 12137bc3e5fSBalbir Singh pmdp = pmd_offset(pudp, addr); 12237bc3e5fSBalbir Singh if (unlikely(!pmdp)) 12337bc3e5fSBalbir Singh return -EINVAL; 12437bc3e5fSBalbir Singh 12537bc3e5fSBalbir Singh ptep = pte_offset_kernel(pmdp, addr); 12637bc3e5fSBalbir Singh if (unlikely(!ptep)) 12737bc3e5fSBalbir Singh return -EINVAL; 12837bc3e5fSBalbir Singh 12937bc3e5fSBalbir Singh pr_devel("clearing mm %p, pte %p, addr %lx\n", &init_mm, ptep, addr); 13037bc3e5fSBalbir Singh 13137bc3e5fSBalbir Singh /* 13237bc3e5fSBalbir Singh * In hash, pte_clear flushes the tlb, in radix, we have to 13337bc3e5fSBalbir Singh */ 13437bc3e5fSBalbir Singh pte_clear(&init_mm, addr, ptep); 13537bc3e5fSBalbir Singh flush_tlb_kernel_range(addr, addr + PAGE_SIZE); 13637bc3e5fSBalbir Singh 13737bc3e5fSBalbir Singh return 0; 13837bc3e5fSBalbir Singh } 13937bc3e5fSBalbir Singh 14094afd069SJordan Niethe static int do_patch_instruction(struct ppc_inst *addr, struct ppc_inst instr) 14137bc3e5fSBalbir Singh { 14237bc3e5fSBalbir Singh int err; 14394afd069SJordan Niethe struct ppc_inst *patch_addr = NULL; 14437bc3e5fSBalbir Singh unsigned long flags; 14537bc3e5fSBalbir Singh unsigned long text_poke_addr; 14637bc3e5fSBalbir Singh unsigned long kaddr = (unsigned long)addr; 14737bc3e5fSBalbir Singh 14837bc3e5fSBalbir Singh /* 14937bc3e5fSBalbir Singh * During early early boot patch_instruction is called 15037bc3e5fSBalbir Singh * when text_poke_area is not ready, but we still need 15137bc3e5fSBalbir Singh * to allow patching. We just do the plain old patching 15237bc3e5fSBalbir Singh */ 1538183d99fSChristophe Leroy if (!this_cpu_read(text_poke_area)) 1548cf4c057SChristophe Leroy return raw_patch_instruction(addr, instr); 15537bc3e5fSBalbir Singh 15637bc3e5fSBalbir Singh local_irq_save(flags); 15737bc3e5fSBalbir Singh 15837bc3e5fSBalbir Singh text_poke_addr = (unsigned long)__this_cpu_read(text_poke_area)->addr; 15937bc3e5fSBalbir Singh if (map_patch_area(addr, text_poke_addr)) { 16037bc3e5fSBalbir Singh err = -1; 16137bc3e5fSBalbir Singh goto out; 16237bc3e5fSBalbir Singh } 16337bc3e5fSBalbir Singh 16494afd069SJordan Niethe patch_addr = (struct ppc_inst *)(text_poke_addr + (kaddr & ~PAGE_MASK)); 16537bc3e5fSBalbir Singh 1668cf4c057SChristophe Leroy __patch_instruction(addr, instr, patch_addr); 16737bc3e5fSBalbir Singh 16837bc3e5fSBalbir Singh err = unmap_patch_area(text_poke_addr); 16937bc3e5fSBalbir Singh if (err) 17037bc3e5fSBalbir Singh pr_warn("failed to unmap %lx\n", text_poke_addr); 17137bc3e5fSBalbir Singh 17237bc3e5fSBalbir Singh out: 17337bc3e5fSBalbir Singh local_irq_restore(flags); 17437bc3e5fSBalbir Singh 17537bc3e5fSBalbir Singh return err; 17637bc3e5fSBalbir Singh } 17737bc3e5fSBalbir Singh #else /* !CONFIG_STRICT_KERNEL_RWX */ 17837bc3e5fSBalbir Singh 17994afd069SJordan Niethe static int do_patch_instruction(struct ppc_inst *addr, struct ppc_inst instr) 18037bc3e5fSBalbir Singh { 1818cf4c057SChristophe Leroy return raw_patch_instruction(addr, instr); 18237bc3e5fSBalbir Singh } 18337bc3e5fSBalbir Singh 18437bc3e5fSBalbir Singh #endif /* CONFIG_STRICT_KERNEL_RWX */ 185b45ba4a5SChristophe Leroy 18694afd069SJordan Niethe int patch_instruction(struct ppc_inst *addr, struct ppc_inst instr) 187b45ba4a5SChristophe Leroy { 188b45ba4a5SChristophe Leroy /* Make sure we aren't patching a freed init section */ 189b45ba4a5SChristophe Leroy if (init_mem_is_free && init_section_contains(addr, 4)) { 190b45ba4a5SChristophe Leroy pr_debug("Skipping init section patching addr: 0x%px\n", addr); 191b45ba4a5SChristophe Leroy return 0; 192b45ba4a5SChristophe Leroy } 193b45ba4a5SChristophe Leroy return do_patch_instruction(addr, instr); 194b45ba4a5SChristophe Leroy } 19537bc3e5fSBalbir Singh NOKPROBE_SYMBOL(patch_instruction); 19637bc3e5fSBalbir Singh 19794afd069SJordan Niethe int patch_branch(struct ppc_inst *addr, unsigned long target, int flags) 198e7a57273SMichael Ellerman { 19994afd069SJordan Niethe struct ppc_inst instr; 2007c95d889SJordan Niethe 2017c95d889SJordan Niethe create_branch(&instr, addr, target, flags); 2027c95d889SJordan Niethe return patch_instruction(addr, instr); 203e7a57273SMichael Ellerman } 204e7a57273SMichael Ellerman 205ebfa50dfSAnju T bool is_offset_in_branch_range(long offset) 206ebfa50dfSAnju T { 207ebfa50dfSAnju T /* 208ebfa50dfSAnju T * Powerpc branch instruction is : 209ebfa50dfSAnju T * 210ebfa50dfSAnju T * 0 6 30 31 211ebfa50dfSAnju T * +---------+----------------+---+---+ 212ebfa50dfSAnju T * | opcode | LI |AA |LK | 213ebfa50dfSAnju T * +---------+----------------+---+---+ 214ebfa50dfSAnju T * Where AA = 0 and LK = 0 215ebfa50dfSAnju T * 216ebfa50dfSAnju T * LI is a signed 24 bits integer. The real branch offset is computed 217ebfa50dfSAnju T * by: imm32 = SignExtend(LI:'0b00', 32); 218ebfa50dfSAnju T * 219ebfa50dfSAnju T * So the maximum forward branch should be: 220ebfa50dfSAnju T * (0x007fffff << 2) = 0x01fffffc = 0x1fffffc 221ebfa50dfSAnju T * The maximum backward branch should be: 222ebfa50dfSAnju T * (0xff800000 << 2) = 0xfe000000 = -0x2000000 223ebfa50dfSAnju T */ 224ebfa50dfSAnju T return (offset >= -0x2000000 && offset <= 0x1fffffc && !(offset & 0x3)); 225ebfa50dfSAnju T } 226ebfa50dfSAnju T 22751c9c084SAnju T /* 22851c9c084SAnju T * Helper to check if a given instruction is a conditional branch 22951c9c084SAnju T * Derived from the conditional checks in analyse_instr() 23051c9c084SAnju T */ 23194afd069SJordan Niethe bool is_conditional_branch(struct ppc_inst instr) 23251c9c084SAnju T { 2338094892dSJordan Niethe unsigned int opcode = ppc_inst_primary_opcode(instr); 23451c9c084SAnju T 23551c9c084SAnju T if (opcode == 16) /* bc, bca, bcl, bcla */ 23651c9c084SAnju T return true; 23751c9c084SAnju T if (opcode == 19) { 238777e26f0SJordan Niethe switch ((ppc_inst_val(instr) >> 1) & 0x3ff) { 23951c9c084SAnju T case 16: /* bclr, bclrl */ 24051c9c084SAnju T case 528: /* bcctr, bcctrl */ 24151c9c084SAnju T case 560: /* bctar, bctarl */ 24251c9c084SAnju T return true; 24351c9c084SAnju T } 24451c9c084SAnju T } 24551c9c084SAnju T return false; 24651c9c084SAnju T } 24771f6e58eSNaveen N. Rao NOKPROBE_SYMBOL(is_conditional_branch); 24851c9c084SAnju T 24994afd069SJordan Niethe int create_branch(struct ppc_inst *instr, 25094afd069SJordan Niethe const struct ppc_inst *addr, 251e7a57273SMichael Ellerman unsigned long target, int flags) 252aaddd3eaSMichael Ellerman { 253053a858eSMichael Ellerman long offset; 254aaddd3eaSMichael Ellerman 25594afd069SJordan Niethe *instr = ppc_inst(0); 256053a858eSMichael Ellerman offset = target; 257aaddd3eaSMichael Ellerman if (! (flags & BRANCH_ABSOLUTE)) 258053a858eSMichael Ellerman offset = offset - (unsigned long)addr; 259053a858eSMichael Ellerman 260053a858eSMichael Ellerman /* Check we can represent the target in the instruction format */ 261ebfa50dfSAnju T if (!is_offset_in_branch_range(offset)) 2627c95d889SJordan Niethe return 1; 263aaddd3eaSMichael Ellerman 264aaddd3eaSMichael Ellerman /* Mask out the flags and target, so they don't step on each other. */ 26594afd069SJordan Niethe *instr = ppc_inst(0x48000000 | (flags & 0x3) | (offset & 0x03FFFFFC)); 266aaddd3eaSMichael Ellerman 2677c95d889SJordan Niethe return 0; 268aaddd3eaSMichael Ellerman } 269411781a2SMichael Ellerman 27094afd069SJordan Niethe int create_cond_branch(struct ppc_inst *instr, const struct ppc_inst *addr, 271411781a2SMichael Ellerman unsigned long target, int flags) 272411781a2SMichael Ellerman { 273411781a2SMichael Ellerman long offset; 274411781a2SMichael Ellerman 275411781a2SMichael Ellerman offset = target; 276411781a2SMichael Ellerman if (! (flags & BRANCH_ABSOLUTE)) 277411781a2SMichael Ellerman offset = offset - (unsigned long)addr; 278411781a2SMichael Ellerman 279411781a2SMichael Ellerman /* Check we can represent the target in the instruction format */ 280411781a2SMichael Ellerman if (offset < -0x8000 || offset > 0x7FFF || offset & 0x3) 2817c95d889SJordan Niethe return 1; 282411781a2SMichael Ellerman 283411781a2SMichael Ellerman /* Mask out the flags and target, so they don't step on each other. */ 28494afd069SJordan Niethe *instr = ppc_inst(0x40000000 | (flags & 0x3FF0003) | (offset & 0xFFFC)); 285411781a2SMichael Ellerman 2867c95d889SJordan Niethe return 0; 287411781a2SMichael Ellerman } 288411781a2SMichael Ellerman 28994afd069SJordan Niethe static unsigned int branch_opcode(struct ppc_inst instr) 290411781a2SMichael Ellerman { 2918094892dSJordan Niethe return ppc_inst_primary_opcode(instr) & 0x3F; 292411781a2SMichael Ellerman } 293411781a2SMichael Ellerman 29494afd069SJordan Niethe static int instr_is_branch_iform(struct ppc_inst instr) 295411781a2SMichael Ellerman { 296411781a2SMichael Ellerman return branch_opcode(instr) == 18; 297411781a2SMichael Ellerman } 298411781a2SMichael Ellerman 29994afd069SJordan Niethe static int instr_is_branch_bform(struct ppc_inst instr) 300411781a2SMichael Ellerman { 301411781a2SMichael Ellerman return branch_opcode(instr) == 16; 302411781a2SMichael Ellerman } 303411781a2SMichael Ellerman 30494afd069SJordan Niethe int instr_is_relative_branch(struct ppc_inst instr) 305411781a2SMichael Ellerman { 306777e26f0SJordan Niethe if (ppc_inst_val(instr) & BRANCH_ABSOLUTE) 307411781a2SMichael Ellerman return 0; 308411781a2SMichael Ellerman 309411781a2SMichael Ellerman return instr_is_branch_iform(instr) || instr_is_branch_bform(instr); 310411781a2SMichael Ellerman } 311411781a2SMichael Ellerman 31294afd069SJordan Niethe int instr_is_relative_link_branch(struct ppc_inst instr) 313b9eab08dSJosh Poimboeuf { 314777e26f0SJordan Niethe return instr_is_relative_branch(instr) && (ppc_inst_val(instr) & BRANCH_SET_LINK); 315b9eab08dSJosh Poimboeuf } 316b9eab08dSJosh Poimboeuf 31794afd069SJordan Niethe static unsigned long branch_iform_target(const struct ppc_inst *instr) 318411781a2SMichael Ellerman { 319411781a2SMichael Ellerman signed long imm; 320411781a2SMichael Ellerman 321777e26f0SJordan Niethe imm = ppc_inst_val(*instr) & 0x3FFFFFC; 322411781a2SMichael Ellerman 323411781a2SMichael Ellerman /* If the top bit of the immediate value is set this is negative */ 324411781a2SMichael Ellerman if (imm & 0x2000000) 325411781a2SMichael Ellerman imm -= 0x4000000; 326411781a2SMichael Ellerman 327777e26f0SJordan Niethe if ((ppc_inst_val(*instr) & BRANCH_ABSOLUTE) == 0) 328411781a2SMichael Ellerman imm += (unsigned long)instr; 329411781a2SMichael Ellerman 330411781a2SMichael Ellerman return (unsigned long)imm; 331411781a2SMichael Ellerman } 332411781a2SMichael Ellerman 33394afd069SJordan Niethe static unsigned long branch_bform_target(const struct ppc_inst *instr) 334411781a2SMichael Ellerman { 335411781a2SMichael Ellerman signed long imm; 336411781a2SMichael Ellerman 337777e26f0SJordan Niethe imm = ppc_inst_val(*instr) & 0xFFFC; 338411781a2SMichael Ellerman 339411781a2SMichael Ellerman /* If the top bit of the immediate value is set this is negative */ 340411781a2SMichael Ellerman if (imm & 0x8000) 341411781a2SMichael Ellerman imm -= 0x10000; 342411781a2SMichael Ellerman 343777e26f0SJordan Niethe if ((ppc_inst_val(*instr) & BRANCH_ABSOLUTE) == 0) 344411781a2SMichael Ellerman imm += (unsigned long)instr; 345411781a2SMichael Ellerman 346411781a2SMichael Ellerman return (unsigned long)imm; 347411781a2SMichael Ellerman } 348411781a2SMichael Ellerman 34994afd069SJordan Niethe unsigned long branch_target(const struct ppc_inst *instr) 350411781a2SMichael Ellerman { 351*f8faaffaSJordan Niethe if (instr_is_branch_iform(ppc_inst_read(instr))) 352411781a2SMichael Ellerman return branch_iform_target(instr); 353*f8faaffaSJordan Niethe else if (instr_is_branch_bform(ppc_inst_read(instr))) 354411781a2SMichael Ellerman return branch_bform_target(instr); 355411781a2SMichael Ellerman 356411781a2SMichael Ellerman return 0; 357411781a2SMichael Ellerman } 358411781a2SMichael Ellerman 35994afd069SJordan Niethe int instr_is_branch_to_addr(const struct ppc_inst *instr, unsigned long addr) 360411781a2SMichael Ellerman { 361*f8faaffaSJordan Niethe if (instr_is_branch_iform(ppc_inst_read(instr)) || 362*f8faaffaSJordan Niethe instr_is_branch_bform(ppc_inst_read(instr))) 363411781a2SMichael Ellerman return branch_target(instr) == addr; 364411781a2SMichael Ellerman 365411781a2SMichael Ellerman return 0; 366411781a2SMichael Ellerman } 367411781a2SMichael Ellerman 36894afd069SJordan Niethe int translate_branch(struct ppc_inst *instr, const struct ppc_inst *dest, 36994afd069SJordan Niethe const struct ppc_inst *src) 370411781a2SMichael Ellerman { 371411781a2SMichael Ellerman unsigned long target; 372411781a2SMichael Ellerman target = branch_target(src); 373411781a2SMichael Ellerman 374*f8faaffaSJordan Niethe if (instr_is_branch_iform(ppc_inst_read(src))) 375*f8faaffaSJordan Niethe return create_branch(instr, dest, target, 376*f8faaffaSJordan Niethe ppc_inst_val(ppc_inst_read(src))); 377*f8faaffaSJordan Niethe else if (instr_is_branch_bform(ppc_inst_read(src))) 378*f8faaffaSJordan Niethe return create_cond_branch(instr, dest, target, 379*f8faaffaSJordan Niethe ppc_inst_val(ppc_inst_read(src))); 380411781a2SMichael Ellerman 3817c95d889SJordan Niethe return 1; 382411781a2SMichael Ellerman } 383ae0dc736SMichael Ellerman 3841e8341aeSKevin Hao #ifdef CONFIG_PPC_BOOK3E_64 3851e8341aeSKevin Hao void __patch_exception(int exc, unsigned long addr) 3861e8341aeSKevin Hao { 3871e8341aeSKevin Hao extern unsigned int interrupt_base_book3e; 3881e8341aeSKevin Hao unsigned int *ibase = &interrupt_base_book3e; 3891e8341aeSKevin Hao 3901e8341aeSKevin Hao /* Our exceptions vectors start with a NOP and -then- a branch 3911e8341aeSKevin Hao * to deal with single stepping from userspace which stops on 3921e8341aeSKevin Hao * the second instruction. Thus we need to patch the second 3931e8341aeSKevin Hao * instruction of the exception, not the first one 3941e8341aeSKevin Hao */ 3951e8341aeSKevin Hao 39694afd069SJordan Niethe patch_branch((struct ppc_inst *)(ibase + (exc / 4) + 1), addr, 0); 3971e8341aeSKevin Hao } 3981e8341aeSKevin Hao #endif 399ae0dc736SMichael Ellerman 400ae0dc736SMichael Ellerman #ifdef CONFIG_CODE_PATCHING_SELFTEST 401ae0dc736SMichael Ellerman 402ae0dc736SMichael Ellerman static void __init test_trampoline(void) 403ae0dc736SMichael Ellerman { 404ae0dc736SMichael Ellerman asm ("nop;\n"); 405ae0dc736SMichael Ellerman } 406ae0dc736SMichael Ellerman 407ae0dc736SMichael Ellerman #define check(x) \ 408ae0dc736SMichael Ellerman if (!(x)) printk("code-patching: test failed at line %d\n", __LINE__); 409ae0dc736SMichael Ellerman 410ae0dc736SMichael Ellerman static void __init test_branch_iform(void) 411ae0dc736SMichael Ellerman { 4127c95d889SJordan Niethe int err; 41394afd069SJordan Niethe struct ppc_inst instr; 414ae0dc736SMichael Ellerman unsigned long addr; 415ae0dc736SMichael Ellerman 416ae0dc736SMichael Ellerman addr = (unsigned long)&instr; 417ae0dc736SMichael Ellerman 418ae0dc736SMichael Ellerman /* The simplest case, branch to self, no flags */ 41975346251SJordan Niethe check(instr_is_branch_iform(ppc_inst(0x48000000))); 420ae0dc736SMichael Ellerman /* All bits of target set, and flags */ 42175346251SJordan Niethe check(instr_is_branch_iform(ppc_inst(0x4bffffff))); 422ae0dc736SMichael Ellerman /* High bit of opcode set, which is wrong */ 42375346251SJordan Niethe check(!instr_is_branch_iform(ppc_inst(0xcbffffff))); 424ae0dc736SMichael Ellerman /* Middle bits of opcode set, which is wrong */ 42575346251SJordan Niethe check(!instr_is_branch_iform(ppc_inst(0x7bffffff))); 426ae0dc736SMichael Ellerman 427ae0dc736SMichael Ellerman /* Simplest case, branch to self with link */ 42875346251SJordan Niethe check(instr_is_branch_iform(ppc_inst(0x48000001))); 429ae0dc736SMichael Ellerman /* All bits of targets set */ 43075346251SJordan Niethe check(instr_is_branch_iform(ppc_inst(0x4bfffffd))); 431ae0dc736SMichael Ellerman /* Some bits of targets set */ 43275346251SJordan Niethe check(instr_is_branch_iform(ppc_inst(0x4bff00fd))); 433ae0dc736SMichael Ellerman /* Must be a valid branch to start with */ 43475346251SJordan Niethe check(!instr_is_branch_iform(ppc_inst(0x7bfffffd))); 435ae0dc736SMichael Ellerman 436ae0dc736SMichael Ellerman /* Absolute branch to 0x100 */ 43775346251SJordan Niethe instr = ppc_inst(0x48000103); 438ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, 0x100)); 439ae0dc736SMichael Ellerman /* Absolute branch to 0x420fc */ 44075346251SJordan Niethe instr = ppc_inst(0x480420ff); 441ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, 0x420fc)); 442ae0dc736SMichael Ellerman /* Maximum positive relative branch, + 20MB - 4B */ 44375346251SJordan Niethe instr = ppc_inst(0x49fffffc); 444ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, addr + 0x1FFFFFC)); 445ae0dc736SMichael Ellerman /* Smallest negative relative branch, - 4B */ 44675346251SJordan Niethe instr = ppc_inst(0x4bfffffc); 447ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, addr - 4)); 448ae0dc736SMichael Ellerman /* Largest negative relative branch, - 32 MB */ 44975346251SJordan Niethe instr = ppc_inst(0x4a000000); 450ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, addr - 0x2000000)); 451ae0dc736SMichael Ellerman 452ae0dc736SMichael Ellerman /* Branch to self, with link */ 4537c95d889SJordan Niethe err = create_branch(&instr, &instr, addr, BRANCH_SET_LINK); 454ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, addr)); 455ae0dc736SMichael Ellerman 456ae0dc736SMichael Ellerman /* Branch to self - 0x100, with link */ 4577c95d889SJordan Niethe err = create_branch(&instr, &instr, addr - 0x100, BRANCH_SET_LINK); 458ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, addr - 0x100)); 459ae0dc736SMichael Ellerman 460ae0dc736SMichael Ellerman /* Branch to self + 0x100, no link */ 4617c95d889SJordan Niethe err = create_branch(&instr, &instr, addr + 0x100, 0); 462ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, addr + 0x100)); 463ae0dc736SMichael Ellerman 464ae0dc736SMichael Ellerman /* Maximum relative negative offset, - 32 MB */ 4657c95d889SJordan Niethe err = create_branch(&instr, &instr, addr - 0x2000000, BRANCH_SET_LINK); 466ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, addr - 0x2000000)); 467ae0dc736SMichael Ellerman 468ae0dc736SMichael Ellerman /* Out of range relative negative offset, - 32 MB + 4*/ 4697c95d889SJordan Niethe err = create_branch(&instr, &instr, addr - 0x2000004, BRANCH_SET_LINK); 4707c95d889SJordan Niethe check(err); 471ae0dc736SMichael Ellerman 472ae0dc736SMichael Ellerman /* Out of range relative positive offset, + 32 MB */ 4737c95d889SJordan Niethe err = create_branch(&instr, &instr, addr + 0x2000000, BRANCH_SET_LINK); 4747c95d889SJordan Niethe check(err); 475ae0dc736SMichael Ellerman 476ae0dc736SMichael Ellerman /* Unaligned target */ 4777c95d889SJordan Niethe err = create_branch(&instr, &instr, addr + 3, BRANCH_SET_LINK); 4787c95d889SJordan Niethe check(err); 479ae0dc736SMichael Ellerman 480ae0dc736SMichael Ellerman /* Check flags are masked correctly */ 4817c95d889SJordan Niethe err = create_branch(&instr, &instr, addr, 0xFFFFFFFC); 482ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, addr)); 483217862d9SJordan Niethe check(ppc_inst_equal(instr, ppc_inst(0x48000000))); 484ae0dc736SMichael Ellerman } 485ae0dc736SMichael Ellerman 486ae0dc736SMichael Ellerman static void __init test_create_function_call(void) 487ae0dc736SMichael Ellerman { 48894afd069SJordan Niethe struct ppc_inst *iptr; 489ae0dc736SMichael Ellerman unsigned long dest; 49094afd069SJordan Niethe struct ppc_inst instr; 491ae0dc736SMichael Ellerman 492ae0dc736SMichael Ellerman /* Check we can create a function call */ 49394afd069SJordan Niethe iptr = (struct ppc_inst *)ppc_function_entry(test_trampoline); 494ae0dc736SMichael Ellerman dest = ppc_function_entry(test_create_function_call); 4957c95d889SJordan Niethe create_branch(&instr, iptr, dest, BRANCH_SET_LINK); 4967c95d889SJordan Niethe patch_instruction(iptr, instr); 497ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(iptr, dest)); 498ae0dc736SMichael Ellerman } 499ae0dc736SMichael Ellerman 500ae0dc736SMichael Ellerman static void __init test_branch_bform(void) 501ae0dc736SMichael Ellerman { 5027c95d889SJordan Niethe int err; 503ae0dc736SMichael Ellerman unsigned long addr; 50494afd069SJordan Niethe struct ppc_inst *iptr, instr; 50594afd069SJordan Niethe unsigned int flags; 506ae0dc736SMichael Ellerman 507ae0dc736SMichael Ellerman iptr = &instr; 508ae0dc736SMichael Ellerman addr = (unsigned long)iptr; 509ae0dc736SMichael Ellerman 510ae0dc736SMichael Ellerman /* The simplest case, branch to self, no flags */ 51175346251SJordan Niethe check(instr_is_branch_bform(ppc_inst(0x40000000))); 512ae0dc736SMichael Ellerman /* All bits of target set, and flags */ 51375346251SJordan Niethe check(instr_is_branch_bform(ppc_inst(0x43ffffff))); 514ae0dc736SMichael Ellerman /* High bit of opcode set, which is wrong */ 51575346251SJordan Niethe check(!instr_is_branch_bform(ppc_inst(0xc3ffffff))); 516ae0dc736SMichael Ellerman /* Middle bits of opcode set, which is wrong */ 51775346251SJordan Niethe check(!instr_is_branch_bform(ppc_inst(0x7bffffff))); 518ae0dc736SMichael Ellerman 519ae0dc736SMichael Ellerman /* Absolute conditional branch to 0x100 */ 52075346251SJordan Niethe instr = ppc_inst(0x43ff0103); 521ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, 0x100)); 522ae0dc736SMichael Ellerman /* Absolute conditional branch to 0x20fc */ 52375346251SJordan Niethe instr = ppc_inst(0x43ff20ff); 524ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, 0x20fc)); 525ae0dc736SMichael Ellerman /* Maximum positive relative conditional branch, + 32 KB - 4B */ 52675346251SJordan Niethe instr = ppc_inst(0x43ff7ffc); 527ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, addr + 0x7FFC)); 528ae0dc736SMichael Ellerman /* Smallest negative relative conditional branch, - 4B */ 52975346251SJordan Niethe instr = ppc_inst(0x43fffffc); 530ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, addr - 4)); 531ae0dc736SMichael Ellerman /* Largest negative relative conditional branch, - 32 KB */ 53275346251SJordan Niethe instr = ppc_inst(0x43ff8000); 533ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, addr - 0x8000)); 534ae0dc736SMichael Ellerman 535ae0dc736SMichael Ellerman /* All condition code bits set & link */ 536ae0dc736SMichael Ellerman flags = 0x3ff000 | BRANCH_SET_LINK; 537ae0dc736SMichael Ellerman 538ae0dc736SMichael Ellerman /* Branch to self */ 5397c95d889SJordan Niethe err = create_cond_branch(&instr, iptr, addr, flags); 540ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, addr)); 541ae0dc736SMichael Ellerman 542ae0dc736SMichael Ellerman /* Branch to self - 0x100 */ 5437c95d889SJordan Niethe err = create_cond_branch(&instr, iptr, addr - 0x100, flags); 544ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, addr - 0x100)); 545ae0dc736SMichael Ellerman 546ae0dc736SMichael Ellerman /* Branch to self + 0x100 */ 5477c95d889SJordan Niethe err = create_cond_branch(&instr, iptr, addr + 0x100, flags); 548ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, addr + 0x100)); 549ae0dc736SMichael Ellerman 550ae0dc736SMichael Ellerman /* Maximum relative negative offset, - 32 KB */ 5517c95d889SJordan Niethe err = create_cond_branch(&instr, iptr, addr - 0x8000, flags); 552ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, addr - 0x8000)); 553ae0dc736SMichael Ellerman 554ae0dc736SMichael Ellerman /* Out of range relative negative offset, - 32 KB + 4*/ 5557c95d889SJordan Niethe err = create_cond_branch(&instr, iptr, addr - 0x8004, flags); 5567c95d889SJordan Niethe check(err); 557ae0dc736SMichael Ellerman 558ae0dc736SMichael Ellerman /* Out of range relative positive offset, + 32 KB */ 5597c95d889SJordan Niethe err = create_cond_branch(&instr, iptr, addr + 0x8000, flags); 5607c95d889SJordan Niethe check(err); 561ae0dc736SMichael Ellerman 562ae0dc736SMichael Ellerman /* Unaligned target */ 5637c95d889SJordan Niethe err = create_cond_branch(&instr, iptr, addr + 3, flags); 5647c95d889SJordan Niethe check(err); 565ae0dc736SMichael Ellerman 566ae0dc736SMichael Ellerman /* Check flags are masked correctly */ 5677c95d889SJordan Niethe err = create_cond_branch(&instr, iptr, addr, 0xFFFFFFFC); 568ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(&instr, addr)); 569217862d9SJordan Niethe check(ppc_inst_equal(instr, ppc_inst(0x43FF0000))); 570ae0dc736SMichael Ellerman } 571ae0dc736SMichael Ellerman 572ae0dc736SMichael Ellerman static void __init test_translate_branch(void) 573ae0dc736SMichael Ellerman { 574ae0dc736SMichael Ellerman unsigned long addr; 57594afd069SJordan Niethe struct ppc_inst *p, *q; 57694afd069SJordan Niethe struct ppc_inst instr; 577ae0dc736SMichael Ellerman void *buf; 578ae0dc736SMichael Ellerman 579ae0dc736SMichael Ellerman buf = vmalloc(PAGE_ALIGN(0x2000000 + 1)); 580ae0dc736SMichael Ellerman check(buf); 581ae0dc736SMichael Ellerman if (!buf) 582ae0dc736SMichael Ellerman return; 583ae0dc736SMichael Ellerman 584ae0dc736SMichael Ellerman /* Simple case, branch to self moved a little */ 585ae0dc736SMichael Ellerman p = buf; 586ae0dc736SMichael Ellerman addr = (unsigned long)p; 587ae0dc736SMichael Ellerman patch_branch(p, addr, 0); 588ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(p, addr)); 589ae0dc736SMichael Ellerman q = p + 1; 5907c95d889SJordan Niethe translate_branch(&instr, q, p); 5917c95d889SJordan Niethe patch_instruction(q, instr); 592ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(q, addr)); 593ae0dc736SMichael Ellerman 594ae0dc736SMichael Ellerman /* Maximum negative case, move b . to addr + 32 MB */ 595ae0dc736SMichael Ellerman p = buf; 596ae0dc736SMichael Ellerman addr = (unsigned long)p; 597ae0dc736SMichael Ellerman patch_branch(p, addr, 0); 598ae0dc736SMichael Ellerman q = buf + 0x2000000; 5997c95d889SJordan Niethe translate_branch(&instr, q, p); 6007c95d889SJordan Niethe patch_instruction(q, instr); 601ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(p, addr)); 602ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(q, addr)); 603*f8faaffaSJordan Niethe check(ppc_inst_equal(ppc_inst_read(q), ppc_inst(0x4a000000))); 604ae0dc736SMichael Ellerman 605ae0dc736SMichael Ellerman /* Maximum positive case, move x to x - 32 MB + 4 */ 606ae0dc736SMichael Ellerman p = buf + 0x2000000; 607ae0dc736SMichael Ellerman addr = (unsigned long)p; 608ae0dc736SMichael Ellerman patch_branch(p, addr, 0); 609ae0dc736SMichael Ellerman q = buf + 4; 6107c95d889SJordan Niethe translate_branch(&instr, q, p); 6117c95d889SJordan Niethe patch_instruction(q, instr); 612ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(p, addr)); 613ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(q, addr)); 614*f8faaffaSJordan Niethe check(ppc_inst_equal(ppc_inst_read(q), ppc_inst(0x49fffffc))); 615ae0dc736SMichael Ellerman 616ae0dc736SMichael Ellerman /* Jump to x + 16 MB moved to x + 20 MB */ 617ae0dc736SMichael Ellerman p = buf; 618ae0dc736SMichael Ellerman addr = 0x1000000 + (unsigned long)buf; 619ae0dc736SMichael Ellerman patch_branch(p, addr, BRANCH_SET_LINK); 620ae0dc736SMichael Ellerman q = buf + 0x1400000; 6217c95d889SJordan Niethe translate_branch(&instr, q, p); 6227c95d889SJordan Niethe patch_instruction(q, instr); 623ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(p, addr)); 624ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(q, addr)); 625ae0dc736SMichael Ellerman 626ae0dc736SMichael Ellerman /* Jump to x + 16 MB moved to x - 16 MB + 4 */ 627ae0dc736SMichael Ellerman p = buf + 0x1000000; 628ae0dc736SMichael Ellerman addr = 0x2000000 + (unsigned long)buf; 629ae0dc736SMichael Ellerman patch_branch(p, addr, 0); 630ae0dc736SMichael Ellerman q = buf + 4; 6317c95d889SJordan Niethe translate_branch(&instr, q, p); 6327c95d889SJordan Niethe patch_instruction(q, instr); 633ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(p, addr)); 634ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(q, addr)); 635ae0dc736SMichael Ellerman 636ae0dc736SMichael Ellerman 637ae0dc736SMichael Ellerman /* Conditional branch tests */ 638ae0dc736SMichael Ellerman 639ae0dc736SMichael Ellerman /* Simple case, branch to self moved a little */ 640ae0dc736SMichael Ellerman p = buf; 641ae0dc736SMichael Ellerman addr = (unsigned long)p; 6427c95d889SJordan Niethe create_cond_branch(&instr, p, addr, 0); 6437c95d889SJordan Niethe patch_instruction(p, instr); 644ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(p, addr)); 645ae0dc736SMichael Ellerman q = p + 1; 6467c95d889SJordan Niethe translate_branch(&instr, q, p); 6477c95d889SJordan Niethe patch_instruction(q, instr); 648ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(q, addr)); 649ae0dc736SMichael Ellerman 650ae0dc736SMichael Ellerman /* Maximum negative case, move b . to addr + 32 KB */ 651ae0dc736SMichael Ellerman p = buf; 652ae0dc736SMichael Ellerman addr = (unsigned long)p; 6537c95d889SJordan Niethe create_cond_branch(&instr, p, addr, 0xFFFFFFFC); 6547c95d889SJordan Niethe patch_instruction(p, instr); 655ae0dc736SMichael Ellerman q = buf + 0x8000; 6567c95d889SJordan Niethe translate_branch(&instr, q, p); 6577c95d889SJordan Niethe patch_instruction(q, instr); 658ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(p, addr)); 659ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(q, addr)); 660*f8faaffaSJordan Niethe check(ppc_inst_equal(ppc_inst_read(q), ppc_inst(0x43ff8000))); 661ae0dc736SMichael Ellerman 662ae0dc736SMichael Ellerman /* Maximum positive case, move x to x - 32 KB + 4 */ 663ae0dc736SMichael Ellerman p = buf + 0x8000; 664ae0dc736SMichael Ellerman addr = (unsigned long)p; 6657c95d889SJordan Niethe create_cond_branch(&instr, p, addr, 0xFFFFFFFC); 6667c95d889SJordan Niethe patch_instruction(p, instr); 667ae0dc736SMichael Ellerman q = buf + 4; 6687c95d889SJordan Niethe translate_branch(&instr, q, p); 6697c95d889SJordan Niethe patch_instruction(q, instr); 670ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(p, addr)); 671ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(q, addr)); 672*f8faaffaSJordan Niethe check(ppc_inst_equal(ppc_inst_read(q), ppc_inst(0x43ff7ffc))); 673ae0dc736SMichael Ellerman 674ae0dc736SMichael Ellerman /* Jump to x + 12 KB moved to x + 20 KB */ 675ae0dc736SMichael Ellerman p = buf; 676ae0dc736SMichael Ellerman addr = 0x3000 + (unsigned long)buf; 6777c95d889SJordan Niethe create_cond_branch(&instr, p, addr, BRANCH_SET_LINK); 6787c95d889SJordan Niethe patch_instruction(p, instr); 679ae0dc736SMichael Ellerman q = buf + 0x5000; 6807c95d889SJordan Niethe translate_branch(&instr, q, p); 6817c95d889SJordan Niethe patch_instruction(q, instr); 682ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(p, addr)); 683ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(q, addr)); 684ae0dc736SMichael Ellerman 685ae0dc736SMichael Ellerman /* Jump to x + 8 KB moved to x - 8 KB + 4 */ 686ae0dc736SMichael Ellerman p = buf + 0x2000; 687ae0dc736SMichael Ellerman addr = 0x4000 + (unsigned long)buf; 6887c95d889SJordan Niethe create_cond_branch(&instr, p, addr, 0); 6897c95d889SJordan Niethe patch_instruction(p, instr); 690ae0dc736SMichael Ellerman q = buf + 4; 6917c95d889SJordan Niethe translate_branch(&instr, q, p); 6927c95d889SJordan Niethe patch_instruction(q, instr); 693ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(p, addr)); 694ae0dc736SMichael Ellerman check(instr_is_branch_to_addr(q, addr)); 695ae0dc736SMichael Ellerman 696ae0dc736SMichael Ellerman /* Free the buffer we were using */ 697ae0dc736SMichael Ellerman vfree(buf); 698ae0dc736SMichael Ellerman } 699ae0dc736SMichael Ellerman 700ae0dc736SMichael Ellerman static int __init test_code_patching(void) 701ae0dc736SMichael Ellerman { 702ae0dc736SMichael Ellerman printk(KERN_DEBUG "Running code patching self-tests ...\n"); 703ae0dc736SMichael Ellerman 704ae0dc736SMichael Ellerman test_branch_iform(); 705ae0dc736SMichael Ellerman test_branch_bform(); 706ae0dc736SMichael Ellerman test_create_function_call(); 707ae0dc736SMichael Ellerman test_translate_branch(); 708ae0dc736SMichael Ellerman 709ae0dc736SMichael Ellerman return 0; 710ae0dc736SMichael Ellerman } 711ae0dc736SMichael Ellerman late_initcall(test_code_patching); 712ae0dc736SMichael Ellerman 713ae0dc736SMichael Ellerman #endif /* CONFIG_CODE_PATCHING_SELFTEST */ 714