1.. SPDX-License-Identifier: GPL-2.0 2 3================================ 4Review checklist for kvm patches 5================================ 6 71. The patch must follow Documentation/process/coding-style.rst and 8 Documentation/process/submitting-patches.rst. 9 102. Patches should be against kvm.git master branch. 11 123. If the patch introduces or modifies a new userspace API: 13 - the API must be documented in Documentation/virt/kvm/api.rst 14 - the API must be discoverable using KVM_CHECK_EXTENSION 15 164. New state must include support for save/restore. 17 185. New features must default to off (userspace should explicitly request them). 19 Performance improvements can and should default to on. 20 216. New cpu features should be exposed via KVM_GET_SUPPORTED_CPUID2 22 237. Emulator changes should be accompanied by unit tests for qemu-kvm.git 24 kvm/test directory. 25 268. Changes should be vendor neutral when possible. Changes to common code 27 are better than duplicating changes to vendor code. 28 299. Similarly, prefer changes to arch independent code than to arch dependent 30 code. 31 3210. User/kernel interfaces and guest/host interfaces must be 64-bit clean 33 (all variables and sizes naturally aligned on 64-bit; use specific types 34 only - u64 rather than ulong). 35 3611. New guest visible features must either be documented in a hardware manual 37 or be accompanied by documentation. 38 3912. Features must be robust against reset and kexec - for example, shared 40 host/guest memory must be unshared to prevent the host from writing to 41 guest memory that the guest has not reserved for this purpose. 42