1.. _todo: 2 3========= 4TODO list 5========= 6 7This section contains a list of smaller janitorial tasks in the kernel DRM 8graphics subsystem useful as newbie projects. Or for slow rainy days. 9 10Difficulty 11---------- 12 13To make it easier task are categorized into different levels: 14 15Starter: Good tasks to get started with the DRM subsystem. 16 17Intermediate: Tasks which need some experience with working in the DRM 18subsystem, or some specific GPU/display graphics knowledge. For debugging issue 19it's good to have the relevant hardware (or a virtual driver set up) available 20for testing. 21 22Advanced: Tricky tasks that need fairly good understanding of the DRM subsystem 23and graphics topics. Generally need the relevant hardware for development and 24testing. 25 26Subsystem-wide refactorings 27=========================== 28 29Remove custom dumb_map_offset implementations 30--------------------------------------------- 31 32All GEM based drivers should be using drm_gem_create_mmap_offset() instead. 33Audit each individual driver, make sure it'll work with the generic 34implementation (there's lots of outdated locking leftovers in various 35implementations), and then remove it. 36 37Contact: Daniel Vetter, respective driver maintainers 38 39Level: Intermediate 40 41Convert existing KMS drivers to atomic modesetting 42-------------------------------------------------- 43 443.19 has the atomic modeset interfaces and helpers, so drivers can now be 45converted over. Modern compositors like Wayland or Surfaceflinger on Android 46really want an atomic modeset interface, so this is all about the bright 47future. 48 49There is a conversion guide for atomic and all you need is a GPU for a 50non-converted driver (again virtual HW drivers for KVM are still all 51suitable). 52 53As part of this drivers also need to convert to universal plane (which means 54exposing primary & cursor as proper plane objects). But that's much easier to 55do by directly using the new atomic helper driver callbacks. 56 57Contact: Daniel Vetter, respective driver maintainers 58 59Level: Advanced 60 61Clean up the clipped coordination confusion around planes 62--------------------------------------------------------- 63 64We have a helper to get this right with drm_plane_helper_check_update(), but 65it's not consistently used. This should be fixed, preferrably in the atomic 66helpers (and drivers then moved over to clipped coordinates). Probably the 67helper should also be moved from drm_plane_helper.c to the atomic helpers, to 68avoid confusion - the other helpers in that file are all deprecated legacy 69helpers. 70 71Contact: Ville Syrjälä, Daniel Vetter, driver maintainers 72 73Level: Advanced 74 75Improve plane atomic_check helpers 76---------------------------------- 77 78Aside from the clipped coordinates right above there's a few suboptimal things 79with the current helpers: 80 81- drm_plane_helper_funcs->atomic_check gets called for enabled or disabled 82 planes. At best this seems to confuse drivers, worst it means they blow up 83 when the plane is disabled without the CRTC. The only special handling is 84 resetting values in the plane state structures, which instead should be moved 85 into the drm_plane_funcs->atomic_duplicate_state functions. 86 87- Once that's done, helpers could stop calling ->atomic_check for disabled 88 planes. 89 90- Then we could go through all the drivers and remove the more-or-less confused 91 checks for plane_state->fb and plane_state->crtc. 92 93Contact: Daniel Vetter 94 95Level: Advanced 96 97Convert early atomic drivers to async commit helpers 98---------------------------------------------------- 99 100For the first year the atomic modeset helpers didn't support asynchronous / 101nonblocking commits, and every driver had to hand-roll them. This is fixed 102now, but there's still a pile of existing drivers that easily could be 103converted over to the new infrastructure. 104 105One issue with the helpers is that they require that drivers handle completion 106events for atomic commits correctly. But fixing these bugs is good anyway. 107 108Somewhat related is the legacy_cursor_update hack, which should be replaced with 109the new atomic_async_check/commit functionality in the helpers in drivers that 110still look at that flag. 111 112Contact: Daniel Vetter, respective driver maintainers 113 114Level: Advanced 115 116Fallout from atomic KMS 117----------------------- 118 119``drm_atomic_helper.c`` provides a batch of functions which implement legacy 120IOCTLs on top of the new atomic driver interface. Which is really nice for 121gradual conversion of drivers, but unfortunately the semantic mismatches are 122a bit too severe. So there's some follow-up work to adjust the function 123interfaces to fix these issues: 124 125* atomic needs the lock acquire context. At the moment that's passed around 126 implicitly with some horrible hacks, and it's also allocate with 127 ``GFP_NOFAIL`` behind the scenes. All legacy paths need to start allocating 128 the acquire context explicitly on stack and then also pass it down into 129 drivers explicitly so that the legacy-on-atomic functions can use them. 130 131 Except for some driver code this is done. This task should be finished by 132 adding WARN_ON(!drm_drv_uses_atomic_modeset) in drm_modeset_lock_all(). 133 134* A bunch of the vtable hooks are now in the wrong place: DRM has a split 135 between core vfunc tables (named ``drm_foo_funcs``), which are used to 136 implement the userspace ABI. And then there's the optional hooks for the 137 helper libraries (name ``drm_foo_helper_funcs``), which are purely for 138 internal use. Some of these hooks should be move from ``_funcs`` to 139 ``_helper_funcs`` since they are not part of the core ABI. There's a 140 ``FIXME`` comment in the kerneldoc for each such case in ``drm_crtc.h``. 141 142Contact: Daniel Vetter 143 144Level: Intermediate 145 146Get rid of dev->struct_mutex from GEM drivers 147--------------------------------------------- 148 149``dev->struct_mutex`` is the Big DRM Lock from legacy days and infested 150everything. Nowadays in modern drivers the only bit where it's mandatory is 151serializing GEM buffer object destruction. Which unfortunately means drivers 152have to keep track of that lock and either call ``unreference`` or 153``unreference_locked`` depending upon context. 154 155Core GEM doesn't have a need for ``struct_mutex`` any more since kernel 4.8, 156and there's a GEM object ``free`` callback for any drivers which are 157entirely ``struct_mutex`` free. 158 159For drivers that need ``struct_mutex`` it should be replaced with a driver- 160private lock. The tricky part is the BO free functions, since those can't 161reliably take that lock any more. Instead state needs to be protected with 162suitable subordinate locks or some cleanup work pushed to a worker thread. For 163performance-critical drivers it might also be better to go with a more 164fine-grained per-buffer object and per-context lockings scheme. Currently only 165the ``msm`` and `i915` drivers use ``struct_mutex``. 166 167Contact: Daniel Vetter, respective driver maintainers 168 169Level: Advanced 170 171Convert logging to drm_* functions with drm_device paramater 172------------------------------------------------------------ 173 174For drivers which could have multiple instances, it is necessary to 175differentiate between which is which in the logs. Since DRM_INFO/WARN/ERROR 176don't do this, drivers used dev_info/warn/err to make this differentiation. We 177now have drm_* variants of the drm print functions, so we can start to convert 178those drivers back to using drm-formatted specific log messages. 179 180Before you start this conversion please contact the relevant maintainers to make 181sure your work will be merged - not everyone agrees that the DRM dmesg macros 182are better. 183 184Contact: Sean Paul, Maintainer of the driver you plan to convert 185 186Level: Starter 187 188Convert drivers to use simple modeset suspend/resume 189---------------------------------------------------- 190 191Most drivers (except i915 and nouveau) that use 192drm_atomic_helper_suspend/resume() can probably be converted to use 193drm_mode_config_helper_suspend/resume(). Also there's still open-coded version 194of the atomic suspend/resume code in older atomic modeset drivers. 195 196Contact: Maintainer of the driver you plan to convert 197 198Level: Intermediate 199 200Convert drivers to use drm_fbdev_generic_setup() 201------------------------------------------------ 202 203Most drivers can use drm_fbdev_generic_setup(). Driver have to implement 204atomic modesetting and GEM vmap support. Historically, generic fbdev emulation 205expected the framebuffer in system memory or system-like memory. By employing 206struct dma_buf_map, drivers with frambuffers in I/O memory can be supported 207as well. 208 209Contact: Maintainer of the driver you plan to convert 210 211Level: Intermediate 212 213Reimplement functions in drm_fbdev_fb_ops without fbdev 214------------------------------------------------------- 215 216A number of callback functions in drm_fbdev_fb_ops could benefit from 217being rewritten without dependencies on the fbdev module. Some of the 218helpers could further benefit from using struct dma_buf_map instead of 219raw pointers. 220 221Contact: Thomas Zimmermann <tzimmermann@suse.de>, Daniel Vetter 222 223Level: Advanced 224 225 226drm_framebuffer_funcs and drm_mode_config_funcs.fb_create cleanup 227----------------------------------------------------------------- 228 229A lot more drivers could be switched over to the drm_gem_framebuffer helpers. 230Various hold-ups: 231 232- Need to switch over to the generic dirty tracking code using 233 drm_atomic_helper_dirtyfb first (e.g. qxl). 234 235- Need to switch to drm_fbdev_generic_setup(), otherwise a lot of the custom fb 236 setup code can't be deleted. 237 238- Many drivers wrap drm_gem_fb_create() only to check for valid formats. For 239 atomic drivers we could check for valid formats by calling 240 drm_plane_check_pixel_format() against all planes, and pass if any plane 241 supports the format. For non-atomic that's not possible since like the format 242 list for the primary plane is fake and we'd therefor reject valid formats. 243 244- Many drivers subclass drm_framebuffer, we'd need a embedding compatible 245 version of the varios drm_gem_fb_create functions. Maybe called 246 drm_gem_fb_create/_with_dirty/_with_funcs as needed. 247 248Contact: Daniel Vetter 249 250Level: Intermediate 251 252Clean up mmap forwarding 253------------------------ 254 255A lot of drivers forward gem mmap calls to dma-buf mmap for imported buffers. 256And also a lot of them forward dma-buf mmap to the gem mmap implementations. 257There's drm_gem_prime_mmap() for this now, but still needs to be rolled out. 258 259Contact: Daniel Vetter 260 261Level: Intermediate 262 263Generic fbdev defio support 264--------------------------- 265 266The defio support code in the fbdev core has some very specific requirements, 267which means drivers need to have a special framebuffer for fbdev. The main 268issue is that it uses some fields in struct page itself, which breaks shmem 269gem objects (and other things). To support defio, affected drivers require 270the use of a shadow buffer, which may add CPU and memory overhead. 271 272Possible solution would be to write our own defio mmap code in the drm fbdev 273emulation. It would need to fully wrap the existing mmap ops, forwarding 274everything after it has done the write-protect/mkwrite trickery: 275 276- In the drm_fbdev_fb_mmap helper, if we need defio, change the 277 default page prots to write-protected with something like this:: 278 279 vma->vm_page_prot = pgprot_wrprotect(vma->vm_page_prot); 280 281- Set the mkwrite and fsync callbacks with similar implementions to the core 282 fbdev defio stuff. These should all work on plain ptes, they don't actually 283 require a struct page. uff. These should all work on plain ptes, they don't 284 actually require a struct page. 285 286- Track the dirty pages in a separate structure (bitfield with one bit per page 287 should work) to avoid clobbering struct page. 288 289Might be good to also have some igt testcases for this. 290 291Contact: Daniel Vetter, Noralf Tronnes 292 293Level: Advanced 294 295idr_init_base() 296--------------- 297 298DRM core&drivers uses a lot of idr (integer lookup directories) for mapping 299userspace IDs to internal objects, and in most places ID=0 means NULL and hence 300is never used. Switching to idr_init_base() for these would make the idr more 301efficient. 302 303Contact: Daniel Vetter 304 305Level: Starter 306 307struct drm_gem_object_funcs 308--------------------------- 309 310GEM objects can now have a function table instead of having the callbacks on the 311DRM driver struct. This is now the preferred way. Callbacks in drivers have been 312converted, except for struct drm_driver.gem_prime_mmap. 313 314Level: Intermediate 315 316Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate 317--------------------------------------------------------- 318 319For cases where drivers are attempting to grab the modeset locks with a local 320acquire context. Replace the boilerplate code surrounding 321drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and 322DRM_MODESET_LOCK_ALL_END() instead. 323 324This should also be done for all places where drm_modeset_lock_all() is still 325used. 326 327As a reference, take a look at the conversions already completed in drm core. 328 329Contact: Sean Paul, respective driver maintainers 330 331Level: Starter 332 333Rename CMA helpers to DMA helpers 334--------------------------------- 335 336CMA (standing for contiguous memory allocator) is really a bit an accident of 337what these were used for first, a much better name would be DMA helpers. In the 338text these should even be called coherent DMA memory helpers (so maybe CDM, but 339no one knows what that means) since underneath they just use dma_alloc_coherent. 340 341Contact: Laurent Pinchart, Daniel Vetter 342 343Level: Intermediate (mostly because it is a huge tasks without good partial 344milestones, not technically itself that challenging) 345 346connector register/unregister fixes 347----------------------------------- 348 349- For most connectors it's a no-op to call drm_connector_register/unregister 350 directly from driver code, drm_dev_register/unregister take care of this 351 already. We can remove all of them. 352 353- For dp drivers it's a bit more a mess, since we need the connector to be 354 registered when calling drm_dp_aux_register. Fix this by instead calling 355 drm_dp_aux_init, and moving the actual registering into a late_register 356 callback as recommended in the kerneldoc. 357 358Level: Intermediate 359 360Remove load/unload callbacks from all non-DRIVER_LEGACY drivers 361--------------------------------------------------------------- 362 363The load/unload callbacks in struct &drm_driver are very much midlayers, plus 364for historical reasons they get the ordering wrong (and we can't fix that) 365between setting up the &drm_driver structure and calling drm_dev_register(). 366 367- Rework drivers to no longer use the load/unload callbacks, directly coding the 368 load/unload sequence into the driver's probe function. 369 370- Once all non-DRIVER_LEGACY drivers are converted, disallow the load/unload 371 callbacks for all modern drivers. 372 373Contact: Daniel Vetter 374 375Level: Intermediate 376 377Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi 378--------------------------------------------------------------- 379 380Once EDID is parsed, the monitor HDMI support information is available through 381drm_display_info.is_hdmi. Many drivers still call drm_detect_hdmi_monitor() to 382retrieve the same information, which is less efficient. 383 384Audit each individual driver calling drm_detect_hdmi_monitor() and switch to 385drm_display_info.is_hdmi if applicable. 386 387Contact: Laurent Pinchart, respective driver maintainers 388 389Level: Intermediate 390 391Consolidate custom driver modeset properties 392-------------------------------------------- 393 394Before atomic modeset took place, many drivers where creating their own 395properties. Among other things, atomic brought the requirement that custom, 396driver specific properties should not be used. 397 398For this task, we aim to introduce core helpers or reuse the existing ones 399if available: 400 401A quick, unconfirmed, examples list. 402 403Introduce core helpers: 404- audio (amdgpu, intel, gma500, radeon) 405- brightness, contrast, etc (armada, nouveau) - overlay only (?) 406- broadcast rgb (gma500, intel) 407- colorkey (armada, nouveau, rcar) - overlay only (?) 408- dither (amdgpu, nouveau, radeon) - varies across drivers 409- underscan family (amdgpu, radeon, nouveau) 410 411Already in core: 412- colorspace (sti) 413- tv format names, enhancements (gma500, intel) 414- tv overscan, margins, etc. (gma500, intel) 415- zorder (omapdrm) - same as zpos (?) 416 417 418Contact: Emil Velikov, respective driver maintainers 419 420Level: Intermediate 421 422Plumb drm_atomic_state all over 423------------------------------- 424 425Currently various atomic functions take just a single or a handful of 426object states (eg. plane state). While that single object state can 427suffice for some simple cases, we often have to dig out additional 428object states for dealing with various dependencies between the individual 429objects or the hardware they represent. The process of digging out the 430additional states is rather non-intuitive and error prone. 431 432To fix that most functions should rather take the overall 433drm_atomic_state as one of their parameters. The other parameters 434would generally be the object(s) we mainly want to interact with. 435 436For example, instead of 437 438.. code-block:: c 439 440 int (*atomic_check)(struct drm_plane *plane, struct drm_plane_state *state); 441 442we would have something like 443 444.. code-block:: c 445 446 int (*atomic_check)(struct drm_plane *plane, struct drm_atomic_state *state); 447 448The implementation can then trivially gain access to any required object 449state(s) via drm_atomic_get_plane_state(), drm_atomic_get_new_plane_state(), 450drm_atomic_get_old_plane_state(), and their equivalents for 451other object types. 452 453Additionally many drivers currently access the object->state pointer 454directly in their commit functions. That is not going to work if we 455eg. want to allow deeper commit pipelines as those pointers could 456then point to the states corresponding to a future commit instead of 457the current commit we're trying to process. Also non-blocking commits 458execute locklessly so there are serious concerns with dereferencing 459the object->state pointers without holding the locks that protect them. 460Use of drm_atomic_get_new_plane_state(), drm_atomic_get_old_plane_state(), 461etc. avoids these problems as well since they relate to a specific 462commit via the passed in drm_atomic_state. 463 464Contact: Ville Syrjälä, Daniel Vetter 465 466Level: Intermediate 467 468Use struct dma_buf_map throughout codebase 469------------------------------------------ 470 471Pointers to shared device memory are stored in struct dma_buf_map. Each 472instance knows whether it refers to system or I/O memory. Most of the DRM-wide 473interface have been converted to use struct dma_buf_map, but implementations 474often still use raw pointers. 475 476The task is to use struct dma_buf_map where it makes sense. 477 478* Memory managers should use struct dma_buf_map for dma-buf-imported buffers. 479* TTM might benefit from using struct dma_buf_map internally. 480* Framebuffer copying and blitting helpers should operate on struct dma_buf_map. 481 482Contact: Thomas Zimmermann <tzimmermann@suse.de>, Christian König, Daniel Vetter 483 484Level: Intermediate 485 486 487Core refactorings 488================= 489 490Make panic handling work 491------------------------ 492 493This is a really varied tasks with lots of little bits and pieces: 494 495* The panic path can't be tested currently, leading to constant breaking. The 496 main issue here is that panics can be triggered from hardirq contexts and 497 hence all panic related callback can run in hardirq context. It would be 498 awesome if we could test at least the fbdev helper code and driver code by 499 e.g. trigger calls through drm debugfs files. hardirq context could be 500 achieved by using an IPI to the local processor. 501 502* There's a massive confusion of different panic handlers. DRM fbdev emulation 503 helpers have one, but on top of that the fbcon code itself also has one. We 504 need to make sure that they stop fighting over each another. 505 506* ``drm_can_sleep()`` is a mess. It hides real bugs in normal operations and 507 isn't a full solution for panic paths. We need to make sure that it only 508 returns true if there's a panic going on for real, and fix up all the 509 fallout. 510 511* The panic handler must never sleep, which also means it can't ever 512 ``mutex_lock()``. Also it can't grab any other lock unconditionally, not 513 even spinlocks (because NMI and hardirq can panic too). We need to either 514 make sure to not call such paths, or trylock everything. Really tricky. 515 516* For the above locking troubles reasons it's pretty much impossible to 517 attempt a synchronous modeset from panic handlers. The only thing we could 518 try to achive is an atomic ``set_base`` of the primary plane, and hope that 519 it shows up. Everything else probably needs to be delayed to some worker or 520 something else which happens later on. Otherwise it just kills the box 521 harder, prevent the panic from going out on e.g. netconsole. 522 523* There's also proposal for a simplied DRM console instead of the full-blown 524 fbcon and DRM fbdev emulation. Any kind of panic handling tricks should 525 obviously work for both console, in case we ever get kmslog merged. 526 527Contact: Daniel Vetter 528 529Level: Advanced 530 531Clean up the debugfs support 532---------------------------- 533 534There's a bunch of issues with it: 535 536- The drm_info_list ->show() function doesn't even bother to cast to the drm 537 structure for you. This is lazy. 538 539- We probably want to have some support for debugfs files on crtc/connectors and 540 maybe other kms objects directly in core. There's even drm_print support in 541 the funcs for these objects to dump kms state, so it's all there. And then the 542 ->show() functions should obviously give you a pointer to the right object. 543 544- The drm_info_list stuff is centered on drm_minor instead of drm_device. For 545 anything we want to print drm_device (or maybe drm_file) is the right thing. 546 547- The drm_driver->debugfs_init hooks we have is just an artifact of the old 548 midlayered load sequence. DRM debugfs should work more like sysfs, where you 549 can create properties/files for an object anytime you want, and the core 550 takes care of publishing/unpuplishing all the files at register/unregister 551 time. Drivers shouldn't need to worry about these technicalities, and fixing 552 this (together with the drm_minor->drm_device move) would allow us to remove 553 debugfs_init. 554 555Contact: Daniel Vetter 556 557Level: Intermediate 558 559KMS cleanups 560------------ 561 562Some of these date from the very introduction of KMS in 2008 ... 563 564- Make ->funcs and ->helper_private vtables optional. There's a bunch of empty 565 function tables in drivers, but before we can remove them we need to make sure 566 that all the users in helpers and drivers do correctly check for a NULL 567 vtable. 568 569- Cleanup up the various ->destroy callbacks. A lot of them just wrapt the 570 drm_*_cleanup implementations and can be removed. Some tack a kfree() at the 571 end, for which we could add drm_*_cleanup_kfree(). And then there's the (for 572 historical reasons) misnamed drm_primary_helper_destroy() function. 573 574Level: Intermediate 575 576Better Testing 577============== 578 579Enable trinity for DRM 580---------------------- 581 582And fix up the fallout. Should be really interesting ... 583 584Level: Advanced 585 586Make KMS tests in i-g-t generic 587------------------------------- 588 589The i915 driver team maintains an extensive testsuite for the i915 DRM driver, 590including tons of testcases for corner-cases in the modesetting API. It would 591be awesome if those tests (at least the ones not relying on Intel-specific GEM 592features) could be made to run on any KMS driver. 593 594Basic work to run i-g-t tests on non-i915 is done, what's now missing is mass- 595converting things over. For modeset tests we also first need a bit of 596infrastructure to use dumb buffers for untiled buffers, to be able to run all 597the non-i915 specific modeset tests. 598 599Level: Advanced 600 601Extend virtual test driver (VKMS) 602--------------------------------- 603 604See the documentation of :ref:`VKMS <vkms>` for more details. This is an ideal 605internship task, since it only requires a virtual machine and can be sized to 606fit the available time. 607 608Contact: Daniel Vetter 609 610Level: See details 611 612Backlight Refactoring 613--------------------- 614 615Backlight drivers have a triple enable/disable state, which is a bit overkill. 616Plan to fix this: 617 6181. Roll out backlight_enable() and backlight_disable() helpers everywhere. This 619 has started already. 6202. In all, only look at one of the three status bits set by the above helpers. 6213. Remove the other two status bits. 622 623Contact: Daniel Vetter 624 625Level: Intermediate 626 627Driver Specific 628=============== 629 630AMD DC Display Driver 631--------------------- 632 633AMD DC is the display driver for AMD devices starting with Vega. There has been 634a bunch of progress cleaning it up but there's still plenty of work to be done. 635 636See drivers/gpu/drm/amd/display/TODO for tasks. 637 638Contact: Harry Wentland, Alex Deucher 639 640Bootsplash 641========== 642 643There is support in place now for writing internal DRM clients making it 644possible to pick up the bootsplash work that was rejected because it was written 645for fbdev. 646 647- [v6,8/8] drm/client: Hack: Add bootsplash example 648 https://patchwork.freedesktop.org/patch/306579/ 649 650- [RFC PATCH v2 00/13] Kernel based bootsplash 651 https://lkml.org/lkml/2017/12/13/764 652 653Contact: Sam Ravnborg 654 655Level: Advanced 656 657Outside DRM 658=========== 659 660Convert fbdev drivers to DRM 661---------------------------- 662 663There are plenty of fbdev drivers for older hardware. Some hwardware has 664become obsolete, but some still provides good(-enough) framebuffers. The 665drivers that are still useful should be converted to DRM and afterwards 666removed from fbdev. 667 668Very simple fbdev drivers can best be converted by starting with a new 669DRM driver. Simple KMS helpers and SHMEM should be able to handle any 670existing hardware. The new driver's call-back functions are filled from 671existing fbdev code. 672 673More complex fbdev drivers can be refactored step-by-step into a DRM 674driver with the help of the DRM fbconv helpers. [1] These helpers provide 675the transition layer between the DRM core infrastructure and the fbdev 676driver interface. Create a new DRM driver on top of the fbconv helpers, 677copy over the fbdev driver, and hook it up to the DRM code. Examples for 678several fbdev drivers are available at [1] and a tutorial of this process 679available at [2]. The result is a primitive DRM driver that can run X11 680and Weston. 681 682 - [1] https://gitlab.freedesktop.org/tzimmermann/linux/tree/fbconv 683 - [2] https://gitlab.freedesktop.org/tzimmermann/linux/blob/fbconv/drivers/gpu/drm/drm_fbconv_helper.c 684 685Contact: Thomas Zimmermann <tzimmermann@suse.de> 686 687Level: Advanced 688