1 /* 2 * Copyright (c) 1982, 1986, 1988, 1993 3 * The Regents of the University of California. All rights reserved. 4 * 5 * Redistribution and use in source and binary forms, with or without 6 * modification, are permitted provided that the following conditions 7 * are met: 8 * 1. Redistributions of source code must retain the above copyright 9 * notice, this list of conditions and the following disclaimer. 10 * 2. Redistributions in binary form must reproduce the above copyright 11 * notice, this list of conditions and the following disclaimer in the 12 * documentation and/or other materials provided with the distribution. 13 * 4. Neither the name of the University nor the names of its contributors 14 * may be used to endorse or promote products derived from this software 15 * without specific prior written permission. 16 * 17 * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND 18 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 19 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE 20 * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE 21 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL 22 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS 23 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) 24 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT 25 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY 26 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF 27 * SUCH DAMAGE. 28 * 29 * $FreeBSD$ 30 */ 31 32 #include "opt_inet.h" 33 #include "opt_ipfw.h" 34 #include "opt_ipdivert.h" 35 #include "opt_ipsec.h" 36 #include "opt_mac.h" 37 38 #ifndef INET 39 #error "IPDIVERT requires INET." 40 #endif 41 42 #include <sys/param.h> 43 #include <sys/kernel.h> 44 #include <sys/lock.h> 45 #include <sys/malloc.h> 46 #include <sys/mac.h> 47 #include <sys/mbuf.h> 48 #include <sys/proc.h> 49 #include <sys/protosw.h> 50 #include <sys/signalvar.h> 51 #include <sys/socket.h> 52 #include <sys/socketvar.h> 53 #include <sys/sx.h> 54 #include <sys/sysctl.h> 55 #include <sys/systm.h> 56 57 #include <vm/uma.h> 58 59 #include <net/if.h> 60 #include <net/route.h> 61 62 #include <netinet/in.h> 63 #include <netinet/in_pcb.h> 64 #include <netinet/in_systm.h> 65 #include <netinet/in_var.h> 66 #include <netinet/ip.h> 67 #include <netinet/ip_divert.h> 68 #include <netinet/ip_var.h> 69 70 /* 71 * Divert sockets 72 */ 73 74 /* 75 * Allocate enough space to hold a full IP packet 76 */ 77 #define DIVSNDQ (65536 + 100) 78 #define DIVRCVQ (65536 + 100) 79 80 /* 81 * Divert sockets work in conjunction with ipfw, see the divert(4) 82 * manpage for features. 83 * Internally, packets selected by ipfw in ip_input() or ip_output(), 84 * and never diverted before, are passed to the input queue of the 85 * divert socket with a given 'divert_port' number (as specified in 86 * the matching ipfw rule), and they are tagged with a 16 bit cookie 87 * (representing the rule number of the matching ipfw rule), which 88 * is passed to process reading from the socket. 89 * 90 * Packets written to the divert socket are again tagged with a cookie 91 * (usually the same as above) and a destination address. 92 * If the destination address is INADDR_ANY then the packet is 93 * treated as outgoing and sent to ip_output(), otherwise it is 94 * treated as incoming and sent to ip_input(). 95 * In both cases, the packet is tagged with the cookie. 96 * 97 * On reinjection, processing in ip_input() and ip_output() 98 * will be exactly the same as for the original packet, except that 99 * ipfw processing will start at the rule number after the one 100 * written in the cookie (so, tagging a packet with a cookie of 0 101 * will cause it to be effectively considered as a standard packet). 102 */ 103 104 /* Internal variables */ 105 static struct inpcbhead divcb; 106 static struct inpcbinfo divcbinfo; 107 108 static u_long div_sendspace = DIVSNDQ; /* XXX sysctl ? */ 109 static u_long div_recvspace = DIVRCVQ; /* XXX sysctl ? */ 110 111 /* 112 * Initialize divert connection block queue. 113 */ 114 void 115 div_init(void) 116 { 117 INP_INFO_LOCK_INIT(&divcbinfo, "div"); 118 LIST_INIT(&divcb); 119 divcbinfo.listhead = &divcb; 120 /* 121 * XXX We don't use the hash list for divert IP, but it's easier 122 * to allocate a one entry hash list than it is to check all 123 * over the place for hashbase == NULL. 124 */ 125 divcbinfo.hashbase = hashinit(1, M_PCB, &divcbinfo.hashmask); 126 divcbinfo.porthashbase = hashinit(1, M_PCB, &divcbinfo.porthashmask); 127 divcbinfo.ipi_zone = uma_zcreate("divcb", sizeof(struct inpcb), 128 NULL, NULL, NULL, NULL, UMA_ALIGN_PTR, UMA_ZONE_NOFREE); 129 uma_zone_set_max(divcbinfo.ipi_zone, maxsockets); 130 } 131 132 /* 133 * IPPROTO_DIVERT is not in the real IP protocol number space; this 134 * function should never be called. Just in case, drop any packets. 135 */ 136 void 137 div_input(struct mbuf *m, int off) 138 { 139 ipstat.ips_noproto++; 140 m_freem(m); 141 } 142 143 /* 144 * Divert a packet by passing it up to the divert socket at port 'port'. 145 * 146 * Setup generic address and protocol structures for div_input routine, 147 * then pass them along with mbuf chain. 148 */ 149 void 150 divert_packet(struct mbuf *m, int incoming) 151 { 152 struct ip *ip; 153 struct inpcb *inp; 154 struct socket *sa; 155 u_int16_t nport; 156 struct sockaddr_in divsrc; 157 struct m_tag *mtag; 158 159 mtag = m_tag_find(m, PACKET_TAG_DIVERT, NULL); 160 if (mtag == NULL) { 161 printf("%s: no divert tag\n", __func__); 162 m_freem(m); 163 return; 164 } 165 /* Assure header */ 166 if (m->m_len < sizeof(struct ip) && 167 (m = m_pullup(m, sizeof(struct ip))) == 0) 168 return; 169 ip = mtod(m, struct ip *); 170 171 /* 172 * Record receive interface address, if any. 173 * But only for incoming packets. 174 */ 175 bzero(&divsrc, sizeof(divsrc)); 176 divsrc.sin_len = sizeof(divsrc); 177 divsrc.sin_family = AF_INET; 178 divsrc.sin_port = divert_cookie(mtag); /* record matching rule */ 179 if (incoming) { 180 struct ifaddr *ifa; 181 182 /* Sanity check */ 183 M_ASSERTPKTHDR(m); 184 185 /* Find IP address for receive interface */ 186 TAILQ_FOREACH(ifa, &m->m_pkthdr.rcvif->if_addrhead, ifa_link) { 187 if (ifa->ifa_addr == NULL) 188 continue; 189 if (ifa->ifa_addr->sa_family != AF_INET) 190 continue; 191 divsrc.sin_addr = 192 ((struct sockaddr_in *) ifa->ifa_addr)->sin_addr; 193 break; 194 } 195 } 196 /* 197 * Record the incoming interface name whenever we have one. 198 */ 199 if (m->m_pkthdr.rcvif) { 200 /* 201 * Hide the actual interface name in there in the 202 * sin_zero array. XXX This needs to be moved to a 203 * different sockaddr type for divert, e.g. 204 * sockaddr_div with multiple fields like 205 * sockaddr_dl. Presently we have only 7 bytes 206 * but that will do for now as most interfaces 207 * are 4 or less + 2 or less bytes for unit. 208 * There is probably a faster way of doing this, 209 * possibly taking it from the sockaddr_dl on the iface. 210 * This solves the problem of a P2P link and a LAN interface 211 * having the same address, which can result in the wrong 212 * interface being assigned to the packet when fed back 213 * into the divert socket. Theoretically if the daemon saves 214 * and re-uses the sockaddr_in as suggested in the man pages, 215 * this iface name will come along for the ride. 216 * (see div_output for the other half of this.) 217 */ 218 strlcpy(divsrc.sin_zero, m->m_pkthdr.rcvif->if_xname, 219 sizeof(divsrc.sin_zero)); 220 } 221 222 /* Put packet on socket queue, if any */ 223 sa = NULL; 224 nport = htons((u_int16_t)divert_info(mtag)); 225 INP_INFO_RLOCK(&divcbinfo); 226 LIST_FOREACH(inp, &divcb, inp_list) { 227 INP_LOCK(inp); 228 /* XXX why does only one socket match? */ 229 if (inp->inp_lport == nport) { 230 sa = inp->inp_socket; 231 SOCKBUF_LOCK(&sa->so_rcv); 232 if (sbappendaddr_locked(&sa->so_rcv, 233 (struct sockaddr *)&divsrc, m, 234 (struct mbuf *)0) == 0) { 235 SOCKBUF_UNLOCK(&sa->so_rcv); 236 sa = NULL; /* force mbuf reclaim below */ 237 } else 238 sorwakeup_locked(sa); 239 INP_UNLOCK(inp); 240 break; 241 } 242 INP_UNLOCK(inp); 243 } 244 INP_INFO_RUNLOCK(&divcbinfo); 245 if (sa == NULL) { 246 m_freem(m); 247 ipstat.ips_noproto++; 248 ipstat.ips_delivered--; 249 } 250 } 251 252 /* 253 * Deliver packet back into the IP processing machinery. 254 * 255 * If no address specified, or address is 0.0.0.0, send to ip_output(); 256 * otherwise, send to ip_input() and mark as having been received on 257 * the interface with that address. 258 */ 259 static int 260 div_output(struct socket *so, struct mbuf *m, 261 struct sockaddr_in *sin, struct mbuf *control) 262 { 263 int error = 0; 264 265 KASSERT(m->m_pkthdr.rcvif == NULL, ("rcvif not null")); 266 267 if (control) 268 m_freem(control); /* XXX */ 269 270 /* Loopback avoidance and state recovery */ 271 if (sin) { 272 struct m_tag *mtag; 273 struct divert_tag *dt; 274 int i; 275 276 mtag = m_tag_get(PACKET_TAG_DIVERT, 277 sizeof(struct divert_tag), M_NOWAIT); 278 if (mtag == NULL) { 279 error = ENOBUFS; 280 goto cantsend; 281 } 282 dt = (struct divert_tag *)(mtag+1); 283 dt->info = 0; 284 dt->cookie = sin->sin_port; 285 m_tag_prepend(m, mtag); 286 287 /* 288 * Find receive interface with the given name, stuffed 289 * (if it exists) in the sin_zero[] field. 290 * The name is user supplied data so don't trust its size 291 * or that it is zero terminated. 292 */ 293 for (i = 0; i < sizeof(sin->sin_zero) && sin->sin_zero[i]; i++) 294 ; 295 if ( i > 0 && i < sizeof(sin->sin_zero)) 296 m->m_pkthdr.rcvif = ifunit(sin->sin_zero); 297 } 298 299 /* Reinject packet into the system as incoming or outgoing */ 300 if (!sin || sin->sin_addr.s_addr == 0) { 301 struct ip *const ip = mtod(m, struct ip *); 302 struct inpcb *inp; 303 304 INP_INFO_WLOCK(&divcbinfo); 305 inp = sotoinpcb(so); 306 INP_LOCK(inp); 307 /* 308 * Don't allow both user specified and setsockopt options, 309 * and don't allow packet length sizes that will crash 310 */ 311 if (((ip->ip_hl != (sizeof (*ip) >> 2)) && inp->inp_options) || 312 ((u_short)ntohs(ip->ip_len) > m->m_pkthdr.len)) { 313 error = EINVAL; 314 m_freem(m); 315 } else { 316 /* Convert fields to host order for ip_output() */ 317 ip->ip_len = ntohs(ip->ip_len); 318 ip->ip_off = ntohs(ip->ip_off); 319 320 /* Send packet to output processing */ 321 ipstat.ips_rawout++; /* XXX */ 322 323 #ifdef MAC 324 mac_create_mbuf_from_inpcb(inp, m); 325 #endif 326 error = ip_output(m, 327 inp->inp_options, NULL, 328 (so->so_options & SO_DONTROUTE) | 329 IP_ALLOWBROADCAST | IP_RAWOUTPUT, 330 inp->inp_moptions, NULL); 331 } 332 INP_UNLOCK(inp); 333 INP_INFO_WUNLOCK(&divcbinfo); 334 } else { 335 if (m->m_pkthdr.rcvif == NULL) { 336 /* 337 * No luck with the name, check by IP address. 338 * Clear the port and the ifname to make sure 339 * there are no distractions for ifa_ifwithaddr. 340 */ 341 struct ifaddr *ifa; 342 343 bzero(sin->sin_zero, sizeof(sin->sin_zero)); 344 sin->sin_port = 0; 345 ifa = ifa_ifwithaddr((struct sockaddr *) sin); 346 if (ifa == NULL) { 347 error = EADDRNOTAVAIL; 348 goto cantsend; 349 } 350 m->m_pkthdr.rcvif = ifa->ifa_ifp; 351 } 352 #ifdef MAC 353 SOCK_LOCK(so); 354 mac_create_mbuf_from_socket(so, m); 355 SOCK_UNLOCK(so); 356 #endif 357 /* Send packet to input processing */ 358 ip_input(m); 359 } 360 361 return error; 362 363 cantsend: 364 m_freem(m); 365 return error; 366 } 367 368 /* 369 * Return a copy of the specified packet, but without 370 * the divert tag. This is used when packets are ``tee'd'' 371 * and we want the cloned copy to not have divert processing. 372 */ 373 struct mbuf * 374 divert_clone(struct mbuf *m) 375 { 376 struct mbuf *clone; 377 struct m_tag *mtag; 378 379 clone = m_dup(m, M_DONTWAIT); 380 if (clone != NULL) { 381 /* strip divert tag from copy */ 382 mtag = m_tag_find(clone, PACKET_TAG_DIVERT, NULL); 383 if (mtag != NULL) 384 m_tag_delete(clone, mtag); 385 } 386 return clone; 387 } 388 389 static int 390 div_attach(struct socket *so, int proto, struct thread *td) 391 { 392 struct inpcb *inp; 393 int error; 394 395 INP_INFO_WLOCK(&divcbinfo); 396 inp = sotoinpcb(so); 397 if (inp != 0) { 398 INP_INFO_WUNLOCK(&divcbinfo); 399 return EINVAL; 400 } 401 if (td && (error = suser(td)) != 0) { 402 INP_INFO_WUNLOCK(&divcbinfo); 403 return error; 404 } 405 error = soreserve(so, div_sendspace, div_recvspace); 406 if (error) { 407 INP_INFO_WUNLOCK(&divcbinfo); 408 return error; 409 } 410 error = in_pcballoc(so, &divcbinfo, "divinp"); 411 if (error) { 412 INP_INFO_WUNLOCK(&divcbinfo); 413 return error; 414 } 415 inp = (struct inpcb *)so->so_pcb; 416 INP_LOCK(inp); 417 INP_INFO_WUNLOCK(&divcbinfo); 418 inp->inp_ip_p = proto; 419 inp->inp_vflag |= INP_IPV4; 420 inp->inp_flags |= INP_HDRINCL; 421 /* The socket is always "connected" because 422 we always know "where" to send the packet */ 423 INP_UNLOCK(inp); 424 SOCK_LOCK(so); 425 so->so_state |= SS_ISCONNECTED; 426 SOCK_UNLOCK(so); 427 return 0; 428 } 429 430 static int 431 div_detach(struct socket *so) 432 { 433 struct inpcb *inp; 434 435 INP_INFO_WLOCK(&divcbinfo); 436 inp = sotoinpcb(so); 437 if (inp == 0) { 438 INP_INFO_WUNLOCK(&divcbinfo); 439 return EINVAL; 440 } 441 INP_LOCK(inp); 442 in_pcbdetach(inp); 443 INP_INFO_WUNLOCK(&divcbinfo); 444 return 0; 445 } 446 447 static int 448 div_abort(struct socket *so) 449 { 450 struct inpcb *inp; 451 452 INP_INFO_WLOCK(&divcbinfo); 453 inp = sotoinpcb(so); 454 if (inp == 0) { 455 INP_INFO_WUNLOCK(&divcbinfo); 456 return EINVAL; /* ??? possible? panic instead? */ 457 } 458 INP_LOCK(inp); 459 soisdisconnected(so); 460 in_pcbdetach(inp); 461 INP_INFO_WUNLOCK(&divcbinfo); 462 return 0; 463 } 464 465 static int 466 div_disconnect(struct socket *so) 467 { 468 if ((so->so_state & SS_ISCONNECTED) == 0) 469 return ENOTCONN; 470 return div_abort(so); 471 } 472 473 static int 474 div_bind(struct socket *so, struct sockaddr *nam, struct thread *td) 475 { 476 struct inpcb *inp; 477 int error; 478 479 INP_INFO_WLOCK(&divcbinfo); 480 inp = sotoinpcb(so); 481 if (inp == 0) { 482 INP_INFO_WUNLOCK(&divcbinfo); 483 return EINVAL; 484 } 485 /* in_pcbbind assumes that nam is a sockaddr_in 486 * and in_pcbbind requires a valid address. Since divert 487 * sockets don't we need to make sure the address is 488 * filled in properly. 489 * XXX -- divert should not be abusing in_pcbind 490 * and should probably have its own family. 491 */ 492 if (nam->sa_family != AF_INET) 493 error = EAFNOSUPPORT; 494 else { 495 ((struct sockaddr_in *)nam)->sin_addr.s_addr = INADDR_ANY; 496 INP_LOCK(inp); 497 error = in_pcbbind(inp, nam, td->td_ucred); 498 INP_UNLOCK(inp); 499 } 500 INP_INFO_WUNLOCK(&divcbinfo); 501 return error; 502 } 503 504 static int 505 div_shutdown(struct socket *so) 506 { 507 struct inpcb *inp; 508 509 INP_INFO_RLOCK(&divcbinfo); 510 inp = sotoinpcb(so); 511 if (inp == 0) { 512 INP_INFO_RUNLOCK(&divcbinfo); 513 return EINVAL; 514 } 515 INP_LOCK(inp); 516 INP_INFO_RUNLOCK(&divcbinfo); 517 socantsendmore(so); 518 INP_UNLOCK(inp); 519 return 0; 520 } 521 522 static int 523 div_send(struct socket *so, int flags, struct mbuf *m, struct sockaddr *nam, 524 struct mbuf *control, struct thread *td) 525 { 526 /* Packet must have a header (but that's about it) */ 527 if (m->m_len < sizeof (struct ip) && 528 (m = m_pullup(m, sizeof (struct ip))) == 0) { 529 ipstat.ips_toosmall++; 530 m_freem(m); 531 return EINVAL; 532 } 533 534 /* Send packet */ 535 return div_output(so, m, (struct sockaddr_in *)nam, control); 536 } 537 538 void 539 div_ctlinput(int cmd, struct sockaddr *sa, void *vip) 540 { 541 struct in_addr faddr; 542 543 faddr = ((struct sockaddr_in *)sa)->sin_addr; 544 if (sa->sa_family != AF_INET || faddr.s_addr == INADDR_ANY) 545 return; 546 if (PRC_IS_REDIRECT(cmd)) 547 return; 548 } 549 550 static int 551 div_pcblist(SYSCTL_HANDLER_ARGS) 552 { 553 int error, i, n; 554 struct inpcb *inp, **inp_list; 555 inp_gen_t gencnt; 556 struct xinpgen xig; 557 558 /* 559 * The process of preparing the TCB list is too time-consuming and 560 * resource-intensive to repeat twice on every request. 561 */ 562 if (req->oldptr == 0) { 563 n = divcbinfo.ipi_count; 564 req->oldidx = 2 * (sizeof xig) 565 + (n + n/8) * sizeof(struct xinpcb); 566 return 0; 567 } 568 569 if (req->newptr != 0) 570 return EPERM; 571 572 /* 573 * OK, now we're committed to doing something. 574 */ 575 INP_INFO_RLOCK(&divcbinfo); 576 gencnt = divcbinfo.ipi_gencnt; 577 n = divcbinfo.ipi_count; 578 INP_INFO_RUNLOCK(&divcbinfo); 579 580 error = sysctl_wire_old_buffer(req, 581 2 * sizeof(xig) + n*sizeof(struct xinpcb)); 582 if (error != 0) 583 return (error); 584 585 xig.xig_len = sizeof xig; 586 xig.xig_count = n; 587 xig.xig_gen = gencnt; 588 xig.xig_sogen = so_gencnt; 589 error = SYSCTL_OUT(req, &xig, sizeof xig); 590 if (error) 591 return error; 592 593 inp_list = malloc(n * sizeof *inp_list, M_TEMP, M_WAITOK); 594 if (inp_list == 0) 595 return ENOMEM; 596 597 INP_INFO_RLOCK(&divcbinfo); 598 for (inp = LIST_FIRST(divcbinfo.listhead), i = 0; inp && i < n; 599 inp = LIST_NEXT(inp, inp_list)) { 600 INP_LOCK(inp); 601 if (inp->inp_gencnt <= gencnt && 602 cr_canseesocket(req->td->td_ucred, inp->inp_socket) == 0) 603 inp_list[i++] = inp; 604 INP_UNLOCK(inp); 605 } 606 INP_INFO_RUNLOCK(&divcbinfo); 607 n = i; 608 609 error = 0; 610 for (i = 0; i < n; i++) { 611 inp = inp_list[i]; 612 if (inp->inp_gencnt <= gencnt) { 613 struct xinpcb xi; 614 xi.xi_len = sizeof xi; 615 /* XXX should avoid extra copy */ 616 bcopy(inp, &xi.xi_inp, sizeof *inp); 617 if (inp->inp_socket) 618 sotoxsocket(inp->inp_socket, &xi.xi_socket); 619 error = SYSCTL_OUT(req, &xi, sizeof xi); 620 } 621 } 622 if (!error) { 623 /* 624 * Give the user an updated idea of our state. 625 * If the generation differs from what we told 626 * her before, she knows that something happened 627 * while we were processing this request, and it 628 * might be necessary to retry. 629 */ 630 INP_INFO_RLOCK(&divcbinfo); 631 xig.xig_gen = divcbinfo.ipi_gencnt; 632 xig.xig_sogen = so_gencnt; 633 xig.xig_count = divcbinfo.ipi_count; 634 INP_INFO_RUNLOCK(&divcbinfo); 635 error = SYSCTL_OUT(req, &xig, sizeof xig); 636 } 637 free(inp_list, M_TEMP); 638 return error; 639 } 640 641 /* 642 * This is the wrapper function for in_setsockaddr. We just pass down 643 * the pcbinfo for in_setpeeraddr to lock. 644 */ 645 static int 646 div_sockaddr(struct socket *so, struct sockaddr **nam) 647 { 648 return (in_setsockaddr(so, nam, &divcbinfo)); 649 } 650 651 /* 652 * This is the wrapper function for in_setpeeraddr. We just pass down 653 * the pcbinfo for in_setpeeraddr to lock. 654 */ 655 static int 656 div_peeraddr(struct socket *so, struct sockaddr **nam) 657 { 658 return (in_setpeeraddr(so, nam, &divcbinfo)); 659 } 660 661 662 SYSCTL_DECL(_net_inet_divert); 663 SYSCTL_PROC(_net_inet_divert, OID_AUTO, pcblist, CTLFLAG_RD, 0, 0, 664 div_pcblist, "S,xinpcb", "List of active divert sockets"); 665 666 struct pr_usrreqs div_usrreqs = { 667 div_abort, pru_accept_notsupp, div_attach, div_bind, 668 pru_connect_notsupp, pru_connect2_notsupp, in_control, div_detach, 669 div_disconnect, pru_listen_notsupp, div_peeraddr, pru_rcvd_notsupp, 670 pru_rcvoob_notsupp, div_send, pru_sense_null, div_shutdown, 671 div_sockaddr, sosend, soreceive, sopoll, in_pcbsosetlabel 672 }; 673