xref: /freebsd/sys/dev/uart/uart_dev_pl011.c (revision 97cb52fa9aefd90fad38790fded50905aeeb9b9e)
1 /*-
2  * SPDX-License-Identifier: BSD-2-Clause-FreeBSD
3  *
4  * Copyright (c) 2012 Semihalf.
5  * All rights reserved.
6  *
7  * Redistribution and use in source and binary forms, with or without
8  * modification, are permitted provided that the following conditions
9  * are met:
10  * 1. Redistributions of source code must retain the above copyright
11  *    notice, this list of conditions and the following disclaimer.
12  * 2. Redistributions in binary form must reproduce the above copyright
13  *    notice, this list of conditions and the following disclaimer in the
14  *    documentation and/or other materials provided with the distribution.
15  *
16  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
17  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
18  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
19  * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
20  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
21  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
22  * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
23  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
24  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
25  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
26  * SUCH DAMAGE.
27  */
28 
29 #include "opt_acpi.h"
30 #include "opt_platform.h"
31 
32 #include <sys/cdefs.h>
33 __FBSDID("$FreeBSD$");
34 
35 #include <sys/param.h>
36 #include <sys/systm.h>
37 #include <sys/kernel.h>
38 #include <sys/bus.h>
39 #include <machine/bus.h>
40 
41 #include <dev/uart/uart.h>
42 #include <dev/uart/uart_cpu.h>
43 #ifdef FDT
44 #include <dev/uart/uart_cpu_fdt.h>
45 #include <dev/ofw/ofw_bus.h>
46 #endif
47 #include <dev/uart/uart_bus.h>
48 #include "uart_if.h"
49 
50 #ifdef DEV_ACPI
51 #include <dev/uart/uart_cpu_acpi.h>
52 #include <contrib/dev/acpica/include/acpi.h>
53 #include <contrib/dev/acpica/include/accommon.h>
54 #include <contrib/dev/acpica/include/actables.h>
55 #endif
56 
57 #include <sys/kdb.h>
58 
59 /* PL011 UART registers and masks*/
60 #define	UART_DR		0x00		/* Data register */
61 #define	DR_FE		(1 << 8)	/* Framing error */
62 #define	DR_PE		(1 << 9)	/* Parity error */
63 #define	DR_BE		(1 << 10)	/* Break error */
64 #define	DR_OE		(1 << 11)	/* Overrun error */
65 
66 #define	UART_FR		0x06		/* Flag register */
67 #define	FR_RXFE		(1 << 4)	/* Receive FIFO/reg empty */
68 #define	FR_TXFF		(1 << 5)	/* Transmit FIFO/reg full */
69 #define	FR_RXFF		(1 << 6)	/* Receive FIFO/reg full */
70 #define	FR_TXFE		(1 << 7)	/* Transmit FIFO/reg empty */
71 
72 #define	UART_IBRD	0x09		/* Integer baud rate register */
73 #define	IBRD_BDIVINT	0xffff	/* Significant part of int. divisor value */
74 
75 #define	UART_FBRD	0x0a		/* Fractional baud rate register */
76 #define	FBRD_BDIVFRAC	0x3f	/* Significant part of frac. divisor value */
77 
78 #define	UART_LCR_H	0x0b		/* Line control register */
79 #define	LCR_H_WLEN8	(0x3 << 5)
80 #define	LCR_H_WLEN7	(0x2 << 5)
81 #define	LCR_H_WLEN6	(0x1 << 5)
82 #define	LCR_H_FEN	(1 << 4)	/* FIFO mode enable */
83 #define	LCR_H_STP2	(1 << 3)	/* 2 stop frames at the end */
84 #define	LCR_H_EPS	(1 << 2)	/* Even parity select */
85 #define	LCR_H_PEN	(1 << 1)	/* Parity enable */
86 
87 #define	UART_CR		0x0c		/* Control register */
88 #define	CR_RXE		(1 << 9)	/* Receive enable */
89 #define	CR_TXE		(1 << 8)	/* Transmit enable */
90 #define	CR_UARTEN	(1 << 0)	/* UART enable */
91 
92 #define	UART_IFLS	0x0d		/* FIFO level select register */
93 #define	IFLS_RX_SHIFT	3		/* RX level in bits [5:3] */
94 #define	IFLS_TX_SHIFT	0		/* TX level in bits [2:0] */
95 #define	IFLS_MASK	0x07		/* RX/TX level is 3 bits */
96 #define	IFLS_LVL_1_8th	0		/* Interrupt at 1/8 full */
97 #define	IFLS_LVL_2_8th	1		/* Interrupt at 1/4 full */
98 #define	IFLS_LVL_4_8th	2		/* Interrupt at 1/2 full */
99 #define	IFLS_LVL_6_8th	3		/* Interrupt at 3/4 full */
100 #define	IFLS_LVL_7_8th	4		/* Interrupt at 7/8 full */
101 
102 #define	UART_IMSC	0x0e		/* Interrupt mask set/clear register */
103 #define	IMSC_MASK_ALL	0x7ff		/* Mask all interrupts */
104 
105 #define	UART_RIS	0x0f		/* Raw interrupt status register */
106 #define	UART_RXREADY	(1 << 4)	/* RX buffer full */
107 #define	UART_TXEMPTY	(1 << 5)	/* TX buffer empty */
108 #define	RIS_RTIM	(1 << 6)	/* Receive timeout */
109 #define	RIS_FE		(1 << 7)	/* Framing error interrupt status */
110 #define	RIS_PE		(1 << 8)	/* Parity error interrupt status */
111 #define	RIS_BE		(1 << 9)	/* Break error interrupt status */
112 #define	RIS_OE		(1 << 10)	/* Overrun interrupt status */
113 
114 #define	UART_MIS	0x10		/* Masked interrupt status register */
115 #define	UART_ICR	0x11		/* Interrupt clear register */
116 
117 #define	UART_PIDREG_0	0x3f8		/* Peripheral ID register 0 */
118 #define	UART_PIDREG_1	0x3f9		/* Peripheral ID register 1 */
119 #define	UART_PIDREG_2	0x3fa		/* Peripheral ID register 2 */
120 #define	UART_PIDREG_3	0x3fb		/* Peripheral ID register 3 */
121 
122 /*
123  * The hardware FIFOs are 16 bytes each on rev 2 and earlier hardware, 32 bytes
124  * on rev 3 and later.  We configure them to interrupt when 3/4 full/empty.  For
125  * RX we set the size to the full hardware capacity so that the uart core
126  * allocates enough buffer space to hold a complete fifo full of incoming data.
127  * For TX, we need to limit the size to the capacity we know will be available
128  * when the interrupt occurs; uart_core will feed exactly that many bytes to
129  * uart_pl011_bus_transmit() which must consume them all.
130  */
131 #define	FIFO_RX_SIZE_R2	16
132 #define	FIFO_TX_SIZE_R2	12
133 #define	FIFO_RX_SIZE_R3	32
134 #define	FIFO_TX_SIZE_R3	24
135 #define	FIFO_IFLS_BITS	((IFLS_LVL_6_8th << IFLS_RX_SHIFT) | (IFLS_LVL_2_8th))
136 
137 /*
138  * FIXME: actual register size is SoC-dependent, we need to handle it
139  */
140 #define	__uart_getreg(bas, reg)		\
141 	bus_space_read_4((bas)->bst, (bas)->bsh, uart_regofs(bas, reg))
142 #define	__uart_setreg(bas, reg, value)	\
143 	bus_space_write_4((bas)->bst, (bas)->bsh, uart_regofs(bas, reg), value)
144 
145 /*
146  * Low-level UART interface.
147  */
148 static int uart_pl011_probe(struct uart_bas *bas);
149 static void uart_pl011_init(struct uart_bas *bas, int, int, int, int);
150 static void uart_pl011_term(struct uart_bas *bas);
151 static void uart_pl011_putc(struct uart_bas *bas, int);
152 static int uart_pl011_rxready(struct uart_bas *bas);
153 static int uart_pl011_getc(struct uart_bas *bas, struct mtx *);
154 
155 static struct uart_ops uart_pl011_ops = {
156 	.probe = uart_pl011_probe,
157 	.init = uart_pl011_init,
158 	.term = uart_pl011_term,
159 	.putc = uart_pl011_putc,
160 	.rxready = uart_pl011_rxready,
161 	.getc = uart_pl011_getc,
162 };
163 
164 static int
165 uart_pl011_probe(struct uart_bas *bas)
166 {
167 
168 	return (0);
169 }
170 
171 static void
172 uart_pl011_param(struct uart_bas *bas, int baudrate, int databits, int stopbits,
173     int parity)
174 {
175 	uint32_t ctrl, line;
176 	uint32_t baud;
177 
178 	/*
179 	 * Zero all settings to make sure
180 	 * UART is disabled and not configured
181 	 */
182 	ctrl = line = 0x0;
183 	__uart_setreg(bas, UART_CR, ctrl);
184 
185 	/* As we know UART is disabled we may setup the line */
186 	switch (databits) {
187 	case 7:
188 		line |= LCR_H_WLEN7;
189 		break;
190 	case 6:
191 		line |= LCR_H_WLEN6;
192 		break;
193 	case 8:
194 	default:
195 		line |= LCR_H_WLEN8;
196 		break;
197 	}
198 
199 	if (stopbits == 2)
200 		line |= LCR_H_STP2;
201 	else
202 		line &= ~LCR_H_STP2;
203 
204 	if (parity)
205 		line |= LCR_H_PEN;
206 	else
207 		line &= ~LCR_H_PEN;
208 	line |= LCR_H_FEN;
209 
210 	/* Configure the rest */
211 	ctrl |= (CR_RXE | CR_TXE | CR_UARTEN);
212 
213 	if (bas->rclk != 0 && baudrate != 0) {
214 		baud = bas->rclk * 4 / baudrate;
215 		__uart_setreg(bas, UART_IBRD, ((uint32_t)(baud >> 6)) & IBRD_BDIVINT);
216 		__uart_setreg(bas, UART_FBRD, (uint32_t)(baud & 0x3F) & FBRD_BDIVFRAC);
217 	}
218 
219 	/* Add config. to line before reenabling UART */
220 	__uart_setreg(bas, UART_LCR_H, (__uart_getreg(bas, UART_LCR_H) &
221 	    ~0xff) | line);
222 
223 	/* Set rx and tx fifo levels. */
224 	__uart_setreg(bas, UART_IFLS, FIFO_IFLS_BITS);
225 
226 	__uart_setreg(bas, UART_CR, ctrl);
227 }
228 
229 static void
230 uart_pl011_init(struct uart_bas *bas, int baudrate, int databits, int stopbits,
231     int parity)
232 {
233 	/* Mask all interrupts */
234 	__uart_setreg(bas, UART_IMSC, __uart_getreg(bas, UART_IMSC) &
235 	    ~IMSC_MASK_ALL);
236 
237 	uart_pl011_param(bas, baudrate, databits, stopbits, parity);
238 }
239 
240 static void
241 uart_pl011_term(struct uart_bas *bas)
242 {
243 }
244 
245 static void
246 uart_pl011_putc(struct uart_bas *bas, int c)
247 {
248 
249 	/* Wait when TX FIFO full. Push character otherwise. */
250 	while (__uart_getreg(bas, UART_FR) & FR_TXFF)
251 		;
252 	__uart_setreg(bas, UART_DR, c & 0xff);
253 }
254 
255 static int
256 uart_pl011_rxready(struct uart_bas *bas)
257 {
258 
259 	return !(__uart_getreg(bas, UART_FR) & FR_RXFE);
260 }
261 
262 static int
263 uart_pl011_getc(struct uart_bas *bas, struct mtx *hwmtx)
264 {
265 	int c;
266 
267 	while (!uart_pl011_rxready(bas))
268 		;
269 	c = __uart_getreg(bas, UART_DR) & 0xff;
270 
271 	return (c);
272 }
273 
274 /*
275  * High-level UART interface.
276  */
277 struct uart_pl011_softc {
278 	struct uart_softc	base;
279 	uint16_t		imsc; /* Interrupt mask */
280 };
281 
282 static int uart_pl011_bus_attach(struct uart_softc *);
283 static int uart_pl011_bus_detach(struct uart_softc *);
284 static int uart_pl011_bus_flush(struct uart_softc *, int);
285 static int uart_pl011_bus_getsig(struct uart_softc *);
286 static int uart_pl011_bus_ioctl(struct uart_softc *, int, intptr_t);
287 static int uart_pl011_bus_ipend(struct uart_softc *);
288 static int uart_pl011_bus_param(struct uart_softc *, int, int, int, int);
289 static int uart_pl011_bus_probe(struct uart_softc *);
290 static int uart_pl011_bus_receive(struct uart_softc *);
291 static int uart_pl011_bus_setsig(struct uart_softc *, int);
292 static int uart_pl011_bus_transmit(struct uart_softc *);
293 static void uart_pl011_bus_grab(struct uart_softc *);
294 static void uart_pl011_bus_ungrab(struct uart_softc *);
295 
296 static kobj_method_t uart_pl011_methods[] = {
297 	KOBJMETHOD(uart_attach,		uart_pl011_bus_attach),
298 	KOBJMETHOD(uart_detach,		uart_pl011_bus_detach),
299 	KOBJMETHOD(uart_flush,		uart_pl011_bus_flush),
300 	KOBJMETHOD(uart_getsig,		uart_pl011_bus_getsig),
301 	KOBJMETHOD(uart_ioctl,		uart_pl011_bus_ioctl),
302 	KOBJMETHOD(uart_ipend,		uart_pl011_bus_ipend),
303 	KOBJMETHOD(uart_param,		uart_pl011_bus_param),
304 	KOBJMETHOD(uart_probe,		uart_pl011_bus_probe),
305 	KOBJMETHOD(uart_receive,	uart_pl011_bus_receive),
306 	KOBJMETHOD(uart_setsig,		uart_pl011_bus_setsig),
307 	KOBJMETHOD(uart_transmit,	uart_pl011_bus_transmit),
308 	KOBJMETHOD(uart_grab,		uart_pl011_bus_grab),
309 	KOBJMETHOD(uart_ungrab,		uart_pl011_bus_ungrab),
310 
311 	{ 0, 0 }
312 };
313 
314 static struct uart_class uart_pl011_class = {
315 	"uart_pl011",
316 	uart_pl011_methods,
317 	sizeof(struct uart_pl011_softc),
318 	.uc_ops = &uart_pl011_ops,
319 	.uc_range = 0x48,
320 	.uc_rclk = 0,
321 	.uc_rshift = 2
322 };
323 
324 
325 #ifdef FDT
326 static struct ofw_compat_data compat_data[] = {
327 	{"arm,pl011",		(uintptr_t)&uart_pl011_class},
328 	{NULL,			(uintptr_t)NULL},
329 };
330 UART_FDT_CLASS_AND_DEVICE(compat_data);
331 #endif
332 
333 #ifdef DEV_ACPI
334 static struct acpi_uart_compat_data acpi_compat_data[] = {
335 	{"ARMH0011", &uart_pl011_class, ACPI_DBG2_ARM_PL011},
336 	{NULL, NULL, 0},
337 };
338 UART_ACPI_CLASS_AND_DEVICE(acpi_compat_data);
339 #endif
340 
341 static int
342 uart_pl011_bus_attach(struct uart_softc *sc)
343 {
344 	struct uart_pl011_softc *psc;
345 	struct uart_bas *bas;
346 
347 	psc = (struct uart_pl011_softc *)sc;
348 	bas = &sc->sc_bas;
349 
350 	/* Enable interrupts */
351 	psc->imsc = (UART_RXREADY | RIS_RTIM | UART_TXEMPTY);
352 	__uart_setreg(bas, UART_IMSC, psc->imsc);
353 
354 	/* Clear interrupts */
355 	__uart_setreg(bas, UART_ICR, IMSC_MASK_ALL);
356 
357 	return (0);
358 }
359 
360 static int
361 uart_pl011_bus_detach(struct uart_softc *sc)
362 {
363 
364 	return (0);
365 }
366 
367 static int
368 uart_pl011_bus_flush(struct uart_softc *sc, int what)
369 {
370 
371 	return (0);
372 }
373 
374 static int
375 uart_pl011_bus_getsig(struct uart_softc *sc)
376 {
377 
378 	return (0);
379 }
380 
381 static int
382 uart_pl011_bus_ioctl(struct uart_softc *sc, int request, intptr_t data)
383 {
384 	struct uart_bas *bas;
385 	int error;
386 
387 	bas = &sc->sc_bas;
388 	error = 0;
389 	uart_lock(sc->sc_hwmtx);
390 	switch (request) {
391 	case UART_IOCTL_BREAK:
392 		break;
393 	case UART_IOCTL_BAUD:
394 		*(int*)data = 115200;
395 		break;
396 	default:
397 		error = EINVAL;
398 		break;
399 	}
400 	uart_unlock(sc->sc_hwmtx);
401 
402 	return (error);
403 }
404 
405 static int
406 uart_pl011_bus_ipend(struct uart_softc *sc)
407 {
408 	struct uart_pl011_softc *psc;
409 	struct uart_bas *bas;
410 	uint32_t ints;
411 	int ipend;
412 
413 	psc = (struct uart_pl011_softc *)sc;
414 	bas = &sc->sc_bas;
415 
416 	uart_lock(sc->sc_hwmtx);
417 	ints = __uart_getreg(bas, UART_MIS);
418 	ipend = 0;
419 
420 	if (ints & (UART_RXREADY | RIS_RTIM))
421 		ipend |= SER_INT_RXREADY;
422 	if (ints & RIS_BE)
423 		ipend |= SER_INT_BREAK;
424 	if (ints & RIS_OE)
425 		ipend |= SER_INT_OVERRUN;
426 	if (ints & UART_TXEMPTY) {
427 		if (sc->sc_txbusy)
428 			ipend |= SER_INT_TXIDLE;
429 
430 		/* Disable TX interrupt */
431 		__uart_setreg(bas, UART_IMSC, psc->imsc & ~UART_TXEMPTY);
432 	}
433 
434 	uart_unlock(sc->sc_hwmtx);
435 
436 	return (ipend);
437 }
438 
439 static int
440 uart_pl011_bus_param(struct uart_softc *sc, int baudrate, int databits,
441     int stopbits, int parity)
442 {
443 
444 	uart_lock(sc->sc_hwmtx);
445 	uart_pl011_param(&sc->sc_bas, baudrate, databits, stopbits, parity);
446 	uart_unlock(sc->sc_hwmtx);
447 
448 	return (0);
449 }
450 
451 static int
452 uart_pl011_bus_probe(struct uart_softc *sc)
453 {
454 	uint8_t hwrev;
455 #ifdef FDT
456 	pcell_t node;
457 	uint32_t periphid;
458 
459 	/*
460 	 * The FIFO sizes vary depending on hardware; rev 2 and below have 16
461 	 * byte FIFOs, rev 3 and up are 32 byte.  The hardware rev is in the
462 	 * primecell periphid register, but we get a bit of drama, as always,
463 	 * with the bcm2835 (rpi), which claims to be rev 3, but has 16 byte
464 	 * FIFOs.  We check for both the old freebsd-historic and the proper
465 	 * bindings-defined compatible strings for bcm2835, and also check the
466 	 * workaround the linux drivers use for rpi3, which is to override the
467 	 * primecell periphid register value with a property.
468 	 */
469 	if (ofw_bus_is_compatible(sc->sc_dev, "brcm,bcm2835-pl011") ||
470 	    ofw_bus_is_compatible(sc->sc_dev, "broadcom,bcm2835-uart")) {
471 		hwrev = 2;
472 	} else {
473 		node = ofw_bus_get_node(sc->sc_dev);
474 		if (OF_getencprop(node, "arm,primecell-periphid", &periphid,
475 		    sizeof(periphid)) > 0) {
476 			hwrev = (periphid >> 20) & 0x0f;
477 		} else {
478 			hwrev = __uart_getreg(&sc->sc_bas, UART_PIDREG_2) >> 4;
479 		}
480 	}
481 #else
482 	hwrev = __uart_getreg(&sc->sc_bas, UART_PIDREG_2) >> 4;
483 #endif
484 	if (hwrev <= 2) {
485 		sc->sc_rxfifosz = FIFO_RX_SIZE_R2;
486 		sc->sc_txfifosz = FIFO_TX_SIZE_R2;
487 	} else {
488 		sc->sc_rxfifosz = FIFO_RX_SIZE_R3;
489 		sc->sc_txfifosz = FIFO_TX_SIZE_R3;
490 	}
491 
492 	device_set_desc(sc->sc_dev, "PrimeCell UART (PL011)");
493 
494 	return (0);
495 }
496 
497 static int
498 uart_pl011_bus_receive(struct uart_softc *sc)
499 {
500 	struct uart_bas *bas;
501 	uint32_t ints, xc;
502 	int rx;
503 
504 	bas = &sc->sc_bas;
505 	uart_lock(sc->sc_hwmtx);
506 
507 	for (;;) {
508 		ints = __uart_getreg(bas, UART_FR);
509 		if (ints & FR_RXFE)
510 			break;
511 		if (uart_rx_full(sc)) {
512 			sc->sc_rxbuf[sc->sc_rxput] = UART_STAT_OVERRUN;
513 			break;
514 		}
515 
516 		xc = __uart_getreg(bas, UART_DR);
517 		rx = xc & 0xff;
518 
519 		if (xc & DR_FE)
520 			rx |= UART_STAT_FRAMERR;
521 		if (xc & DR_PE)
522 			rx |= UART_STAT_PARERR;
523 
524 		uart_rx_put(sc, rx);
525 	}
526 
527 	uart_unlock(sc->sc_hwmtx);
528 
529 	return (0);
530 }
531 
532 static int
533 uart_pl011_bus_setsig(struct uart_softc *sc, int sig)
534 {
535 
536 	return (0);
537 }
538 
539 static int
540 uart_pl011_bus_transmit(struct uart_softc *sc)
541 {
542 	struct uart_pl011_softc *psc;
543 	struct uart_bas *bas;
544 	int i;
545 
546 	psc = (struct uart_pl011_softc *)sc;
547 	bas = &sc->sc_bas;
548 	uart_lock(sc->sc_hwmtx);
549 
550 	for (i = 0; i < sc->sc_txdatasz; i++) {
551 		__uart_setreg(bas, UART_DR, sc->sc_txbuf[i]);
552 		uart_barrier(bas);
553 	}
554 
555 	/* Mark busy and enable TX interrupt */
556 	sc->sc_txbusy = 1;
557 	__uart_setreg(bas, UART_IMSC, psc->imsc);
558 
559 	uart_unlock(sc->sc_hwmtx);
560 
561 	return (0);
562 }
563 
564 static void
565 uart_pl011_bus_grab(struct uart_softc *sc)
566 {
567 	struct uart_pl011_softc *psc;
568 	struct uart_bas *bas;
569 
570 	psc = (struct uart_pl011_softc *)sc;
571 	bas = &sc->sc_bas;
572 
573 	/* Disable interrupts on switch to polling */
574 	uart_lock(sc->sc_hwmtx);
575 	__uart_setreg(bas, UART_IMSC, psc->imsc & ~IMSC_MASK_ALL);
576 	uart_unlock(sc->sc_hwmtx);
577 }
578 
579 static void
580 uart_pl011_bus_ungrab(struct uart_softc *sc)
581 {
582 	struct uart_pl011_softc *psc;
583 	struct uart_bas *bas;
584 
585 	psc = (struct uart_pl011_softc *)sc;
586 	bas = &sc->sc_bas;
587 
588 	/* Switch to using interrupts while not grabbed */
589 	uart_lock(sc->sc_hwmtx);
590 	__uart_setreg(bas, UART_IMSC, psc->imsc);
591 	uart_unlock(sc->sc_hwmtx);
592 }
593