Searched hist:bcdd559268039d8340d38fa58668393596e29fdc (Results 1 – 1 of 1) sorted by relevance
| /linux/drivers/rtc/ |
| H A D | rtc-rp5c01.c | diff bcdd559268039d8340d38fa58668393596e29fdc Mon Feb 12 23:47:49 CET 2018 Alexandre Belloni <alexandre.belloni@bootlin.com> rtc: rp5c01: fix possible race condition
The probe function is not allowed to fail after registering the RTC because
the following may happen:
CPU0: CPU1:
sys_load_module()
do_init_module()
do_one_initcall()
cmos_do_probe()
rtc_device_register()
__register_chrdev()
cdev->owner = struct module*
open("/dev/rtc0")
rtc_device_unregister()
module_put()
free_module()
module_free(mod->module_core)
/* struct module *module is now
freed */
chrdev_open()
spin_lock(cdev_lock)
cdev_get()
try_module_get()
module_is_live()
/* dereferences already
freed struct module* */
Switch to devm_rtc_allocate_device/rtc_register_device to register the rtc
as late as possible.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
|