Home
last modified time | relevance | path

Searched hist:"90 ff5d688e61f49f23545ffab6228bd7e87e6dc7" (Results 1 – 1 of 1) sorted by relevance

/linux/arch/powerpc/include/asm/
H A Dexception-64s.hdiff 90ff5d688e61f49f23545ffab6228bd7e87e6dc7 Mon Dec 16 05:12:43 CET 2013 Michael Neuling <mikey@neuling.org> powerpc: Fix bad stack check in exception entry

In EXCEPTION_PROLOG_COMMON() we check to see if the stack pointer (r1)
is valid when coming from the kernel. If it's not valid, we die but
with a nice oops message.

Currently we allocate a stack frame (subtract INT_FRAME_SIZE) before we
check to see if the stack pointer is negative. Unfortunately, this
won't detect a bad stack where r1 is less than INT_FRAME_SIZE.

This patch fixes the check to compare the modified r1 with
-INT_FRAME_SIZE. With this, bad kernel stack pointers (including NULL
pointers) are correctly detected again.

Kudos to Paulus for finding this.

Signed-off-by: Michael Neuling <mikey@neuling.org>
cc: stable@vger.kernel.org
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>