xref: /linux/drivers/hwmon/lm63.c (revision 964acc34569677e6725812172c3d1a28b3973277)
1 // SPDX-License-Identifier: GPL-2.0-or-later
2 /*
3  * lm63.c - driver for the National Semiconductor LM63 temperature sensor
4  *          with integrated fan control
5  * Copyright (C) 2004-2008  Jean Delvare <jdelvare@suse.de>
6  * Based on the lm90 driver.
7  *
8  * The LM63 is a sensor chip made by National Semiconductor. It measures
9  * two temperatures (its own and one external one) and the speed of one
10  * fan, those speed it can additionally control. Complete datasheet can be
11  * obtained from National's website at:
12  *   http://www.national.com/pf/LM/LM63.html
13  *
14  * The LM63 is basically an LM86 with fan speed monitoring and control
15  * capabilities added. It misses some of the LM86 features though:
16  *  - No low limit for local temperature.
17  *  - No critical limit for local temperature.
18  *  - Critical limit for remote temperature can be changed only once. We
19  *    will consider that the critical limit is read-only.
20  *
21  * The datasheet isn't very clear about what the tachometer reading is.
22  * I had a explanation from National Semiconductor though. The two lower
23  * bits of the read value have to be masked out. The value is still 16 bit
24  * in width.
25  */
26 
27 #include <linux/module.h>
28 #include <linux/init.h>
29 #include <linux/slab.h>
30 #include <linux/jiffies.h>
31 #include <linux/i2c.h>
32 #include <linux/hwmon-sysfs.h>
33 #include <linux/hwmon.h>
34 #include <linux/err.h>
35 #include <linux/mutex.h>
36 #include <linux/of.h>
37 #include <linux/sysfs.h>
38 #include <linux/types.h>
39 
40 /*
41  * Addresses to scan
42  * Address is fully defined internally and cannot be changed except for
43  * LM64 which has one pin dedicated to address selection.
44  * LM63 and LM96163 have address 0x4c.
45  * LM64 can have address 0x18 or 0x4e.
46  */
47 
48 static const unsigned short normal_i2c[] = { 0x18, 0x4c, 0x4e, I2C_CLIENT_END };
49 
50 /*
51  * The LM63 registers
52  */
53 
54 #define LM63_REG_CONFIG1		0x03
55 #define LM63_REG_CONVRATE		0x04
56 #define LM63_REG_CONFIG2		0xBF
57 #define LM63_REG_CONFIG_FAN		0x4A
58 
59 #define LM63_REG_TACH_COUNT_MSB		0x47
60 #define LM63_REG_TACH_COUNT_LSB		0x46
61 #define LM63_REG_TACH_LIMIT_MSB		0x49
62 #define LM63_REG_TACH_LIMIT_LSB		0x48
63 
64 #define LM63_REG_PWM_VALUE		0x4C
65 #define LM63_REG_PWM_FREQ		0x4D
66 #define LM63_REG_LUT_TEMP_HYST		0x4F
67 #define LM63_REG_LUT_TEMP(nr)		(0x50 + 2 * (nr))
68 #define LM63_REG_LUT_PWM(nr)		(0x51 + 2 * (nr))
69 
70 #define LM63_REG_LOCAL_TEMP		0x00
71 #define LM63_REG_LOCAL_HIGH		0x05
72 
73 #define LM63_REG_REMOTE_TEMP_MSB	0x01
74 #define LM63_REG_REMOTE_TEMP_LSB	0x10
75 #define LM63_REG_REMOTE_OFFSET_MSB	0x11
76 #define LM63_REG_REMOTE_OFFSET_LSB	0x12
77 #define LM63_REG_REMOTE_HIGH_MSB	0x07
78 #define LM63_REG_REMOTE_HIGH_LSB	0x13
79 #define LM63_REG_REMOTE_LOW_MSB		0x08
80 #define LM63_REG_REMOTE_LOW_LSB		0x14
81 #define LM63_REG_REMOTE_TCRIT		0x19
82 #define LM63_REG_REMOTE_TCRIT_HYST	0x21
83 
84 #define LM63_REG_ALERT_STATUS		0x02
85 #define LM63_REG_ALERT_MASK		0x16
86 
87 #define LM63_REG_MAN_ID			0xFE
88 #define LM63_REG_CHIP_ID		0xFF
89 
90 #define LM96163_REG_TRUTHERM		0x30
91 #define LM96163_REG_REMOTE_TEMP_U_MSB	0x31
92 #define LM96163_REG_REMOTE_TEMP_U_LSB	0x32
93 #define LM96163_REG_CONFIG_ENHANCED	0x45
94 
95 #define LM63_PWM_BASE_FAST_HZ		180000
96 #define LM63_PWM_BASE_SLOW_HZ		700
97 
98 #define LM63_MAX_CONVRATE		9
99 
100 #define LM63_MAX_CONVRATE_HZ		32
101 #define LM96163_MAX_CONVRATE_HZ		26
102 
103 /*
104  * Conversions and various macros
105  * For tachometer counts, the LM63 uses 16-bit values.
106  * For local temperature and high limit, remote critical limit and hysteresis
107  * value, it uses signed 8-bit values with LSB = 1 degree Celsius.
108  * For remote temperature, low and high limits, it uses signed 11-bit values
109  * with LSB = 0.125 degree Celsius, left-justified in 16-bit registers.
110  * For LM64 the actual remote diode temperature is 16 degree Celsius higher
111  * than the register reading. Remote temperature setpoints have to be
112  * adapted accordingly.
113  */
114 
115 #define FAN_FROM_REG(reg)	((reg) == 0xFFFC || (reg) == 0 ? 0 : \
116 				 5400000 / (reg))
117 #define FAN_TO_REG(val)		((val) <= 82 ? 0xFFFC : \
118 				 (5400000 / (val)) & 0xFFFC)
119 #define TEMP8_FROM_REG(reg)	((reg) * 1000)
120 #define TEMP8_TO_REG(val)	DIV_ROUND_CLOSEST(clamp_val((val), -128000, \
121 							    127000), 1000)
122 #define TEMP8U_TO_REG(val)	DIV_ROUND_CLOSEST(clamp_val((val), 0, \
123 							    255000), 1000)
124 #define TEMP11_FROM_REG(reg)	((reg) / 32 * 125)
125 #define TEMP11_TO_REG(val)	(DIV_ROUND_CLOSEST(clamp_val((val), -128000, \
126 							     127875), 125) * 32)
127 #define TEMP11U_TO_REG(val)	(DIV_ROUND_CLOSEST(clamp_val((val), 0, \
128 							     255875), 125) * 32)
129 #define HYST_TO_REG(val)	DIV_ROUND_CLOSEST(clamp_val((val), 0, 127000), \
130 						  1000)
131 
132 #define UPDATE_INTERVAL(max, rate) \
133 			((1000 << (LM63_MAX_CONVRATE - (rate))) / (max))
134 
135 enum chips { lm63, lm64, lm96163 };
136 
137 /*
138  * Client data (each client gets its own)
139  */
140 
141 struct lm63_data {
142 	struct i2c_client *client;
143 	struct mutex update_lock;
144 	const struct attribute_group *groups[5];
145 	bool valid; /* false until following fields are valid */
146 	char lut_valid; /* zero until lut fields are valid */
147 	unsigned long last_updated; /* in jiffies */
148 	unsigned long lut_last_updated; /* in jiffies */
149 	enum chips kind;
150 	int temp2_offset;
151 
152 	int update_interval;	/* in milliseconds */
153 	int max_convrate_hz;
154 	int lut_size;		/* 8 or 12 */
155 
156 	/* registers values */
157 	u8 config, config_fan;
158 	u16 fan[2];	/* 0: input
159 			   1: low limit */
160 	u8 pwm1_freq;
161 	u8 pwm1[13];	/* 0: current output
162 			   1-12: lookup table */
163 	s8 temp8[15];	/* 0: local input
164 			   1: local high limit
165 			   2: remote critical limit
166 			   3-14: lookup table */
167 	s16 temp11[4];	/* 0: remote input
168 			   1: remote low limit
169 			   2: remote high limit
170 			   3: remote offset */
171 	u16 temp11u;	/* remote input (unsigned) */
172 	u8 temp2_crit_hyst;
173 	u8 lut_temp_hyst;
174 	u8 alarms;
175 	bool pwm_highres;
176 	bool lut_temp_highres;
177 	bool remote_unsigned; /* true if unsigned remote upper limits */
178 	bool trutherm;
179 };
180 
181 static inline int temp8_from_reg(struct lm63_data *data, int nr)
182 {
183 	if (data->remote_unsigned)
184 		return TEMP8_FROM_REG((u8)data->temp8[nr]);
185 	return TEMP8_FROM_REG(data->temp8[nr]);
186 }
187 
188 static inline int lut_temp_from_reg(struct lm63_data *data, int nr)
189 {
190 	return data->temp8[nr] * (data->lut_temp_highres ? 500 : 1000);
191 }
192 
193 static inline int lut_temp_to_reg(struct lm63_data *data, long val)
194 {
195 	val -= data->temp2_offset;
196 	if (data->lut_temp_highres)
197 		return DIV_ROUND_CLOSEST(clamp_val(val, 0, 127500), 500);
198 	else
199 		return DIV_ROUND_CLOSEST(clamp_val(val, 0, 127000), 1000);
200 }
201 
202 /*
203  * Update the lookup table register cache.
204  * client->update_lock must be held when calling this function.
205  */
206 static void lm63_update_lut(struct lm63_data *data)
207 {
208 	struct i2c_client *client = data->client;
209 	int i;
210 
211 	if (time_after(jiffies, data->lut_last_updated + 5 * HZ) ||
212 	    !data->lut_valid) {
213 		for (i = 0; i < data->lut_size; i++) {
214 			data->pwm1[1 + i] = i2c_smbus_read_byte_data(client,
215 					    LM63_REG_LUT_PWM(i));
216 			data->temp8[3 + i] = i2c_smbus_read_byte_data(client,
217 					     LM63_REG_LUT_TEMP(i));
218 		}
219 		data->lut_temp_hyst = i2c_smbus_read_byte_data(client,
220 				      LM63_REG_LUT_TEMP_HYST);
221 
222 		data->lut_last_updated = jiffies;
223 		data->lut_valid = 1;
224 	}
225 }
226 
227 static struct lm63_data *lm63_update_device(struct device *dev)
228 {
229 	struct lm63_data *data = dev_get_drvdata(dev);
230 	struct i2c_client *client = data->client;
231 	unsigned long next_update;
232 
233 	mutex_lock(&data->update_lock);
234 
235 	next_update = data->last_updated +
236 		      msecs_to_jiffies(data->update_interval);
237 	if (time_after(jiffies, next_update) || !data->valid) {
238 		if (data->config & 0x04) { /* tachometer enabled  */
239 			/* order matters for fan1_input */
240 			data->fan[0] = i2c_smbus_read_byte_data(client,
241 				       LM63_REG_TACH_COUNT_LSB) & 0xFC;
242 			data->fan[0] |= i2c_smbus_read_byte_data(client,
243 					LM63_REG_TACH_COUNT_MSB) << 8;
244 			data->fan[1] = (i2c_smbus_read_byte_data(client,
245 					LM63_REG_TACH_LIMIT_LSB) & 0xFC)
246 				     | (i2c_smbus_read_byte_data(client,
247 					LM63_REG_TACH_LIMIT_MSB) << 8);
248 		}
249 
250 		data->pwm1_freq = i2c_smbus_read_byte_data(client,
251 				  LM63_REG_PWM_FREQ);
252 		if (data->pwm1_freq == 0)
253 			data->pwm1_freq = 1;
254 		data->pwm1[0] = i2c_smbus_read_byte_data(client,
255 				LM63_REG_PWM_VALUE);
256 
257 		data->temp8[0] = i2c_smbus_read_byte_data(client,
258 				 LM63_REG_LOCAL_TEMP);
259 		data->temp8[1] = i2c_smbus_read_byte_data(client,
260 				 LM63_REG_LOCAL_HIGH);
261 
262 		/* order matters for temp2_input */
263 		data->temp11[0] = i2c_smbus_read_byte_data(client,
264 				  LM63_REG_REMOTE_TEMP_MSB) << 8;
265 		data->temp11[0] |= i2c_smbus_read_byte_data(client,
266 				   LM63_REG_REMOTE_TEMP_LSB);
267 		data->temp11[1] = (i2c_smbus_read_byte_data(client,
268 				  LM63_REG_REMOTE_LOW_MSB) << 8)
269 				| i2c_smbus_read_byte_data(client,
270 				  LM63_REG_REMOTE_LOW_LSB);
271 		data->temp11[2] = (i2c_smbus_read_byte_data(client,
272 				  LM63_REG_REMOTE_HIGH_MSB) << 8)
273 				| i2c_smbus_read_byte_data(client,
274 				  LM63_REG_REMOTE_HIGH_LSB);
275 		data->temp11[3] = (i2c_smbus_read_byte_data(client,
276 				  LM63_REG_REMOTE_OFFSET_MSB) << 8)
277 				| i2c_smbus_read_byte_data(client,
278 				  LM63_REG_REMOTE_OFFSET_LSB);
279 
280 		if (data->kind == lm96163)
281 			data->temp11u = (i2c_smbus_read_byte_data(client,
282 					LM96163_REG_REMOTE_TEMP_U_MSB) << 8)
283 				      | i2c_smbus_read_byte_data(client,
284 					LM96163_REG_REMOTE_TEMP_U_LSB);
285 
286 		data->temp8[2] = i2c_smbus_read_byte_data(client,
287 				 LM63_REG_REMOTE_TCRIT);
288 		data->temp2_crit_hyst = i2c_smbus_read_byte_data(client,
289 					LM63_REG_REMOTE_TCRIT_HYST);
290 
291 		data->alarms = i2c_smbus_read_byte_data(client,
292 			       LM63_REG_ALERT_STATUS) & 0x7F;
293 
294 		data->last_updated = jiffies;
295 		data->valid = true;
296 	}
297 
298 	lm63_update_lut(data);
299 
300 	mutex_unlock(&data->update_lock);
301 
302 	return data;
303 }
304 
305 /*
306  * Trip points in the lookup table should be in ascending order for both
307  * temperatures and PWM output values.
308  */
309 static int lm63_lut_looks_bad(struct device *dev, struct lm63_data *data)
310 {
311 	int i;
312 
313 	mutex_lock(&data->update_lock);
314 	lm63_update_lut(data);
315 
316 	for (i = 1; i < data->lut_size; i++) {
317 		if (data->pwm1[1 + i - 1] > data->pwm1[1 + i]
318 		 || data->temp8[3 + i - 1] > data->temp8[3 + i]) {
319 			dev_warn(dev,
320 				 "Lookup table doesn't look sane (check entries %d and %d)\n",
321 				 i, i + 1);
322 			break;
323 		}
324 	}
325 	mutex_unlock(&data->update_lock);
326 
327 	return i == data->lut_size ? 0 : 1;
328 }
329 
330 /*
331  * Sysfs callback functions and files
332  */
333 
334 static ssize_t show_fan(struct device *dev, struct device_attribute *devattr,
335 			char *buf)
336 {
337 	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
338 	struct lm63_data *data = lm63_update_device(dev);
339 	int fan;
340 
341 	mutex_lock(&data->update_lock);
342 	fan = FAN_FROM_REG(data->fan[attr->index]);
343 	mutex_unlock(&data->update_lock);
344 
345 	return sprintf(buf, "%d\n", fan);
346 }
347 
348 static ssize_t set_fan(struct device *dev, struct device_attribute *dummy,
349 		       const char *buf, size_t count)
350 {
351 	struct lm63_data *data = dev_get_drvdata(dev);
352 	struct i2c_client *client = data->client;
353 	unsigned long val;
354 	int err;
355 
356 	err = kstrtoul(buf, 10, &val);
357 	if (err)
358 		return err;
359 
360 	mutex_lock(&data->update_lock);
361 	data->fan[1] = FAN_TO_REG(val);
362 	i2c_smbus_write_byte_data(client, LM63_REG_TACH_LIMIT_LSB,
363 				  data->fan[1] & 0xFF);
364 	i2c_smbus_write_byte_data(client, LM63_REG_TACH_LIMIT_MSB,
365 				  data->fan[1] >> 8);
366 	mutex_unlock(&data->update_lock);
367 	return count;
368 }
369 
370 static ssize_t show_pwm1(struct device *dev, struct device_attribute *devattr,
371 			 char *buf)
372 {
373 	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
374 	struct lm63_data *data = lm63_update_device(dev);
375 	int nr = attr->index;
376 	int pwm;
377 
378 	mutex_lock(&data->update_lock);
379 	if (data->pwm_highres)
380 		pwm = data->pwm1[nr];
381 	else
382 		pwm = data->pwm1[nr] >= 2 * data->pwm1_freq ?
383 		       255 : (data->pwm1[nr] * 255 + data->pwm1_freq) /
384 		       (2 * data->pwm1_freq);
385 	mutex_unlock(&data->update_lock);
386 
387 	return sprintf(buf, "%d\n", pwm);
388 }
389 
390 static ssize_t set_pwm1(struct device *dev, struct device_attribute *devattr,
391 			const char *buf, size_t count)
392 {
393 	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
394 	struct lm63_data *data = dev_get_drvdata(dev);
395 	struct i2c_client *client = data->client;
396 	int nr = attr->index;
397 	unsigned long val;
398 	int err;
399 	u8 reg;
400 
401 	if (!(data->config_fan & 0x20)) /* register is read-only */
402 		return -EPERM;
403 
404 	err = kstrtoul(buf, 10, &val);
405 	if (err)
406 		return err;
407 
408 	reg = nr ? LM63_REG_LUT_PWM(nr - 1) : LM63_REG_PWM_VALUE;
409 	val = clamp_val(val, 0, 255);
410 
411 	mutex_lock(&data->update_lock);
412 	data->pwm1[nr] = data->pwm_highres ? val :
413 			(val * data->pwm1_freq * 2 + 127) / 255;
414 	i2c_smbus_write_byte_data(client, reg, data->pwm1[nr]);
415 	mutex_unlock(&data->update_lock);
416 	return count;
417 }
418 
419 static ssize_t pwm1_enable_show(struct device *dev,
420 				struct device_attribute *dummy, char *buf)
421 {
422 	struct lm63_data *data = lm63_update_device(dev);
423 	return sprintf(buf, "%d\n", data->config_fan & 0x20 ? 1 : 2);
424 }
425 
426 static ssize_t pwm1_enable_store(struct device *dev,
427 				 struct device_attribute *dummy,
428 				 const char *buf, size_t count)
429 {
430 	struct lm63_data *data = dev_get_drvdata(dev);
431 	struct i2c_client *client = data->client;
432 	unsigned long val;
433 	int err;
434 
435 	err = kstrtoul(buf, 10, &val);
436 	if (err)
437 		return err;
438 	if (val < 1 || val > 2)
439 		return -EINVAL;
440 
441 	/*
442 	 * Only let the user switch to automatic mode if the lookup table
443 	 * looks sane.
444 	 */
445 	if (val == 2 && lm63_lut_looks_bad(dev, data))
446 		return -EPERM;
447 
448 	mutex_lock(&data->update_lock);
449 	data->config_fan = i2c_smbus_read_byte_data(client,
450 						    LM63_REG_CONFIG_FAN);
451 	if (val == 1)
452 		data->config_fan |= 0x20;
453 	else
454 		data->config_fan &= ~0x20;
455 	i2c_smbus_write_byte_data(client, LM63_REG_CONFIG_FAN,
456 				  data->config_fan);
457 	mutex_unlock(&data->update_lock);
458 	return count;
459 }
460 
461 static ssize_t pwm1_freq_show(struct device *dev,
462 			      struct device_attribute *dummy, char *buf)
463 {
464 	struct lm63_data *data = lm63_update_device(dev);
465 	unsigned int base, freq;
466 
467 	mutex_lock(&data->update_lock);
468 	base = (data->config_fan & 0x08) ?
469 	       LM63_PWM_BASE_SLOW_HZ : LM63_PWM_BASE_FAST_HZ;
470 	freq = data->pwm1_freq;
471 	mutex_unlock(&data->update_lock);
472 
473 	return sprintf(buf, "%u\n", base / freq);
474 }
475 
476 /*
477  * Pick the closest CONFIG_FAN.SCS + PFR for the requested frequency.
478  * PWM_FREQ writes need the LUT unlocked, same as set_pwm1(). LUT PWM
479  * bytes are register-relative; rewrite them after a frequency change
480  * if duty cycles must be preserved.
481  */
482 static ssize_t pwm1_freq_store(struct device *dev,
483 			       struct device_attribute *dummy,
484 			       const char *buf, size_t count)
485 {
486 	struct lm63_data *data = dev_get_drvdata(dev);
487 	struct i2c_client *client = data->client;
488 	unsigned long val, pfr_fast, pfr_slow, err_fast, err_slow, pfr;
489 	bool slow_clock;
490 	int ret;
491 
492 	ret = kstrtoul(buf, 10, &val);
493 	if (ret)
494 		return ret;
495 	if (val == 0)
496 		return -EINVAL;
497 
498 	pfr_fast = clamp_val(DIV_ROUND_CLOSEST((unsigned long)LM63_PWM_BASE_FAST_HZ, val),
499 			     1UL, 31UL);
500 	pfr_slow = clamp_val(DIV_ROUND_CLOSEST((unsigned long)LM63_PWM_BASE_SLOW_HZ, val),
501 			     1UL, 31UL);
502 	err_fast = abs_diff(LM63_PWM_BASE_FAST_HZ / pfr_fast, val);
503 	err_slow = abs_diff(LM63_PWM_BASE_SLOW_HZ / pfr_slow, val);
504 
505 	if (err_slow < err_fast) {
506 		slow_clock = true;
507 		pfr = pfr_slow;
508 	} else {
509 		slow_clock = false;
510 		pfr = pfr_fast;
511 	}
512 
513 	mutex_lock(&data->update_lock);
514 	ret = i2c_smbus_read_byte_data(client, LM63_REG_CONFIG_FAN);
515 	if (ret < 0) {
516 		mutex_unlock(&data->update_lock);
517 		return ret;
518 	}
519 	data->config_fan = ret;
520 
521 	if (!(data->config_fan & 0x20)) { /* register is read-only */
522 		mutex_unlock(&data->update_lock);
523 		return -EPERM;
524 	}
525 
526 	if (data->kind == lm96163) {
527 		ret = i2c_smbus_read_byte_data(client, LM96163_REG_CONFIG_ENHANCED);
528 		if (ret < 0) {
529 			mutex_unlock(&data->update_lock);
530 			return ret;
531 		}
532 		data->pwm_highres = !slow_clock && pfr == 8 && (ret & 0x10);
533 	}
534 
535 	if (slow_clock)
536 		data->config_fan |= 0x08;
537 	else
538 		data->config_fan &= ~0x08;
539 	i2c_smbus_write_byte_data(client, LM63_REG_CONFIG_FAN, data->config_fan);
540 	i2c_smbus_write_byte_data(client, LM63_REG_PWM_FREQ, pfr);
541 	data->pwm1_freq = pfr;
542 	mutex_unlock(&data->update_lock);
543 	return count;
544 }
545 
546 /*
547  * There are 8bit registers for both local(temp1) and remote(temp2) sensor.
548  * For remote sensor registers temp2_offset has to be considered,
549  * for local sensor it must not.
550  * So we need separate 8bit accessors for local and remote sensor.
551  */
552 static ssize_t show_local_temp8(struct device *dev,
553 				struct device_attribute *devattr,
554 				char *buf)
555 {
556 	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
557 	struct lm63_data *data = lm63_update_device(dev);
558 	return sprintf(buf, "%d\n", TEMP8_FROM_REG(data->temp8[attr->index]));
559 }
560 
561 static ssize_t show_remote_temp8(struct device *dev,
562 				 struct device_attribute *devattr,
563 				 char *buf)
564 {
565 	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
566 	struct lm63_data *data = lm63_update_device(dev);
567 	return sprintf(buf, "%d\n", temp8_from_reg(data, attr->index)
568 		       + data->temp2_offset);
569 }
570 
571 static ssize_t show_lut_temp(struct device *dev,
572 			      struct device_attribute *devattr,
573 			      char *buf)
574 {
575 	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
576 	struct lm63_data *data = lm63_update_device(dev);
577 	return sprintf(buf, "%d\n", lut_temp_from_reg(data, attr->index)
578 		       + data->temp2_offset);
579 }
580 
581 static ssize_t set_temp8(struct device *dev, struct device_attribute *devattr,
582 			 const char *buf, size_t count)
583 {
584 	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
585 	struct lm63_data *data = dev_get_drvdata(dev);
586 	struct i2c_client *client = data->client;
587 	int nr = attr->index;
588 	long val;
589 	int err;
590 	int temp;
591 	u8 reg;
592 
593 	err = kstrtol(buf, 10, &val);
594 	if (err)
595 		return err;
596 
597 	mutex_lock(&data->update_lock);
598 	switch (nr) {
599 	case 2:
600 		reg = LM63_REG_REMOTE_TCRIT;
601 		if (data->remote_unsigned)
602 			temp = TEMP8U_TO_REG(val - data->temp2_offset);
603 		else
604 			temp = TEMP8_TO_REG(val - data->temp2_offset);
605 		break;
606 	case 1:
607 		reg = LM63_REG_LOCAL_HIGH;
608 		temp = TEMP8_TO_REG(val);
609 		break;
610 	default:	/* lookup table */
611 		reg = LM63_REG_LUT_TEMP(nr - 3);
612 		temp = lut_temp_to_reg(data, val);
613 	}
614 	data->temp8[nr] = temp;
615 	i2c_smbus_write_byte_data(client, reg, temp);
616 	mutex_unlock(&data->update_lock);
617 	return count;
618 }
619 
620 static ssize_t show_temp11(struct device *dev, struct device_attribute *devattr,
621 			   char *buf)
622 {
623 	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
624 	struct lm63_data *data = lm63_update_device(dev);
625 	int nr = attr->index;
626 	int temp;
627 
628 	mutex_lock(&data->update_lock);
629 	if (!nr) {
630 		/*
631 		 * Use unsigned temperature unless its value is zero.
632 		 * If it is zero, use signed temperature.
633 		 */
634 		if (data->temp11u)
635 			temp = TEMP11_FROM_REG(data->temp11u);
636 		else
637 			temp = TEMP11_FROM_REG(data->temp11[nr]);
638 	} else {
639 		if (data->remote_unsigned && nr == 2)
640 			temp = TEMP11_FROM_REG((u16)data->temp11[nr]);
641 		else
642 			temp = TEMP11_FROM_REG(data->temp11[nr]);
643 	}
644 	temp += data->temp2_offset;
645 	mutex_unlock(&data->update_lock);
646 
647 	return sprintf(buf, "%d\n", temp);
648 }
649 
650 static ssize_t set_temp11(struct device *dev, struct device_attribute *devattr,
651 			  const char *buf, size_t count)
652 {
653 	static const u8 reg[6] = {
654 		LM63_REG_REMOTE_LOW_MSB,
655 		LM63_REG_REMOTE_LOW_LSB,
656 		LM63_REG_REMOTE_HIGH_MSB,
657 		LM63_REG_REMOTE_HIGH_LSB,
658 		LM63_REG_REMOTE_OFFSET_MSB,
659 		LM63_REG_REMOTE_OFFSET_LSB,
660 	};
661 
662 	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
663 	struct lm63_data *data = dev_get_drvdata(dev);
664 	struct i2c_client *client = data->client;
665 	long val;
666 	int err;
667 	int nr = attr->index;
668 
669 	err = kstrtol(buf, 10, &val);
670 	if (err)
671 		return err;
672 
673 	mutex_lock(&data->update_lock);
674 	if (data->remote_unsigned && nr == 2)
675 		data->temp11[nr] = TEMP11U_TO_REG(val - data->temp2_offset);
676 	else
677 		data->temp11[nr] = TEMP11_TO_REG(val - data->temp2_offset);
678 
679 	i2c_smbus_write_byte_data(client, reg[(nr - 1) * 2],
680 				  data->temp11[nr] >> 8);
681 	i2c_smbus_write_byte_data(client, reg[(nr - 1) * 2 + 1],
682 				  data->temp11[nr] & 0xff);
683 	mutex_unlock(&data->update_lock);
684 	return count;
685 }
686 
687 /*
688  * Hysteresis register holds a relative value, while we want to present
689  * an absolute to user-space
690  */
691 static ssize_t temp2_crit_hyst_show(struct device *dev,
692 				    struct device_attribute *dummy, char *buf)
693 {
694 	struct lm63_data *data = lm63_update_device(dev);
695 	int temp;
696 
697 	mutex_lock(&data->update_lock);
698 	temp = temp8_from_reg(data, 2) + data->temp2_offset
699 	     - TEMP8_FROM_REG(data->temp2_crit_hyst);
700 	mutex_unlock(&data->update_lock);
701 
702 	return sprintf(buf, "%d\n", temp);
703 }
704 
705 static ssize_t show_lut_temp_hyst(struct device *dev,
706 				  struct device_attribute *devattr, char *buf)
707 {
708 	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
709 	struct lm63_data *data = lm63_update_device(dev);
710 	int temp;
711 
712 	mutex_lock(&data->update_lock);
713 	temp = lut_temp_from_reg(data, attr->index) + data->temp2_offset
714 	     - TEMP8_FROM_REG(data->lut_temp_hyst);
715 	mutex_unlock(&data->update_lock);
716 
717 	return sprintf(buf, "%d\n", temp);
718 }
719 
720 /*
721  * The LM63 has a single hysteresis register shared by all LUT entries.
722  * Expose it as a chip-wide hysteresis amount in millidegrees; the
723  * per-point pwm1_auto_pointN_temp_hyst attributes remain read-only and
724  * show the resulting absolute trip-down temperature for each entry.
725  */
726 static ssize_t pwm1_auto_point_temp_hyst_show(struct device *dev,
727 					      struct device_attribute *dummy,
728 					      char *buf)
729 {
730 	struct lm63_data *data = lm63_update_device(dev);
731 	u8 hyst;
732 
733 	mutex_lock(&data->update_lock);
734 	hyst = data->lut_temp_hyst;
735 	mutex_unlock(&data->update_lock);
736 
737 	return sprintf(buf, "%d\n", TEMP8_FROM_REG(hyst));
738 }
739 
740 static ssize_t pwm1_auto_point_temp_hyst_store(struct device *dev,
741 					       struct device_attribute *dummy,
742 					       const char *buf, size_t count)
743 {
744 	struct lm63_data *data = dev_get_drvdata(dev);
745 	struct i2c_client *client = data->client;
746 	unsigned long val;
747 	int err;
748 
749 	err = kstrtoul(buf, 10, &val);
750 	if (err)
751 		return err;
752 
753 	mutex_lock(&data->update_lock);
754 	data->lut_temp_hyst = HYST_TO_REG(val);
755 	i2c_smbus_write_byte_data(client, LM63_REG_LUT_TEMP_HYST,
756 				  data->lut_temp_hyst);
757 	mutex_unlock(&data->update_lock);
758 	return count;
759 }
760 
761 /*
762  * And now the other way around, user-space provides an absolute
763  * hysteresis value and we have to store a relative one
764  */
765 static ssize_t temp2_crit_hyst_store(struct device *dev,
766 				     struct device_attribute *dummy,
767 				     const char *buf, size_t count)
768 {
769 	struct lm63_data *data = lm63_update_device(dev);
770 	struct i2c_client *client = data->client;
771 	long val;
772 	int err;
773 	long hyst;
774 
775 	err = kstrtol(buf, 10, &val);
776 	if (err)
777 		return err;
778 
779 	mutex_lock(&data->update_lock);
780 	hyst = temp8_from_reg(data, 2) + data->temp2_offset - val;
781 	i2c_smbus_write_byte_data(client, LM63_REG_REMOTE_TCRIT_HYST,
782 				  HYST_TO_REG(hyst));
783 	mutex_unlock(&data->update_lock);
784 	return count;
785 }
786 
787 /*
788  * Set conversion rate.
789  * client->update_lock must be held when calling this function.
790  */
791 static void lm63_set_convrate(struct lm63_data *data, unsigned int interval)
792 {
793 	struct i2c_client *client = data->client;
794 	unsigned int update_interval;
795 	int i;
796 
797 	/* Shift calculations to avoid rounding errors */
798 	interval <<= 6;
799 
800 	/* find the nearest update rate */
801 	update_interval = (1 << (LM63_MAX_CONVRATE + 6)) * 1000
802 	  / data->max_convrate_hz;
803 	for (i = 0; i < LM63_MAX_CONVRATE; i++, update_interval >>= 1)
804 		if (interval >= update_interval * 3 / 4)
805 			break;
806 
807 	i2c_smbus_write_byte_data(client, LM63_REG_CONVRATE, i);
808 	data->update_interval = UPDATE_INTERVAL(data->max_convrate_hz, i);
809 }
810 
811 static ssize_t update_interval_show(struct device *dev,
812 				    struct device_attribute *attr, char *buf)
813 {
814 	struct lm63_data *data = dev_get_drvdata(dev);
815 
816 	return sprintf(buf, "%u\n", data->update_interval);
817 }
818 
819 static ssize_t update_interval_store(struct device *dev,
820 				     struct device_attribute *attr,
821 				     const char *buf, size_t count)
822 {
823 	struct lm63_data *data = dev_get_drvdata(dev);
824 	unsigned long val;
825 	int err;
826 
827 	err = kstrtoul(buf, 10, &val);
828 	if (err)
829 		return err;
830 
831 	mutex_lock(&data->update_lock);
832 	lm63_set_convrate(data, clamp_val(val, 0, 100000));
833 	mutex_unlock(&data->update_lock);
834 
835 	return count;
836 }
837 
838 static ssize_t temp2_type_show(struct device *dev,
839 			       struct device_attribute *attr, char *buf)
840 {
841 	struct lm63_data *data = dev_get_drvdata(dev);
842 
843 	return sprintf(buf, data->trutherm ? "1\n" : "2\n");
844 }
845 
846 static ssize_t temp2_type_store(struct device *dev,
847 				struct device_attribute *attr,
848 				const char *buf, size_t count)
849 {
850 	struct lm63_data *data = dev_get_drvdata(dev);
851 	struct i2c_client *client = data->client;
852 	unsigned long val;
853 	int ret;
854 	u8 reg;
855 
856 	ret = kstrtoul(buf, 10, &val);
857 	if (ret < 0)
858 		return ret;
859 	if (val != 1 && val != 2)
860 		return -EINVAL;
861 
862 	mutex_lock(&data->update_lock);
863 	data->trutherm = val == 1;
864 	reg = i2c_smbus_read_byte_data(client, LM96163_REG_TRUTHERM) & ~0x02;
865 	i2c_smbus_write_byte_data(client, LM96163_REG_TRUTHERM,
866 				  reg | (data->trutherm ? 0x02 : 0x00));
867 	data->valid = false;
868 	mutex_unlock(&data->update_lock);
869 
870 	return count;
871 }
872 
873 static ssize_t alarms_show(struct device *dev, struct device_attribute *dummy,
874 			   char *buf)
875 {
876 	struct lm63_data *data = lm63_update_device(dev);
877 	return sprintf(buf, "%u\n", data->alarms);
878 }
879 
880 static ssize_t show_alarm(struct device *dev, struct device_attribute *devattr,
881 			  char *buf)
882 {
883 	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
884 	struct lm63_data *data = lm63_update_device(dev);
885 	int bitnr = attr->index;
886 
887 	return sprintf(buf, "%u\n", (data->alarms >> bitnr) & 1);
888 }
889 
890 static SENSOR_DEVICE_ATTR(fan1_input, S_IRUGO, show_fan, NULL, 0);
891 static SENSOR_DEVICE_ATTR(fan1_min, S_IWUSR | S_IRUGO, show_fan,
892 	set_fan, 1);
893 
894 static SENSOR_DEVICE_ATTR(pwm1, S_IWUSR | S_IRUGO, show_pwm1, set_pwm1, 0);
895 static DEVICE_ATTR_RW(pwm1_enable);
896 static DEVICE_ATTR_RW(pwm1_freq);
897 static DEVICE_ATTR_RW(pwm1_auto_point_temp_hyst);
898 static SENSOR_DEVICE_ATTR(pwm1_auto_point1_pwm, S_IWUSR | S_IRUGO,
899 	show_pwm1, set_pwm1, 1);
900 static SENSOR_DEVICE_ATTR(pwm1_auto_point1_temp, S_IWUSR | S_IRUGO,
901 	show_lut_temp, set_temp8, 3);
902 static SENSOR_DEVICE_ATTR(pwm1_auto_point1_temp_hyst, S_IRUGO,
903 	show_lut_temp_hyst, NULL, 3);
904 static SENSOR_DEVICE_ATTR(pwm1_auto_point2_pwm, S_IWUSR | S_IRUGO,
905 	show_pwm1, set_pwm1, 2);
906 static SENSOR_DEVICE_ATTR(pwm1_auto_point2_temp, S_IWUSR | S_IRUGO,
907 	show_lut_temp, set_temp8, 4);
908 static SENSOR_DEVICE_ATTR(pwm1_auto_point2_temp_hyst, S_IRUGO,
909 	show_lut_temp_hyst, NULL, 4);
910 static SENSOR_DEVICE_ATTR(pwm1_auto_point3_pwm, S_IWUSR | S_IRUGO,
911 	show_pwm1, set_pwm1, 3);
912 static SENSOR_DEVICE_ATTR(pwm1_auto_point3_temp, S_IWUSR | S_IRUGO,
913 	show_lut_temp, set_temp8, 5);
914 static SENSOR_DEVICE_ATTR(pwm1_auto_point3_temp_hyst, S_IRUGO,
915 	show_lut_temp_hyst, NULL, 5);
916 static SENSOR_DEVICE_ATTR(pwm1_auto_point4_pwm, S_IWUSR | S_IRUGO,
917 	show_pwm1, set_pwm1, 4);
918 static SENSOR_DEVICE_ATTR(pwm1_auto_point4_temp, S_IWUSR | S_IRUGO,
919 	show_lut_temp, set_temp8, 6);
920 static SENSOR_DEVICE_ATTR(pwm1_auto_point4_temp_hyst, S_IRUGO,
921 	show_lut_temp_hyst, NULL, 6);
922 static SENSOR_DEVICE_ATTR(pwm1_auto_point5_pwm, S_IWUSR | S_IRUGO,
923 	show_pwm1, set_pwm1, 5);
924 static SENSOR_DEVICE_ATTR(pwm1_auto_point5_temp, S_IWUSR | S_IRUGO,
925 	show_lut_temp, set_temp8, 7);
926 static SENSOR_DEVICE_ATTR(pwm1_auto_point5_temp_hyst, S_IRUGO,
927 	show_lut_temp_hyst, NULL, 7);
928 static SENSOR_DEVICE_ATTR(pwm1_auto_point6_pwm, S_IWUSR | S_IRUGO,
929 	show_pwm1, set_pwm1, 6);
930 static SENSOR_DEVICE_ATTR(pwm1_auto_point6_temp, S_IWUSR | S_IRUGO,
931 	show_lut_temp, set_temp8, 8);
932 static SENSOR_DEVICE_ATTR(pwm1_auto_point6_temp_hyst, S_IRUGO,
933 	show_lut_temp_hyst, NULL, 8);
934 static SENSOR_DEVICE_ATTR(pwm1_auto_point7_pwm, S_IWUSR | S_IRUGO,
935 	show_pwm1, set_pwm1, 7);
936 static SENSOR_DEVICE_ATTR(pwm1_auto_point7_temp, S_IWUSR | S_IRUGO,
937 	show_lut_temp, set_temp8, 9);
938 static SENSOR_DEVICE_ATTR(pwm1_auto_point7_temp_hyst, S_IRUGO,
939 	show_lut_temp_hyst, NULL, 9);
940 static SENSOR_DEVICE_ATTR(pwm1_auto_point8_pwm, S_IWUSR | S_IRUGO,
941 	show_pwm1, set_pwm1, 8);
942 static SENSOR_DEVICE_ATTR(pwm1_auto_point8_temp, S_IWUSR | S_IRUGO,
943 	show_lut_temp, set_temp8, 10);
944 static SENSOR_DEVICE_ATTR(pwm1_auto_point8_temp_hyst, S_IRUGO,
945 	show_lut_temp_hyst, NULL, 10);
946 static SENSOR_DEVICE_ATTR(pwm1_auto_point9_pwm, S_IWUSR | S_IRUGO,
947 	show_pwm1, set_pwm1, 9);
948 static SENSOR_DEVICE_ATTR(pwm1_auto_point9_temp, S_IWUSR | S_IRUGO,
949 	show_lut_temp, set_temp8, 11);
950 static SENSOR_DEVICE_ATTR(pwm1_auto_point9_temp_hyst, S_IRUGO,
951 	show_lut_temp_hyst, NULL, 11);
952 static SENSOR_DEVICE_ATTR(pwm1_auto_point10_pwm, S_IWUSR | S_IRUGO,
953 	show_pwm1, set_pwm1, 10);
954 static SENSOR_DEVICE_ATTR(pwm1_auto_point10_temp, S_IWUSR | S_IRUGO,
955 	show_lut_temp, set_temp8, 12);
956 static SENSOR_DEVICE_ATTR(pwm1_auto_point10_temp_hyst, S_IRUGO,
957 	show_lut_temp_hyst, NULL, 12);
958 static SENSOR_DEVICE_ATTR(pwm1_auto_point11_pwm, S_IWUSR | S_IRUGO,
959 	show_pwm1, set_pwm1, 11);
960 static SENSOR_DEVICE_ATTR(pwm1_auto_point11_temp, S_IWUSR | S_IRUGO,
961 	show_lut_temp, set_temp8, 13);
962 static SENSOR_DEVICE_ATTR(pwm1_auto_point11_temp_hyst, S_IRUGO,
963 	show_lut_temp_hyst, NULL, 13);
964 static SENSOR_DEVICE_ATTR(pwm1_auto_point12_pwm, S_IWUSR | S_IRUGO,
965 	show_pwm1, set_pwm1, 12);
966 static SENSOR_DEVICE_ATTR(pwm1_auto_point12_temp, S_IWUSR | S_IRUGO,
967 	show_lut_temp, set_temp8, 14);
968 static SENSOR_DEVICE_ATTR(pwm1_auto_point12_temp_hyst, S_IRUGO,
969 	show_lut_temp_hyst, NULL, 14);
970 
971 static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, show_local_temp8, NULL, 0);
972 static SENSOR_DEVICE_ATTR(temp1_max, S_IWUSR | S_IRUGO, show_local_temp8,
973 	set_temp8, 1);
974 
975 static SENSOR_DEVICE_ATTR(temp2_input, S_IRUGO, show_temp11, NULL, 0);
976 static SENSOR_DEVICE_ATTR(temp2_min, S_IWUSR | S_IRUGO, show_temp11,
977 	set_temp11, 1);
978 static SENSOR_DEVICE_ATTR(temp2_max, S_IWUSR | S_IRUGO, show_temp11,
979 	set_temp11, 2);
980 static SENSOR_DEVICE_ATTR(temp2_offset, S_IWUSR | S_IRUGO, show_temp11,
981 	set_temp11, 3);
982 static SENSOR_DEVICE_ATTR(temp2_crit, S_IRUGO, show_remote_temp8,
983 	set_temp8, 2);
984 static DEVICE_ATTR_RW(temp2_crit_hyst);
985 
986 static DEVICE_ATTR_RW(temp2_type);
987 
988 /* Individual alarm files */
989 static SENSOR_DEVICE_ATTR(fan1_min_alarm, S_IRUGO, show_alarm, NULL, 0);
990 static SENSOR_DEVICE_ATTR(temp2_crit_alarm, S_IRUGO, show_alarm, NULL, 1);
991 static SENSOR_DEVICE_ATTR(temp2_fault, S_IRUGO, show_alarm, NULL, 2);
992 static SENSOR_DEVICE_ATTR(temp2_min_alarm, S_IRUGO, show_alarm, NULL, 3);
993 static SENSOR_DEVICE_ATTR(temp2_max_alarm, S_IRUGO, show_alarm, NULL, 4);
994 static SENSOR_DEVICE_ATTR(temp1_max_alarm, S_IRUGO, show_alarm, NULL, 6);
995 /* Raw alarm file for compatibility */
996 static DEVICE_ATTR_RO(alarms);
997 
998 static DEVICE_ATTR_RW(update_interval);
999 
1000 static struct attribute *lm63_attributes[] = {
1001 	&sensor_dev_attr_pwm1.dev_attr.attr,
1002 	&dev_attr_pwm1_enable.attr,
1003 	&dev_attr_pwm1_freq.attr,
1004 	&dev_attr_pwm1_auto_point_temp_hyst.attr,
1005 	&sensor_dev_attr_pwm1_auto_point1_pwm.dev_attr.attr,
1006 	&sensor_dev_attr_pwm1_auto_point1_temp.dev_attr.attr,
1007 	&sensor_dev_attr_pwm1_auto_point1_temp_hyst.dev_attr.attr,
1008 	&sensor_dev_attr_pwm1_auto_point2_pwm.dev_attr.attr,
1009 	&sensor_dev_attr_pwm1_auto_point2_temp.dev_attr.attr,
1010 	&sensor_dev_attr_pwm1_auto_point2_temp_hyst.dev_attr.attr,
1011 	&sensor_dev_attr_pwm1_auto_point3_pwm.dev_attr.attr,
1012 	&sensor_dev_attr_pwm1_auto_point3_temp.dev_attr.attr,
1013 	&sensor_dev_attr_pwm1_auto_point3_temp_hyst.dev_attr.attr,
1014 	&sensor_dev_attr_pwm1_auto_point4_pwm.dev_attr.attr,
1015 	&sensor_dev_attr_pwm1_auto_point4_temp.dev_attr.attr,
1016 	&sensor_dev_attr_pwm1_auto_point4_temp_hyst.dev_attr.attr,
1017 	&sensor_dev_attr_pwm1_auto_point5_pwm.dev_attr.attr,
1018 	&sensor_dev_attr_pwm1_auto_point5_temp.dev_attr.attr,
1019 	&sensor_dev_attr_pwm1_auto_point5_temp_hyst.dev_attr.attr,
1020 	&sensor_dev_attr_pwm1_auto_point6_pwm.dev_attr.attr,
1021 	&sensor_dev_attr_pwm1_auto_point6_temp.dev_attr.attr,
1022 	&sensor_dev_attr_pwm1_auto_point6_temp_hyst.dev_attr.attr,
1023 	&sensor_dev_attr_pwm1_auto_point7_pwm.dev_attr.attr,
1024 	&sensor_dev_attr_pwm1_auto_point7_temp.dev_attr.attr,
1025 	&sensor_dev_attr_pwm1_auto_point7_temp_hyst.dev_attr.attr,
1026 	&sensor_dev_attr_pwm1_auto_point8_pwm.dev_attr.attr,
1027 	&sensor_dev_attr_pwm1_auto_point8_temp.dev_attr.attr,
1028 	&sensor_dev_attr_pwm1_auto_point8_temp_hyst.dev_attr.attr,
1029 
1030 	&sensor_dev_attr_temp1_input.dev_attr.attr,
1031 	&sensor_dev_attr_temp2_input.dev_attr.attr,
1032 	&sensor_dev_attr_temp2_min.dev_attr.attr,
1033 	&sensor_dev_attr_temp1_max.dev_attr.attr,
1034 	&sensor_dev_attr_temp2_max.dev_attr.attr,
1035 	&sensor_dev_attr_temp2_offset.dev_attr.attr,
1036 	&sensor_dev_attr_temp2_crit.dev_attr.attr,
1037 	&dev_attr_temp2_crit_hyst.attr,
1038 
1039 	&sensor_dev_attr_temp2_crit_alarm.dev_attr.attr,
1040 	&sensor_dev_attr_temp2_fault.dev_attr.attr,
1041 	&sensor_dev_attr_temp2_min_alarm.dev_attr.attr,
1042 	&sensor_dev_attr_temp2_max_alarm.dev_attr.attr,
1043 	&sensor_dev_attr_temp1_max_alarm.dev_attr.attr,
1044 	&dev_attr_alarms.attr,
1045 	&dev_attr_update_interval.attr,
1046 	NULL
1047 };
1048 
1049 static struct attribute *lm63_attributes_temp2_type[] = {
1050 	&dev_attr_temp2_type.attr,
1051 	NULL
1052 };
1053 
1054 static const struct attribute_group lm63_group_temp2_type = {
1055 	.attrs = lm63_attributes_temp2_type,
1056 };
1057 
1058 static struct attribute *lm63_attributes_extra_lut[] = {
1059 	&sensor_dev_attr_pwm1_auto_point9_pwm.dev_attr.attr,
1060 	&sensor_dev_attr_pwm1_auto_point9_temp.dev_attr.attr,
1061 	&sensor_dev_attr_pwm1_auto_point9_temp_hyst.dev_attr.attr,
1062 	&sensor_dev_attr_pwm1_auto_point10_pwm.dev_attr.attr,
1063 	&sensor_dev_attr_pwm1_auto_point10_temp.dev_attr.attr,
1064 	&sensor_dev_attr_pwm1_auto_point10_temp_hyst.dev_attr.attr,
1065 	&sensor_dev_attr_pwm1_auto_point11_pwm.dev_attr.attr,
1066 	&sensor_dev_attr_pwm1_auto_point11_temp.dev_attr.attr,
1067 	&sensor_dev_attr_pwm1_auto_point11_temp_hyst.dev_attr.attr,
1068 	&sensor_dev_attr_pwm1_auto_point12_pwm.dev_attr.attr,
1069 	&sensor_dev_attr_pwm1_auto_point12_temp.dev_attr.attr,
1070 	&sensor_dev_attr_pwm1_auto_point12_temp_hyst.dev_attr.attr,
1071 	NULL
1072 };
1073 
1074 static const struct attribute_group lm63_group_extra_lut = {
1075 	.attrs = lm63_attributes_extra_lut,
1076 };
1077 
1078 /*
1079  * On LM63, temp2_crit can be set only once, which should be job
1080  * of the bootloader.
1081  * On LM64, temp2_crit can always be set.
1082  * On LM96163, temp2_crit can be set if bit 1 of the configuration
1083  * register is true.
1084  */
1085 static umode_t lm63_attribute_mode(struct kobject *kobj,
1086 				   struct attribute *attr, int index)
1087 {
1088 	struct device *dev = kobj_to_dev(kobj);
1089 	struct lm63_data *data = dev_get_drvdata(dev);
1090 
1091 	if (attr == &sensor_dev_attr_temp2_crit.dev_attr.attr
1092 	    && (data->kind == lm64 ||
1093 		(data->kind == lm96163 && (data->config & 0x02))))
1094 		return attr->mode | S_IWUSR;
1095 
1096 	return attr->mode;
1097 }
1098 
1099 static const struct attribute_group lm63_group = {
1100 	.is_visible = lm63_attribute_mode,
1101 	.attrs = lm63_attributes,
1102 };
1103 
1104 static struct attribute *lm63_attributes_fan1[] = {
1105 	&sensor_dev_attr_fan1_input.dev_attr.attr,
1106 	&sensor_dev_attr_fan1_min.dev_attr.attr,
1107 
1108 	&sensor_dev_attr_fan1_min_alarm.dev_attr.attr,
1109 	NULL
1110 };
1111 
1112 static const struct attribute_group lm63_group_fan1 = {
1113 	.attrs = lm63_attributes_fan1,
1114 };
1115 
1116 /*
1117  * Real code
1118  */
1119 
1120 /* Return 0 if detection is successful, -ENODEV otherwise */
1121 static int lm63_detect(struct i2c_client *client,
1122 		       struct i2c_board_info *info)
1123 {
1124 	struct i2c_adapter *adapter = client->adapter;
1125 	u8 man_id, chip_id, reg_config1, reg_config2;
1126 	u8 reg_alert_status, reg_alert_mask;
1127 	int address = client->addr;
1128 
1129 	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
1130 		return -ENODEV;
1131 
1132 	man_id = i2c_smbus_read_byte_data(client, LM63_REG_MAN_ID);
1133 	chip_id = i2c_smbus_read_byte_data(client, LM63_REG_CHIP_ID);
1134 
1135 	reg_config1 = i2c_smbus_read_byte_data(client, LM63_REG_CONFIG1);
1136 	reg_config2 = i2c_smbus_read_byte_data(client, LM63_REG_CONFIG2);
1137 	reg_alert_status = i2c_smbus_read_byte_data(client,
1138 			   LM63_REG_ALERT_STATUS);
1139 	reg_alert_mask = i2c_smbus_read_byte_data(client, LM63_REG_ALERT_MASK);
1140 
1141 	if (man_id != 0x01 /* National Semiconductor */
1142 	 || (reg_config1 & 0x18) != 0x00
1143 	 || (reg_config2 & 0xF8) != 0x00
1144 	 || (reg_alert_status & 0x20) != 0x00
1145 	 || (reg_alert_mask & 0xA4) != 0xA4) {
1146 		dev_dbg(&adapter->dev,
1147 			"Unsupported chip (man_id=0x%02X, chip_id=0x%02X)\n",
1148 			man_id, chip_id);
1149 		return -ENODEV;
1150 	}
1151 
1152 	if (chip_id == 0x41 && address == 0x4c)
1153 		strscpy(info->type, "lm63", I2C_NAME_SIZE);
1154 	else if (chip_id == 0x51 && (address == 0x18 || address == 0x4e))
1155 		strscpy(info->type, "lm64", I2C_NAME_SIZE);
1156 	else if (chip_id == 0x49 && address == 0x4c)
1157 		strscpy(info->type, "lm96163", I2C_NAME_SIZE);
1158 	else
1159 		return -ENODEV;
1160 
1161 	return 0;
1162 }
1163 
1164 /*
1165  * Ideally we shouldn't have to initialize anything, since the BIOS
1166  * should have taken care of everything
1167  */
1168 static void lm63_init_client(struct lm63_data *data)
1169 {
1170 	struct i2c_client *client = data->client;
1171 	struct device *dev = &client->dev;
1172 	u8 convrate;
1173 
1174 	data->config = i2c_smbus_read_byte_data(client, LM63_REG_CONFIG1);
1175 	data->config_fan = i2c_smbus_read_byte_data(client,
1176 						    LM63_REG_CONFIG_FAN);
1177 
1178 	/* Start converting if needed */
1179 	if (data->config & 0x40) { /* standby */
1180 		dev_dbg(dev, "Switching to operational mode\n");
1181 		data->config &= 0xA7;
1182 		i2c_smbus_write_byte_data(client, LM63_REG_CONFIG1,
1183 					  data->config);
1184 	}
1185 	/* Tachometer is always enabled on LM64 */
1186 	if (data->kind == lm64)
1187 		data->config |= 0x04;
1188 
1189 	/* We may need pwm1_freq before ever updating the client data */
1190 	data->pwm1_freq = i2c_smbus_read_byte_data(client, LM63_REG_PWM_FREQ);
1191 	if (data->pwm1_freq == 0)
1192 		data->pwm1_freq = 1;
1193 
1194 	switch (data->kind) {
1195 	case lm63:
1196 	case lm64:
1197 		data->max_convrate_hz = LM63_MAX_CONVRATE_HZ;
1198 		data->lut_size = 8;
1199 		break;
1200 	case lm96163:
1201 		data->max_convrate_hz = LM96163_MAX_CONVRATE_HZ;
1202 		data->lut_size = 12;
1203 		data->trutherm
1204 		  = i2c_smbus_read_byte_data(client,
1205 					     LM96163_REG_TRUTHERM) & 0x02;
1206 		break;
1207 	}
1208 	convrate = i2c_smbus_read_byte_data(client, LM63_REG_CONVRATE);
1209 	if (unlikely(convrate > LM63_MAX_CONVRATE))
1210 		convrate = LM63_MAX_CONVRATE;
1211 	data->update_interval = UPDATE_INTERVAL(data->max_convrate_hz,
1212 						convrate);
1213 
1214 	/*
1215 	 * For LM96163, check if high resolution PWM
1216 	 * and unsigned temperature format is enabled.
1217 	 */
1218 	if (data->kind == lm96163) {
1219 		u8 config_enhanced
1220 		  = i2c_smbus_read_byte_data(client,
1221 					     LM96163_REG_CONFIG_ENHANCED);
1222 		if (config_enhanced & 0x20)
1223 			data->lut_temp_highres = true;
1224 		if ((config_enhanced & 0x10)
1225 		    && !(data->config_fan & 0x08) && data->pwm1_freq == 8)
1226 			data->pwm_highres = true;
1227 		if (config_enhanced & 0x08)
1228 			data->remote_unsigned = true;
1229 	}
1230 
1231 	/* Show some debug info about the LM63 configuration */
1232 	if (data->kind == lm63)
1233 		dev_dbg(dev, "Alert/tach pin configured for %s\n",
1234 			(data->config & 0x04) ? "tachometer input" :
1235 			"alert output");
1236 	dev_dbg(dev, "PWM clock %s kHz, output frequency %u Hz\n",
1237 		(data->config_fan & 0x08) ? "1.4" : "360",
1238 		((data->config_fan & 0x08) ? 700 : 180000) / data->pwm1_freq);
1239 	dev_dbg(dev, "PWM output active %s, %s mode\n",
1240 		(data->config_fan & 0x10) ? "low" : "high",
1241 		(data->config_fan & 0x20) ? "manual" : "auto");
1242 }
1243 
1244 static const struct i2c_device_id lm63_id[];
1245 
1246 static int lm63_probe(struct i2c_client *client)
1247 {
1248 	struct device *dev = &client->dev;
1249 	struct device *hwmon_dev;
1250 	struct lm63_data *data;
1251 	int groups = 0;
1252 
1253 	data = devm_kzalloc(dev, sizeof(struct lm63_data), GFP_KERNEL);
1254 	if (!data)
1255 		return -ENOMEM;
1256 
1257 	data->client = client;
1258 	mutex_init(&data->update_lock);
1259 
1260 	/* Set the device type */
1261 	data->kind = (uintptr_t)i2c_get_match_data(client);
1262 	if (data->kind == lm64)
1263 		data->temp2_offset = 16000;
1264 
1265 	/* Initialize chip */
1266 	lm63_init_client(data);
1267 
1268 	/* Register sysfs hooks */
1269 	data->groups[groups++] = &lm63_group;
1270 	if (data->config & 0x04)	/* tachometer enabled */
1271 		data->groups[groups++] = &lm63_group_fan1;
1272 
1273 	if (data->kind == lm96163) {
1274 		data->groups[groups++] = &lm63_group_temp2_type;
1275 		data->groups[groups++] = &lm63_group_extra_lut;
1276 	}
1277 
1278 	hwmon_dev = devm_hwmon_device_register_with_groups(dev, client->name,
1279 							   data, data->groups);
1280 	return PTR_ERR_OR_ZERO(hwmon_dev);
1281 }
1282 
1283 /*
1284  * Driver data (common to all clients)
1285  */
1286 
1287 static const struct i2c_device_id lm63_id[] = {
1288 	{ .name = "lm63", .driver_data = lm63 },
1289 	{ .name = "lm64", .driver_data = lm64 },
1290 	{ .name = "lm96163", .driver_data = lm96163 },
1291 	{ }
1292 };
1293 MODULE_DEVICE_TABLE(i2c, lm63_id);
1294 
1295 static const struct of_device_id __maybe_unused lm63_of_match[] = {
1296 	{
1297 		.compatible = "national,lm63",
1298 		.data = (void *)lm63
1299 	},
1300 	{
1301 		.compatible = "national,lm64",
1302 		.data = (void *)lm64
1303 	},
1304 	{
1305 		.compatible = "national,lm96163",
1306 		.data = (void *)lm96163
1307 	},
1308 	{ },
1309 };
1310 MODULE_DEVICE_TABLE(of, lm63_of_match);
1311 
1312 static struct i2c_driver lm63_driver = {
1313 	.class		= I2C_CLASS_HWMON,
1314 	.driver = {
1315 		.name	= "lm63",
1316 		.of_match_table = of_match_ptr(lm63_of_match),
1317 	},
1318 	.probe		= lm63_probe,
1319 	.id_table	= lm63_id,
1320 	.detect		= lm63_detect,
1321 	.address_list	= normal_i2c,
1322 };
1323 
1324 module_i2c_driver(lm63_driver);
1325 
1326 MODULE_AUTHOR("Jean Delvare <jdelvare@suse.de>");
1327 MODULE_DESCRIPTION("LM63 driver");
1328 MODULE_LICENSE("GPL");
1329