xref: /linux/drivers/net/ethernet/mellanox/mlx5/core/devlink.c (revision 91ec2035134982b98fab0609a9fd8480e8217dc1)
1 // SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB
2 /* Copyright (c) 2019 Mellanox Technologies */
3 
4 #include <devlink.h>
5 
6 #include "mlx5_core.h"
7 #include "fw_reset.h"
8 #include "fs_core.h"
9 #include "eswitch.h"
10 #include "esw/qos.h"
11 #include "sf/dev/dev.h"
12 #include "sf/sf.h"
13 #include "lib/nv_param.h"
14 
mlx5_devlink_flash_update(struct devlink * devlink,struct devlink_flash_update_params * params,struct netlink_ext_ack * extack)15 static int mlx5_devlink_flash_update(struct devlink *devlink,
16 				     struct devlink_flash_update_params *params,
17 				     struct netlink_ext_ack *extack)
18 {
19 	struct mlx5_core_dev *dev = devlink_priv(devlink);
20 
21 	return mlx5_firmware_flash(dev, params->fw, extack);
22 }
23 
mlx5_fw_ver_major(u32 version)24 static u8 mlx5_fw_ver_major(u32 version)
25 {
26 	return (version >> 24) & 0xff;
27 }
28 
mlx5_fw_ver_minor(u32 version)29 static u8 mlx5_fw_ver_minor(u32 version)
30 {
31 	return (version >> 16) & 0xff;
32 }
33 
mlx5_fw_ver_subminor(u32 version)34 static u16 mlx5_fw_ver_subminor(u32 version)
35 {
36 	return version & 0xffff;
37 }
38 
mlx5_devlink_serial_numbers_put(struct mlx5_core_dev * dev,struct devlink_info_req * req,struct netlink_ext_ack * extack)39 static int mlx5_devlink_serial_numbers_put(struct mlx5_core_dev *dev,
40 					   struct devlink_info_req *req,
41 					   struct netlink_ext_ack *extack)
42 {
43 	struct pci_dev *pdev = dev->pdev;
44 	unsigned int vpd_size, kw_len;
45 	char *str, *end;
46 	u8 *vpd_data;
47 	int err = 0;
48 	int start;
49 
50 	vpd_data = pci_vpd_alloc(pdev, &vpd_size);
51 	if (IS_ERR(vpd_data))
52 		return 0;
53 
54 	start = pci_vpd_find_ro_info_keyword(vpd_data, vpd_size,
55 					     PCI_VPD_RO_KEYWORD_SERIALNO, &kw_len);
56 	if (start >= 0) {
57 		str = kstrndup(vpd_data + start, kw_len, GFP_KERNEL);
58 		if (!str) {
59 			err = -ENOMEM;
60 			goto end;
61 		}
62 		end = strchrnul(str, ' ');
63 		*end = '\0';
64 		err = devlink_info_board_serial_number_put(req, str);
65 		kfree(str);
66 		if (err)
67 			goto end;
68 	}
69 
70 	start = pci_vpd_find_ro_info_keyword(vpd_data, vpd_size, "V3", &kw_len);
71 	if (start >= 0) {
72 		str = kstrndup(vpd_data + start, kw_len, GFP_KERNEL);
73 		if (!str) {
74 			err = -ENOMEM;
75 			goto end;
76 		}
77 		err = devlink_info_serial_number_put(req, str);
78 		kfree(str);
79 		if (err)
80 			goto end;
81 	}
82 
83 end:
84 	kfree(vpd_data);
85 	return err;
86 }
87 
88 #define DEVLINK_FW_STRING_LEN 32
89 
90 static int
mlx5_devlink_info_get(struct devlink * devlink,struct devlink_info_req * req,struct netlink_ext_ack * extack)91 mlx5_devlink_info_get(struct devlink *devlink, struct devlink_info_req *req,
92 		      struct netlink_ext_ack *extack)
93 {
94 	struct mlx5_core_dev *dev = devlink_priv(devlink);
95 	char version_str[DEVLINK_FW_STRING_LEN];
96 	u32 running_fw, stored_fw;
97 	int err;
98 
99 	if (!mlx5_core_is_pf(dev))
100 		return 0;
101 
102 	err = mlx5_devlink_serial_numbers_put(dev, req, extack);
103 	if (err)
104 		return err;
105 
106 	err = devlink_info_version_fixed_put(req, "fw.psid", dev->board_id);
107 	if (err)
108 		return err;
109 
110 	mlx5_fw_version_query(dev, &running_fw, &stored_fw);
111 
112 	snprintf(version_str, sizeof(version_str), "%d.%d.%04d",
113 		 mlx5_fw_ver_major(running_fw), mlx5_fw_ver_minor(running_fw),
114 		 mlx5_fw_ver_subminor(running_fw));
115 	err = devlink_info_version_running_put(req, "fw.version", version_str);
116 	if (err)
117 		return err;
118 	err = devlink_info_version_running_put(req,
119 					       DEVLINK_INFO_VERSION_GENERIC_FW,
120 					       version_str);
121 	if (err)
122 		return err;
123 
124 	/* no pending version, return running (stored) version */
125 	if (stored_fw == 0)
126 		stored_fw = running_fw;
127 
128 	snprintf(version_str, sizeof(version_str), "%d.%d.%04d",
129 		 mlx5_fw_ver_major(stored_fw), mlx5_fw_ver_minor(stored_fw),
130 		 mlx5_fw_ver_subminor(stored_fw));
131 	err = devlink_info_version_stored_put(req, "fw.version", version_str);
132 	if (err)
133 		return err;
134 	return devlink_info_version_stored_put(req,
135 					       DEVLINK_INFO_VERSION_GENERIC_FW,
136 					       version_str);
137 }
138 
mlx5_devlink_reload_fw_activate(struct devlink * devlink,struct netlink_ext_ack * extack)139 static int mlx5_devlink_reload_fw_activate(struct devlink *devlink, struct netlink_ext_ack *extack)
140 {
141 	struct mlx5_core_dev *dev = devlink_priv(devlink);
142 	u8 reset_level, reset_type, net_port_alive;
143 	int err;
144 
145 	err = mlx5_fw_reset_query(dev, &reset_level, &reset_type);
146 	if (err)
147 		return err;
148 	if (!(reset_level & MLX5_MFRL_REG_RESET_LEVEL3)) {
149 		NL_SET_ERR_MSG_MOD(extack, "FW activate requires reboot");
150 		return -EINVAL;
151 	}
152 
153 	net_port_alive = !!(reset_type & MLX5_MFRL_REG_RESET_TYPE_NET_PORT_ALIVE);
154 	err = mlx5_fw_reset_set_reset_sync(dev, net_port_alive, extack);
155 	if (err)
156 		return err;
157 
158 	err = mlx5_fw_reset_wait_reset_done(dev);
159 	if (err)
160 		return err;
161 
162 	mlx5_sync_reset_unload_flow(dev, true);
163 	err = mlx5_health_wait_pci_up(dev);
164 	if (err)
165 		NL_SET_ERR_MSG_MOD(extack, "FW activate aborted, PCI reads fail after reset");
166 
167 	return err;
168 }
169 
mlx5_devlink_trigger_fw_live_patch(struct devlink * devlink,struct netlink_ext_ack * extack)170 static int mlx5_devlink_trigger_fw_live_patch(struct devlink *devlink,
171 					      struct netlink_ext_ack *extack)
172 {
173 	struct mlx5_core_dev *dev = devlink_priv(devlink);
174 	u8 reset_level;
175 	int err;
176 
177 	err = mlx5_fw_reset_query(dev, &reset_level, NULL);
178 	if (err)
179 		return err;
180 	if (!(reset_level & MLX5_MFRL_REG_RESET_LEVEL0)) {
181 		NL_SET_ERR_MSG_MOD(extack,
182 				   "FW upgrade to the stored FW can't be done by FW live patching");
183 		return -EINVAL;
184 	}
185 
186 	return mlx5_fw_reset_set_live_patch(dev);
187 }
188 
mlx5_devlink_reload_down(struct devlink * devlink,bool netns_change,enum devlink_reload_action action,enum devlink_reload_limit limit,struct netlink_ext_ack * extack)189 static int mlx5_devlink_reload_down(struct devlink *devlink, bool netns_change,
190 				    enum devlink_reload_action action,
191 				    enum devlink_reload_limit limit,
192 				    struct netlink_ext_ack *extack)
193 {
194 	struct mlx5_core_dev *dev = devlink_priv(devlink);
195 	struct pci_dev *pdev = dev->pdev;
196 	int ret = 0;
197 
198 	if (mlx5_fw_reset_in_progress(dev)) {
199 		NL_SET_ERR_MSG_MOD(extack, "Can't reload during firmware reset");
200 		return -EBUSY;
201 	}
202 
203 	if (mlx5_dev_is_lightweight(dev)) {
204 		if (action != DEVLINK_RELOAD_ACTION_DRIVER_REINIT)
205 			return -EOPNOTSUPP;
206 		mlx5_unload_one_light(dev);
207 		return 0;
208 	}
209 
210 	if (mlx5_core_is_mp_slave(dev)) {
211 		NL_SET_ERR_MSG_MOD(extack, "reload is unsupported for multi port slave");
212 		return -EOPNOTSUPP;
213 	}
214 
215 	if (action == DEVLINK_RELOAD_ACTION_FW_ACTIVATE &&
216 	    !dev->priv.fw_reset) {
217 		NL_SET_ERR_MSG_MOD(extack, "FW activate is unsupported for this function");
218 		return -EOPNOTSUPP;
219 	}
220 
221 	if (mlx5_core_is_pf(dev) && pci_num_vf(pdev))
222 		NL_SET_ERR_MSG_MOD(extack, "reload while VFs are present is unfavorable");
223 
224 	switch (action) {
225 	case DEVLINK_RELOAD_ACTION_DRIVER_REINIT:
226 		mlx5_unload_one_devl_locked(dev, false);
227 		break;
228 	case DEVLINK_RELOAD_ACTION_FW_ACTIVATE:
229 		if (limit == DEVLINK_RELOAD_LIMIT_NO_RESET)
230 			ret = mlx5_devlink_trigger_fw_live_patch(devlink, extack);
231 		else
232 			ret = mlx5_devlink_reload_fw_activate(devlink, extack);
233 		break;
234 	default:
235 		/* Unsupported action should not get to this function */
236 		WARN_ON(1);
237 		ret = -EOPNOTSUPP;
238 	}
239 
240 	return ret;
241 }
242 
mlx5_devlink_reload_up(struct devlink * devlink,enum devlink_reload_action action,enum devlink_reload_limit limit,u32 * actions_performed,struct netlink_ext_ack * extack)243 static int mlx5_devlink_reload_up(struct devlink *devlink, enum devlink_reload_action action,
244 				  enum devlink_reload_limit limit, u32 *actions_performed,
245 				  struct netlink_ext_ack *extack)
246 {
247 	struct mlx5_core_dev *dev = devlink_priv(devlink);
248 	int ret = 0;
249 
250 	*actions_performed = BIT(action);
251 	switch (action) {
252 	case DEVLINK_RELOAD_ACTION_DRIVER_REINIT:
253 		if (mlx5_dev_is_lightweight(dev)) {
254 			mlx5_fw_reporters_create(dev);
255 			return mlx5_init_one_devl_locked(dev);
256 		}
257 		ret = mlx5_load_one_devl_locked(dev, false);
258 		break;
259 	case DEVLINK_RELOAD_ACTION_FW_ACTIVATE:
260 		if (limit == DEVLINK_RELOAD_LIMIT_NO_RESET)
261 			break;
262 		/* On fw_activate action, also driver is reloaded and reinit performed */
263 		*actions_performed |= BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT);
264 		ret = mlx5_load_one_devl_locked(dev, true);
265 		if (ret)
266 			return ret;
267 		ret = mlx5_fw_reset_verify_fw_complete(dev, extack);
268 		break;
269 	default:
270 		/* Unsupported action should not get to this function */
271 		WARN_ON(1);
272 		ret = -EOPNOTSUPP;
273 	}
274 
275 	return ret;
276 }
277 
mlx5_find_trap_by_id(struct mlx5_core_dev * dev,int trap_id)278 static struct mlx5_devlink_trap *mlx5_find_trap_by_id(struct mlx5_core_dev *dev, int trap_id)
279 {
280 	struct mlx5_devlink_trap *dl_trap;
281 
282 	list_for_each_entry(dl_trap, &dev->priv.traps, list)
283 		if (dl_trap->trap.id == trap_id)
284 			return dl_trap;
285 
286 	return NULL;
287 }
288 
mlx5_devlink_trap_init(struct devlink * devlink,const struct devlink_trap * trap,void * trap_ctx)289 static int mlx5_devlink_trap_init(struct devlink *devlink, const struct devlink_trap *trap,
290 				  void *trap_ctx)
291 {
292 	struct mlx5_core_dev *dev = devlink_priv(devlink);
293 	struct mlx5_devlink_trap *dl_trap;
294 
295 	dl_trap = kzalloc_obj(*dl_trap);
296 	if (!dl_trap)
297 		return -ENOMEM;
298 
299 	dl_trap->trap.id = trap->id;
300 	dl_trap->trap.action = DEVLINK_TRAP_ACTION_DROP;
301 	dl_trap->item = trap_ctx;
302 
303 	if (mlx5_find_trap_by_id(dev, trap->id)) {
304 		kfree(dl_trap);
305 		mlx5_core_err(dev, "Devlink trap: Trap 0x%x already found", trap->id);
306 		return -EEXIST;
307 	}
308 
309 	list_add_tail(&dl_trap->list, &dev->priv.traps);
310 	return 0;
311 }
312 
mlx5_devlink_trap_fini(struct devlink * devlink,const struct devlink_trap * trap,void * trap_ctx)313 static void mlx5_devlink_trap_fini(struct devlink *devlink, const struct devlink_trap *trap,
314 				   void *trap_ctx)
315 {
316 	struct mlx5_core_dev *dev = devlink_priv(devlink);
317 	struct mlx5_devlink_trap *dl_trap;
318 
319 	dl_trap = mlx5_find_trap_by_id(dev, trap->id);
320 	if (!dl_trap) {
321 		mlx5_core_err(dev, "Devlink trap: Missing trap id 0x%x", trap->id);
322 		return;
323 	}
324 	list_del(&dl_trap->list);
325 	kfree(dl_trap);
326 }
327 
mlx5_devlink_trap_action_set(struct devlink * devlink,const struct devlink_trap * trap,enum devlink_trap_action action,struct netlink_ext_ack * extack)328 static int mlx5_devlink_trap_action_set(struct devlink *devlink,
329 					const struct devlink_trap *trap,
330 					enum devlink_trap_action action,
331 					struct netlink_ext_ack *extack)
332 {
333 	struct mlx5_core_dev *dev = devlink_priv(devlink);
334 	struct mlx5_devlink_trap_event_ctx trap_event_ctx;
335 	enum devlink_trap_action action_orig;
336 	struct mlx5_devlink_trap *dl_trap;
337 	int err;
338 
339 	if (is_mdev_switchdev_mode(dev)) {
340 		NL_SET_ERR_MSG_MOD(extack, "Devlink traps can't be set in switchdev mode");
341 		return -EOPNOTSUPP;
342 	}
343 
344 	dl_trap = mlx5_find_trap_by_id(dev, trap->id);
345 	if (!dl_trap) {
346 		mlx5_core_err(dev, "Devlink trap: Set action on invalid trap id 0x%x", trap->id);
347 		return -EINVAL;
348 	}
349 
350 	if (action != DEVLINK_TRAP_ACTION_DROP && action != DEVLINK_TRAP_ACTION_TRAP)
351 		return -EOPNOTSUPP;
352 
353 	if (action == dl_trap->trap.action)
354 		return 0;
355 
356 	action_orig = dl_trap->trap.action;
357 	dl_trap->trap.action = action;
358 	trap_event_ctx.trap = &dl_trap->trap;
359 	trap_event_ctx.err = 0;
360 	err = mlx5_blocking_notifier_call_chain(dev, MLX5_DRIVER_EVENT_TYPE_TRAP,
361 						&trap_event_ctx);
362 	if (err == NOTIFY_BAD)
363 		dl_trap->trap.action = action_orig;
364 
365 	return trap_event_ctx.err;
366 }
367 
368 static const struct devlink_ops mlx5_devlink_ops = {
369 #ifdef CONFIG_MLX5_ESWITCH
370 	.eswitch_mode_set = mlx5_devlink_eswitch_mode_set,
371 	.eswitch_mode_get = mlx5_devlink_eswitch_mode_get,
372 	.eswitch_inline_mode_set = mlx5_devlink_eswitch_inline_mode_set,
373 	.eswitch_inline_mode_get = mlx5_devlink_eswitch_inline_mode_get,
374 	.eswitch_encap_mode_set = mlx5_devlink_eswitch_encap_mode_set,
375 	.eswitch_encap_mode_get = mlx5_devlink_eswitch_encap_mode_get,
376 	.rate_leaf_tx_share_set = mlx5_esw_devlink_rate_leaf_tx_share_set,
377 	.rate_leaf_tx_max_set = mlx5_esw_devlink_rate_leaf_tx_max_set,
378 	.rate_leaf_tc_bw_set = mlx5_esw_devlink_rate_leaf_tc_bw_set,
379 	.rate_node_tc_bw_set = mlx5_esw_devlink_rate_node_tc_bw_set,
380 	.rate_node_tx_share_set = mlx5_esw_devlink_rate_node_tx_share_set,
381 	.rate_node_tx_max_set = mlx5_esw_devlink_rate_node_tx_max_set,
382 	.rate_node_new = mlx5_esw_devlink_rate_node_new,
383 	.rate_node_del = mlx5_esw_devlink_rate_node_del,
384 	.rate_leaf_parent_set = mlx5_esw_devlink_rate_leaf_parent_set,
385 	.rate_node_parent_set = mlx5_esw_devlink_rate_node_parent_set,
386 	.supported_cross_device_rate_nodes = true,
387 #endif
388 #ifdef CONFIG_MLX5_SF_MANAGER
389 	.port_new = mlx5_devlink_sf_port_new,
390 #endif
391 	.flash_update = mlx5_devlink_flash_update,
392 	.info_get = mlx5_devlink_info_get,
393 	.reload_actions = BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT) |
394 			  BIT(DEVLINK_RELOAD_ACTION_FW_ACTIVATE),
395 	.reload_limits = BIT(DEVLINK_RELOAD_LIMIT_NO_RESET),
396 	.reload_down = mlx5_devlink_reload_down,
397 	.reload_up = mlx5_devlink_reload_up,
398 	.trap_init = mlx5_devlink_trap_init,
399 	.trap_fini = mlx5_devlink_trap_fini,
400 	.trap_action_set = mlx5_devlink_trap_action_set,
401 };
402 
mlx5_devlink_trap_report(struct mlx5_core_dev * dev,int trap_id,struct sk_buff * skb,struct devlink_port * dl_port)403 void mlx5_devlink_trap_report(struct mlx5_core_dev *dev, int trap_id, struct sk_buff *skb,
404 			      struct devlink_port *dl_port)
405 {
406 	struct devlink *devlink = priv_to_devlink(dev);
407 	struct mlx5_devlink_trap *dl_trap;
408 
409 	dl_trap = mlx5_find_trap_by_id(dev, trap_id);
410 	if (!dl_trap) {
411 		mlx5_core_err(dev, "Devlink trap: Report on invalid trap id 0x%x", trap_id);
412 		return;
413 	}
414 
415 	if (dl_trap->trap.action != DEVLINK_TRAP_ACTION_TRAP) {
416 		mlx5_core_dbg(dev, "Devlink trap: Trap id %d has action %d", trap_id,
417 			      dl_trap->trap.action);
418 		return;
419 	}
420 	devlink_trap_report(devlink, skb, dl_trap->item, dl_port, NULL);
421 }
422 
mlx5_devlink_trap_get_num_active(struct mlx5_core_dev * dev)423 int mlx5_devlink_trap_get_num_active(struct mlx5_core_dev *dev)
424 {
425 	struct mlx5_devlink_trap *dl_trap;
426 	int count = 0;
427 
428 	list_for_each_entry(dl_trap, &dev->priv.traps, list)
429 		if (dl_trap->trap.action == DEVLINK_TRAP_ACTION_TRAP)
430 			count++;
431 
432 	return count;
433 }
434 
mlx5_devlink_traps_get_action(struct mlx5_core_dev * dev,int trap_id,enum devlink_trap_action * action)435 int mlx5_devlink_traps_get_action(struct mlx5_core_dev *dev, int trap_id,
436 				  enum devlink_trap_action *action)
437 {
438 	struct mlx5_devlink_trap *dl_trap;
439 
440 	dl_trap = mlx5_find_trap_by_id(dev, trap_id);
441 	if (!dl_trap) {
442 		mlx5_core_err(dev, "Devlink trap: Get action on invalid trap id 0x%x",
443 			      trap_id);
444 		return -EINVAL;
445 	}
446 
447 	*action = dl_trap->trap.action;
448 	return 0;
449 }
450 
mlx5_devlink_alloc(struct device * dev)451 struct devlink *mlx5_devlink_alloc(struct device *dev)
452 {
453 	return devlink_alloc(&mlx5_devlink_ops, sizeof(struct mlx5_core_dev),
454 			     dev);
455 }
456 
mlx5_devlink_free(struct devlink * devlink)457 void mlx5_devlink_free(struct devlink *devlink)
458 {
459 	devlink_free(devlink);
460 }
461 
mlx5_devlink_enable_roce_validate(struct devlink * devlink,u32 id,union devlink_param_value * val,struct netlink_ext_ack * extack)462 static int mlx5_devlink_enable_roce_validate(struct devlink *devlink, u32 id,
463 					     union devlink_param_value *val,
464 					     struct netlink_ext_ack *extack)
465 {
466 	struct mlx5_core_dev *dev = devlink_priv(devlink);
467 	bool new_state = val->vbool;
468 
469 	if (new_state && !MLX5_CAP_GEN(dev, roce) &&
470 	    !(MLX5_CAP_GEN(dev, roce_rw_supported) && MLX5_CAP_GEN_MAX(dev, roce))) {
471 		NL_SET_ERR_MSG_MOD(extack, "Device doesn't support RoCE");
472 		return -EOPNOTSUPP;
473 	}
474 	if (mlx5_core_is_mp_slave(dev) || mlx5_lag_is_active(dev)) {
475 		NL_SET_ERR_MSG_MOD(extack, "Multi port slave/Lag device can't configure RoCE");
476 		return -EOPNOTSUPP;
477 	}
478 
479 	return 0;
480 }
481 
482 #ifdef CONFIG_MLX5_ESWITCH
mlx5_devlink_large_group_num_validate(struct devlink * devlink,u32 id,union devlink_param_value * val,struct netlink_ext_ack * extack)483 static int mlx5_devlink_large_group_num_validate(struct devlink *devlink, u32 id,
484 						 union devlink_param_value *val,
485 						 struct netlink_ext_ack *extack)
486 {
487 	int group_num = val->vu32;
488 
489 	if (group_num < 1 || group_num > 1024) {
490 		NL_SET_ERR_MSG_MOD(extack,
491 				   "Unsupported group number, supported range is 1-1024");
492 		return -EOPNOTSUPP;
493 	}
494 
495 	return 0;
496 }
497 #endif
498 
mlx5_devlink_eq_depth_validate(struct devlink * devlink,u32 id,union devlink_param_value * val,struct netlink_ext_ack * extack)499 static int mlx5_devlink_eq_depth_validate(struct devlink *devlink, u32 id,
500 					  union devlink_param_value *val,
501 					  struct netlink_ext_ack *extack)
502 {
503 	return (val->vu32 >= 64 && val->vu32 <= 4096) ? 0 : -EINVAL;
504 }
505 
506 static int
mlx5_devlink_hairpin_num_queues_validate(struct devlink * devlink,u32 id,union devlink_param_value * val,struct netlink_ext_ack * extack)507 mlx5_devlink_hairpin_num_queues_validate(struct devlink *devlink, u32 id,
508 					 union devlink_param_value *val,
509 					 struct netlink_ext_ack *extack)
510 {
511 	return val->vu32 ? 0 : -EINVAL;
512 }
513 
514 static int
mlx5_devlink_hairpin_queue_size_validate(struct devlink * devlink,u32 id,union devlink_param_value * val,struct netlink_ext_ack * extack)515 mlx5_devlink_hairpin_queue_size_validate(struct devlink *devlink, u32 id,
516 					 union devlink_param_value *val,
517 					 struct netlink_ext_ack *extack)
518 {
519 	struct mlx5_core_dev *dev = devlink_priv(devlink);
520 	u32 val32 = val->vu32;
521 
522 	if (!is_power_of_2(val32)) {
523 		NL_SET_ERR_MSG_MOD(extack, "Value is not power of two");
524 		return -EINVAL;
525 	}
526 
527 	if (val32 > BIT(MLX5_CAP_GEN(dev, log_max_hairpin_num_packets))) {
528 		NL_SET_ERR_MSG_FMT_MOD(
529 			extack, "Maximum hairpin queue size is %lu",
530 			BIT(MLX5_CAP_GEN(dev, log_max_hairpin_num_packets)));
531 		return -EINVAL;
532 	}
533 
534 	return 0;
535 }
536 
mlx5_devlink_num_doorbells_validate(struct devlink * devlink,u32 id,union devlink_param_value * val,struct netlink_ext_ack * extack)537 static int mlx5_devlink_num_doorbells_validate(struct devlink *devlink, u32 id,
538 					       union devlink_param_value *val,
539 					       struct netlink_ext_ack *extack)
540 {
541 	struct mlx5_core_dev *mdev = devlink_priv(devlink);
542 	u32 val32 = val->vu32;
543 	u32 max_num_channels;
544 
545 	max_num_channels = mlx5e_get_max_num_channels(mdev);
546 	if (val32 > max_num_channels) {
547 		NL_SET_ERR_MSG_FMT_MOD(extack,
548 				       "Requested num_doorbells (%u) exceeds max number of channels (%u)",
549 				       val32, max_num_channels);
550 		return -EINVAL;
551 	}
552 
553 	return 0;
554 }
555 
mlx5_devlink_hairpin_params_init_values(struct devlink * devlink)556 static void mlx5_devlink_hairpin_params_init_values(struct devlink *devlink)
557 {
558 	struct mlx5_core_dev *dev = devlink_priv(devlink);
559 	union devlink_param_value value;
560 	u32 link_speed = 0;
561 	u64 link_speed64;
562 
563 	/* set hairpin pair per each 50Gbs share of the link */
564 	mlx5_port_max_linkspeed(dev, &link_speed);
565 	link_speed = max_t(u32, link_speed, 50000);
566 	link_speed64 = link_speed;
567 	do_div(link_speed64, 50000);
568 
569 	value.vu32 = link_speed64;
570 	devl_param_driverinit_value_set(
571 		devlink, MLX5_DEVLINK_PARAM_ID_HAIRPIN_NUM_QUEUES, &value);
572 
573 	value.vu32 =
574 		BIT(min_t(u32, 16 - MLX5_MPWRQ_MIN_LOG_STRIDE_SZ(dev),
575 			  MLX5_CAP_GEN(dev, log_max_hairpin_num_packets)));
576 	devl_param_driverinit_value_set(
577 		devlink, MLX5_DEVLINK_PARAM_ID_HAIRPIN_QUEUE_SIZE, &value);
578 }
579 
580 static const struct devlink_param mlx5_devlink_params[] = {
581 	DEVLINK_PARAM_GENERIC(ENABLE_ROCE, BIT(DEVLINK_PARAM_CMODE_DRIVERINIT),
582 			      NULL, NULL, mlx5_devlink_enable_roce_validate),
583 #ifdef CONFIG_MLX5_ESWITCH
584 	DEVLINK_PARAM_DRIVER(MLX5_DEVLINK_PARAM_ID_ESW_LARGE_GROUP_NUM,
585 			     "fdb_large_groups", DEVLINK_PARAM_TYPE_U32,
586 			     BIT(DEVLINK_PARAM_CMODE_DRIVERINIT),
587 			     NULL, NULL,
588 			     mlx5_devlink_large_group_num_validate),
589 #endif
590 	DEVLINK_PARAM_GENERIC(IO_EQ_SIZE, BIT(DEVLINK_PARAM_CMODE_DRIVERINIT),
591 			      NULL, NULL, mlx5_devlink_eq_depth_validate),
592 	DEVLINK_PARAM_GENERIC(EVENT_EQ_SIZE, BIT(DEVLINK_PARAM_CMODE_DRIVERINIT),
593 			      NULL, NULL, mlx5_devlink_eq_depth_validate),
594 };
595 
mlx5_devlink_set_params_init_values(struct devlink * devlink)596 static void mlx5_devlink_set_params_init_values(struct devlink *devlink)
597 {
598 	struct mlx5_core_dev *dev = devlink_priv(devlink);
599 	union devlink_param_value value;
600 
601 	value.vbool = MLX5_CAP_GEN(dev, roce) && !mlx5_dev_is_lightweight(dev);
602 	devl_param_driverinit_value_set(devlink,
603 					DEVLINK_PARAM_GENERIC_ID_ENABLE_ROCE,
604 					&value);
605 
606 #ifdef CONFIG_MLX5_ESWITCH
607 	value.vu32 = ESW_OFFLOADS_DEFAULT_NUM_GROUPS;
608 	devl_param_driverinit_value_set(devlink,
609 					MLX5_DEVLINK_PARAM_ID_ESW_LARGE_GROUP_NUM,
610 					&value);
611 #endif
612 
613 	value.vu32 = MLX5_COMP_EQ_SIZE;
614 	devl_param_driverinit_value_set(devlink,
615 					DEVLINK_PARAM_GENERIC_ID_IO_EQ_SIZE,
616 					&value);
617 
618 	value.vu32 = MLX5_NUM_ASYNC_EQE;
619 	devl_param_driverinit_value_set(devlink,
620 					DEVLINK_PARAM_GENERIC_ID_EVENT_EQ_SIZE,
621 					&value);
622 }
623 
624 static const struct devlink_param mlx5_devlink_eth_params[] = {
625 	DEVLINK_PARAM_GENERIC(ENABLE_ETH, BIT(DEVLINK_PARAM_CMODE_DRIVERINIT),
626 			      NULL, NULL, NULL),
627 	DEVLINK_PARAM_DRIVER(MLX5_DEVLINK_PARAM_ID_HAIRPIN_NUM_QUEUES,
628 			     "hairpin_num_queues", DEVLINK_PARAM_TYPE_U32,
629 			     BIT(DEVLINK_PARAM_CMODE_DRIVERINIT), NULL, NULL,
630 			     mlx5_devlink_hairpin_num_queues_validate),
631 	DEVLINK_PARAM_DRIVER(MLX5_DEVLINK_PARAM_ID_HAIRPIN_QUEUE_SIZE,
632 			     "hairpin_queue_size", DEVLINK_PARAM_TYPE_U32,
633 			     BIT(DEVLINK_PARAM_CMODE_DRIVERINIT), NULL, NULL,
634 			     mlx5_devlink_hairpin_queue_size_validate),
635 	DEVLINK_PARAM_GENERIC(NUM_DOORBELLS,
636 			      BIT(DEVLINK_PARAM_CMODE_DRIVERINIT), NULL, NULL,
637 			      mlx5_devlink_num_doorbells_validate),
638 };
639 
mlx5_devlink_eth_params_register(struct devlink * devlink)640 static int mlx5_devlink_eth_params_register(struct devlink *devlink)
641 {
642 	struct mlx5_core_dev *dev = devlink_priv(devlink);
643 	union devlink_param_value value;
644 	int err;
645 
646 	if (!mlx5_eth_supported(dev))
647 		return 0;
648 
649 	err = devl_params_register(devlink, mlx5_devlink_eth_params,
650 				   ARRAY_SIZE(mlx5_devlink_eth_params));
651 	if (err)
652 		return err;
653 
654 	value.vbool = !mlx5_dev_is_lightweight(dev);
655 	devl_param_driverinit_value_set(devlink,
656 					DEVLINK_PARAM_GENERIC_ID_ENABLE_ETH,
657 					&value);
658 
659 	mlx5_devlink_hairpin_params_init_values(devlink);
660 
661 	value.vu32 = MLX5_DEFAULT_NUM_DOORBELLS;
662 	devl_param_driverinit_value_set(devlink,
663 					DEVLINK_PARAM_GENERIC_ID_NUM_DOORBELLS,
664 					&value);
665 	return 0;
666 }
667 
mlx5_devlink_eth_params_unregister(struct devlink * devlink)668 static void mlx5_devlink_eth_params_unregister(struct devlink *devlink)
669 {
670 	struct mlx5_core_dev *dev = devlink_priv(devlink);
671 
672 	if (!mlx5_eth_supported(dev))
673 		return;
674 
675 	devl_params_unregister(devlink, mlx5_devlink_eth_params,
676 			       ARRAY_SIZE(mlx5_devlink_eth_params));
677 }
678 
679 #define MLX5_PCIE_CONG_THRESH_MAX	10000
680 #define MLX5_PCIE_CONG_THRESH_DEF_LOW	7500
681 #define MLX5_PCIE_CONG_THRESH_DEF_HIGH	9000
682 
683 static int
mlx5_devlink_pcie_cong_thresh_validate(struct devlink * devl,u32 id,union devlink_param_value * val,struct netlink_ext_ack * extack)684 mlx5_devlink_pcie_cong_thresh_validate(struct devlink *devl, u32 id,
685 				       union devlink_param_value *val,
686 				       struct netlink_ext_ack *extack)
687 {
688 	if (val->vu16 > MLX5_PCIE_CONG_THRESH_MAX) {
689 		NL_SET_ERR_MSG_FMT_MOD(extack, "Value %u > max supported (%u)",
690 				       val->vu16, MLX5_PCIE_CONG_THRESH_MAX);
691 
692 		return -EINVAL;
693 	}
694 
695 	switch (id) {
696 	case MLX5_DEVLINK_PARAM_ID_PCIE_CONG_IN_LOW:
697 	case MLX5_DEVLINK_PARAM_ID_PCIE_CONG_IN_HIGH:
698 	case MLX5_DEVLINK_PARAM_ID_PCIE_CONG_OUT_LOW:
699 	case MLX5_DEVLINK_PARAM_ID_PCIE_CONG_OUT_HIGH:
700 		break;
701 	default:
702 		return -EOPNOTSUPP;
703 	}
704 
705 	return 0;
706 }
707 
mlx5_devlink_pcie_cong_init_values(struct devlink * devlink)708 static void mlx5_devlink_pcie_cong_init_values(struct devlink *devlink)
709 {
710 	union devlink_param_value value;
711 	u32 id;
712 
713 	value.vu16 = MLX5_PCIE_CONG_THRESH_DEF_LOW;
714 	id = MLX5_DEVLINK_PARAM_ID_PCIE_CONG_IN_LOW;
715 	devl_param_driverinit_value_set(devlink, id, &value);
716 
717 	value.vu16 = MLX5_PCIE_CONG_THRESH_DEF_HIGH;
718 	id = MLX5_DEVLINK_PARAM_ID_PCIE_CONG_IN_HIGH;
719 	devl_param_driverinit_value_set(devlink, id, &value);
720 
721 	value.vu16 = MLX5_PCIE_CONG_THRESH_DEF_LOW;
722 	id = MLX5_DEVLINK_PARAM_ID_PCIE_CONG_OUT_LOW;
723 	devl_param_driverinit_value_set(devlink, id, &value);
724 
725 	value.vu16 = MLX5_PCIE_CONG_THRESH_DEF_HIGH;
726 	id = MLX5_DEVLINK_PARAM_ID_PCIE_CONG_OUT_HIGH;
727 	devl_param_driverinit_value_set(devlink, id, &value);
728 }
729 
730 static const struct devlink_param mlx5_devlink_pcie_cong_params[] = {
731 	DEVLINK_PARAM_DRIVER(MLX5_DEVLINK_PARAM_ID_PCIE_CONG_IN_LOW,
732 			     "pcie_cong_inbound_low", DEVLINK_PARAM_TYPE_U16,
733 			     BIT(DEVLINK_PARAM_CMODE_DRIVERINIT), NULL, NULL,
734 			     mlx5_devlink_pcie_cong_thresh_validate),
735 	DEVLINK_PARAM_DRIVER(MLX5_DEVLINK_PARAM_ID_PCIE_CONG_IN_HIGH,
736 			     "pcie_cong_inbound_high", DEVLINK_PARAM_TYPE_U16,
737 			     BIT(DEVLINK_PARAM_CMODE_DRIVERINIT), NULL, NULL,
738 			     mlx5_devlink_pcie_cong_thresh_validate),
739 	DEVLINK_PARAM_DRIVER(MLX5_DEVLINK_PARAM_ID_PCIE_CONG_OUT_LOW,
740 			     "pcie_cong_outbound_low", DEVLINK_PARAM_TYPE_U16,
741 			     BIT(DEVLINK_PARAM_CMODE_DRIVERINIT), NULL, NULL,
742 			     mlx5_devlink_pcie_cong_thresh_validate),
743 	DEVLINK_PARAM_DRIVER(MLX5_DEVLINK_PARAM_ID_PCIE_CONG_OUT_HIGH,
744 			     "pcie_cong_outbound_high", DEVLINK_PARAM_TYPE_U16,
745 			     BIT(DEVLINK_PARAM_CMODE_DRIVERINIT), NULL, NULL,
746 			     mlx5_devlink_pcie_cong_thresh_validate),
747 };
748 
mlx5_devlink_pcie_cong_params_register(struct devlink * devlink)749 static int mlx5_devlink_pcie_cong_params_register(struct devlink *devlink)
750 {
751 	struct mlx5_core_dev *dev = devlink_priv(devlink);
752 	int err;
753 
754 	if (!mlx5_pcie_cong_event_supported(dev))
755 		return 0;
756 
757 	err = devl_params_register(devlink, mlx5_devlink_pcie_cong_params,
758 				   ARRAY_SIZE(mlx5_devlink_pcie_cong_params));
759 	if (err)
760 		return err;
761 
762 	mlx5_devlink_pcie_cong_init_values(devlink);
763 
764 	return 0;
765 }
766 
mlx5_devlink_pcie_cong_params_unregister(struct devlink * devlink)767 static void mlx5_devlink_pcie_cong_params_unregister(struct devlink *devlink)
768 {
769 	struct mlx5_core_dev *dev = devlink_priv(devlink);
770 
771 	if (!mlx5_pcie_cong_event_supported(dev))
772 		return;
773 
774 	devl_params_unregister(devlink, mlx5_devlink_pcie_cong_params,
775 			       ARRAY_SIZE(mlx5_devlink_pcie_cong_params));
776 }
777 
mlx5_devlink_enable_rdma_validate(struct devlink * devlink,u32 id,union devlink_param_value * val,struct netlink_ext_ack * extack)778 static int mlx5_devlink_enable_rdma_validate(struct devlink *devlink, u32 id,
779 					     union devlink_param_value *val,
780 					     struct netlink_ext_ack *extack)
781 {
782 	struct mlx5_core_dev *dev = devlink_priv(devlink);
783 	bool new_state = val->vbool;
784 
785 	if (new_state && !mlx5_rdma_supported(dev))
786 		return -EOPNOTSUPP;
787 	return 0;
788 }
789 
790 static const struct devlink_param mlx5_devlink_rdma_params[] = {
791 	DEVLINK_PARAM_GENERIC(ENABLE_RDMA, BIT(DEVLINK_PARAM_CMODE_DRIVERINIT),
792 			      NULL, NULL, mlx5_devlink_enable_rdma_validate),
793 };
794 
mlx5_devlink_rdma_params_register(struct devlink * devlink)795 static int mlx5_devlink_rdma_params_register(struct devlink *devlink)
796 {
797 	struct mlx5_core_dev *dev = devlink_priv(devlink);
798 	union devlink_param_value value;
799 	int err;
800 
801 	if (!IS_ENABLED(CONFIG_MLX5_INFINIBAND))
802 		return 0;
803 
804 	err = devl_params_register(devlink, mlx5_devlink_rdma_params,
805 				   ARRAY_SIZE(mlx5_devlink_rdma_params));
806 	if (err)
807 		return err;
808 
809 	value.vbool = !mlx5_dev_is_lightweight(dev);
810 	devl_param_driverinit_value_set(devlink,
811 					DEVLINK_PARAM_GENERIC_ID_ENABLE_RDMA,
812 					&value);
813 	return 0;
814 }
815 
mlx5_devlink_rdma_params_unregister(struct devlink * devlink)816 static void mlx5_devlink_rdma_params_unregister(struct devlink *devlink)
817 {
818 	if (!IS_ENABLED(CONFIG_MLX5_INFINIBAND))
819 		return;
820 
821 	devl_params_unregister(devlink, mlx5_devlink_rdma_params,
822 			       ARRAY_SIZE(mlx5_devlink_rdma_params));
823 }
824 
825 static const struct devlink_param mlx5_devlink_vnet_params[] = {
826 	DEVLINK_PARAM_GENERIC(ENABLE_VNET, BIT(DEVLINK_PARAM_CMODE_DRIVERINIT),
827 			      NULL, NULL, NULL),
828 };
829 
mlx5_devlink_vnet_params_register(struct devlink * devlink)830 static int mlx5_devlink_vnet_params_register(struct devlink *devlink)
831 {
832 	struct mlx5_core_dev *dev = devlink_priv(devlink);
833 	union devlink_param_value value;
834 	int err;
835 
836 	if (!mlx5_vnet_supported(dev))
837 		return 0;
838 
839 	err = devl_params_register(devlink, mlx5_devlink_vnet_params,
840 				   ARRAY_SIZE(mlx5_devlink_vnet_params));
841 	if (err)
842 		return err;
843 
844 	value.vbool = !mlx5_dev_is_lightweight(dev);
845 	devl_param_driverinit_value_set(devlink,
846 					DEVLINK_PARAM_GENERIC_ID_ENABLE_VNET,
847 					&value);
848 	return 0;
849 }
850 
mlx5_devlink_vnet_params_unregister(struct devlink * devlink)851 static void mlx5_devlink_vnet_params_unregister(struct devlink *devlink)
852 {
853 	struct mlx5_core_dev *dev = devlink_priv(devlink);
854 
855 	if (!mlx5_vnet_supported(dev))
856 		return;
857 
858 	devl_params_unregister(devlink, mlx5_devlink_vnet_params,
859 			       ARRAY_SIZE(mlx5_devlink_vnet_params));
860 }
861 
mlx5_devlink_auxdev_params_register(struct devlink * devlink)862 static int mlx5_devlink_auxdev_params_register(struct devlink *devlink)
863 {
864 	int err;
865 
866 	err = mlx5_devlink_eth_params_register(devlink);
867 	if (err)
868 		return err;
869 
870 	err = mlx5_devlink_rdma_params_register(devlink);
871 	if (err)
872 		goto rdma_err;
873 
874 	err = mlx5_devlink_vnet_params_register(devlink);
875 	if (err)
876 		goto vnet_err;
877 	return 0;
878 
879 vnet_err:
880 	mlx5_devlink_rdma_params_unregister(devlink);
881 rdma_err:
882 	mlx5_devlink_eth_params_unregister(devlink);
883 	return err;
884 }
885 
mlx5_devlink_auxdev_params_unregister(struct devlink * devlink)886 static void mlx5_devlink_auxdev_params_unregister(struct devlink *devlink)
887 {
888 	mlx5_devlink_vnet_params_unregister(devlink);
889 	mlx5_devlink_rdma_params_unregister(devlink);
890 	mlx5_devlink_eth_params_unregister(devlink);
891 }
892 
mlx5_devlink_max_uc_list_validate(struct devlink * devlink,u32 id,union devlink_param_value * val,struct netlink_ext_ack * extack)893 static int mlx5_devlink_max_uc_list_validate(struct devlink *devlink, u32 id,
894 					     union devlink_param_value *val,
895 					     struct netlink_ext_ack *extack)
896 {
897 	struct mlx5_core_dev *dev = devlink_priv(devlink);
898 
899 	if (val->vu32 == 0) {
900 		NL_SET_ERR_MSG_MOD(extack, "max_macs value must be greater than 0");
901 		return -EINVAL;
902 	}
903 
904 	if (!is_power_of_2(val->vu32)) {
905 		NL_SET_ERR_MSG_MOD(extack, "Only power of 2 values are supported for max_macs");
906 		return -EINVAL;
907 	}
908 
909 	if (ilog2(val->vu32) >
910 	    MLX5_CAP_GEN_MAX(dev, log_max_current_uc_list)) {
911 		NL_SET_ERR_MSG_MOD(extack, "max_macs value is out of the supported range");
912 		return -EINVAL;
913 	}
914 
915 	return 0;
916 }
917 
918 static const struct devlink_param mlx5_devlink_max_uc_list_params[] = {
919 	DEVLINK_PARAM_GENERIC(MAX_MACS, BIT(DEVLINK_PARAM_CMODE_DRIVERINIT),
920 			      NULL, NULL, mlx5_devlink_max_uc_list_validate),
921 };
922 
mlx5_devlink_max_uc_list_params_register(struct devlink * devlink)923 static int mlx5_devlink_max_uc_list_params_register(struct devlink *devlink)
924 {
925 	struct mlx5_core_dev *dev = devlink_priv(devlink);
926 	union devlink_param_value value;
927 	int err;
928 
929 	if (!MLX5_CAP_GEN_MAX(dev, log_max_current_uc_list_wr_supported))
930 		return 0;
931 
932 	err = devl_params_register(devlink, mlx5_devlink_max_uc_list_params,
933 				   ARRAY_SIZE(mlx5_devlink_max_uc_list_params));
934 	if (err)
935 		return err;
936 
937 	value.vu32 = 1 << MLX5_CAP_GEN(dev, log_max_current_uc_list);
938 	devl_param_driverinit_value_set(devlink,
939 					DEVLINK_PARAM_GENERIC_ID_MAX_MACS,
940 					&value);
941 	return 0;
942 }
943 
944 static void
mlx5_devlink_max_uc_list_params_unregister(struct devlink * devlink)945 mlx5_devlink_max_uc_list_params_unregister(struct devlink *devlink)
946 {
947 	struct mlx5_core_dev *dev = devlink_priv(devlink);
948 
949 	if (!MLX5_CAP_GEN_MAX(dev, log_max_current_uc_list_wr_supported))
950 		return;
951 
952 	devl_params_unregister(devlink, mlx5_devlink_max_uc_list_params,
953 			       ARRAY_SIZE(mlx5_devlink_max_uc_list_params));
954 }
955 
956 #define MLX5_TRAP_DROP(_id, _group_id)					\
957 	DEVLINK_TRAP_GENERIC(DROP, DROP, _id,				\
958 			     DEVLINK_TRAP_GROUP_GENERIC_ID_##_group_id, \
959 			     DEVLINK_TRAP_METADATA_TYPE_F_IN_PORT)
960 
961 static const struct devlink_trap mlx5_traps_arr[] = {
962 	MLX5_TRAP_DROP(INGRESS_VLAN_FILTER, L2_DROPS),
963 	MLX5_TRAP_DROP(DMAC_FILTER, L2_DROPS),
964 };
965 
966 static const struct devlink_trap_group mlx5_trap_groups_arr[] = {
967 	DEVLINK_TRAP_GROUP_GENERIC(L2_DROPS, 0),
968 };
969 
mlx5_devlink_traps_register(struct devlink * devlink)970 int mlx5_devlink_traps_register(struct devlink *devlink)
971 {
972 	struct mlx5_core_dev *core_dev = devlink_priv(devlink);
973 	int err;
974 
975 	err = devl_trap_groups_register(devlink, mlx5_trap_groups_arr,
976 					ARRAY_SIZE(mlx5_trap_groups_arr));
977 	if (err)
978 		return err;
979 
980 	err = devl_traps_register(devlink, mlx5_traps_arr, ARRAY_SIZE(mlx5_traps_arr),
981 				  &core_dev->priv);
982 	if (err)
983 		goto err_trap_group;
984 	return 0;
985 
986 err_trap_group:
987 	devl_trap_groups_unregister(devlink, mlx5_trap_groups_arr,
988 				    ARRAY_SIZE(mlx5_trap_groups_arr));
989 	return err;
990 }
991 
mlx5_devlink_traps_unregister(struct devlink * devlink)992 void mlx5_devlink_traps_unregister(struct devlink *devlink)
993 {
994 	devl_traps_unregister(devlink, mlx5_traps_arr, ARRAY_SIZE(mlx5_traps_arr));
995 	devl_trap_groups_unregister(devlink, mlx5_trap_groups_arr,
996 				    ARRAY_SIZE(mlx5_trap_groups_arr));
997 }
998 
mlx5_devlink_params_register(struct devlink * devlink)999 int mlx5_devlink_params_register(struct devlink *devlink)
1000 {
1001 	int err;
1002 
1003 	/* Here only the driver init params should be registered.
1004 	 * Runtime params should be registered by the code which
1005 	 * behaviour they configure.
1006 	 */
1007 
1008 	err = devl_params_register(devlink, mlx5_devlink_params,
1009 				   ARRAY_SIZE(mlx5_devlink_params));
1010 	if (err)
1011 		return err;
1012 
1013 	mlx5_devlink_set_params_init_values(devlink);
1014 
1015 	err = mlx5_devlink_auxdev_params_register(devlink);
1016 	if (err)
1017 		goto auxdev_reg_err;
1018 
1019 	err = mlx5_devlink_max_uc_list_params_register(devlink);
1020 	if (err)
1021 		goto max_uc_list_err;
1022 
1023 	err = mlx5_devlink_pcie_cong_params_register(devlink);
1024 	if (err)
1025 		goto pcie_cong_err;
1026 
1027 	err = mlx5_nv_param_register_dl_params(devlink);
1028 	if (err)
1029 		goto nv_param_err;
1030 
1031 	return 0;
1032 
1033 nv_param_err:
1034 	mlx5_devlink_pcie_cong_params_unregister(devlink);
1035 pcie_cong_err:
1036 	mlx5_devlink_max_uc_list_params_unregister(devlink);
1037 max_uc_list_err:
1038 	mlx5_devlink_auxdev_params_unregister(devlink);
1039 auxdev_reg_err:
1040 	devl_params_unregister(devlink, mlx5_devlink_params,
1041 			       ARRAY_SIZE(mlx5_devlink_params));
1042 	return err;
1043 }
1044 
mlx5_devlink_params_unregister(struct devlink * devlink)1045 void mlx5_devlink_params_unregister(struct devlink *devlink)
1046 {
1047 	mlx5_nv_param_unregister_dl_params(devlink);
1048 	mlx5_devlink_pcie_cong_params_unregister(devlink);
1049 	mlx5_devlink_max_uc_list_params_unregister(devlink);
1050 	mlx5_devlink_auxdev_params_unregister(devlink);
1051 	devl_params_unregister(devlink, mlx5_devlink_params,
1052 			       ARRAY_SIZE(mlx5_devlink_params));
1053 }
1054