1 // SPDX-License-Identifier: MIT
2 /*
3 * Copyright 2020 Noralf Trønnes
4 */
5
6 #include <linux/lz4.h>
7 #include <linux/usb.h>
8 #include <linux/vmalloc.h>
9 #include <linux/workqueue.h>
10
11 #include <drm/drm_atomic.h>
12 #include <drm/drm_connector.h>
13 #include <drm/drm_damage_helper.h>
14 #include <drm/drm_drv.h>
15 #include <drm/drm_format_helper.h>
16 #include <drm/drm_fourcc.h>
17 #include <drm/drm_framebuffer.h>
18 #include <drm/drm_gem.h>
19 #include <drm/drm_gem_atomic_helper.h>
20 #include <drm/drm_gem_framebuffer_helper.h>
21 #include <drm/drm_print.h>
22 #include <drm/drm_rect.h>
23 #include <drm/drm_simple_kms_helper.h>
24 #include <drm/gud.h>
25
26 #include "gud_internal.h"
27
28 /*
29 * Some userspace rendering loops run all displays in the same loop.
30 * This means that a fast display will have to wait for a slow one.
31 * Such users might want to enable this module parameter.
32 */
33 static bool gud_async_flush;
34 module_param_named(async_flush, gud_async_flush, bool, 0644);
35 MODULE_PARM_DESC(async_flush, "Enable asynchronous flushing [default=0]");
36
37 /*
38 * FIXME: The driver is probably broken on Big Endian machines.
39 * See discussion:
40 * https://lore.kernel.org/dri-devel/CAKb7UvihLX0hgBOP3VBG7O+atwZcUVCPVuBdfmDMpg0NjXe-cQ@mail.gmail.com/
41 */
42
gud_is_big_endian(void)43 static bool gud_is_big_endian(void)
44 {
45 #if defined(__BIG_ENDIAN)
46 return true;
47 #else
48 return false;
49 #endif
50 }
51
gud_xrgb8888_to_r124(u8 * dst,const struct drm_format_info * format,void * src,struct drm_framebuffer * fb,struct drm_rect * rect,struct drm_format_conv_state * fmtcnv_state)52 static size_t gud_xrgb8888_to_r124(u8 *dst, const struct drm_format_info *format,
53 void *src, struct drm_framebuffer *fb,
54 struct drm_rect *rect,
55 struct drm_format_conv_state *fmtcnv_state)
56 {
57 unsigned int block_width = drm_format_info_block_width(format, 0);
58 unsigned int bits_per_pixel = 8 / block_width;
59 unsigned int x, y, width, height;
60 u8 pix, *pix8, *block = dst; /* Assign to silence compiler warning */
61 struct iosys_map dst_map, vmap;
62 size_t len;
63 void *buf;
64
65 WARN_ON_ONCE(format->char_per_block[0] != 1);
66
67 /* Start on a byte boundary */
68 rect->x1 = ALIGN_DOWN(rect->x1, block_width);
69 width = drm_rect_width(rect);
70 height = drm_rect_height(rect);
71 len = drm_format_info_min_pitch(format, 0, width) * height;
72
73 buf = kmalloc(width * height, GFP_KERNEL);
74 if (!buf)
75 return 0;
76
77 iosys_map_set_vaddr(&dst_map, buf);
78 iosys_map_set_vaddr(&vmap, src);
79 drm_fb_xrgb8888_to_gray8(&dst_map, NULL, &vmap, fb, rect, fmtcnv_state);
80 pix8 = buf;
81
82 for (y = 0; y < height; y++) {
83 for (x = 0; x < width; x++) {
84 unsigned int pixpos = x % block_width; /* within byte from the left */
85 unsigned int pixshift = (block_width - pixpos - 1) * bits_per_pixel;
86
87 if (!pixpos) {
88 block = dst++;
89 *block = 0;
90 }
91
92 pix = (*pix8++) >> (8 - bits_per_pixel);
93 *block |= pix << pixshift;
94 }
95 }
96
97 kfree(buf);
98
99 return len;
100 }
101
gud_xrgb8888_to_color(u8 * dst,const struct drm_format_info * format,void * src,struct drm_framebuffer * fb,struct drm_rect * rect)102 static size_t gud_xrgb8888_to_color(u8 *dst, const struct drm_format_info *format,
103 void *src, struct drm_framebuffer *fb,
104 struct drm_rect *rect)
105 {
106 unsigned int block_width = drm_format_info_block_width(format, 0);
107 unsigned int bits_per_pixel = 8 / block_width;
108 u8 r, g, b, pix, *block = dst; /* Assign to silence compiler warning */
109 unsigned int x, y, width;
110 __le32 *sbuf32;
111 u32 pix32;
112 size_t len;
113
114 /* Start on a byte boundary */
115 rect->x1 = ALIGN_DOWN(rect->x1, block_width);
116 width = drm_rect_width(rect);
117 len = drm_format_info_min_pitch(format, 0, width) * drm_rect_height(rect);
118
119 for (y = rect->y1; y < rect->y2; y++) {
120 sbuf32 = src + (y * fb->pitches[0]);
121 sbuf32 += rect->x1;
122
123 for (x = 0; x < width; x++) {
124 unsigned int pixpos = x % block_width; /* within byte from the left */
125 unsigned int pixshift = (block_width - pixpos - 1) * bits_per_pixel;
126
127 if (!pixpos) {
128 block = dst++;
129 *block = 0;
130 }
131
132 pix32 = le32_to_cpu(*sbuf32++);
133 r = pix32 >> 16;
134 g = pix32 >> 8;
135 b = pix32;
136
137 switch (format->format) {
138 case GUD_DRM_FORMAT_XRGB1111:
139 pix = ((r >> 7) << 2) | ((g >> 7) << 1) | (b >> 7);
140 break;
141 default:
142 WARN_ON_ONCE(1);
143 return len;
144 }
145
146 *block |= pix << pixshift;
147 }
148 }
149
150 return len;
151 }
152
gud_prep_flush(struct gud_device * gdrm,struct drm_framebuffer * fb,const struct iosys_map * src,bool cached_reads,const struct drm_format_info * format,struct drm_rect * rect,struct gud_set_buffer_req * req,struct drm_format_conv_state * fmtcnv_state)153 static int gud_prep_flush(struct gud_device *gdrm, struct drm_framebuffer *fb,
154 const struct iosys_map *src, bool cached_reads,
155 const struct drm_format_info *format, struct drm_rect *rect,
156 struct gud_set_buffer_req *req,
157 struct drm_format_conv_state *fmtcnv_state)
158 {
159 u8 compression = gdrm->compression;
160 struct iosys_map dst;
161 void *vaddr, *buf;
162 size_t pitch, len;
163
164 pitch = drm_format_info_min_pitch(format, 0, drm_rect_width(rect));
165 len = pitch * drm_rect_height(rect);
166 if (len > gdrm->bulk_len)
167 return -E2BIG;
168
169 vaddr = src[0].vaddr;
170 retry:
171 if (compression)
172 buf = gdrm->compress_buf;
173 else
174 buf = gdrm->bulk_buf;
175 iosys_map_set_vaddr(&dst, buf);
176
177 /*
178 * Imported buffers are assumed to be write-combined and thus uncached
179 * with slow reads (at least on ARM).
180 */
181 if (format != fb->format) {
182 if (format->format == GUD_DRM_FORMAT_R1) {
183 len = gud_xrgb8888_to_r124(buf, format, vaddr, fb, rect, fmtcnv_state);
184 if (!len)
185 return -ENOMEM;
186 } else if (format->format == DRM_FORMAT_R8) {
187 drm_fb_xrgb8888_to_gray8(&dst, NULL, src, fb, rect, fmtcnv_state);
188 } else if (format->format == DRM_FORMAT_RGB332) {
189 drm_fb_xrgb8888_to_rgb332(&dst, NULL, src, fb, rect, fmtcnv_state);
190 } else if (format->format == DRM_FORMAT_RGB565) {
191 if (gud_is_big_endian()) {
192 drm_fb_xrgb8888_to_rgb565be(&dst, NULL, src, fb, rect,
193 fmtcnv_state);
194 } else {
195 drm_fb_xrgb8888_to_rgb565(&dst, NULL, src, fb, rect,
196 fmtcnv_state);
197 }
198 } else if (format->format == DRM_FORMAT_RGB888) {
199 drm_fb_xrgb8888_to_rgb888(&dst, NULL, src, fb, rect, fmtcnv_state);
200 } else {
201 len = gud_xrgb8888_to_color(buf, format, vaddr, fb, rect);
202 }
203 } else if (gud_is_big_endian() && format->cpp[0] > 1) {
204 drm_fb_swab(&dst, NULL, src, fb, rect, cached_reads, fmtcnv_state);
205 } else if (compression && cached_reads && pitch == fb->pitches[0]) {
206 /* can compress directly from the framebuffer */
207 buf = vaddr + rect->y1 * pitch;
208 } else {
209 drm_fb_memcpy(&dst, NULL, src, fb, rect);
210 }
211
212 memset(req, 0, sizeof(*req));
213 req->x = cpu_to_le32(rect->x1);
214 req->y = cpu_to_le32(rect->y1);
215 req->width = cpu_to_le32(drm_rect_width(rect));
216 req->height = cpu_to_le32(drm_rect_height(rect));
217 req->length = cpu_to_le32(len);
218
219 if (compression & GUD_COMPRESSION_LZ4) {
220 int complen;
221
222 complen = LZ4_compress_default(buf, gdrm->bulk_buf, len, len, gdrm->lz4_comp_mem);
223 if (complen <= 0) {
224 compression = 0;
225 goto retry;
226 }
227
228 req->compression = GUD_COMPRESSION_LZ4;
229 req->compressed_length = cpu_to_le32(complen);
230 }
231
232 return 0;
233 }
234
235 struct gud_usb_bulk_context {
236 struct timer_list timer;
237 struct usb_sg_request sgr;
238 };
239
gud_usb_bulk_timeout(struct timer_list * t)240 static void gud_usb_bulk_timeout(struct timer_list *t)
241 {
242 struct gud_usb_bulk_context *ctx = timer_container_of(ctx, t, timer);
243
244 usb_sg_cancel(&ctx->sgr);
245 }
246
gud_usb_bulk(struct gud_device * gdrm,size_t len)247 static int gud_usb_bulk(struct gud_device *gdrm, size_t len)
248 {
249 struct gud_usb_bulk_context ctx;
250 int ret;
251
252 ret = usb_sg_init(&ctx.sgr, gud_to_usb_device(gdrm), gdrm->bulk_pipe, 0,
253 gdrm->bulk_sgt.sgl, gdrm->bulk_sgt.nents, len, GFP_KERNEL);
254 if (ret)
255 return ret;
256
257 timer_setup_on_stack(&ctx.timer, gud_usb_bulk_timeout, 0);
258 mod_timer(&ctx.timer, jiffies + msecs_to_jiffies(3000));
259
260 usb_sg_wait(&ctx.sgr);
261
262 if (!timer_delete_sync(&ctx.timer))
263 ret = -ETIMEDOUT;
264 else if (ctx.sgr.status < 0)
265 ret = ctx.sgr.status;
266 else if (ctx.sgr.bytes != len)
267 ret = -EIO;
268
269 timer_destroy_on_stack(&ctx.timer);
270
271 return ret;
272 }
273
gud_flush_rect(struct gud_device * gdrm,struct drm_framebuffer * fb,const struct iosys_map * src,bool cached_reads,const struct drm_format_info * format,struct drm_rect * rect,struct drm_format_conv_state * fmtcnv_state)274 static int gud_flush_rect(struct gud_device *gdrm, struct drm_framebuffer *fb,
275 const struct iosys_map *src, bool cached_reads,
276 const struct drm_format_info *format, struct drm_rect *rect,
277 struct drm_format_conv_state *fmtcnv_state)
278 {
279 struct gud_set_buffer_req req;
280 size_t len, trlen;
281 int ret;
282
283 drm_dbg(&gdrm->drm, "Flushing [FB:%d] " DRM_RECT_FMT "\n", fb->base.id, DRM_RECT_ARG(rect));
284
285 ret = gud_prep_flush(gdrm, fb, src, cached_reads, format, rect, &req, fmtcnv_state);
286 if (ret)
287 return ret;
288
289 len = le32_to_cpu(req.length);
290
291 if (req.compression)
292 trlen = le32_to_cpu(req.compressed_length);
293 else
294 trlen = len;
295
296 gdrm->stats_length += len;
297 /* Did it wrap around? */
298 if (gdrm->stats_length <= len && gdrm->stats_actual_length) {
299 gdrm->stats_length = len;
300 gdrm->stats_actual_length = 0;
301 }
302 gdrm->stats_actual_length += trlen;
303
304 if (!(gdrm->flags & GUD_DISPLAY_FLAG_FULL_UPDATE) || gdrm->prev_flush_failed) {
305 ret = gud_usb_set(gdrm, GUD_REQ_SET_BUFFER, 0, &req, sizeof(req));
306 if (ret)
307 return ret;
308 }
309
310 ret = gud_usb_bulk(gdrm, trlen);
311 if (ret)
312 gdrm->stats_num_errors++;
313
314 return ret;
315 }
316
gud_clear_damage(struct gud_device * gdrm)317 void gud_clear_damage(struct gud_device *gdrm)
318 {
319 gdrm->damage.x1 = INT_MAX;
320 gdrm->damage.y1 = INT_MAX;
321 gdrm->damage.x2 = 0;
322 gdrm->damage.y2 = 0;
323 }
324
gud_flush_damage(struct gud_device * gdrm,struct drm_framebuffer * fb,const struct iosys_map * src,bool cached_reads,struct drm_rect * damage)325 static void gud_flush_damage(struct gud_device *gdrm, struct drm_framebuffer *fb,
326 const struct iosys_map *src, bool cached_reads,
327 struct drm_rect *damage)
328 {
329 struct drm_format_conv_state fmtcnv_state = DRM_FORMAT_CONV_STATE_INIT;
330 const struct drm_format_info *format;
331 unsigned int i, lines;
332 size_t pitch;
333 int ret;
334
335 format = fb->format;
336 if (format->format == DRM_FORMAT_XRGB8888 && gdrm->xrgb8888_emulation_format)
337 format = gdrm->xrgb8888_emulation_format;
338
339 /* Split update if it's too big */
340 pitch = drm_format_info_min_pitch(format, 0, drm_rect_width(damage));
341 lines = drm_rect_height(damage);
342
343 if (gdrm->bulk_len < lines * pitch)
344 lines = gdrm->bulk_len / pitch;
345
346 for (i = 0; i < DIV_ROUND_UP(drm_rect_height(damage), lines); i++) {
347 struct drm_rect rect = *damage;
348
349 rect.y1 += i * lines;
350 rect.y2 = min_t(u32, rect.y1 + lines, damage->y2);
351
352 ret = gud_flush_rect(gdrm, fb, src, cached_reads, format, &rect, &fmtcnv_state);
353 if (ret) {
354 if (ret != -ENODEV && ret != -ECONNRESET &&
355 ret != -ESHUTDOWN && ret != -EPROTO)
356 dev_err_ratelimited(fb->dev->dev,
357 "Failed to flush framebuffer: error=%d\n", ret);
358 gdrm->prev_flush_failed = true;
359 break;
360 }
361 }
362
363 drm_format_conv_state_release(&fmtcnv_state);
364 }
365
gud_flush_work(struct work_struct * work)366 void gud_flush_work(struct work_struct *work)
367 {
368 struct gud_device *gdrm = container_of(work, struct gud_device, work);
369 struct iosys_map shadow_map;
370 struct drm_framebuffer *fb;
371 struct drm_rect damage;
372 int idx;
373
374 if (!drm_dev_enter(&gdrm->drm, &idx))
375 return;
376
377 mutex_lock(&gdrm->damage_lock);
378 fb = gdrm->fb;
379 gdrm->fb = NULL;
380 iosys_map_set_vaddr(&shadow_map, gdrm->shadow_buf);
381 damage = gdrm->damage;
382 gud_clear_damage(gdrm);
383 mutex_unlock(&gdrm->damage_lock);
384
385 if (!fb)
386 goto out;
387
388 gud_flush_damage(gdrm, fb, &shadow_map, true, &damage);
389
390 drm_framebuffer_put(fb);
391 out:
392 drm_dev_exit(idx);
393 }
394
gud_fb_queue_damage(struct gud_device * gdrm,struct drm_framebuffer * fb,const struct iosys_map * src,struct drm_rect * damage)395 static int gud_fb_queue_damage(struct gud_device *gdrm, struct drm_framebuffer *fb,
396 const struct iosys_map *src, struct drm_rect *damage)
397 {
398 struct drm_framebuffer *old_fb = NULL;
399 struct iosys_map shadow_map;
400
401 mutex_lock(&gdrm->damage_lock);
402
403 if (!gdrm->shadow_buf) {
404 gdrm->shadow_buf = vcalloc(fb->pitches[0], fb->height);
405 if (!gdrm->shadow_buf) {
406 mutex_unlock(&gdrm->damage_lock);
407 return -ENOMEM;
408 }
409 }
410
411 iosys_map_set_vaddr(&shadow_map, gdrm->shadow_buf);
412 iosys_map_incr(&shadow_map, drm_fb_clip_offset(fb->pitches[0], fb->format, damage));
413 drm_fb_memcpy(&shadow_map, fb->pitches, src, fb, damage);
414
415 if (fb != gdrm->fb) {
416 old_fb = gdrm->fb;
417 drm_framebuffer_get(fb);
418 gdrm->fb = fb;
419 }
420
421 gdrm->damage.x1 = min(gdrm->damage.x1, damage->x1);
422 gdrm->damage.y1 = min(gdrm->damage.y1, damage->y1);
423 gdrm->damage.x2 = max(gdrm->damage.x2, damage->x2);
424 gdrm->damage.y2 = max(gdrm->damage.y2, damage->y2);
425
426 mutex_unlock(&gdrm->damage_lock);
427
428 queue_work(system_long_wq, &gdrm->work);
429
430 if (old_fb)
431 drm_framebuffer_put(old_fb);
432
433 return 0;
434 }
435
gud_fb_handle_damage(struct gud_device * gdrm,struct drm_framebuffer * fb,const struct iosys_map * src,struct drm_rect * damage)436 static void gud_fb_handle_damage(struct gud_device *gdrm, struct drm_framebuffer *fb,
437 const struct iosys_map *src, struct drm_rect *damage)
438 {
439 int ret;
440
441 if (gdrm->flags & GUD_DISPLAY_FLAG_FULL_UPDATE)
442 drm_rect_init(damage, 0, 0, fb->width, fb->height);
443
444 if (gud_async_flush) {
445 ret = gud_fb_queue_damage(gdrm, fb, src, damage);
446 if (ret != -ENOMEM)
447 return;
448 }
449
450 /* Imported buffers are assumed to be WriteCombined with uncached reads */
451 gud_flush_damage(gdrm, fb, src, !fb->obj[0]->import_attach, damage);
452 }
453
gud_pipe_check(struct drm_simple_display_pipe * pipe,struct drm_plane_state * new_plane_state,struct drm_crtc_state * new_crtc_state)454 int gud_pipe_check(struct drm_simple_display_pipe *pipe,
455 struct drm_plane_state *new_plane_state,
456 struct drm_crtc_state *new_crtc_state)
457 {
458 struct gud_device *gdrm = to_gud_device(pipe->crtc.dev);
459 struct drm_plane_state *old_plane_state = pipe->plane.state;
460 const struct drm_display_mode *mode = &new_crtc_state->mode;
461 struct drm_atomic_state *state = new_plane_state->state;
462 struct drm_framebuffer *old_fb = old_plane_state->fb;
463 struct drm_connector_state *connector_state = NULL;
464 struct drm_framebuffer *fb = new_plane_state->fb;
465 const struct drm_format_info *format = fb->format;
466 struct drm_connector *connector;
467 unsigned int i, num_properties;
468 struct gud_state_req *req;
469 int idx, ret;
470 size_t len;
471
472 if (WARN_ON_ONCE(!fb))
473 return -EINVAL;
474
475 if (old_plane_state->rotation != new_plane_state->rotation)
476 new_crtc_state->mode_changed = true;
477
478 if (old_fb && old_fb->format != format)
479 new_crtc_state->mode_changed = true;
480
481 if (!new_crtc_state->mode_changed && !new_crtc_state->connectors_changed)
482 return 0;
483
484 /* Only one connector is supported */
485 if (hweight32(new_crtc_state->connector_mask) != 1)
486 return -EINVAL;
487
488 if (format->format == DRM_FORMAT_XRGB8888 && gdrm->xrgb8888_emulation_format)
489 format = gdrm->xrgb8888_emulation_format;
490
491 for_each_new_connector_in_state(state, connector, connector_state, i) {
492 if (connector_state->crtc)
493 break;
494 }
495
496 /*
497 * DRM_IOCTL_MODE_OBJ_SETPROPERTY on the rotation property will not have
498 * the connector included in the state.
499 */
500 if (!connector_state) {
501 struct drm_connector_list_iter conn_iter;
502
503 drm_connector_list_iter_begin(pipe->crtc.dev, &conn_iter);
504 drm_for_each_connector_iter(connector, &conn_iter) {
505 if (connector->state->crtc) {
506 connector_state = connector->state;
507 break;
508 }
509 }
510 drm_connector_list_iter_end(&conn_iter);
511 }
512
513 if (WARN_ON_ONCE(!connector_state))
514 return -ENOENT;
515
516 len = struct_size(req, properties,
517 size_add(GUD_PROPERTIES_MAX_NUM, GUD_CONNECTOR_PROPERTIES_MAX_NUM));
518 req = kzalloc(len, GFP_KERNEL);
519 if (!req)
520 return -ENOMEM;
521
522 gud_from_display_mode(&req->mode, mode);
523
524 req->format = gud_from_fourcc(format->format);
525 if (WARN_ON_ONCE(!req->format)) {
526 ret = -EINVAL;
527 goto out;
528 }
529
530 req->connector = drm_connector_index(connector_state->connector);
531
532 ret = gud_connector_fill_properties(connector_state, req->properties);
533 if (ret < 0)
534 goto out;
535
536 num_properties = ret;
537 for (i = 0; i < gdrm->num_properties; i++) {
538 u16 prop = gdrm->properties[i];
539 u64 val;
540
541 switch (prop) {
542 case GUD_PROPERTY_ROTATION:
543 /* DRM UAPI matches the protocol so use value directly */
544 val = new_plane_state->rotation;
545 break;
546 default:
547 WARN_ON_ONCE(1);
548 ret = -EINVAL;
549 goto out;
550 }
551
552 req->properties[num_properties + i].prop = cpu_to_le16(prop);
553 req->properties[num_properties + i].val = cpu_to_le64(val);
554 num_properties++;
555 }
556
557 if (drm_dev_enter(fb->dev, &idx)) {
558 len = struct_size(req, properties, num_properties);
559 ret = gud_usb_set(gdrm, GUD_REQ_SET_STATE_CHECK, 0, req, len);
560 drm_dev_exit(idx);
561 } else {
562 ret = -ENODEV;
563 }
564 out:
565 kfree(req);
566
567 return ret;
568 }
569
gud_pipe_update(struct drm_simple_display_pipe * pipe,struct drm_plane_state * old_state)570 void gud_pipe_update(struct drm_simple_display_pipe *pipe,
571 struct drm_plane_state *old_state)
572 {
573 struct drm_device *drm = pipe->crtc.dev;
574 struct gud_device *gdrm = to_gud_device(drm);
575 struct drm_plane_state *state = pipe->plane.state;
576 struct drm_shadow_plane_state *shadow_plane_state = to_drm_shadow_plane_state(state);
577 struct drm_framebuffer *fb = state->fb;
578 struct drm_crtc *crtc = &pipe->crtc;
579 struct drm_rect damage;
580 int ret, idx;
581
582 if (crtc->state->mode_changed || !crtc->state->enable) {
583 cancel_work_sync(&gdrm->work);
584 mutex_lock(&gdrm->damage_lock);
585 if (gdrm->fb) {
586 drm_framebuffer_put(gdrm->fb);
587 gdrm->fb = NULL;
588 }
589 gud_clear_damage(gdrm);
590 vfree(gdrm->shadow_buf);
591 gdrm->shadow_buf = NULL;
592 mutex_unlock(&gdrm->damage_lock);
593 }
594
595 if (!drm_dev_enter(drm, &idx))
596 return;
597
598 if (!old_state->fb)
599 gud_usb_set_u8(gdrm, GUD_REQ_SET_CONTROLLER_ENABLE, 1);
600
601 if (fb && (crtc->state->mode_changed || crtc->state->connectors_changed))
602 gud_usb_set(gdrm, GUD_REQ_SET_STATE_COMMIT, 0, NULL, 0);
603
604 if (crtc->state->active_changed)
605 gud_usb_set_u8(gdrm, GUD_REQ_SET_DISPLAY_ENABLE, crtc->state->active);
606
607 if (!fb)
608 goto ctrl_disable;
609
610 ret = drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE);
611 if (ret)
612 goto ctrl_disable;
613
614 if (drm_atomic_helper_damage_merged(old_state, state, &damage))
615 gud_fb_handle_damage(gdrm, fb, &shadow_plane_state->data[0], &damage);
616
617 drm_gem_fb_end_cpu_access(fb, DMA_FROM_DEVICE);
618
619 ctrl_disable:
620 if (!crtc->state->enable)
621 gud_usb_set_u8(gdrm, GUD_REQ_SET_CONTROLLER_ENABLE, 0);
622
623 drm_dev_exit(idx);
624 }
625