xref: /linux/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c (revision e6020a55b8e364d15eac27f9c788e13114eec6b7)
1 /*
2  * Copyright 2007-8 Advanced Micro Devices, Inc.
3  * Copyright 2008 Red Hat Inc.
4  *
5  * Permission is hereby granted, free of charge, to any person obtaining a
6  * copy of this software and associated documentation files (the "Software"),
7  * to deal in the Software without restriction, including without limitation
8  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9  * and/or sell copies of the Software, and to permit persons to whom the
10  * Software is furnished to do so, subject to the following conditions:
11  *
12  * The above copyright notice and this permission notice shall be included in
13  * all copies or substantial portions of the Software.
14  *
15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
18  * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
19  * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
20  * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
21  * OTHER DEALINGS IN THE SOFTWARE.
22  *
23  * Authors: Dave Airlie
24  *          Alex Deucher
25  */
26 
27 #include <drm/display/drm_dp_helper.h>
28 #include <drm/drm_crtc_helper.h>
29 #include <drm/drm_edid.h>
30 #include <drm/drm_modeset_helper_vtables.h>
31 #include <drm/drm_probe_helper.h>
32 #include <drm/amdgpu_drm.h>
33 #include "amdgpu.h"
34 #include "atom.h"
35 #include "atombios_encoders.h"
36 #include "atombios_dp.h"
37 #include "amdgpu_connectors.h"
38 #include "amdgpu_i2c.h"
39 #include "amdgpu_display.h"
40 
41 #include <linux/pm_runtime.h>
42 
43 void amdgpu_connector_hotplug(struct drm_connector *connector)
44 {
45 	struct drm_device *dev = connector->dev;
46 	struct amdgpu_device *adev = drm_to_adev(dev);
47 	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
48 
49 	/* bail if the connector does not have hpd pin, e.g.,
50 	 * VGA, TV, etc.
51 	 */
52 	if (amdgpu_connector->hpd.hpd == AMDGPU_HPD_NONE)
53 		return;
54 
55 	amdgpu_display_hpd_set_polarity(adev, amdgpu_connector->hpd.hpd);
56 
57 	/* if the connector is already off, don't turn it back on */
58 	if (connector->dpms != DRM_MODE_DPMS_ON)
59 		return;
60 
61 	/* just deal with DP (not eDP) here. */
62 	if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
63 		struct amdgpu_connector_atom_dig *dig_connector =
64 			amdgpu_connector->con_priv;
65 
66 		/* if existing sink type was not DP no need to retrain */
67 		if (dig_connector->dp_sink_type != CONNECTOR_OBJECT_ID_DISPLAYPORT)
68 			return;
69 
70 		/* first get sink type as it may be reset after (un)plug */
71 		dig_connector->dp_sink_type = amdgpu_atombios_dp_get_sinktype(amdgpu_connector);
72 		/* don't do anything if sink is not display port, i.e.,
73 		 * passive dp->(dvi|hdmi) adaptor
74 		 */
75 		if (dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT &&
76 		    amdgpu_display_hpd_sense(adev, amdgpu_connector->hpd.hpd) &&
77 		    amdgpu_atombios_dp_needs_link_train(amdgpu_connector)) {
78 			/* Don't start link training before we have the DPCD */
79 			if (amdgpu_atombios_dp_get_dpcd(amdgpu_connector))
80 				return;
81 
82 			/* Turn the connector off and back on immediately, which
83 			 * will trigger link training
84 			 */
85 			drm_helper_connector_dpms(connector, DRM_MODE_DPMS_OFF);
86 			drm_helper_connector_dpms(connector, DRM_MODE_DPMS_ON);
87 		}
88 	}
89 }
90 
91 static void amdgpu_connector_property_change_mode(struct drm_encoder *encoder)
92 {
93 	struct drm_crtc *crtc = encoder->crtc;
94 
95 	if (crtc && crtc->enabled) {
96 		drm_crtc_helper_set_mode(crtc, &crtc->mode,
97 					 crtc->x, crtc->y, crtc->primary->fb);
98 	}
99 }
100 
101 int amdgpu_connector_get_monitor_bpc(struct drm_connector *connector)
102 {
103 	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
104 	struct amdgpu_connector_atom_dig *dig_connector;
105 	int bpc = 8;
106 	unsigned int mode_clock, max_tmds_clock;
107 
108 	switch (connector->connector_type) {
109 	case DRM_MODE_CONNECTOR_DVII:
110 	case DRM_MODE_CONNECTOR_HDMIB:
111 		if (amdgpu_connector->use_digital) {
112 			if (connector->display_info.is_hdmi) {
113 				if (connector->display_info.bpc)
114 					bpc = connector->display_info.bpc;
115 			}
116 		}
117 		break;
118 	case DRM_MODE_CONNECTOR_DVID:
119 	case DRM_MODE_CONNECTOR_HDMIA:
120 		if (connector->display_info.is_hdmi) {
121 			if (connector->display_info.bpc)
122 				bpc = connector->display_info.bpc;
123 		}
124 		break;
125 	case DRM_MODE_CONNECTOR_DisplayPort:
126 		dig_connector = amdgpu_connector->con_priv;
127 		if ((dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) ||
128 		    (dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_eDP) ||
129 		    connector->display_info.is_hdmi) {
130 			if (connector->display_info.bpc)
131 				bpc = connector->display_info.bpc;
132 		}
133 		break;
134 	case DRM_MODE_CONNECTOR_eDP:
135 	case DRM_MODE_CONNECTOR_LVDS:
136 		if (connector->display_info.bpc)
137 			bpc = connector->display_info.bpc;
138 		else {
139 			const struct drm_connector_helper_funcs *connector_funcs =
140 				connector->helper_private;
141 			struct drm_encoder *encoder = connector_funcs->best_encoder(connector);
142 			struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
143 			struct amdgpu_encoder_atom_dig *dig = amdgpu_encoder->enc_priv;
144 
145 			if (dig->lcd_misc & ATOM_PANEL_MISC_V13_6BIT_PER_COLOR)
146 				bpc = 6;
147 			else if (dig->lcd_misc & ATOM_PANEL_MISC_V13_8BIT_PER_COLOR)
148 				bpc = 8;
149 		}
150 		break;
151 	}
152 
153 	if (connector->display_info.is_hdmi) {
154 		/*
155 		 * Pre DCE-8 hw can't handle > 12 bpc, and more than 12 bpc doesn't make
156 		 * much sense without support for > 12 bpc framebuffers. RGB 4:4:4 at
157 		 * 12 bpc is always supported on hdmi deep color sinks, as this is
158 		 * required by the HDMI-1.3 spec. Clamp to a safe 12 bpc maximum.
159 		 */
160 		if (bpc > 12) {
161 			DRM_DEBUG("%s: HDMI deep color %d bpc unsupported. Using 12 bpc.\n",
162 				  connector->name, bpc);
163 			bpc = 12;
164 		}
165 
166 		/* Any defined maximum tmds clock limit we must not exceed? */
167 		if (connector->display_info.max_tmds_clock > 0) {
168 			/* mode_clock is clock in kHz for mode to be modeset on this connector */
169 			mode_clock = amdgpu_connector->pixelclock_for_modeset;
170 
171 			/* Maximum allowable input clock in kHz */
172 			max_tmds_clock = connector->display_info.max_tmds_clock;
173 
174 			DRM_DEBUG("%s: hdmi mode dotclock %d kHz, max tmds input clock %d kHz.\n",
175 				  connector->name, mode_clock, max_tmds_clock);
176 
177 			/* Check if bpc is within clock limit. Try to degrade gracefully otherwise */
178 			if ((bpc == 12) && (mode_clock * 3/2 > max_tmds_clock)) {
179 				if ((connector->display_info.edid_hdmi_rgb444_dc_modes & DRM_EDID_HDMI_DC_30) &&
180 				    (mode_clock * 5/4 <= max_tmds_clock))
181 					bpc = 10;
182 				else
183 					bpc = 8;
184 
185 				DRM_DEBUG("%s: HDMI deep color 12 bpc exceeds max tmds clock. Using %d bpc.\n",
186 					  connector->name, bpc);
187 			}
188 
189 			if ((bpc == 10) && (mode_clock * 5/4 > max_tmds_clock)) {
190 				bpc = 8;
191 				DRM_DEBUG("%s: HDMI deep color 10 bpc exceeds max tmds clock. Using %d bpc.\n",
192 					  connector->name, bpc);
193 			}
194 		} else if (bpc > 8) {
195 			/* max_tmds_clock missing, but hdmi spec mandates it for deep color. */
196 			DRM_DEBUG("%s: Required max tmds clock for HDMI deep color missing. Using 8 bpc.\n",
197 				  connector->name);
198 			bpc = 8;
199 		}
200 	}
201 
202 	if ((amdgpu_deep_color == 0) && (bpc > 8)) {
203 		DRM_DEBUG("%s: Deep color disabled. Set amdgpu module param deep_color=1 to enable.\n",
204 			  connector->name);
205 		bpc = 8;
206 	}
207 
208 	DRM_DEBUG("%s: Display bpc=%d, returned bpc=%d\n",
209 		  connector->name, connector->display_info.bpc, bpc);
210 
211 	return bpc;
212 }
213 
214 static void
215 amdgpu_connector_update_scratch_regs(struct drm_connector *connector,
216 				      enum drm_connector_status status)
217 {
218 	struct drm_encoder *best_encoder;
219 	struct drm_encoder *encoder;
220 	const struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
221 	bool connected;
222 
223 	best_encoder = connector_funcs->best_encoder(connector);
224 
225 	drm_connector_for_each_possible_encoder(connector, encoder) {
226 		if ((encoder == best_encoder) && (status == connector_status_connected))
227 			connected = true;
228 		else
229 			connected = false;
230 
231 		amdgpu_atombios_encoder_set_bios_scratch_regs(connector, encoder, connected);
232 	}
233 }
234 
235 static struct drm_encoder *
236 amdgpu_connector_find_encoder(struct drm_connector *connector,
237 			       int encoder_type)
238 {
239 	struct drm_encoder *encoder;
240 
241 	drm_connector_for_each_possible_encoder(connector, encoder) {
242 		if (encoder->encoder_type == encoder_type)
243 			return encoder;
244 	}
245 
246 	return NULL;
247 }
248 
249 static const struct drm_edid *
250 amdgpu_connector_get_hardcoded_edid(struct amdgpu_device *adev)
251 {
252 	return drm_edid_dup(adev->mode_info.bios_hardcoded_edid);
253 }
254 
255 static void amdgpu_connector_get_edid(struct drm_connector *connector)
256 {
257 	struct drm_device *dev = connector->dev;
258 	struct amdgpu_device *adev = drm_to_adev(dev);
259 	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
260 
261 	if (amdgpu_connector->edid)
262 		return;
263 
264 	/* on hw with routers, select right port */
265 	if (amdgpu_connector->router.ddc_valid)
266 		amdgpu_i2c_router_select_ddc_port(amdgpu_connector);
267 
268 	if ((amdgpu_connector_encoder_get_dp_bridge_encoder_id(connector) !=
269 	     ENCODER_OBJECT_ID_NONE) &&
270 	    amdgpu_connector->ddc_bus->has_aux) {
271 		amdgpu_connector->edid = drm_edid_read_ddc(connector,
272 							  &amdgpu_connector->ddc_bus->aux.ddc);
273 	} else if ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) ||
274 		   (connector->connector_type == DRM_MODE_CONNECTOR_eDP)) {
275 		struct amdgpu_connector_atom_dig *dig = amdgpu_connector->con_priv;
276 
277 		if ((dig->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT ||
278 		     dig->dp_sink_type == CONNECTOR_OBJECT_ID_eDP) &&
279 		    amdgpu_connector->ddc_bus->has_aux)
280 			amdgpu_connector->edid = drm_edid_read_ddc(connector,
281 								  &amdgpu_connector->ddc_bus->aux.ddc);
282 		else if (amdgpu_connector->ddc_bus)
283 			amdgpu_connector->edid = drm_edid_read_ddc(connector,
284 								  &amdgpu_connector->ddc_bus->adapter);
285 	} else if (amdgpu_connector->ddc_bus) {
286 		amdgpu_connector->edid = drm_edid_read_ddc(connector,
287 							  &amdgpu_connector->ddc_bus->adapter);
288 	}
289 
290 	if (!amdgpu_connector->edid) {
291 		/* some laptops provide a hardcoded edid in rom for LCDs */
292 		if (((connector->connector_type == DRM_MODE_CONNECTOR_LVDS) ||
293 		     (connector->connector_type == DRM_MODE_CONNECTOR_eDP))) {
294 			amdgpu_connector->edid = amdgpu_connector_get_hardcoded_edid(adev);
295 			drm_edid_connector_update(connector, amdgpu_connector->edid);
296 		}
297 	}
298 }
299 
300 static int amdgpu_connector_ddc_get_modes(struct drm_connector *connector)
301 {
302 	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
303 	int ret;
304 
305 	if (amdgpu_connector->edid) {
306 		drm_edid_connector_update(connector, amdgpu_connector->edid);
307 		ret = drm_edid_connector_add_modes(connector);
308 		return ret;
309 	}
310 	drm_edid_connector_update(connector, NULL);
311 	return 0;
312 }
313 
314 static struct drm_encoder *
315 amdgpu_connector_best_single_encoder(struct drm_connector *connector)
316 {
317 	struct drm_encoder *encoder;
318 
319 	/* pick the first one */
320 	drm_connector_for_each_possible_encoder(connector, encoder)
321 		return encoder;
322 
323 	return NULL;
324 }
325 
326 static void amdgpu_get_native_mode(struct drm_connector *connector)
327 {
328 	struct drm_encoder *encoder = amdgpu_connector_best_single_encoder(connector);
329 	struct amdgpu_encoder *amdgpu_encoder;
330 
331 	if (encoder == NULL)
332 		return;
333 
334 	amdgpu_encoder = to_amdgpu_encoder(encoder);
335 
336 	if (!list_empty(&connector->probed_modes)) {
337 		struct drm_display_mode *preferred_mode =
338 			list_first_entry(&connector->probed_modes,
339 					 struct drm_display_mode, head);
340 
341 		amdgpu_encoder->native_mode = *preferred_mode;
342 	} else {
343 		amdgpu_encoder->native_mode.clock = 0;
344 	}
345 }
346 
347 static struct drm_display_mode *
348 amdgpu_connector_lcd_native_mode(struct drm_encoder *encoder)
349 {
350 	struct drm_device *dev = encoder->dev;
351 	struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
352 	struct drm_display_mode *mode = NULL;
353 	struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
354 
355 	if (native_mode->hdisplay != 0 &&
356 	    native_mode->vdisplay != 0 &&
357 	    native_mode->clock != 0) {
358 		mode = drm_mode_duplicate(dev, native_mode);
359 		if (!mode)
360 			return NULL;
361 
362 		mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;
363 		drm_mode_set_name(mode);
364 
365 		DRM_DEBUG_KMS("Adding native panel mode %s\n", mode->name);
366 	} else if (native_mode->hdisplay != 0 &&
367 		   native_mode->vdisplay != 0) {
368 		/* mac laptops without an edid */
369 		/* Note that this is not necessarily the exact panel mode,
370 		 * but an approximation based on the cvt formula.  For these
371 		 * systems we should ideally read the mode info out of the
372 		 * registers or add a mode table, but this works and is much
373 		 * simpler.
374 		 */
375 		mode = drm_cvt_mode(dev, native_mode->hdisplay, native_mode->vdisplay, 60, true, false, false);
376 		if (!mode)
377 			return NULL;
378 
379 		mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;
380 		DRM_DEBUG_KMS("Adding cvt approximation of native panel mode %s\n", mode->name);
381 	}
382 	return mode;
383 }
384 
385 static void amdgpu_connector_add_common_modes(struct drm_encoder *encoder,
386 					       struct drm_connector *connector)
387 {
388 	struct drm_device *dev = encoder->dev;
389 	struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
390 	struct drm_display_mode *mode = NULL;
391 	struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
392 	int i;
393 	int n;
394 	struct mode_size {
395 		char name[DRM_DISPLAY_MODE_LEN];
396 		int w;
397 		int h;
398 	} common_modes[] = {
399 		{  "640x480",  640,  480},
400 		{  "800x600",  800,  600},
401 		{ "1024x768", 1024,  768},
402 		{ "1280x720", 1280,  720},
403 		{ "1280x800", 1280,  800},
404 		{"1280x1024", 1280, 1024},
405 		{ "1440x900", 1440,  900},
406 		{"1680x1050", 1680, 1050},
407 		{"1600x1200", 1600, 1200},
408 		{"1920x1080", 1920, 1080},
409 		{"1920x1200", 1920, 1200}
410 	};
411 
412 	n = ARRAY_SIZE(common_modes);
413 
414 	for (i = 0; i < n; i++) {
415 		if (amdgpu_encoder->devices & (ATOM_DEVICE_TV_SUPPORT)) {
416 			if (common_modes[i].w > 1024 ||
417 			    common_modes[i].h > 768)
418 				continue;
419 		}
420 		if (amdgpu_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT)) {
421 			if (common_modes[i].w > native_mode->hdisplay ||
422 			    common_modes[i].h > native_mode->vdisplay ||
423 			    (common_modes[i].w == native_mode->hdisplay &&
424 			     common_modes[i].h == native_mode->vdisplay))
425 				continue;
426 		}
427 
428 		mode = drm_cvt_mode(dev, common_modes[i].w, common_modes[i].h, 60, false, false, false);
429 		if (!mode)
430 			return;
431 		strscpy(mode->name, common_modes[i].name, DRM_DISPLAY_MODE_LEN);
432 
433 		drm_mode_probed_add(connector, mode);
434 	}
435 }
436 
437 static int amdgpu_connector_set_property(struct drm_connector *connector,
438 					  struct drm_property *property,
439 					  uint64_t val)
440 {
441 	struct drm_device *dev = connector->dev;
442 	struct amdgpu_device *adev = drm_to_adev(dev);
443 	struct drm_encoder *encoder;
444 	struct amdgpu_encoder *amdgpu_encoder;
445 
446 	if (property == adev->mode_info.coherent_mode_property) {
447 		struct amdgpu_encoder_atom_dig *dig;
448 		bool new_coherent_mode;
449 
450 		/* need to find digital encoder on connector */
451 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
452 		if (!encoder)
453 			return 0;
454 
455 		amdgpu_encoder = to_amdgpu_encoder(encoder);
456 
457 		if (!amdgpu_encoder->enc_priv)
458 			return 0;
459 
460 		dig = amdgpu_encoder->enc_priv;
461 		new_coherent_mode = val ? true : false;
462 		if (dig->coherent_mode != new_coherent_mode) {
463 			dig->coherent_mode = new_coherent_mode;
464 			amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
465 		}
466 	}
467 
468 	if (property == adev->mode_info.audio_property) {
469 		struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
470 		/* need to find digital encoder on connector */
471 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
472 		if (!encoder)
473 			return 0;
474 
475 		amdgpu_encoder = to_amdgpu_encoder(encoder);
476 
477 		if (amdgpu_connector->audio != val) {
478 			amdgpu_connector->audio = val;
479 			amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
480 		}
481 	}
482 
483 	if (property == adev->mode_info.dither_property) {
484 		struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
485 		/* need to find digital encoder on connector */
486 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
487 		if (!encoder)
488 			return 0;
489 
490 		amdgpu_encoder = to_amdgpu_encoder(encoder);
491 
492 		if (amdgpu_connector->dither != val) {
493 			amdgpu_connector->dither = val;
494 			amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
495 		}
496 	}
497 
498 	if (property == adev->mode_info.underscan_property) {
499 		/* need to find digital encoder on connector */
500 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
501 		if (!encoder)
502 			return 0;
503 
504 		amdgpu_encoder = to_amdgpu_encoder(encoder);
505 
506 		if (amdgpu_encoder->underscan_type != val) {
507 			amdgpu_encoder->underscan_type = val;
508 			amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
509 		}
510 	}
511 
512 	if (property == adev->mode_info.underscan_hborder_property) {
513 		/* need to find digital encoder on connector */
514 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
515 		if (!encoder)
516 			return 0;
517 
518 		amdgpu_encoder = to_amdgpu_encoder(encoder);
519 
520 		if (amdgpu_encoder->underscan_hborder != val) {
521 			amdgpu_encoder->underscan_hborder = val;
522 			amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
523 		}
524 	}
525 
526 	if (property == adev->mode_info.underscan_vborder_property) {
527 		/* need to find digital encoder on connector */
528 		encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
529 		if (!encoder)
530 			return 0;
531 
532 		amdgpu_encoder = to_amdgpu_encoder(encoder);
533 
534 		if (amdgpu_encoder->underscan_vborder != val) {
535 			amdgpu_encoder->underscan_vborder = val;
536 			amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
537 		}
538 	}
539 
540 	if (property == adev->mode_info.load_detect_property) {
541 		struct amdgpu_connector *amdgpu_connector =
542 			to_amdgpu_connector(connector);
543 
544 		if (val == 0)
545 			amdgpu_connector->dac_load_detect = false;
546 		else
547 			amdgpu_connector->dac_load_detect = true;
548 	}
549 
550 	if (property == dev->mode_config.scaling_mode_property) {
551 		enum amdgpu_rmx_type rmx_type;
552 
553 		if (connector->encoder) {
554 			amdgpu_encoder = to_amdgpu_encoder(connector->encoder);
555 		} else {
556 			const struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
557 
558 			amdgpu_encoder = to_amdgpu_encoder(connector_funcs->best_encoder(connector));
559 		}
560 
561 		switch (val) {
562 		default:
563 		case DRM_MODE_SCALE_NONE:
564 			rmx_type = RMX_OFF;
565 			break;
566 		case DRM_MODE_SCALE_CENTER:
567 			rmx_type = RMX_CENTER;
568 			break;
569 		case DRM_MODE_SCALE_ASPECT:
570 			rmx_type = RMX_ASPECT;
571 			break;
572 		case DRM_MODE_SCALE_FULLSCREEN:
573 			rmx_type = RMX_FULL;
574 			break;
575 		}
576 
577 		if (amdgpu_encoder->rmx_type == rmx_type)
578 			return 0;
579 
580 		if ((rmx_type != DRM_MODE_SCALE_NONE) &&
581 		    (amdgpu_encoder->native_mode.clock == 0))
582 			return 0;
583 
584 		amdgpu_encoder->rmx_type = rmx_type;
585 
586 		amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
587 	}
588 
589 	return 0;
590 }
591 
592 static void
593 amdgpu_connector_fixup_lcd_native_mode(struct drm_encoder *encoder,
594 					struct drm_connector *connector)
595 {
596 	struct amdgpu_encoder *amdgpu_encoder =	to_amdgpu_encoder(encoder);
597 	struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
598 	struct drm_display_mode *t, *mode;
599 
600 	/* If the EDID preferred mode doesn't match the native mode, use it */
601 	list_for_each_entry_safe(mode, t, &connector->probed_modes, head) {
602 		if (mode->type & DRM_MODE_TYPE_PREFERRED) {
603 			if (mode->hdisplay != native_mode->hdisplay ||
604 			    mode->vdisplay != native_mode->vdisplay)
605 				drm_mode_copy(native_mode, mode);
606 		}
607 	}
608 
609 	/* Try to get native mode details from EDID if necessary */
610 	if (!native_mode->clock) {
611 		list_for_each_entry_safe(mode, t, &connector->probed_modes, head) {
612 			if (mode->hdisplay == native_mode->hdisplay &&
613 			    mode->vdisplay == native_mode->vdisplay) {
614 				drm_mode_copy(native_mode, mode);
615 				drm_mode_set_crtcinfo(native_mode, CRTC_INTERLACE_HALVE_V);
616 				DRM_DEBUG_KMS("Determined LVDS native mode details from EDID\n");
617 				break;
618 			}
619 		}
620 	}
621 
622 	if (!native_mode->clock) {
623 		DRM_DEBUG_KMS("No LVDS native mode details, disabling RMX\n");
624 		amdgpu_encoder->rmx_type = RMX_OFF;
625 	}
626 }
627 
628 static int amdgpu_connector_lvds_get_modes(struct drm_connector *connector)
629 {
630 	struct drm_encoder *encoder;
631 	int ret = 0;
632 	struct drm_display_mode *mode;
633 
634 	amdgpu_connector_get_edid(connector);
635 	ret = amdgpu_connector_ddc_get_modes(connector);
636 	if (ret > 0) {
637 		encoder = amdgpu_connector_best_single_encoder(connector);
638 		if (encoder) {
639 			amdgpu_connector_fixup_lcd_native_mode(encoder, connector);
640 			/* add scaled modes */
641 			amdgpu_connector_add_common_modes(encoder, connector);
642 		}
643 		return ret;
644 	}
645 
646 	encoder = amdgpu_connector_best_single_encoder(connector);
647 	if (!encoder)
648 		return 0;
649 
650 	/* we have no EDID modes */
651 	mode = amdgpu_connector_lcd_native_mode(encoder);
652 	if (mode) {
653 		ret = 1;
654 		drm_mode_probed_add(connector, mode);
655 		/* add the width/height from vbios tables if available */
656 		connector->display_info.width_mm = mode->width_mm;
657 		connector->display_info.height_mm = mode->height_mm;
658 		/* add scaled modes */
659 		amdgpu_connector_add_common_modes(encoder, connector);
660 	}
661 
662 	return ret;
663 }
664 
665 static enum drm_mode_status amdgpu_connector_lvds_mode_valid(struct drm_connector *connector,
666 					     const struct drm_display_mode *mode)
667 {
668 	struct drm_encoder *encoder = amdgpu_connector_best_single_encoder(connector);
669 
670 	if ((mode->hdisplay < 320) || (mode->vdisplay < 240))
671 		return MODE_PANEL;
672 
673 	if (encoder) {
674 		struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
675 		struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
676 
677 		/* AVIVO hardware supports downscaling modes larger than the panel
678 		 * to the panel size, but I'm not sure this is desirable.
679 		 */
680 		if ((mode->hdisplay > native_mode->hdisplay) ||
681 		    (mode->vdisplay > native_mode->vdisplay))
682 			return MODE_PANEL;
683 
684 		/* if scaling is disabled, block non-native modes */
685 		if (amdgpu_encoder->rmx_type == RMX_OFF) {
686 			if ((mode->hdisplay != native_mode->hdisplay) ||
687 			    (mode->vdisplay != native_mode->vdisplay))
688 				return MODE_PANEL;
689 		}
690 	}
691 
692 	return MODE_OK;
693 }
694 
695 static enum drm_connector_status
696 amdgpu_connector_lvds_detect(struct drm_connector *connector, bool force)
697 {
698 	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
699 	struct drm_encoder *encoder = amdgpu_connector_best_single_encoder(connector);
700 	enum drm_connector_status ret = connector_status_disconnected;
701 	int r;
702 
703 	if (!drm_kms_helper_is_poll_worker()) {
704 		r = pm_runtime_get_sync(connector->dev->dev);
705 		if (r < 0) {
706 			pm_runtime_put_autosuspend(connector->dev->dev);
707 			return connector_status_disconnected;
708 		}
709 	}
710 
711 	if (encoder) {
712 		struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
713 		struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
714 
715 		/* check if panel is valid */
716 		if (native_mode->hdisplay >= 320 && native_mode->vdisplay >= 240)
717 			ret = connector_status_connected;
718 
719 	}
720 
721 	/* check for edid as well */
722 	amdgpu_connector_get_edid(connector);
723 	if (amdgpu_connector->edid)
724 		ret = connector_status_connected;
725 	/* check acpi lid status ??? */
726 
727 	amdgpu_connector_update_scratch_regs(connector, ret);
728 
729 	if (!drm_kms_helper_is_poll_worker())
730 		pm_runtime_put_autosuspend(connector->dev->dev);
731 
732 	return ret;
733 }
734 
735 static void amdgpu_connector_unregister(struct drm_connector *connector)
736 {
737 	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
738 
739 	if (amdgpu_connector->ddc_bus && amdgpu_connector->ddc_bus->has_aux) {
740 		drm_dp_aux_unregister(&amdgpu_connector->ddc_bus->aux);
741 		amdgpu_connector->ddc_bus->has_aux = false;
742 	}
743 }
744 
745 static void amdgpu_connector_destroy(struct drm_connector *connector)
746 {
747 	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
748 
749 	drm_edid_free(amdgpu_connector->edid);
750 	kfree(amdgpu_connector->con_priv);
751 	drm_connector_unregister(connector);
752 	drm_connector_cleanup(connector);
753 	kfree(connector);
754 }
755 
756 static int amdgpu_connector_set_lcd_property(struct drm_connector *connector,
757 					      struct drm_property *property,
758 					      uint64_t value)
759 {
760 	struct drm_device *dev = connector->dev;
761 	struct amdgpu_encoder *amdgpu_encoder;
762 	enum amdgpu_rmx_type rmx_type;
763 
764 	DRM_DEBUG_KMS("\n");
765 	if (property != dev->mode_config.scaling_mode_property)
766 		return 0;
767 
768 	if (connector->encoder)
769 		amdgpu_encoder = to_amdgpu_encoder(connector->encoder);
770 	else {
771 		const struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
772 
773 		amdgpu_encoder = to_amdgpu_encoder(connector_funcs->best_encoder(connector));
774 	}
775 
776 	switch (value) {
777 	case DRM_MODE_SCALE_NONE:
778 		rmx_type = RMX_OFF;
779 		break;
780 	case DRM_MODE_SCALE_CENTER:
781 		rmx_type = RMX_CENTER;
782 		break;
783 	case DRM_MODE_SCALE_ASPECT:
784 		rmx_type = RMX_ASPECT;
785 		break;
786 	default:
787 	case DRM_MODE_SCALE_FULLSCREEN:
788 		rmx_type = RMX_FULL;
789 		break;
790 	}
791 
792 	if (amdgpu_encoder->rmx_type == rmx_type)
793 		return 0;
794 
795 	amdgpu_encoder->rmx_type = rmx_type;
796 
797 	amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
798 	return 0;
799 }
800 
801 
802 static const struct drm_connector_helper_funcs amdgpu_connector_lvds_helper_funcs = {
803 	.get_modes = amdgpu_connector_lvds_get_modes,
804 	.mode_valid = amdgpu_connector_lvds_mode_valid,
805 	.best_encoder = amdgpu_connector_best_single_encoder,
806 };
807 
808 static const struct drm_connector_funcs amdgpu_connector_lvds_funcs = {
809 	.dpms = drm_helper_connector_dpms,
810 	.detect = amdgpu_connector_lvds_detect,
811 	.fill_modes = drm_helper_probe_single_connector_modes,
812 	.early_unregister = amdgpu_connector_unregister,
813 	.destroy = amdgpu_connector_destroy,
814 	.set_property = amdgpu_connector_set_lcd_property,
815 };
816 
817 static int amdgpu_connector_vga_get_modes(struct drm_connector *connector)
818 {
819 	int ret;
820 
821 	amdgpu_connector_get_edid(connector);
822 	ret = amdgpu_connector_ddc_get_modes(connector);
823 	amdgpu_get_native_mode(connector);
824 
825 	return ret;
826 }
827 
828 static enum drm_mode_status amdgpu_connector_vga_mode_valid(struct drm_connector *connector,
829 					    const struct drm_display_mode *mode)
830 {
831 	struct drm_device *dev = connector->dev;
832 	struct amdgpu_device *adev = drm_to_adev(dev);
833 
834 	/* XXX check mode bandwidth */
835 
836 	if ((mode->clock / 10) > adev->clock.max_pixel_clock)
837 		return MODE_CLOCK_HIGH;
838 
839 	return MODE_OK;
840 }
841 
842 static enum drm_connector_status
843 amdgpu_connector_vga_detect(struct drm_connector *connector, bool force)
844 {
845 	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
846 	struct drm_encoder *encoder;
847 	const struct drm_encoder_helper_funcs *encoder_funcs;
848 	bool dret = false;
849 	enum drm_connector_status ret = connector_status_disconnected;
850 	int r;
851 
852 	if (!drm_kms_helper_is_poll_worker()) {
853 		r = pm_runtime_get_sync(connector->dev->dev);
854 		if (r < 0) {
855 			pm_runtime_put_autosuspend(connector->dev->dev);
856 			return connector_status_disconnected;
857 		}
858 	}
859 
860 	encoder = amdgpu_connector_best_single_encoder(connector);
861 	if (!encoder)
862 		ret = connector_status_disconnected;
863 
864 	if (amdgpu_connector->ddc_bus)
865 		dret = amdgpu_display_ddc_probe(amdgpu_connector, false);
866 	if (dret) {
867 		amdgpu_connector->detected_by_load = false;
868 		drm_edid_free(amdgpu_connector->edid);
869 		amdgpu_connector_get_edid(connector);
870 
871 		if (!amdgpu_connector->edid) {
872 			drm_err(connector->dev,
873 				"%s: probed a monitor but no|invalid EDID\n",
874 				connector->name);
875 			ret = connector_status_connected;
876 		} else {
877 			amdgpu_connector->use_digital =
878 				drm_edid_is_digital(amdgpu_connector->edid);
879 
880 			/* some oems have boards with separate digital and analog connectors
881 			 * with a shared ddc line (often vga + hdmi)
882 			 */
883 			if (amdgpu_connector->use_digital && amdgpu_connector->shared_ddc) {
884 				drm_edid_free(amdgpu_connector->edid);
885 				ret = connector_status_disconnected;
886 			} else {
887 				ret = connector_status_connected;
888 			}
889 		}
890 	} else {
891 
892 		/* if we aren't forcing don't do destructive polling */
893 		if (!force) {
894 			/* only return the previous status if we last
895 			 * detected a monitor via load.
896 			 */
897 			if (amdgpu_connector->detected_by_load)
898 				ret = connector->status;
899 			goto out;
900 		}
901 
902 		if (amdgpu_connector->dac_load_detect && encoder) {
903 			encoder_funcs = encoder->helper_private;
904 			ret = encoder_funcs->detect(encoder, connector);
905 			if (ret != connector_status_disconnected)
906 				amdgpu_connector->detected_by_load = true;
907 		}
908 	}
909 
910 	amdgpu_connector_update_scratch_regs(connector, ret);
911 
912 out:
913 	if (!drm_kms_helper_is_poll_worker())
914 		pm_runtime_put_autosuspend(connector->dev->dev);
915 
916 	return ret;
917 }
918 
919 static const struct drm_connector_helper_funcs amdgpu_connector_vga_helper_funcs = {
920 	.get_modes = amdgpu_connector_vga_get_modes,
921 	.mode_valid = amdgpu_connector_vga_mode_valid,
922 	.best_encoder = amdgpu_connector_best_single_encoder,
923 };
924 
925 static const struct drm_connector_funcs amdgpu_connector_vga_funcs = {
926 	.dpms = drm_helper_connector_dpms,
927 	.detect = amdgpu_connector_vga_detect,
928 	.fill_modes = drm_helper_probe_single_connector_modes,
929 	.early_unregister = amdgpu_connector_unregister,
930 	.destroy = amdgpu_connector_destroy,
931 	.set_property = amdgpu_connector_set_property,
932 };
933 
934 static bool
935 amdgpu_connector_check_hpd_status_unchanged(struct drm_connector *connector)
936 {
937 	struct drm_device *dev = connector->dev;
938 	struct amdgpu_device *adev = drm_to_adev(dev);
939 	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
940 	enum drm_connector_status status;
941 
942 	if (amdgpu_connector->hpd.hpd != AMDGPU_HPD_NONE) {
943 		if (amdgpu_display_hpd_sense(adev, amdgpu_connector->hpd.hpd))
944 			status = connector_status_connected;
945 		else
946 			status = connector_status_disconnected;
947 		if (connector->status == status)
948 			return true;
949 	}
950 
951 	return false;
952 }
953 
954 static void amdgpu_connector_shared_ddc(enum drm_connector_status *status,
955 					struct drm_connector *connector,
956 					struct amdgpu_connector *amdgpu_connector)
957 {
958 	struct drm_connector *list_connector;
959 	struct drm_connector_list_iter iter;
960 	struct amdgpu_connector *list_amdgpu_connector;
961 	struct drm_device *dev = connector->dev;
962 	struct amdgpu_device *adev = drm_to_adev(dev);
963 
964 	if (amdgpu_connector->shared_ddc && *status == connector_status_connected) {
965 		drm_connector_list_iter_begin(dev, &iter);
966 		drm_for_each_connector_iter(list_connector,
967 					    &iter) {
968 			if (connector == list_connector)
969 				continue;
970 			list_amdgpu_connector = to_amdgpu_connector(list_connector);
971 			if (list_amdgpu_connector->shared_ddc &&
972 			    list_amdgpu_connector->ddc_bus->rec.i2c_id ==
973 			     amdgpu_connector->ddc_bus->rec.i2c_id) {
974 				/* cases where both connectors are digital */
975 				if (list_connector->connector_type != DRM_MODE_CONNECTOR_VGA) {
976 					/* hpd is our only option in this case */
977 					if (!amdgpu_display_hpd_sense(adev,
978 								      amdgpu_connector->hpd.hpd)) {
979 						drm_edid_free(amdgpu_connector->edid);
980 						*status = connector_status_disconnected;
981 					}
982 				}
983 			}
984 		}
985 		drm_connector_list_iter_end(&iter);
986 	}
987 }
988 
989 /*
990  * DVI is complicated
991  * Do a DDC probe, if DDC probe passes, get the full EDID so
992  * we can do analog/digital monitor detection at this point.
993  * If the monitor is an analog monitor or we got no DDC,
994  * we need to find the DAC encoder object for this connector.
995  * If we got no DDC, we do load detection on the DAC encoder object.
996  * If we got analog DDC or load detection passes on the DAC encoder
997  * we have to check if this analog encoder is shared with anyone else (TV)
998  * if its shared we have to set the other connector to disconnected.
999  */
1000 static enum drm_connector_status
1001 amdgpu_connector_dvi_detect(struct drm_connector *connector, bool force)
1002 {
1003 	struct drm_device *dev = connector->dev;
1004 	struct amdgpu_device *adev = drm_to_adev(dev);
1005 	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1006 	const struct drm_encoder_helper_funcs *encoder_funcs;
1007 	int r;
1008 	enum drm_connector_status ret = connector_status_disconnected;
1009 	bool dret = false, broken_edid = false;
1010 
1011 	if (!drm_kms_helper_is_poll_worker()) {
1012 		r = pm_runtime_get_sync(connector->dev->dev);
1013 		if (r < 0) {
1014 			pm_runtime_put_autosuspend(connector->dev->dev);
1015 			return connector_status_disconnected;
1016 		}
1017 	}
1018 
1019 	if (amdgpu_connector->detected_hpd_without_ddc) {
1020 		force = true;
1021 		amdgpu_connector->detected_hpd_without_ddc = false;
1022 	}
1023 
1024 	if (!force && amdgpu_connector_check_hpd_status_unchanged(connector)) {
1025 		ret = connector->status;
1026 		goto exit;
1027 	}
1028 
1029 	if (amdgpu_connector->ddc_bus) {
1030 		dret = amdgpu_display_ddc_probe(amdgpu_connector, false);
1031 
1032 		/* Sometimes the pins required for the DDC probe on DVI
1033 		 * connectors don't make contact at the same time that the ones
1034 		 * for HPD do. If the DDC probe fails even though we had an HPD
1035 		 * signal, try again later
1036 		 */
1037 		if (!dret && !force &&
1038 		    amdgpu_display_hpd_sense(adev, amdgpu_connector->hpd.hpd)) {
1039 			DRM_DEBUG_KMS("hpd detected without ddc, retrying in 1 second\n");
1040 			amdgpu_connector->detected_hpd_without_ddc = true;
1041 			schedule_delayed_work(&adev->hotplug_work,
1042 					      msecs_to_jiffies(1000));
1043 			goto exit;
1044 		}
1045 	}
1046 	if (dret) {
1047 		amdgpu_connector->detected_by_load = false;
1048 		drm_edid_free(amdgpu_connector->edid);
1049 		amdgpu_connector_get_edid(connector);
1050 
1051 		if (!amdgpu_connector->edid) {
1052 			drm_err(adev_to_drm(adev), "%s: probed a monitor but no|invalid EDID\n",
1053 					connector->name);
1054 			ret = connector_status_connected;
1055 			broken_edid = true; /* defer use_digital to later */
1056 		} else {
1057 			amdgpu_connector->use_digital =
1058 				drm_edid_is_digital(amdgpu_connector->edid);
1059 
1060 			/* some oems have boards with separate digital and analog connectors
1061 			 * with a shared ddc line (often vga + hdmi)
1062 			 */
1063 			if ((!amdgpu_connector->use_digital) && amdgpu_connector->shared_ddc) {
1064 				drm_edid_free(amdgpu_connector->edid);
1065 				ret = connector_status_disconnected;
1066 			} else {
1067 				ret = connector_status_connected;
1068 			}
1069 
1070 			/* This gets complicated.  We have boards with VGA + HDMI with a
1071 			 * shared DDC line and we have boards with DVI-D + HDMI with a shared
1072 			 * DDC line.  The latter is more complex because with DVI<->HDMI adapters
1073 			 * you don't really know what's connected to which port as both are digital.
1074 			 */
1075 			amdgpu_connector_shared_ddc(&ret, connector, amdgpu_connector);
1076 		}
1077 	}
1078 
1079 	if ((ret == connector_status_connected) && (amdgpu_connector->use_digital == true))
1080 		goto out;
1081 
1082 	/* DVI-D and HDMI-A are digital only */
1083 	if ((connector->connector_type == DRM_MODE_CONNECTOR_DVID) ||
1084 	    (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA))
1085 		goto out;
1086 
1087 	/* if we aren't forcing don't do destructive polling */
1088 	if (!force) {
1089 		/* only return the previous status if we last
1090 		 * detected a monitor via load.
1091 		 */
1092 		if (amdgpu_connector->detected_by_load)
1093 			ret = connector->status;
1094 		goto out;
1095 	}
1096 
1097 	/* find analog encoder */
1098 	if (amdgpu_connector->dac_load_detect) {
1099 		struct drm_encoder *encoder;
1100 
1101 		drm_connector_for_each_possible_encoder(connector, encoder) {
1102 			if (encoder->encoder_type != DRM_MODE_ENCODER_DAC &&
1103 			    encoder->encoder_type != DRM_MODE_ENCODER_TVDAC)
1104 				continue;
1105 
1106 			encoder_funcs = encoder->helper_private;
1107 			if (encoder_funcs->detect) {
1108 				if (!broken_edid) {
1109 					if (ret != connector_status_connected) {
1110 						/* deal with analog monitors without DDC */
1111 						ret = encoder_funcs->detect(encoder, connector);
1112 						if (ret == connector_status_connected) {
1113 							amdgpu_connector->use_digital = false;
1114 						}
1115 						if (ret != connector_status_disconnected)
1116 							amdgpu_connector->detected_by_load = true;
1117 					}
1118 				} else {
1119 					enum drm_connector_status lret;
1120 					/* assume digital unless load detected otherwise */
1121 					amdgpu_connector->use_digital = true;
1122 					lret = encoder_funcs->detect(encoder, connector);
1123 					DRM_DEBUG_KMS("load_detect %x returned: %x\n",
1124 						      encoder->encoder_type, lret);
1125 					if (lret == connector_status_connected)
1126 						amdgpu_connector->use_digital = false;
1127 				}
1128 				break;
1129 			}
1130 		}
1131 	}
1132 
1133 out:
1134 	/* updated in get modes as well since we need to know if it's analog or digital */
1135 	amdgpu_connector_update_scratch_regs(connector, ret);
1136 
1137 exit:
1138 	if (!drm_kms_helper_is_poll_worker())
1139 		pm_runtime_put_autosuspend(connector->dev->dev);
1140 
1141 	return ret;
1142 }
1143 
1144 /* okay need to be smart in here about which encoder to pick */
1145 static struct drm_encoder *
1146 amdgpu_connector_dvi_encoder(struct drm_connector *connector)
1147 {
1148 	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1149 	struct drm_encoder *encoder;
1150 
1151 	drm_connector_for_each_possible_encoder(connector, encoder) {
1152 		if (amdgpu_connector->use_digital == true) {
1153 			if (encoder->encoder_type == DRM_MODE_ENCODER_TMDS)
1154 				return encoder;
1155 		} else {
1156 			if (encoder->encoder_type == DRM_MODE_ENCODER_DAC ||
1157 			    encoder->encoder_type == DRM_MODE_ENCODER_TVDAC)
1158 				return encoder;
1159 		}
1160 	}
1161 
1162 	/* see if we have a default encoder  TODO */
1163 
1164 	/* then check use digitial */
1165 	/* pick the first one */
1166 	drm_connector_for_each_possible_encoder(connector, encoder)
1167 		return encoder;
1168 
1169 	return NULL;
1170 }
1171 
1172 static void amdgpu_connector_dvi_force(struct drm_connector *connector)
1173 {
1174 	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1175 
1176 	if (connector->force == DRM_FORCE_ON)
1177 		amdgpu_connector->use_digital = false;
1178 	if (connector->force == DRM_FORCE_ON_DIGITAL)
1179 		amdgpu_connector->use_digital = true;
1180 }
1181 
1182 /**
1183  * amdgpu_max_hdmi_pixel_clock - Return max supported HDMI (TMDS) pixel clock
1184  * @adev: pointer to amdgpu_device
1185  *
1186  * Return: maximum supported HDMI (TMDS) pixel clock in KHz.
1187  */
1188 static int amdgpu_max_hdmi_pixel_clock(const struct amdgpu_device *adev)
1189 {
1190 	if (adev->asic_type >= CHIP_POLARIS10)
1191 		return 600000;
1192 	else if (adev->asic_type >= CHIP_TONGA)
1193 		return 300000;
1194 	else
1195 		return 297000;
1196 }
1197 
1198 /**
1199  * amdgpu_connector_dvi_mode_valid - Validate a mode on DVI/HDMI connectors
1200  * @connector: DRM connector to validate the mode on
1201  * @mode: display mode to validate
1202  *
1203  * Validate the given display mode on DVI and HDMI connectors, including
1204  * analog signals on DVI-I.
1205  *
1206  * Return: drm_mode_status indicating whether the mode is valid.
1207  */
1208 static enum drm_mode_status amdgpu_connector_dvi_mode_valid(struct drm_connector *connector,
1209 					    const struct drm_display_mode *mode)
1210 {
1211 	struct drm_device *dev = connector->dev;
1212 	struct amdgpu_device *adev = drm_to_adev(dev);
1213 	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1214 	const int max_hdmi_pixel_clock = amdgpu_max_hdmi_pixel_clock(adev);
1215 	const int max_dvi_single_link_pixel_clock = 165000;
1216 	int max_digital_pixel_clock_khz;
1217 
1218 	/* XXX check mode bandwidth */
1219 
1220 	if (amdgpu_connector->use_digital) {
1221 		switch (amdgpu_connector->connector_object_id) {
1222 		case CONNECTOR_OBJECT_ID_HDMI_TYPE_A:
1223 			max_digital_pixel_clock_khz = max_hdmi_pixel_clock;
1224 			break;
1225 		case CONNECTOR_OBJECT_ID_SINGLE_LINK_DVI_I:
1226 		case CONNECTOR_OBJECT_ID_SINGLE_LINK_DVI_D:
1227 			max_digital_pixel_clock_khz = max_dvi_single_link_pixel_clock;
1228 			break;
1229 		case CONNECTOR_OBJECT_ID_DUAL_LINK_DVI_I:
1230 		case CONNECTOR_OBJECT_ID_DUAL_LINK_DVI_D:
1231 		case CONNECTOR_OBJECT_ID_HDMI_TYPE_B:
1232 			max_digital_pixel_clock_khz = max_dvi_single_link_pixel_clock * 2;
1233 			break;
1234 		default:
1235 			return MODE_BAD;
1236 		}
1237 
1238 		/* When the display EDID claims that it's an HDMI display,
1239 		 * we use the HDMI encoder mode of the display HW,
1240 		 * so we should verify against the max HDMI clock here.
1241 		 */
1242 		if (connector->display_info.is_hdmi)
1243 			max_digital_pixel_clock_khz = max_hdmi_pixel_clock;
1244 
1245 		if (mode->clock > max_digital_pixel_clock_khz)
1246 			return MODE_CLOCK_HIGH;
1247 	}
1248 
1249 	/* check against the max pixel clock */
1250 	if ((mode->clock / 10) > adev->clock.max_pixel_clock)
1251 		return MODE_CLOCK_HIGH;
1252 
1253 	return MODE_OK;
1254 }
1255 
1256 static const struct drm_connector_helper_funcs amdgpu_connector_dvi_helper_funcs = {
1257 	.get_modes = amdgpu_connector_vga_get_modes,
1258 	.mode_valid = amdgpu_connector_dvi_mode_valid,
1259 	.best_encoder = amdgpu_connector_dvi_encoder,
1260 };
1261 
1262 static const struct drm_connector_funcs amdgpu_connector_dvi_funcs = {
1263 	.dpms = drm_helper_connector_dpms,
1264 	.detect = amdgpu_connector_dvi_detect,
1265 	.fill_modes = drm_helper_probe_single_connector_modes,
1266 	.set_property = amdgpu_connector_set_property,
1267 	.early_unregister = amdgpu_connector_unregister,
1268 	.destroy = amdgpu_connector_destroy,
1269 	.force = amdgpu_connector_dvi_force,
1270 };
1271 
1272 static int amdgpu_connector_dp_get_modes(struct drm_connector *connector)
1273 {
1274 	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1275 	struct amdgpu_connector_atom_dig *amdgpu_dig_connector = amdgpu_connector->con_priv;
1276 	struct drm_encoder *encoder = amdgpu_connector_best_single_encoder(connector);
1277 	int ret;
1278 
1279 	if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) ||
1280 	    (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)) {
1281 		struct drm_display_mode *mode;
1282 
1283 		if (connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
1284 			if (!amdgpu_dig_connector->edp_on)
1285 				amdgpu_atombios_encoder_set_edp_panel_power(connector,
1286 								     ATOM_TRANSMITTER_ACTION_POWER_ON);
1287 			amdgpu_connector_get_edid(connector);
1288 			ret = amdgpu_connector_ddc_get_modes(connector);
1289 			if (!amdgpu_dig_connector->edp_on)
1290 				amdgpu_atombios_encoder_set_edp_panel_power(connector,
1291 								     ATOM_TRANSMITTER_ACTION_POWER_OFF);
1292 		} else {
1293 			/* need to setup ddc on the bridge */
1294 			if (amdgpu_connector_encoder_get_dp_bridge_encoder_id(connector) !=
1295 			    ENCODER_OBJECT_ID_NONE) {
1296 				if (encoder)
1297 					amdgpu_atombios_encoder_setup_ext_encoder_ddc(encoder);
1298 			}
1299 			amdgpu_connector_get_edid(connector);
1300 			ret = amdgpu_connector_ddc_get_modes(connector);
1301 		}
1302 
1303 		if (ret > 0) {
1304 			if (encoder) {
1305 				amdgpu_connector_fixup_lcd_native_mode(encoder, connector);
1306 				/* add scaled modes */
1307 				amdgpu_connector_add_common_modes(encoder, connector);
1308 			}
1309 			return ret;
1310 		}
1311 
1312 		if (!encoder)
1313 			return 0;
1314 
1315 		/* we have no EDID modes */
1316 		mode = amdgpu_connector_lcd_native_mode(encoder);
1317 		if (mode) {
1318 			ret = 1;
1319 			drm_mode_probed_add(connector, mode);
1320 			/* add the width/height from vbios tables if available */
1321 			connector->display_info.width_mm = mode->width_mm;
1322 			connector->display_info.height_mm = mode->height_mm;
1323 			/* add scaled modes */
1324 			amdgpu_connector_add_common_modes(encoder, connector);
1325 		}
1326 	} else {
1327 		/* need to setup ddc on the bridge */
1328 		if (amdgpu_connector_encoder_get_dp_bridge_encoder_id(connector) !=
1329 			ENCODER_OBJECT_ID_NONE) {
1330 			if (encoder)
1331 				amdgpu_atombios_encoder_setup_ext_encoder_ddc(encoder);
1332 		}
1333 		amdgpu_connector_get_edid(connector);
1334 		ret = amdgpu_connector_ddc_get_modes(connector);
1335 
1336 		amdgpu_get_native_mode(connector);
1337 	}
1338 
1339 	return ret;
1340 }
1341 
1342 u16 amdgpu_connector_encoder_get_dp_bridge_encoder_id(struct drm_connector *connector)
1343 {
1344 	struct drm_encoder *encoder;
1345 	struct amdgpu_encoder *amdgpu_encoder;
1346 
1347 	drm_connector_for_each_possible_encoder(connector, encoder) {
1348 		amdgpu_encoder = to_amdgpu_encoder(encoder);
1349 
1350 		switch (amdgpu_encoder->encoder_id) {
1351 		case ENCODER_OBJECT_ID_TRAVIS:
1352 		case ENCODER_OBJECT_ID_NUTMEG:
1353 			return amdgpu_encoder->encoder_id;
1354 		default:
1355 			break;
1356 		}
1357 	}
1358 
1359 	return ENCODER_OBJECT_ID_NONE;
1360 }
1361 
1362 static bool amdgpu_connector_encoder_is_hbr2(struct drm_connector *connector)
1363 {
1364 	struct drm_encoder *encoder;
1365 	struct amdgpu_encoder *amdgpu_encoder;
1366 	bool found = false;
1367 
1368 	drm_connector_for_each_possible_encoder(connector, encoder) {
1369 		amdgpu_encoder = to_amdgpu_encoder(encoder);
1370 		if (amdgpu_encoder->caps & ATOM_ENCODER_CAP_RECORD_HBR2)
1371 			found = true;
1372 	}
1373 
1374 	return found;
1375 }
1376 
1377 bool amdgpu_connector_is_dp12_capable(struct drm_connector *connector)
1378 {
1379 	struct drm_device *dev = connector->dev;
1380 	struct amdgpu_device *adev = drm_to_adev(dev);
1381 
1382 	if ((adev->clock.default_dispclk >= 53900) &&
1383 	    amdgpu_connector_encoder_is_hbr2(connector)) {
1384 		return true;
1385 	}
1386 
1387 	return false;
1388 }
1389 
1390 static enum drm_connector_status
1391 amdgpu_connector_dp_detect(struct drm_connector *connector, bool force)
1392 {
1393 	struct drm_device *dev = connector->dev;
1394 	struct amdgpu_device *adev = drm_to_adev(dev);
1395 	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1396 	enum drm_connector_status ret = connector_status_disconnected;
1397 	struct amdgpu_connector_atom_dig *amdgpu_dig_connector = amdgpu_connector->con_priv;
1398 	struct drm_encoder *encoder = amdgpu_connector_best_single_encoder(connector);
1399 	int r;
1400 
1401 	if (!drm_kms_helper_is_poll_worker()) {
1402 		r = pm_runtime_get_sync(connector->dev->dev);
1403 		if (r < 0) {
1404 			pm_runtime_put_autosuspend(connector->dev->dev);
1405 			return connector_status_disconnected;
1406 		}
1407 	}
1408 
1409 	if (!force && amdgpu_connector_check_hpd_status_unchanged(connector)) {
1410 		ret = connector->status;
1411 		goto out;
1412 	}
1413 
1414 	drm_edid_free(amdgpu_connector->edid);
1415 
1416 	if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) ||
1417 	    (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)) {
1418 		if (encoder) {
1419 			struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
1420 			struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
1421 
1422 			/* check if panel is valid */
1423 			if (native_mode->hdisplay >= 320 && native_mode->vdisplay >= 240)
1424 				ret = connector_status_connected;
1425 		}
1426 		/* eDP is always DP */
1427 		amdgpu_dig_connector->dp_sink_type = CONNECTOR_OBJECT_ID_DISPLAYPORT;
1428 		if (!amdgpu_dig_connector->edp_on)
1429 			amdgpu_atombios_encoder_set_edp_panel_power(connector,
1430 							     ATOM_TRANSMITTER_ACTION_POWER_ON);
1431 		if (!amdgpu_atombios_dp_get_dpcd(amdgpu_connector))
1432 			ret = connector_status_connected;
1433 		if (!amdgpu_dig_connector->edp_on)
1434 			amdgpu_atombios_encoder_set_edp_panel_power(connector,
1435 							     ATOM_TRANSMITTER_ACTION_POWER_OFF);
1436 	} else if (amdgpu_connector_encoder_get_dp_bridge_encoder_id(connector) !=
1437 		   ENCODER_OBJECT_ID_NONE) {
1438 		/* DP bridges are always DP */
1439 		amdgpu_dig_connector->dp_sink_type = CONNECTOR_OBJECT_ID_DISPLAYPORT;
1440 		/* get the DPCD from the bridge */
1441 		amdgpu_atombios_dp_get_dpcd(amdgpu_connector);
1442 
1443 		if (encoder) {
1444 			/* setup ddc on the bridge */
1445 			amdgpu_atombios_encoder_setup_ext_encoder_ddc(encoder);
1446 			/* bridge chips are always aux */
1447 			/* try DDC */
1448 			if (amdgpu_display_ddc_probe(amdgpu_connector, true))
1449 				ret = connector_status_connected;
1450 			else if (amdgpu_connector->dac_load_detect) { /* try load detection */
1451 				const struct drm_encoder_helper_funcs *encoder_funcs = encoder->helper_private;
1452 
1453 				ret = encoder_funcs->detect(encoder, connector);
1454 			}
1455 		}
1456 	} else {
1457 		amdgpu_dig_connector->dp_sink_type =
1458 			amdgpu_atombios_dp_get_sinktype(amdgpu_connector);
1459 		if (amdgpu_display_hpd_sense(adev, amdgpu_connector->hpd.hpd)) {
1460 			ret = connector_status_connected;
1461 			if (amdgpu_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT)
1462 				amdgpu_atombios_dp_get_dpcd(amdgpu_connector);
1463 		} else {
1464 			if (amdgpu_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) {
1465 				if (!amdgpu_atombios_dp_get_dpcd(amdgpu_connector))
1466 					ret = connector_status_connected;
1467 			} else {
1468 				/* try non-aux ddc (DP to DVI/HDMI/etc. adapter) */
1469 				if (amdgpu_display_ddc_probe(amdgpu_connector,
1470 							     false))
1471 					ret = connector_status_connected;
1472 			}
1473 		}
1474 	}
1475 
1476 	amdgpu_connector_update_scratch_regs(connector, ret);
1477 out:
1478 	if (!drm_kms_helper_is_poll_worker())
1479 		pm_runtime_put_autosuspend(connector->dev->dev);
1480 
1481 	if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
1482 	    connector->connector_type == DRM_MODE_CONNECTOR_eDP)
1483 		drm_dp_set_subconnector_property(&amdgpu_connector->base,
1484 						 ret,
1485 						 amdgpu_dig_connector->dpcd,
1486 						 amdgpu_dig_connector->downstream_ports);
1487 	return ret;
1488 }
1489 
1490 static enum drm_mode_status amdgpu_connector_dp_mode_valid(struct drm_connector *connector,
1491 					   const struct drm_display_mode *mode)
1492 {
1493 	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1494 	struct amdgpu_connector_atom_dig *amdgpu_dig_connector = amdgpu_connector->con_priv;
1495 
1496 	/* XXX check mode bandwidth */
1497 
1498 	if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) ||
1499 	    (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)) {
1500 		struct drm_encoder *encoder = amdgpu_connector_best_single_encoder(connector);
1501 
1502 		if ((mode->hdisplay < 320) || (mode->vdisplay < 240))
1503 			return MODE_PANEL;
1504 
1505 		if (encoder) {
1506 			struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
1507 			struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
1508 
1509 			/* AVIVO hardware supports downscaling modes larger than the panel
1510 			 * to the panel size, but I'm not sure this is desirable.
1511 			 */
1512 			if ((mode->hdisplay > native_mode->hdisplay) ||
1513 			    (mode->vdisplay > native_mode->vdisplay))
1514 				return MODE_PANEL;
1515 
1516 			/* if scaling is disabled, block non-native modes */
1517 			if (amdgpu_encoder->rmx_type == RMX_OFF) {
1518 				if ((mode->hdisplay != native_mode->hdisplay) ||
1519 				    (mode->vdisplay != native_mode->vdisplay))
1520 					return MODE_PANEL;
1521 			}
1522 		}
1523 		return MODE_OK;
1524 	} else {
1525 		if ((amdgpu_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) ||
1526 		    (amdgpu_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_eDP)) {
1527 			return amdgpu_atombios_dp_mode_valid_helper(connector, mode);
1528 		} else {
1529 			if (connector->display_info.is_hdmi) {
1530 				/* HDMI 1.3+ supports max clock of 340 Mhz */
1531 				if (mode->clock > 340000)
1532 					return MODE_CLOCK_HIGH;
1533 			} else {
1534 				if (mode->clock > 165000)
1535 					return MODE_CLOCK_HIGH;
1536 			}
1537 		}
1538 	}
1539 
1540 	return MODE_OK;
1541 }
1542 
1543 static int
1544 amdgpu_connector_late_register(struct drm_connector *connector)
1545 {
1546 	struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1547 	int r = 0;
1548 
1549 	if (amdgpu_connector->ddc_bus->has_aux) {
1550 		amdgpu_connector->ddc_bus->aux.dev = amdgpu_connector->base.kdev;
1551 		r = drm_dp_aux_register(&amdgpu_connector->ddc_bus->aux);
1552 	}
1553 
1554 	return r;
1555 }
1556 
1557 static const struct drm_connector_helper_funcs amdgpu_connector_dp_helper_funcs = {
1558 	.get_modes = amdgpu_connector_dp_get_modes,
1559 	.mode_valid = amdgpu_connector_dp_mode_valid,
1560 	.best_encoder = amdgpu_connector_dvi_encoder,
1561 };
1562 
1563 static const struct drm_connector_funcs amdgpu_connector_dp_funcs = {
1564 	.dpms = drm_helper_connector_dpms,
1565 	.detect = amdgpu_connector_dp_detect,
1566 	.fill_modes = drm_helper_probe_single_connector_modes,
1567 	.set_property = amdgpu_connector_set_property,
1568 	.early_unregister = amdgpu_connector_unregister,
1569 	.destroy = amdgpu_connector_destroy,
1570 	.force = amdgpu_connector_dvi_force,
1571 	.late_register = amdgpu_connector_late_register,
1572 };
1573 
1574 static const struct drm_connector_funcs amdgpu_connector_edp_funcs = {
1575 	.dpms = drm_helper_connector_dpms,
1576 	.detect = amdgpu_connector_dp_detect,
1577 	.fill_modes = drm_helper_probe_single_connector_modes,
1578 	.set_property = amdgpu_connector_set_lcd_property,
1579 	.early_unregister = amdgpu_connector_unregister,
1580 	.destroy = amdgpu_connector_destroy,
1581 	.force = amdgpu_connector_dvi_force,
1582 	.late_register = amdgpu_connector_late_register,
1583 };
1584 
1585 void
1586 amdgpu_connector_add(struct amdgpu_device *adev,
1587 		      uint32_t connector_id,
1588 		      uint32_t supported_device,
1589 		      int connector_type,
1590 		      struct amdgpu_i2c_bus_rec *i2c_bus,
1591 		      uint16_t connector_object_id,
1592 		      struct amdgpu_hpd *hpd,
1593 		      struct amdgpu_router *router)
1594 {
1595 	struct drm_device *dev = adev_to_drm(adev);
1596 	struct drm_connector *connector;
1597 	struct drm_connector_list_iter iter;
1598 	struct amdgpu_connector *amdgpu_connector;
1599 	struct amdgpu_connector_atom_dig *amdgpu_dig_connector;
1600 	struct drm_encoder *encoder;
1601 	struct amdgpu_encoder *amdgpu_encoder;
1602 	struct i2c_adapter *ddc = NULL;
1603 	uint32_t subpixel_order = SubPixelNone;
1604 	bool shared_ddc = false;
1605 	bool is_dp_bridge = false;
1606 	bool has_aux = false;
1607 
1608 	if (connector_type == DRM_MODE_CONNECTOR_Unknown)
1609 		return;
1610 
1611 	/* see if we already added it */
1612 	drm_connector_list_iter_begin(dev, &iter);
1613 	drm_for_each_connector_iter(connector, &iter) {
1614 		amdgpu_connector = to_amdgpu_connector(connector);
1615 		if (amdgpu_connector->connector_id == connector_id) {
1616 			amdgpu_connector->devices |= supported_device;
1617 			drm_connector_list_iter_end(&iter);
1618 			return;
1619 		}
1620 		if (amdgpu_connector->ddc_bus && i2c_bus->valid) {
1621 			if (amdgpu_connector->ddc_bus->rec.i2c_id == i2c_bus->i2c_id) {
1622 				amdgpu_connector->shared_ddc = true;
1623 				shared_ddc = true;
1624 			}
1625 			if (amdgpu_connector->router_bus && router->ddc_valid &&
1626 			    (amdgpu_connector->router.router_id == router->router_id)) {
1627 				amdgpu_connector->shared_ddc = false;
1628 				shared_ddc = false;
1629 			}
1630 		}
1631 	}
1632 	drm_connector_list_iter_end(&iter);
1633 
1634 	/* check if it's a dp bridge */
1635 	list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
1636 		amdgpu_encoder = to_amdgpu_encoder(encoder);
1637 		if (amdgpu_encoder->devices & supported_device) {
1638 			switch (amdgpu_encoder->encoder_id) {
1639 			case ENCODER_OBJECT_ID_TRAVIS:
1640 			case ENCODER_OBJECT_ID_NUTMEG:
1641 				is_dp_bridge = true;
1642 				break;
1643 			default:
1644 				break;
1645 			}
1646 		}
1647 	}
1648 
1649 	amdgpu_connector = kzalloc_obj(struct amdgpu_connector);
1650 	if (!amdgpu_connector)
1651 		return;
1652 
1653 	connector = &amdgpu_connector->base;
1654 
1655 	amdgpu_connector->connector_id = connector_id;
1656 	amdgpu_connector->devices = supported_device;
1657 	amdgpu_connector->shared_ddc = shared_ddc;
1658 	amdgpu_connector->connector_object_id = connector_object_id;
1659 	amdgpu_connector->hpd = *hpd;
1660 
1661 	amdgpu_connector->router = *router;
1662 	if (router->ddc_valid || router->cd_valid) {
1663 		amdgpu_connector->router_bus = amdgpu_i2c_lookup(adev, &router->i2c_info);
1664 		if (!amdgpu_connector->router_bus)
1665 			drm_err(adev_to_drm(adev),
1666 				"Failed to assign router i2c bus! Check dmesg for i2c errors.\n");
1667 	}
1668 
1669 	if (is_dp_bridge) {
1670 		amdgpu_dig_connector = kzalloc_obj(struct amdgpu_connector_atom_dig);
1671 		if (!amdgpu_dig_connector)
1672 			goto failed;
1673 		amdgpu_connector->con_priv = amdgpu_dig_connector;
1674 		if (i2c_bus->valid) {
1675 			amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1676 			if (amdgpu_connector->ddc_bus) {
1677 				has_aux = true;
1678 				ddc = &amdgpu_connector->ddc_bus->adapter;
1679 			} else {
1680 				drm_err(adev_to_drm(adev),
1681 					"DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1682 			}
1683 		}
1684 		switch (connector_type) {
1685 		case DRM_MODE_CONNECTOR_VGA:
1686 		case DRM_MODE_CONNECTOR_DVIA:
1687 		default:
1688 			drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1689 						    &amdgpu_connector_dp_funcs,
1690 						    connector_type,
1691 						    ddc);
1692 			drm_connector_helper_add(&amdgpu_connector->base,
1693 						 &amdgpu_connector_dp_helper_funcs);
1694 			connector->interlace_allowed = true;
1695 			connector->doublescan_allowed = true;
1696 			amdgpu_connector->dac_load_detect = true;
1697 			drm_object_attach_property(&amdgpu_connector->base.base,
1698 						      adev->mode_info.load_detect_property,
1699 						      1);
1700 			drm_object_attach_property(&amdgpu_connector->base.base,
1701 						   dev->mode_config.scaling_mode_property,
1702 						   DRM_MODE_SCALE_NONE);
1703 			break;
1704 		case DRM_MODE_CONNECTOR_DVII:
1705 		case DRM_MODE_CONNECTOR_DVID:
1706 		case DRM_MODE_CONNECTOR_HDMIA:
1707 		case DRM_MODE_CONNECTOR_HDMIB:
1708 		case DRM_MODE_CONNECTOR_DisplayPort:
1709 			drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1710 						    &amdgpu_connector_dp_funcs,
1711 						    connector_type,
1712 						    ddc);
1713 			drm_connector_helper_add(&amdgpu_connector->base,
1714 						 &amdgpu_connector_dp_helper_funcs);
1715 			drm_object_attach_property(&amdgpu_connector->base.base,
1716 						      adev->mode_info.underscan_property,
1717 						      UNDERSCAN_OFF);
1718 			drm_object_attach_property(&amdgpu_connector->base.base,
1719 						      adev->mode_info.underscan_hborder_property,
1720 						      0);
1721 			drm_object_attach_property(&amdgpu_connector->base.base,
1722 						      adev->mode_info.underscan_vborder_property,
1723 						      0);
1724 
1725 			drm_object_attach_property(&amdgpu_connector->base.base,
1726 						   dev->mode_config.scaling_mode_property,
1727 						   DRM_MODE_SCALE_NONE);
1728 
1729 			drm_object_attach_property(&amdgpu_connector->base.base,
1730 						   adev->mode_info.dither_property,
1731 						   AMDGPU_FMT_DITHER_DISABLE);
1732 
1733 			if (amdgpu_audio != 0) {
1734 				drm_object_attach_property(&amdgpu_connector->base.base,
1735 							   adev->mode_info.audio_property,
1736 							   AMDGPU_AUDIO_AUTO);
1737 				amdgpu_connector->audio = AMDGPU_AUDIO_AUTO;
1738 			}
1739 
1740 			subpixel_order = SubPixelHorizontalRGB;
1741 			connector->interlace_allowed = true;
1742 			if (connector_type == DRM_MODE_CONNECTOR_HDMIB)
1743 				connector->doublescan_allowed = true;
1744 			else
1745 				connector->doublescan_allowed = false;
1746 			if (connector_type == DRM_MODE_CONNECTOR_DVII) {
1747 				amdgpu_connector->dac_load_detect = true;
1748 				drm_object_attach_property(&amdgpu_connector->base.base,
1749 							      adev->mode_info.load_detect_property,
1750 							      1);
1751 			}
1752 			break;
1753 		case DRM_MODE_CONNECTOR_LVDS:
1754 		case DRM_MODE_CONNECTOR_eDP:
1755 			drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1756 						    &amdgpu_connector_edp_funcs,
1757 						    connector_type,
1758 						    ddc);
1759 			drm_connector_helper_add(&amdgpu_connector->base,
1760 						 &amdgpu_connector_dp_helper_funcs);
1761 			drm_object_attach_property(&amdgpu_connector->base.base,
1762 						      dev->mode_config.scaling_mode_property,
1763 						      DRM_MODE_SCALE_FULLSCREEN);
1764 			subpixel_order = SubPixelHorizontalRGB;
1765 			connector->interlace_allowed = false;
1766 			connector->doublescan_allowed = false;
1767 			break;
1768 		}
1769 	} else {
1770 		switch (connector_type) {
1771 		case DRM_MODE_CONNECTOR_VGA:
1772 			if (i2c_bus->valid) {
1773 				amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1774 				if (!amdgpu_connector->ddc_bus)
1775 					drm_err(adev_to_drm(adev),
1776 						"VGA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1777 				else
1778 					ddc = &amdgpu_connector->ddc_bus->adapter;
1779 			}
1780 			drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1781 						    &amdgpu_connector_vga_funcs,
1782 						    connector_type,
1783 						    ddc);
1784 			drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_vga_helper_funcs);
1785 			amdgpu_connector->dac_load_detect = true;
1786 			drm_object_attach_property(&amdgpu_connector->base.base,
1787 						      adev->mode_info.load_detect_property,
1788 						      1);
1789 			drm_object_attach_property(&amdgpu_connector->base.base,
1790 						   dev->mode_config.scaling_mode_property,
1791 						   DRM_MODE_SCALE_NONE);
1792 			/* no HPD on analog connectors */
1793 			amdgpu_connector->hpd.hpd = AMDGPU_HPD_NONE;
1794 			connector->interlace_allowed = true;
1795 			connector->doublescan_allowed = true;
1796 			break;
1797 		case DRM_MODE_CONNECTOR_DVIA:
1798 			if (i2c_bus->valid) {
1799 				amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1800 				if (!amdgpu_connector->ddc_bus)
1801 					drm_err(adev_to_drm(adev),
1802 						"DVIA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1803 				else
1804 					ddc = &amdgpu_connector->ddc_bus->adapter;
1805 			}
1806 			drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1807 						    &amdgpu_connector_vga_funcs,
1808 						    connector_type,
1809 						    ddc);
1810 			drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_vga_helper_funcs);
1811 			amdgpu_connector->dac_load_detect = true;
1812 			drm_object_attach_property(&amdgpu_connector->base.base,
1813 						      adev->mode_info.load_detect_property,
1814 						      1);
1815 			drm_object_attach_property(&amdgpu_connector->base.base,
1816 						   dev->mode_config.scaling_mode_property,
1817 						   DRM_MODE_SCALE_NONE);
1818 			/* no HPD on analog connectors */
1819 			amdgpu_connector->hpd.hpd = AMDGPU_HPD_NONE;
1820 			connector->interlace_allowed = true;
1821 			connector->doublescan_allowed = true;
1822 			break;
1823 		case DRM_MODE_CONNECTOR_DVII:
1824 		case DRM_MODE_CONNECTOR_DVID:
1825 			amdgpu_dig_connector = kzalloc_obj(struct amdgpu_connector_atom_dig);
1826 			if (!amdgpu_dig_connector)
1827 				goto failed;
1828 			amdgpu_connector->con_priv = amdgpu_dig_connector;
1829 			if (i2c_bus->valid) {
1830 				amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1831 				if (!amdgpu_connector->ddc_bus)
1832 					drm_err(adev_to_drm(adev),
1833 						"DVI: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1834 				else
1835 					ddc = &amdgpu_connector->ddc_bus->adapter;
1836 			}
1837 			drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1838 						    &amdgpu_connector_dvi_funcs,
1839 						    connector_type,
1840 						    ddc);
1841 			drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_dvi_helper_funcs);
1842 			subpixel_order = SubPixelHorizontalRGB;
1843 			drm_object_attach_property(&amdgpu_connector->base.base,
1844 						      adev->mode_info.coherent_mode_property,
1845 						      1);
1846 			drm_object_attach_property(&amdgpu_connector->base.base,
1847 						   adev->mode_info.underscan_property,
1848 						   UNDERSCAN_OFF);
1849 			drm_object_attach_property(&amdgpu_connector->base.base,
1850 						   adev->mode_info.underscan_hborder_property,
1851 						   0);
1852 			drm_object_attach_property(&amdgpu_connector->base.base,
1853 						   adev->mode_info.underscan_vborder_property,
1854 						   0);
1855 			drm_object_attach_property(&amdgpu_connector->base.base,
1856 						   dev->mode_config.scaling_mode_property,
1857 						   DRM_MODE_SCALE_NONE);
1858 
1859 			if (amdgpu_audio != 0) {
1860 				drm_object_attach_property(&amdgpu_connector->base.base,
1861 							   adev->mode_info.audio_property,
1862 							   AMDGPU_AUDIO_AUTO);
1863 				amdgpu_connector->audio = AMDGPU_AUDIO_AUTO;
1864 			}
1865 			drm_object_attach_property(&amdgpu_connector->base.base,
1866 						   adev->mode_info.dither_property,
1867 						   AMDGPU_FMT_DITHER_DISABLE);
1868 			if (connector_type == DRM_MODE_CONNECTOR_DVII) {
1869 				amdgpu_connector->dac_load_detect = true;
1870 				drm_object_attach_property(&amdgpu_connector->base.base,
1871 							   adev->mode_info.load_detect_property,
1872 							   1);
1873 			}
1874 			connector->interlace_allowed = true;
1875 			if (connector_type == DRM_MODE_CONNECTOR_DVII)
1876 				connector->doublescan_allowed = true;
1877 			else
1878 				connector->doublescan_allowed = false;
1879 			break;
1880 		case DRM_MODE_CONNECTOR_HDMIA:
1881 		case DRM_MODE_CONNECTOR_HDMIB:
1882 			amdgpu_dig_connector = kzalloc_obj(struct amdgpu_connector_atom_dig);
1883 			if (!amdgpu_dig_connector)
1884 				goto failed;
1885 			amdgpu_connector->con_priv = amdgpu_dig_connector;
1886 			if (i2c_bus->valid) {
1887 				amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1888 				if (!amdgpu_connector->ddc_bus)
1889 					drm_err(adev_to_drm(adev),
1890 						"HDMI: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1891 				else
1892 					ddc = &amdgpu_connector->ddc_bus->adapter;
1893 			}
1894 			drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1895 						    &amdgpu_connector_dvi_funcs,
1896 						    connector_type,
1897 						    ddc);
1898 			drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_dvi_helper_funcs);
1899 			drm_object_attach_property(&amdgpu_connector->base.base,
1900 						      adev->mode_info.coherent_mode_property,
1901 						      1);
1902 			drm_object_attach_property(&amdgpu_connector->base.base,
1903 						   adev->mode_info.underscan_property,
1904 						   UNDERSCAN_OFF);
1905 			drm_object_attach_property(&amdgpu_connector->base.base,
1906 						   adev->mode_info.underscan_hborder_property,
1907 						   0);
1908 			drm_object_attach_property(&amdgpu_connector->base.base,
1909 						   adev->mode_info.underscan_vborder_property,
1910 						   0);
1911 			drm_object_attach_property(&amdgpu_connector->base.base,
1912 						   dev->mode_config.scaling_mode_property,
1913 						   DRM_MODE_SCALE_NONE);
1914 			if (amdgpu_audio != 0) {
1915 				drm_object_attach_property(&amdgpu_connector->base.base,
1916 							   adev->mode_info.audio_property,
1917 							   AMDGPU_AUDIO_AUTO);
1918 				amdgpu_connector->audio = AMDGPU_AUDIO_AUTO;
1919 			}
1920 			drm_object_attach_property(&amdgpu_connector->base.base,
1921 						   adev->mode_info.dither_property,
1922 						   AMDGPU_FMT_DITHER_DISABLE);
1923 			subpixel_order = SubPixelHorizontalRGB;
1924 			connector->interlace_allowed = true;
1925 			if (connector_type == DRM_MODE_CONNECTOR_HDMIB)
1926 				connector->doublescan_allowed = true;
1927 			else
1928 				connector->doublescan_allowed = false;
1929 			break;
1930 		case DRM_MODE_CONNECTOR_DisplayPort:
1931 			amdgpu_dig_connector = kzalloc_obj(struct amdgpu_connector_atom_dig);
1932 			if (!amdgpu_dig_connector)
1933 				goto failed;
1934 			amdgpu_connector->con_priv = amdgpu_dig_connector;
1935 			if (i2c_bus->valid) {
1936 				amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1937 				if (amdgpu_connector->ddc_bus) {
1938 					has_aux = true;
1939 					ddc = &amdgpu_connector->ddc_bus->adapter;
1940 				} else {
1941 					drm_err(adev_to_drm(adev),
1942 						"DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1943 				}
1944 			}
1945 			drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1946 						    &amdgpu_connector_dp_funcs,
1947 						    connector_type,
1948 						    ddc);
1949 			drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_dp_helper_funcs);
1950 			subpixel_order = SubPixelHorizontalRGB;
1951 			drm_object_attach_property(&amdgpu_connector->base.base,
1952 						      adev->mode_info.coherent_mode_property,
1953 						      1);
1954 			drm_object_attach_property(&amdgpu_connector->base.base,
1955 						   adev->mode_info.underscan_property,
1956 						   UNDERSCAN_OFF);
1957 			drm_object_attach_property(&amdgpu_connector->base.base,
1958 						   adev->mode_info.underscan_hborder_property,
1959 						   0);
1960 			drm_object_attach_property(&amdgpu_connector->base.base,
1961 						   adev->mode_info.underscan_vborder_property,
1962 						   0);
1963 			drm_object_attach_property(&amdgpu_connector->base.base,
1964 						   dev->mode_config.scaling_mode_property,
1965 						   DRM_MODE_SCALE_NONE);
1966 			if (amdgpu_audio != 0) {
1967 				drm_object_attach_property(&amdgpu_connector->base.base,
1968 							   adev->mode_info.audio_property,
1969 							   AMDGPU_AUDIO_AUTO);
1970 				amdgpu_connector->audio = AMDGPU_AUDIO_AUTO;
1971 			}
1972 			drm_object_attach_property(&amdgpu_connector->base.base,
1973 						   adev->mode_info.dither_property,
1974 						   AMDGPU_FMT_DITHER_DISABLE);
1975 			connector->interlace_allowed = true;
1976 			/* in theory with a DP to VGA converter... */
1977 			connector->doublescan_allowed = false;
1978 			break;
1979 		case DRM_MODE_CONNECTOR_eDP:
1980 			amdgpu_dig_connector = kzalloc_obj(struct amdgpu_connector_atom_dig);
1981 			if (!amdgpu_dig_connector)
1982 				goto failed;
1983 			amdgpu_connector->con_priv = amdgpu_dig_connector;
1984 			if (i2c_bus->valid) {
1985 				amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1986 				if (amdgpu_connector->ddc_bus) {
1987 					has_aux = true;
1988 					ddc = &amdgpu_connector->ddc_bus->adapter;
1989 				} else {
1990 					drm_err(adev_to_drm(adev),
1991 						"eDP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1992 				}
1993 			}
1994 			drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1995 						    &amdgpu_connector_edp_funcs,
1996 						    connector_type,
1997 						    ddc);
1998 			drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_dp_helper_funcs);
1999 			drm_object_attach_property(&amdgpu_connector->base.base,
2000 						      dev->mode_config.scaling_mode_property,
2001 						      DRM_MODE_SCALE_FULLSCREEN);
2002 			subpixel_order = SubPixelHorizontalRGB;
2003 			connector->interlace_allowed = false;
2004 			connector->doublescan_allowed = false;
2005 			break;
2006 		case DRM_MODE_CONNECTOR_LVDS:
2007 			amdgpu_dig_connector = kzalloc_obj(struct amdgpu_connector_atom_dig);
2008 			if (!amdgpu_dig_connector)
2009 				goto failed;
2010 			amdgpu_connector->con_priv = amdgpu_dig_connector;
2011 			if (i2c_bus->valid) {
2012 				amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
2013 				if (!amdgpu_connector->ddc_bus)
2014 					drm_err(adev_to_drm(adev),
2015 						"LVDS: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
2016 				else
2017 					ddc = &amdgpu_connector->ddc_bus->adapter;
2018 			}
2019 			drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
2020 						    &amdgpu_connector_lvds_funcs,
2021 						    connector_type,
2022 						    ddc);
2023 			drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_lvds_helper_funcs);
2024 			drm_object_attach_property(&amdgpu_connector->base.base,
2025 						      dev->mode_config.scaling_mode_property,
2026 						      DRM_MODE_SCALE_FULLSCREEN);
2027 			subpixel_order = SubPixelHorizontalRGB;
2028 			connector->interlace_allowed = false;
2029 			connector->doublescan_allowed = false;
2030 			break;
2031 		}
2032 	}
2033 
2034 	if (amdgpu_connector->hpd.hpd == AMDGPU_HPD_NONE) {
2035 		if (i2c_bus->valid) {
2036 			connector->polled = DRM_CONNECTOR_POLL_CONNECT |
2037 						DRM_CONNECTOR_POLL_DISCONNECT;
2038 		}
2039 	} else
2040 		connector->polled = DRM_CONNECTOR_POLL_HPD;
2041 
2042 	connector->display_info.subpixel_order = subpixel_order;
2043 
2044 	if (has_aux)
2045 		amdgpu_atombios_dp_aux_init(amdgpu_connector);
2046 
2047 	if (connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
2048 	    connector_type == DRM_MODE_CONNECTOR_eDP) {
2049 		drm_connector_attach_dp_subconnector_property(&amdgpu_connector->base);
2050 	}
2051 
2052 	return;
2053 
2054 failed:
2055 	drm_connector_cleanup(connector);
2056 	kfree(connector);
2057 }
2058