Lines Matching +full:oe +full:- +full:extra +full:- +full:delay
2 # SPDX-License-Identifier: GPL-2.0
7 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
8 # (c) 2010-2018 Joe Perches <joe@perches.com>
69 my $docsfile = "$D/../Documentation/dev-tools/checkpatch.rst";
72 my $allow_c99_comments = 1; # Can be overridden by --ignore C99_COMMENT_TOLERANCE
74 my $git_command ='export LANGUAGE=en_US.UTF-8; git';
88 -q, --quiet quiet
89 -v, --verbose verbose mode
90 --no-tree run without a kernel tree
91 --no-signoff do not check for 'Signed-off-by' line
92 --no-fixes-tag do not check for 'Fixes:' tag
93 --patch treat FILE as patchfile (default)
94 --emacs emacs compile window format
95 --terse one line per report
96 --showfile emit diffed file position, not input file position
97 -g, --git treat FILE as a single commit or git revision range
105 <rev>-<count>
107 -f, --file treat FILE as regular source file
108 --subjective, --strict enable more subjective tests
109 --list-types list the possible message types
110 --types TYPE(,TYPE2...) show only these comma separated message types
111 --ignore TYPE(,TYPE2...) ignore various comma separated message types
112 --show-types show the specific message type in the output
113 --max-line-length=n set the maximum line length, (default $max_line_length)
115 requires --strict for use with --file
116 --min-conf-desc-length=n set the minimum description length for config symbols
118 --tab-size=n set the number of spaces for tab (default $tabsize)
119 --root=PATH PATH to the kernel tree root
120 --no-summary suppress the per-file summary
121 --mailback only produce a report in case of warnings/errors
122 --summary-file include the filename in summary
123 --debug KEY=[0|1] turn on/off debugging of KEY, where KEY is one of
126 --test-only=WORD report only warnings/errors containing WORD
128 --fix EXPERIMENTAL - may create horrible results
129 If correctable single-line errors exist, create
130 "<inputfile>.EXPERIMENTAL-checkpatch-fixes"
133 --fix-inplace EXPERIMENTAL - may create horrible results
134 Is the same as --fix, but overwrites the input
136 --ignore-perl-version override checking of perl version. expect
138 --codespell Use the codespell dictionary for spelling/typos
140 --codespellfile Use this codespell dictionary
141 --typedefsfile Read additional types from this file
142 --color[=WHEN] Use colors 'always', 'never', or only when output
144 --kconfig-prefix=WORD use WORD as a prefix for Kconfig symbols (default
146 -h, --help, --version display this help and exit
148 When FILE is - read standard input.
155 do {} while (0) advice is over-stated in a few situations:
158 file-scope, where C disallows code (it must be in functions). See
162 like DECLARE_PER_CPU. These might just compile with a do-while-0
167 expression. These cannot do-while, and need a ({}) wrapper.
241 if (-f $conf) {
307 # Prevent --color by itself from consuming other arguments
309 if ($_ eq "--color" || $_ eq "-color") {
310 $_ = "--color=$color";
319 'fixes-tag!' => \$chk_fixes_tag,
330 'show-types!' => \$show_types,
331 'list-types!' => \$list_types,
332 'max-line-length=i' => \$max_line_length,
333 'min-conf-desc-length=i' => \$min_conf_desc_length,
334 'tab-size=i' => \$tabsize,
338 'summary-file!' => \$summary_file,
340 'fix-inplace!' => \$fix_inplace,
341 'ignore-perl-version!' => \$ignore_perl_version,
343 'test-only=s' => \$tst_only,
348 'no-color' => \$color, #keep old behaviors of -nocolor
349 'nocolor' => \$color, #keep old behaviors of -nocolor
350 'kconfig-prefix=s' => \${CONFIG_},
358 } elsif (!(-f $codespellfile)) {
371 my $codespell_dict = `python3 -c "$python_codespell_dict" 2> /dev/null`;
372 $codespellfile = $codespell_dict if (-f $codespell_dict);
376 # $help is 1 if either -h, --help or --version is passed as option - exitcode: 0
377 # $help is 2 if invalid option is passed - exitcode: 1
378 help($help - 1) if ($help);
380 die "$P: --git cannot be used with --file or --fix\n" if ($git && ($file || $fix));
381 die "$P: --verbose cannot be used with --terse\n" if ($verbose && $terse);
390 $color = (-t STDOUT);
410 #if no filenames are given, push '-' to read patch from stdin
412 push(@ARGV, '-');
415 # skip TAB size 1 to avoid additional checks on $tabsize - 1
426 $word =~ tr/[a-z]/[A-Z]/;
431 $hashRef->{$word}++;
470 die "$P: $root: --root does not point at a valid tree\n";
482 print "Must be run from the top-level dir. of a kernel tree\n";
490 [A-Za-z_][A-Za-z\d_]*
491 (?:\s*\#\#\s*[A-Za-z_][A-Za-z\d_]*)*
546 our $Member = qr{->$Ident|\.$Ident|\[[^]]*\]};
551 our $Hex = qr{(?i)0x[0-9a-f]+$Int_type?};
552 our $Int = qr{[0-9]+$Int_type?};
553 our $Octal = qr{0[0-7]+$Int_type?};
555 our $Float_hex = qr{(?i)0x[0-9a-f]+p-?[0-9]+[fl]?};
556 our $Float_dec = qr{(?i)(?:[0-9]+\.[0-9]*|[0-9]*\.[0-9]+)(?:e-?[0-9]+)?[fl]?};
557 our $Float_int = qr{(?i)[0-9]+e-?[0-9]+[fl]?};
560 our $Assignment = qr{\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=};
561 our $Compare = qr{<=|>=|==|!=|<|(?<!-)>};
562 our $Arithmetic = qr{\+|-|\*|\/|%};
565 =>|->|<<|>>|<|>|!|~|
566 &&|\|\||,|\^|\+\+|--|&|\||$Arithmetic
581 [\xC2-\xDF][\x80-\xBF] # non-overlong 2-byte
582 | \xE0[\xA0-\xBF][\x80-\xBF] # excluding overlongs
583 | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2} # straight 3-byte
584 | \xED[\x80-\x9F][\x80-\xBF] # excluding surrogates
585 | \xF0[\x90-\xBF][\x80-\xBF]{2} # planes 1-3
586 | [\xF1-\xF3][\x80-\xBF]{3} # planes 4-15
587 | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16
591 [\x09\x0A\x0D\x20-\x7E] # ASCII
618 …(?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|co…
622 MODULE_[A-Z_]+|
637 Signed-off-by:|
638 Co-developed-by:|
639 Acked-by:|
640 Tested-by:|
641 Reviewed-by:|
642 Reported-by:|
643 Suggested-by:|
665 [=-]*> |
666 <[=-]* |
689 our $dev_id_types = qr{\b[a-z]\w*_device_id\b};
699 for my $i (0 .. ($len-1)) {
711 $str1 =~ s/-//g;
712 $str2 =~ s/-//g;
723 } elsif (substr($str1, $i-1, 1) eq substr($str2, $j-1, 1)) {
724 $distance[$i][$j] = $distance[$i - 1][$j - 1];
726 my $dist1 = $distance[$i][$j - 1]; #insert distance
727 my $dist2 = $distance[$i - 1][$j]; # remove
728 my $dist3 = $distance[$i - 1][$j - 1]; #replace
739 'Signed-off-by:', 'Co-developed-by:', 'Acked-by:', 'Tested-by:',
740 'Reviewed-by:', 'Reported-by:', 'Suggested-by:'
750 \Qfreedesktop.org/archives/dri-devel\E |
753 \Qmail-archive.com\E |
754 \Qmailman.alsa-project.org/pipermail\E |
842 ["IIO_DEV_ATTR_[A-Z_]+", 1],
848 my $word_pattern = '\b[A-Z]?[a-z]{2,}\b';
854 $mode_perms_search .= $entry->[0];
878 0[0-7][0-7][2367]
915 return trim($string) if ($string =~ /^\s*0[0-7]{3,3}\s*$/);
926 last if ($lastpos > 0 && ($curpos - length($omatch) != $lastpos));
966 warn "No typos will be found - file '$spelling_file': $!\n";
983 my ($suspect, $fix) = split(/->/, $line);
989 warn "No codespell typos will be found - file '$codespellfile': $!\n";
1008 print("$file: '$line' invalid - ignored\n");
1025 or warn "No structs that should be const will be found - file '$conststructsfile': $!\n";
1031 or warn "No additional types will be considered - file '$typedefsfile': $!\n";
1091 our $balanced_parens = qr/(\((?:[^\(\)]++|(?-1))*\))/;
1096 (?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,6}\s*\(|
1126 return if (!(-f $file));
1138 next if ($line !~ /(?:[A-Z][a-z]|[a-z][A-Z])/);
1139 if ($line =~ /^[ \t]*(?:#[ \t]*define|typedef\s+$Type)\s+(\w*(?:[A-Z][a-z]|[a-z][A-Z])\w*)/) {
1141 } elsif ($line =~ /^\s*$Declare\s+(\w*(?:[A-Z][a-z]|[a-z][A-Z])\w*)\s*[\(\[,;]/) {
1143 } elsif ($line =~ /^\s*(?:union|struct|enum)\s+(\w*(?:[A-Z][a-z]|[a-z][A-Z])\w*)\s*[;\{]/) {
1154 return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl"));
1157 …s{$filename} = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback…
1166 …return 1 if (!$tree || which("python3") eq "" || !(-x "$root/scripts/spdxcheck.py") || !(-e "$gitr…
1169 my $status = `cd "$root_path"; echo "$license" | scripts/spdxcheck.py -`;
1184 if (-e "$gitroot") {
1185 …my $git_last_include_commit = `${git_command} log --no-merges --pretty=format:"%h%n" -1 -- include…
1187 $camelcase_cache = ".checkpatch-camelcase.git.$git_last_include_commit";
1190 $files = `find $root/include -name "*.h"`;
1197 $camelcase_cache = ".checkpatch-camelcase.date.$last_mod_date";
1200 if ($camelcase_cache ne "" && -f $camelcase_cache) {
1212 if (-e "$gitroot") {
1213 $files = `${git_command} ls-files "include/*.h"`;
1222 unlink glob ".checkpatch-camelcase.*";
1235 return 0 if ((which("git") eq "") || !(-e "$gitroot"));
1237 my $output = `${git_command} ls-files -- $filename 2>/dev/null`;
1245 return ($id, $desc) if ((which("git") eq "") || !(-e "$gitroot"));
1247 my $output = `${git_command} log --no-color --format='%H %s' -1 $commit 2>&1`;
1258 # git rev-list --remotes | grep -i "^$1" |
1260 # git log --format='%H %s' -1 $line |
1261 # echo "commit $(cut -c 1-12,41-)"
1282 my $fixlinenr = -1;
1285 # For example, HEAD-3 means we need check 'HEAD, HEAD~1, HEAD~2'.
1286 die "$P: No git repository found\n" if ($git && !-e "$gitroot");
1292 if ($commit_expr =~ m/^(.*)-(\d+)$/) {
1293 $git_range = "-$2 $1";
1297 $git_range = "-1 $commit_expr";
1299 my $lines = `${git_command} log --no-color --no-merges --pretty=format:'%H %s' $git_range`;
1301 $line =~ /^([0-9a-fA-F]{40,40}) (.*)$/;
1321 open($FILE, '-|', "git format-patch -M --stdout -1 $filename") ||
1322 die "$P: $filename: git format-patch failed - $!\n";
1324 open($FILE, '-|', "diff -u /dev/null $filename") ||
1325 die "$P: $filename: diff failed - $!\n";
1326 } elsif ($filename eq '-') {
1330 die "$P: $filename: open failed - $!\n";
1332 if ($filename eq '-') {
1342 $vname = qq("$1") if ($filename eq '-' && $_ =~ m/^Subject:\s+(.+)/i);
1347 print '-' x length($vname) . "\n";
1349 print '-' x length($vname) . "\n";
1360 $fixlinenr = -1;
1399 if (! -e $root . '/' . $check) {
1443 # "John D. (Doe)" - Do not extract
1457 if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
1474 if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
1516 if (-e "$path/$bin") {
1528 if (-e "$path/$conf") {
1683 return substr($rawline, $-[0], $+[0] - $-[0]);
1688 my $line = $linenr - 1;
1691 my $coff = $off - 1;
1705 @stack = (['', 0]) if ($#stack == -1);
1713 next if ($lines[$line] =~ /^-/);
1714 $remain--;
1741 ($type, $level) = @{$stack[$#stack - 1]};
1757 $coff = $off + length($1) - 1;
1760 #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
1768 $level--;
1782 $level--;
1794 $level--;
1805 $remain--;
1808 my $statement = substr($blk, $soff, $off - $soff + 1);
1809 my $condition = substr($blk, $soff, $coff - $soff + 1);
1817 $line, $remain + 1, $off - $loff + 1, $level);
1874 if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) {
1884 last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s));
1895 my $start = $linenr - 1;
1904 next if ($rawlines[$line] =~ /^-/);
1905 $remain--;
1913 $level = $stack[$#stack - 1];
1921 $off--;
1926 $level--;
1975 my ($current_comment) = ($rawlines[$end_line - 1] =~ m@^\+.*(//.*$)@);
1977 ($current_comment) = ($rawlines[$end_line - 2] =~ m@^[\+ ].*(//.*$)@);
1983 ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@);
1991 my $line = $rawlines[$linenr - 1];
2015 ##print "LINE: $rawlines[$end_line - 1 ]\n";
2024 my $offset = $linenr - 1;
2030 next if (defined($line) && $line =~ /^-/);
2031 $cnt--;
2201 print "PAREN('$1') -> $type\n"
2257 } elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) {
2272 if ($1 ne '++' && $1 ne '--') {
2340 $type =~ tr/[a-z]/[A-Z]/;
2373 my @lines = split("\n", $output, -1);
2400 if ($$lineRef =~ /^\@\@ -\d+,\d+ \+(\d+),(\d+) \@\@/) {
2429 if ($line =~ /^(?:\+\+\+|\-\-\-)\s+\S+/) { #new filename
2431 } elsif ($line =~ /^\@\@ -\d+,\d+ \+\d+,\d+ \@\@/) { #new hunk
2439 fixup_current_range(\$lines[$range_last_linenr], $delta_offset--, -1);
2520 if (-f "$root/$file") {
2525 if (! -f _) {
2531 substr($prefix, -length($file)) = '';
2576 my $max_spaces_before_tab = $source_indent - 1;
2598 return -1;
2606 $pos += length($1) - 1;
2609 } elsif (index($string, '(') == -1) {
2621 for my $i (0 .. (length($line) - 1)) {
2667 my $is_binding_patch = -1;
2670 my $has_patch_separator = 0; #Found a --- line
2679 my $last_git_commit_id_linenr = -1;
2682 my $last_coalesced_string_linenr = -1;
2711 # Pre-scan the patch sanitizing the lines.
2712 # Pre-scan the patch looking for any __setup documentation.
2731 if ($1 =~ m@Documentation/admin-guide/kernel-parameters.txt$@) {
2736 if ($rawline =~ /^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
2737 $realline=$1-1;
2752 next if (defined $rawlines[$ln - 1] &&
2753 $rawlines[$ln - 1] =~ /^-/);
2754 $cnt--;
2755 #print "RAW<$rawlines[$ln - 1]>\n";
2756 last if (!defined $rawlines[$ln - 1]);
2757 if ($rawlines[$ln - 1] =~ m@(/\*|\*/)@ &&
2758 $rawlines[$ln - 1] !~ m@"[^"]*(?:/\*|\*/)[^"]*"@) {
2781 # simplify matching -- only bother with positive lines.
2787 $realcnt-- if ($line =~ /^(?:\+| |$)/);
2793 #print "-->$line\n";
2804 $fixlinenr = -1;
2811 my $rawline = $rawlines[$linenr - 1];
2816 ($line =~ /^ mode change [0-7]+ => [0-7]+ \S+\s*$/ ||
2818 $line =~ /^diff --git a\/[\w\/\.\_\-]+ b\/\S+\s*$/))) {
2824 $line =~ /^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@(.*)/) {
2828 $realline=$1-1;
2853 $realcnt-- if ($realcnt != 0);
2866 $realcnt--;
2876 if ($line =~ /^diff --git.*?(\S+)$/) {
2888 -e "$root/$p1_prefix") {
2890 "patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
2926 $is_binding_patch = () = $realfile =~ m@^(?:Documentation/devicetree/|include/dt-bindings/)@;
2928 if (($last_binding_patch != -1) &&
2931 …udes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst\n");
2954 "Missing commit description - Add an appropriate one\n");
2962 $line =~ m@^\s*(?:\-\-\-\s+a/|\+\+\+\s+b/)@ ||
2963 $line =~ m/^\s*\@\@ \-\d+,\d+ \+\d+,\d+ \@\@/)) {
2965 "Avoid using diff content in the commit message - patch(1) might not work\n" . $herecurr);
2980 if (decode("MIME-Header", $line) =~ /^From:\s*(.*)/) {
2986 $author = encode("utf8", $author) if ($line =~ /=\?utf-8\?/i);
2992 if ($line =~ /^\s*signed-off-by:\s*(.*)/i) {
3031 if ($line =~ /^---$/) {
3044 $line =~ /^(\s*)([a-z0-9_-]+by:|$signature_tags)(\s*)(.*)/i) {
3055 "Non-standard signature: $sign_off\n" . $herecurr);
3058 "Non-standard signature: '$sign_off' - perhaps '$suggested_signature'?\n" . $herecurr) &&
3072 if ($sign_off =~ /-by:$/i && $sign_off ne $ucfirst_sign_off) {
3136 $cur_name =~ s/[a-zA-Z\s\-\"]+//g;
3186 # Check Co-developed-by: immediately followed by Signed-off-by: with same name and email
3187 if ($sign_off =~ /^co-developed-by:$/i) {
3190 … "Co-developed-by: should not be used to attribute nominal patch author '$author'\n" . $herecurr);
3194 "Co-developed-by: must be immediately followed by Signed-off-by:\n" . $herecurr);
3195 } elsif ($rawlines[$linenr] !~ /^signed-off-by:\s*(.*)/i) {
3197 …"Co-developed-by: must be immediately followed by Signed-off-by:\n" . $herecurr . $rawlines[$linen…
3200 …"Co-developed-by and Signed-off-by: name/email do not match\n" . $herecurr . $rawlines[$linenr] . …
3204 # check if Reported-by: is followed by a Closes: tag
3205 if ($sign_off =~ /^reported(?:|-and-tested)-by:$/i) {
3208 …"Reported-by: should be immediately followed by Closes: with a URL to the report\n" . $herecurr . …
3211 …"Reported-by: should be immediately followed by Closes: with a URL to the report\n" . $herecurr . …
3229 $line =~ /^\s*(fixes:?)\s*(?:commit\s*)?([0-9a-f]{5,40})(?:\s*($balanced_parens))?/i) {
3237 $title = substr($3, 1, -1);
3239 $title = substr($title, 1, -1);
3248 my $tag_space = not ($line =~ /^fixes:? [0-9a-f]{5,40} ($balanced_parens)/i);
3250 my $id_length = not ($orig_commit =~ /^[0-9a-f]{12,40}$/i);
3251 my $id_case = not ($orig_commit !~ /[A-F]/);
3260 …"Please use correct Fixes: style 'Fixes: <12+ chars of sha1> (\"<title line>\")' - ie: '$fixed'\n"…
3274 # Check for Gerrit Change-Ids not in any patch context
3275 if ($realfile eq '' && !$has_patch_separator && $line =~ /^\s*change-id:/i) {
3277 "Remove Gerrit Change-Id's before submitting upstream\n" . $herecurr) &&
3288 $line =~ /^\s*\[\<[0-9a-fA-F]{8,}\>\]/) ||
3289 $line =~ /^(?:\s+\w+:\s+[0-9a-fA-F]+){3,3}/ ||
3290 $line =~ /^\s*\#\d+\s*\[[0-9a-fA-F]+\]\s*\w+ at [0-9a-fA-F]+/) {
3298 !($line =~ /^\s*[a-zA-Z0-9_\/\.]+\s+\|\s+\d+/ ||
3300 $line =~ /^\s*(?:[\w\.\-\+]*\/)++[\w\.\-\+]+:/ ||
3321 "Patch version information should be after the --- line\n" . $herecurr);
3350 # commit <SHA-1 hash length 12+ chars> ("Complete commit subject")
3353 # bare SHA-1 hash with minimum length of 5. It also avoids several types of
3354 # possible SHA-1 matches.
3359 $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink|base-commit):/i &&
3360 $line !~ /^This reverts commit [0-9a-f]{7,40}/ &&
3361 (($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
3362 … /\bcommit\s*$/i && defined($rawlines[$linenr]) && $rawlines[$linenr] =~ /^\s*[0-9a-f]{5,}\b/i)) ||
3363 ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i &&
3364 $line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i &&
3365 $line !~ /\bfixes:\s*[0-9a-f]{12,40}/i))) {
3380 if ($line =~ /(?:\bcommit\s+[0-9a-f]{5,}|\bcommit\s*$)/i) {
3382 if ($input =~ /\bcommit\s+[0-9a-f]{5,}\s*($balanced_parens)/i) {
3386 $orig_desc = substr($orig_desc, 1, -1);
3388 $orig_desc = substr($orig_desc, 1, -1);
3400 if ($input =~ /\b(c)ommit\s+([0-9a-f]{5,})\b/i) {
3403 $short = 0 if ($input =~ /\bcommit\s+[0-9a-f]{12,40}/i);
3404 $long = 1 if ($input =~ /\bcommit\s+[0-9a-f]{41,}/i);
3405 $space = 0 if ($input =~ /\bcommit [0-9a-f]/i);
3406 $case = 0 if ($input =~ /\b[Cc]ommit\s+[0-9a-f]{5,40}[^A-F]/);
3407 } elsif ($input =~ /\b([0-9a-f]{12,40})\b/i) {
3416 $last_git_commit_id_linenr != $linenr - 1) {
3418 …it commit description style 'commit <12+ chars of sha1> (\"<title line>\")' - ie: '${init_char}omm…
3427 …"Use lore.kernel.org archive links when possible - see https://lore.kernel.org/lists.html\n" . $he…
3433 $line =~ /^rename (?:from|to) [\w\/\.\-]+\s*$/ ||
3434 ($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/ &&
3447 …"DT bindings should be in DT schema format. See: Documentation/devicetree/bindings/writing-schema.…
3451 if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
3457 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
3467 "Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr);
3474 $rawline =~ /^(?:commit\b|from\b|[\w-]+:)/i)) {
3480 # Check if there is UTF-8 in a commit log when a mail header has explicitly
3483 $rawline =~ /^Content-Type:.+charset="(.+)".*$/ &&
3484 $1 !~ /utf-8/i) {
3491 "8-bit UTF-8 used in possible commit log\n" . $herecurr);
3512 while ($rawline_utf8 =~ /(?:^|[^\w\-'`])($misspellings)(?:[^\w\-'`]|$)/gi) {
3515 my $ptr = substr($blank, 0, $-[1]) . "^" x length($typo);
3518 $typo_fix = ucfirst($typo_fix) if ($typo =~ /^[A-Z]/);
3519 $typo_fix = uc($typo_fix) if ($typo =~ /^[A-Z]+$/);
3523 "'$typo' may be misspelled - perhaps '$typo_fix'?\n" . $hereptr) &&
3525 $fixed[$fixlinenr] =~ s/(^|[^A-Za-z@])($typo)($|[^A-Za-z@])/$1$typo_fix$3/;
3531 if ($in_commit_log && $line =~ /(^fixes:|\bcommit)\s+([0-9a-f]{6,40})\b/i) {
3542 # avoid false positive from list command eg, '-rw-r--r-- 1 root root'
3544 $rawline !~ /[bcCdDlMnpPs\?-][rwxsStT-]{9}/) {
3550 my $start_pos = $-[1];
3563 $start_char = substr($rawline, $start_pos - 1, 1) if ($start_pos > ($in_commit_log ? 0 : 1));
3567 next if (index(" \t.,;?!", $end_char) == -1);
3570 if ($first =~ /\b[0-9a-f]{2,}\b/i) {
3595 # ignore non-hunk lines and lines being removed
3596 next if (!$hunk_line || $line =~ /^-/);
3644 next if ($f =~ /^-/);
3674 my $stat_real = get_stat_real($linenr, $ln - 1);
3683 if ($rawline =~ /^\+[A-Z]:/ &&
3684 $rawline !~ /^\+[A-Z]:\t\S/) {
3688 $fixed[$fixlinenr] =~ s/^(\+[A-Z]):\s*/$1:\t/;
3693 if ($rawline =~ /^\+[A-Z]:/ &&
3694 $prevrawline =~ /^[\+ ][A-Z]:/) {
3695 $rawline =~ /^\+([A-Z]):\s*(.*)/;
3698 $prevrawline =~ /^[\+ ]([A-Z]):\s*(.*)/;
3709 "Misordered MAINTAINERS entry - list '$cur:' before '$prev:'\n" . $hereprev);
3714 "Misordered MAINTAINERS entry - list file patterns in alphabetic order\n" . $hereprev);
3725 my @compats = $rawline =~ /\"([a-zA-Z0-9\-\,\.\+_]+)\"/g;
3728 my $vp_file = $dt_path . "vendor-prefixes.yaml";
3732 $compat2 =~ s/\,[a-zA-Z0-9]*\-/\,<\.\*>\-/;
3734 $compat3 =~ s/\,([a-z]*)[0-9]*\-/\,$1<\.\*>\-/;
3735 `grep -Erq "$compat|$compat2|$compat3" $dt_path`;
3738 "DT compatible string \"$compat\" appears un-documented -- check $dt_path\n" . $herecurr);
3741 next if $compat !~ /^([a-zA-Z0-9\-]+)\,/;
3743 `grep -Eq "\\"\\^\Q$vendor\E,\\.\\*\\":" $vp_file`;
3746 … "DT compatible string vendor \"$vendor\" appears un-documented -- check $vp_file\n" . $herecurr);
3751 # Check for RGMII phy-mode with delay on PCB
3753 $line =~ /^\+\s*(phy-mode|phy-connection-type)\s*=\s*"/ &&
3757 if ($mode =~ /^"rgmii(?:|-rxid|-txid)"$/) {
3759 …"$prop $mode without comment -- delays on the PCB should be described, otherwise use \"rgmii-id\"\…
3781 $rawline =~ /SPDX-License-Identifier:/ &&
3788 $rawline !~ m@^\+\Q$comment\E SPDX-License-Identifier: @) {
3790 … "Missing or malformed SPDX-License-Identifier tag in line $checklicenseline\n" . $herecurr);
3791 } elsif ($rawline =~ /(SPDX-License-Identifier: .*)/) {
3798 $spdx_license !~ /GPL-2\.0(?:-only)? OR BSD-2-Clause/) {
3803 "DT binding documents should be licensed (GPL-2.0-only OR BSD-2-Clause)\n" . $herecurr) &&
3805 …$fixed[$fixlinenr] =~ s/SPDX-License-Identifier: .*/SPDX-License-Identifier: (GPL-2.0-only OR BSD-…
3808 if ($realfile =~ m@^include/dt-bindings/@ &&
3809 $spdx_license !~ /GPL-2\.0(?:-only)? OR \S+/) {
3811 "DT binding headers should be licensed (GPL-2.0-only OR .*)\n" . $herecurr);
3826 # check for using SPDX-License-Identifier on the wrong line number
3828 $rawline =~ /\bSPDX-License-Identifier:/ &&
3829 substr($line, @-, @+ - @-) eq "$;" x (@+ - @-)) {
3831 "Misplaced SPDX-License-Identifier tag - use line $checklicenseline instead\n" . $herecurr);
3858 length(expand_tabs(substr($line, 1, length($line) - length($1) - 1))) <= $max_line_length) {
3873 } elsif ($rawline =~ /^\+.*\b[a-z][\w\.\+\-]*:\/\/\S+/i) {
3880 length(expand_tabs(substr($line, 1, length($line) - length($1) - 1))) <= $max_line_length) {
3885 length(expand_tabs(substr($line, 1, length($line) - length($1) - 1))) <= $max_line_length) {
3909 $line =~ /^\+\s*(?:[A-Z]+_)?SYM_[A-Z]+_(?:START|END)(?:_[A-Z_]+)?\s*\(\s*\.L/) {
3911 … range of code via 'SYM_*_START/END' annotations; see Documentation/core-api/asm-annotations.rst\n…
3950 $fixed[$fixlinenr - 1] .= " $operator";
3961 # insert logical operator at last non-comment, non-whitepsace char on previous line
3963 my $line_end = substr($prevrawline, $-[0]);
3964 $fixed[$fixlinenr - 1] =~ s/\Q$line_end\E$/ $operator$line_end/;
3982 # check multi-line statement indentation matches previous line
4080 $line =~ /^\+[a-z_]*init/ ||
4081 $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ ||
4095 $last_blank_line != ($linenr - 1)) {
4249 (!defined $lines[$realline_next - 1] ||
4250 substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) {
4330 …if ($line =~ /(.*)\b((?:if|while|for|switch|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|do\b|else\b)/ && $li…
4337 "Too many leading tabs - consider code refactoring\n" . $herecurr);
4340 my $ctx_cnt = $realcnt - $#ctx - 1;
4347 defined $lines[$ctx_ln - 1] &&
4348 $lines[$ctx_ln - 1] =~ /^-/)) {
4350 $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/);
4355 #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
4357 if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln - 1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
4360 "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
4364 defined $lines[$ctx_ln - 1])
4366 my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
4370 "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
4376 …if ($line =~ /\b(?:(?:if|while|for|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|(?:do|else)\b)/ && $line !~ /…
4424 my $cond_ptr = -1;
4487 $prev_values = substr($curr_values, -1);
4495 if ($line =~ /^\+\s*(?:$Declare)?([A-Za-z_][A-Za-z\d_]*)\s*=/) {
4499 "Do not use self-assignments to avoid compiler warnings\n" . $herecurr);
4504 if ($prevline =~ /^\+.*$Lval\s*(?:\.|->)\s*$/ &&
4506 $prevline =~ /($Lval\s*(?:\.|->))\s*$/;
4512 "Avoid multiple line dereference - prefer '$ref'\n" . $hereprev);
4568 fix_delete_line($fixlinenr - 1, $prevrawline);
4614 #print "APW <$lines[$realline_next - 1]>\n";
4616 exists $lines[$realline_next - 1] &&
4618 ($lines[$realline_next - 1] =~ /EXPORT_SYMBOL.*\((.*)\)/)) {
4625 if ($stat =~ /^(?:.\s*}\s*\n)?.([A-Z_]+)\s*\(\s*($Ident)/ &&
4638 #print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
4647 #print "FOO B <$lines[$linenr - 1]>\n";
4742 "Move const after static - use 'static const $1'\n" . $herecurr) &&
4749 # check for non-global char *foo[] = {"bar", ...} declarations.
4772 "Bad function definition - $1() should probably be $1(void)\n" . $herecurr) &&
4846 …if ($line =~ /\b(?!AA_|BUILD_|IDA_|KVM_|RWLOCK_|snd_|SPIN_)(?:[a-zA-Z_]*_)?BUG(?:_ON)?(?:_[A-Z_]+)…
4850 …"Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery cod…
4866 if ($line =~ /\bprintk\s*\(\s*(?!KERN_[A-Z]+\b)/) {
4872 if ($line =~ /\b(printk(_once|_ratelimited)?)\s*\(\s*KERN_([A-Z]+)/) {
4888 if ($line =~ /\bdev_printk\s*\(\s*KERN_([A-Z]+)/) {
4950 fix_delete_line($fixlinenr - 1, $prevrawline);
5043 # 1. with a type on the left -- int [] a;
5044 # 2. at the beginning of a line for slice initialisers -- [0...10] = 5,
5045 # 3. inside a curly brace -- = { [0...10] = 5 }
5047 my ($where, $prefix) = ($-[1], $1);
5063 my $ctx_before = substr($line, 0, $-[1]);
5073 # cpp #define statements have non-optional spaces, ie
5102 \+=|-=|\*=|\/=|%=|\^=|\|=|&=|
5103 =>|->|<<|>>|<|>|=|!|~|
5104 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%|
5125 my $last_after = -1;
5204 # ->
5205 } elsif ($op eq '->') {
5247 # '*' as part of a type definition -- reported already.
5255 $opv eq '*U' || $opv eq '-U' ||
5257 if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {
5280 # unary ++ and unary -- are allowed no space on one side.
5281 } elsif ($op eq '++' or $op eq '--') {
5311 $op eq '+' or $op eq '-' or
5323 } elsif (!defined $fix_elements[$n + 2] && $ctx !~ /Wx[OE]/) {
5406 # check for whitespace before a non-naked semicolon
5507 # ie: &(foo->bar) should be &foo->bar and *(foo->bar) should be *foo->bar
5519 # ie: (foo->bar)(); should be foo->bar();
5520 # but not "if (foo->bar) (" to avoid some false positives
5538 my $test = substr($2, 1, -1);
5562 if ($sline =~ /^.\s+[A-Za-z_][A-Za-z\d_]*:(?!\s*\d+)/ &&
5563 $sline !~ /^. [A-Za-z\d_][A-Za-z\d_]*:/ &&
5602 # at end-of-function, with the previous line a single leading tab, then return;
5607 $lines[$linenr - 3] =~ /^[ +]/ &&
5608 $lines[$linenr - 3] !~ /^[ +]\s*$Ident\s*:/) {
5613 # if statements using unnecessary parentheses - ie: if ((foo == bar))
5621 $msg = " - maybe == should be = ?" if ($comp eq "==");
5632 $line =~ /^\+(.*)\b($Constant|[A-Z_][A-Z0-9_]*)\s*($Compare)\s*($LvalOrFunc)/) {
5639 $to !~ /^(?:Constant|[A-Z_][A-Z0-9_]*)$/ &&
5657 if ($sline =~ /\breturn(?:\s*\(+\s*|\s+)(E[A-Z]+)(?:\s*\)+\s*|\s*)[;:,]/) {
5661 "return of an errno should typically be negative (ie: return -$1)\n" . $herecurr);
5675 # Check for illegal assignment in if conditional -- and check for trailing
5690 ($stat_next =~ /^((?:\s*\n[+-])*\s*)/s);
5692 statement_rawlines($whitespace) - 1;
5772 \s*0[xX][0-9]+\s*
5776 \s*0[xX][0-9]+\s*
5817 fix_delete_line($fixlinenr - 1, $prevrawline);
5843 fix_delete_line($fixlinenr - 1, $prevrawline);
5861 $var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
5865 $var !~ /^(?:[A-Z]+_){1,5}[A-Z]{1,3}[a-z]/ &&
5867 $var !~ /^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
5872 $var !~ /^(?:[a-z0-9_]*|[A-Z0-9_]*)?_?[a-z][A-Z](?:_[a-z0-9_]+|_[A-Z0-9_]+)?$/ &&
5874 $var !~ /^(?:[a-z_]*?)_?(?:[KMGT]iB|[KMGT]?Hz)(?:_[a-z_]+)?$/) {
5877 next if ($word !~ /[A-Z][a-z]|[a-z][A-Z]/);
5908 if (-f "$root/$checkfile" &&
5912 my $asminclude = `grep -Ec "#include\\s+<asm/$file>" $root/$checkfile`;
5925 # Usually multi-statement macros should be enclosed in a do {} while
5940 #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
5951 $define_args = substr($define_args, 1, length($define_args) - 2);
6001 $dstat !~ /^(?:$Ident|-?$Constant),$/ && # 10, // foo(),
6002 $dstat !~ /^(?:$Ident|-?$Constant);$/ && # foo();
6003 …$dstat !~ /^[!~-]?(?:$Lval|$Constant)$/ && # 10 // foo() // !foo // ~foo // -foo // foo->bar // f…
6012 $dstat !~ /^for\s*$Constant\s+(?:$Ident|-?$Constant)$/ && # for (...) bar()
6019 …"Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic d…
6022 …"Non-declarative macros with multiple statements should be enclosed in a do - while loop\n" . "$he…
6030 # Make $define_stmt single line, comment-free, etc
6058 "Macro argument reuse '$arg' - possible side-effects?\n" . "$herectx");
6071 "Argument '$arg' is not used in function-like macro\n" . "$herectx");
6101 # single-statement macros do not need to be enclosed in do while (0) loop,
6155 my $ln = $linenr - 1;
6160 my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s);
6161 my $offset = statement_rawlines($whitespace) - 1;
6170 $ln += statement_rawlines($block) - 1;
6207 if (!defined $suppress_ifbraces{$linenr - 1} &&
6211 # Check the pre-context.
6212 if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) {
6218 ctx_statement_full($linenr, $realcnt, $-[0]);
6238 # Check the post-context.
6245 #print "APW: ALLOWED: chunk-1 block<$block>\n";
6269 fix_delete_line($fixlinenr - 1, $prevrawline);
6284 …"Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst\n" . …
6287 # Check for user-visible strings broken across lines, which breaks the ability
6293 $prevrawline !~ /(?:\\(?:[ntr]|[0-7]{1,3}|x[0-9a-fA-F]{1,2})|;\s*|\{\s*)"\s*$/) {
6298 $last_coalesced_string_linenr != $linenr - 1) {
6305 fix_delete_line($fixlinenr - 1, $prevrawline);
6310 fix_insert_line($fixlinenr - 1, $fixedline);
6327 # This does not work very well for -f --file checking as it depends on patch
6328 # context providing the function name or a single line form for in-file
6343 "Unnecessary ftrace-like logging - prefer using ftrace\n" . $herecurr) &&
6360 if ($line =~ /$String[A-Z_]/ ||
6361 ($line =~ /([A-Za-z0-9_]+)$String/ && $1 !~ /^[Lu]$/)) {
6366 my $extracted_string = substr($rawline, $-[0], $+[0] - $-[0]);
6367 $fixed[$fixlinenr] =~ s/\Q$extracted_string\E([A-Za-z0-9_])/$extracted_string $1/;
6368 $fixed[$fixlinenr] =~ s/([A-Za-z0-9_])\Q$extracted_string\E/$1 $extracted_string/;
6379 my $extracted_string = substr($rawline, $-[0], $+[0] - $-[0]);
6380 $fixed[$fixlinenr] =~ s/\Q$extracted_string\E\s*"/substr($extracted_string, 0, -1)/e;
6385 # check for non-standard and hex prefixed decimal printf formats
6389 my $string = substr($rawline, $-[1], $+[1] - $-[1]);
6394 "\%L$1 is non-standard C, use %ll$1\n" . $herecurr);
6400 "%Z$1 is non-standard C, use %z$1\n" . $herecurr);
6440 if ($lines[$linenr - 2] =~ /^\+(\t*)if\s*\(\s*$tested\s*\)\s*$/) {
6445 if ($lines[$linenr - 1] =~ /^\+(\t+)$func\s*\(\s*$tested\s*\)\s*;\s*$/) {
6454 fix_delete_line($fixlinenr - 1, $prevrawline);
6467 my $testline = $lines[$linenr - 3];
6469 my ($s, $c) = ctx_statement_block($linenr - 3, $realcnt, 0);
6481 $line =~ /\b$logFunctions\s*\(.*\b(KERN_[A-Z]+)\b/) {
6504 while ($stat_real =~ /[^\"%]*(%[\#\d\.\*\-]*(h+)[idux])/g) {
6507 my $lineoff = substr($stat_real, 0, $-[1]) =~ tr@\n@@;
6523 … "Possible precedence defect with mask then right shift - may need parentheses\n" . $herecurr);
6587 # check for __read_mostly with const non-pointer (should just be const)
6612 my $delay = $1;
6614 if (! ($delay < 10) ) {
6618 if ($delay > 2000) {
6620 "long udelay - prefer mdelay; see function description of mdelay().\n" . $herecurr);
6701 if ($realfile !~ m@^include/asm-generic/@ &&
6706 "__smp memory barriers shouldn't be used outside barrier.h and asm-generic\n" . $herecurr);
6726 … m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
6871 …"Unnecessary typecast of c90 int constant - '$cast$const' could be '$const$suffix'\n" . $herecurr)…
6925 my $fmt = get_quoted_string($lines[$count - 1], raw_line($count, 0));
6954 $use = " - use %pS instead";
6957 $use = " - '%pA' is only intended to be used from Rust code";
7029 "Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88\n" . $herecurr);
7035 "Prefer strscpy over strlcpy - see: https://github.com/KSPP/linux/issues/89\n" . $herecurr);
7041 …"Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/iss…
7178 "found a file-scoped extern type:$st_type name:$st_name in .c file\n"
7232 …"__setup appears un-documented -- check Documentation/admin-guide/kernel-parameters.txt\n" . $here…
7239 … "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
7268 !($r1 =~ /^$Constant$/ || $r1 =~ /^[A-Z_][A-Z0-9_]*$/)) {
7323 …if ($line =~ /^\+\s*#\s*if\s+defined(?:\s*\(?\s*|\s+)(${CONFIG_}[A-Z_]+)\s*\)?\s*\|\|\s*defined(?:…
7336 'lint -fallthrough[ \t]*',
7337 'intentional(?:ly)?[ \t]*fall(?:(?:s | |-)[Tt]|t)hr(?:ough|u|ew)',
7338 '(?:else,?\s*)?FALL(?:S | |-)?THR(?:OUGH|U|EW)[ \t.!]*(?:-[^\n\r]*)?',
7339 'Fall(?:(?:s | |-)[Tt]|t)hr(?:ough|u|ew)[ \t.!]*(?:-[^\n\r]*)?',
7340 'fall(?:s | |-)?thr(?:ough|u|ew)[ \t.!]*(?:-[^\n\r]*)?',
7377 "Use of the '$1' macro makes the build non-deterministic\n" . $herecurr);
7383 "Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)\n" . $herecurr);
7466 …"usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_po…
7472 … "#define of '$1' is wrong - use Kconfig variables or standard guards instead\n" . $herecurr);
7484 substr($rawline, $-[6], $+[6] - $-[6]) !~ /\\n"$/) {
7485 my $offset = $+[6] - 1;
7497 …"Use C99 flexible arrays - see https://docs.kernel.org/process/deprecated.html#zero-length-and-one…
7499 $fixed[$fixlinenr - 1] =~ s/\[\s*0\s*\]/[]/;
7551 "lockdep_no_validate class is reserved for device->mutex.\n" . $herecurr);
7566 …E_ATTR\s*\(\s*(\w+)\s*,\s*\(?\s*(\s*(?:${multi_mode_perms_string_search}|0[0-7]{3,3})\s*)\s*\)?\s*…
7628 my $func = $entry->[0];
7629 my $arg_pos = $entry->[1];
7637 $arg_pos--;
7687 …"Prefer \"GPL\" over \"GPL v2\" - see commit bf7fbeeae6db (\"module: Cure the MODULE_LICENSE \"GPL…
7695 if ($line =~ /\.extra[12]\s*=\s*&(zero|one|int_max)\b/) {
7715 if (!(substr($stripped, -4) eq "{}};" ||
7716 substr($stripped, -6) eq "{{}}};" ||
7728 if ($#rawlines == -1) {
7738 # This is not a patch, and we are in 'no-patch' mode so
7744 if (!$is_patch && $filename !~ /cover-letter\.patch$/) {
7746 "Does not appear to be a unified-diff format patch\n");
7757 "Missing Signed-off-by: line(s)\n");
7760 # 0 -> missing sign off
7761 # 1 -> sign off identical
7762 # 2 -> names and addresses match, comments mismatch
7763 # 3 -> addresses match, names different
7764 # 4 -> names match, addresses different
7765 # 5 -> names match, addresses excluding subaddress details (refer RFC 5233) match
7767 my $sob_msg = "'From: $author' != 'Signed-off-by: $author_sob'";
7771 "Missing Signed-off-by: line by nominal patch author '$author'\n");
7774 "From:/Signed-off-by: email comments mismatch: $sob_msg\n");
7777 "From:/Signed-off-by: email name mismatch: $sob_msg\n");
7780 "From:/Signed-off-by: email address mismatch: $sob_msg\n");
7783 "From:/Signed-off-by: email subaddress mismatch: $sob_msg\n");
7802 mechanically convert to the typical style using --fix or --fix-inplace.
7821 $newfile .= ".EXPERIMENTAL-checkpatch-fixes" if (!$fix_inplace);
7845 Wrote EXPERIMENTAL --fix correction(s) to '$newfile'