Lines Matching refs:should
246 The first argument for kcalloc or kmalloc_array should be the
259 should be::
276 Architecture specific defines should be avoided wherever
286 BUG() or BUG_ON() should be avoided totally.
355 The function names should preferably follow the above pattern.
407 otherwise valid syscalls. This should be avoided in new code.
412 ENOTSUPP is not a standard error code and should be avoided in new patches.
413 EOPNOTSUPP should be used instead.
418 EXPORT_SYMBOL should immediately follow the symbol to be exported.
433 It should not be used for any other purpose.
443 lockdep_assert_held() annotations should be preferred over
449 No #include statements in include/uapi should use a uapi/ path.
452 usleep_range() should be preferred over udelay(). The proper way of
471 C99 style single line comments (//) should not be used.
477 Applications of data_race() should have a comment so as to document the
497 signal to be delayed on the PCB; this unusual configuration should be
517 For adding version info, the following comment style should be used::
528 description of the changes made by the patch should be added.
553 line should be added according to Developer's certificate of
560 required that a simple sign off line should be present at the
614 should be written as::
631 side of the test should be avoided.
638 Code indent should use tabs instead of spaces.
654 switch should be at the same indent as case.
704 grepped, should not be split across multiple lines.
736 Trailing statements (for example after any conditional) should be
742 should be::
752 The ARRAY_SIZE(foo) macro should be preferred over
765 Local symbol names that are prefixed with `.L` should be avoided,
772 but `.L` prefixed local symbol names should not be used to denote
788 read-only. The __read_mostly annotation thus should be removed.
807 should either use weak functions (appropriate for some cases), or
808 the symbol that protects them should be the same symbol we use.
813 do {} while(0) macros should not have a trailing semicolon.
816 Const init definitions should use __initconst instead of
823 The inline keyword should sit between storage class and type.
832 should be::
854 Macros with multiple statements should be enclosed in a
855 do - while block. Same should also be the case for macros
871 Macro definition should not end with a semicolon. The macro
872 invocation style should be consistent with function calls.
960 This should be corrected to::
969 All arguments should have identifier names.
976 should be::
981 Global variables should not be initialized explicitly to
987 Static variables should not be initialized explicitly to zero.
1006 Pointers with __free attribute should be declared at the place of use
1022 should be initialized as::
1053 Permission bits should use 4 digit octal permissions (like 0700 or 0444).
1072 Assignment operators should not be written at the start of a
1073 line but should follow the operand at the previous line.
1112 Concatenated elements should have a space in between.
1117 should be::
1122 `else {` should follow the closing block `}` on the same line.
1133 The opening brace should be following the function definitions on the
1134 next line. For any non-functional block it should be on the same line
1157 Trailing whitespace should always be removed.
1195 while should follow the closing bracket on the same line::
1208 Kconfig symbols should have a help text which fully describes
1217 So, CVS style keywords ($Id$, $Revision$, $Log$) should not be
1224 A "break;" should be added after empty default statement to avoid
1229 the line. These should be removed.
1238 Devicetree bindings should be their own patch. This is because
1275 Prefixing 0x with decimal output is defective and should be corrected.