further lint fixes

(cherry picked from commit 4ab1323af43e16c3c75773a928cdb4b8a38b6621)

zev: bugfix: device nodes remained for delete queues

devfs_clean() is used to remove old device nodes. It requires
a dev_info_t as a starting point. The zev instance's dev_info_t
was used but didn

zev: bugfix: device nodes remained for delete queues

devfs_clean() is used to remove old device nodes. It requires
a dev_info_t as a starting point. The zev instance's dev_info_t
was used but didn't work. ddi_root_node() is now used, which
returns top_devinfo.

(cherry picked from commit 85dcc477b9e19a46828540f27460c39ec7d9acb3)

show more ...

zev: fix: tmpqueues should be initially empty

When creating temporary queues dynamically, (by opening the
tmpqueue device) the resulting queue should start empty and not
contain any old events.

(ch

zev: fix: tmpqueues should be initially empty

When creating temporary queues dynamically, (by opening the
tmpqueue device) the resulting queue should start empty and not
contain any old events.

(cherry picked from commit e61588a30d771b9cef4272cc070900ddfca2caf1)

show more ...

zev: dynamically create temporary queues

The zev driver can now create new ephemeral queues in the fly.

When the tmpqueue device is opened, a new non-persistent queue
is created and the userland ca

zev: dynamically create temporary queues

The zev driver can now create new ephemeral queues in the fly.

When the tmpqueue device is opened, a new non-persistent queue
is created and the userland can immediatly use it as though
the tmpqueue device itself was a valid queue device. As soon
as the device is closed the temporary queue is removed.

This should make using tmp queues easier. It is no longer
necessary to find or generate a free queue name, and tmp queues
opened via the tmpqueue device can not be orphaned - they are
already opened when they are created. Using the old method
a userland process might crash or forget about a tmp queue
it has created - which would then remain in the queue list
indefinitly.

(cherry picked from commit 441d11320a78072d7e6d87230d4271396bf53648)

show more ...

zev: bugfix: device files are removed correctly

When a queue is removed the corresponding /devices special files
were not correctly removed aswell. To achieve that, it is
necessary to call devfs_cl

zev: bugfix: device files are removed correctly

When a queue is removed the corresponding /devices special files
were not correctly removed aswell. To achieve that, it is
necessary to call devfs_clean() using the DV_CLEAN_FORCE flag.
This is now done and the device files dissapear as one would expect.

(cherry picked from commit c9ca1789b5c8ee2493129f0c6ba97999e110d893)

show more ...

zev: bugfix: missing mutex protection

In certain circuumstances zev_hold_queue() was called without
acquiring the necessary mutex first. I have not found any
code in zevadm or beaverd that might ac

zev: bugfix: missing mutex protection

In certain circuumstances zev_hold_queue() was called without
acquiring the necessary mutex first. I have not found any
code in zevadm or beaverd that might actually trigger this bug,
though.

(cherry picked from commit 2999edecce9b37a4cb1afce74f711ecc92a24d35)

show more ...

zev: bugfix: some queues were blocking too early

Under certain conditions, zev queues would block too soon or
for the wrong queues: if the max queue limit was reached and
there was a queue with the

zev: bugfix: some queues were blocking too early

Under certain conditions, zev queues would block too soon or
for the wrong queues: if the max queue limit was reached and
there was a queue with the block flag, zev would block new
messages, even if the blocking queue wasn't full.

(cherry picked from commit b0e9cea3504949d7ad8e034834f531716cb8d908)

show more ...

zev: use devfs_cleanup to remove unused entries

Old device files under /devices/pseudo are no longer cleaned
up when the queue is no longer used. Calling devfs_cleanup()
was suggested to trigger th

zev: use devfs_cleanup to remove unused entries

Old device files under /devices/pseudo are no longer cleaned
up when the queue is no longer used. Calling devfs_cleanup()
was suggested to trigger this.

(cherry picked from commit 62b114c4754a2ea0f22c1bc9d1455494a4010f99)

show more ...

zev: bugfix: fix modinfo version string

The modinfo string has a marco to show the zev modules
version information. That macro was not correctly expanded
and the macro's name was shown instead.

(c

zev: bugfix: fix modinfo version string

The modinfo string has a marco to show the zev modules
version information. That macro was not correctly expanded
and the macro's name was shown instead.

(cherry picked from commit 87604a728c4afb2050560da461653ca42fc38944)

show more ...

zev: new ioctl() to query ABI version

A new ioctl() has been added to query the module for it's
version numbers. These are supposed to give an indication of
which behaviour and which feature set ca

zev: new ioctl() to query ABI version

A new ioctl() has been added to query the module for it's
version numbers. These are supposed to give an indication of
which behaviour and which feature set can be expected to work.

(cherry picked from commit f63c8e0930c25065bb397bcbbe45afb4f170fc96)

show more ...

zev: bugfix: zev_update_blockflag() without mutex

The function zev_update_blockflag() requires callers to
hold the zev_mutex, but zev_queue_new() called it without
holding zev_mutex.

(cherry picked

zev: bugfix: zev_update_blockflag() without mutex

The function zev_update_blockflag() requires callers to
hold the zev_mutex, but zev_queue_new() called it without
holding zev_mutex.

(cherry picked from commit 090d3ec73612995a4ea34f67051c3abb1f1cdac2)

show more ...

zev: filter events outside of HiDrive spaces

To reduce load on the beaver daemon we do not report events
that are not from a production HiDrive filesystem containing
customer data, recognized by the

zev: filter events outside of HiDrive spaces

To reduce load on the beaver daemon we do not report events
that are not from a production HiDrive filesystem containing
customer data, recognized by the string "_root" anyhere in
the dataset name.

(cherry picked from commit f13bc8390f84fee6da73e746d0d788b9fa771e3d)

show more ...

zev: bugfix: blocked at global queue size limit

Even if all queues where non-blocking, reaching the global queue
size limit made the system block ZFS calls.

Now, old messages are discarded until th

zev: bugfix: blocked at global queue size limit

Even if all queues where non-blocking, reaching the global queue
size limit made the system block ZFS calls.

Now, old messages are discarded until the new one fits into all
queues. A small optimization was added so we don't have to
iterate over all queues to find out whether we have any blocking
queues.

(cherry picked from commit ff713486fb8b8b11e70a36d5225a9933482e4918)

show more ...

zev: bugfix: lowering global queue size limit

When the global queue size limit was lowered, the individual
queue size maxima where not lowered accordingly.

(cherry picked from commit d114cf321a2cce

zev: bugfix: lowering global queue size limit

When the global queue size limit was lowered, the individual
queue size maxima where not lowered accordingly.

(cherry picked from commit d114cf321a2ccebeb2e9ad7d2745ff3af2f3f7ce)

show more ...

zev: option to create empty queues

New zev queues where filled with as many events as would fit from
the global event backlog. Now a flag can be set to skip this step.
The new queue will then be em

zev: option to create empty queues

New zev queues where filled with as many events as would fit from
the global event backlog. Now a flag can be set to skip this step.
The new queue will then be empty upon creation and will only receive
events newer than the queue itself.

(cherry picked from commit 6970b7d9a5856021f673d67e8ba9f061c20eac54)

show more ...

zev: bugfix: trim queue after reading messages

The read() handler did not shorten the message queue after
a successfull read, relying on other places to do that.
But when the queue is full read() is

zev: bugfix: trim queue after reading messages

The read() handler did not shorten the message queue after
a successfull read, relying on other places to do that.
But when the queue is full read() is the only place that
can still perform work, every other thread blocks until the
queue is smaller. So read() also needs to trim the queue
down immediately.

(cherry picked from commit 578003757a2bbaa68f18d8d2afd161505e7e8fa2)

show more ...

zev: ioctl() to get signatures for an open file

There's a new ioctl() ZEV_IOC_GET_FILE_SIGNATURES to get
beaver signatures for a data range in an open file. The
provided buffer has to be large enou

zev: ioctl() to get signatures for an open file

There's a new ioctl() ZEV_IOC_GET_FILE_SIGNATURES to get
beaver signatures for a data range in an open file. The
provided buffer has to be large enough to hold the parameters
and the signatures.

zevadm can display a file's signatures using 'zevadm -c <filename>'

(cherry picked from commit 6b4c2eb9a413da85091774d0095ad61946ae043d)

show more ...

zev: calculate beaver-compatible checksums of changes

Ranges required to calculate the checksums will be range locked before
the zev callbacks are called. Checksums are calculated in the zev
module

zev: calculate beaver-compatible checksums of changes

Ranges required to calculate the checksums will be range locked before
the zev callbacks are called. Checksums are calculated in the zev
module and reported to userland. Checksums of all-zeroes blocks are
omitted. Userland is expected to infer that the block must have bee
all-zeroes.

An internal cache is implemented to avoid re-reading the same data
over and over again.

(cherry picked from commit d8e62bab61474da73f26dc58b26d937c9cc17397)

show more ...

zev: changes for #1891 review (multiplayer)

Review feedback addressed in this commit:

- remove avl, replace with array
- read() can block (but can be interrupted by signals)
- style changes
- q

zev: changes for #1891 review (multiplayer)

Review feedback addressed in this commit:

- remove avl, replace with array
- read() can block (but can be interrupted by signals)
- style changes
- queue threshold can be set to 0 bytes (no delay)
- FIND_QUEUE macro replaced by function
- new mutex to avoid races when queues are full
- zevadm can be told to poll events from a specified queue
- zevadm can create blocking queues

additional changes:

- mark events are delivered without delay

(cherry picked from commit e4ea145c5d454bda934f8af75eec9ea17f2489c0)

show more ...

zev: multi-queue support

(cherry picked from commit bc16f3206d5f60ea7a18a972c3a52afb85102b71)

zev: remove unnecessary zap_lookup, display ctime

(cherry picked from commit a27b019ed8c12d2702bb90b14500b8932ac1ecd3)

zev: new ioctl (get_gen) and various fixes

(cherry picked from commit 7a84701fb0e8e59f59d30523c82b171d7e510273)

zev: small fix for zev_detach() return value

(cherry picked from commit ff33ba5a948e98d96388e544a519285260587106)

zev: bugfix - zev_detach return value when busy

zev_detach() returned EBUSY when the module was in use, but should
return DDI_FAILURE.

EBUSY leads to the titanic_7 kernel trying to unload the modul

zev: bugfix - zev_detach return value when busy

zev_detach() returned EBUSY when the module was in use, but should
return DDI_FAILURE.

EBUSY leads to the titanic_7 kernel trying to unload the module, which
will fail in _fini(), and also break functionality because of the partial
execution of _fini().

(cherry picked from commit b36b61981825c480819dc7087eeb3aad5be53d6d)

show more ...

zev: fix lint and build warnings

(cherry picked from commit 74cdfce6dd066682a1724b52826d50255f2af3dd)