sesutil(8): Complete libxo transition

Reviewed by: des
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D41418

sesutil: Fix a typo in an error message

PR: 281658
MFC after: 1 week

Remove $FreeBSD$: one-line .c pattern

Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/

sesutil: fix "fault all" with zoned jbods

Some SAS JBODs support zoning. This feature allows individual SAS
targets to be accessible by only some initiator ports. One application
would be connecti

sesutil: fix "fault all" with zoned jbods

Some SAS JBODs support zoning. This feature allows individual SAS
targets to be accessible by only some initiator ports. One application
would be connecting two servers to the same JBOD, but they wouldn't be
able to see each other's disks.

A zoned JBOD should also prohibit initiators from accessing SES elements
corresponding to inaccessible SAS targets. It reports that by setting
the element's status code to 0x8 (No Access Allowed).

The bug is that when doing "sesutil (fault|locate) all ...", sesutil
will attempt a ENCIOC_SETELMSTAT ioctl for every single element, even
the inaccessible ones. The enclosure will reject the command, the
kernel will return EINVAL, and sesutil will exit.

The solution is to check the element's status, and skip trying to set it
if the status is 0x8. But if the user actually supplied a ses ID, then
assume that he knows what he's doing and try to set it anyway.

PR: 270093
MFC after: 1 week
Sponsored by: Axcient
Reviewed by: mav, trasz
Differential Revision: https://reviews.freebsd.org/D39017

show more ...

sesutil: don't malloc in a tight loop

Reported by: mav
MFC after: 1 week
Sponsored by: Axcient
Reviwed by: mav
Differential Revision: https://reviews.freebsd.org/D38473

sesutil: plug memory leaks

MFC after: 1 week
Sponsored by: Axcient
Reviewed by: bapt
Differential Revision: https://reviews.freebsd.org/D33955

Add tests for ses(4)

The tests require SES hardware. Without it, the test cases will be
skipped.

Reviewed by: ken
Differential Revision: https://reviews.freebsd.org/D31809
Sponsored by: Axcient
MF

Add tests for ses(4)

The tests require SES hardware. Without it, the test cases will be
skipped.

Reviewed by: ken
Differential Revision: https://reviews.freebsd.org/D31809
Sponsored by: Axcient
MFC after: 2 weeks

show more ...

sesutil: fix a comment

MFC after: 2 weeks
Sponsored by: Axcient

sesutil: Avoid setting reserved bits.

Weird side of SES specification is that some bits have different
meaning or semantics in status and control pages. This patch fixes
non-zero writes into reserv

sesutil: Avoid setting reserved bits.

Weird side of SES specification is that some bits have different
meaning or semantics in status and control pages. This patch fixes
non-zero writes into reserved fields, that caused errors on some
enclosures when trying to control locate/fault LEDs, keeping other
bits unchanged.

MFC after: 2 weeks
Sposonred by: iXsystems, Inc.

show more ...

sesutil: Widen "Desc" field to fit "Drive Slot 23"

sesutil: Fix status checking

Previously we would display "OK, Swapped" for swapped disks,
instead of the usual disk size.

Reviewed By: allanjude
Differential Revision: https://reviews.freebsd.org/D

sesutil: Fix status checking

Previously we would display "OK, Swapped" for swapped disks,
instead of the usual disk size.

Reviewed By: allanjude
Differential Revision: https://reviews.freebsd.org/D31219

show more ...

Fix misplaced voltages/temperatures labels in 'sesutil show'.

PR: bin/247384
Reported by: brd
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D25353

Merge ^/head r357855 through r357920.

sesutil: fix Coverity CIDs

* 1411604: file descriptor leak
* 1411586: memory leaks, null dereference on ENOMEM

Reported by: Coverity Scan
Coverity CIDs: 1411604, 1411586
Reviewed by: trasz
MFC afte

sesutil: fix Coverity CIDs

* 1411604: file descriptor leak
* 1411586: memory leaks, null dereference on ENOMEM

Reported by: Coverity Scan
Coverity CIDs: 1411604, 1411586
Reviewed by: trasz
MFC after: 2 weeks
Sponsored by: Axcient
Differential Revision: https://reviews.freebsd.org/D23651

show more ...

Add 'sesutil show' subcommand to show enclosure and its contents
in a user-friendly way.

Reviewed by: allanjude, bcr (manpages)
MFC after: 2 weeks
Relnotes: yes
Sponsored by: Klara Inc.
Differential

Add 'sesutil show' subcommand to show enclosure and its contents
in a user-friendly way.

Reviewed by: allanjude, bcr (manpages)
MFC after: 2 weeks
Relnotes: yes
Sponsored by: Klara Inc.
Differential Revision: https://reviews.freebsd.org/D22567

show more ...

sesutil: fix another memory leak

Instead of calloc()ing (and forgetting to free) in a tight loop, just put
this small array on the stack.

Reported by: Coverity
Coverity CID: 1331665
MFC after: 2 we

sesutil: fix another memory leak

Instead of calloc()ing (and forgetting to free) in a tight loop, just put
this small array on the stack.

Reported by: Coverity
Coverity CID: 1331665
MFC after: 2 weeks
Sponsored by: Axcient

show more ...

sesutil: fix some memory leaks

Reported by: Coverity
Coverity CID: 1331665
MFC after: 2 weeks
Sponsored by: Axcient

sesutil: fix an out-of-bounds array access

sesutil would allow the user to toggle an LED that was one past the maximum
element. If he tried, ENCIOC_GETELMSTAT would return EINVAL.

Reported by: Cov

sesutil: fix an out-of-bounds array access

sesutil would allow the user to toggle an LED that was one past the maximum
element. If he tried, ENCIOC_GETELMSTAT would return EINVAL.

Reported by: Coverity
Coverity CID: 1398940
MFC after: 2 weeks
Sponsored by: Axcient

show more ...

Merge ^/head r343712 through r343806.

Check element type before setting LEDs.

With r319610, sesutil started twiddling the bits of every SES device.
Not everything is a disk slot, there are also fan controllers, temperature
sensors, even

Check element type before setting LEDs.

With r319610, sesutil started twiddling the bits of every SES device.
Not everything is a disk slot, there are also fan controllers, temperature
sensors, even power supplies, among other things controlled by SES.

Add a type check to make sure we are only operating on device slot and array
device slot elements. Other type elements will be skipped, but it would be
simple to add additional cases for controlling the ident LEDs of other
element types (which are not necessarily the same bits).

Rather than doing raw bit manipulation of an unstructured byte array using
unnamed numeric constants, leverage existing code abstractions.

Submitted by: Ryan Moeller <ryan@freqlabs.com>
MFC after: 1 week
Sponsored by: iXsystems, Inc.
Differential Revision: https://reviews.freebsd.org/D19052

show more ...

MFhead@r320180

Merge ^/head r319973 through 321382.

Merge ^/head r320398 through r320572.

Add libxo(3) support to sesutil(8)

This is useful to simplify parsing "sesutil map"

Submitted by: nikita.kozlov@blade-group.com
MFC after: 3 weeks
Relnotes: yes
Sponsored by: blade

Merge ^/head r320042 through r320397.