rtsold: Further usage message updates

Add -u, remove -p from the rtsol(8) usage message.

PR: 266634
MFC after: 1 week

rtsold: Add -i to the usage message

PR: 266634
Fixes: 231bac4ccc43 ("rtsol/rtsold: Add option to skip random delay")
MFC after: 1 week

(cherry picked from commit 9e9e64b693ab1e08cca46e26e46816054

rtsold: Add -i to the usage message

PR: 266634
Fixes: 231bac4ccc43 ("rtsol/rtsold: Add option to skip random delay")
MFC after: 1 week

(cherry picked from commit 9e9e64b693ab1e08cca46e26e468160542c33f3a)

show more ...

Remove $FreeBSD$: two-line .h pattern

Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/

rtsol: introduce an 'always' script

In addition to the 'M' and 'O' scripts (for when 'Managed' and 'Other'
flags are set) also introduce an 'always' script that is called for any
router advertisemen

rtsol: introduce an 'always' script

In addition to the 'M' and 'O' scripts (for when 'Managed' and 'Other'
flags are set) also introduce an 'always' script that is called for any
router advertisement (so even if M and O are not set).

This is primarly useful for systems like pfSense that wish to be
informed of routers for further system configuration.

See also https://redmine.pfsense.org/issues/14072

Reviewed by: melifaro
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D39931

show more ...

rtsol/rtsold: Add option to skip random delay

In accordance with a SHOULD in RFC 4861, rtsol and rtsold wait a
random time between zero and one (aka MAX_RTR_SOLICITATION_DELAY)
seconds before sendin

rtsol/rtsold: Add option to skip random delay

In accordance with a SHOULD in RFC 4861, rtsol and rtsold wait a
random time between zero and one (aka MAX_RTR_SOLICITATION_DELAY)
seconds before sending a Router Solicitation, in order to avoid
network congestion if many hosts come online at once. (The
question of how many hosts would be required to cause congestion
by each sending a single packet on a Gbps+ network is left to the
reader.)

The new option -i disables this wait and instructs rtsol and rtsold
to send the Router Solicitation immediately.

Reviewed by: bz, kp (earlier version)
MFC after: 1 week
Relnotes: yes
Sponsored by: https://www.patreon.com/cperciva
Differential Revision: https://reviews.freebsd.org/D32956

show more ...

rtsold: auto-probe point to point interfaces

rtsold works fine for point to point interfaces in manual mode but will
not auto-probe them.

Reviewed by: markj
MFC after: 1 week
Differential Revision:

rtsold: auto-probe point to point interfaces

rtsold works fine for point to point interfaces in manual mode but will
not auto-probe them.

Reviewed by: markj
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D31517

show more ...

Simplify using nvlist_append_string_array().

Reported by: hrs
MFC after: 1 week

fix casper initialization for setting scripts.

MFC after: 1 week

MFH

Sponsored by: Rubicon Communications, LLC (netgate.com)

rtsol(d): add script for "M bit"

While we do support the "O bit" running a script (usually to start a
dhcpv6 client) we have no options for setups which set the "M bit" for,
e.g., static address ass

rtsol(d): add script for "M bit"

While we do support the "O bit" running a script (usually to start a
dhcpv6 client) we have no options for setups which set the "M bit" for,
e.g., static address assignment as in EC2.

Duplicate most of the "O bit" logic to also start a script for the
"M bit" with the one difference: if the "M bit" is set we will not
start the script for the "O bit" as well (per RFC 4861, Section 4.2).

Reviewed by: hrs, markj
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D26099

show more ...

MFHead@r345275

MFhead@r344786

Merge ^/head r344549 through r344775.

rtsol: Use vwarnx(3) to log messages to standard error.

This ensures that the program name is included in the output, which
makes it easy to identify the source of error messages printed
during boot

rtsol: Use vwarnx(3) to log messages to standard error.

This ensures that the program name is included in the output, which
makes it easy to identify the source of error messages printed
during boot.

MFC after: 1 week

show more ...

Capsicumize rtsol(8) and rtsold(8).

These programs parse ND6 Router Advertisement messages; rtsold(8) has
required an SA, SA-14:20.rtsold, for a bug in this code. Thus, they
are good candidates for

Capsicumize rtsol(8) and rtsold(8).

These programs parse ND6 Router Advertisement messages; rtsold(8) has
required an SA, SA-14:20.rtsold, for a bug in this code. Thus, they
are good candidates for sandboxing.

The approach taken is to run the main executable in capability mode
and use Casper services to provide functionality that cannot be
implemented within the sandbox. In particular, several custom services
were required.

- A Casper service is used to send Router Solicitation messages on a
raw ICMP6 socket. Initially I took the approach of creating a
socket for each interface upon startup, and connect(2)ing it to
the all-routers multicast group for the interface. This permits
the use of sendmsg(2) in capability mode, but only works if the
interface's link is up when rtsol(d) starts. So, instead, the
rtsold.sendmsg service is used to transmit RS messages on behalf
of the main process. One could alternately define a service
which simply creates and connects a socket for each destination
address, and returns the socket to the sandboxed process. However,
to implement rtsold's -m option we also need to read the ND6 default
router list, and this cannot be done in capability mode.
- rtsold may execute resolvconf(8) in response to RDNSS and DNSSL
options in received RA messages. A Casper service is used to
fork and exec resolvconf(8), and to reap the child process.
- A service is used to determine whether a given interface's
link-local address is useable (i.e., not duplicated or undergoing
DAD). This information is supplied by getifaddrs(3), which reads
a sysctl not available in capability mode. The SIOCGIFCONF socket
ioctl provides equivalent information and can be used in capability
mode, but I decided against it for now because of some limitations
of that interface.

In addition to these new services, cap_syslog(3) is used to send
messages to syslogd.

Reviewed by: oshogbo
Tested by: bz (previous versions)
MFC after: 2 months
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D17572

show more ...

Merge ^/head r339670 through r339812.

Always free dynamically allocated memory before returning.

CID: 1007418
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

Merge ^/head r339015 through r339669.

Remove dead code.

No functional change intended.

MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

Staticize a couple of functions.

No functional change intended.

MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

Remove some obsolete compatibility code.

No functional change intended.

MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

Merge ^/head r325999 through r326131.

General further adoption of SPDX licensing ID tags.

Mainly focus on files that use BSD 3-Clause license.

The Software Package Data Exchange (SPDX) group provides a specification
to make it easier f

General further adoption of SPDX licensing ID tags.

Mainly focus on files that use BSD 3-Clause license.

The Software Package Data Exchange (SPDX) group provides a specification
to make it easier for automated tools to detect and summarize well known
opensource licenses. We are gradually adopting the specification, noting
that the tags are considered only advisory and do not, in any way,
superceed or replace the license texts.

Special thanks to Wind River for providing access to "The Duke of
Highlander" tool: an older (2014) run over FreeBSD tree was useful as a
starting point.

show more ...

MFH

Sponsored by: The FreeBSD Foundation

Merge ^/head r295601 through r295844.