ndp: Bring back the -A option for the netlink implementation

This was lost during the conversion to netlink.

Reviewed by: kp
Fixes: 91fbe0819bb9 ndp: convert ndp(8) to netlink
MFC after: 1 week
Di

ndp: Bring back the -A option for the netlink implementation

This was lost during the conversion to netlink.

Reviewed by: kp
Fixes: 91fbe0819bb9 ndp: convert ndp(8) to netlink
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D47234

show more ...

ndp(8): Complete libxo transition

Reviewed by: des
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D41417

ndp: Fix libxo formatting for the header of neighbor cache

PR: 272749
Reviewed by: zlei
Fixes: e1c7783e220b ndp(8): add structured output formatting via libxo
Fixes: 91fbe0819bb9 ndp: convert ndp

ndp: Fix libxo formatting for the header of neighbor cache

PR: 272749
Reviewed by: zlei
Fixes: e1c7783e220b ndp(8): add structured output formatting via libxo
Fixes: 91fbe0819bb9 ndp: convert ndp(8) to netlink
MFC after: 3 days

show more ...

ndp: improve -c and -d handling in ndp_netlink

This patch restores/fixes some of the behavior present in pre-netlink ndp(8).

1. Deleting a local address now correctly returns EPERM (instead of

ndp: improve -c and -d handling in ndp_netlink

This patch restores/fixes some of the behavior present in pre-netlink ndp(8).

1. Deleting a local address now correctly returns EPERM (instead of
ENOENT)
2. ndp -c no longer dumps the entire table while complaining about
local addresses
3. Return exit code when deleting entry (e.g. trying ndp -d on a local
address is an error)

Reviewed by: kp
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D42316

show more ...

netlink: cope with growing requests

If a request ends up growing beyong the initially allocated space the
netlink functions (such as snl_add_msg_attr_u32()) will allocate a
new buffer. This invalida

netlink: cope with growing requests

If a request ends up growing beyong the initially allocated space the
netlink functions (such as snl_add_msg_attr_u32()) will allocate a
new buffer. This invalidates the header pointer we can have received
from snl_create_msg_request(). Always use the hdr returned by
snl_finalize_msg().

Reviewed by: melifaro
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D42223

show more ...

ndp: cope with unresolved neighbours

If we've not (yet) resolved a neighbour nda_lladdr will be NULL, and
NLA_DATA_LEN(neigh->nda_lladdr) will dereference a NULL pointer.

Avoid that by checking nda

ndp: cope with unresolved neighbours

If we've not (yet) resolved a neighbour nda_lladdr will be NULL, and
NLA_DATA_LEN(neigh->nda_lladdr) will dereference a NULL pointer.

Avoid that by checking nda_lladdr first, and only dereferencing if it's
not NULL.

Test case:
ping6 -c 1 <non-existant neighbour>
ndp -a

Reviewed by: melifaro
MFC after: 3 days
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D41903

show more ...

ndp: Prepare for pending tcpdump update

ndp makes use of gmt2local, however that library has been removed from
tcpdump. Add utc_offset() as a substitute.

Reviewed by: emaste, jhb, melifaro
Sponsor

ndp: Prepare for pending tcpdump update

ndp makes use of gmt2local, however that library has been removed from
tcpdump. Add utc_offset() as a substitute.

Reviewed by: emaste, jhb, melifaro
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D40445

show more ...

netlink: update rta_multipath conditions in arp/ndp after 656a39c1a062

arp/ndp: Use valid prototypes for function declarations with no arguments.

ndp: fix signed/unsigned compariosn in the netlink code.

ndp: convert ndp(8) to netlink.

The change is intended to be fully transparent to the users.
Similarly to route(8) and netstat(8), ndp can be build without
netlink by defining WITHOUT_NETLINK in m

ndp: convert ndp(8) to netlink.

The change is intended to be fully transparent to the users.
Similarly to route(8) and netstat(8), ndp can be build without
netlink by defining WITHOUT_NETLINK in make.conf.

Differential Revision: https://reviews.freebsd.org/D39720

show more ...