mixer: Fix a bogus free() call in the main loop

After a strsep() call, p might not point at the original allocation
anymore.

Reported by: CHERI
Reviewed by: christos
MFC after: 1 week
Differential

mixer: Fix a bogus free() call in the main loop

After a strsep() call, p might not point at the original allocation
anymore.

Reported by: CHERI
Reviewed by: christos
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D47266

show more ...

mixer(8): Implement hot-swapping

Introduce a -V option, which can be used alongside -d (default unit
change), in order to hot-swap devices (i.e switch to them on the fly
without needing to restart t

mixer(8): Implement hot-swapping

Introduce a -V option, which can be used alongside -d (default unit
change), in order to hot-swap devices (i.e switch to them on the fly
without needing to restart the track), in case virtual_oss(8) exists and
is running.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days
Reviewed by: dev_submerge.ch
Differential Revision: https://reviews.freebsd.org/D46253

show more ...

mixer(8): Make mute and recsrc argument parsing more robust

For the deprecated argument interfaces of the mute (1, 0, ^) and recsrc
(+, -, =, ^) controls, we only check the first character of the
ar

mixer(8): Make mute and recsrc argument parsing more robust

For the deprecated argument interfaces of the mute (1, 0, ^) and recsrc
(+, -, =, ^) controls, we only check the first character of the
argument, which means that an argument such as "vol.mute=10" would be
valid. Fix this by checking the whole argument string.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days
Reviewed by: dev_submerge.ch
Differential Revision: https://reviews.freebsd.org/D45973

show more ...

mixer(8): Use mixer_get_path()

Sponsored by: The FreeBSD Foundation
MFC after: 1 day
Reviewed by: dev_submerge.ch
Differential Revision: https://reviews.freebsd.org/D45276

mixer(8): Ignore mixer_open() failures for the -a option

The most likely reason mixer_open() will fail is because either the
device doesn't exist, or because it is disabled, so there is not reason
t

mixer(8): Ignore mixer_open() failures for the -a option

The most likely reason mixer_open() will fail is because either the
device doesn't exist, or because it is disabled, so there is not reason
to kill the application. Instead, continue and print the rest of the
enabled mixers.

PR: 277615
Sponsored by: The FreeBSD Foundation
MFC after: 1 day
Reviewed by: dev_submerge.ch
Differential Revision: https://reviews.freebsd.org/D45151

show more ...

mixer(8): Use new mixer if we change the default unit

If we use the -d option to change the default unit, close the current
mixer and open the one we set as the default to avoid printing and
applyin

mixer(8): Use new mixer if we change the default unit

If we use the -d option to change the default unit, close the current
mixer and open the one we set as the default to avoid printing and
applying changes (if any) to the old one.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks
Reviewed by: dev_submerge.ch, markj
Differential Revision: https://reviews.freebsd.org/D43809

show more ...

mixer(8): Improve mute and recsrc controls

The input options of "dev.mute" (+, -, ^) and "dev.recsrc" (+, -, ^, =)
are quite cryptic. Allow the input to also be an actual description of
what these o

mixer(8): Improve mute and recsrc controls

The input options of "dev.mute" (+, -, ^) and "dev.recsrc" (+, -, ^, =)
are quite cryptic. Allow the input to also be an actual description of
what these options do.

+ -> add (recsrc)
- -> remove (recsrc)
^ -> toggle (recsrc, mute)
= -> set (recsrc)
0 -> off (mute)
1 -> on (mute)

Also, deprecate the use of the symbol options in the EXAMPLES section of
the man page, by using the new descriptive options.

In the future, we might want to get rid of the symbol options
altogether, but preserve backwards compatibility for now.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks
Reviewed by: dev_submerge.ch, imp
Differential Revision: https://reviews.freebsd.org/D43796

show more ...

mixer(8): Allow full PCM device names as input for the -d option

The -d option is a wrapper around hw.snd.default_unit. Currently
mixer(8) expects the option argument to be just the unit's number (e

mixer(8): Allow full PCM device names as input for the -d option

The -d option is a wrapper around hw.snd.default_unit. Currently
mixer(8) expects the option argument to be just the unit's number (e.g
pcm0 -> 0). To avoid confusion, allow full device names of the form
"pcmN" as well.

While here, improve the -d option's description in the man page.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks
Reviewed by: dev_submerge.ch, imp
Differential Revision: https://reviews.freebsd.org/D43794

show more ...

mixer(8): Improve error messsages and warnings

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks
Reviewed by: dev_submerge.ch, imp
Differential Revision: https:

mixer(8): Improve error messsages and warnings

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks
Reviewed by: dev_submerge.ch, imp
Differential Revision: https://reviews.freebsd.org/D43793

show more ...

Remove $FreeBSD$: two-line .h pattern

Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/

mixer: Fix default_unit switching with mixers that have no devices

Apparently it's possible for a mixer to have no devices:

$ mixer -f /dev/mixer2
pcm2:mixer: <USB audio> at ? kld snd_uaudio (rec)

mixer: Fix default_unit switching with mixers that have no devices

Apparently it's possible for a mixer to have no devices:

$ mixer -f /dev/mixer2
pcm2:mixer: <USB audio> at ? kld snd_uaudio (rec)
$

If this is the default sound device, an attempt to change the default
unit using mixer -d fails with a segfault because mod_dunit is called
with a NULL device pointer, which is dereferenced to get the parent
mixer.

ctl_dunit seems to be a dummy, i.e., we don't actually need it and can
simply pass the mixer to mod_dunit() directly. This patch removes that
structure and associated indirection to fix the crash.

Reviewed by: christos, hselasky
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D38060

show more ...

mixer: remove volume backwards compat, add % interpretation

The current situation is fairly confusing, where an integer is interpreted
as a percent until you slap a decimal on it and magically it be

mixer: remove volume backwards compat, add % interpretation

The current situation is fairly confusing, where an integer is interpreted
as a percent until you slap a decimal on it and magically it becomes an
absolute value.

Let's have a flag day in 14.0 and remove this shim entirely. Setting with
percent can still be useful, so allow a trailing '%' to indicate as such.
As a side effect, we tighten down the format allowed in the volume a little
bit by ensuring there's no trailing garbage after the value once it's
separated into left and right components.

Reviewed by: christos, hselasky, pauamma_gundo.com (manpages)
Relnotes: yes
Differential Revision: https://reviews.freebsd.org/D35101

show more ...

mixer(8): Improve shorthand volume parsing.

The initial patch had a bug where the full volume syntax, floating point values,
:, + and -, wasn't accepted.

While at it move some defines to enum's.

F

mixer(8): Improve shorthand volume parsing.

The initial patch had a bug where the full volume syntax, floating point values,
:, + and -, wasn't accepted.

While at it move some defines to enum's.

Fixes: da3d4469ef841be44ac4b346a6b51668d608ed49
Submitted by: christos@
Differential Revision: https://reviews.freebsd.org/D34617
Sponsored by: NVIDIA Networking

show more ...

mixer(8): Add shorthand syntax for setting the volume.

dev.volume=X[.X] can now also be written as dev=X[.X] .

Requested by: hselasky@ and bsduck (FreeBSD forums)
Submitted by: christos@
Differen

mixer(8): Add shorthand syntax for setting the volume.

dev.volume=X[.X] can now also be written as dev=X[.X] .

Requested by: hselasky@ and bsduck (FreeBSD forums)
Submitted by: christos@
Differential Revision: https://reviews.freebsd.org/D34612
Sponsored by: NVIDIA Networking

show more ...

mixer(8): Remove [.volume] string from default printout.

Submitted by: christos@
Differential Revision: https://reviews.freebsd.org/D34591
Sponsored by: NVIDIA Networking

mixer(8): Add -h option to show usage.

Differential Revision: https://reviews.freebsd.org/D32508
Submitted by: christos@
Sponsored by: NVIDIA Networking

mixer(8): Print usage to standard error.

Differential Revision: https://reviews.freebsd.org/D32507
Submitted by: christos@
Sponsored by: NVIDIA Networking

mixer(8): Fix mixer status line for /dev/dspX.vpY mixer devices.

In some cases when passing /dev/dspX.vpY as mixer devices, m->ci.longname and
m->ci.hw_info will be empty. Don't print any brackets a

mixer(8): Fix mixer status line for /dev/dspX.vpY mixer devices.

In some cases when passing /dev/dspX.vpY as mixer devices, m->ci.longname and
m->ci.hw_info will be empty. Don't print any brackets and parentheses
in this case.

Differential Revision: https://reviews.freebsd.org/D32500
Submitted by: christos@
Sponsored by: NVIDIA Networking

show more ...

mixer(8): Compile fix for when the "char" type is unsigned.

Differential Revision: https://reviews.freebsd.org/D31636
Sponsored by: NVIDIA Networking

Implement and use new mixer(3) library for FreeBSD.

Wiki article: https://wiki.freebsd.org/SummerOfCode2021Projects/SoundMixerImprovements
This project was part of Google Summer of Code 2021.

Submi

Implement and use new mixer(3) library for FreeBSD.

Wiki article: https://wiki.freebsd.org/SummerOfCode2021Projects/SoundMixerImprovements
This project was part of Google Summer of Code 2021.

Submitted by: christos@
Differential Revision: https://reviews.freebsd.org/D31636
Sponsored by: NVIDIA Networking

show more ...

Merge ^/head r351317 through r351731.

mixer(8): Report an error if the passed value is an empty string

This patch fixes a bug that made the mixer command enter
an infinite loop when instructed to set the value of a device
to an empty st

mixer(8): Report an error if the passed value is an empty string

This patch fixes a bug that made the mixer command enter
an infinite loop when instructed to set the value of a device
to an empty string (e.g., `mixer vol ""`).

Additionally, some tests for mixer(8) are being added.

PR: 240039
Reviewed by: hselasky, mav
Approved by: src (hselasky, mav)
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D21409

show more ...

Merge ^/head r317503 through r317807.

mixer(8): Prevent possible sscanf() overflow.

Fix %s buffer sizes in sscanf().

Obtained from: DragonflyBSD (git dab952e2)
MFC after: 5 days

mixer(8): Style: Tag no-return usage() as __dead2

Coverity really should have figured this out from the exit(3) call at the end
of the routine, but just make it explicit.

No functional change.

Rep

mixer(8): Style: Tag no-return usage() as __dead2

Coverity really should have figured this out from the exit(3) call at the end
of the routine, but just make it explicit.

No functional change.

Reported by: Coverity
CID: 1304866 (false positive double-close of 'baz')
Sponsored by: EMC / Isilon Storage Division

show more ...