bsdinstall: complete whitelabeling the installer

The commit 147585b4893bc38698aaa971af336b241477eac3 introduces
whitlabeling. This commit addresses couple more places where the
os name was missed.

bsdinstall: complete whitelabeling the installer

The commit 147585b4893bc38698aaa971af336b241477eac3 introduces
whitlabeling. This commit addresses couple more places where the
os name was missed.

Reviewed by: imp, asiciliano, brd
Differential Revision: https://reviews.freebsd.org/D43638

show more ...

Revert "bsdinstall: separate out dist selection in prep for pkgbase support"

Firstly, my review comments were not addressed and instead totally
ignored. Secondly, and a more valid justification for

Revert "bsdinstall: separate out dist selection in prep for pkgbase support"

Firstly, my review comments were not addressed and instead totally
ignored. Secondly, and a more valid justification for the revert, this
completely breaks the installer, since selectdists isn't installed.
Given the blatant lack of testing, back out this commit until it has
actually been tested and review comments taken on board so that the
installer actually works.

This reverts commit 009d3f66cb5f0cf3f1d353f311d3a6878b2a534e.

show more ...

bsdinstall: separate out dist selection in prep for pkgbase support

No functional change intended.

Approved by: asiciliano
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revisio

bsdinstall: separate out dist selection in prep for pkgbase support

No functional change intended.

Approved by: asiciliano
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D43621

show more ...

bsdinstall: rename "Live CD" to "Live System"

This uses more generic wording in the FreeBSD installer, when offering
the user to use the system booted without running the installer.

The updated wor

bsdinstall: rename "Live CD" to "Live System"

This uses more generic wording in the FreeBSD installer, when offering
the user to use the system booted without running the installer.

The updated wording is also reflected in freebsd-version(1).

Reviewed by: emaste
Sponsored by: The FreeBSD Foundation
Differential revision: https://reviews.freebsd.org/D43233

show more ...

bsdinstall: Fix race condition when shutting down after installation

Whilst reboot(8) will block whilst it runs, shutdown(8) does not,
daemonizing instead. This means that we must wait after running

bsdinstall: Fix race condition when shutting down after installation

Whilst reboot(8) will block whilst it runs, shutdown(8) does not,
daemonizing instead. This means that we must wait after running it,
otherwise we will exit and cause the system to attempt to go multi-user
in parallel with the shutdown daemon killing init. With the new
multi-console support in the installer, runconsoles will immediately
kill this daemon, racing with the daemon being able to signal init as
desired, and I have seen this race be lost in QEMU with a single CPU. In
the past this wasn't such an issue, since shutdown's daemon puts itself
in a new session group immediately after fork (and the parent doesn't
wait until that has happened, so whilst there's technically a race
condition in there where it could receive a SIGHUP from the death of the
parent's session leader, in practice this is very unlikely to be hit.
This means that the only consequence of this oversight before was that
you might get the beginnings of more console output on the way to
multi-user and thus the console would look a little confusing.

Reviewed by: gjb
Fixes: e4505364c087 ("release/rc.local: Provide option to shutdown after installation complete")
Fixes: a09af1b7fd95 ("bsdinstall release: Start installer on multiple consoles")
Differential Revision: https://reviews.freebsd.org/D36879

show more ...

bsdinstall release: Start installer on multiple consoles

Currently the installer is only started on the primary ("high level")
console. For systems where this is the video console and serial console

bsdinstall release: Start installer on multiple consoles

Currently the installer is only started on the primary ("high level")
console. For systems where this is the video console and serial consoles
aren't of interest, and headless systems with just a serial console,
this works just fine, but for systems where both video and serial
consoles are present and meaningful this requires the user to select the
right primary console in loader, with the poor user experience of the
system appearing to hang if they leave the wrong one selected. This
notably differs from our multi-user behaviour of spawning getty on every
console, where the only issue with selecting the wrong primary console
is a quieter boot process until the login prompt appears (or the system
crashes).

Instead, use the newly-added runconsoles helper to run the installer on
every console (except for ttyv*, where only ttyv0 will be used). For
interactive installations, any of the consoles can be used, though only
one should be used at a time as no effort is made to avoid multiple
installations running at the same time clobbering each other. If the
Live CD option is selected, the other installers (which should, if the
user is well-behaved, be sitting at the welcome screen) will be killed.
If an automated install is in use, the primary console will be used to
display its output, and the others will direct the user to the primary
console.

Reviewed by: brooks, gjb
Differential Revision: https://reviews.freebsd.org/D36805

show more ...

bsdinstall release: Move code to a new startbsdinstall wrapper

This separates out the install media-specific environment (creating
bsdinstall_etc) from actually running the installer on a given cons

bsdinstall release: Move code to a new startbsdinstall wrapper

This separates out the install media-specific environment (creating
bsdinstall_etc) from actually running the installer on a given console.
This will be used by a future change to start the installer on multiple
consoles.

Reviewed by: brooks, gjb
Differential Revision: https://reviews.freebsd.org/D36803

show more ...