bsdinstall: Create separate datasets for directories in /usr/ports

Both distfiles & packages contain compressed files.

Signed-off-by: Ricardo Branco <rbranco@suse.de>
Reviewed by: imp
Pull Request:

bsdinstall: Create separate datasets for directories in /usr/ports

Both distfiles & packages contain compressed files.

Signed-off-by: Ricardo Branco <rbranco@suse.de>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/1873

show more ...

bsdinstall: Use fat32 EFI system partition for ZFS

This is consistent with other operating systems and with bsdinstall's
UFS config and with bsdinstall's ZFS config prior to commit
0b7472b3d8d2.

Fi

bsdinstall: Use fat32 EFI system partition for ZFS

This is consistent with other operating systems and with bsdinstall's
UFS config and with bsdinstall's ZFS config prior to commit
0b7472b3d8d2.

Fixes: 0b7472b3d8d2 ("Mount the EFI system partition (ESP) on newly-installed systems.")
Reviewed by: imp
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53642

show more ...

bsdinstall: Fix typos

Reviewed by: emaste
MFC after: 2 days
Differential Revision: https://reviews.freebsd.org/D53170

bsdinstall: Add loader.efi to all ESPs we create

For proper redundancy, add copies of loader.efi to each of the ESPs we
create when we create multi-volume ZFS datasets. zfsboot creates a list
of sec

bsdinstall: Add loader.efi to all ESPs we create

For proper redundancy, add copies of loader.efi to each of the ESPs we
create when we create multi-volume ZFS datasets. zfsboot creates a list
of secondary ESPs, while bootpart doesn't create any (it's the UFS
partitioning tool) because we don't supporg UFS over gmirror. The
primary ESP is mounted and is what we use efibootmgr to boot from. The
redundant copies allow the system to boot if the primary disks fails.

Sponsored by: Netflix
MFC After: 2 days
PR: 208802
Reviewed by: cperciva
Differential Revision: https://reviews.freebsd.org/D52780

show more ...

bsdinstall: fix vfs.zfs.vdev.min_auto_ashift oid

Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
PR: 266374
Pull request: https://github.com/freebsd/freebsd-src/pull/1851
Reviewed by: emaste
Sponsor

bsdinstall: fix vfs.zfs.vdev.min_auto_ashift oid

Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
PR: 266374
Pull request: https://github.com/freebsd/freebsd-src/pull/1851
Reviewed by: emaste
Sponsored by: The FreeBSD Foundation

show more ...

bsdinstall: Drop outdated comments about ZFS dataset compression

All datasets on zroot pool are compressed by default since FreeBSD 11.0 [1],
no need to mention that on some specific datasets these

bsdinstall: Drop outdated comments about ZFS dataset compression

All datasets on zroot pool are compressed by default since FreeBSD 11.0 [1],
no need to mention that on some specific datasets these days.

[1] 47206692f2cca020891d1eec5028e02c3e6f56c5

Reviewed by: jrm (mentor), ziaee
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D52304

show more ...

bsdinstall: use the canonical name for compression

According to zfsprops(7), the canonical property for the compression
algorithm is "compression", with "compress" accepted as an alternate
name. Us

bsdinstall: use the canonical name for compression

According to zfsprops(7), the canonical property for the compression
algorithm is "compression", with "compress" accepted as an alternate
name. Use the canonical name in bsdinstall.

While here, change "lz4" to "on" so we pick up any future changes in
the default compression algorithm.

MFC after: 1 week
Reviewed by: delphij
Differential Revision: https://reviews.freebsd.org/D51572

show more ...

bsdinstall: Remove support for ZFS + MBR disk layouts

It hasn't worked for some time -- as reported in review D40816
"Installing FreeBSD with Auto ZFS + MBR has been broken ever since the
move to Op

bsdinstall: Remove support for ZFS + MBR disk layouts

It hasn't worked for some time -- as reported in review D40816
"Installing FreeBSD with Auto ZFS + MBR has been broken ever since the
move to OpenZFS with FreeBSD 13." It relied on the partition table and
ZFS data overlapping in a very fragile way and is not a good idea.

Reviewed by: jhb
Relnotes: Yes
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D51028

show more ...

zfsboot: fix misuse of the phrase zpool

A pool is not a zpool.

Reviewed by: jbh, ivy
Approved by: des (mentor)
MFC after: 1 week
Pull Request: https://github.com/freebsd/freebsd-src/pull/1569

bsdinstall: hook up help line and prompt for ZFS disk selection

Previously we were passing the wrong variable names for the prompt and
help line, so the intended action wasn't clear to the user.

Re

bsdinstall: hook up help line and prompt for ZFS disk selection

Previously we were passing the wrong variable names for the prompt and
help line, so the intended action wasn't clear to the user.

Reviewed by: jhb, markj
MFC after: 3 days
See also: https://github.com/opnsense/installer/issues/22
Pull Request: https://github.com/freebsd/freebsd-src/pull/1579

show more ...

bsdinstall/zfsboot: Remove unused global variable

In an AMA session on the FreeBSD Discord, it was revealed that no
logic remains calling GPART_BOOTCODE_PARTONLY. It was removed in
aa2a0e0fc311 for

bsdinstall/zfsboot: Remove unused global variable

In an AMA session on the FreeBSD Discord, it was revealed that no
logic remains calling GPART_BOOTCODE_PARTONLY. It was removed in
aa2a0e0fc311 for FreeBSD 12. git grep shows no other references.
No functional change intended.

MFC after: 2 weeks
Fixes: aa2a0e0fc311 (Enable new UEFI+GELI support)
Reported by: Antranig Vartanian <antranigv@freebsd.am>
Reviewed by: emaste, mhorne
Approved by: emaste, mhorne (src)
Approved by: mhorne, carlavilla (mentors)
Differential Revision: https://reviews.freebsd.org/D48086

show more ...

bsdinstall: Fix a typo in a comment

PR: 283507
MFC after: 1 week

bsdinstall zfsboot: Add an option to edit the ZFS pool creation options

This allows the default options (-O compress=lz4 -O atime=off) to be
overridden, before the ZFS boot pool is created. For exam

bsdinstall zfsboot: Add an option to edit the ZFS pool creation options

This allows the default options (-O compress=lz4 -O atime=off) to be
overridden, before the ZFS boot pool is created. For example, to set the
compression algorithm to something different.

Reviewed by: jhb, dim
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D47478

show more ...

bsdinstall zfsboot: Don't override ZFSBOOT_FORCE_4K_SECTORS if it is null.

Only set a default value of 1 if the shell variable is unset. This allows
installer scripts to disable the variable.

PR:

bsdinstall zfsboot: Don't override ZFSBOOT_FORCE_4K_SECTORS if it is null.

Only set a default value of 1 if the shell variable is unset. This allows
installer scripts to disable the variable.

PR: 274513
Reported by: Albin "a12l" Otterhäll <bugs.freebsd.org@a12l.xyz>
Differential Revision: https://reviews.freebsd.org/D42319

show more ...

bsdinstall: Fix command line argument list parsing

bsddialog(1) uses getopt_long(3) to parse command line argument list.
Add '--' to avoid errors caused by arguments (menu items) begin
with '-'.
The

bsdinstall: Fix command line argument list parsing

bsddialog(1) uses getopt_long(3) to parse command line argument list.
Add '--' to avoid errors caused by arguments (menu items) begin
with '-'.
The change is compatible with dialog(1) and Xdialog(1).

show more ...

Remove $FreeBSD$: one-line sh pattern

Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/

bsdinstall on zfs: create dataset for /home rather than /usr/home

Now that pw (hence adduser and the initial install) use /home for
user home directories rather than /usr/home, create a dataset for

bsdinstall on zfs: create dataset for /home rather than /usr/home

Now that pw (hence adduser and the initial install) use /home for
user home directories rather than /usr/home, create a dataset for
/home rather than /usr/home. Update the man page to match.

Reviewed by: rgrimes, markj
Differential Revision: https://reviews.freebsd.org/D40086

show more ...

bsdinstall: s/to small/too small/

Reported by: Sulev-Madis Silber <ketas@si.pri.ee>

bsdinstall: improve zfsboots ability to handle datasets under a BE

Currently we only set canmount=noauto on the root of the BE, this
change makes it so we set it on all datasets under the BE as well

bsdinstall: improve zfsboots ability to handle datasets under a BE

Currently we only set canmount=noauto on the root of the BE, this
change makes it so we set it on all datasets under the BE as well.

Reviewed by: allanjude
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D35422

show more ...

Fix a memory leak from caf73e58579

Don't shadow an already-local variable with another local declaration.

Reported by: dteske
MFC after: 13 days
MFC with: caf73e58579343fc1661f43554b30115bb940535
S

Fix a memory leak from caf73e58579

Don't shadow an already-local variable with another local declaration.

Reported by: dteske
MFC after: 13 days
MFC with: caf73e58579343fc1661f43554b30115bb940535
Sponsored by: Axcient
Differential Revision: https://reviews.freebsd.org/D35331

show more ...

bsdinstall: fix prepopulating the ZFS disk menu with ZFSBOOT_DISKS

If the ZFSBOOT_DISKS variable is set to one or more disk names, then
those disks should be preselected in the disk menu. However,

bsdinstall: fix prepopulating the ZFS disk menu with ZFSBOOT_DISKS

If the ZFSBOOT_DISKS variable is set to one or more disk names, then
those disks should be preselected in the disk menu. However, the code
wasn't correctly setting the variable, leaving all disks unselected.

MFC after: 2 weeks
Sponsored by: Axcient
Reviewed by: dteske
Differential Revision: https://reviews.freebsd.org/D35331

show more ...

bsdinstall: use gpt/efiboot0 label in /etc/fstab

Otherwise, boot will hang if the numbering of disks has changed since
initial install.

MFC after: 2 weeks
Sponsored by: Axcient
Reviewed by: brd
Dif

bsdinstall: use gpt/efiboot0 label in /etc/fstab

Otherwise, boot will hang if the numbering of disks has changed since
initial install.

MFC after: 2 weeks
Sponsored by: Axcient
Reviewed by: brd
Differential Revision: https://reviews.freebsd.org/D35309

show more ...

bsdinstall: allow whitelabeling the scripts

Approved by: allanjude, asiciliano
Differential Revision: https://reviews.freebsd.org/D35197
Sponsored by: Rubicon Communications, LLC ("Netgate")

bsdinstall: filter out disks that are unavailable from the list of options in ZFS

Reviewed by: allanjude, rew
Differential Revision: https://reviews.freebsd.org/D34167
Sponsored by: Rubicon Communic

bsdinstall: filter out disks that are unavailable from the list of options in ZFS

Reviewed by: allanjude, rew
Differential Revision: https://reviews.freebsd.org/D34167
Sponsored by: Rubicon Communications, LLC ("Netgate")

show more ...

Remove extraneous semicolons trailing break and continue statements.