bsdinstall: use the canonical name for compression

According to zfsprops(7), the canonical property for the compression
algorithm is "compression", with "compress" accepted as an alternate
name. Us

bsdinstall: use the canonical name for compression

According to zfsprops(7), the canonical property for the compression
algorithm is "compression", with "compress" accepted as an alternate
name. Use the canonical name in bsdinstall.

While here, change "lz4" to "on" so we pick up any future changes in
the default compression algorithm.

MFC after: 1 week
Reviewed by: delphij
Differential Revision: https://reviews.freebsd.org/D51572

show more ...

bsdinstall: Remove support for ZFS + MBR disk layouts

It hasn't worked for some time -- as reported in review D40816
"Installing FreeBSD with Auto ZFS + MBR has been broken ever since the
move to Op

bsdinstall: Remove support for ZFS + MBR disk layouts

It hasn't worked for some time -- as reported in review D40816
"Installing FreeBSD with Auto ZFS + MBR has been broken ever since the
move to OpenZFS with FreeBSD 13." It relied on the partition table and
ZFS data overlapping in a very fragile way and is not a good idea.

Reviewed by: jhb
Relnotes: Yes
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D51028

show more ...

zfsboot: fix misuse of the phrase zpool

A pool is not a zpool.

Reviewed by: jbh, ivy
Approved by: des (mentor)
MFC after: 1 week
Pull Request: https://github.com/freebsd/freebsd-src/pull/1569

bsdinstall: hook up help line and prompt for ZFS disk selection

Previously we were passing the wrong variable names for the prompt and
help line, so the intended action wasn't clear to the user.

Re

bsdinstall: hook up help line and prompt for ZFS disk selection

Previously we were passing the wrong variable names for the prompt and
help line, so the intended action wasn't clear to the user.

Reviewed by: jhb, markj
MFC after: 3 days
See also: https://github.com/opnsense/installer/issues/22
Pull Request: https://github.com/freebsd/freebsd-src/pull/1579

show more ...

bsdinstall/zfsboot: Remove unused global variable

In an AMA session on the FreeBSD Discord, it was revealed that no
logic remains calling GPART_BOOTCODE_PARTONLY. It was removed in
aa2a0e0fc311 for

bsdinstall/zfsboot: Remove unused global variable

In an AMA session on the FreeBSD Discord, it was revealed that no
logic remains calling GPART_BOOTCODE_PARTONLY. It was removed in
aa2a0e0fc311 for FreeBSD 12. git grep shows no other references.
No functional change intended.

MFC after: 2 weeks
Fixes: aa2a0e0fc311 (Enable new UEFI+GELI support)
Reported by: Antranig Vartanian <antranigv@freebsd.am>
Reviewed by: emaste, mhorne
Approved by: emaste, mhorne (src)
Approved by: mhorne, carlavilla (mentors)
Differential Revision: https://reviews.freebsd.org/D48086

show more ...

bsdinstall: Fix a typo in a comment

PR: 283507
MFC after: 1 week

bsdinstall zfsboot: Add an option to edit the ZFS pool creation options

This allows the default options (-O compress=lz4 -O atime=off) to be
overridden, before the ZFS boot pool is created. For exam

bsdinstall zfsboot: Add an option to edit the ZFS pool creation options

This allows the default options (-O compress=lz4 -O atime=off) to be
overridden, before the ZFS boot pool is created. For example, to set the
compression algorithm to something different.

Reviewed by: jhb, dim
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D47478

show more ...

bsdinstall zfsboot: Don't override ZFSBOOT_FORCE_4K_SECTORS if it is null.

Only set a default value of 1 if the shell variable is unset. This allows
installer scripts to disable the variable.

PR:

bsdinstall zfsboot: Don't override ZFSBOOT_FORCE_4K_SECTORS if it is null.

Only set a default value of 1 if the shell variable is unset. This allows
installer scripts to disable the variable.

PR: 274513
Reported by: Albin "a12l" Otterhäll <bugs.freebsd.org@a12l.xyz>
Differential Revision: https://reviews.freebsd.org/D42319

show more ...

bsdinstall: Fix command line argument list parsing

bsddialog(1) uses getopt_long(3) to parse command line argument list.
Add '--' to avoid errors caused by arguments (menu items) begin
with '-'.
The

bsdinstall: Fix command line argument list parsing

bsddialog(1) uses getopt_long(3) to parse command line argument list.
Add '--' to avoid errors caused by arguments (menu items) begin
with '-'.
The change is compatible with dialog(1) and Xdialog(1).

show more ...

Remove $FreeBSD$: one-line sh pattern

Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/

bsdinstall on zfs: create dataset for /home rather than /usr/home

Now that pw (hence adduser and the initial install) use /home for
user home directories rather than /usr/home, create a dataset for

bsdinstall on zfs: create dataset for /home rather than /usr/home

Now that pw (hence adduser and the initial install) use /home for
user home directories rather than /usr/home, create a dataset for
/home rather than /usr/home. Update the man page to match.

Reviewed by: rgrimes, markj
Differential Revision: https://reviews.freebsd.org/D40086

show more ...

bsdinstall: s/to small/too small/

Reported by: Sulev-Madis Silber <ketas@si.pri.ee>

bsdinstall: improve zfsboots ability to handle datasets under a BE

Currently we only set canmount=noauto on the root of the BE, this
change makes it so we set it on all datasets under the BE as well

bsdinstall: improve zfsboots ability to handle datasets under a BE

Currently we only set canmount=noauto on the root of the BE, this
change makes it so we set it on all datasets under the BE as well.

Reviewed by: allanjude
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D35422

show more ...

Fix a memory leak from caf73e58579

Don't shadow an already-local variable with another local declaration.

Reported by: dteske
MFC after: 13 days
MFC with: caf73e58579343fc1661f43554b30115bb940535
S

Fix a memory leak from caf73e58579

Don't shadow an already-local variable with another local declaration.

Reported by: dteske
MFC after: 13 days
MFC with: caf73e58579343fc1661f43554b30115bb940535
Sponsored by: Axcient
Differential Revision: https://reviews.freebsd.org/D35331

show more ...

bsdinstall: fix prepopulating the ZFS disk menu with ZFSBOOT_DISKS

If the ZFSBOOT_DISKS variable is set to one or more disk names, then
those disks should be preselected in the disk menu. However,

bsdinstall: fix prepopulating the ZFS disk menu with ZFSBOOT_DISKS

If the ZFSBOOT_DISKS variable is set to one or more disk names, then
those disks should be preselected in the disk menu. However, the code
wasn't correctly setting the variable, leaving all disks unselected.

MFC after: 2 weeks
Sponsored by: Axcient
Reviewed by: dteske
Differential Revision: https://reviews.freebsd.org/D35331

show more ...

bsdinstall: use gpt/efiboot0 label in /etc/fstab

Otherwise, boot will hang if the numbering of disks has changed since
initial install.

MFC after: 2 weeks
Sponsored by: Axcient
Reviewed by: brd
Dif

bsdinstall: use gpt/efiboot0 label in /etc/fstab

Otherwise, boot will hang if the numbering of disks has changed since
initial install.

MFC after: 2 weeks
Sponsored by: Axcient
Reviewed by: brd
Differential Revision: https://reviews.freebsd.org/D35309

show more ...

bsdinstall: allow whitelabeling the scripts

Approved by: allanjude, asiciliano
Differential Revision: https://reviews.freebsd.org/D35197
Sponsored by: Rubicon Communications, LLC ("Netgate")

bsdinstall: filter out disks that are unavailable from the list of options in ZFS

Reviewed by: allanjude, rew
Differential Revision: https://reviews.freebsd.org/D34167
Sponsored by: Rubicon Communic

bsdinstall: filter out disks that are unavailable from the list of options in ZFS

Reviewed by: allanjude, rew
Differential Revision: https://reviews.freebsd.org/D34167
Sponsored by: Rubicon Communications, LLC ("Netgate")

show more ...

Remove extraneous semicolons trailing break and continue statements.

bsdinstall: zfsboot: Prompt user for zpool name if the pool already exists

If one install FreeBSD on multiple disks (say 13 and CURRENT) the first created
pool will always be used.
Prompt the user f

bsdinstall: zfsboot: Prompt user for zpool name if the pool already exists

If one install FreeBSD on multiple disks (say 13 and CURRENT) the first created
pool will always be used.
Prompt the user for a new pool name if we detect that the default or supplied one
already exists.

Reviewed by: imp
MFC after: 2 weeks
Sponsored by: Beckhoff Automation GmbH & Co. KG
Differential Revision: https://reviews.freebsd.org/D33331

show more ...

Allows user to specify an optional ZFSBOOT_POOL_SIZE for their zroot

The default is to create a zroot that consumes the whole disk because if
used with geli(8) this makes sense.

Without geli(8), I

Allows user to specify an optional ZFSBOOT_POOL_SIZE for their zroot

The default is to create a zroot that consumes the whole disk because if
used with geli(8) this makes sense.

Without geli(8), I like to keep my data pool separate from my system
pool.

This is different than ZFSBOOT_BOOT_POOL_SIZE which is named bootpool.

Reviewed by: allenjude
Pull Request: https://github.com/freebsd/freebsd-src/pull/53
Differential Revision: https://reviews.freebsd.org/D30588

show more ...

Mount the EFI system partition (ESP) on newly-installed systems.

Per hier(7), the ESP will be mounted at /boot/efi. On UFS systems,
any existing ESP will be reused and mounted there; otherwise, a ne

Mount the EFI system partition (ESP) on newly-installed systems.

Per hier(7), the ESP will be mounted at /boot/efi. On UFS systems,
any existing ESP will be reused and mounted there; otherwise, a new one
will be made. On ZFS systems, space for an ESP is allocated on all disks
in the root pool, but only the partition actually used to boot is set up
and mounted.

This makes future upgrades of the EFI loader easier (upgrade scripts can
just change /boot/efi) and also greatly simplifies the parts of the
installer involved in initialization of the ESP. It also makes the
installer's behavior correspond to the documentation in hier(7).

Reviewed by: imp, tsoome
MFC after: 1 week
Relnotes: yes
Differential Revision: https://reviews.freebsd.org/D28897

show more ...

bsdinstall: riscv-specific tweaks

Make the installer more useful, by allowing it to create a bootable
installation. Also, enable the menu option for ZFS-on-root.

Like arm64, RISC-V boots by UEFI on

bsdinstall: riscv-specific tweaks

Make the installer more useful, by allowing it to create a bootable
installation. Also, enable the menu option for ZFS-on-root.

Like arm64, RISC-V boots by UEFI only, so arm64's partedit
implementation is renamed and shared among the two platforms.

Reviewed by: gjb
MFC after: 5 days
Differential Revision: https://reviews.freebsd.org/D28180

show more ...

bsdinstall: Use TMPDIR if set

Submitted by: Ryan Moeller <ryan@freqlabs.com>
Reviewed by: bcran, Nick Wolff <darkfiberiru@gmail.com>
Differential Revision: https://reviews.freebsd.org/D22979/

Merge ^/head r353316 through r353350.