bsdinstall: wlanconfig: ensure the interface is always up for scanning

Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Reviewed by: thj (earlier), emaste
Differential Revision: https://review

bsdinstall: wlanconfig: ensure the interface is always up for scanning

Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Reviewed by: thj (earlier), emaste
Differential Revision: https://reviews.freebsd.org/D51312

show more ...

bsdinstall: wlanconfig: properly format regdomain dialog input

Without the extra '\n' the dual-column ('REGD' '') are not properly
separated for dialog which leads to an [misleading] error hidden on

bsdinstall: wlanconfig: properly format regdomain dialog input

Without the extra '\n' the dual-column ('REGD' '') are not properly
separated for dialog which leads to an [misleading] error hidden on
the command line:
Error: --menu bad arguments items number.
[Writing this I wonder why the dual-column input is needed].

It is still unclear as to where the error message quoted in PR287538
suddenly came from for 14.3-RELEASE given the code was broken since 2016
(or noone ever noticed or reported).

Looking at manual ifconfig output:
ifconfig wlan0 country GB regdomain Expected
-> ifconfig: unknown regdomain Expected
and "ifconfig: " gets stripped by the script, which means the regdomain
variable would have to be set to "Expected" or more likely to
"Expected eval: Use: not found" which looks like a concatination of
errors.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Fixes: 95ee591e83a91
PR: 287538
Reviewed by: emaste, thj
Differential Revision: https://reviews.freebsd.org/D51313

show more ...

bsdinstall: wlanconfig: fix interface UP on (re-)starting wpa_supplicant

Make sure an interface is back up before (re-)starting wpa_supplicant
in wlanconfig not relying on wpa to UP the interface (t

bsdinstall: wlanconfig: fix interface UP on (re-)starting wpa_supplicant

Make sure an interface is back up before (re-)starting wpa_supplicant
in wlanconfig not relying on wpa to UP the interface (though we fixed
that).

Sponsored by: The FreeBSD Foundation
Reviewed by: emaste (in D47491)
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D47491

show more ...

bsdinstall: Fix wifi network selection size

Use correct variable while creating dialog used to select among
available wireless networks

Approved by: asiciliano
Sponsored by: Rubicon Communications,

bsdinstall: Fix wifi network selection size

Use correct variable while creating dialog used to select among
available wireless networks

Approved by: asiciliano
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D45271

show more ...

Remove $FreeBSD$: one-line sh pattern

Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/

bsdinstall: allow whitelabeling the scripts

Approved by: allanjude, asiciliano
Differential Revision: https://reviews.freebsd.org/D35197
Sponsored by: Rubicon Communications, LLC ("Netgate")

wlanconfig: allow to enter WiFi details if no networks found

Improve the installer: wlanconfig allows user to enter WiFi details
if no networks found, useful to connect to a hidden SSID.

PR: 2461

wlanconfig: allow to enter WiFi details if no networks found

Improve the installer: wlanconfig allows user to enter WiFi details
if no networks found, useful to connect to a hidden SSID.

PR: 246192
Reported by: emaste
Approved by: bapt (mentor)
Differential Revision: https://reviews.freebsd.org/D34149

show more ...

Fix indentation in bsdinstall-created wpa_supplicant.conf

PR: base/221982
Reported by: emaste
Reviewed by: emaste, allanjude
MFC after: 0 days
X-MFC-to: stable/11
Differential Revision: https://rev

Fix indentation in bsdinstall-created wpa_supplicant.conf

PR: base/221982
Reported by: emaste
Reviewed by: emaste, allanjude
MFC after: 0 days
X-MFC-to: stable/11
Differential Revision: https://reviews.freebsd.org/D23641

show more ...

Merge ^/head r325999 through r326131.

Fix indentation in bsdinstall-created wpa_supplicant.conf

r309934 cleaned up some cases in bsdinstall to use heredocs but broke
the indentation of the generated output, because <<- heredocs strip
le

Fix indentation in bsdinstall-created wpa_supplicant.conf

r309934 cleaned up some cases in bsdinstall to use heredocs but broke
the indentation of the generated output, because <<- heredocs strip
leading tabs.

PR: 221982
Reviewed by: allanjude, dteske
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D13190

show more ...

Merge ^/head r309817 through r310168.

Revert r309918 -- modern POSIX has deprecated -<#>/+<#> syntax

Special thanks to: jilles

It's completely pointless to replace newlines with space
(this is done automatically for you upon shell expansion)

The flags of a WLAN need to be quoted (they contain things like brackets)

Simplify single-line if statements

Simplify loop by moving predicate to clause

Wordsmithing

Why test $? when you can test the command

Restore previous comment

Both simplify bringup of interface after changes and catch errors in debug

Calculate proper size of menu list dialog

There's an API function for catching errors and displaying them or
logging them to debug output

There's an API function for displaying pauses

There's an API function for displaying yes/no dialogs

There's an API function for displaying errors