top: Avoid printing a blank line when the ZFS ARC is empty

PR: 275994
MFC after: 2 weeks

Remove $FreeBSD$: two-line .h pattern

Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/

top(8): restore erronously removed SWAIT array element

due to bad rebase.

Noted by: kevans
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Fixes: 6a5e6a50bd55c3fb4933abe1edaad3a928700c42ESC

top(8): add missed SLOCK state to the sorted_state[]

Put it near/after the sleep state.

Noted by: Mark Millard <marklmi@yahoo.com>
Reviewed by: kevans
Sponsored by: The FreeBSD Foundation
MFC after

top(8): add missed SLOCK state to the sorted_state[]

Put it near/after the sleep state.

Noted by: Mark Millard <marklmi@yahoo.com>
Reviewed by: kevans
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D40607

show more ...

top(8): document the actual sort order for process sorting

Noted by: Mark Millard <marklmi@yahoo.com>
Reviewed by: kevans
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision

top(8): document the actual sort order for process sorting

Noted by: Mark Millard <marklmi@yahoo.com>
Reviewed by: kevans
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D40607

show more ...

top(8): use designated initializers for sorted_state[]

Also correct comments for individual state, duplicating the S* constants
descriptions from sys/proc.h [*].

Reviewed by: kevans (previous versi

top(8): use designated initializers for sorted_state[]

Also correct comments for individual state, duplicating the S* constants
descriptions from sys/proc.h [*].

Reviewed by: kevans (previous version)
Noted by: Mark Millard <marklmi@yahoo.com> [*]
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D40607

show more ...

top(8): designate the sorted_state[] array as constant

Reviewed by: kevans
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D40607

top: Use a cpuset_t to represent a CPU mask

The code attempts to detect holes in the CPU ID space, but previously
this would only work for up to sizeof(long)*8 CPUs.

MFC after: 2 weeks

top: fix sorting by pid (-o pid)

The 'pid' order was added, but the equivalent comparator was not back in
8b800d3af2d8c ("Add the PID column to the list of sort keys.").
`ordernames` indices need to

top: fix sorting by pid (-o pid)

The 'pid' order was added, but the equivalent comparator was not back in
8b800d3af2d8c ("Add the PID column to the list of sort keys.").
`ordernames` indices need to match `compares` indices in order for this
to work.

A future commit will restructure all of this to make it less error prone
going forward (see D37083).

MFC after: 3 days
Reviewed by: pstef (D37083)

show more ...

top: Remove a duplicate extern declaration for show_args.

This fixes a -Wnested-extern error with GCC 9. There is an existing
extern declaration in top.h.

Reviewed by: imp, emaste
Differential Rev

top: Remove a duplicate extern declaration for show_args.

This fixes a -Wnested-extern error with GCC 9. There is an existing
extern declaration in top.h.

Reviewed by: imp, emaste
Differential Revision: https://reviews.freebsd.org/D31937

show more ...

top(1): support command name and argument grepping

Obtained from: OpenBSD
Reviewed by: imp@
Pull Request: https://github.com/freebsd/freebsd-src/pull/479

MFH

Sponsored by: Rubicon Communications, LLC (netgate.com)

top: VIS_SAFE turned out to be unsafe

Unset VIS_SAFE flag as it turned out to be actually unsafe
for continuos top display as it's passing through sequences
resulting cursor movement (backspace, tab

top: VIS_SAFE turned out to be unsafe

Unset VIS_SAFE flag as it turned out to be actually unsafe
for continuos top display as it's passing through sequences
resulting cursor movement (backspace, tab, carriage-return),
and explicitly set VIS_TAB for the same reason.

Reported by: Mark Millard <marklmi@yahoo.com>, swills
Tested by: Mark Millard <marklmi@yahoo.com>, swills

show more ...

top: do not try to use sysctl machdep.smp_active.

The sysctl was removed by r76078 in 2001.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

top: display battery capacity remaining

Submitted by: Antranig Vartanian <antranigv@freebsd.am>
Reviewed by: imp, philip
Differential Revision: https://reviews.freebsd.org/D22871

Merge ^/head r352537 through r352586.

top(1): support multibyte characters in command names (ARGV array)
depending on locale.

- add setlocale()
- remove printable() function
- add VIS_OCTAL and VIS_SAFE to the flag of strvisx() to di

top(1): support multibyte characters in command names (ARGV array)
depending on locale.

- add setlocale()
- remove printable() function
- add VIS_OCTAL and VIS_SAFE to the flag of strvisx() to display
non-printable characters that do not use C-style backslash sequences
in three digit octal sequence, or remove it

This change allows multibyte characters to be displayed according to
locale. If it is recognized as a non-display character according to the
locale, it is displayed in three digit octal sequence.

Reference:
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165751.html
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165766.html
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165833.html
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165846.html
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165891.html

Submitted by: hrs
Differential Revision: https://reviews.freebsd.org/D16204

show more ...

MFHead @349476

Sponsored by: The FreeBSD Foundation

top(1): Don't show the swap line when there are no swap devices

Submitted by: antranigv@freebsd.am
Reviewed by: bapt
MFC after: 1 month
Sponsored by: Klara Systems
Differential Revision: https://rev

top(1): Don't show the swap line when there are no swap devices

Submitted by: antranigv@freebsd.am
Reviewed by: bapt
MFC after: 1 month
Sponsored by: Klara Systems
Differential Revision: https://reviews.freebsd.org/D18928

show more ...

Merge ^/head r343956 through r344177.

Fix multiple warnings in usr.bin/top about discarded qualifiers from
both clang and gcc, by either constifying variables, or when that is not
possible, using __DECONST.

MFC after: 1 week

Merge ^/head r338298 through r338391.

Fix column alignment in per-thread mode.

PR: 230872
Approved by: re (marius)
MFC after: 1 week

Merge ^/head r337646 through r338014.

fix top after arc accounting change