usr.bin/top: fix displaying load average for loads of at least 100

After top registers load average of at least 100 which then gets reduced to
below 100, there are left stray digits.
Supporting load

usr.bin/top: fix displaying load average for loads of at least 100

After top registers load average of at least 100 which then gets reduced to
below 100, there are left stray digits.
Supporting load over 100 requires increasing the width only to 6, but since
we support over 1000 CPU's now, let's increase it to 7.

Reviewed by: kib
Differential Revision: https://reviews.freebsd.org/D45284

show more ...

Remove $FreeBSD$: two-line .h pattern

Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/

top: display battery capacity remaining

Submitted by: Antranig Vartanian <antranigv@freebsd.am>
Reviewed by: imp, philip
Differential Revision: https://reviews.freebsd.org/D22871

Merge ^/head r352537 through r352586.

top(1): support multibyte characters in command names (ARGV array)
depending on locale.

- add setlocale()
- remove printable() function
- add VIS_OCTAL and VIS_SAFE to the flag of strvisx() to di

top(1): support multibyte characters in command names (ARGV array)
depending on locale.

- add setlocale()
- remove printable() function
- add VIS_OCTAL and VIS_SAFE to the flag of strvisx() to display
non-printable characters that do not use C-style backslash sequences
in three digit octal sequence, or remove it

This change allows multibyte characters to be displayed according to
locale. If it is recognized as a non-display character according to the
locale, it is displayed in three digit octal sequence.

Reference:
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165751.html
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165766.html
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165833.html
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165846.html
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165891.html

Submitted by: hrs
Differential Revision: https://reviews.freebsd.org/D16204

show more ...

MFHead @349476

Sponsored by: The FreeBSD Foundation

top(1): Don't show the swap line when there are no swap devices

Submitted by: antranigv@freebsd.am
Reviewed by: bapt
MFC after: 1 month
Sponsored by: Klara Systems
Differential Revision: https://rev

top(1): Don't show the swap line when there are no swap devices

Submitted by: antranigv@freebsd.am
Reviewed by: bapt
MFC after: 1 month
Sponsored by: Klara Systems
Differential Revision: https://reviews.freebsd.org/D18928

show more ...

MFHead@r345880

Fix regression in top(1) after r344381, causing informational messages
to no longer be displayed. This was because the reimplementation of
setup_buffer() did not copy the previous contents into any

Fix regression in top(1) after r344381, causing informational messages
to no longer be displayed. This was because the reimplementation of
setup_buffer() did not copy the previous contents into any reallocated
buffer.

Reported by: James Wright <james.wright@jigsawdezign.com>
PR: 236947
MFC after: 3 days

show more ...

MFhead@r344527

Merge ^/head r344178 through r344512.

Fix more AddressSanitizer violations in usr.bin/top

In line_update(), set lastcol correctly after moving to any non-zero
column, so the "overwrite old stuff" part does not attempt to address
negativ

Fix more AddressSanitizer violations in usr.bin/top

In line_update(), set lastcol correctly after moving to any non-zero
column, so the "overwrite old stuff" part does not attempt to address
negative offsets in the current line.

Rewrite setup_buffer() to always allocate at least 80 characters,
otherwise various calls to summary_format() will overwrite the end of
the buffers, if the screen width gets small enough.

MFC after: 1 week

show more ...

Merge ^/head r343956 through r344177.

Fix the first couple of AddressSanitizer violations in usr.bin/top.

Avoid setting zero bytes beyond the length of the 'thisline' parameters
in i_process() and u_process(), and don't attempt to memse

Fix the first couple of AddressSanitizer violations in usr.bin/top.

Avoid setting zero bytes beyond the length of the 'thisline' parameters
in i_process() and u_process(), and don't attempt to memset a negative
number of bytes.

MFC after: 1 week

show more ...

Fix multiple warnings in usr.bin/top about discarded qualifiers from
both clang and gcc, by either constifying variables, or when that is not
possible, using __DECONST.

MFC after: 1 week

Merge ^/head r338026 through r338297, and resolve conflicts.

top(1): Use warnx and errx instead of fprintf

This also makes make "-v" exit without error, since it isn't.

MFH @ r337607, in preparation for boarding

top(1): fix a buffer overflow copying states to display while they were incremented

- fix an AddressSanitizer error

Submitted by: devnexen@gmail.com
Reviewed by: eadler
Approved by: gnn (mentor)

top(1): fix a buffer overflow copying states to display while they were incremented

- fix an AddressSanitizer error

Submitted by: devnexen@gmail.com
Reviewed by: eadler
Approved by: gnn (mentor)
Differential Revision: https://reviews.freebsd.org/D16183

show more ...

Fix thread state summary line display after r334918.

top(1): rollback r335836

Encoding-specific processing introduced in r335836 is not recommended.
And doing getenv("LANG") and assuming an encoding based on it is a
very bad practice to internationali

top(1): rollback r335836

Encoding-specific processing introduced in r335836 is not recommended.
And doing getenv("LANG") and assuming an encoding based on it is a
very bad practice to internationalize software.

Submitted by: hrs
Differential Revision: https://reviews.freebsd.org/D16203

show more ...

top(1): Fix the prompt bug and core dump problem in o / p mode that occurred by r336028

Reviewed by: cy
Approved by: gnn (mentor)
Differential Revision: https://reviews.freebsd.org/D16174

r336028 changed next_msg to a char * from char [] of fixed size. Change
2nd argument of vsnprintf() to get the strlen of next_msg so that the
appropriate size is used.

Found with gcc.

/usr.bin/top

r336028 changed next_msg to a char * from char [] of fixed size. Change
2nd argument of vsnprintf() to get the strlen of next_msg so that the
appropriate size is used.

Found with gcc.

/usr.bin/top/display.c: In function 'new_message':
/usr.bin/top/display.c:963:31: error:
argument to 'sizeof' in 'vsnprintf' call is the same expression as the
destination; did you mean to provide an explicit length?
[-Werror=sizeof-pointer-memaccess]
vsnprintf(next_msg, sizeof(next_msg), msgfmt, args);

Reviewed by: daichi

show more ...

Changed to eliminate the upper limit of command length displayed
by "-a" and expand to match terminal width

Reviewed by: eadler
Approved by: gnn (mentor)
Differential Revision: https://reviews.freeb

Changed to eliminate the upper limit of command length displayed
by "-a" and expand to match terminal width

Reviewed by: eadler
Approved by: gnn (mentor)
Differential Revision: https://reviews.freebsd.org/D16083

show more ...

top(1) - support UTF-8 display

Reviewed by: eadler
Approved by: gnn (mentor)
Differential Revision: https://reviews.freebsd.org/D16006