Use a more sensible default of 1 or -1 when only the start and
end values are specified.

PR: bin/68981
Submitted by: Stefan `Sec` Zehl
MFC after: 2 weeks

Do What I Mean when the user asks for random integers or characters.
Up to now jot would fail to generate the last character in the range
or skew the integer distribution in a way that would generate

Do What I Mean when the user asks for random integers or characters.
Up to now jot would fail to generate the last character in the range
or skew the integer distribution in a way that would generate the numbers
in the range's limits with half the probability of the rest.

This modification fixes the program, rather than documenting the
strange behavior, as suggested in docs/54879.

Also, correctly specify the range of random(3).

PR: docs/54879
MFC after: 2 weeks

show more ...

Avoid negative array indices: an empty string can also be used
to specify a default value.

Restore jot's ability to use a seed for producing a deterministic
sequence of random numbers.
This functionality was lost in revision 1.9 when the random number
generator was switched to arc4random.

Restore jot's ability to use a seed for producing a deterministic
sequence of random numbers.
This functionality was lost in revision 1.9 when the random number
generator was switched to arc4random.

PR: docs/54879
MFC after: 2 weeks

show more ...

Replace obscure aliases through pointers with plain variables.

MFC after: 2 weeks

Merge code in common cases.

Verified by: New regression tests in tools/regression/usr.bin/jot
MFC after: 2 weeks

Replace opaque numeric bit flag values with #defined identifiers.
While there, add some missing FALLTHROUGH comments.

Verified with: cmp(1) on the executable
MFC after: 2 weeks

Avoid passing negative values to <ctype.h> functions on machines with
signed chars.

Fix jot so that 'jot -r -w %d 1 1 4' never prints 4. Previously, it
would print it with probability 1/2**32. It seems that the correct
behavior is to print 4 with probability 1/4, but I'd like to a

Fix jot so that 'jot -r -w %d 1 1 4' never prints 4. Previously, it
would print it with probability 1/2**32. It seems that the correct
behavior is to print 4 with probability 1/4, but I'd like to avoid
breaking POLA until all the range inconsistencies in jot can be fixed
in one pass. See PR for details.

PR: 54878
Submitted by: David Brinegar <jot.3.brinegar@spamgourmet.com>

show more ...

Don't depend on pollution in <limits.h> for the definition of
<stdint.h> macros.

Consistently use FBSDID

Remove local prototype for main().

Protoize. Remove un-needed cast to char in switch of getopt(3)'s return value.
FBSDID.

remove __P

Actually, arc4random() returns a uint32_t, not an int. Use the correct
constant, just in case uint32_t turns into a `short' ten years from now.
If this is MFC'd it will be necessary to hard-code the

Actually, arc4random() returns a uint32_t, not an int. Use the correct
constant, just in case uint32_t turns into a `short' ten years from now.
If this is MFC'd it will be necessary to hard-code the constant since
-stable doesn't have UINT32_MAX.

show more ...

fix jot -r on 64-bit platforms by teaching it that arc4random outputs
an int, not a long

Submitted by: Paul Herman <pherman@frenchfries.net>
PR#: alpha/31859

Replace the cast I removed in rev. 1.16 with a slightly less evil one
(well, at least one that gcc doesn't complain about). This fixes -r,
which rev. 1.16 broke.

Submitted by: bde

Silence warnings and compile with WARNS=2 on i386 and alpha.

Miscellaneous cleanups; sync to OpenBSD as much as feasible.
Noteworthy changes include:
* Use getopt(3).
* Fix overflows in -b and -w options.
* Use strlcpy(3) and snprintf(3) in favor of strcpy(

Miscellaneous cleanups; sync to OpenBSD as much as feasible.
Noteworthy changes include:
* Use getopt(3).
* Fix overflows in -b and -w options.
* Use strlcpy(3) and snprintf(3) in favor of strcpy(3) and
sprintf(3), respectively. Also check return values of the former
two.
* Fix lots of other gratuitous differences with OpenBSD.

Obtained from: OpenBSD

show more ...

Don't call printf with no format string.

Back out rev 1.11, about which bde had concerns, and instead implement
appropriate bounds-checking and typecasts based on our knowledge of
the desired conversion format specifier.

Simplify diagnosti

Back out rev 1.11, about which bde had concerns, and instead implement
appropriate bounds-checking and typecasts based on our knowledge of
the desired conversion format specifier.

Simplify diagnostics and take care to print the correct conversion
format specifier when %l is involved.

show more ...

$Id$ -> $FreeBSD$

Don't dump core for a known, documented bug.

PR: 12611
Reviewed by: markm

Improve printf(3) conversion specifier parsing so that silly formats
aren't allowed and the right casts can be used for printf() statements.

Document the conversion specifier limitations and the fac

Improve printf(3) conversion specifier parsing so that silly formats
aren't allowed and the right casts can be used for printf() statements.

Document the conversion specifier limitations and the fact that
arithmetic overflow causes a fatal error.

PR: 12611
Reported by: Frode Vatvedt Fjeld <frodef@acm.org>
Reviewed by: bde

show more ...

Correct an error in a manpage example, add -Wall -W to Makefile (no
warnings given) and modify source to use arc4random() instead of random().

Reviewed by: ache