depend-cleanup: Add a regex for files that moved

When a file is moved or copied to a new directory the depend-cleanup
script may incorrectly remove the .depend file as the generated regex
will pass.

depend-cleanup: Add a regex for files that moved

When a file is moved or copied to a new directory the depend-cleanup
script may incorrectly remove the .depend file as the generated regex
will pass. Fix this by passing in a new regex for the arm64 files that
have the same name as a generic implementation we were previously
using.

While here add memchr.S. It has moved from a generated file to one in
the source tree with the same name.

Reviewed by: emaste
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D48519

show more ...

depend-cleanup: bea89d038ac5 also moved memchr

Commit bea89d038ac5 added strlcat but also introduced a memchr wrapper
in the source tree rather than using the autogenerated one used for
AARCH64_STRI

depend-cleanup: bea89d038ac5 also moved memchr

Commit bea89d038ac5 added strlcat but also introduced a memchr wrapper
in the source tree rather than using the autogenerated one used for
AARCH64_STRING_FUNCS. Move memchr.S to MDSRS and add a cleanup rule for
the old wrapper.

Reviewed by: fuz
Sponsored by: The FreeBSD Foundation
Fixes: bea89d038ac5 ("lib/libc/aarch64/string: add strlcat SIMD implementation")
Differential Revision: https://reviews.freebsd.org/D48502

show more ...

depend-cleanup: Fix match expression for AArch64 asm files

Some routines (strcmp, strncmp, strlen) switched from an asm
implementation from arm-optimized-routines to a new asm implementation.
The de

depend-cleanup: Fix match expression for AArch64 asm files

Some routines (strcmp, strncmp, strlen) switched from an asm
implementation from arm-optimized-routines to a new asm implementation.
The default clean_dep rule matches both the old and new dependency
string, resulting in those routines always being rebuilt. Instead use
"arm-optimized-routines" (i.e., contrib subdir for the previous
implementation) as the matching regex.

Also delete the old generated src files.

Reviewed by: fuz
Sponsored by: The FreeBSD Foundation
Fixes: d57842ed2dad ("depend-cleanup.sh: clean up after AArch64 libc SIMD merge")
Differential Revision: https://reviews.freebsd.org/D48459

show more ...

depend-cleanup.sh: clean up after AArch64 libc SIMD merge

This should cover all the changed functions.

Event: GSoC 2024
Reported by: andrew
Approved by: emaste
Differential Revision: https://revie

depend-cleanup.sh: clean up after AArch64 libc SIMD merge

This should cover all the changed functions.

Event: GSoC 2024
Reported by: andrew
Approved by: emaste
Differential Revision: https://reviews.freebsd.org/D48443

show more ...

depend-cleanup: Fix test arg

-e follows the symlink to see if the file exists. I tested on the wrong
tree, so it appeared to work for me. Change to -h which see if the link
is there or not. The file

depend-cleanup: Fix test arg

-e follows the symlink to see if the file exists. I tested on the wrong
tree, so it appeared to work for me. Change to -h which see if the link
is there or not. The file will never not be a link if present.

Fixes: 42ee30f19cc7
Noticed by: Herbert Skuhra
Sponsored by: Netflix

show more ...

depend-cleanup.sh: Need to delete jemalloc.3 in objtree

With the jemalloc.3 move into the tree (it's a generated file that we
don't/can't generate as part of the build), we need to remove it from
th

depend-cleanup.sh: Need to delete jemalloc.3 in objtree

With the jemalloc.3 move into the tree (it's a generated file that we
don't/can't generate as part of the build), we need to remove it from
the .OBJDIR or make gets confused about how to build it (honestly for
reasons unknown).

Sponsored by: Netflix

show more ...

depend-cleanup.sh: clean up after hash function removal from libcrypt

The hash function removal changed the mangled names of MD[45] and
SHA{256,512} hash function identifiers. Clean these files to

depend-cleanup.sh: clean up after hash function removal from libcrypt

The hash function removal changed the mangled names of MD[45] and
SHA{256,512} hash function identifiers. Clean these files to pick
up the symbol change.

Reported by: bapt
Tested by: brooks
Fixes: cb5e41b160838880de7d03100afa02e4edee5a9e

show more ...

llvm19: permit incremental builds from llvm18

Detect and delete out of date clang-tblgen produced output. I found it
sufficent for compilation to delete only arm_*.inc files, but it seems
safer to

llvm19: permit incremental builds from llvm18

Detect and delete out of date clang-tblgen produced output. I found it
sufficent for compilation to delete only arm_*.inc files, but it seems
safer to regenerate all output and a few extra clang-tblgen runs pales
in comparison to the full build we're doing at this point.

Reviewed by: dim, emaste
Differential Revision: https://reviews.freebsd.org/D47270

show more ...

depend-cleanup.sh: Clean up after riscv static binary IFUNC addition

reloc.c is conditionally included by libc_start1.c so existing builds
don't feature it in the .depend file and won't know they ne

depend-cleanup.sh: Clean up after riscv static binary IFUNC addition

reloc.c is conditionally included by libc_start1.c so existing builds
don't feature it in the .depend file and won't know they need to rebuild
libc_start1.c.

MFC after: 1 week

show more ...

depend-cleanup.sh: Add a rule to work around zfs arc_os.c dependency changes

zfs: merge openzfs/zfs@b10992582

Notable upstream pull request merges:
#9416 -multiple zio_compress: introduce max size threshold
#10018 a10e552b9 Adding Direct IO Support
#15147 e419a63bf xattr

zfs: merge openzfs/zfs@b10992582

Notable upstream pull request merges:
#9416 -multiple zio_compress: introduce max size threshold
#10018 a10e552b9 Adding Direct IO Support
#15147 e419a63bf xattr dataset prop: change defaults to sa
#15454 7e957fde7 send/recv: open up additional stream feature flags
#15810 0d77e738e Defer resilver only when progress is above a threshold
#15921 3cf2bfa57 Allocate zap_attribute_t from kmem instead of stack
#16483 -multiple dmu_objset: replace dnode_hash impl with cityhash4
#16485 8be2f4c3d zio_resume: log when unsuspending the pool
#16491 88433e640 sys/types32.h: Remove struct timeval32 from libspl header
#16496 f245541e2 zfs_file: implement zfs_file_deallocate for FreeBSD 14
#16511 308f7c2f1 Fix an uninitialized data access
#16529 29c9e6c32 Fix handling of DNS names with '-' in them for sharenfs
#16531 ddf5f34f0 Avoid fault diagnosis if multiple vdevs have errors
#16539 6f50f8e16 zfs_log: add flex array fields to log record structs
#16546 d40d40913 Evicting too many bytes from MFU metadata
#16551 3014dcb76 Reduce and handle EAGAIN errors on AIO label reads
#16554 80645d658 FreeBSD: restore zfs_znode_update_vfs()
#16565 832f66b21 FreeBSD: Sync taskq_cancel_id() returns with Linux
#16567 48d1be254 Properly release key in spa_keystore_dsl_key_hold_dd()
#16569 141368a4b Restrict raidz faulted vdev count
#16583 c84a37ae9 lua: add flex array field to TString type
#16584 86737c592 Avoid computing strlen() inside loops
#16587 d34d4f97a snapdir: add 'disabled' value to make .zfs inaccessible
#16593 224393a32 feature: large_microzap
#16597 412105977 Temporarily disable Direct IO by default
#16605 4ebe674d9 ARC: Cache arc_c value during arc_evict()

Backported pull request merges:
#16613 ab777f436 Return boolean_t in inline functions of
lib/libspl/include/sys/uio.h
#16616 efeb60b86 FreeBSD: ignore some includes when not building kernel
#16635 ---TBD--- zdb: fix printf format in dump_zap()

Obtained from: OpenZFS
OpenZFS commit: b109925820fb79db3e37670c159977f03edd950f
OpenZFS tag: 2.3.0-rc1

show more ...

depend-cleanup.sh: Fix overzealous syscall.S cleanup on amd64

Just as we skip the cleanup for i386 due to still having a custom
syscall.S, we also need to do the same for lib32 on amd64, so filter i

depend-cleanup.sh: Fix overzealous syscall.S cleanup on amd64

Just as we skip the cleanup for i386 due to still having a custom
syscall.S, we also need to do the same for lib32 on amd64, so filter it
out of ALL_libcompats here.

Fixes: a650ec0e55a9 ("lib{c,sys}: fix incremental builds")

show more ...

depend-cleanup.sh: Fix overzealous syscall.S cleanup on non-amd64

Although there is no longer a syscall.S in the source tree, the
generated file is still called syscall.S, so the syscall\.S regex st

depend-cleanup.sh: Fix overzealous syscall.S cleanup on non-amd64

Although there is no longer a syscall.S in the source tree, the
generated file is still called syscall.S, so the syscall\.S regex still
matches the .depend file. Previously it looked like:

syscall.o \
/path/to/src/lib/libc/MACHINE/sys/syscall.S \
...

or

syscall.o \
/path/to/src/lib/libsys/MACHINE/syscall.S \
...

Now it looks like:

syscall.o: syscall.S \
...

Thus, match on the file having a directory specified, to distinguish it from
the generated case where it's adjacent in the OBJDIR. Note the .* is needed due
to the use of egrep -w.

Fixes: 3a4b04e82df6 ("depend-cleanup.sh: Simplify handling for stale syscall.S")

show more ...

depend-cleanup.sh: Fix overzealous abd_os.c cleanup

A source file with the same name is still used to build an abd_os.o, it
just comes from a different directory. Thus we need to include part of
the

depend-cleanup.sh: Fix overzealous abd_os.c cleanup

A source file with the same name is still used to build an abd_os.o, it
just comes from a different directory. Thus we need to include part of
the path in the regex too. Technically zfs/abd_os\.c would suffice given
it's now in sys/contrib/openzfs/lib/libzpool/abd_os.c, but this seems
clearer and less likely to have future false-positives.

Fixes: fd3d3240b0d7 ("depend-cleanup.sh: Add a rule to work around abd_os.c dependency changes")

show more ...

depend-cleanup.sh: Extend clean_dep to support a custom regex

This will avoid having to duplicate the loop every time the default
regex isn't good enough, and will be used by upcoming commits.

depend-cleanup.sh: Fix overzealous rescue.mk cleanup

grep -q -v means "are there any lines that don't match", not "are there
no lines that match", and since the file has lines other than ones with
n

depend-cleanup.sh: Fix overzealous rescue.mk cleanup

grep -q -v means "are there any lines that don't match", not "are there
no lines that match", and since the file has lines other than ones with
nvme_util.o when up-to-date this triggers on every build.

Fixes: 26a09db3add3 ("Fix incremental build with WITH_NVME newly enabled")
MFC after: 1 week

show more ...

depend-cleanup.sh: Fix pretend (-n) mode

Fixes: 26a09db3add3 ("Fix incremental build with WITH_NVME newly enabled")
MFC after: 1 week

depend-cleanup.sh: Add a rule to work around abd_os.c dependency changes

Fixes incremental buildworld after the latest OpenZFS import.

Fixes: e2df9bb44109 ("zfs: merge openzfs/zfs@b10992582")
Spons

depend-cleanup.sh: Add a rule to work around abd_os.c dependency changes

Fixes incremental buildworld after the latest OpenZFS import.

Fixes: e2df9bb44109 ("zfs: merge openzfs/zfs@b10992582")
Sponsored by: Klara, Inc.

show more ...

depend-cleanup.sh: Simplify handling for stale syscall.S

Remove the outer grep and depend on the greps in clean_dep instead.

Reviewed by: brooks, imp
Obtained from: CheriBSD
Sponsored by: AFRL, DAR

depend-cleanup.sh: Simplify handling for stale syscall.S

Remove the outer grep and depend on the greps in clean_dep instead.

Reviewed by: brooks, imp
Obtained from: CheriBSD
Sponsored by: AFRL, DARPA
Differential Revision: https://reviews.freebsd.org/D46103

show more ...

depend-cleanup: remove entries from 2020 and 2021

> These tests increase the build time (albeit by a small amount), so
> they should be removed once enough time has passed and it is extremely
> unli

depend-cleanup: remove entries from 2020 and 2021

> These tests increase the build time (albeit by a small amount), so
> they should be removed once enough time has passed and it is extremely
> unlikely anyone would try a NO_CLEAN build against an object tree from
> before the related change.

The comment suggests a year is a reasonable period but we'll be somewhat
more conservative for now, in part so that we retain different examples
of special cases.

Reviewed by: brooks, imp
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D46178

show more ...

tools: Remove stray "then"

Fixes: 26a09db3add3

Fix incremental build with WITH_NVME newly enabled

rescue.mk doesn't get updated when options change so nvme_util.o is now
missing on architectures were NVME was previously marked BROKEN.

Reviewed

Fix incremental build with WITH_NVME newly enabled

rescue.mk doesn't get updated when options change so nvme_util.o is now
missing on architectures were NVME was previously marked BROKEN.

Reviewed by: imp
Fixes: 2fda3ab0ac19 WITH_NVME: Remove from broken.
Differential Revision: https://reviews.freebsd.org/D44826

show more ...

lib{c,sys}: really fix incremental builds

Reported by: andrew
Fixes: a650ec0e55a9 lib{c,sys}: fix incremental builds

lib{c,sys}: fix incremental builds

I removed lib/libsys/{aarch64,arm,riscv}/syscall.S in favor of an
idential generated version. We need to clean out the .ddepend files to
ensure the generated vers

lib{c,sys}: fix incremental builds

I removed lib/libsys/{aarch64,arm,riscv}/syscall.S in favor of an
idential generated version. We need to clean out the .ddepend files to
ensure the generated version is actually generated.

The guard here is technically too strict, but should be fine in practice
and I've verified both the breakage and fix on an armv7 build.

Reported by: imp
Fixes: e6ffc7669a56 Remove pointless MD syscall(2)
Fixes: 0ee0ae237324 Remove pointless MD syscall(2)
Fixes: 7b3836c28188 Remove pointless MD syscall(2)

show more ...

ino64: Fix incremental builds

These files were removed, so we need to fix up depends for WITHOUT_CLEAN
builds (the default). Metamode builds aren't affected.

Sponsored by: Netflix
Feedback from:

ino64: Fix incremental builds

These files were removed, so we need to fix up depends for WITHOUT_CLEAN
builds (the default). Metamode builds aren't affected.

Sponsored by: Netflix
Feedback from: emaste
Tested by: Pierre Pronchery
Differential Revision: https://reviews.freebsd.org/D42433

show more ...