unix tests: Skip random_eor_and_waitall unconditionally

This test always fails, I don't see any reason to make it conditional on
the "CI" test parameter.

There is at least one test bug here, we're

unix tests: Skip random_eor_and_waitall unconditionally

This test always fails, I don't see any reason to make it conditional on
the "CI" test parameter.

There is at least one test bug here, we're using the wrong sysctl to
obtain the receive buffer size, but fixing that is not sufficient.

PR: 279354
Reviewed by: glebius
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D46726

show more ...

test: Change bug number

There was already a bug on this, so change to old bug

PR: 279354
Sponsored by: Netflix

test: disable sys.kern.unix_seqpacket_test.random_eor_and_waitall

It's been failing for a while, at least some of the time.

PR: 279994
Sponsored by: Netflix

tests/unix_seqpacket: remove workaround for a kernel bug that is no longer

tests/unix_seqpacket: test send(2) to a closed or aborted peer socket

In both cases the kernel returns EPIPE and delivers SIGPIPE, unless
blocked or disabled. The test isn't specific to SOCK_SEQPAC

tests/unix_seqpacket: test send(2) to a closed or aborted peer socket

In both cases the kernel returns EPIPE and delivers SIGPIPE, unless
blocked or disabled. The test isn't specific to SOCK_SEQPACKET, it is the
same for SOCK_STREAM. Put the test into this file, since it has all
primitives to write this test tersely.

Reviewed by: tuexen
Differential Revision: https://reviews.freebsd.org/D44146

show more ...

tests/unix_seqpacket: provide random data pumping test with MSG_EOR

Allocate a big chunk of randomly initialized memory. Send it to the peer
in random sized chunks, throwing MSG_EOR at randomly ini

tests/unix_seqpacket: provide random data pumping test with MSG_EOR

Allocate a big chunk of randomly initialized memory. Send it to the peer
in random sized chunks, throwing MSG_EOR at randomly initialized offsets.
Receive into random sized chunks setting MSG_WAITALL randomly. Check that
MSG_EORs where they should be, check that MSG_WAITALL is abode, but
overriden by MSG_EOR. And finally memcmp() what we receive.

Reviewed by: asomers, tuexen
Differential Revision: https://reviews.freebsd.org/D43775

show more ...

tests/unix_seqpacket: mk_pair_of_sockets() requires a valid argument

All callers do it right. Don't be overprotective against a stupid
caller and thus don't look like a code that leaks a resource.

tests/unix_seqpacket: mk_pair_of_sockets() requires a valid argument

All callers do it right. Don't be overprotective against a stupid
caller and thus don't look like a code that leaks a resource.

Reported by: Coverity Scan
CID: 1539210

show more ...

tests/unix_seqpacket: test that implied connect doesn't work

Applies both to SOCK_STREAM and SOCK_SEQPACKET. Put the test in this file
as it is most advanced one.

Reviewed by: tuexen
Differential

tests/unix_seqpacket: test that implied connect doesn't work

Applies both to SOCK_STREAM and SOCK_SEQPACKET. Put the test in this file
as it is most advanced one.

Reviewed by: tuexen
Differential Revision: https://reviews.freebsd.org/D43854

show more ...

tests/unix_seqpacket: test that data can be sent before accept(2)

This is undocumented feature of PF_UNIX/SOCK_STREAM and thus of
PF_UNIX/SOCK_SEQPACKET, too. Put the test into this file, since thi

tests/unix_seqpacket: test that data can be sent before accept(2)

This is undocumented feature of PF_UNIX/SOCK_STREAM and thus of
PF_UNIX/SOCK_SEQPACKET, too. Put the test into this file, since this file
is most advanced and has all primitives to write this test in minimum
number of lines.

Differential Revision: https://reviews.freebsd.org/D43853

show more ...

tests/unix_seqpacket: provide function that returns bound & listening sock

Use the function in mk_pair_of_sockets(), and in four existing tests -
'listen_bound', 'connect', 'shutdown_send' and 'shut

tests/unix_seqpacket: provide function that returns bound & listening sock

Use the function in mk_pair_of_sockets(), and in four existing tests -
'listen_bound', 'connect', 'shutdown_send' and 'shutdown_send_sigpipe'.
While here make mk_pair_of_sockets() return pointer to sockaddr_un instead
of path. This also fixes bug of returning pointer to stack memory of
returning function. However, the only caller that cares about this return
is temporarily ifdefed out. No functional change intended.

Reviewed by: tuexen
Differential Revision: https://reviews.freebsd.org/D43852

show more ...

tests/unix_seqpacket: remove EMSGSIZE tests

These tests were not testing conformance to the specification, rather than
the limitation of our implementation. The specification doesn't say that
a SOC

tests/unix_seqpacket: remove EMSGSIZE tests

These tests were not testing conformance to the specification, rather than
the limitation of our implementation. The specification doesn't say that
a SOCK_SEQPACKET shall ever return EMSGSIZE. It says:

The SOCK_SEQPACKET socket type is similar to the SOCK_STREAM type,
and is also connection-oriented. The only difference between these
types is that record boundaries are maintained using the
SOCK_SEQPACKET type. A record can be sent using one or more output
operations and received using one or more input operations, but a
single operation never transfers parts of more than one record.
Record boundaries are visible to the receiver via the MSG_EOR flag
in the received message flags returned by the recvmsg() function. It
is protocol-specific whether a maximum record size is imposed.

The EMSGSIZE is specified as 'message is too large to be sent all at once,
as the socket requires'. Indeed existing implementation that has
unix/seqpacket marked as PR_ATOMIC has such a limitation. But future
implementation won't have, thus remove the tests.

Reviewed by: tuexen, asomers
Differential Revision: https://reviews.freebsd.org/D43756

show more ...

Remove $FreeBSD$: one-line .c pattern

Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/

unix_seqpacket_test: Consistently use datalen as length to send.

This matches the other tests in this file and quiets a set but unused
warning from GCC.

Merge ^/head r318964 through r319164.

Send all of `data`, not just a portion of it

It was sending only a long's worth (4 or 8 bytes) of data previously
(instead of the entire buffer) via send(2).

MFC after: 1 week
Reported by: Coverity

Send all of `data`, not just a portion of it

It was sending only a long's worth (4 or 8 bytes) of data previously
(instead of the entire buffer) via send(2).

MFC after: 1 week
Reported by: Coverity
CID: 1229966, 1229967, 1230004, 1230005
Sponsored by: Dell EMC Isilon

show more ...

Merge ^/head r317503 through r317807.

Don't pass size_t arguments to setsockopt(SO_SNDBUF/SO_RCVBUF).

These command take an int. The tests work by accident on little-endian,
64-bit systems.

PR: 218919
Tested with: qemu-cheri and Cheri

Don't pass size_t arguments to setsockopt(SO_SNDBUF/SO_RCVBUF).

These command take an int. The tests work by accident on little-endian,
64-bit systems.

PR: 218919
Tested with: qemu-cheri and CheriBSD built for mips64
Reviewed by: asomers, ngie
Obtained from: CheriBSD
MFC after: 1 week
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D10518

show more ...

MFH r289384-r293170

Sponsored by: The FreeBSD Foundation

Mfh r292839

- Remove unused but set ssize in shutdown_send_sigpipe
- Add #ifdef TEST_SEQ_PACKET_SOURCE_ADDRESS` for untestable code
because FreeBSD doesn't have a means to map source addresses for
SEQ_PACKET

- Remove unused but set ssize in shutdown_send_sigpipe
- Add #ifdef TEST_SEQ_PACKET_SOURCE_ADDRESS` for untestable code
because FreeBSD doesn't have a means to map source addresses for
SEQ_PACKET AF_UNIX sockets (paraphrased). Put pathname variable
under the #ifdef to mute another unused but set variable warning

MFC after: 1 week
Sponsored by: EMC / Isilon Storage Division

show more ...

Clean trailing whitespace

MFC after: 1 week
Sponsored by: EMC / Isilon Storage Division

Merge from head

Catch up with head, primarily for the 1.14.4.0 firmware.

Merge ^/head r285924 through r286421.

Fixed shutdown(2) unix(4) tests for SOCK_SEQPACKET after r285910 (by ed).