netlink: fix build

The commit checked in had a dependency on not yet reviewed changes.
Revert them, but the main gist of the commit is not reverted.

Fixes: f2a4eed3e13b6aeb9ddeef580d3b931cf22a14e3

netlink: underscore snl_get_genl_family_info() to discourage its use

This function uses already supposedly opaque struct _getfamily_attrs as
the argument and it fills it with pointers to volatile me

netlink: underscore snl_get_genl_family_info() to discourage its use

This function uses already supposedly opaque struct _getfamily_attrs as
the argument and it fills it with pointers to volatile memory, which makes
it is unsafe for general use. While here also underscore structures that
hang off the struct _getfamily_attrs.

Small programs like powerd(8) and RPC daemons are converted to use
snl_get_genl_mcast_group() and/or snl_get_genl_family(). The genl(1)
utility was fixed not to mix its own parsers with parsers declared in
netlink_snl_generic.h.

Reviewed by: melifaro
Differential Revision: https://reviews.freebsd.org/D48480

show more ...

netlink: small cleanup of generic snl(3)

- Add const qualifiers for the family/group name pointers.
- Break & tab long lines.

No functional changes.

netlink: snl_create_genl_msg_request() may fail due to ENOMEM

Reviewed by: melifaro
Differential Revision: https://reviews.freebsd.org/D48310

netlink: add snl(3) primitive to obtain group ID

using the family name and the group name as lookup arguments.

Reviewed by: melifaro
Differential Revision: https://reviews.freebsd.org/D48308

netlink: cope with growing requests

If a request ends up growing beyong the initially allocated space the
netlink functions (such as snl_add_msg_attr_u32()) will allocate a
new buffer. This invalida

netlink: cope with growing requests

If a request ends up growing beyong the initially allocated space the
netlink functions (such as snl_add_msg_attr_u32()) will allocate a
new buffer. This invalidates the header pointer we can have received
from snl_create_msg_request(). Always use the hdr returned by
snl_finalize_msg().

Reviewed by: melifaro
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D42223

show more ...

netlink: add snl(3) support for listing genetlink multicast groups

Reviewed by: bapt
Differential Revision: https://reviews.freebsd.org/D40282
MFC after: 2 weeks

spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSD

The SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catch
up to that fact and revert to their recommended match of

spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSD

The SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catch
up to that fact and revert to their recommended match of BSD-2-Clause.

Discussed with: pfg
MFC After: 3 days
Sponsored by: Netflix

show more ...

netlink: improve snl(3)

Summary:
* add snl_send_message() as a convenient send wrapper
* add signed integer parsers
* add snl_read_reply_code() to simplify operation result checks
* add snl_read_rep

netlink: improve snl(3)

Summary:
* add snl_send_message() as a convenient send wrapper
* add signed integer parsers
* add snl_read_reply_code() to simplify operation result checks
* add snl_read_reply_multi() to simplify reading multipart messages
* add snl_create_genl_msg_request()
* add snl_get_genl_family() to simplify family name->id resolution
* add tests for some of the functionality

Reviewed by: kp
Differential Revision: https://reviews.freebsd.org/D39092
MFC after: 2 weeks

show more ...