netinet: use in_broadcast() inline

There should be no functional change.

Reviewed by: rrs, markj
Differential Revision: https://reviews.freebsd.org/D49088

sctp: improve heartbeat timer computation
PR: 278666
Reviewed by: Albin Hellqvist
MFC after: 3 days
Pull Request: https://reviews.freebsd.org/D45107

sctp: store cookie secret change time as time_t
Reported by: Coverity Scan
CID: 1492349
CID: 1493281
MFC after: 3 days

sockets: garbage collect SS_ISCONFIRMING

Fixes: 8df32b19dee92b5eaa4b488ae78dca6accfcb38e

sctp: don't call sctp_ulp_notify() recursively

This does not work with the new locking scheme.

MFC after: 3 days

sctp: cleanup locking for notifications

All notifications are now queued via sctp_ulp_notify(). Do
the locking of the inp read lock there and validate this in all
functions being used.
This is one s

sctp: cleanup locking for notifications

All notifications are now queued via sctp_ulp_notify(). Do
the locking of the inp read lock there and validate this in all
functions being used.
This is one step in avoiding race conditions when closing the
read end of an SCTP socket.

MFC after: 3 days

show more ...

sctp: make sure all SCTP RESET notifications use sctp_ulp_notify()

While there, improve consistency of the notification related code.
No functional change intended.

MFC after: 3 days

sctp: cleanup SCTP AUTH related notification

This makes consistent use of the parameters and ensures that
all SCTP AUTH related notifications are using sctp_ulp_notify().

No functional change inten

sctp: cleanup SCTP AUTH related notification

This makes consistent use of the parameters and ensures that
all SCTP AUTH related notifications are using sctp_ulp_notify().

No functional change intended.

MFC after: 3 days

show more ...

sctp: cleanup

In particular, don't use a socket level flag, use the inp level one.
After adding appropriate locking, this will close a race condition.

MFC after: 1 week

sctp: cleanup cdefs.h include

sys: Remove $FreeBSD$: one-line .c pattern

Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/

sctp: cleanup

Do not put a variable in the stcb for passing it to a function.
Just use a parameter of the function. No functional change intended.

MFC after: 1 week

sctp: add an assert

This enforces a condition mentioned in a comment.

MFC after: 1 week

sctp: improve consistency

MFC after: 1 week

sctp: remove redundant check

This is already checked by the caller.

MFC after: 1 week

sctp: keep sb_acc and sb_ccc in sync

PR: 260116
MFC after: 1 week

sctp: improve consistency

This is simplifying a patch to address PR 260116.

PR: 260116
MFC after: 1 week

sctp: update zero checksum support

Implement support for the error detection method identifier.
MFC after: 2 weeks

sctp: initial implementation of draft-tuexen-tsvwg-sctp-zero-checksum

sctp: improve delivery of stream reset notifications

Two functions are not called via sctp_ulp_notify() and therefore
need additional checks when being called.

Reported by: syzbot+eb888d3a5a6c54413

sctp: improve delivery of stream reset notifications

Two functions are not called via sctp_ulp_notify() and therefore
need additional checks when being called.

Reported by: syzbot+eb888d3a5a6c54413de5@syzkaller.appspotmail.com
MFC after: 3 days

show more ...

netinet*: remove PRC_ constants and streamline ICMP processing

In the original design of the network stack from the protocol control
input method pr_ctlinput was used notify the protocols about two

netinet*: remove PRC_ constants and streamline ICMP processing

In the original design of the network stack from the protocol control
input method pr_ctlinput was used notify the protocols about two very
different kinds of events: internal system events and receival of an
ICMP messages from outside. These events were coded with PRC_ codes.
Today these methods are removed from the protosw(9) and are isolated
to IPv4 and IPv6 stacks and are called only from icmp*_input(). The
PRC_ codes now just create a shim layer between ICMP codes and errors
or actions taken by protocols.

- Change ipproto_ctlinput_t to pass just pointer to ICMP header. This
allows protocols to not deduct it from the internal IP header.
- Change ip6proto_ctlinput_t to pass just struct ip6ctlparam pointer.
It has all the information needed to the protocols. In the structure,
change ip6c_finaldst fields to sockaddr_in6. The reason is that
icmp6_input() already has this address wrapped in sockaddr, and the
protocols want this address as sockaddr.
- For UDP tunneling control input, as well as for IPSEC control input,
change the prototypes to accept a transparent union of either ICMP
header pointer or struct ip6ctlparam pointer.
- In icmp_input() and icmp6_input() do only validation of ICMP header and
count bad packets. The translation of ICMP codes to errors/actions is
done by protocols.
- Provide icmp_errmap() and icmp6_errmap() as substitute to inetctlerrmap,
inet6ctlerrmap arrays.
- In protocol ctlinput methods either trust what icmp_errmap() recommend,
or do our own logic based on the ICMP header.

Differential revision: https://reviews.freebsd.org/D36731

show more ...

sctp: improve handling of sctp inpcb flags

Use an atomic operation when the inp is not write locked.

Reported by: syzbot+bf27083e9a3f8fde8b4d@syzkaller.appspotmail.com
MFC after: 3 days

sctp: more sb_cc related cleanups

No functional change intended. It allows a simpler patch for PR 260116.

MFC after: 3 days

sctp: use sb_avail() when accessing sb_acc for reading

This is a cleanup to simplify a patch for PR 260116.

PR: 260116
MFC after: 3 days

sctp: cleanup, no functional change intended

MFC after: 3 days