dummymbuf: add 'enlarge'

Teach dummymbuf to replace mbufs with larger ones.
This can be useful for testing for bugs that depend on mbuf layout.

Sponsored by: Rubicon Communications, LLC ("Netgate")

sys/net: fix several sysinit_cfunc_t signature mismatches

Reviewed by: glebius
Differential Revision: https://reviews.freebsd.org/D48490

dummymbuf: Explicitly include if_private.h

struct ifnet is expected to be private for everything outside of the
network stack (sys/net*, except netlink. Since dummymbuf is part of the
network stack

dummymbuf: Explicitly include if_private.h

struct ifnet is expected to be private for everything outside of the
network stack (sys/net*, except netlink. Since dummymbuf is part of the
network stack, explicitly include the header to get access to the
private members.

Sponsored by: Juniper Networks, Inc.

show more ...

dummymbuf: Log the entire rule set if no delimiters are present

An empty string was printed instead.

Reviewed by: kp
Approved by: kp (mentor)
Differential Revision: https://reviews.freebsd.org/D469

dummymbuf: Log the entire rule set if no delimiters are present

An empty string was printed instead.

Reviewed by: kp
Approved by: kp (mentor)
Differential Revision: https://reviews.freebsd.org/D46964

show more ...

dummymbuf: Fix code style

No functional change intended.

Reviewed by: kp
Approved by: kp (mentor)
Differential Revision: https://reviews.freebsd.org/D46958

dummymbuf: Validate syntax upon write to net.dummymbuf.rules sysctl

For now, opargs are not validated due to their runtime nature.

Reviewed by: kp
Approved by: kp (mentor)
Differential Revision: ht

dummymbuf: Validate syntax upon write to net.dummymbuf.rules sysctl

For now, opargs are not validated due to their runtime nature.

Reviewed by: kp
Approved by: kp (mentor)
Differential Revision: https://reviews.freebsd.org/D46496

show more ...

dummymbuf: Avoid copyout of uninitialized memory from the sysctl handler

If *rulesp was initially unset, we'll allocate a new buffer and pass it
to sysctl_handle_string(), which copies the existing

dummymbuf: Avoid copyout of uninitialized memory from the sysctl handler

If *rulesp was initially unset, we'll allocate a new buffer and pass it
to sysctl_handle_string(), which copies the existing string out and then
copies in the new string. We need to make sure the buffer containing
the existing rules is initialized, otherwise we leak kernel memory to
userspace.

Fix some nearby style nits while here.

Reported by: KMSAN
Reviewed by: igoro, kp
Fixes: 8aaffd78c0f5 ("Add dummymbuf module for testing purposes")
Sponsored by: Klara, Inc.
Differential Revision: https://reviews.freebsd.org/D46493

show more ...

dummymbuf: fix build without INET or INET6

Note that VIMAGE would mask both compilation failures.

Add dummymbuf module for testing purposes

Reviewed by: kp
Differential Revision: https://reviews.freebsd.org/D45928