thunderbolt: Fix v2.0 reset to reliably wait for the reset to finish

The `reg` value was never initialized, so the loop could potentially
abort without a single read of the register. This was found

thunderbolt: Fix v2.0 reset to reliably wait for the reset to finish

The `reg` value was never initialized, so the loop could potentially
abort without a single read of the register. This was found by the
following warning from GCC:

sys/dev/thunderbolt/nhi.c: In function 'nhi_reset_v2':
sys/dev/thunderbolt/nhi.c:272:35: error: 'reg' is used uninitialized [-Werror=uninitialized]
272 | for (size_t i = 0; i < 10 && reg; i++) {
| ^~
sys/dev/thunderbolt/nhi.c:257:18: note: 'reg' was declared here
257 | uint32_t reg;
| ^~~

Reported by: GCC 15
Fixes: efdb82413963 ("thunderbolt: Reset controllers")

show more ...

thunderbolt: Explicitly read NHI ISR0 register to clear it

This fixes and issue where Pink Sardine controllers were not receiving
interrupts for more than the first command sent on the ring.

Review

thunderbolt: Explicitly read NHI ISR0 register to clear it

This fixes and issue where Pink Sardine controllers were not receiving
interrupts for more than the first command sent on the ring.

Reviewed by: emaste, imp
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52862

show more ...

thunderbolt: Reset controllers

Reset routine for both v1.0 and v2.0 routes, chosen depending on version
reported in caps.

Reviewed by: imp
Sponsored by: The FreeBSD Foundation
Differential Revision

thunderbolt: Reset controllers

Reset routine for both v1.0 and v2.0 routes, chosen depending on version
reported in caps.

Reviewed by: imp
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D49452

show more ...

thunderbolt: Get NHI version number from caps

Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D49452