qlnxe: Advertise the IFCAP_HWSTATS capability

The hardware can count statistics and the driver has already retrieved
them via qlnx_get_counter().

Advertise the IFCAP_HWSTATS capability to avoid the

qlnxe: Advertise the IFCAP_HWSTATS capability

The hardware can count statistics and the driver has already retrieved
them via qlnx_get_counter().

Advertise the IFCAP_HWSTATS capability to avoid the net stack from
double counting IFCOUNTER_IBYTES.

Reviewed by: kbowling
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D51451

show more ...

qlnxe: Fix advertising the IFCAP_LINKSTATE capability

The following up advertising of IFCAP_HWCSUM capability unconditionally
overwrite IFCAP_LINKSTATE.

Reviewed by: kbowling
MFC after: 3 days
Diff

qlnxe: Fix advertising the IFCAP_LINKSTATE capability

The following up advertising of IFCAP_HWCSUM capability unconditionally
overwrite IFCAP_LINKSTATE.

Reviewed by: kbowling
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D51450

show more ...

qlnxe: Fix error handling of SIOCGI2C ioctl

The error -1 is actually ERESTART in the context of syscall. It is for
kernel mode only and will not be passed to user mode. When the kernel
sees this err

qlnxe: Fix error handling of SIOCGI2C ioctl

The error -1 is actually ERESTART in the context of syscall. It is for
kernel mode only and will not be passed to user mode. When the kernel
sees this error it will restart the syscall.

When the the SFP module data is not available, e.g. the SFP module is
not present, the ioctl handler returns ERESTART and kernel will retry
infinitely, hence the userland `ifconfig -v ql0` will hang forever until
get interrupted. That is apparently wrong.

Fix that by returning error ENODEV to indicate the SFP module data is
not available.

As for the case that ecore_ptt_acquire() fails, it appears to be quite
safe to restart, so keep returning ERESTART.

Reported by: Steve Wheeler
See also: https://redmine.pfsense.org/issues/16248
Reviewed by: kbowling
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D51351

show more ...

qlnxe: Fix build with INET

opt_inet.h is missing from 5684c8783b64, thus actually `#ifdef INET`
does not work.

PR: 287445
See also: https://redmine.pfsense.org/issues/16248
Reviewed by: kbowling
T

qlnxe: Fix build with INET

opt_inet.h is missing from 5684c8783b64, thus actually `#ifdef INET`
does not work.

PR: 287445
See also: https://redmine.pfsense.org/issues/16248
Reviewed by: kbowling
Tested by: leper <leper4@protonmail.com>
Fixes: 5684c8783b64 qlnxe: Add missing #ifdef INET to fix amd64 LINT-NOINET/NOIP builds
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D51295

show more ...

qlnx: fix panic at startup

While attaching the qlnx driver we can end up trying to call ifmedia functions
before those are set up (through ether_ifattach() -> rtnl_handle_ifattach()
-> dump_iface()

qlnx: fix panic at startup

While attaching the qlnx driver we can end up trying to call ifmedia functions
before those are set up (through ether_ifattach() -> rtnl_handle_ifattach()
-> dump_iface() -> get_operstate_ether() -> ifmedia_ioctl()). Postpone the
ether_ifattach() until after the ifmedia setup.

Reviewed by: markj,zlei
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D50819

show more ...

qlnx: Convert recent changes to IfAPI

Sponsored by: Juniper Networks, Inc.
Reviewed by: zlei
Differential Revision: https://reviews.freebsd.org/D47533

qlnxe: Allow MAC address override

The qlnxe driver always sets the NIC's rx mac address to the card's
default MAC, ignoring any MAC address set via ifconfig.

PR: 278085
MFC after: 1 week

net: Remove unneeded NULL check for the allocated ifnet

Change 4787572d0580 made if_alloc_domain() never fail, then also do the
wrappers if_alloc(), if_alloc_dev(), and if_gethandle().

No functiona

net: Remove unneeded NULL check for the allocated ifnet

Change 4787572d0580 made if_alloc_domain() never fail, then also do the
wrappers if_alloc(), if_alloc_dev(), and if_gethandle().

No functional change intended.

Reviewed by: kp, imp, glebius, stevek
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D45740

show more ...

qlnx: Use device_set_descf()

No functional change intended.

MFC after: 1 week

qlnxe: Fix multiple locking issues

Multiple issues are reported with WITNESS and code inspection of the
locking and lock initialization.

PR: 278084
MFC after: 1 week

Revert "qlnxe: Fix multiple locking issues"

This commit is missing a file, revert so I can do it correctly,
atomically.

This reverts commit 29684d08fa3010c2035b4eb1ce0b39091ad07723.

qlnxe: Fix multiple locking issues

Multiple issues are reported with WITNESS and code inspection of the
locking and lock initialization.

PR: 278084
MFC after: 1 week

qlnxe: Fix promiscuous and allmulti settings

PR: 278087
MFC after: 1 week

sys: Remove $FreeBSD$: one-line .c pattern

Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/

qlnxe: Add missing #ifdef INET to fix amd64 LINT-NOINET/NOIP builds

The approach here is copied directly from qlxgb.

Fixes: b0d3d44dfe63 ("qlnxe: add driver to amd64 NOTES")

Simplify buffer count calculation

Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/778

Remove duplicate #include

Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/778

qlnxe: Fix too many args in call to internal_ram_wr()

internal_ram_wr() only takes 3 args when ECORE_CONFIG_DIRECT_HWFN
is defined

Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
Reviewed by: im

qlnxe: Fix too many args in call to internal_ram_wr()

internal_ram_wr() only takes 3 args when ECORE_CONFIG_DIRECT_HWFN
is defined

Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/779

show more ...

qlnxe: Move sriov includes to qlnx_os.c

SRIOV is being enabled in ecore.h but by then
the qlnx_os.h header has been processed and not
included the relevant headers

Signed-off-by: Mark O'Donovan <sh

qlnxe: Move sriov includes to qlnx_os.c

SRIOV is being enabled in ecore.h but by then
the qlnx_os.h header has been processed and not
included the relevant headers

Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/779

show more ...

Mechanically convert qlnx(4) to IfAPI

Reviewed By: zlei
Sponsored by: Juniper Networks, Inc.
Differential Revision: https://reviews.freebsd.org/D37856

qlnx: purge EOL release compatibility

Drop code that supproted FreeBSD 10 and 11.

Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/603
Differential Revision: https://revie

qlnx: purge EOL release compatibility

Drop code that supproted FreeBSD 10 and 11.

Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/603
Differential Revision: https://reviews.freebsd.org/D35560

show more ...

qlnx/qlxgb/qlxgbe/qlxge: Remove unused devclass arguments to DRIVER_MODULE.

qlnxe(4): Fix a typo in a source code comment

- s/mulitple/multiple/

MFC after: 3 days

qlnx: Mark variables only used in debug traces as unused.

qlnx: Comment out remaining references to tx_data_bd.