ig4(4): Add Intel ACPI HID

MFC after: 1 month

ig4(4): Add an EMAG device type

Sponsored by: Ampere Computing LLC, Netflix
Submitted by: allanjude
Differential Revision: https://reviews.freebsd.org/D28746
Reviewed by: imp

sys: Remove $FreeBSD$: one-line .c pattern

Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/

ichiic: use bool for one-bit wide bit-fields

A one-bit wide bit-field can take only the values 0 and -1. Clang 16
introduced a warning that "implicit truncation from 'int' to a one-bit
wide bit-fiel

ichiic: use bool for one-bit wide bit-fields

A one-bit wide bit-field can take only the values 0 and -1. Clang 16
introduced a warning that "implicit truncation from 'int' to a one-bit
wide bit-field changes value from 1 to -1". Fix by using c99 bool.

Reported by: Clang
Reviewed by: emaste, wulf
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D39665

show more ...

ig4(4): Add device HID to match I2C controller on ASUS X540 laptops

Tested by: Andrés Ramírez <rrandresf_AT_hotmail_DOT_com>
MFC after: 1 week

ichiic: Remove unused devclass arguments to DRIVER_MODULE.

ig4(4): Add PNP info for ACPI attachment

MFC after: 2 month

ig4iic_acpi_probe: remove set but unused variable

MFC after: 1 week

ig4: ensure that drivers always attach in correct order

Use DRIVER_MODULE_ORDERED(SI_ORDER_ANY) so that ig4's ACPI attachment
happens after iicbus and acpi_iicbus drivers are registered.

I have see

ig4: ensure that drivers always attach in correct order

Use DRIVER_MODULE_ORDERED(SI_ORDER_ANY) so that ig4's ACPI attachment
happens after iicbus and acpi_iicbus drivers are registered.

I have seen a problem where iicbus attached under ig4 instead of
acpi_iicbus when ig4.ko was loaded with kldload. I believe that that
happened because ig4 driver was a first driver to register, it attached
and created an iicbus child. Then iicbus driver was registered and,
since it was the only driver that could attach to the iicbus child
device, it did exactly that. After that acpi_iicbus driver was
registered. It would be able to attach to the iicbus device, but it was
already attached, so nothing happened.

MFC after: 2 weeks

show more ...

[ig4] Remove unused methods from bus interface

bus_get/set_resource methods are implemented in child device (iicbus).
As their implementation with bus_generic_rl_get/set calls do not
recurse up the

[ig4] Remove unused methods from bus interface

bus_get/set_resource methods are implemented in child device (iicbus).
As their implementation with bus_generic_rl_get/set calls do not
recurse up the tree, the versions in ig4 are never called.

Suggested by: jhb

show more ...

[ig4] Add generic resource methods to bus interface

That allows ig4 children to allocate IRQs

[ig4] Add suspend/resume support

That is done with re-execution of controller initialization procedure
from resume handler.

PR: 238037

[ig4] Allow enabling of polled mode from iicbus allocation callback

If controller is allocated with IIC_NOWAIT option ig4 enables polled mode
for a period of allocation that makes possible to start

[ig4] Allow enabling of polled mode from iicbus allocation callback

If controller is allocated with IIC_NOWAIT option ig4 enables polled mode
for a period of allocation that makes possible to start I2C transfers
from the contexts where sleeping is not allowed e.g. from ithreads or
callouts.

show more ...

[ig4] Only enable interrupts when we want them. Otherwise keep mask at 0.

This avoids possible interrupt storms, depending on the state of the I2C
controller before the driver attached.

During atta

[ig4] Only enable interrupts when we want them. Otherwise keep mask at 0.

This avoids possible interrupt storms, depending on the state of the I2C
controller before the driver attached.

During attaching this clears the interrupt mask.

Revert r338215 as this change makes it no-op.

Obtained from: DragonflyBSD (d7c8555)

show more ...

[ig4] Give common name to PCI and ACPI device drivers

They share common device driver code with different bus attachments

This commit starts a bunch of changes which have following properties:

Rev

[ig4] Give common name to PCI and ACPI device drivers

They share common device driver code with different bus attachments

This commit starts a bunch of changes which have following properties:

Reviewed by: imp (previous version)
MFC after: 1 month
Differential Revision: https://reviews.freebsd.org/D22016

show more ...

fix formatting and style in ig4iic_acpi_probe afetr r339754

This includes removing stray whitespace, adding a line after the
variable declaration block and removing a redundant check.

MFC after: 1

fix formatting and style in ig4iic_acpi_probe afetr r339754

This includes removing stray whitespace, adding a line after the
variable declaration block and removing a redundant check.

MFC after: 1 week
X-MFC with: r339754

show more ...

Merge ^/head r339670 through r339812.

Distinguish _CID match and _HID match and make lower priority probe
when _CID match.

Reviewed by: jhb, imp
Differential Revision:https://reviews.freebsd.org/D16468

Merge ^/head r338026 through r338297, and resolve conflicts.

[ig4] Fix I/O timeout issue with Designware I2C controller on AMD platforms

Due to hardware limitation AMD I2C controller can't trigger pending
interrupt if interrupt status has been changed after c

[ig4] Fix I/O timeout issue with Designware I2C controller on AMD platforms

Due to hardware limitation AMD I2C controller can't trigger pending
interrupt if interrupt status has been changed after clearing
interrupt status bits. So, I2C will lose the interrupt and IO will be
timed out. Implements a workaround to disable I2C controller interrupt
and re-enable I2C interrupt before existing interrupt handler.

Submitted by: rajfbsd@gmail.com
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D16720

show more ...

[ig4] add ACPI Device HID for AMD platforms

Added ACPI Device HID AMDI0010 for the designware I2C controllers in
future AMD platforms. Also, when verifying component version check for
minimal value

[ig4] add ACPI Device HID for AMD platforms

Added ACPI Device HID AMDI0010 for the designware I2C controllers in
future AMD platforms. Also, when verifying component version check for
minimal value instead of exact match.

PR: 230641
Submitted by: Rajesh <rajfbsd@gmail.com>
Reviewed by: cem, gonzo
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D16670

show more ...

[ig4] Add support for i2c controllers on Skylake and Kaby Lake

This was tested by Ben on HP Chromebook 13 G1 with a
Skylake CPU and Sunrise Point-LP I2C controller and by me on
Minnowboard Turbot w

[ig4] Add support for i2c controllers on Skylake and Kaby Lake

This was tested by Ben on HP Chromebook 13 G1 with a
Skylake CPU and Sunrise Point-LP I2C controller and by me on
Minnowboard Turbot with Atom E3826 (formerly Bay Trail)

Submitted by: Ben Pye <ben@curlybracket.co.uk>
Reviewed by: gonzo
Obtained from: DragonflyBSD (a4549657 by Imre Vadász)
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D13654

show more ...

[ig4] Add ACPI platform support for ig4 driver

Add ACPI part for ig4 driver to make it work on Intel BayTrail SoC where
ig4 device is available only through ACPI

Reviewed by: avg
MFC after: 1 week

[ig4] Add ACPI platform support for ig4 driver

Add ACPI part for ig4 driver to make it work on Intel BayTrail SoC where
ig4 device is available only through ACPI

Reviewed by: avg
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D8742

show more ...