scmi: Avoid a use-after-free

Use LIST_FOREACH_SAFE to avoid a use-after-free in scmi_reqs_pool_free.
The next pointer will be invalid after the call to free meaning
LIST_FOREACH will dereference a f

scmi: Avoid a use-after-free

Use LIST_FOREACH_SAFE to avoid a use-after-free in scmi_reqs_pool_free.
The next pointer will be invalid after the call to free meaning
LIST_FOREACH will dereference a freed struct to move to the next item.

Reviewed by: emaste
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D50753

show more ...

scmi: Add sysctl transport properties

Expose as read-only the configured transport properties.

Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: htt

scmi: Add sysctl transport properties

Expose as read-only the configured transport properties.

Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47428
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>

show more ...

scmi: Add SDT traces to the core stack

Add a few basic traces to track SCMI messages lifecycle.

Tested on: Arm Morello Board
Reviewed by: Andrew
Sponsored by: Arm Ltd
Differential Revision: ht

scmi: Add SDT traces to the core stack

Add a few basic traces to track SCMI messages lifecycle.

Tested on: Arm Morello Board
Reviewed by: Andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47427
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>

show more ...

scmi: Add optional asynchronous handling of replies

Add the core logic to handle the replies to pending command in an
asynchronous manner.

Tested on: Arm Morello Board
Reviewed by: andrew
Spon

scmi: Add optional asynchronous handling of replies

Add the core logic to handle the replies to pending command in an
asynchronous manner.

Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47426
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>

show more ...

scmi: Refactor scmi_request internal logic

Split scmi_request internals into a TX and an RX phase, which will be
called, anyway, in sequence as before when a normal transmission is
requested.

No fu

scmi: Refactor scmi_request internal logic

Split scmi_request internals into a TX and an RX phase, which will be
called, anyway, in sequence as before when a normal transmission is
requested.

No functional change.

Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47425
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>

show more ...

scmi: Add scmi_token_reserve helper

During normal operation, the SCMI stack, upon each transmission attempt,
takes care to automatically pick an appropriate, monotonically increasing,
sequence numbe

scmi: Add scmi_token_reserve helper

During normal operation, the SCMI stack, upon each transmission attempt,
takes care to automatically pick an appropriate, monotonically increasing,
sequence number to fill-in the token field in the egressing message.

This does not cope well with the alternative scenario in which, instead,
a complete and fully formed message is provided upfront: in such a case the
SCMI stack will have to use the already provided sequence number, embedded
in the message, to track such transaction.

Add a method to attempt to reserve a specific sequence number to be used
when a fully firmed (raw) message is handled.

Tested on: Arm Morello Board
Reported by: andrew
Sponsored by: Arm ltd
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>

show more ...

scmi: Add helper to manipulate scmi_msg descriptors

Refactor allocation logic for scmi_req and introduce new helpers to be able
to obtain an scmi_msg reference to a freshly allocated request.

Teste

scmi: Add helper to manipulate scmi_msg descriptors

Refactor allocation logic for scmi_req and introduce new helpers to be able
to obtain an scmi_msg reference to a freshly allocated request.

Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47423
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>

show more ...

scmi: Add devicetree transport properties

SCMI transport characteristics can be optionally described in the
devicetree to override the default build-time values.

Tested on: Arm Morello Board
R

scmi: Add devicetree transport properties

SCMI transport characteristics can be optionally described in the
devicetree to override the default build-time values.

Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47422
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>

show more ...

scmi: Redefine max message payload size

The defined maximum payload size should not include header and status
field. Fix the definition accordingly, so that it matches the
definitions as can be foun

scmi: Redefine max message payload size

The defined maximum payload size should not include header and status
field. Fix the definition accordingly, so that it matches the
definitions as can be found in the Linux SCMI stack.
The semantic of this define is important since it will then be possible
to override such values from devicetree, like in Linux.

Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Differential Revision: https://reviews.freebsd.org/D47421
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>

show more ...

scmi: Make transports report the effective length of the received messages

Once a message is received that fits into the RX buffer, update the
msg.rx_len field with the effective length of the messa

scmi: Make transports report the effective length of the received messages

Once a message is received that fits into the RX buffer, update the
msg.rx_len field with the effective length of the message received.

Tested on: Arm Morello Board
Reviewed by: andrew
Sponsored by: Arm Ltd
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>

show more ...

Revert "scmi: Make transports report the effective length of the received messages"

Revert to reapply series as some patches were incorrect versions

This reverts commit 9342829d578e26f10a5cbc26e2b9

Revert "scmi: Make transports report the effective length of the received messages"

Revert to reapply series as some patches were incorrect versions

This reverts commit 9342829d578e26f10a5cbc26e2b9e66cfd9864c4.

show more ...

Revert "scmi: Redefine max message payload size"

Revert to reapply series as some patches were incorrect versions

This reverts commit f0216239492579022982d94e04090f1333fee5a5.

Revert "scmi: Add devicetree transport properties"

Revert to reapply series as some patches were incorrect versions

This reverts commit 103ea03e6713a0f3bb874472fbd9fd81e2278805.

Revert "scmi: Add helper to manipulate scmi_msg descriptors"

Revert to reapply series as some patches were incorrect versions

This reverts commit e887179d4bc032e79d0334371d613c5841989a41.

Revert "scmi: Add scmi_token_reserve helper"

Revert to reapply series as some patches were incorrect versions

This reverts commit c508841dfc5923ef81ed8ea61da364fb20616bbf.

Revert "scmi: Refactor scmi_request internal logic"

Revert to reapply series as some patches were incorrect versions

This reverts commit 341d8fd90fa084d074059051478657cb45e53402.

Revert "scmi: Add optional asynchronous handling of replies"

Revert to reapply series as some patches were incorrect versions

This reverts commit b802926b7b145d7cfe2465ac4e19f062a9eb6e6d.

Revert "scmi: Add SDT traces to the core stack"

Revert to reapply series as some patches were incorrect versions

This reverts commit 984f9fb81a9dfb9780c9bcc99607ad7cac3a72dd.

Revert "scmi: Add sysctl transport properties"

Revert to reapply series as some patches were incorrect versions

This reverts commit e6d0edd2fe8c3c15faa7c9c66703efa007a5fbe1.