ciss: Don't panic on null CR ciss_dequeue_notify

Apparently, sometimes on hot plug/unplug, a null cr comes back from
ciss_dequeue_notify. This is clearly a bug, and by ignoring it we're
papering ove

ciss: Don't panic on null CR ciss_dequeue_notify

Apparently, sometimes on hot plug/unplug, a null cr comes back from
ciss_dequeue_notify. This is clearly a bug, and by ignoring it we're
papering over that bug. We only ever wake the thread after enqueing a
notification or setting a bit about killing the thread, so once we check
the bit isn't the cause, cr can't be NULL unless something else has
dequeued it.

Ideally, this would be fixed, rather than papered over, but this makes a
very old card somewhat more useable for external enclosures. I suspect
it's a race when we set CISS_THREAD_SHUT and another flag (the latter
w/o ciss_mtx held), but I don't see it and w/o hardware to reproduce
it would be hard to know for sure.

PR: 246279
Reviewed by: imp
Tested by: Marek Zarychta
Differential Revision: https://reviews.freebsd.org/D25155

show more ...

ciss: hw.ciss.initator_id to set the initiator ID

Add hw.ciss.inititor_id to set the initiator to something other than the
default.

PR: 246279
Reviewed by: imp
Tested by: Marek Zarychta
Differentia

ciss: hw.ciss.initator_id to set the initiator ID

Add hw.ciss.inititor_id to set the initiator to something other than the
default.

PR: 246279
Reviewed by: imp
Tested by: Marek Zarychta
Differential Revision: https://reviews.freebsd.org/D25155

show more ...

ciss: Add max physical target

Add support for tracking the maximum physical target and using that to
override the maximum logical target.

PR: 246279
Reviewed by: imp
Tested by: Marek Zarychta
Diffe

ciss: Add max physical target

Add support for tracking the maximum physical target and using that to
override the maximum logical target.

PR: 246279
Reviewed by: imp
Tested by: Marek Zarychta
Differential Revision: https://reviews.freebsd.org/D25155

show more ...

ciss: Expose tunable hw.ciss.force_interrupt as sysctl

Expose the hw.ciss.force_interrupt tuneable as a sysctl and make it
writeable at runtime.

PR: 246279
Reviewed by: imp
Tested by: Marek Zarycht

ciss: Expose tunable hw.ciss.force_interrupt as sysctl

Expose the hw.ciss.force_interrupt tuneable as a sysctl and make it
writeable at runtime.

PR: 246279
Reviewed by: imp
Tested by: Marek Zarychta
Differential Revision: https://reviews.freebsd.org/D25155

show more ...

ciss: Expose tunable hw.ciss.force_transport as sysctl

Expose the hw.ciss.force_transport tuneable as a sysctl and make it
writeable at runtime.

PR: 246279
Reviewed by: imp
Tested by: Marek Zarycht

ciss: Expose tunable hw.ciss.force_transport as sysctl

Expose the hw.ciss.force_transport tuneable as a sysctl and make it
writeable at runtime.

PR: 246279
Reviewed by: imp
Tested by: Marek Zarychta
Differential Revision: https://reviews.freebsd.org/D25155

show more ...

ciss: Expose tunable hw.ciss.nop_message_heartbeat as sysctl

Expose the hw.ciss.nop_message_heartbeat tuneable as a sysctl and make
it writeable at runtime.

PR: 246279
Reviewed by: imp
Tested by: M

ciss: Expose tunable hw.ciss.nop_message_heartbeat as sysctl

Expose the hw.ciss.nop_message_heartbeat tuneable as a sysctl and make
it writeable at runtime.

PR: 246279
Reviewed by: imp
Tested by: Marek Zarychta
Differential Revision: https://reviews.freebsd.org/D25155

show more ...

ciss: Expose tunable hw.ciss.expose_hidden_physical as sysctl

Expose the hw.ciss.expose_hidden_physical tuneable as a sysctl
and make it writeable at runtime.

PR: 246279
Reviewed by: imp
Tested by:

ciss: Expose tunable hw.ciss.expose_hidden_physical as sysctl

Expose the hw.ciss.expose_hidden_physical tuneable as a sysctl
and make it writeable at runtime.

PR: 246279
Reviewed by: imp
Tested by: Marek Zarychta
Differential Revision: https://reviews.freebsd.org/D25155

show more ...

ciss: Report more errors at higher ciss_verbose levels

Report more information on errors, including the the opcode.

PR: 246279
Reviewed by: imp
Tested by: Marek Zarychta
Differential Revision: http

ciss: Report more errors at higher ciss_verbose levels

Report more information on errors, including the the opcode.

PR: 246279
Reviewed by: imp
Tested by: Marek Zarychta
Differential Revision: https://reviews.freebsd.org/D25155

show more ...

ciss: Add sysctl/tunable hw.ciss.verbose

Add tuneable to turn on/off verbosity for debugging purposes. This is
approximately the same as bootverbose, but will print even more
information when > 1.

ciss: Add sysctl/tunable hw.ciss.verbose

Add tuneable to turn on/off verbosity for debugging purposes. This is
approximately the same as bootverbose, but will print even more
information when > 1.

PR: 246279
Reviewed by: imp
Tested by: Marek Zarychta
Differential Revision: https://reviews.freebsd.org/D25155

show more ...

ciss: Add sysctl/tunable hw.ciss and hw.ciss.base_transfer_speed

Add a sysctl/tuneable to report a different base transfer speed than the
default of 132*1024.

PR: 246279
Reviewed by: imp
Tested by:

ciss: Add sysctl/tunable hw.ciss and hw.ciss.base_transfer_speed

Add a sysctl/tuneable to report a different base transfer speed than the
default of 132*1024.

PR: 246279
Reviewed by: imp
Tested by: Marek Zarychta
Differential Revision: https://reviews.freebsd.org/D25155

show more ...

ciss: Ignore data over/under run on RECEIVE_DIAGNOSTIC

This appears to be harmless, so ignore data over/under run on
diagnostics.

PR: 246279
Reviewed by: imp
Tested by: Marek Zarychta
Differential

ciss: Ignore data over/under run on RECEIVE_DIAGNOSTIC

This appears to be harmless, so ignore data over/under run on
diagnostics.

PR: 246279
Reviewed by: imp
Tested by: Marek Zarychta
Differential Revision: https://reviews.freebsd.org/D25155

show more ...

sys: Remove $FreeBSD$: two-line .h pattern

Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/

spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSD

The SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catch
up to that fact and revert to their recommended match of

spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSD

The SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catch
up to that fact and revert to their recommended match of BSD-2-Clause.

Discussed with: pfg
MFC After: 3 days
Sponsored by: Netflix

show more ...

ciss: Fix typo

Although unused, fixed type in CISS_BOARD_UNKNOWN #define.

Submitted by: Peter Eriksson (a trivial part of D25155)

ciss: Remove unused devclass argument to DRIVER_MODULE.

Fix "set but not used" for real in the ciss driver.

Fix "set but not used" warnings in the ciss driver.

ciss(4): Fix typo.

ciss(4): Properly handle data underrun.

For SCSI data underrun is a part of normal life. It should not be
reported as error. This fixes MODE SENSE used by modern CAM.

MFC after: 1 month

ciss: clean up empty lines in .c and .h files

Add missing STAILQ_INIT() in ciss_disable_adapter().

I think it should fix reported panic after "ADAPTER HEARTBEAT FAILED".

MFC after: 2 weeks
Sponsored by: iXsystems, Inc.

MFHead @349234

Sponsored by: The FreeBSD Foundation

Don't print the request we may be aborting in ciss_notify_abort as
part of ciss_detach. It's a left-over debug that isn't needed and also
discloses a kernel address. Only root could provoke as part o

Don't print the request we may be aborting in ciss_notify_abort as
part of ciss_detach. It's a left-over debug that isn't needed and also
discloses a kernel address. Only root could provoke as part of a
devctl or kldunload.

Submitted by: Fuqian Huang
MFC After: 1 week

show more ...

MFH r338661 through r339200.

Sponsored by: The FreeBSD Foundation

Merge ^/head r338731 through r338987.