bnxt_en: Improve sysctl handler bnxt_dcb_list_app()

Prefer sbuf_new_for_sysctl() over error-prone manually managed buffer.

No functional change intended.

Reviewed by: markj
Tested by: Daniel Porsc

bnxt_en: Improve sysctl handler bnxt_dcb_list_app()

Prefer sbuf_new_for_sysctl() over error-prone manually managed buffer.

No functional change intended.

Reviewed by: markj
Tested by: Daniel Porsch <daniel.porsch@loopia.se>
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D48496

show more ...

bnxt_en: Remove pointless NULL check for sysctl arg1

Those sysctl handlers have been guaranteed to have non-null softc. No
need for NULL check within sysctl handlers.

No functional change intended.

bnxt_en: Remove pointless NULL check for sysctl arg1

Those sysctl handlers have been guaranteed to have non-null softc. No
need for NULL check within sysctl handlers.

No functional change intended.

Reviewed by: markj
Tested by: Daniel Porsch <daniel.porsch@loopia.se>
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D48495

show more ...

bnxt_en: Fix the description of sysctl knob dev.bnxt.X.dcb.dcbx_cap

While here, update the description of dev.bnxt.X.dcb to more informative
words "Data Center Bridging".

Reviewed by: markj
Fixes:

bnxt_en: Fix the description of sysctl knob dev.bnxt.X.dcb.dcbx_cap

While here, update the description of dev.bnxt.X.dcb to more informative
words "Data Center Bridging".

Reviewed by: markj
Fixes: 35b53f8c989f bnxt_en: Add PFC, ETS & App TLVs protocols support
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D48993

show more ...

bnxt_en: Retrieve maximum of 128 APP TLVs

It appears that the maximum number of APP TLVs supported by the hardware
is 128 according to D45005. Well Daniel Porsch reported an issue PR284073
which sho

bnxt_en: Retrieve maximum of 128 APP TLVs

It appears that the maximum number of APP TLVs supported by the hardware
is 128 according to D45005. Well Daniel Porsch reported an issue PR284073
which shows that the number can exceed the limit, causing out of bound
write to on-stack allocated variable app[128] and the kernel panics.

Limit to 128 while retrieving APP TLVs.

PR: 284073
Reviewed by: markj
Tested by: Daniel Porsch <daniel.porsch@loopia.se>
Fixes: 35b53f8c989f bnxt_en: Add PFC, ETS & App TLVs protocols support
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D48589

show more ...

bnxt_en: Firmware error recovery support

Implement firmware error recovery support for Thor adapters.
This entails enabling the capability for the firmware to initiate
error recovery. Specifically,

bnxt_en: Firmware error recovery support

Implement firmware error recovery support for Thor adapters.
This entails enabling the capability for the firmware to initiate
error recovery. Specifically, the firmware will send the reset notify
asynchronous event to notify the driver of an error and impending reset.
Subsequently, the driver will queue a task to execute the following steps.

1. Deactivate the allocated resources.
2. Await completion of the firmware's recovery process.
3. Configure the resources and reactivate the network interface.

Reviewed by: imp
Approved by: imp
Differential revision: https://reviews.freebsd.org/D45008

show more ...

bnxt_en: Added support for priority queues extended stats

Below priority queues extended stats are exposed to sysctl:

tx_bytes_pri{0-7}
rx_bytes_pri{0-7}
tx_packets_pri{0-7}
rx_packets_pri{0-7}

Re

bnxt_en: Added support for priority queues extended stats

Below priority queues extended stats are exposed to sysctl:

tx_bytes_pri{0-7}
rx_bytes_pri{0-7}
tx_packets_pri{0-7}
rx_packets_pri{0-7}

Reviewed by: imp
Approved by: imp
Differential revision: https://reviews.freebsd.org/D45007

show more ...

bnxt_en: L2-RoCE driver communication interface

- Added Aux bus support for RoCE.
- Implemented the ulp ops that are required by RoCE driver.
- Restructure context memory data structures
- DBR pacin

bnxt_en: L2-RoCE driver communication interface

- Added Aux bus support for RoCE.
- Implemented the ulp ops that are required by RoCE driver.
- Restructure context memory data structures
- DBR pacing support

Reviewed by: imp
Approved by: imp
Differential revision: https://reviews.freebsd.org/D45006

show more ...

bnxt_en: Add PFC, ETS & App TLVs protocols support

Created new directory "bnxt_en" in /dev/bnxt and /modules/bnxt
and moved source files and Makefile into respective directory.

ETS support:

- A

bnxt_en: Add PFC, ETS & App TLVs protocols support

Created new directory "bnxt_en" in /dev/bnxt and /modules/bnxt
and moved source files and Makefile into respective directory.

ETS support:

- Added new files bnxt_dcb.c & bnxt_dcb.h
- Added sysctl node 'dcb' and created handlers 'ets' and
'dcbx_cap'
- Add logic to validate user input and configure ETS in
the firmware
- Updated makefile to include bnxt_dcb.c & bnxt_dcb.h

PFC support:

- Created sysctl handlers 'pfc' under node 'dcb'
- Added logic to validate user input and configure PFC in
the firmware.

App TLV support:

- Created 3 new sysctl handlers under node 'dcb'
- set_apptlv (write only): Sets a specified TLV
- del_apptlv (write only): Deletes a specified TLV
- list_apptlv (read only): Lists all APP TLVs configured
- Added logic to validate user input and configure APP TLVs
in the firmware.

Added Below DCB ops for management interface:

- Set PFC, Get PFC, Set ETS, Get ETS, Add App_TLV, Del App_TLV
Lst App_TLV

Reviewed by: imp
Approved by: imp
Differential revision: https://reviews.freebsd.org/D45005

show more ...