bce_vhci: fix duplicate endpoint queue registration, ratelimit failure logging

bce_vhci_endpoint_create() was registering both the IN and OUT
submission queues on every call, regardless of which dir

bce_vhci: fix duplicate endpoint queue registration, ratelimit failure logging

bce_vhci_endpoint_create() was registering both the IN and OUT
submission queues on every call, regardless of which direction
the endpoint actually needed.
The per-stage firmware registration failures weren't rate-limited,
so a stuck registration will spam the console.

Tested on:
MacBookPro15,2
Macmini8,1
MacBookPro15,3
MacBookPro16,2

Reviewed by: adrian
Differential Revision: https://reviews.freebsd.org/D58831

show more ...

apple_bce: initiate IN data phase for control transfers

For IN control transfers, the firmware does
not send TRANSFER_REQUEST for the data phase
the host must send BCE_VHCI_CMD_TRANSFER_REQUEST
with

apple_bce: initiate IN data phase for control transfers

For IN control transfers, the firmware does
not send TRANSFER_REQUEST for the data phase
the host must send BCE_VHCI_CMD_TRANSFER_REQUEST
with an IN DMA buffer once the setup phase completes.

Reviewed by: adrian
Differential Revision: https://reviews.freebsd.org/D58872

show more ...

apple_bce: fix C_CONNECT_STATUS during port reset

Only set the port change bit when the corresponding status bit
actually transitioned, instead of unconditionally flagging
C_CONNECT_STATUS on every

apple_bce: fix C_CONNECT_STATUS during port reset

Only set the port change bit when the corresponding status bit
actually transitioned, instead of unconditionally flagging
C_CONNECT_STATUS on every port change event. Also clear any
flaky C_CONNECT_STATUS that the port change taskqueue may have
set while the bus lock was dropped during a successful port reset.

Reviewed by: adrian
Differential Revision: https://reviews.freebsd.org/D58875

show more ...

apple_bce: ignore duplicate TRANSFER_REQUEST in STATUS state

Since the host initiates IN data transfers, the
firmware's own TRANSFER_REQUEST for the same phase arrives after
we've already moved to S

apple_bce: ignore duplicate TRANSFER_REQUEST in STATUS state

Since the host initiates IN data transfers, the
firmware's own TRANSFER_REQUEST for the same phase arrives after
we've already moved to STATUS state. Ignoring instead of failing
the transfer with USB_ERR_IOERROR.

Reviewed by: adrian
Differential Revision: https://reviews.freebsd.org/D58873

show more ...

apple_bce: fix cold boot panic in mailbox send

Poll mailbox reply registers with DELAY() when the system is still
cold, falling back to the interrupt-driven
sema_timedwait path once timers are avail

apple_bce: fix cold boot panic in mailbox send

Poll mailbox reply registers with DELAY() when the system is still
cold, falling back to the interrupt-driven
sema_timedwait path once timers are available.

Reviewed by: adrian
Differential Revision: https://reviews.freebsd.org/D58871

show more ...

apple_bce: kick USB explore thread after VHCI attach

Call usb_needs_explore() after attach so the hub explore thread
enumerates all initially connected ports instead of only the first.

Reviewed by:

apple_bce: kick USB explore thread after VHCI attach

Call usb_needs_explore() after attach so the hub explore thread
enumerates all initially connected ports instead of only the first.

Reviewed by: adrian
Differential Revision: https://reviews.freebsd.org/D58870

show more ...