net80211: LinuxKPI: migrate HE IE structs from LinuxKPI to net80211

Take the HE IE structures as they are used by drivers and put them
into net80211 rather than LinuxKPI. There is little need to
re

net80211: LinuxKPI: migrate HE IE structs from LinuxKPI to net80211

Take the HE IE structures as they are used by drivers and put them
into net80211 rather than LinuxKPI. There is little need to
re-invent the wheel on those. They settled for long enough.

Do not export them by default to user space as some also overlap with
wpa and we still do not have a clear distinction for what is available
only in kernel and what to user space. In our case ifconfig(8)
is a consumer of these structs which it can setting WANT_NET80211 like
we have done for some VHT bits before.

Add struct net80211_he_cap which holds the IE fields but also a bool
and is meant to be put into ic/vap/ni. The bool will give us the same
naming for all layers rather than having individual flags in each part
which was highly confusing. In theory this struct should be in
ieee80211_var.h but that would pull things apart.

Extend struct ieee80211_mu_edca_param_set by a union as it will help
ifconfig(8) parsing the bk/be/vi/vo parts.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Reviewed by: adrian
Differential Revision: https://reviews.freebsd.org/D50676

show more ...

LinuxKPI: 802.11: add ieee80211_purge_tx_queue()

Add ieee80211_purge_tx_queue() dummy function needed by rtw88 SDIO.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

LinuxKPI: 802.11: header updates for mt76

Add more structs, fields, flags, defines.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

LinuxKPI: 802.11: updates to headers for driver update

Move some structs into the appropriate header to be visible.
Add new fields to structs and enums.

Remove arguments from two functions (one fun

LinuxKPI: 802.11: updates to headers for driver update

Move some structs into the appropriate header to be visible.
Add new fields to structs and enums.

Remove arguments from two functions (one function currently unused
by drivers in the tree, for the other the argument was unused).
Adjust the iwlwifi accordingly. This is in preparation for new
driver versions to allow a smooth transition.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

show more ...

LinuxKPI: 802.11: introduce mlo field to sta

Driver updates introduce a new field "mlo" to the sta.
Add the field to the struct and initialize it in the 802.11 compat
code along with a IMPROVE so on

LinuxKPI: 802.11: introduce mlo field to sta

Driver updates introduce a new field "mlo" to the sta.
Add the field to the struct and initialize it in the 802.11 compat
code along with a IMPROVE so once we get to 11be we can deal with it.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

show more ...

LinuxKPI: 802.11: add IEEE80211_KEY_FLAG_BITS

Add IEEE80211_KEY_FLAG_BITS to be used with %b for debugging
ieee802111_key_flag bit flags. Names are a lot easier to deal
with than just numbers.

Spo

LinuxKPI: 802.11: add IEEE80211_KEY_FLAG_BITS

Add IEEE80211_KEY_FLAG_BITS to be used with %b for debugging
ieee802111_key_flag bit flags. Names are a lot easier to deal
with than just numbers.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

show more ...

LinuxKPI: 802.11: fill ieee80211_get_key_rx_seq() also for TKIP/GCMP

In addition to CCMP add TKIP and GCMP support. The others are still
TODO() until we do suport them natively.
Also refine checks

LinuxKPI: 802.11: fill ieee80211_get_key_rx_seq() also for TKIP/GCMP

In addition to CCMP add TKIP and GCMP support. The others are still
TODO() until we do suport them natively.
Also refine checks for tid and narrow them down (also don't assert but
gratiously fail).

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

show more ...

LinuxKPI 802.11: move key-related functions together

No functional changes.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

LinuxKPI: 802.11: more fields moved from vif to bss_conf

csa_active, color_change_active, mu_mimo_owner also moved from
vif to bss_conf; we already have the fields in bss_conf (adjust type
for one)

LinuxKPI: 802.11: more fields moved from vif to bss_conf

csa_active, color_change_active, mu_mimo_owner also moved from
vif to bss_conf; we already have the fields in bss_conf (adjust type
for one) so all we have to do is remove the old relics in vif.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Tested by: Oleksandr Kryvulia (shuriku shurik.kiev.ua)
Tested by: Oleg Nauman (oleg.nauman gmail.com) [rtw88]
Differential Revision: https://reviews.freebsd.org/D49734

show more ...

LinuxKPI: 802.11: move chanctx_conf from vif to vif->bss_conf

In preparations for MLD support chanctx_conf was moved from vif to
the bss_conf as it will be per-link later. Follow accordingly.

Spon

LinuxKPI: 802.11: move chanctx_conf from vif to vif->bss_conf

In preparations for MLD support chanctx_conf was moved from vif to
the bss_conf as it will be per-link later. Follow accordingly.

Sponsored by: The FreeBSD Foundation
PR: 280546
MFC after: 3 days
Tested by: Oleksandr Kryvulia (shuriku shurik.kiev.ua)
Tested by: Oleg Nauman (oleg.nauman gmail.com) [rtw88]
Differential Revision: https://reviews.freebsd.org/D49734

show more ...

LinuxKPI: 802.11: reduce code duplication introducing lkpi_remove_chanctx()

We have the same code three times, so factor it out into its own
function to make it easier to maintain.

Sponsored by: Th

LinuxKPI: 802.11: reduce code duplication introducing lkpi_remove_chanctx()

We have the same code three times, so factor it out into its own
function to make it easier to maintain.

Sponsored by: The FreeBSD Foundation
PR: 280546
MFC after: 3 days
Tested by: Oleksandr Kryvulia (shuriku shurik.kiev.ua)
Tested by: Oleg Nauman (oleg.nauman gmail.com) [rtw88]
Differential Revision: https://reviews.freebsd.org/D49734

show more ...

LinuxKPI: 802.11: remove cipher_scheme support

iwlwifi was the only driver we care about which "used" cipher_scheme
and it was removed from there too. Remove given it is no longer
used anywhere.

S

LinuxKPI: 802.11: remove cipher_scheme support

iwlwifi was the only driver we care about which "used" cipher_scheme
and it was removed from there too. Remove given it is no longer
used anywhere.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

show more ...

LinuxKPI: 802.11: CONFIG_PM_SLEEP / WoWLAN header adjustments

Sort out some (though not yet all) changes needed for CONFIG_PM_SLEEP
and respectively WoWLAN support (so we can compile it in). This i

LinuxKPI: 802.11: CONFIG_PM_SLEEP / WoWLAN header adjustments

Sort out some (though not yet all) changes needed for CONFIG_PM_SLEEP
and respectively WoWLAN support (so we can compile it in). This is
just one further step towards proper suspend/resume support.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

show more ...

LinuxKPI: 802.11: crypto pn lengths

Define the last missing PN length and for consistency use them
in struct ieee80211_key_seq (even though a 6 is a 6 is a 6).

Sponsored by: The FreeBSD Foundation

LinuxKPI: 802.11: crypto pn lengths

Define the last missing PN length and for consistency use them
in struct ieee80211_key_seq (even though a 6 is a 6 is a 6).

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

show more ...

LinuxKPI: 802.11: add condition to TODO in ieee80211_sta_recalc_aggregates

ieee80211_sta_recalc_aggregates() shows up in TODO traces but there is
nothing we have to do there until we have active lin

LinuxKPI: 802.11: add condition to TODO in ieee80211_sta_recalc_aggregates

ieee80211_sta_recalc_aggregates() shows up in TODO traces but there is
nothing we have to do there until we have active links (MLO support).
Make the TODO conditional for a time when we will get there.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

show more ...

LinuxKPI: 802.11: hardware crypto offload improvements

Implement mac80211 functions ieee80211_iter_keys[_rcu](), and
ieee80211_get_key_rx_seq() (*).
Implement an internal function lkpi_sta_del_keys(

LinuxKPI: 802.11: hardware crypto offload improvements

Implement mac80211 functions ieee80211_iter_keys[_rcu](), and
ieee80211_get_key_rx_seq() (*).
Implement an internal function lkpi_sta_del_keys() to delete keys
when we are leaving RUN (AUTHORIZED) state.
Improve and make work (*) the net80211 vap function pointers
(*iv_key_set)(), (*iv_key_delete)() implementations.
Correct the logic in lkpi_80211_txq_tx_one() and factor most crypto
related bits out into lkpi_hw_crypto_prepare() (*).

(*) We are currently supporting CCMP only. I would hope we will
not have to do full WEP/TKIP support anymore given both are deprecated.

The entire logic remains behind the LKPI_80211_HW_CRYPTO pre-processor
condition and with this commit in addition behind a tunable.
The code is compiled in by default now but the tunable remains off until
wider testing has shown no problems.
I have seen one net80211 triggered panic on shutdown related to deleting
keys which I cannot reproduce anymore and could have been fixed by
9763fec11b83; otherwise we will have to investigate as it shows again.
The dedicated hw crypto tracing option can help in that case with debug
kernels.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Fixes: b35f6cd06612

show more ...

LinuxKPI: 802.11: ieee80211_vif_usable_links()

ieee80211_vif_usable_links() shows up in TODO() tracking.
Turns out the return (1) is likely wrong and should be 0 given we do
not support MLD yet. Fo

LinuxKPI: 802.11: ieee80211_vif_usable_links()

ieee80211_vif_usable_links() shows up in TODO() tracking.
Turns out the return (1) is likely wrong and should be 0 given we do
not support MLD yet. For now return the valid_links bitmap and leave
an IMPROVE as likely not all of the valid ones will be useable.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

show more ...

LinuxKPI: 802.11: make struct ieee80211_tx_info a bit more packed

Given I was looking at the struct make it more packed at the beginning
at least. In fact it did not shrink but the tx_time_est got

LinuxKPI: 802.11: make struct ieee80211_tx_info a bit more packed

Given I was looking at the struct make it more packed at the beginning
at least. In fact it did not shrink but the tx_time_est got expanded.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

show more ...

LinuxKPI: 802.11: fill in a lot more RX status fields

Convert a lot more LinuxKPI rx_status fields to net80211 rx_stats
bits for as much as we can see fit. Factor the entire logic out
into its own

LinuxKPI: 802.11: fill in a lot more RX status fields

Convert a lot more LinuxKPI rx_status fields to net80211 rx_stats
bits for as much as we can see fit. Factor the entire logic out
into its own function as it got quite long.

Now only net80211 needs to start using more of these values and
report them.

Also fix some related fields and struct definitions in LinuxKPI.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

show more ...

LinuxKPI: 802.11: implement various VHT helper functions

Implement ieee80211_rate_set_vht(), ieee80211_rate_get_vht_{mcs,nss}(),
and ieee80211_get_vht_max_nss().

Sponsored by: The FreeBSD Foundatio

LinuxKPI: 802.11: implement various VHT helper functions

Implement ieee80211_rate_set_vht(), ieee80211_rate_get_vht_{mcs,nss}(),
and ieee80211_get_vht_max_nss().

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

show more ...

LinuxKPI: 802.11: remove rate_lowest_index()

rate_lowest_index() is no longer used anywhere in our code.
Garbage collect it.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

LinuxKPI: 802.11: implement ieee80211_get_{he,eht}_iftype_cap{,_vif}

Implement the combination of all four functions, the *_vif versions
from mac80211.h as a wrapper to the non-*_vif ones in cfg8021

LinuxKPI: 802.11: implement ieee80211_get_{he,eht}_iftype_cap{,_vif}

Implement the combination of all four functions, the *_vif versions
from mac80211.h as a wrapper to the non-*_vif ones in cfg80211.h.
Put the function pairs next to each other and in the right files
and harmonize argument naming, etc.

Both of them have shown up too often in the todo-tracing to bother
enough to implement them now for a time in the future when we will
support HE/EHT.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

show more ...

LinuxKPI: 802.11: turn on debugfs for iwlwifi and rtw88

Make iwlwifi compile with debugfs after the last updates and turn it on
for both iwlwifi and rtw88 in order to be able to get at least some
us

LinuxKPI: 802.11: turn on debugfs for iwlwifi and rtw88

Make iwlwifi compile with debugfs after the last updates and turn it on
for both iwlwifi and rtw88 in order to be able to get at least some
useful information on driver/firwmare state.

Sponsored by: The FreeBSD Foundation
MFC after: 10 days

show more ...

LinuxKPI: 802.11: add a print mask for ieee80211_rx_status_flags bits

Add a print mask for use with %b to aid debugging. It is a lot easier
to read names than numbers.

Sponsored by: The FreeBSD Fo

LinuxKPI: 802.11: add a print mask for ieee80211_rx_status_flags bits

Add a print mask for use with %b to aid debugging. It is a lot easier
to read names than numbers.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

show more ...

LinuxKPI: 802.11: adjustments for v6.11 iwlwifi, rtw88 and rtw89

Bring in the LinuxKPI 802.11 compat bits which are altering
the mac80211 KPI.

* In struct ieee80211_bss_conf chandef -> chanreq.
* V

LinuxKPI: 802.11: adjustments for v6.11 iwlwifi, rtw88 and rtw89

Bring in the LinuxKPI 802.11 compat bits which are altering
the mac80211 KPI.

* In struct ieee80211_bss_conf chandef -> chanreq.
* Various struct ieee80211_ops gained a link_id arguemnt,
stop gained a suspend flag.
* Various functions gained a link_id argument.
* ieee80211_tx_status() was renamed to ieee80211_tx_status_skb()

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

show more ...