release: stop disabling sendmail

sendmail is already disabled by default everywhere since 14.0

MFC After: 1 week
Approved by: emaste (re)
Reviewed by: emaste (re)
Differential Revision: https://rev

release: stop disabling sendmail

sendmail is already disabled by default everywhere since 14.0

MFC After: 1 week
Approved by: emaste (re)
Reviewed by: emaste (re)
Differential Revision: https://reviews.freebsd.org/D54575

show more ...

release: Use make's `:H` rather than `/..`

In general we want to strip subdir components, rather than appending
`..`s.

Reviewed by: lwhsu
Sponsored by: The FreeBSD Foundation
Differential Revision:

release: Use make's `:H` rather than `/..`

In general we want to strip subdir components, rather than appending
`..`s.

Reviewed by: lwhsu
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D54373

show more ...

release: Add WITHOUT_QEMU to IMAKE

We have NO_ROOT here, so we need WITHOUT_QEMU to avoid problems.

15.0 candidate.

Reviewed by: emaste, markj
MFC after: 3 days
Differential Revision: https://revi

release: Add WITHOUT_QEMU to IMAKE

We have NO_ROOT here, so we need WITHOUT_QEMU to avoid problems.

15.0 candidate.

Reviewed by: emaste, markj
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D53637

show more ...

release: Add pkg .conf to METALOG on dvd

We're correctly recording all of the packages in the dvd METALOG file,
but if we don't record ./packages/repos/FreeBSD_install_cdrom.conf then
users won't be

release: Add pkg .conf to METALOG on dvd

We're correctly recording all of the packages in the dvd METALOG file,
but if we don't record ./packages/repos/FreeBSD_install_cdrom.conf then
users won't be able to install them very easily.

Reviewed by: markj
Reported by: Lars Tunkrans
MFC after: 3 days
Sponsored by: https://www.patreon.com/cperciva
Differential Revision: https://reviews.freebsd.org/D53199

show more ...

release: Fix dependency ordering

The 'make release' command triggers some sub-builds, in particular
'real-release' (which builds install images) and 'vm-release' (which
builds VM images). These bot

release: Fix dependency ordering

The 'make release' command triggers some sub-builds, in particular
'real-release' (which builds install images) and 'vm-release' (which
builds VM images). These both now depend on pkgbase-repo.

Unfortunately for historical reasons 'make real-release' has used a
recursive make instead of proper make dependencies; this results in
the pkgbase-repo target being invoked twice since the recursive make
does not have any awareness of the targets being run by the parent
make command. Since the pkgbase-repo target starts by creating the
pkgbase-repo directory, the second make command incorrectly assumes
that target has already been built; this showed up in 15.0-ALPHA5
builds with pkgbase-repo.tar being empty as it was created after the
pkgbase-repo directory was created by before that directory had been
populated.

Change
real-release:
make obj
make ${RELEASE_TARGETS}
to a single line
real-release: obj .WAIT ${RELEASE_TARGETS}
in order to handle dependency deduplication properly while keeping
the intended behaviour that "obj" completes before ${RELEASE_TARGETS}.

Diagnosed by: jrtc27, emaste
Reviewed by: emaste
MFC after: 1 day
Sponsored by: https://www.patreon.com/cperciva
Differential Revision: https://reviews.freebsd.org/D52972

show more ...

release: Publish pkgbase-repo.tar

This is a tarball containing the pkgbase repository for the release.

Note: This is an uncompressed tarball, because all of its constituent
.pkg files are already c

release: Publish pkgbase-repo.tar

This is a tarball containing the pkgbase repository for the release.

Note: This is an uncompressed tarball, because all of its constituent
.pkg files are already compressed; there's no point adding another
layer of compression.

Reviewed by: ivy
MFC after: 1 minute
Sponsored by: https://www.patreon.com/cperciva
Differential Revision: https://reviews.freebsd.org/D52899

show more ...

release: Respect NODISTSETS

In addition to not putting distribution sets onto ISO images, if
NODISTSETS is set then we should not build the distribution sets
or put them onto the "FTP" site (aka dow

release: Respect NODISTSETS

In addition to not putting distribution sets onto ISO images, if
NODISTSETS is set then we should not build the distribution sets
or put them onto the "FTP" site (aka download.freebsd.org).

MFC after: 3 days
Sponsored by: https://www.patreon.com/cperciva

show more ...

release: Check for empty NODISTSETS

Treat an empty NODISTSETS the same as if it is not defined; this avoids
problems if a script calls 'make release NODISTSETS=${NODISTSETS}'.

MFC after: 3 days
Spo

release: Check for empty NODISTSETS

Treat an empty NODISTSETS the same as if it is not defined; this avoids
problems if a script calls 'make release NODISTSETS=${NODISTSETS}'.

MFC after: 3 days
Sponsored by: https://www.patreon.com/cperciva

show more ...

release: Consolidate pkgbase-repo dependency

Use the same approach for pkgbase-repo-dir as for the packagesystem
dependency.

Reviewed by: Isaac Freund <ifreund@freebsdfoundation.org>
Sponsored by:

release: Consolidate pkgbase-repo dependency

Use the same approach for pkgbase-repo-dir as for the packagesystem
dependency.

Reviewed by: Isaac Freund <ifreund@freebsdfoundation.org>
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52884

show more ...

release: Fix NO_ROOT cross-building VM images

Pass PKG_ABI to virtual machine image builds.

Reviewed by: cperciva
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd

release: Fix NO_ROOT cross-building VM images

Pass PKG_ABI to virtual machine image builds.

Reviewed by: cperciva
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52874

show more ...

release: Install pkg(8) from the release repo on bootonly

Although bootonly doesn't contain an offline package repository, we
still want pkg installed so the user can use it to repair an existing
sy

release: Install pkg(8) from the release repo on bootonly

Although bootonly doesn't contain an offline package repository, we
still want pkg installed so the user can use it to repair an existing
system. Installing it from the release repository ensures it's always
available without depending on pkg.freebsd.org.

While here, fix a typo in PKGBASE_REPO_ARGS.

MFC after: 3 seconds
Reviewed by: cperciva
Sponsored by: https://www.patreon.com/bsdivy
Differential Revision: https://reviews.freebsd.org/D52848

show more ...

pkgbase-stage: Use unique PKG_DBDIR

Prior to this commit, pkgbase-stage.lua used a hard-coded PKG_DBDIR
"./pkgdb"; unfortunately this creates a race condition if we start
building disc1.iso and dvd1

pkgbase-stage: Use unique PKG_DBDIR

Prior to this commit, pkgbase-stage.lua used a hard-coded PKG_DBDIR
"./pkgdb"; unfortunately this creates a race condition if we start
building disc1.iso and dvd1.iso at the same time

pkg: sqlite error while executing CREATE TABLE licenses [...]
in file pkgdb.c:2330: table licenses already exists

since pkg checks to see if the pkgdb is initialized and initializes
it if not.

Use separate pkgdb-disc1 and pkgdb-dvd directories.

MFC after: 1 minute
Sponsored by: https://www.patreon.com/cperciva
Differential Revision: https://reviews.freebsd.org/D52755

show more ...

release: create pkgbase VM and cloud images

VM and cloud images are now built as packaged base systems by default,
matching the default for installation media.

Setting -DNOPKGBASE allows building a

release: create pkgbase VM and cloud images

VM and cloud images are now built as packaged base systems by default,
matching the default for installation media.

Setting -DNOPKGBASE allows building as non-pkgbase systems.

Reviewed by: emaste
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D51483

show more ...

release: create pkgbase repo config from Makefile

This will allow the VM image build scripts to use the same repository
config file for installing base system packages at build time.

Reviewed by: e

release: create pkgbase repo config from Makefile

This will allow the VM image build scripts to use the same repository
config file for installing base system packages at build time.

Reviewed by: emaste
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D51482

show more ...

release: Install pkg from the pkgbase repo

If we're building pkgbase media, install the pkg package from the
pkgbase repository we already created, not from pkg.freebsd.org.
Aside from being more de

release: Install pkg from the pkgbase repo

If we're building pkgbase media, install the pkg package from the
pkgbase repository we already created, not from pkg.freebsd.org.
Aside from being more desirable, this also fixes make release for
version/architecture combinations which are missing repository
on pkg.f.o (which is nearly all of them at the time of writing).

This doesn't yet work for bootonly, since we don't build the pkgbase
repository there. For now, restore the old behaviour of attempting
to install pkg from pkg.freebsd.org for bootonly.

MFC after: 1 day
Reviewed by: ifreund_freebsdfoundation.org, cperciva (previous version)
Differential Revision: https://reviews.freebsd.org/D52637

show more ...

release: Fail the build if pkg can't be installed

If we can't install pkg(8) on the media, instead of ignoring the error,
fail the build. This avoids silently creating media which doesn't have
pkg(

release: Fail the build if pkg can't be installed

If we can't install pkg(8) on the media, instead of ignoring the error,
fail the build. This avoids silently creating media which doesn't have
pkg(8) on, and therefore can't be used for a pkgbase install.

Installing pkg(8) can still be entirely disabled by setting NOPKG.

MFC after: 1 day
Reviewed by: ifreund_freebsdfoundation.org, cperciva
Differential Revision: https://reviews.freebsd.org/D52635

show more ...

pkgbootstrap: Gate building from ports

In release builds we want to build pkg from the ports tree for reasons
mentioned in a previous commit; but non-release pkgbase builds may be
just fine with ins

pkgbootstrap: Gate building from ports

In release builds we want to build pkg from the ports tree for reasons
mentioned in a previous commit; but non-release pkgbase builds may be
just fine with installing pkg from pkg.freebsd.org.

Gate it behind BOOTSTRAP_PKG_FROM_PORTS rather than building form ports
any time we have a ports tree available.

While I'm here, make the pkgbase-repo target in release/Makefile
create the temporary directories we need for building.

Reviewed by: ivy
MFC after: 6 hours
Sponsored by: https://www.patreon.com/cperciva
Fixes: 2c06b824436d ("pkgbootstrap: Build pkg if PORTSDIR exists")

show more ...

pkgbase: Don't include pkg by default

We need to put pkg into the pkgbase repository for release builds, but
not for non-release pkgbase builds. Gate the contents of package-pkg
behind INCLUDE_PKG_

pkgbase: Don't include pkg by default

We need to put pkg into the pkgbase repository for release builds, but
not for non-release pkgbase builds. Gate the contents of package-pkg
behind INCLUDE_PKG_IN_PKGBASE_REPO=YES and set that when building
releases.

Reviewed by: ivy
MFC after: 6 hours
Sponsored by: https://www.patreon.com/cperciva

show more ...

release: Always dist sets on dvd1

In the !NOPKGBASE && !NODISTSETS case, we only want the pkgbase repo
on disc1; but we want both packaging formats on dvd in order to allow
for offline installs in b

release: Always dist sets on dvd1

In the !NOPKGBASE && !NODISTSETS case, we only want the pkgbase repo
on disc1; but we want both packaging formats on dvd in order to allow
for offline installs in both methods and also tools which ingest the
dist sets from the dvd image.

MFC after: 12 hours
Sponsored by: https://www.patreon.com/cperciva
Differential Revision: https://reviews.freebsd.org/D52537

show more ...

release: Make PKGBASE the default

Replace the PKGBASE option by a NOPKGBASE option.

Check for both whether the option is defined and whether it is empty,
since when running from release.sh we alway

release: Make PKGBASE the default

Replace the PKGBASE option by a NOPKGBASE option.

Check for both whether the option is defined and whether it is empty,
since when running from release.sh we always define NOPKGBASE.

MFC after: 12 hours
Sponsored by: https://www.patreon.com/cperciva
Differential Revision: https://reviews.freebsd.org/D52536

show more ...

release: Pass ABI to running pkgbase-stage on dvd

I did this for disc1 but forgot to amend the dvd invocation.

Fixes: 340e68fd7c0d ("release: Pass ABI to pkgbase-stage.lua")
MFC after: 3 days
Spons

release: Pass ABI to running pkgbase-stage on dvd

I did this for disc1 but forgot to amend the dvd invocation.

Fixes: 340e68fd7c0d ("release: Pass ABI to pkgbase-stage.lua")
MFC after: 3 days
Sponsored by: https://www.patreon.com/cperciva

show more ...

release: CLEANDIRS += pkgdb

This directory gets created by pkgbase-stage.lua.

MFC after: 3 days
Sponsored by: https://www.patreon.com/c/cperciva

release: Pass ABI to pkgbase-stage.lua

We then pass ABI from pkgbase-stage.lua to pkg(8); without this,
cross-building releases with PKGBASE enabled fails with

pkg: wrong architecture: ...
pkg: rep

release: Pass ABI to pkgbase-stage.lua

We then pass ABI from pkgbase-stage.lua to pkg(8); without this,
cross-building releases with PKGBASE enabled fails with

pkg: wrong architecture: ...
pkg: repository FreeBSD-base contains packages with wrong ABI: ...

MFC after: 1 minute
Discussed with: emaste, jrtc27
Sponsored by: https://www.patreon.com/c/cperciva

show more ...

release: make symlink creation for src.tgz more robust

PR: 288256
Approved by: emaste
Differential Revision: https://reviews.freebsd.org/D51335

release: Install wireless firmware to bootonly media

Also install wireless firmware packages to the bootonly ISO and the
mini-memstick image so users can fetch installation files over a
wireless con

release: Install wireless firmware to bootonly media

Also install wireless firmware packages to the bootonly ISO and the
mini-memstick image so users can fetch installation files over a
wireless connection.

Reported by: Mark Philips <mark@freebsdfoundation.org>
Reviewed by: bz, emaste, imp, releng (cperciva)
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D51348

show more ...