Revert "Mark several getaddrinfo tests as XFAIL"

This change was unreviewed and should not have been committed to :main.

This reverts commit 9b37d84c87e69dabc69d818aa4d2fea718bd8b74.

Mark several getaddrinfo tests as XFAIL

These tests were recently enabled on main and have failed consistently
since they were enabled.

- lib.libc.net.getaddrinfo.getaddrinfo.basic
- lib.libc.net.g

Mark several getaddrinfo tests as XFAIL

These tests were recently enabled on main and have failed consistently
since they were enabled.

- lib.libc.net.getaddrinfo.getaddrinfo.basic
- lib.libc.net.getaddrinfo.getaddrinfo.nofamily
- lib.libc.net.getaddrinfo.getaddrinfo_test.basic
- lib.libc.net.getaddrinfo.getaddrinfo_test.empty_servname
- lib.libc.net.getaddrinfo.getaddrinfo_test.sock_raw

Mark them as expected failures so they no longer count as failures in
Jenkins CI.

PR: 285826
MFC with: 5313457780, 0b773a94ab

show more ...

tests: Require allow_network_access for tests needing name resolution

Tests that require working name resolution or network access now mandate that
the kuya variable allow_network_access be set.

PR

tests: Require allow_network_access for tests needing name resolution

Tests that require working name resolution or network access now mandate that
the kuya variable allow_network_access be set.

PR: 285826
Reported by: ngie
Reviewed by: igoro
Approved by: lwhsu
Sponsored by: Netflix
Differential Revision: https://reviews.freebsd.org/D49633

show more ...

libc/getaddrinfo(2): return EAI_AGAIN on nameserver timeout

A nameserver timeout is a soft failure, future attempts may succeed.
Returning EAI_AGAIN is crucial for API users to tell a soft name
reso

libc/getaddrinfo(2): return EAI_AGAIN on nameserver timeout

A nameserver timeout is a soft failure, future attempts may succeed.
Returning EAI_AGAIN is crucial for API users to tell a soft name
resolution failure from negative resolution result.

Before the change we would return EAI_ADDRFAMILY, which I believe, is a
regression from 144361386696, and before that revision we used to return
EAI_NONAME in most of the cases.

Reviewed by: kib
Differential Revision: https://reviews.freebsd.org/D49411

show more ...

libc/tests: add getaddrinfo test

A test suite for getaddrinfo(3) written in C. Unlike NetBSD test, this
one will be mostly focused on what the API should return when something
isn't good with your

libc/tests: add getaddrinfo test

A test suite for getaddrinfo(3) written in C. Unlike NetBSD test, this
one will be mostly focused on what the API should return when something
isn't good with your DNS. Test emulates bad DNS servers in resolv.conf
intercepting fopen(2) and emulates downed network intercepting send(2).

Initial version covers three main scenarios: all good, server(s) timed
out, network down. For each scenario we test hostname with trailing dot
and without, since libc resolver uses quite different code paths,
sometimes even yielding with different error codes. All current error
codes in the test are what our libc returns right now, meaning the test
documents what we have, not what there should be.

Reviewed by: kib
Differential Revision: https://reviews.freebsd.org/D49410

show more ...