libbsnmp: avoid division by zero with empty password

PR: 283909

bsnmp: Use mkstemp when creating clients local socket

Reviewed by: harti, rew
Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.
X-NetApp-PR: #72
Differential Revision: https://reviews.free

bsnmp: Use mkstemp when creating clients local socket

Reviewed by: harti, rew
Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.
X-NetApp-PR: #72
Differential Revision: https://reviews.freebsd.org/D34550

show more ...

bsnmp: Fix two typos in error messages

- s/responce/response/

MFC after: 1 week

Revert "bsnmpclient(3): make it thread-safe"

This reverts commit 89e3d5671ba13dceca272d5b159c9bd805f3f504.

As pointed out, there are several problems with that commit:

1. The new semantics, while

Revert "bsnmpclient(3): make it thread-safe"

This reverts commit 89e3d5671ba13dceca272d5b159c9bd805f3f504.

As pointed out, there are several problems with that commit:

1. The new semantics, while useful for clients where multiple
threads use separate contexts, breaks clients which correctly
share a single one
2. Change in semantics would require a library version bump
3. It doesn't build with GCC

show more ...

bsnmpclient(3): make it thread-safe

Reviewed By: harti
Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.
Differential Revision: https://reviews.freebsd.org/D27336

Merge release 1.14 of bsnmp.

bsnmp: Fix operator precedence in error check in table_check_response

Summary:
The ?: operator has a lower precedence than == and &&, so the result will always
be recorded as true. Found by gcc8.

bsnmp: Fix operator precedence in error check in table_check_response

Summary:
The ?: operator has a lower precedence than == and &&, so the result will always
be recorded as true. Found by gcc8.

Reviewed by: ngie, ae
Differential Revision: https://reviews.freebsd.org/D22427

show more ...

MFHead@r345880

Follow the declared behaviour that specifies server string format in
bsnmpclient(3).

snmp_parse_server() function accepts string where some fields can be
omitted: [trans::][community@][server][:port

Follow the declared behaviour that specifies server string format in
bsnmpclient(3).

snmp_parse_server() function accepts string where some fields can be
omitted: [trans::][community@][server][:port]

"trans" field can be "udp", "udp6", "dgram" and "stream".
"community" can be empty string, if it is omitted, the default value
will be used. For read_community it is "public", for write_comminity
it is "private". "server" field can be hostname, IPv4 address or IPv6
address. IPv6 address should be specified in brackets "[]".
If port is omitted, the default value "snmp" will be used for "udp"
and "udp6" transports. So, now for bsnmpget(1) and bsnmwalk(1) it is
not required to specify all fields in argument of '-s' option. E.g.

# bsnmpget -s 127.1 sysName.0
# bsnmpget -s "udp::127.1" sysName.0
# bsnmpget -s "udp::public@127.1" sysName.0
# bsnmpget -s "udp::public@127.1:161" sysName.0
# bsnmpget -s "udp::[::1]" sysName.0
# bsnmpget -s "udp6::[::1]" sysName.0
# bsnmpget -s "[fe80::1%lo0]" sysName.0

PR: 236664
Reported by: olivier
MFC after: 1 month

show more ...

Add IPv6 transport for bsnmp.

This patch adds a new table begemotSnmpdTransInetTable that uses the
InetAddressType textual convention and can be used to create listening
ports for IPv4, IPv6, zoned

Add IPv6 transport for bsnmp.

This patch adds a new table begemotSnmpdTransInetTable that uses the
InetAddressType textual convention and can be used to create listening
ports for IPv4, IPv6, zoned IPv6 and based on DNS names. It also supports
future extension beyond UDP by adding a protocol identifier to the table
index. In order to support this gensnmptree had to be modified.

Submitted by: harti
MFC after: 1 month
Relnotes: yes
Differential Revision: https://reviews.freebsd.org/D16654

show more ...

bsnmp: explicitly test the return value for open_client_{local,udp} in snmp_open(..)

open_client_* returns -1 on failure; 0 on success. Ensure that the return value is
0 -- otherwise exit snmp_open(

bsnmp: explicitly test the return value for open_client_{local,udp} in snmp_open(..)

open_client_* returns -1 on failure; 0 on success. Ensure that the return value is
0 -- otherwise exit snmp_open(..).

MFC after: 1 week
Sponsored by: Dell EMC Isilon

show more ...

bsnmp: don't leak snmp_client.fd in open_client_udp(..) on connect(2) failure

MFC after: 1 week
Sponsored by: Dell EMC Isilon

Merge ^/head r311314 through r311459.

snmp_table_fetch_async: don't leak `work` if snmp_pdu_send(..) fails

MFC after: 1 week
Reported by: Coverity
CID: 1017276

Merge ^/head r311132 through r311305.

Use calloc instead of malloc with buffers in snmp_{recv,send}_packet

This doesn't fix the issue noted in the PR, but at the very least it
cleans up the error so it looks a bit more sane, and in the

Use calloc instead of malloc with buffers in snmp_{recv,send}_packet

This doesn't fix the issue noted in the PR, but at the very least it
cleans up the error so it looks a bit more sane, and in the event
that bsnmp did wander off into the weeds, the likelihood of it
crashing with more sensible output is greater, in my opinion

MFC counter set high so I have enough time to resolve the real
underlying bug in bsnmpwalk

MFC after: 1 month
PR: 215721

show more ...

snmp_discover_engine: fix up req/resp (PDU object) handling a bit

- Call snmp_pdu_free on req and resp when done with the objects
- Call snmp_pdu_free on req before calling snmp_pdu_create on it
a

snmp_discover_engine: fix up req/resp (PDU object) handling a bit

- Call snmp_pdu_free on req and resp when done with the objects
- Call snmp_pdu_free on req before calling snmp_pdu_create on it
again

MFC after: 1 week

show more ...

Unbreak the build by passing the string to strdup, not its length

MFC after: 1 week
X-MFC with: r310931
Pointyhat to: ngie

Use strdup in snmp_parse_server(..) when possible instead of malloc+strcpy

This simplifies the code and mutes a Coverity warning about sc->cport being
improperly allocated

Reported by: Coverity
CID

Use strdup in snmp_parse_server(..) when possible instead of malloc+strcpy

This simplifies the code and mutes a Coverity warning about sc->cport being
improperly allocated

Reported by: Coverity
CID: 1018247
MFC after: 1 week

show more ...

style(9): snmp_send_packet(..): fix whitespace

MFC after: 3 days

style(9): clean up trailing whitespace

MFC after: 3 weeks

Minor style(9) fixes

- Trailing whitespace cleanup
- Sort variables in snmp_dialog(..) by alignment

No functional change

MFC after: 1 week

Clean up trailing and leading whitespace

Fix variable type alignment in snmp_dialog(..)

MFC after: 1 week

Bring in a SNMP module that allows configuration of SNMPv3 Notification targets.

Sponsored by: The FreeBSD Foundation
Reviewed by: philip
Approved by: philip

Sync: merge r216133 through r216338 from ^/head.