1--- 2 3A lot of the tests written in C use assert(), only printing 'ok' at the end 4of the program if none of the assert()s fired. 5 6This is wrong. They should do the test outside of an assert(), and print 7'ok' or 'not ok' as appropriate, instead of bailing out part way through. 8That way if a test starts failing we'll know exactly which one failed, and 9the other tests can continue. 10 11This probably means a simple libtest.so that they can link against to 12provide an ok() function (the non-fatal assert), probably with some helper 13functions to keep track of test numbers and so on. 14 15--- 16 17Any of the tests written in C should link against the libraries under 18/usr/obj rather than using the system libraries. 19 20--- 21 22Not everything's been converted to the new style. In particular; 23 24 atm/ 25 ccd/ 26 some of geom_*/ 27 some of netinet/ 28 nfsmmap/ 29 p1003_1b/ 30 some of pipe/ 31 security/ 32 some of sockets/ 33 tls/ 34 35needs to be converted. And fsx/ and gaithrstress/ are (I think) standalone 36programs rather than individual tests, so aren't amenable to this sort of 37conversion. 38