1$FreeBSD$ 2--- 3 4A lot of the tests written in C use assert(), only printing 'ok' at the end 5of the program if none of the assert()s fired. 6 7This is wrong. They should do the test outside of an assert(), and print 8'ok' or 'not ok' as appropriate, instead of bailing out part way through. 9That way if a test starts failing we'll know exactly which one failed, and 10the other tests can continue. 11 12This probably means a simple libtest.so that they can link against to 13provide an ok() function (the non-fatal assert), probably with some helper 14functions to keep track of test numbers and so on. 15 16--- 17 18Any of the tests written in C should link against the libraries under 19/usr/obj rather than using the system libraries. 20 21--- 22 23Not everything's been converted to the new style. In particular; 24 25 atm/ 26 ccd/ 27 some of geom_*/ 28 some of netinet/ 29 nfsmmap/ 30 p1003_1b/ 31 some of pipe/ 32 security/ 33 some of sockets/ 34 tls/ 35 36needs to be converted. And fsx/ and gaithrstress/ are (I think) standalone 37programs rather than individual tests, so aren't amenable to this sort of 38conversion. 39