100e13b1dSNik Clayton--- 200e13b1dSNik Clayton 300e13b1dSNik ClaytonA lot of the tests written in C use assert(), only printing 'ok' at the end 400e13b1dSNik Claytonof the program if none of the assert()s fired. 500e13b1dSNik Clayton 600e13b1dSNik ClaytonThis is wrong. They should do the test outside of an assert(), and print 700e13b1dSNik Clayton'ok' or 'not ok' as appropriate, instead of bailing out part way through. 800e13b1dSNik ClaytonThat way if a test starts failing we'll know exactly which one failed, and 900e13b1dSNik Claytonthe other tests can continue. 1000e13b1dSNik Clayton 1100e13b1dSNik ClaytonThis probably means a simple libtest.so that they can link against to 1200e13b1dSNik Claytonprovide an ok() function (the non-fatal assert), probably with some helper 1300e13b1dSNik Claytonfunctions to keep track of test numbers and so on. 1400e13b1dSNik Clayton 1500e13b1dSNik Clayton--- 1600e13b1dSNik Clayton 1700e13b1dSNik ClaytonAny of the tests written in C should link against the libraries under 1800e13b1dSNik Clayton/usr/obj rather than using the system libraries. 1900e13b1dSNik Clayton 2000e13b1dSNik Clayton--- 2100e13b1dSNik Clayton 2200e13b1dSNik ClaytonNot everything's been converted to the new style. In particular; 2300e13b1dSNik Clayton 2400e13b1dSNik Clayton atm/ 2500e13b1dSNik Clayton ccd/ 2600e13b1dSNik Clayton some of geom_*/ 2700e13b1dSNik Clayton some of netinet/ 2800e13b1dSNik Clayton nfsmmap/ 2900e13b1dSNik Clayton p1003_1b/ 3000e13b1dSNik Clayton some of pipe/ 3100e13b1dSNik Clayton security/ 3200e13b1dSNik Clayton some of sockets/ 3300e13b1dSNik Clayton tls/ 3400e13b1dSNik Clayton 3500e13b1dSNik Claytonneeds to be converted. And fsx/ and gaithrstress/ are (I think) standalone 3600e13b1dSNik Claytonprograms rather than individual tests, so aren't amenable to this sort of 3700e13b1dSNik Claytonconversion. 38