19821f1d3SAlan Somers /*- 29821f1d3SAlan Somers * SPDX-License-Identifier: BSD-2-Clause-FreeBSD 39821f1d3SAlan Somers * 49821f1d3SAlan Somers * Copyright (c) 2019 The FreeBSD Foundation 59821f1d3SAlan Somers * 69821f1d3SAlan Somers * This software was developed by BFF Storage Systems, LLC under sponsorship 79821f1d3SAlan Somers * from the FreeBSD Foundation. 89821f1d3SAlan Somers * 99821f1d3SAlan Somers * Redistribution and use in source and binary forms, with or without 109821f1d3SAlan Somers * modification, are permitted provided that the following conditions 119821f1d3SAlan Somers * are met: 129821f1d3SAlan Somers * 1. Redistributions of source code must retain the above copyright 139821f1d3SAlan Somers * notice, this list of conditions and the following disclaimer. 149821f1d3SAlan Somers * 2. Redistributions in binary form must reproduce the above copyright 159821f1d3SAlan Somers * notice, this list of conditions and the following disclaimer in the 169821f1d3SAlan Somers * documentation and/or other materials provided with the distribution. 179821f1d3SAlan Somers * 189821f1d3SAlan Somers * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND 199821f1d3SAlan Somers * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 209821f1d3SAlan Somers * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE 219821f1d3SAlan Somers * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE 229821f1d3SAlan Somers * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL 239821f1d3SAlan Somers * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS 249821f1d3SAlan Somers * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) 259821f1d3SAlan Somers * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT 269821f1d3SAlan Somers * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY 279821f1d3SAlan Somers * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF 289821f1d3SAlan Somers * SUCH DAMAGE. 299821f1d3SAlan Somers */ 309821f1d3SAlan Somers 3109c01e67SAlan Somers extern "C" { 329821f1d3SAlan Somers #include <sys/param.h> 3309c01e67SAlan Somers #include <sys/mman.h> 349821f1d3SAlan Somers #include <sys/module.h> 359821f1d3SAlan Somers #include <sys/sysctl.h> 3609c01e67SAlan Somers #include <sys/wait.h> 3709c01e67SAlan Somers 3809c01e67SAlan Somers #include <pwd.h> 3909c01e67SAlan Somers #include <semaphore.h> 4009c01e67SAlan Somers #include <unistd.h> 4109c01e67SAlan Somers } 429821f1d3SAlan Somers 439821f1d3SAlan Somers #include <gtest/gtest.h> 449821f1d3SAlan Somers 459821f1d3SAlan Somers #include "mockfs.hh" 469821f1d3SAlan Somers #include "utils.hh" 479821f1d3SAlan Somers 489821f1d3SAlan Somers using namespace testing; 499821f1d3SAlan Somers 509821f1d3SAlan Somers /* Check that fusefs(4) is accessible and the current user can mount(2) */ 519821f1d3SAlan Somers void check_environment() 529821f1d3SAlan Somers { 539821f1d3SAlan Somers const char *devnode = "/dev/fuse"; 549821f1d3SAlan Somers const char *usermount_node = "vfs.usermount"; 559821f1d3SAlan Somers int usermount_val = 0; 569821f1d3SAlan Somers size_t usermount_size = sizeof(usermount_val); 579821f1d3SAlan Somers if (eaccess(devnode, R_OK | W_OK)) { 589821f1d3SAlan Somers if (errno == ENOENT) { 599821f1d3SAlan Somers GTEST_SKIP() << devnode << " does not exist"; 609821f1d3SAlan Somers } else if (errno == EACCES) { 619821f1d3SAlan Somers GTEST_SKIP() << devnode << 629821f1d3SAlan Somers " is not accessible by the current user"; 639821f1d3SAlan Somers } else { 649821f1d3SAlan Somers GTEST_SKIP() << strerror(errno); 659821f1d3SAlan Somers } 669821f1d3SAlan Somers } 679821f1d3SAlan Somers sysctlbyname(usermount_node, &usermount_val, &usermount_size, 689821f1d3SAlan Somers NULL, 0); 699821f1d3SAlan Somers if (geteuid() != 0 && !usermount_val) 709821f1d3SAlan Somers GTEST_SKIP() << "current user is not allowed to mount"; 719821f1d3SAlan Somers } 729821f1d3SAlan Somers 739821f1d3SAlan Somers class FuseEnv: public Environment { 749821f1d3SAlan Somers virtual void SetUp() { 759821f1d3SAlan Somers } 769821f1d3SAlan Somers }; 779821f1d3SAlan Somers 789821f1d3SAlan Somers void FuseTest::SetUp() { 799821f1d3SAlan Somers const char *node = "vfs.maxbcachebuf"; 809821f1d3SAlan Somers int val = 0; 819821f1d3SAlan Somers size_t size = sizeof(val); 829821f1d3SAlan Somers 839821f1d3SAlan Somers /* 849821f1d3SAlan Somers * XXX check_environment should be called from FuseEnv::SetUp, but 859821f1d3SAlan Somers * can't due to https://github.com/google/googletest/issues/2189 869821f1d3SAlan Somers */ 879821f1d3SAlan Somers check_environment(); 889821f1d3SAlan Somers if (IsSkipped()) 899821f1d3SAlan Somers return; 909821f1d3SAlan Somers 919821f1d3SAlan Somers ASSERT_EQ(0, sysctlbyname(node, &val, &size, NULL, 0)) 929821f1d3SAlan Somers << strerror(errno); 939821f1d3SAlan Somers m_maxbcachebuf = val; 949821f1d3SAlan Somers 959821f1d3SAlan Somers try { 9691ff3a0dSAlan Somers m_mock = new MockFS(m_maxreadahead, m_allow_other, 97*140bb492SAlan Somers m_default_permissions, m_push_symlinks_in, m_ro, 9891ff3a0dSAlan Somers m_init_flags); 999821f1d3SAlan Somers } catch (std::system_error err) { 1009821f1d3SAlan Somers FAIL() << err.what(); 1019821f1d3SAlan Somers } 1029821f1d3SAlan Somers } 1039821f1d3SAlan Somers 10491ff3a0dSAlan Somers void 10591ff3a0dSAlan Somers FuseTest::expect_access(uint64_t ino, mode_t access_mode, int error) 10691ff3a0dSAlan Somers { 10791ff3a0dSAlan Somers EXPECT_CALL(*m_mock, process( 10891ff3a0dSAlan Somers ResultOf([=](auto in) { 10991ff3a0dSAlan Somers return (in->header.opcode == FUSE_ACCESS && 11091ff3a0dSAlan Somers in->header.nodeid == ino && 11191ff3a0dSAlan Somers in->body.access.mask == access_mode); 11291ff3a0dSAlan Somers }, Eq(true)), 11391ff3a0dSAlan Somers _) 11491ff3a0dSAlan Somers ).WillOnce(Invoke(ReturnErrno(error))); 11591ff3a0dSAlan Somers } 11691ff3a0dSAlan Somers 1179f10f423SAlan Somers void 1189f10f423SAlan Somers FuseTest::expect_flush(uint64_t ino, int times, ProcessMockerT r) 1199f10f423SAlan Somers { 1209f10f423SAlan Somers EXPECT_CALL(*m_mock, process( 1219f10f423SAlan Somers ResultOf([=](auto in) { 1229f10f423SAlan Somers return (in->header.opcode == FUSE_FLUSH && 1239f10f423SAlan Somers in->header.nodeid == ino); 1249f10f423SAlan Somers }, Eq(true)), 1259f10f423SAlan Somers _) 1269f10f423SAlan Somers ).Times(times) 1279f10f423SAlan Somers .WillRepeatedly(Invoke(r)); 1289f10f423SAlan Somers } 1299f10f423SAlan Somers 1309821f1d3SAlan Somers void FuseTest::expect_getattr(uint64_t ino, uint64_t size) 1319821f1d3SAlan Somers { 1329821f1d3SAlan Somers /* Until the attr cache is working, we may send an additional GETATTR */ 1339821f1d3SAlan Somers EXPECT_CALL(*m_mock, process( 1349821f1d3SAlan Somers ResultOf([=](auto in) { 1359821f1d3SAlan Somers return (in->header.opcode == FUSE_GETATTR && 1369821f1d3SAlan Somers in->header.nodeid == ino); 1379821f1d3SAlan Somers }, Eq(true)), 1389821f1d3SAlan Somers _) 1399821f1d3SAlan Somers ).WillRepeatedly(Invoke(ReturnImmediate([=](auto i __unused, auto out) { 1409821f1d3SAlan Somers SET_OUT_HEADER_LEN(out, attr); 1419821f1d3SAlan Somers out->body.attr.attr.ino = ino; // Must match nodeid 1429821f1d3SAlan Somers out->body.attr.attr.mode = S_IFREG | 0644; 1439821f1d3SAlan Somers out->body.attr.attr.size = size; 1449821f1d3SAlan Somers out->body.attr.attr_valid = UINT64_MAX; 1459821f1d3SAlan Somers }))); 1469821f1d3SAlan Somers } 1479821f1d3SAlan Somers 1489821f1d3SAlan Somers void FuseTest::expect_lookup(const char *relpath, uint64_t ino, mode_t mode, 1499821f1d3SAlan Somers uint64_t size, int times) 1509821f1d3SAlan Somers { 1519821f1d3SAlan Somers EXPECT_LOOKUP(1, relpath) 1529821f1d3SAlan Somers .Times(times) 1539821f1d3SAlan Somers .WillRepeatedly(Invoke(ReturnImmediate([=](auto in __unused, auto out) { 1549821f1d3SAlan Somers SET_OUT_HEADER_LEN(out, entry); 1559821f1d3SAlan Somers out->body.entry.attr.mode = mode; 1569821f1d3SAlan Somers out->body.entry.nodeid = ino; 1579821f1d3SAlan Somers out->body.entry.attr.nlink = 1; 1589821f1d3SAlan Somers out->body.entry.attr_valid = UINT64_MAX; 1599821f1d3SAlan Somers out->body.entry.attr.size = size; 1609821f1d3SAlan Somers }))); 1619821f1d3SAlan Somers } 1629821f1d3SAlan Somers 1639821f1d3SAlan Somers void FuseTest::expect_open(uint64_t ino, uint32_t flags, int times) 1649821f1d3SAlan Somers { 1659821f1d3SAlan Somers EXPECT_CALL(*m_mock, process( 1669821f1d3SAlan Somers ResultOf([=](auto in) { 1679821f1d3SAlan Somers return (in->header.opcode == FUSE_OPEN && 1689821f1d3SAlan Somers in->header.nodeid == ino); 1699821f1d3SAlan Somers }, Eq(true)), 1709821f1d3SAlan Somers _) 1719821f1d3SAlan Somers ).Times(times) 1729821f1d3SAlan Somers .WillRepeatedly(Invoke(ReturnImmediate([=](auto in __unused, auto out) { 1739821f1d3SAlan Somers out->header.len = sizeof(out->header); 1749821f1d3SAlan Somers SET_OUT_HEADER_LEN(out, open); 1759821f1d3SAlan Somers out->body.open.fh = FH; 1769821f1d3SAlan Somers out->body.open.open_flags = flags; 1779821f1d3SAlan Somers }))); 1789821f1d3SAlan Somers } 1799821f1d3SAlan Somers 1809821f1d3SAlan Somers void FuseTest::expect_opendir(uint64_t ino) 1819821f1d3SAlan Somers { 182363a7416SAlan Somers /* opendir(3) calls fstatfs */ 1839821f1d3SAlan Somers EXPECT_CALL(*m_mock, process( 1849821f1d3SAlan Somers ResultOf([](auto in) { 1859821f1d3SAlan Somers return (in->header.opcode == FUSE_STATFS); 1869821f1d3SAlan Somers }, Eq(true)), 1879821f1d3SAlan Somers _) 1889821f1d3SAlan Somers ).WillRepeatedly(Invoke(ReturnImmediate([=](auto i __unused, auto out) { 1899821f1d3SAlan Somers SET_OUT_HEADER_LEN(out, statfs); 1909821f1d3SAlan Somers }))); 1919821f1d3SAlan Somers 1929821f1d3SAlan Somers EXPECT_CALL(*m_mock, process( 1939821f1d3SAlan Somers ResultOf([=](auto in) { 1949821f1d3SAlan Somers return (in->header.opcode == FUSE_OPENDIR && 1959821f1d3SAlan Somers in->header.nodeid == ino); 1969821f1d3SAlan Somers }, Eq(true)), 1979821f1d3SAlan Somers _) 1989821f1d3SAlan Somers ).WillOnce(Invoke(ReturnImmediate([=](auto in __unused, auto out) { 1999821f1d3SAlan Somers out->header.len = sizeof(out->header); 2009821f1d3SAlan Somers SET_OUT_HEADER_LEN(out, open); 2019821f1d3SAlan Somers out->body.open.fh = FH; 2029821f1d3SAlan Somers }))); 2039821f1d3SAlan Somers } 2049821f1d3SAlan Somers 2059821f1d3SAlan Somers void FuseTest::expect_read(uint64_t ino, uint64_t offset, uint64_t isize, 2069821f1d3SAlan Somers uint64_t osize, const void *contents) 2079821f1d3SAlan Somers { 2089821f1d3SAlan Somers EXPECT_CALL(*m_mock, process( 2099821f1d3SAlan Somers ResultOf([=](auto in) { 2109821f1d3SAlan Somers return (in->header.opcode == FUSE_READ && 2119821f1d3SAlan Somers in->header.nodeid == ino && 2129821f1d3SAlan Somers in->body.read.fh == FH && 2139821f1d3SAlan Somers in->body.read.offset == offset && 2149821f1d3SAlan Somers in->body.read.size == isize); 2159821f1d3SAlan Somers }, Eq(true)), 2169821f1d3SAlan Somers _) 2179821f1d3SAlan Somers ).WillOnce(Invoke(ReturnImmediate([=](auto in __unused, auto out) { 2189821f1d3SAlan Somers out->header.len = sizeof(struct fuse_out_header) + osize; 2199821f1d3SAlan Somers memmove(out->body.bytes, contents, osize); 2209821f1d3SAlan Somers }))).RetiresOnSaturation(); 2219821f1d3SAlan Somers } 2229821f1d3SAlan Somers 22342d50d16SAlan Somers void FuseTest::expect_release(uint64_t ino, uint64_t fh) 2249821f1d3SAlan Somers { 2259821f1d3SAlan Somers EXPECT_CALL(*m_mock, process( 2269821f1d3SAlan Somers ResultOf([=](auto in) { 2279821f1d3SAlan Somers return (in->header.opcode == FUSE_RELEASE && 2289821f1d3SAlan Somers in->header.nodeid == ino && 22942d50d16SAlan Somers in->body.release.fh == fh); 2309821f1d3SAlan Somers }, Eq(true)), 2319821f1d3SAlan Somers _) 232e0bec057SAlan Somers ).WillOnce(Invoke(ReturnErrno(0))); 2339821f1d3SAlan Somers } 234e0bec057SAlan Somers 23535cf0e7eSAlan Somers void FuseTest::expect_releasedir(uint64_t ino, ProcessMockerT r) 23635cf0e7eSAlan Somers { 23735cf0e7eSAlan Somers EXPECT_CALL(*m_mock, process( 23835cf0e7eSAlan Somers ResultOf([=](auto in) { 23935cf0e7eSAlan Somers return (in->header.opcode == FUSE_RELEASEDIR && 24035cf0e7eSAlan Somers in->header.nodeid == ino && 24135cf0e7eSAlan Somers in->body.release.fh == FH); 24235cf0e7eSAlan Somers }, Eq(true)), 24335cf0e7eSAlan Somers _) 24435cf0e7eSAlan Somers ).WillOnce(Invoke(r)); 24535cf0e7eSAlan Somers } 24635cf0e7eSAlan Somers 2479821f1d3SAlan Somers void FuseTest::expect_write(uint64_t ino, uint64_t offset, uint64_t isize, 2489821f1d3SAlan Somers uint64_t osize, uint32_t flags, const void *contents) 2499821f1d3SAlan Somers { 2509821f1d3SAlan Somers EXPECT_CALL(*m_mock, process( 2519821f1d3SAlan Somers ResultOf([=](auto in) { 2529821f1d3SAlan Somers const char *buf = (const char*)in->body.bytes + 2539821f1d3SAlan Somers sizeof(struct fuse_write_in); 2549821f1d3SAlan Somers bool pid_ok; 2559821f1d3SAlan Somers 2569821f1d3SAlan Somers if (in->body.write.write_flags & FUSE_WRITE_CACHE) 2579821f1d3SAlan Somers pid_ok = true; 2589821f1d3SAlan Somers else 2599821f1d3SAlan Somers pid_ok = (pid_t)in->header.pid == getpid(); 2609821f1d3SAlan Somers 2619821f1d3SAlan Somers return (in->header.opcode == FUSE_WRITE && 2629821f1d3SAlan Somers in->header.nodeid == ino && 2639821f1d3SAlan Somers in->body.write.fh == FH && 2649821f1d3SAlan Somers in->body.write.offset == offset && 2659821f1d3SAlan Somers in->body.write.size == isize && 2669821f1d3SAlan Somers pid_ok && 2679821f1d3SAlan Somers in->body.write.write_flags == flags && 2689821f1d3SAlan Somers 0 == bcmp(buf, contents, isize)); 2699821f1d3SAlan Somers }, Eq(true)), 2709821f1d3SAlan Somers _) 2719821f1d3SAlan Somers ).WillOnce(Invoke(ReturnImmediate([=](auto in __unused, auto out) { 2729821f1d3SAlan Somers SET_OUT_HEADER_LEN(out, write); 2739821f1d3SAlan Somers out->body.write.size = osize; 2749821f1d3SAlan Somers }))); 2759821f1d3SAlan Somers } 2769821f1d3SAlan Somers 27709c01e67SAlan Somers static void 27809c01e67SAlan Somers get_unprivileged_uid(uid_t *uid) 27909c01e67SAlan Somers { 28009c01e67SAlan Somers struct passwd *pw; 28109c01e67SAlan Somers 28209c01e67SAlan Somers /* 28309c01e67SAlan Somers * First try "tests", Kyua's default unprivileged user. XXX after 28409c01e67SAlan Somers * GoogleTest gains a proper Kyua wrapper, get this with the Kyua API 28509c01e67SAlan Somers */ 28609c01e67SAlan Somers pw = getpwnam("tests"); 28709c01e67SAlan Somers if (pw == NULL) { 28809c01e67SAlan Somers /* Fall back to "nobody" */ 28909c01e67SAlan Somers pw = getpwnam("nobody"); 29009c01e67SAlan Somers } 29109c01e67SAlan Somers if (pw == NULL) 29209c01e67SAlan Somers GTEST_SKIP() << "Test requires an unprivileged user"; 29309c01e67SAlan Somers *uid = pw->pw_uid; 29409c01e67SAlan Somers } 29509c01e67SAlan Somers 29609c01e67SAlan Somers void 29709c01e67SAlan Somers FuseTest::fork(bool drop_privs, std::function<void()> parent_func, 29809c01e67SAlan Somers std::function<int()> child_func) 29909c01e67SAlan Somers { 30009c01e67SAlan Somers sem_t *sem; 30109c01e67SAlan Somers int mprot = PROT_READ | PROT_WRITE; 30209c01e67SAlan Somers int mflags = MAP_ANON | MAP_SHARED; 30309c01e67SAlan Somers pid_t child; 30409c01e67SAlan Somers uid_t uid; 30509c01e67SAlan Somers 30609c01e67SAlan Somers if (drop_privs) { 30709c01e67SAlan Somers get_unprivileged_uid(&uid); 30809c01e67SAlan Somers if (IsSkipped()) 30909c01e67SAlan Somers return; 31009c01e67SAlan Somers } 31109c01e67SAlan Somers 31209c01e67SAlan Somers sem = (sem_t*)mmap(NULL, sizeof(*sem), mprot, mflags, -1, 0); 31309c01e67SAlan Somers ASSERT_NE(MAP_FAILED, sem) << strerror(errno); 31409c01e67SAlan Somers ASSERT_EQ(0, sem_init(sem, 1, 0)) << strerror(errno); 31509c01e67SAlan Somers 31609c01e67SAlan Somers if ((child = ::fork()) == 0) { 31709c01e67SAlan Somers /* In child */ 31809c01e67SAlan Somers int err = 0; 31909c01e67SAlan Somers 32009c01e67SAlan Somers if (sem_wait(sem)) { 32109c01e67SAlan Somers perror("sem_wait"); 32209c01e67SAlan Somers err = 1; 32309c01e67SAlan Somers goto out; 32409c01e67SAlan Somers } 32509c01e67SAlan Somers 32609c01e67SAlan Somers if (drop_privs && 0 != setreuid(-1, uid)) { 32709c01e67SAlan Somers perror("setreuid"); 32809c01e67SAlan Somers err = 1; 32909c01e67SAlan Somers goto out; 33009c01e67SAlan Somers } 33109c01e67SAlan Somers err = child_func(); 33209c01e67SAlan Somers 33309c01e67SAlan Somers out: 33409c01e67SAlan Somers sem_destroy(sem); 33509c01e67SAlan Somers _exit(err); 33609c01e67SAlan Somers } else if (child > 0) { 33709c01e67SAlan Somers int child_status; 33809c01e67SAlan Somers 33909c01e67SAlan Somers /* 34009c01e67SAlan Somers * In parent. Cleanup must happen here, because it's still 34109c01e67SAlan Somers * privileged. 34209c01e67SAlan Somers */ 34309c01e67SAlan Somers m_mock->m_child_pid = child; 34409c01e67SAlan Somers ASSERT_NO_FATAL_FAILURE(parent_func()); 34509c01e67SAlan Somers 34609c01e67SAlan Somers /* Signal the child process to go */ 34709c01e67SAlan Somers ASSERT_EQ(0, sem_post(sem)) << strerror(errno); 34809c01e67SAlan Somers 3494eb84816SAlan Somers ASSERT_LE(0, wait(&child_status)) << strerror(errno); 35009c01e67SAlan Somers ASSERT_EQ(0, WEXITSTATUS(child_status)); 35109c01e67SAlan Somers } else { 35209c01e67SAlan Somers FAIL() << strerror(errno); 35309c01e67SAlan Somers } 35409c01e67SAlan Somers munmap(sem, sizeof(*sem)); 35509c01e67SAlan Somers } 35609c01e67SAlan Somers 3579821f1d3SAlan Somers static void usage(char* progname) { 3589821f1d3SAlan Somers fprintf(stderr, "Usage: %s [-v]\n\t-v increase verbosity\n", progname); 3599821f1d3SAlan Somers exit(2); 3609821f1d3SAlan Somers } 3619821f1d3SAlan Somers 3629821f1d3SAlan Somers int main(int argc, char **argv) { 3639821f1d3SAlan Somers int ch; 3649821f1d3SAlan Somers FuseEnv *fuse_env = new FuseEnv; 3659821f1d3SAlan Somers 3669821f1d3SAlan Somers InitGoogleTest(&argc, argv); 3679821f1d3SAlan Somers AddGlobalTestEnvironment(fuse_env); 3689821f1d3SAlan Somers 3699821f1d3SAlan Somers while ((ch = getopt(argc, argv, "v")) != -1) { 3709821f1d3SAlan Somers switch (ch) { 3719821f1d3SAlan Somers case 'v': 3729821f1d3SAlan Somers verbosity++; 3739821f1d3SAlan Somers break; 3749821f1d3SAlan Somers default: 3759821f1d3SAlan Somers usage(argv[0]); 3769821f1d3SAlan Somers break; 3779821f1d3SAlan Somers } 3789821f1d3SAlan Somers } 3799821f1d3SAlan Somers 3809821f1d3SAlan Somers return (RUN_ALL_TESTS()); 3819821f1d3SAlan Somers } 382