xref: /freebsd/sys/kern/subr_smp.c (revision 5861f9665471e98e544f6fa3ce73c4912229ff82)
1 /*-
2  * Copyright (c) 2001, John Baldwin <jhb@FreeBSD.org>.
3  * All rights reserved.
4  *
5  * Redistribution and use in source and binary forms, with or without
6  * modification, are permitted provided that the following conditions
7  * are met:
8  * 1. Redistributions of source code must retain the above copyright
9  *    notice, this list of conditions and the following disclaimer.
10  * 2. Redistributions in binary form must reproduce the above copyright
11  *    notice, this list of conditions and the following disclaimer in the
12  *    documentation and/or other materials provided with the distribution.
13  * 3. Neither the name of the author nor the names of any co-contributors
14  *    may be used to endorse or promote products derived from this software
15  *    without specific prior written permission.
16  *
17  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
18  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
19  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
20  * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
21  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
22  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
23  * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
24  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
25  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
26  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
27  * SUCH DAMAGE.
28  */
29 
30 /*
31  * This module holds the global variables and machine independent functions
32  * used for the kernel SMP support.
33  */
34 
35 #include <sys/cdefs.h>
36 __FBSDID("$FreeBSD$");
37 
38 #include <sys/param.h>
39 #include <sys/systm.h>
40 #include <sys/kernel.h>
41 #include <sys/ktr.h>
42 #include <sys/proc.h>
43 #include <sys/bus.h>
44 #include <sys/lock.h>
45 #include <sys/mutex.h>
46 #include <sys/pcpu.h>
47 #include <sys/smp.h>
48 #include <sys/sysctl.h>
49 
50 #include <machine/cpu.h>
51 #include <machine/smp.h>
52 
53 #include "opt_sched.h"
54 
55 #ifdef SMP
56 volatile cpumask_t stopped_cpus;
57 volatile cpumask_t started_cpus;
58 cpumask_t idle_cpus_mask;
59 cpumask_t hlt_cpus_mask;
60 cpumask_t logical_cpus_mask;
61 
62 void (*cpustop_restartfunc)(void);
63 #endif
64 /* This is used in modules that need to work in both SMP and UP. */
65 cpumask_t all_cpus;
66 
67 int mp_ncpus;
68 /* export this for libkvm consumers. */
69 int mp_maxcpus = MAXCPU;
70 
71 volatile int smp_started;
72 u_int mp_maxid;
73 
74 SYSCTL_NODE(_kern, OID_AUTO, smp, CTLFLAG_RD, NULL, "Kernel SMP");
75 
76 SYSCTL_INT(_kern_smp, OID_AUTO, maxid, CTLFLAG_RD, &mp_maxid, 0,
77     "Max CPU ID.");
78 
79 SYSCTL_INT(_kern_smp, OID_AUTO, maxcpus, CTLFLAG_RD, &mp_maxcpus, 0,
80     "Max number of CPUs that the system was compiled for.");
81 
82 int smp_active = 0;	/* are the APs allowed to run? */
83 SYSCTL_INT(_kern_smp, OID_AUTO, active, CTLFLAG_RW, &smp_active, 0,
84     "Number of Auxillary Processors (APs) that were successfully started");
85 
86 int smp_disabled = 0;	/* has smp been disabled? */
87 SYSCTL_INT(_kern_smp, OID_AUTO, disabled, CTLFLAG_RDTUN, &smp_disabled, 0,
88     "SMP has been disabled from the loader");
89 TUNABLE_INT("kern.smp.disabled", &smp_disabled);
90 
91 int smp_cpus = 1;	/* how many cpu's running */
92 SYSCTL_INT(_kern_smp, OID_AUTO, cpus, CTLFLAG_RD, &smp_cpus, 0,
93     "Number of CPUs online");
94 
95 int smp_topology = 0;	/* Which topology we're using. */
96 SYSCTL_INT(_kern_smp, OID_AUTO, topology, CTLFLAG_RD, &smp_topology, 0,
97     "Topology override setting; 0 is default provided by hardware.");
98 TUNABLE_INT("kern.smp.topology", &smp_topology);
99 
100 #ifdef SMP
101 /* Enable forwarding of a signal to a process running on a different CPU */
102 static int forward_signal_enabled = 1;
103 SYSCTL_INT(_kern_smp, OID_AUTO, forward_signal_enabled, CTLFLAG_RW,
104 	   &forward_signal_enabled, 0,
105 	   "Forwarding of a signal to a process on a different CPU");
106 
107 /* Enable forwarding of roundrobin to all other cpus */
108 static int forward_roundrobin_enabled = 1;
109 SYSCTL_INT(_kern_smp, OID_AUTO, forward_roundrobin_enabled, CTLFLAG_RW,
110 	   &forward_roundrobin_enabled, 0,
111 	   "Forwarding of roundrobin to all other CPUs");
112 
113 /* Variables needed for SMP rendezvous. */
114 static volatile int smp_rv_ncpus;
115 static void (*volatile smp_rv_setup_func)(void *arg);
116 static void (*volatile smp_rv_action_func)(void *arg);
117 static void (*volatile smp_rv_teardown_func)(void *arg);
118 static void *volatile smp_rv_func_arg;
119 static volatile int smp_rv_waiters[3];
120 
121 /*
122  * Shared mutex to restrict busywaits between smp_rendezvous() and
123  * smp(_targeted)_tlb_shootdown().  A deadlock occurs if both of these
124  * functions trigger at once and cause multiple CPUs to busywait with
125  * interrupts disabled.
126  */
127 struct mtx smp_ipi_mtx;
128 
129 /*
130  * Let the MD SMP code initialize mp_maxid very early if it can.
131  */
132 static void
133 mp_setmaxid(void *dummy)
134 {
135 	cpu_mp_setmaxid();
136 }
137 SYSINIT(cpu_mp_setmaxid, SI_SUB_TUNABLES, SI_ORDER_FIRST, mp_setmaxid, NULL);
138 
139 /*
140  * Call the MD SMP initialization code.
141  */
142 static void
143 mp_start(void *dummy)
144 {
145 
146 	/* Probe for MP hardware. */
147 	if (smp_disabled != 0 || cpu_mp_probe() == 0) {
148 		mp_ncpus = 1;
149 		all_cpus = PCPU_GET(cpumask);
150 		return;
151 	}
152 
153 	mtx_init(&smp_ipi_mtx, "smp rendezvous", NULL, MTX_SPIN);
154 	cpu_mp_start();
155 	printf("FreeBSD/SMP: Multiprocessor System Detected: %d CPUs\n",
156 	    mp_ncpus);
157 	cpu_mp_announce();
158 }
159 SYSINIT(cpu_mp, SI_SUB_CPU, SI_ORDER_THIRD, mp_start, NULL);
160 
161 void
162 forward_signal(struct thread *td)
163 {
164 	int id;
165 
166 	/*
167 	 * signotify() has already set TDF_ASTPENDING and TDF_NEEDSIGCHECK on
168 	 * this thread, so all we need to do is poke it if it is currently
169 	 * executing so that it executes ast().
170 	 */
171 	THREAD_LOCK_ASSERT(td, MA_OWNED);
172 	KASSERT(TD_IS_RUNNING(td),
173 	    ("forward_signal: thread is not TDS_RUNNING"));
174 
175 	CTR1(KTR_SMP, "forward_signal(%p)", td->td_proc);
176 
177 	if (!smp_started || cold || panicstr)
178 		return;
179 	if (!forward_signal_enabled)
180 		return;
181 
182 	/* No need to IPI ourself. */
183 	if (td == curthread)
184 		return;
185 
186 	id = td->td_oncpu;
187 	if (id == NOCPU)
188 		return;
189 	ipi_selected(1 << id, IPI_AST);
190 }
191 
192 void
193 forward_roundrobin(void)
194 {
195 	struct pcpu *pc;
196 	struct thread *td;
197 	cpumask_t id, map, me;
198 
199 	CTR0(KTR_SMP, "forward_roundrobin()");
200 
201 	if (!smp_started || cold || panicstr)
202 		return;
203 	if (!forward_roundrobin_enabled)
204 		return;
205 	map = 0;
206 	me = PCPU_GET(cpumask);
207 	SLIST_FOREACH(pc, &cpuhead, pc_allcpu) {
208 		td = pc->pc_curthread;
209 		id = pc->pc_cpumask;
210 		if (id != me && (id & stopped_cpus) == 0 &&
211 		    !TD_IS_IDLETHREAD(td)) {
212 			td->td_flags |= TDF_NEEDRESCHED;
213 			map |= id;
214 		}
215 	}
216 	ipi_selected(map, IPI_AST);
217 }
218 
219 /*
220  * When called the executing CPU will send an IPI to all other CPUs
221  *  requesting that they halt execution.
222  *
223  * Usually (but not necessarily) called with 'other_cpus' as its arg.
224  *
225  *  - Signals all CPUs in map to stop.
226  *  - Waits for each to stop.
227  *
228  * Returns:
229  *  -1: error
230  *   0: NA
231  *   1: ok
232  *
233  * XXX FIXME: this is not MP-safe, needs a lock to prevent multiple CPUs
234  *            from executing at same time.
235  */
236 int
237 stop_cpus(cpumask_t map)
238 {
239 	int i;
240 
241 	if (!smp_started)
242 		return 0;
243 
244 	CTR1(KTR_SMP, "stop_cpus(%x)", map);
245 
246 	/* send the stop IPI to all CPUs in map */
247 	ipi_selected(map, IPI_STOP);
248 
249 	i = 0;
250 	while ((stopped_cpus & map) != map) {
251 		/* spin */
252 		cpu_spinwait();
253 		i++;
254 #ifdef DIAGNOSTIC
255 		if (i == 100000) {
256 			printf("timeout stopping cpus\n");
257 			break;
258 		}
259 #endif
260 	}
261 
262 	return 1;
263 }
264 
265 #if defined(__amd64__)
266 /*
267  * When called the executing CPU will send an IPI to all other CPUs
268  *  requesting that they halt execution.
269  *
270  * Usually (but not necessarily) called with 'other_cpus' as its arg.
271  *
272  *  - Signals all CPUs in map to suspend.
273  *  - Waits for each to suspend.
274  *
275  * Returns:
276  *  -1: error
277  *   0: NA
278  *   1: ok
279  *
280  * XXX FIXME: this is not MP-safe, needs a lock to prevent multiple CPUs
281  *            from executing at same time.
282  */
283 int
284 suspend_cpus(cpumask_t map)
285 {
286 	int i;
287 
288 	if (!smp_started)
289 		return (0);
290 
291 	CTR1(KTR_SMP, "suspend_cpus(%x)", map);
292 
293 	/* send the suspend IPI to all CPUs in map */
294 	ipi_selected(map, IPI_SUSPEND);
295 
296 	i = 0;
297 	while ((stopped_cpus & map) != map) {
298 		/* spin */
299 		cpu_spinwait();
300 		i++;
301 #ifdef DIAGNOSTIC
302 		if (i == 100000) {
303 			printf("timeout suspending cpus\n");
304 			break;
305 		}
306 #endif
307 	}
308 
309 	return (1);
310 }
311 #endif
312 
313 /*
314  * Called by a CPU to restart stopped CPUs.
315  *
316  * Usually (but not necessarily) called with 'stopped_cpus' as its arg.
317  *
318  *  - Signals all CPUs in map to restart.
319  *  - Waits for each to restart.
320  *
321  * Returns:
322  *  -1: error
323  *   0: NA
324  *   1: ok
325  */
326 int
327 restart_cpus(cpumask_t map)
328 {
329 
330 	if (!smp_started)
331 		return 0;
332 
333 	CTR1(KTR_SMP, "restart_cpus(%x)", map);
334 
335 	/* signal other cpus to restart */
336 	atomic_store_rel_int(&started_cpus, map);
337 
338 	/* wait for each to clear its bit */
339 	while ((stopped_cpus & map) != 0)
340 		cpu_spinwait();
341 
342 	return 1;
343 }
344 
345 /*
346  * All-CPU rendezvous.  CPUs are signalled, all execute the setup function
347  * (if specified), rendezvous, execute the action function (if specified),
348  * rendezvous again, execute the teardown function (if specified), and then
349  * resume.
350  *
351  * Note that the supplied external functions _must_ be reentrant and aware
352  * that they are running in parallel and in an unknown lock context.
353  */
354 void
355 smp_rendezvous_action(void)
356 {
357 	void* local_func_arg = smp_rv_func_arg;
358 	void (*local_setup_func)(void*)   = smp_rv_setup_func;
359 	void (*local_action_func)(void*)   = smp_rv_action_func;
360 	void (*local_teardown_func)(void*) = smp_rv_teardown_func;
361 
362 	/* Ensure we have up-to-date values. */
363 	atomic_add_acq_int(&smp_rv_waiters[0], 1);
364 	while (smp_rv_waiters[0] < smp_rv_ncpus)
365 		cpu_spinwait();
366 
367 	/* setup function */
368 	if (local_setup_func != smp_no_rendevous_barrier) {
369 		if (smp_rv_setup_func != NULL)
370 			smp_rv_setup_func(smp_rv_func_arg);
371 
372 		/* spin on entry rendezvous */
373 		atomic_add_int(&smp_rv_waiters[1], 1);
374 		while (smp_rv_waiters[1] < smp_rv_ncpus)
375                 	cpu_spinwait();
376 	}
377 
378 	/* action function */
379 	if (local_action_func != NULL)
380 		local_action_func(local_func_arg);
381 
382 	/* spin on exit rendezvous */
383 	atomic_add_int(&smp_rv_waiters[2], 1);
384 	if (local_teardown_func == smp_no_rendevous_barrier)
385                 return;
386 	while (smp_rv_waiters[2] < smp_rv_ncpus)
387 		cpu_spinwait();
388 
389 	/* teardown function */
390 	if (local_teardown_func != NULL)
391 		local_teardown_func(local_func_arg);
392 }
393 
394 void
395 smp_rendezvous_cpus(cpumask_t map,
396 	void (* setup_func)(void *),
397 	void (* action_func)(void *),
398 	void (* teardown_func)(void *),
399 	void *arg)
400 {
401 	int i, ncpus = 0;
402 
403 	if (!smp_started) {
404 		if (setup_func != NULL)
405 			setup_func(arg);
406 		if (action_func != NULL)
407 			action_func(arg);
408 		if (teardown_func != NULL)
409 			teardown_func(arg);
410 		return;
411 	}
412 
413 	for (i = 0; i <= mp_maxid; i++)
414 		if (((1 << i) & map) != 0 && !CPU_ABSENT(i))
415 			ncpus++;
416 	if (ncpus == 0)
417 		panic("ncpus is 0 with map=0x%x", map);
418 
419 	/* obtain rendezvous lock */
420 	mtx_lock_spin(&smp_ipi_mtx);
421 
422 	/* set static function pointers */
423 	smp_rv_ncpus = ncpus;
424 	smp_rv_setup_func = setup_func;
425 	smp_rv_action_func = action_func;
426 	smp_rv_teardown_func = teardown_func;
427 	smp_rv_func_arg = arg;
428 	smp_rv_waiters[1] = 0;
429 	smp_rv_waiters[2] = 0;
430 	atomic_store_rel_int(&smp_rv_waiters[0], 0);
431 
432 	/* signal other processors, which will enter the IPI with interrupts off */
433 	ipi_selected(map & ~(1 << curcpu), IPI_RENDEZVOUS);
434 
435 	/* Check if the current CPU is in the map */
436 	if ((map & (1 << curcpu)) != 0)
437 		smp_rendezvous_action();
438 
439 	if (teardown_func == smp_no_rendevous_barrier)
440 		while (atomic_load_acq_int(&smp_rv_waiters[2]) < ncpus)
441 			cpu_spinwait();
442 
443 	/* release lock */
444 	mtx_unlock_spin(&smp_ipi_mtx);
445 }
446 
447 void
448 smp_rendezvous(void (* setup_func)(void *),
449 	       void (* action_func)(void *),
450 	       void (* teardown_func)(void *),
451 	       void *arg)
452 {
453 	smp_rendezvous_cpus(all_cpus, setup_func, action_func, teardown_func, arg);
454 }
455 
456 static struct cpu_group group[MAXCPU];
457 
458 struct cpu_group *
459 smp_topo(void)
460 {
461 	struct cpu_group *top;
462 
463 	/*
464 	 * Check for a fake topology request for debugging purposes.
465 	 */
466 	switch (smp_topology) {
467 	case 1:
468 		/* Dual core with no sharing.  */
469 		top = smp_topo_1level(CG_SHARE_NONE, 2, 0);
470 		break;
471 	case 2:
472 		/* No topology, all cpus are equal. */
473 		top = smp_topo_none();
474 		break;
475 	case 3:
476 		/* Dual core with shared L2.  */
477 		top = smp_topo_1level(CG_SHARE_L2, 2, 0);
478 		break;
479 	case 4:
480 		/* quad core, shared l3 among each package, private l2.  */
481 		top = smp_topo_1level(CG_SHARE_L3, 4, 0);
482 		break;
483 	case 5:
484 		/* quad core,  2 dualcore parts on each package share l2.  */
485 		top = smp_topo_2level(CG_SHARE_NONE, 2, CG_SHARE_L2, 2, 0);
486 		break;
487 	case 6:
488 		/* Single-core 2xHTT */
489 		top = smp_topo_1level(CG_SHARE_L1, 2, CG_FLAG_HTT);
490 		break;
491 	case 7:
492 		/* quad core with a shared l3, 8 threads sharing L2.  */
493 		top = smp_topo_2level(CG_SHARE_L3, 4, CG_SHARE_L2, 8,
494 		    CG_FLAG_SMT);
495 		break;
496 	default:
497 		/* Default, ask the system what it wants. */
498 		top = cpu_topo();
499 		break;
500 	}
501 	/*
502 	 * Verify the returned topology.
503 	 */
504 	if (top->cg_count != mp_ncpus)
505 		panic("Built bad topology at %p.  CPU count %d != %d",
506 		    top, top->cg_count, mp_ncpus);
507 	if (top->cg_mask != all_cpus)
508 		panic("Built bad topology at %p.  CPU mask 0x%X != 0x%X",
509 		    top, top->cg_mask, all_cpus);
510 	return (top);
511 }
512 
513 struct cpu_group *
514 smp_topo_none(void)
515 {
516 	struct cpu_group *top;
517 
518 	top = &group[0];
519 	top->cg_parent = NULL;
520 	top->cg_child = NULL;
521 	top->cg_mask = (1 << mp_ncpus) - 1;
522 	top->cg_count = mp_ncpus;
523 	top->cg_children = 0;
524 	top->cg_level = CG_SHARE_NONE;
525 	top->cg_flags = 0;
526 
527 	return (top);
528 }
529 
530 static int
531 smp_topo_addleaf(struct cpu_group *parent, struct cpu_group *child, int share,
532     int count, int flags, int start)
533 {
534 	cpumask_t mask;
535 	int i;
536 
537 	for (mask = 0, i = 0; i < count; i++, start++)
538 		mask |= (1 << start);
539 	child->cg_parent = parent;
540 	child->cg_child = NULL;
541 	child->cg_children = 0;
542 	child->cg_level = share;
543 	child->cg_count = count;
544 	child->cg_flags = flags;
545 	child->cg_mask = mask;
546 	parent->cg_children++;
547 	for (; parent != NULL; parent = parent->cg_parent) {
548 		if ((parent->cg_mask & child->cg_mask) != 0)
549 			panic("Duplicate children in %p.  mask 0x%X child 0x%X",
550 			    parent, parent->cg_mask, child->cg_mask);
551 		parent->cg_mask |= child->cg_mask;
552 		parent->cg_count += child->cg_count;
553 	}
554 
555 	return (start);
556 }
557 
558 struct cpu_group *
559 smp_topo_1level(int share, int count, int flags)
560 {
561 	struct cpu_group *child;
562 	struct cpu_group *top;
563 	int packages;
564 	int cpu;
565 	int i;
566 
567 	cpu = 0;
568 	top = &group[0];
569 	packages = mp_ncpus / count;
570 	top->cg_child = child = &group[1];
571 	top->cg_level = CG_SHARE_NONE;
572 	for (i = 0; i < packages; i++, child++)
573 		cpu = smp_topo_addleaf(top, child, share, count, flags, cpu);
574 	return (top);
575 }
576 
577 struct cpu_group *
578 smp_topo_2level(int l2share, int l2count, int l1share, int l1count,
579     int l1flags)
580 {
581 	struct cpu_group *top;
582 	struct cpu_group *l1g;
583 	struct cpu_group *l2g;
584 	int cpu;
585 	int i;
586 	int j;
587 
588 	cpu = 0;
589 	top = &group[0];
590 	l2g = &group[1];
591 	top->cg_child = l2g;
592 	top->cg_level = CG_SHARE_NONE;
593 	top->cg_children = mp_ncpus / (l2count * l1count);
594 	l1g = l2g + top->cg_children;
595 	for (i = 0; i < top->cg_children; i++, l2g++) {
596 		l2g->cg_parent = top;
597 		l2g->cg_child = l1g;
598 		l2g->cg_level = l2share;
599 		for (j = 0; j < l2count; j++, l1g++)
600 			cpu = smp_topo_addleaf(l2g, l1g, l1share, l1count,
601 			    l1flags, cpu);
602 	}
603 	return (top);
604 }
605 
606 
607 struct cpu_group *
608 smp_topo_find(struct cpu_group *top, int cpu)
609 {
610 	struct cpu_group *cg;
611 	cpumask_t mask;
612 	int children;
613 	int i;
614 
615 	mask = (1 << cpu);
616 	cg = top;
617 	for (;;) {
618 		if ((cg->cg_mask & mask) == 0)
619 			return (NULL);
620 		if (cg->cg_children == 0)
621 			return (cg);
622 		children = cg->cg_children;
623 		for (i = 0, cg = cg->cg_child; i < children; cg++, i++)
624 			if ((cg->cg_mask & mask) != 0)
625 				break;
626 	}
627 	return (NULL);
628 }
629 #else /* !SMP */
630 
631 void
632 smp_rendezvous_cpus(cpumask_t map,
633 	void (*setup_func)(void *),
634 	void (*action_func)(void *),
635 	void (*teardown_func)(void *),
636 	void *arg)
637 {
638 	if (setup_func != NULL)
639 		setup_func(arg);
640 	if (action_func != NULL)
641 		action_func(arg);
642 	if (teardown_func != NULL)
643 		teardown_func(arg);
644 }
645 
646 void
647 smp_rendezvous(void (*setup_func)(void *),
648 	       void (*action_func)(void *),
649 	       void (*teardown_func)(void *),
650 	       void *arg)
651 {
652 
653 	if (setup_func != NULL)
654 		setup_func(arg);
655 	if (action_func != NULL)
656 		action_func(arg);
657 	if (teardown_func != NULL)
658 		teardown_func(arg);
659 }
660 
661 /*
662  * Provide dummy SMP support for UP kernels.  Modules that need to use SMP
663  * APIs will still work using this dummy support.
664  */
665 static void
666 mp_setvariables_for_up(void *dummy)
667 {
668 	mp_ncpus = 1;
669 	mp_maxid = PCPU_GET(cpuid);
670 	all_cpus = PCPU_GET(cpumask);
671 	KASSERT(PCPU_GET(cpuid) == 0, ("UP must have a CPU ID of zero"));
672 }
673 SYSINIT(cpu_mp_setvariables, SI_SUB_TUNABLES, SI_ORDER_FIRST,
674     mp_setvariables_for_up, NULL);
675 #endif /* SMP */
676 
677 void
678 smp_no_rendevous_barrier(void *dummy)
679 {
680 #ifdef SMP
681 	KASSERT((!smp_started),("smp_no_rendevous called and smp is started"));
682 #endif
683 }
684