xref: /freebsd/sys/fs/nfsclient/nfs_clnode.c (revision 8f73d398eda19cea49d16932d09e165ff3e299b5)
19ec7b004SRick Macklem /*-
29ec7b004SRick Macklem  * Copyright (c) 1989, 1993
39ec7b004SRick Macklem  *	The Regents of the University of California.  All rights reserved.
49ec7b004SRick Macklem  *
59ec7b004SRick Macklem  * This code is derived from software contributed to Berkeley by
69ec7b004SRick Macklem  * Rick Macklem at The University of Guelph.
79ec7b004SRick Macklem  *
89ec7b004SRick Macklem  * Redistribution and use in source and binary forms, with or without
99ec7b004SRick Macklem  * modification, are permitted provided that the following conditions
109ec7b004SRick Macklem  * are met:
119ec7b004SRick Macklem  * 1. Redistributions of source code must retain the above copyright
129ec7b004SRick Macklem  *    notice, this list of conditions and the following disclaimer.
139ec7b004SRick Macklem  * 2. Redistributions in binary form must reproduce the above copyright
149ec7b004SRick Macklem  *    notice, this list of conditions and the following disclaimer in the
159ec7b004SRick Macklem  *    documentation and/or other materials provided with the distribution.
169ec7b004SRick Macklem  * 4. Neither the name of the University nor the names of its contributors
179ec7b004SRick Macklem  *    may be used to endorse or promote products derived from this software
189ec7b004SRick Macklem  *    without specific prior written permission.
199ec7b004SRick Macklem  *
209ec7b004SRick Macklem  * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
219ec7b004SRick Macklem  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
229ec7b004SRick Macklem  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
239ec7b004SRick Macklem  * ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
249ec7b004SRick Macklem  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
259ec7b004SRick Macklem  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
269ec7b004SRick Macklem  * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
279ec7b004SRick Macklem  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
289ec7b004SRick Macklem  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
299ec7b004SRick Macklem  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
309ec7b004SRick Macklem  * SUCH DAMAGE.
319ec7b004SRick Macklem  *
329ec7b004SRick Macklem  *	from nfs_node.c	8.6 (Berkeley) 5/22/95
339ec7b004SRick Macklem  */
349ec7b004SRick Macklem 
359ec7b004SRick Macklem #include <sys/cdefs.h>
369ec7b004SRick Macklem __FBSDID("$FreeBSD$");
379ec7b004SRick Macklem 
389ec7b004SRick Macklem #include <sys/param.h>
399ec7b004SRick Macklem #include <sys/systm.h>
40ca27c028SRick Macklem #include <sys/fcntl.h>
419ec7b004SRick Macklem #include <sys/lock.h>
429ec7b004SRick Macklem #include <sys/malloc.h>
439ec7b004SRick Macklem #include <sys/mount.h>
449ec7b004SRick Macklem #include <sys/namei.h>
459ec7b004SRick Macklem #include <sys/proc.h>
469ec7b004SRick Macklem #include <sys/socket.h>
479ec7b004SRick Macklem #include <sys/sysctl.h>
48e2eb210cSRick Macklem #include <sys/taskqueue.h>
499ec7b004SRick Macklem #include <sys/vnode.h>
509ec7b004SRick Macklem 
519ec7b004SRick Macklem #include <vm/uma.h>
529ec7b004SRick Macklem 
539ec7b004SRick Macklem #include <fs/nfs/nfsport.h>
549ec7b004SRick Macklem #include <fs/nfsclient/nfsnode.h>
559ec7b004SRick Macklem #include <fs/nfsclient/nfsmount.h>
569ec7b004SRick Macklem #include <fs/nfsclient/nfs.h>
578f0e65c9SRick Macklem #include <fs/nfsclient/nfs_kdtrace.h>
589ec7b004SRick Macklem 
59ca27c028SRick Macklem #include <nfs/nfs_lock.h>
60ca27c028SRick Macklem 
619ec7b004SRick Macklem extern struct vop_vector newnfs_vnodeops;
629ec7b004SRick Macklem extern struct buf_ops buf_ops_newnfs;
639ec7b004SRick Macklem MALLOC_DECLARE(M_NEWNFSREQ);
649ec7b004SRick Macklem 
659ec7b004SRick Macklem uma_zone_t newnfsnode_zone;
669ec7b004SRick Macklem 
6743a993bbSKirk McKusick const char nfs_vnode_tag[] = "nfs";
6843a993bbSKirk McKusick 
69e2eb210cSRick Macklem static void	nfs_freesillyrename(void *arg, __unused int pending);
70e2eb210cSRick Macklem 
719ec7b004SRick Macklem void
729ec7b004SRick Macklem ncl_nhinit(void)
739ec7b004SRick Macklem {
749ec7b004SRick Macklem 
759ec7b004SRick Macklem 	newnfsnode_zone = uma_zcreate("NCLNODE", sizeof(struct nfsnode), NULL,
769ec7b004SRick Macklem 	    NULL, NULL, NULL, UMA_ALIGN_PTR, 0);
779ec7b004SRick Macklem }
789ec7b004SRick Macklem 
799ec7b004SRick Macklem void
809ec7b004SRick Macklem ncl_nhuninit(void)
819ec7b004SRick Macklem {
829ec7b004SRick Macklem 	uma_zdestroy(newnfsnode_zone);
839ec7b004SRick Macklem }
849ec7b004SRick Macklem 
859ec7b004SRick Macklem /*
869ec7b004SRick Macklem  * ONLY USED FOR THE ROOT DIRECTORY. nfscl_nget() does the rest. If this
879ec7b004SRick Macklem  * function is going to be used to get Regular Files, code must be added
889ec7b004SRick Macklem  * to fill in the "struct nfsv4node".
899ec7b004SRick Macklem  * Look up a vnode/nfsnode by file handle.
909ec7b004SRick Macklem  * Callers must check for mount points!!
919ec7b004SRick Macklem  * In all cases, a pointer to a
929ec7b004SRick Macklem  * nfsnode structure is returned.
939ec7b004SRick Macklem  */
949ec7b004SRick Macklem int
954b3a38ecSRick Macklem ncl_nget(struct mount *mntp, u_int8_t *fhp, int fhsize, struct nfsnode **npp,
964b3a38ecSRick Macklem     int lkflags)
979ec7b004SRick Macklem {
989ec7b004SRick Macklem 	struct thread *td = curthread;	/* XXX */
999ec7b004SRick Macklem 	struct nfsnode *np;
1009ec7b004SRick Macklem 	struct vnode *vp;
1019ec7b004SRick Macklem 	struct vnode *nvp;
1029ec7b004SRick Macklem 	int error;
1039ec7b004SRick Macklem 	u_int hash;
1049ec7b004SRick Macklem 	struct nfsmount *nmp;
1059ec7b004SRick Macklem 	struct nfsfh *nfhp;
1069ec7b004SRick Macklem 
1079ec7b004SRick Macklem 	nmp = VFSTONFS(mntp);
1089ec7b004SRick Macklem 	*npp = NULL;
1099ec7b004SRick Macklem 
1109ec7b004SRick Macklem 	hash = fnv_32_buf(fhp, fhsize, FNV1_32_INIT);
1119ec7b004SRick Macklem 
1129ec7b004SRick Macklem 	MALLOC(nfhp, struct nfsfh *, sizeof (struct nfsfh) + fhsize,
1139ec7b004SRick Macklem 	    M_NFSFH, M_WAITOK);
1149ec7b004SRick Macklem 	bcopy(fhp, &nfhp->nfh_fh[0], fhsize);
1159ec7b004SRick Macklem 	nfhp->nfh_len = fhsize;
1164b3a38ecSRick Macklem 	error = vfs_hash_get(mntp, hash, lkflags,
1179ec7b004SRick Macklem 	    td, &nvp, newnfs_vncmpf, nfhp);
1189ec7b004SRick Macklem 	FREE(nfhp, M_NFSFH);
1199ec7b004SRick Macklem 	if (error)
1209ec7b004SRick Macklem 		return (error);
1219ec7b004SRick Macklem 	if (nvp != NULL) {
1229ec7b004SRick Macklem 		*npp = VTONFS(nvp);
1239ec7b004SRick Macklem 		return (0);
1249ec7b004SRick Macklem 	}
1259ec7b004SRick Macklem 	np = uma_zalloc(newnfsnode_zone, M_WAITOK | M_ZERO);
1269ec7b004SRick Macklem 
12743a993bbSKirk McKusick 	error = getnewvnode(nfs_vnode_tag, mntp, &newnfs_vnodeops, &nvp);
1289ec7b004SRick Macklem 	if (error) {
1299ec7b004SRick Macklem 		uma_zfree(newnfsnode_zone, np);
1309ec7b004SRick Macklem 		return (error);
1319ec7b004SRick Macklem 	}
1329ec7b004SRick Macklem 	vp = nvp;
1337f763fc3SRick Macklem 	KASSERT(vp->v_bufobj.bo_bsize != 0, ("ncl_nget: bo_bsize == 0"));
1349ec7b004SRick Macklem 	vp->v_bufobj.bo_ops = &buf_ops_newnfs;
1359ec7b004SRick Macklem 	vp->v_data = np;
1369ec7b004SRick Macklem 	np->n_vnode = vp;
1379ec7b004SRick Macklem 	/*
1389ec7b004SRick Macklem 	 * Initialize the mutex even if the vnode is going to be a loser.
1399ec7b004SRick Macklem 	 * This simplifies the logic in reclaim, which can then unconditionally
1409ec7b004SRick Macklem 	 * destroy the mutex (in the case of the loser, or if hash_insert
1419ec7b004SRick Macklem 	 * happened to return an error no special casing is needed).
1429ec7b004SRick Macklem 	 */
1439ec7b004SRick Macklem 	mtx_init(&np->n_mtx, "NEWNFSnode lock", NULL, MTX_DEF | MTX_DUPOK);
1449ec7b004SRick Macklem 	/*
1459ec7b004SRick Macklem 	 * NFS supports recursive and shared locking.
1469ec7b004SRick Macklem 	 */
1473634d5b2SJohn Baldwin 	lockmgr(vp->v_vnlock, LK_EXCLUSIVE | LK_NOWITNESS, NULL);
1489ec7b004SRick Macklem 	VN_LOCK_AREC(vp);
1499ec7b004SRick Macklem 	VN_LOCK_ASHARE(vp);
1509ec7b004SRick Macklem 	/*
1519ec7b004SRick Macklem 	 * Are we getting the root? If so, make sure the vnode flags
1529ec7b004SRick Macklem 	 * are correct
1539ec7b004SRick Macklem 	 */
1549ec7b004SRick Macklem 	if ((fhsize == nmp->nm_fhsize) &&
1559ec7b004SRick Macklem 	    !bcmp(fhp, nmp->nm_fh, fhsize)) {
1569ec7b004SRick Macklem 		if (vp->v_type == VNON)
1579ec7b004SRick Macklem 			vp->v_type = VDIR;
1589ec7b004SRick Macklem 		vp->v_vflag |= VV_ROOT;
1599ec7b004SRick Macklem 	}
1609ec7b004SRick Macklem 
1619ec7b004SRick Macklem 	MALLOC(np->n_fhp, struct nfsfh *, sizeof (struct nfsfh) + fhsize,
1629ec7b004SRick Macklem 	    M_NFSFH, M_WAITOK);
1639ec7b004SRick Macklem 	bcopy(fhp, np->n_fhp->nfh_fh, fhsize);
1649ec7b004SRick Macklem 	np->n_fhp->nfh_len = fhsize;
1659ec7b004SRick Macklem 	error = insmntque(vp, mntp);
1669ec7b004SRick Macklem 	if (error != 0) {
1679ec7b004SRick Macklem 		*npp = NULL;
1689ec7b004SRick Macklem 		FREE((caddr_t)np->n_fhp, M_NFSFH);
1699ec7b004SRick Macklem 		mtx_destroy(&np->n_mtx);
1709ec7b004SRick Macklem 		uma_zfree(newnfsnode_zone, np);
1719ec7b004SRick Macklem 		return (error);
1729ec7b004SRick Macklem 	}
1734b3a38ecSRick Macklem 	error = vfs_hash_insert(vp, hash, lkflags,
1749ec7b004SRick Macklem 	    td, &nvp, newnfs_vncmpf, np->n_fhp);
1759ec7b004SRick Macklem 	if (error)
1769ec7b004SRick Macklem 		return (error);
1779ec7b004SRick Macklem 	if (nvp != NULL) {
1789ec7b004SRick Macklem 		*npp = VTONFS(nvp);
1799ec7b004SRick Macklem 		/* vfs_hash_insert() vput()'s the losing vnode */
1809ec7b004SRick Macklem 		return (0);
1819ec7b004SRick Macklem 	}
1829ec7b004SRick Macklem 	*npp = np;
1839ec7b004SRick Macklem 
1849ec7b004SRick Macklem 	return (0);
1859ec7b004SRick Macklem }
1869ec7b004SRick Macklem 
187e2eb210cSRick Macklem /*
188e2eb210cSRick Macklem  * Do the vrele(sp->s_dvp) as a separate task in order to avoid a
189e2eb210cSRick Macklem  * deadlock because of a LOR when vrele() locks the directory vnode.
190e2eb210cSRick Macklem  */
191e2eb210cSRick Macklem static void
192e2eb210cSRick Macklem nfs_freesillyrename(void *arg, __unused int pending)
193e2eb210cSRick Macklem {
194e2eb210cSRick Macklem 	struct sillyrename *sp;
195e2eb210cSRick Macklem 
196e2eb210cSRick Macklem 	sp = arg;
197e2eb210cSRick Macklem 	vrele(sp->s_dvp);
198e2eb210cSRick Macklem 	free(sp, M_NEWNFSREQ);
199e2eb210cSRick Macklem }
200e2eb210cSRick Macklem 
201*8f73d398SKonstantin Belousov static void
202*8f73d398SKonstantin Belousov ncl_releasesillyrename(struct vnode *vp, struct thread *td)
2039ec7b004SRick Macklem {
2049ec7b004SRick Macklem 	struct nfsnode *np;
2059ec7b004SRick Macklem 	struct sillyrename *sp;
206*8f73d398SKonstantin Belousov 
207*8f73d398SKonstantin Belousov 	ASSERT_VOP_ELOCKED(vp, "releasesillyrename");
208*8f73d398SKonstantin Belousov 	np = VTONFS(vp);
209*8f73d398SKonstantin Belousov 	mtx_lock(&np->n_mtx);
210*8f73d398SKonstantin Belousov 	if (vp->v_type != VDIR) {
211*8f73d398SKonstantin Belousov 		sp = np->n_sillyrename;
212*8f73d398SKonstantin Belousov 		np->n_sillyrename = NULL;
213*8f73d398SKonstantin Belousov 	} else
214*8f73d398SKonstantin Belousov 		sp = NULL;
215*8f73d398SKonstantin Belousov 	if (sp != NULL) {
216*8f73d398SKonstantin Belousov 		mtx_unlock(&np->n_mtx);
217*8f73d398SKonstantin Belousov 		(void) ncl_vinvalbuf(vp, 0, td, 1);
218*8f73d398SKonstantin Belousov 		/*
219*8f73d398SKonstantin Belousov 		 * Remove the silly file that was rename'd earlier
220*8f73d398SKonstantin Belousov 		 */
221*8f73d398SKonstantin Belousov 		ncl_removeit(sp, vp);
222*8f73d398SKonstantin Belousov 		crfree(sp->s_cred);
223*8f73d398SKonstantin Belousov 		TASK_INIT(&sp->s_task, 0, nfs_freesillyrename, sp);
224*8f73d398SKonstantin Belousov 		taskqueue_enqueue(taskqueue_thread, &sp->s_task);
225*8f73d398SKonstantin Belousov 		mtx_lock(&np->n_mtx);
226*8f73d398SKonstantin Belousov 	}
227*8f73d398SKonstantin Belousov 	np->n_flag &= NMODIFIED;
228*8f73d398SKonstantin Belousov 	mtx_unlock(&np->n_mtx);
229*8f73d398SKonstantin Belousov }
230*8f73d398SKonstantin Belousov 
231*8f73d398SKonstantin Belousov int
232*8f73d398SKonstantin Belousov ncl_inactive(struct vop_inactive_args *ap)
233*8f73d398SKonstantin Belousov {
234d00a615aSRick Macklem 	struct vnode *vp = ap->a_vp;
23553e1b8fbSRick Macklem 	boolean_t retv;
2369ec7b004SRick Macklem 
237d00a615aSRick Macklem 	if (NFS_ISV4(vp) && vp->v_type == VREG) {
23847a59856SRick Macklem 		/*
239fdd88deeSRick Macklem 		 * Since mmap()'d files do I/O after VOP_CLOSE(), the NFSv4
24053e1b8fbSRick Macklem 		 * Close operations are delayed until now. Any dirty
24153e1b8fbSRick Macklem 		 * buffers/pages must be flushed before the close, so that the
24253e1b8fbSRick Macklem 		 * stateid is available for the writes.
24347a59856SRick Macklem 		 */
24453e1b8fbSRick Macklem 		if (vp->v_object != NULL) {
24589f6b863SAttilio Rao 			VM_OBJECT_WLOCK(vp->v_object);
24653e1b8fbSRick Macklem 			retv = vm_object_page_clean(vp->v_object, 0, 0,
24753e1b8fbSRick Macklem 			    OBJPC_SYNC);
24889f6b863SAttilio Rao 			VM_OBJECT_WUNLOCK(vp->v_object);
24953e1b8fbSRick Macklem 		} else
25053e1b8fbSRick Macklem 			retv = TRUE;
25153e1b8fbSRick Macklem 		if (retv == TRUE) {
25267c5c2d2SRick Macklem 			(void)ncl_flush(vp, MNT_WAIT, NULL, ap->a_td, 1, 0);
253d00a615aSRick Macklem 			(void)nfsrpc_close(vp, 1, ap->a_td);
254fdd88deeSRick Macklem 		}
25553e1b8fbSRick Macklem 	}
25647a59856SRick Macklem 
257*8f73d398SKonstantin Belousov 	ncl_releasesillyrename(vp, ap->a_td);
2589ec7b004SRick Macklem 	return (0);
2599ec7b004SRick Macklem }
2609ec7b004SRick Macklem 
2619ec7b004SRick Macklem /*
2629ec7b004SRick Macklem  * Reclaim an nfsnode so that it can be used for other purposes.
2639ec7b004SRick Macklem  */
2649ec7b004SRick Macklem int
2659ec7b004SRick Macklem ncl_reclaim(struct vop_reclaim_args *ap)
2669ec7b004SRick Macklem {
2679ec7b004SRick Macklem 	struct vnode *vp = ap->a_vp;
2689ec7b004SRick Macklem 	struct nfsnode *np = VTONFS(vp);
2699ec7b004SRick Macklem 	struct nfsdmap *dp, *dp2;
2709ec7b004SRick Macklem 
2719ec7b004SRick Macklem 	/*
2729ec7b004SRick Macklem 	 * If the NLM is running, give it a chance to abort pending
2739ec7b004SRick Macklem 	 * locks.
2749ec7b004SRick Macklem 	 */
275ca27c028SRick Macklem 	if (nfs_reclaim_p != NULL)
276ca27c028SRick Macklem 		nfs_reclaim_p(ap);
2779ec7b004SRick Macklem 
278*8f73d398SKonstantin Belousov 	ncl_releasesillyrename(vp, ap->a_td);
279*8f73d398SKonstantin Belousov 
2809ec7b004SRick Macklem 	/*
2819ec7b004SRick Macklem 	 * Destroy the vm object and flush associated pages.
2829ec7b004SRick Macklem 	 */
2839ec7b004SRick Macklem 	vnode_destroy_vobject(vp);
2849ec7b004SRick Macklem 
28579cafccdSRick Macklem 	if (NFS_ISV4(vp) && vp->v_type == VREG)
28679cafccdSRick Macklem 		/*
28779cafccdSRick Macklem 		 * We can now safely close any remaining NFSv4 Opens for
28879cafccdSRick Macklem 		 * this file. Most opens will have already been closed by
28979cafccdSRick Macklem 		 * ncl_inactive(), but there are cases where it is not
29079cafccdSRick Macklem 		 * called, so we need to do it again here.
29179cafccdSRick Macklem 		 */
29279cafccdSRick Macklem 		(void) nfsrpc_close(vp, 1, ap->a_td);
29379cafccdSRick Macklem 
2949ec7b004SRick Macklem 	vfs_hash_remove(vp);
2959ec7b004SRick Macklem 
2969ec7b004SRick Macklem 	/*
2979ec7b004SRick Macklem 	 * Call nfscl_reclaimnode() to save attributes in the delegation,
2989ec7b004SRick Macklem 	 * as required.
2999ec7b004SRick Macklem 	 */
3009ec7b004SRick Macklem 	if (vp->v_type == VREG)
3019ec7b004SRick Macklem 		nfscl_reclaimnode(vp);
3029ec7b004SRick Macklem 
3039ec7b004SRick Macklem 	/*
3049ec7b004SRick Macklem 	 * Free up any directory cookie structures and
3059ec7b004SRick Macklem 	 * large file handle structures that might be associated with
3069ec7b004SRick Macklem 	 * this nfs node.
3079ec7b004SRick Macklem 	 */
3089ec7b004SRick Macklem 	if (vp->v_type == VDIR) {
3099ec7b004SRick Macklem 		dp = LIST_FIRST(&np->n_cookies);
3109ec7b004SRick Macklem 		while (dp) {
3119ec7b004SRick Macklem 			dp2 = dp;
3129ec7b004SRick Macklem 			dp = LIST_NEXT(dp, ndm_list);
3139ec7b004SRick Macklem 			FREE((caddr_t)dp2, M_NFSDIROFF);
3149ec7b004SRick Macklem 		}
3159ec7b004SRick Macklem 	}
3167af1242aSRick Macklem 	if (np->n_writecred != NULL)
3177af1242aSRick Macklem 		crfree(np->n_writecred);
3189ec7b004SRick Macklem 	FREE((caddr_t)np->n_fhp, M_NFSFH);
3199ec7b004SRick Macklem 	if (np->n_v4 != NULL)
3209ec7b004SRick Macklem 		FREE((caddr_t)np->n_v4, M_NFSV4NODE);
3219ec7b004SRick Macklem 	mtx_destroy(&np->n_mtx);
3229ec7b004SRick Macklem 	uma_zfree(newnfsnode_zone, vp->v_data);
3239ec7b004SRick Macklem 	vp->v_data = NULL;
3249ec7b004SRick Macklem 	return (0);
3259ec7b004SRick Macklem }
3269ec7b004SRick Macklem 
3279ec7b004SRick Macklem /*
3289ec7b004SRick Macklem  * Invalidate both the access and attribute caches for this vnode.
3299ec7b004SRick Macklem  */
3309ec7b004SRick Macklem void
3319ec7b004SRick Macklem ncl_invalcaches(struct vnode *vp)
3329ec7b004SRick Macklem {
3339ec7b004SRick Macklem 	struct nfsnode *np = VTONFS(vp);
3349ec7b004SRick Macklem 	int i;
3359ec7b004SRick Macklem 
3369ec7b004SRick Macklem 	mtx_lock(&np->n_mtx);
3379ec7b004SRick Macklem 	for (i = 0; i < NFS_ACCESSCACHESIZE; i++)
3389ec7b004SRick Macklem 		np->n_accesscache[i].stamp = 0;
3398f0e65c9SRick Macklem 	KDTRACE_NFS_ACCESSCACHE_FLUSH_DONE(vp);
3409ec7b004SRick Macklem 	np->n_attrstamp = 0;
3418f0e65c9SRick Macklem 	KDTRACE_NFS_ATTRCACHE_FLUSH_DONE(vp);
3429ec7b004SRick Macklem 	mtx_unlock(&np->n_mtx);
3439ec7b004SRick Macklem }
344