1c3aac50fSPeter Wemm /* $FreeBSD$ */ 2952a6212SJordan K. Hubbard /* $NetBSD: msdosfs_denode.c,v 1.28 1998/02/10 14:10:00 mrg Exp $ */ 327a0bc89SDoug Rabson 427a0bc89SDoug Rabson /*- 5952a6212SJordan K. Hubbard * Copyright (C) 1994, 1995, 1997 Wolfgang Solfrank. 6952a6212SJordan K. Hubbard * Copyright (C) 1994, 1995, 1997 TooLs GmbH. 727a0bc89SDoug Rabson * All rights reserved. 827a0bc89SDoug Rabson * Original code by Paul Popelka (paulp@uts.amdahl.com) (see below). 927a0bc89SDoug Rabson * 1027a0bc89SDoug Rabson * Redistribution and use in source and binary forms, with or without 1127a0bc89SDoug Rabson * modification, are permitted provided that the following conditions 1227a0bc89SDoug Rabson * are met: 1327a0bc89SDoug Rabson * 1. Redistributions of source code must retain the above copyright 1427a0bc89SDoug Rabson * notice, this list of conditions and the following disclaimer. 1527a0bc89SDoug Rabson * 2. Redistributions in binary form must reproduce the above copyright 1627a0bc89SDoug Rabson * notice, this list of conditions and the following disclaimer in the 1727a0bc89SDoug Rabson * documentation and/or other materials provided with the distribution. 1827a0bc89SDoug Rabson * 3. All advertising materials mentioning features or use of this software 1927a0bc89SDoug Rabson * must display the following acknowledgement: 2027a0bc89SDoug Rabson * This product includes software developed by TooLs GmbH. 2127a0bc89SDoug Rabson * 4. The name of TooLs GmbH may not be used to endorse or promote products 2227a0bc89SDoug Rabson * derived from this software without specific prior written permission. 2327a0bc89SDoug Rabson * 2427a0bc89SDoug Rabson * THIS SOFTWARE IS PROVIDED BY TOOLS GMBH ``AS IS'' AND ANY EXPRESS OR 2527a0bc89SDoug Rabson * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES 2627a0bc89SDoug Rabson * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. 2727a0bc89SDoug Rabson * IN NO EVENT SHALL TOOLS GMBH BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 2827a0bc89SDoug Rabson * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 2927a0bc89SDoug Rabson * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; 3027a0bc89SDoug Rabson * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, 3127a0bc89SDoug Rabson * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR 3227a0bc89SDoug Rabson * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF 3327a0bc89SDoug Rabson * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 3427a0bc89SDoug Rabson */ 3527a0bc89SDoug Rabson /* 3627a0bc89SDoug Rabson * Written by Paul Popelka (paulp@uts.amdahl.com) 3727a0bc89SDoug Rabson * 3827a0bc89SDoug Rabson * You can do anything you want with this software, just don't say you wrote 3927a0bc89SDoug Rabson * it, and don't remove this notice. 4027a0bc89SDoug Rabson * 4127a0bc89SDoug Rabson * This software is provided "as is". 4227a0bc89SDoug Rabson * 4327a0bc89SDoug Rabson * The author supplies this software to be publicly redistributed on the 4427a0bc89SDoug Rabson * understanding that the author is not responsible for the correct 4527a0bc89SDoug Rabson * functioning of this software in any circumstances and is not liable for 4627a0bc89SDoug Rabson * any damages caused by this software. 4727a0bc89SDoug Rabson * 4827a0bc89SDoug Rabson * October 1992 4927a0bc89SDoug Rabson */ 5027a0bc89SDoug Rabson 5127a0bc89SDoug Rabson #include <sys/param.h> 5227a0bc89SDoug Rabson #include <sys/systm.h> 531c5bb3eaSPeter Wemm #include <sys/kernel.h> 5427a0bc89SDoug Rabson #include <sys/mount.h> 5527a0bc89SDoug Rabson #include <sys/malloc.h> 569626b608SPoul-Henning Kamp #include <sys/bio.h> 5727a0bc89SDoug Rabson #include <sys/buf.h> 5827a0bc89SDoug Rabson #include <sys/vnode.h> 591b367556SJason Evans #include <sys/mutex.h> 6027a0bc89SDoug Rabson 61c3c6d51eSPoul-Henning Kamp #include <vm/vm.h> 62efeaf95aSDavid Greenman #include <vm/vm_extern.h> 63c3c6d51eSPoul-Henning Kamp 641166fb51SRuslan Ermilov #include <fs/msdosfs/bpb.h> 651166fb51SRuslan Ermilov #include <fs/msdosfs/msdosfsmount.h> 661166fb51SRuslan Ermilov #include <fs/msdosfs/direntry.h> 671166fb51SRuslan Ermilov #include <fs/msdosfs/denode.h> 681166fb51SRuslan Ermilov #include <fs/msdosfs/fat.h> 6927a0bc89SDoug Rabson 70a1c995b6SPoul-Henning Kamp static MALLOC_DEFINE(M_MSDOSFSNODE, "MSDOSFS node", "MSDOSFS vnode private part"); 7155166637SPoul-Henning Kamp 72303b270bSEivind Eklund static struct denode **dehashtbl; 73303b270bSEivind Eklund static u_long dehash; /* size of hash table - 1 */ 74bfbb9ce6SPoul-Henning Kamp #define DEHASH(dev, dcl, doff) (dehashtbl[(minor(dev) + (dcl) + (doff) / \ 75952a6212SJordan K. Hubbard sizeof(struct direntry)) & dehash]) 761b367556SJason Evans static struct mtx dehash_mtx; 7727a0bc89SDoug Rabson 7894a8606fSDoug Rabson union _qcvt { 7994a8606fSDoug Rabson quad_t qcvt; 8094a8606fSDoug Rabson long val[2]; 8194a8606fSDoug Rabson }; 8294a8606fSDoug Rabson #define SETHIGH(q, h) { \ 8394a8606fSDoug Rabson union _qcvt tmp; \ 8494a8606fSDoug Rabson tmp.qcvt = (q); \ 8594a8606fSDoug Rabson tmp.val[_QUAD_HIGHWORD] = (h); \ 8694a8606fSDoug Rabson (q) = tmp.qcvt; \ 8794a8606fSDoug Rabson } 8894a8606fSDoug Rabson #define SETLOW(q, l) { \ 8994a8606fSDoug Rabson union _qcvt tmp; \ 9094a8606fSDoug Rabson tmp.qcvt = (q); \ 9194a8606fSDoug Rabson tmp.val[_QUAD_LOWWORD] = (l); \ 9294a8606fSDoug Rabson (q) = tmp.qcvt; \ 9394a8606fSDoug Rabson } 9494a8606fSDoug Rabson 9558c27bcfSBruce Evans static struct denode * 9611caded3SAlfred Perlstein msdosfs_hashget(dev_t dev, u_long dirclust, u_long diroff); 9711caded3SAlfred Perlstein static void msdosfs_hashins(struct denode *dep); 9811caded3SAlfred Perlstein static void msdosfs_hashrem(struct denode *dep); 9958c27bcfSBruce Evans 100952a6212SJordan K. Hubbard /*ARGSUSED*/ 101952a6212SJordan K. Hubbard int 102952a6212SJordan K. Hubbard msdosfs_init(vfsp) 1038092a8e1SMike Pritchard struct vfsconf *vfsp; 10427a0bc89SDoug Rabson { 10527a0bc89SDoug Rabson dehashtbl = hashinit(desiredvnodes/2, M_MSDOSFSMNT, &dehash); 1066008862bSJohn Baldwin mtx_init(&dehash_mtx, "msdosfs dehash", NULL, MTX_DEF); 107952a6212SJordan K. Hubbard return (0); 10827a0bc89SDoug Rabson } 10927a0bc89SDoug Rabson 110432a8400SBoris Popov int 111432a8400SBoris Popov msdosfs_uninit(vfsp) 112432a8400SBoris Popov struct vfsconf *vfsp; 113432a8400SBoris Popov { 114432a8400SBoris Popov 115432a8400SBoris Popov if (dehashtbl) 116432a8400SBoris Popov free(dehashtbl, M_MSDOSFSMNT); 1171b367556SJason Evans mtx_destroy(&dehash_mtx); 118432a8400SBoris Popov return (0); 119432a8400SBoris Popov } 120432a8400SBoris Popov 12127a0bc89SDoug Rabson static struct denode * 12227a0bc89SDoug Rabson msdosfs_hashget(dev, dirclust, diroff) 12327a0bc89SDoug Rabson dev_t dev; 12427a0bc89SDoug Rabson u_long dirclust; 12527a0bc89SDoug Rabson u_long diroff; 12627a0bc89SDoug Rabson { 127b40ce416SJulian Elischer struct thread *td = curthread; /* XXX */ 12827a0bc89SDoug Rabson struct denode *dep; 129af3f60d5SBruce Evans struct vnode *vp; 13027a0bc89SDoug Rabson 131af3f60d5SBruce Evans loop: 1329ed346baSBosko Milekic mtx_lock(&dehash_mtx); 133952a6212SJordan K. Hubbard for (dep = DEHASH(dev, dirclust, diroff); dep; dep = dep->de_next) { 134af3f60d5SBruce Evans if (dirclust == dep->de_dirclust 135af3f60d5SBruce Evans && diroff == dep->de_diroffset 136af3f60d5SBruce Evans && dev == dep->de_dev 137af3f60d5SBruce Evans && dep->de_refcnt != 0) { 138af3f60d5SBruce Evans vp = DETOV(dep); 1399ed346baSBosko Milekic mtx_lock(&vp->v_interlock); 1409ed346baSBosko Milekic mtx_unlock(&dehash_mtx); 141b40ce416SJulian Elischer if (vget(vp, LK_EXCLUSIVE | LK_INTERLOCK, td)) 142af3f60d5SBruce Evans goto loop; 143af3f60d5SBruce Evans return (dep); 14427a0bc89SDoug Rabson } 14527a0bc89SDoug Rabson } 1469ed346baSBosko Milekic mtx_unlock(&dehash_mtx); 147af3f60d5SBruce Evans return (NULL); 14827a0bc89SDoug Rabson } 14927a0bc89SDoug Rabson 15027a0bc89SDoug Rabson static void 15127a0bc89SDoug Rabson msdosfs_hashins(dep) 15227a0bc89SDoug Rabson struct denode *dep; 15327a0bc89SDoug Rabson { 15427a0bc89SDoug Rabson struct denode **depp, *deq; 15527a0bc89SDoug Rabson 1569ed346baSBosko Milekic mtx_lock(&dehash_mtx); 157952a6212SJordan K. Hubbard depp = &DEHASH(dep->de_dev, dep->de_dirclust, dep->de_diroffset); 158c3c6d51eSPoul-Henning Kamp deq = *depp; 159c3c6d51eSPoul-Henning Kamp if (deq) 16027a0bc89SDoug Rabson deq->de_prev = &dep->de_next; 16127a0bc89SDoug Rabson dep->de_next = deq; 16227a0bc89SDoug Rabson dep->de_prev = depp; 16327a0bc89SDoug Rabson *depp = dep; 1649ed346baSBosko Milekic mtx_unlock(&dehash_mtx); 16527a0bc89SDoug Rabson } 16627a0bc89SDoug Rabson 16727a0bc89SDoug Rabson static void 16827a0bc89SDoug Rabson msdosfs_hashrem(dep) 16927a0bc89SDoug Rabson struct denode *dep; 17027a0bc89SDoug Rabson { 17127a0bc89SDoug Rabson struct denode *deq; 172af3f60d5SBruce Evans 1739ed346baSBosko Milekic mtx_lock(&dehash_mtx); 174c3c6d51eSPoul-Henning Kamp deq = dep->de_next; 175c3c6d51eSPoul-Henning Kamp if (deq) 17627a0bc89SDoug Rabson deq->de_prev = dep->de_prev; 17727a0bc89SDoug Rabson *dep->de_prev = deq; 17827a0bc89SDoug Rabson #ifdef DIAGNOSTIC 17927a0bc89SDoug Rabson dep->de_next = NULL; 18027a0bc89SDoug Rabson dep->de_prev = NULL; 18127a0bc89SDoug Rabson #endif 1829ed346baSBosko Milekic mtx_unlock(&dehash_mtx); 18327a0bc89SDoug Rabson } 18427a0bc89SDoug Rabson 18527a0bc89SDoug Rabson /* 18627a0bc89SDoug Rabson * If deget() succeeds it returns with the gotten denode locked(). 18727a0bc89SDoug Rabson * 18827a0bc89SDoug Rabson * pmp - address of msdosfsmount structure of the filesystem containing 18927a0bc89SDoug Rabson * the denode of interest. The pm_dev field and the address of 19027a0bc89SDoug Rabson * the msdosfsmount structure are used. 19127a0bc89SDoug Rabson * dirclust - which cluster bp contains, if dirclust is 0 (root directory) 19227a0bc89SDoug Rabson * diroffset is relative to the beginning of the root directory, 19327a0bc89SDoug Rabson * otherwise it is cluster relative. 19427a0bc89SDoug Rabson * diroffset - offset past begin of cluster of denode we want 19527a0bc89SDoug Rabson * depp - returns the address of the gotten denode. 19627a0bc89SDoug Rabson */ 19727a0bc89SDoug Rabson int 198952a6212SJordan K. Hubbard deget(pmp, dirclust, diroffset, depp) 19927a0bc89SDoug Rabson struct msdosfsmount *pmp; /* so we know the maj/min number */ 20027a0bc89SDoug Rabson u_long dirclust; /* cluster this dir entry came from */ 20127a0bc89SDoug Rabson u_long diroffset; /* index of entry within the cluster */ 20227a0bc89SDoug Rabson struct denode **depp; /* returns the addr of the gotten denode */ 20327a0bc89SDoug Rabson { 20427a0bc89SDoug Rabson int error; 20527a0bc89SDoug Rabson dev_t dev = pmp->pm_dev; 20627a0bc89SDoug Rabson struct mount *mntp = pmp->pm_mountp; 207952a6212SJordan K. Hubbard struct direntry *direntptr; 20827a0bc89SDoug Rabson struct denode *ldep; 20927a0bc89SDoug Rabson struct vnode *nvp; 21027a0bc89SDoug Rabson struct buf *bp; 211b40ce416SJulian Elischer struct thread *td = curthread; /* XXX */ 21200af9731SPoul-Henning Kamp struct timeval tv; 21327a0bc89SDoug Rabson 21427a0bc89SDoug Rabson #ifdef MSDOSFS_DEBUG 215952a6212SJordan K. Hubbard printf("deget(pmp %p, dirclust %lu, diroffset %lx, depp %p)\n", 216952a6212SJordan K. Hubbard pmp, dirclust, diroffset, depp); 21727a0bc89SDoug Rabson #endif 21827a0bc89SDoug Rabson 21927a0bc89SDoug Rabson /* 220952a6212SJordan K. Hubbard * On FAT32 filesystems, root is a (more or less) normal 221952a6212SJordan K. Hubbard * directory 22227a0bc89SDoug Rabson */ 223952a6212SJordan K. Hubbard if (FAT32(pmp) && dirclust == MSDOSFSROOT) 224952a6212SJordan K. Hubbard dirclust = pmp->pm_rootdirblk; 22527a0bc89SDoug Rabson 22627a0bc89SDoug Rabson /* 22727a0bc89SDoug Rabson * See if the denode is in the denode cache. Use the location of 22827a0bc89SDoug Rabson * the directory entry to compute the hash value. For subdir use 229952a6212SJordan K. Hubbard * address of "." entry. For root dir (if not FAT32) use cluster 230952a6212SJordan K. Hubbard * MSDOSFSROOT, offset MSDOSFSROOT_OFS 23127a0bc89SDoug Rabson * 23227a0bc89SDoug Rabson * NOTE: The check for de_refcnt > 0 below insures the denode being 23327a0bc89SDoug Rabson * examined does not represent an unlinked but still open file. 23427a0bc89SDoug Rabson * These files are not to be accessible even when the directory 23527a0bc89SDoug Rabson * entry that represented the file happens to be reused while the 23627a0bc89SDoug Rabson * deleted file is still open. 23727a0bc89SDoug Rabson */ 238c3c6d51eSPoul-Henning Kamp ldep = msdosfs_hashget(dev, dirclust, diroffset); 239c3c6d51eSPoul-Henning Kamp if (ldep) { 24027a0bc89SDoug Rabson *depp = ldep; 241952a6212SJordan K. Hubbard return (0); 24227a0bc89SDoug Rabson } 24327a0bc89SDoug Rabson 2442f9bae59SDavid Greenman /* 2452f9bae59SDavid Greenman * Do the MALLOC before the getnewvnode since doing so afterward 2462f9bae59SDavid Greenman * might cause a bogus v_data pointer to get dereferenced 2472f9bae59SDavid Greenman * elsewhere if MALLOC should block. 2482f9bae59SDavid Greenman */ 2492f9bae59SDavid Greenman MALLOC(ldep, struct denode *, sizeof(struct denode), M_MSDOSFSNODE, M_WAITOK); 25027a0bc89SDoug Rabson 25127a0bc89SDoug Rabson /* 25227a0bc89SDoug Rabson * Directory entry was not in cache, have to create a vnode and 25327a0bc89SDoug Rabson * copy it from the passed disk buffer. 25427a0bc89SDoug Rabson */ 25527a0bc89SDoug Rabson /* getnewvnode() does a VREF() on the vnode */ 256c3c6d51eSPoul-Henning Kamp error = getnewvnode(VT_MSDOSFS, mntp, msdosfs_vnodeop_p, &nvp); 257c3c6d51eSPoul-Henning Kamp if (error) { 2582f9bae59SDavid Greenman *depp = NULL; 2592f9bae59SDavid Greenman FREE(ldep, M_MSDOSFSNODE); 26027a0bc89SDoug Rabson return error; 26127a0bc89SDoug Rabson } 26227a0bc89SDoug Rabson bzero((caddr_t)ldep, sizeof *ldep); 26323b59018SMatthew Dillon lockinit(&nvp->v_lock, PINOD, "denode", VLKTIMEOUT, 0); 264e7b1ac75SBoris Popov nvp->v_vnlock = &nvp->v_lock; 26527a0bc89SDoug Rabson nvp->v_data = ldep; 26627a0bc89SDoug Rabson ldep->de_vnode = nvp; 26727a0bc89SDoug Rabson ldep->de_flag = 0; 26827a0bc89SDoug Rabson ldep->de_devvp = 0; 26927a0bc89SDoug Rabson ldep->de_dev = dev; 27027a0bc89SDoug Rabson ldep->de_dirclust = dirclust; 27127a0bc89SDoug Rabson ldep->de_diroffset = diroffset; 27227a0bc89SDoug Rabson fc_purge(ldep, 0); /* init the fat cache for this denode */ 27327a0bc89SDoug Rabson 27427a0bc89SDoug Rabson /* 275af3f60d5SBruce Evans * Lock the denode so that it can't be accessed until we've read 276af3f60d5SBruce Evans * it in and have done what we need to it. Do this here instead 277af3f60d5SBruce Evans * of at the start of msdosfs_hashins() so that reinsert() can 278af3f60d5SBruce Evans * call msdosfs_hashins() with a locked denode. 27927a0bc89SDoug Rabson */ 280b40ce416SJulian Elischer if (VOP_LOCK(nvp, LK_EXCLUSIVE, td) != 0) 281af3f60d5SBruce Evans panic("deget: unexpected lock failure"); 282af3f60d5SBruce Evans 283af3f60d5SBruce Evans /* 284af3f60d5SBruce Evans * Insert the denode into the hash queue. 285af3f60d5SBruce Evans */ 28627a0bc89SDoug Rabson msdosfs_hashins(ldep); 28727a0bc89SDoug Rabson 288952a6212SJordan K. Hubbard ldep->de_pmp = pmp; 289952a6212SJordan K. Hubbard ldep->de_refcnt = 1; 29027a0bc89SDoug Rabson /* 29127a0bc89SDoug Rabson * Copy the directory entry into the denode area of the vnode. 29227a0bc89SDoug Rabson */ 293952a6212SJordan K. Hubbard if ((dirclust == MSDOSFSROOT 294952a6212SJordan K. Hubbard || (FAT32(pmp) && dirclust == pmp->pm_rootdirblk)) 295952a6212SJordan K. Hubbard && diroffset == MSDOSFSROOT_OFS) { 29627a0bc89SDoug Rabson /* 29727a0bc89SDoug Rabson * Directory entry for the root directory. There isn't one, 29827a0bc89SDoug Rabson * so we manufacture one. We should probably rummage 29927a0bc89SDoug Rabson * through the root directory and find a label entry (if it 30027a0bc89SDoug Rabson * exists), and then use the time and date from that entry 30127a0bc89SDoug Rabson * as the time and date for the root denode. 30227a0bc89SDoug Rabson */ 303e6e370a7SJeff Roberson nvp->v_vflag |= VV_ROOT; /* should be further down XXX */ 304952a6212SJordan K. Hubbard 30527a0bc89SDoug Rabson ldep->de_Attributes = ATTR_DIRECTORY; 306bad3d41dSDmitrij Tejblum ldep->de_LowerCase = 0; 307952a6212SJordan K. Hubbard if (FAT32(pmp)) 308952a6212SJordan K. Hubbard ldep->de_StartCluster = pmp->pm_rootdirblk; 309952a6212SJordan K. Hubbard /* de_FileSize will be filled in further down */ 310952a6212SJordan K. Hubbard else { 31127a0bc89SDoug Rabson ldep->de_StartCluster = MSDOSFSROOT; 31201f6cfbaSYoshihiro Takahashi ldep->de_FileSize = pmp->pm_rootdirsize * DEV_BSIZE; 313952a6212SJordan K. Hubbard } 31427a0bc89SDoug Rabson /* 31527a0bc89SDoug Rabson * fill in time and date so that dos2unixtime() doesn't 31627a0bc89SDoug Rabson * spit up when called from msdosfs_getattr() with root 31727a0bc89SDoug Rabson * denode 31827a0bc89SDoug Rabson */ 319952a6212SJordan K. Hubbard ldep->de_CHun = 0; 320952a6212SJordan K. Hubbard ldep->de_CTime = 0x0000; /* 00:00:00 */ 321952a6212SJordan K. Hubbard ldep->de_CDate = (0 << DD_YEAR_SHIFT) | (1 << DD_MONTH_SHIFT) 32227a0bc89SDoug Rabson | (1 << DD_DAY_SHIFT); 32327a0bc89SDoug Rabson /* Jan 1, 1980 */ 324952a6212SJordan K. Hubbard ldep->de_ADate = ldep->de_CDate; 325952a6212SJordan K. Hubbard ldep->de_MTime = ldep->de_CTime; 326952a6212SJordan K. Hubbard ldep->de_MDate = ldep->de_CDate; 32727a0bc89SDoug Rabson /* leave the other fields as garbage */ 32827a0bc89SDoug Rabson } else { 329952a6212SJordan K. Hubbard error = readep(pmp, dirclust, diroffset, &bp, &direntptr); 3305097a20dSBruce Evans if (error) { 3315097a20dSBruce Evans /* 3325097a20dSBruce Evans * The denode does not contain anything useful, so 3335097a20dSBruce Evans * it would be wrong to leave it on its hash chain. 3345097a20dSBruce Evans * Arrange for vput() to just forget about it. 3355097a20dSBruce Evans */ 3365097a20dSBruce Evans ldep->de_Name[0] = SLOT_DELETED; 3375097a20dSBruce Evans 3385097a20dSBruce Evans vput(nvp); 3395097a20dSBruce Evans *depp = NULL; 340952a6212SJordan K. Hubbard return (error); 3415097a20dSBruce Evans } 34227a0bc89SDoug Rabson DE_INTERNALIZE(ldep, direntptr); 34327a0bc89SDoug Rabson brelse(bp); 34427a0bc89SDoug Rabson } 34527a0bc89SDoug Rabson 34627a0bc89SDoug Rabson /* 34727a0bc89SDoug Rabson * Fill in a few fields of the vnode and finish filling in the 34827a0bc89SDoug Rabson * denode. Then return the address of the found denode. 34927a0bc89SDoug Rabson */ 35027a0bc89SDoug Rabson if (ldep->de_Attributes & ATTR_DIRECTORY) { 35127a0bc89SDoug Rabson /* 35227a0bc89SDoug Rabson * Since DOS directory entries that describe directories 35327a0bc89SDoug Rabson * have 0 in the filesize field, we take this opportunity 35427a0bc89SDoug Rabson * to find out the length of the directory and plug it into 35527a0bc89SDoug Rabson * the denode structure. 35627a0bc89SDoug Rabson */ 35727a0bc89SDoug Rabson u_long size; 35827a0bc89SDoug Rabson 35927a0bc89SDoug Rabson nvp->v_type = VDIR; 360952a6212SJordan K. Hubbard if (ldep->de_StartCluster != MSDOSFSROOT) { 361952a6212SJordan K. Hubbard error = pcbmap(ldep, 0xffff, 0, &size, 0); 36227a0bc89SDoug Rabson if (error == E2BIG) { 363952a6212SJordan K. Hubbard ldep->de_FileSize = de_cn2off(pmp, size); 36427a0bc89SDoug Rabson error = 0; 36527a0bc89SDoug Rabson } else 36627a0bc89SDoug Rabson printf("deget(): pcbmap returned %d\n", error); 36727a0bc89SDoug Rabson } 36827a0bc89SDoug Rabson } else 36927a0bc89SDoug Rabson nvp->v_type = VREG; 370c21410e1SPoul-Henning Kamp getmicrouptime(&tv); 37100af9731SPoul-Henning Kamp SETHIGH(ldep->de_modrev, tv.tv_sec); 37200af9731SPoul-Henning Kamp SETLOW(ldep->de_modrev, tv.tv_usec * 4294); 3735097a20dSBruce Evans ldep->de_devvp = pmp->pm_devvp; 37427a0bc89SDoug Rabson VREF(ldep->de_devvp); 37527a0bc89SDoug Rabson *depp = ldep; 376952a6212SJordan K. Hubbard return (0); 37727a0bc89SDoug Rabson } 37827a0bc89SDoug Rabson 37927a0bc89SDoug Rabson int 380952a6212SJordan K. Hubbard deupdat(dep, waitfor) 38127a0bc89SDoug Rabson struct denode *dep; 38227a0bc89SDoug Rabson int waitfor; 38327a0bc89SDoug Rabson { 38427a0bc89SDoug Rabson int error; 38527a0bc89SDoug Rabson struct buf *bp; 38627a0bc89SDoug Rabson struct direntry *dirp; 387952a6212SJordan K. Hubbard struct timespec ts; 38827a0bc89SDoug Rabson 389952a6212SJordan K. Hubbard if (DETOV(dep)->v_mount->mnt_flag & MNT_RDONLY) 390952a6212SJordan K. Hubbard return (0); 391a0502b19SPoul-Henning Kamp getnanotime(&ts); 392952a6212SJordan K. Hubbard DETIMES(dep, &ts, &ts, &ts); 393952a6212SJordan K. Hubbard if ((dep->de_flag & DE_MODIFIED) == 0) 394952a6212SJordan K. Hubbard return (0); 395952a6212SJordan K. Hubbard dep->de_flag &= ~DE_MODIFIED; 396952a6212SJordan K. Hubbard if (dep->de_Attributes & ATTR_DIRECTORY) 397952a6212SJordan K. Hubbard return (0); 398952a6212SJordan K. Hubbard if (dep->de_refcnt <= 0) 399952a6212SJordan K. Hubbard return (0); 400c3c6d51eSPoul-Henning Kamp error = readde(dep, &bp, &dirp); 401c3c6d51eSPoul-Henning Kamp if (error) 402952a6212SJordan K. Hubbard return (error); 40327a0bc89SDoug Rabson DE_EXTERNALIZE(dirp, dep); 40427a0bc89SDoug Rabson if (waitfor) 405952a6212SJordan K. Hubbard return (bwrite(bp)); 406952a6212SJordan K. Hubbard else { 40727a0bc89SDoug Rabson bdwrite(bp); 408952a6212SJordan K. Hubbard return (0); 409952a6212SJordan K. Hubbard } 41027a0bc89SDoug Rabson } 41127a0bc89SDoug Rabson 41227a0bc89SDoug Rabson /* 41327a0bc89SDoug Rabson * Truncate the file described by dep to the length specified by length. 41427a0bc89SDoug Rabson */ 41527a0bc89SDoug Rabson int 416b40ce416SJulian Elischer detrunc(dep, length, flags, cred, td) 41727a0bc89SDoug Rabson struct denode *dep; 41827a0bc89SDoug Rabson u_long length; 41927a0bc89SDoug Rabson int flags; 42027a0bc89SDoug Rabson struct ucred *cred; 421b40ce416SJulian Elischer struct thread *td; 42227a0bc89SDoug Rabson { 42327a0bc89SDoug Rabson int error; 42427a0bc89SDoug Rabson int allerror; 42527a0bc89SDoug Rabson u_long eofentry; 42627a0bc89SDoug Rabson u_long chaintofree; 42727a0bc89SDoug Rabson daddr_t bn; 42827a0bc89SDoug Rabson int boff; 42927a0bc89SDoug Rabson int isadir = dep->de_Attributes & ATTR_DIRECTORY; 43027a0bc89SDoug Rabson struct buf *bp; 43127a0bc89SDoug Rabson struct msdosfsmount *pmp = dep->de_pmp; 43227a0bc89SDoug Rabson 43327a0bc89SDoug Rabson #ifdef MSDOSFS_DEBUG 434952a6212SJordan K. Hubbard printf("detrunc(): file %s, length %lu, flags %x\n", dep->de_Name, length, flags); 43527a0bc89SDoug Rabson #endif 43627a0bc89SDoug Rabson 43727a0bc89SDoug Rabson /* 43827a0bc89SDoug Rabson * Disallow attempts to truncate the root directory since it is of 43927a0bc89SDoug Rabson * fixed size. That's just the way dos filesystems are. We use 44027a0bc89SDoug Rabson * the VROOT bit in the vnode because checking for the directory 44127a0bc89SDoug Rabson * bit and a startcluster of 0 in the denode is not adequate to 44227a0bc89SDoug Rabson * recognize the root directory at this point in a file or 44327a0bc89SDoug Rabson * directory's life. 44427a0bc89SDoug Rabson */ 445e6e370a7SJeff Roberson if ((DETOV(dep)->v_vflag & VV_ROOT) && !FAT32(pmp)) { 446952a6212SJordan K. Hubbard printf("detrunc(): can't truncate root directory, clust %ld, offset %ld\n", 44727a0bc89SDoug Rabson dep->de_dirclust, dep->de_diroffset); 448952a6212SJordan K. Hubbard return (EINVAL); 44927a0bc89SDoug Rabson } 45027a0bc89SDoug Rabson 45127a0bc89SDoug Rabson 452bd7e5f99SJohn Dyson if (dep->de_FileSize < length) { 453bd7e5f99SJohn Dyson vnode_pager_setsize(DETOV(dep), length); 45427a0bc89SDoug Rabson return deextend(dep, length, cred); 455bd7e5f99SJohn Dyson } 45627a0bc89SDoug Rabson 45727a0bc89SDoug Rabson /* 45827a0bc89SDoug Rabson * If the desired length is 0 then remember the starting cluster of 45927a0bc89SDoug Rabson * the file and set the StartCluster field in the directory entry 46027a0bc89SDoug Rabson * to 0. If the desired length is not zero, then get the number of 46127a0bc89SDoug Rabson * the last cluster in the shortened file. Then get the number of 46227a0bc89SDoug Rabson * the first cluster in the part of the file that is to be freed. 46327a0bc89SDoug Rabson * Then set the next cluster pointer in the last cluster of the 46427a0bc89SDoug Rabson * file to CLUST_EOFE. 46527a0bc89SDoug Rabson */ 46627a0bc89SDoug Rabson if (length == 0) { 46727a0bc89SDoug Rabson chaintofree = dep->de_StartCluster; 46827a0bc89SDoug Rabson dep->de_StartCluster = 0; 46927a0bc89SDoug Rabson eofentry = ~0; 47027a0bc89SDoug Rabson } else { 471952a6212SJordan K. Hubbard error = pcbmap(dep, de_clcount(pmp, length) - 1, 0, 472952a6212SJordan K. Hubbard &eofentry, 0); 473c3c6d51eSPoul-Henning Kamp if (error) { 47427a0bc89SDoug Rabson #ifdef MSDOSFS_DEBUG 47527a0bc89SDoug Rabson printf("detrunc(): pcbmap fails %d\n", error); 47627a0bc89SDoug Rabson #endif 477952a6212SJordan K. Hubbard return (error); 47827a0bc89SDoug Rabson } 47927a0bc89SDoug Rabson } 48027a0bc89SDoug Rabson 481952a6212SJordan K. Hubbard fc_purge(dep, de_clcount(pmp, length)); 48227a0bc89SDoug Rabson 48327a0bc89SDoug Rabson /* 48427a0bc89SDoug Rabson * If the new length is not a multiple of the cluster size then we 48527a0bc89SDoug Rabson * must zero the tail end of the new last cluster in case it 48627a0bc89SDoug Rabson * becomes part of the file again because of a seek. 48727a0bc89SDoug Rabson */ 48827a0bc89SDoug Rabson if ((boff = length & pmp->pm_crbomask) != 0) { 48927a0bc89SDoug Rabson if (isadir) { 49027a0bc89SDoug Rabson bn = cntobn(pmp, eofentry); 49127a0bc89SDoug Rabson error = bread(pmp->pm_devvp, bn, pmp->pm_bpcluster, 49227a0bc89SDoug Rabson NOCRED, &bp); 49327a0bc89SDoug Rabson } else { 49427a0bc89SDoug Rabson bn = de_blk(pmp, length); 49527a0bc89SDoug Rabson error = bread(DETOV(dep), bn, pmp->pm_bpcluster, 49627a0bc89SDoug Rabson NOCRED, &bp); 49727a0bc89SDoug Rabson } 49827a0bc89SDoug Rabson if (error) { 499952a6212SJordan K. Hubbard brelse(bp); 50027a0bc89SDoug Rabson #ifdef MSDOSFS_DEBUG 50127a0bc89SDoug Rabson printf("detrunc(): bread fails %d\n", error); 50227a0bc89SDoug Rabson #endif 503952a6212SJordan K. Hubbard return (error); 50427a0bc89SDoug Rabson } 50527a0bc89SDoug Rabson /* 50627a0bc89SDoug Rabson * is this the right place for it? 50727a0bc89SDoug Rabson */ 50827a0bc89SDoug Rabson bzero(bp->b_data + boff, pmp->pm_bpcluster - boff); 50927a0bc89SDoug Rabson if (flags & IO_SYNC) 51027a0bc89SDoug Rabson bwrite(bp); 51127a0bc89SDoug Rabson else 51227a0bc89SDoug Rabson bdwrite(bp); 51327a0bc89SDoug Rabson } 51427a0bc89SDoug Rabson 51527a0bc89SDoug Rabson /* 51627a0bc89SDoug Rabson * Write out the updated directory entry. Even if the update fails 51727a0bc89SDoug Rabson * we free the trailing clusters. 51827a0bc89SDoug Rabson */ 51927a0bc89SDoug Rabson dep->de_FileSize = length; 520952a6212SJordan K. Hubbard if (!isadir) 521952a6212SJordan K. Hubbard dep->de_flag |= DE_UPDATE|DE_MODIFIED; 522b40ce416SJulian Elischer allerror = vtruncbuf(DETOV(dep), cred, td, length, pmp->pm_bpcluster); 52344fdad99SPeter Wemm #ifdef MSDOSFS_DEBUG 52444fdad99SPeter Wemm if (allerror) 52544fdad99SPeter Wemm printf("detrunc(): vtruncbuf error %d\n", allerror); 52644fdad99SPeter Wemm #endif 52744fdad99SPeter Wemm error = deupdat(dep, 1); 52844fdad99SPeter Wemm if (error && (allerror == 0)) 52944fdad99SPeter Wemm allerror = error; 53027a0bc89SDoug Rabson #ifdef MSDOSFS_DEBUG 531952a6212SJordan K. Hubbard printf("detrunc(): allerror %d, eofentry %lu\n", 53227a0bc89SDoug Rabson allerror, eofentry); 53327a0bc89SDoug Rabson #endif 53427a0bc89SDoug Rabson 53527a0bc89SDoug Rabson /* 53627a0bc89SDoug Rabson * If we need to break the cluster chain for the file then do it 53727a0bc89SDoug Rabson * now. 53827a0bc89SDoug Rabson */ 53927a0bc89SDoug Rabson if (eofentry != ~0) { 54027a0bc89SDoug Rabson error = fatentry(FAT_GET_AND_SET, pmp, eofentry, 54127a0bc89SDoug Rabson &chaintofree, CLUST_EOFE); 54227a0bc89SDoug Rabson if (error) { 54327a0bc89SDoug Rabson #ifdef MSDOSFS_DEBUG 54427a0bc89SDoug Rabson printf("detrunc(): fatentry errors %d\n", error); 54527a0bc89SDoug Rabson #endif 546952a6212SJordan K. Hubbard return (error); 54727a0bc89SDoug Rabson } 548952a6212SJordan K. Hubbard fc_setcache(dep, FC_LASTFC, de_cluster(pmp, length - 1), 54927a0bc89SDoug Rabson eofentry); 55027a0bc89SDoug Rabson } 55127a0bc89SDoug Rabson 55227a0bc89SDoug Rabson /* 55327a0bc89SDoug Rabson * Now free the clusters removed from the file because of the 55427a0bc89SDoug Rabson * truncation. 55527a0bc89SDoug Rabson */ 556952a6212SJordan K. Hubbard if (chaintofree != 0 && !MSDOSFSEOF(pmp, chaintofree)) 55727a0bc89SDoug Rabson freeclusterchain(pmp, chaintofree); 55827a0bc89SDoug Rabson 559952a6212SJordan K. Hubbard return (allerror); 56027a0bc89SDoug Rabson } 56127a0bc89SDoug Rabson 56227a0bc89SDoug Rabson /* 56327a0bc89SDoug Rabson * Extend the file described by dep to length specified by length. 56427a0bc89SDoug Rabson */ 56527a0bc89SDoug Rabson int 56627a0bc89SDoug Rabson deextend(dep, length, cred) 56727a0bc89SDoug Rabson struct denode *dep; 568952a6212SJordan K. Hubbard u_long length; 56927a0bc89SDoug Rabson struct ucred *cred; 57027a0bc89SDoug Rabson { 57127a0bc89SDoug Rabson struct msdosfsmount *pmp = dep->de_pmp; 57227a0bc89SDoug Rabson u_long count; 57327a0bc89SDoug Rabson int error; 57427a0bc89SDoug Rabson 57527a0bc89SDoug Rabson /* 57627a0bc89SDoug Rabson * The root of a DOS filesystem cannot be extended. 57727a0bc89SDoug Rabson */ 578e6e370a7SJeff Roberson if ((DETOV(dep)->v_vflag & VV_ROOT) && !FAT32(pmp)) 579952a6212SJordan K. Hubbard return (EINVAL); 58027a0bc89SDoug Rabson 58127a0bc89SDoug Rabson /* 582952a6212SJordan K. Hubbard * Directories cannot be extended. 58327a0bc89SDoug Rabson */ 584952a6212SJordan K. Hubbard if (dep->de_Attributes & ATTR_DIRECTORY) 585952a6212SJordan K. Hubbard return (EISDIR); 58627a0bc89SDoug Rabson 58727a0bc89SDoug Rabson if (length <= dep->de_FileSize) 58827a0bc89SDoug Rabson panic("deextend: file too large"); 58927a0bc89SDoug Rabson 59027a0bc89SDoug Rabson /* 59127a0bc89SDoug Rabson * Compute the number of clusters to allocate. 59227a0bc89SDoug Rabson */ 59327a0bc89SDoug Rabson count = de_clcount(pmp, length) - de_clcount(pmp, dep->de_FileSize); 59427a0bc89SDoug Rabson if (count > 0) { 59527a0bc89SDoug Rabson if (count > pmp->pm_freeclustercount) 596952a6212SJordan K. Hubbard return (ENOSPC); 597c3c6d51eSPoul-Henning Kamp error = extendfile(dep, count, NULL, NULL, DE_CLEAR); 598c3c6d51eSPoul-Henning Kamp if (error) { 59927a0bc89SDoug Rabson /* truncate the added clusters away again */ 60027a0bc89SDoug Rabson (void) detrunc(dep, dep->de_FileSize, 0, cred, NULL); 601952a6212SJordan K. Hubbard return (error); 60227a0bc89SDoug Rabson } 60327a0bc89SDoug Rabson } 60427a0bc89SDoug Rabson dep->de_FileSize = length; 605952a6212SJordan K. Hubbard dep->de_flag |= DE_UPDATE|DE_MODIFIED; 606952a6212SJordan K. Hubbard return (deupdat(dep, 1)); 60727a0bc89SDoug Rabson } 60827a0bc89SDoug Rabson 60927a0bc89SDoug Rabson /* 61027a0bc89SDoug Rabson * Move a denode to its correct hash queue after the file it represents has 61127a0bc89SDoug Rabson * been moved to a new directory. 61227a0bc89SDoug Rabson */ 613952a6212SJordan K. Hubbard void 614952a6212SJordan K. Hubbard reinsert(dep) 61527a0bc89SDoug Rabson struct denode *dep; 61627a0bc89SDoug Rabson { 61727a0bc89SDoug Rabson /* 61827a0bc89SDoug Rabson * Fix up the denode cache. If the denode is for a directory, 61927a0bc89SDoug Rabson * there is nothing to do since the hash is based on the starting 62027a0bc89SDoug Rabson * cluster of the directory file and that hasn't changed. If for a 62127a0bc89SDoug Rabson * file the hash is based on the location of the directory entry, 62227a0bc89SDoug Rabson * so we must remove it from the cache and re-enter it with the 62327a0bc89SDoug Rabson * hash based on the new location of the directory entry. 62427a0bc89SDoug Rabson */ 625952a6212SJordan K. Hubbard if (dep->de_Attributes & ATTR_DIRECTORY) 626952a6212SJordan K. Hubbard return; 62727a0bc89SDoug Rabson msdosfs_hashrem(dep); 62827a0bc89SDoug Rabson msdosfs_hashins(dep); 62927a0bc89SDoug Rabson } 63027a0bc89SDoug Rabson 63127a0bc89SDoug Rabson int 63227a0bc89SDoug Rabson msdosfs_reclaim(ap) 63327a0bc89SDoug Rabson struct vop_reclaim_args /* { 63427a0bc89SDoug Rabson struct vnode *a_vp; 63527a0bc89SDoug Rabson } */ *ap; 63627a0bc89SDoug Rabson { 63727a0bc89SDoug Rabson struct vnode *vp = ap->a_vp; 63827a0bc89SDoug Rabson struct denode *dep = VTODE(vp); 63927a0bc89SDoug Rabson 64027a0bc89SDoug Rabson #ifdef MSDOSFS_DEBUG 641f0707215SPoul-Henning Kamp printf("msdosfs_reclaim(): dep %p, file %s, refcnt %ld\n", 64227a0bc89SDoug Rabson dep, dep->de_Name, dep->de_refcnt); 64327a0bc89SDoug Rabson #endif 64427a0bc89SDoug Rabson 64527a0bc89SDoug Rabson if (prtactive && vp->v_usecount != 0) 64627a0bc89SDoug Rabson vprint("msdosfs_reclaim(): pushing active", vp); 64727a0bc89SDoug Rabson /* 648952a6212SJordan K. Hubbard * Remove the denode from its hash chain. 64927a0bc89SDoug Rabson */ 65027a0bc89SDoug Rabson msdosfs_hashrem(dep); 65127a0bc89SDoug Rabson /* 652952a6212SJordan K. Hubbard * Purge old data structures associated with the denode. 65327a0bc89SDoug Rabson */ 654952a6212SJordan K. Hubbard cache_purge(vp); 65527a0bc89SDoug Rabson if (dep->de_devvp) { 65627a0bc89SDoug Rabson vrele(dep->de_devvp); 65727a0bc89SDoug Rabson dep->de_devvp = 0; 65827a0bc89SDoug Rabson } 659952a6212SJordan K. Hubbard #if 0 /* XXX */ 66027a0bc89SDoug Rabson dep->de_flag = 0; 661952a6212SJordan K. Hubbard #endif 662e7b1ac75SBoris Popov lockdestroy(&vp->v_lock); 66327a0bc89SDoug Rabson FREE(dep, M_MSDOSFSNODE); 66427a0bc89SDoug Rabson vp->v_data = NULL; 66527a0bc89SDoug Rabson 666952a6212SJordan K. Hubbard return (0); 66727a0bc89SDoug Rabson } 66827a0bc89SDoug Rabson 66927a0bc89SDoug Rabson int 67027a0bc89SDoug Rabson msdosfs_inactive(ap) 67127a0bc89SDoug Rabson struct vop_inactive_args /* { 67227a0bc89SDoug Rabson struct vnode *a_vp; 673b40ce416SJulian Elischer struct thread *a_td; 67427a0bc89SDoug Rabson } */ *ap; 67527a0bc89SDoug Rabson { 67627a0bc89SDoug Rabson struct vnode *vp = ap->a_vp; 67727a0bc89SDoug Rabson struct denode *dep = VTODE(vp); 678b40ce416SJulian Elischer struct thread *td = ap->a_td; 67927a0bc89SDoug Rabson int error = 0; 68027a0bc89SDoug Rabson 68127a0bc89SDoug Rabson #ifdef MSDOSFS_DEBUG 682f0707215SPoul-Henning Kamp printf("msdosfs_inactive(): dep %p, de_Name[0] %x\n", dep, dep->de_Name[0]); 68327a0bc89SDoug Rabson #endif 68427a0bc89SDoug Rabson 68527a0bc89SDoug Rabson if (prtactive && vp->v_usecount != 0) 68627a0bc89SDoug Rabson vprint("msdosfs_inactive(): pushing active", vp); 68727a0bc89SDoug Rabson 68827a0bc89SDoug Rabson /* 689952a6212SJordan K. Hubbard * Ignore denodes related to stale file handles. 69027a0bc89SDoug Rabson */ 691af3f60d5SBruce Evans if (dep->de_Name[0] == SLOT_DELETED) 692af3f60d5SBruce Evans goto out; 69327a0bc89SDoug Rabson 69427a0bc89SDoug Rabson /* 69527a0bc89SDoug Rabson * If the file has been deleted and it is on a read/write 69627a0bc89SDoug Rabson * filesystem, then truncate the file, and mark the directory slot 69727a0bc89SDoug Rabson * as empty. (This may not be necessary for the dos filesystem.) 69827a0bc89SDoug Rabson */ 69927a0bc89SDoug Rabson #ifdef MSDOSFS_DEBUG 700f0707215SPoul-Henning Kamp printf("msdosfs_inactive(): dep %p, refcnt %ld, mntflag %x, MNT_RDONLY %x\n", 70127a0bc89SDoug Rabson dep, dep->de_refcnt, vp->v_mount->mnt_flag, MNT_RDONLY); 70227a0bc89SDoug Rabson #endif 70327a0bc89SDoug Rabson if (dep->de_refcnt <= 0 && (vp->v_mount->mnt_flag & MNT_RDONLY) == 0) { 704b40ce416SJulian Elischer error = detrunc(dep, (u_long) 0, 0, NOCRED, td); 70527a0bc89SDoug Rabson dep->de_flag |= DE_UPDATE; 70627a0bc89SDoug Rabson dep->de_Name[0] = SLOT_DELETED; 70727a0bc89SDoug Rabson } 708952a6212SJordan K. Hubbard deupdat(dep, 0); 709952a6212SJordan K. Hubbard 710af3f60d5SBruce Evans out: 711b40ce416SJulian Elischer VOP_UNLOCK(vp, 0, td); 71227a0bc89SDoug Rabson /* 713952a6212SJordan K. Hubbard * If we are done with the denode, reclaim it 714952a6212SJordan K. Hubbard * so that it can be reused immediately. 71527a0bc89SDoug Rabson */ 71627a0bc89SDoug Rabson #ifdef MSDOSFS_DEBUG 71727a0bc89SDoug Rabson printf("msdosfs_inactive(): v_usecount %d, de_Name[0] %x\n", vp->v_usecount, 71827a0bc89SDoug Rabson dep->de_Name[0]); 71927a0bc89SDoug Rabson #endif 720af3f60d5SBruce Evans if (dep->de_Name[0] == SLOT_DELETED) 721b40ce416SJulian Elischer vrecycle(vp, NULL, td); 722952a6212SJordan K. Hubbard return (error); 72327a0bc89SDoug Rabson } 724