xref: /freebsd/sys/dev/nvd/nvd.c (revision ec84ecbba0ef8e3314ea5ec51ff8dcd6c0761bd9)
1bb0ec6b3SJim Harris /*-
2bb0ec6b3SJim Harris  * Copyright (C) 2012 Intel Corporation
3bb0ec6b3SJim Harris  * All rights reserved.
4bb0ec6b3SJim Harris  *
5bb0ec6b3SJim Harris  * Redistribution and use in source and binary forms, with or without
6bb0ec6b3SJim Harris  * modification, are permitted provided that the following conditions
7bb0ec6b3SJim Harris  * are met:
8bb0ec6b3SJim Harris  * 1. Redistributions of source code must retain the above copyright
9bb0ec6b3SJim Harris  *    notice, this list of conditions and the following disclaimer.
10bb0ec6b3SJim Harris  * 2. Redistributions in binary form must reproduce the above copyright
11bb0ec6b3SJim Harris  *    notice, this list of conditions and the following disclaimer in the
12bb0ec6b3SJim Harris  *    documentation and/or other materials provided with the distribution.
13bb0ec6b3SJim Harris  *
14bb0ec6b3SJim Harris  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
15bb0ec6b3SJim Harris  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
16bb0ec6b3SJim Harris  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
17bb0ec6b3SJim Harris  * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
18bb0ec6b3SJim Harris  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
19bb0ec6b3SJim Harris  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
20bb0ec6b3SJim Harris  * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
21bb0ec6b3SJim Harris  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
22bb0ec6b3SJim Harris  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
23bb0ec6b3SJim Harris  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
24bb0ec6b3SJim Harris  * SUCH DAMAGE.
25bb0ec6b3SJim Harris  */
26bb0ec6b3SJim Harris 
27bb0ec6b3SJim Harris #include <sys/cdefs.h>
28bb0ec6b3SJim Harris __FBSDID("$FreeBSD$");
29bb0ec6b3SJim Harris 
30bb0ec6b3SJim Harris #include <sys/param.h>
31bb0ec6b3SJim Harris #include <sys/bio.h>
32bb0ec6b3SJim Harris #include <sys/kernel.h>
33bb0ec6b3SJim Harris #include <sys/malloc.h>
34bb0ec6b3SJim Harris #include <sys/module.h>
35bb0ec6b3SJim Harris #include <sys/systm.h>
36bb0ec6b3SJim Harris #include <sys/taskqueue.h>
37bb0ec6b3SJim Harris 
38bb0ec6b3SJim Harris #include <geom/geom.h>
39bb0ec6b3SJim Harris #include <geom/geom_disk.h>
40bb0ec6b3SJim Harris 
41bb0ec6b3SJim Harris #include <dev/nvme/nvme.h>
42bb0ec6b3SJim Harris 
43bb0ec6b3SJim Harris struct nvd_disk;
44bb0ec6b3SJim Harris 
45bb0ec6b3SJim Harris static disk_ioctl_t nvd_ioctl;
46bb0ec6b3SJim Harris static disk_strategy_t nvd_strategy;
47bb0ec6b3SJim Harris 
48*ec84ecbbSJim Harris static void *nvd_new_disk(struct nvme_namespace *ns, void *ctrlr);
49bb0ec6b3SJim Harris static void destroy_geom_disk(struct nvd_disk *ndisk);
50bb0ec6b3SJim Harris 
51*ec84ecbbSJim Harris static void *nvd_new_controller(struct nvme_controller *ctrlr);
52*ec84ecbbSJim Harris 
53bb0ec6b3SJim Harris static int nvd_load(void);
54bb0ec6b3SJim Harris static void nvd_unload(void);
55bb0ec6b3SJim Harris 
56bb0ec6b3SJim Harris MALLOC_DEFINE(M_NVD, "nvd", "nvd(4) allocations");
57bb0ec6b3SJim Harris 
58bb0ec6b3SJim Harris struct nvme_consumer *consumer_handle;
59bb0ec6b3SJim Harris 
60bb0ec6b3SJim Harris struct nvd_disk {
61bb0ec6b3SJim Harris 
62bb0ec6b3SJim Harris 	struct bio_queue_head	bioq;
63bb0ec6b3SJim Harris 	struct task		bioqtask;
64bb0ec6b3SJim Harris 	struct mtx		bioqlock;
65bb0ec6b3SJim Harris 
66bb0ec6b3SJim Harris 	struct disk		*disk;
67bb0ec6b3SJim Harris 	struct taskqueue	*tq;
68bb0ec6b3SJim Harris 	struct nvme_namespace	*ns;
69bb0ec6b3SJim Harris 
70bb0ec6b3SJim Harris 	uint32_t		cur_depth;
71bb0ec6b3SJim Harris 
72*ec84ecbbSJim Harris 	TAILQ_ENTRY(nvd_disk)	global_tailq;
73*ec84ecbbSJim Harris 	TAILQ_ENTRY(nvd_disk)	ctrlr_tailq;
74bb0ec6b3SJim Harris };
75bb0ec6b3SJim Harris 
76*ec84ecbbSJim Harris struct nvd_controller {
77*ec84ecbbSJim Harris 
78*ec84ecbbSJim Harris 	TAILQ_ENTRY(nvd_controller)	tailq;
79*ec84ecbbSJim Harris 	TAILQ_HEAD(, nvd_disk)		disk_head;
80*ec84ecbbSJim Harris };
81*ec84ecbbSJim Harris 
82*ec84ecbbSJim Harris static TAILQ_HEAD(, nvd_controller)	ctrlr_head;
83*ec84ecbbSJim Harris static TAILQ_HEAD(disk_list, nvd_disk)	disk_head;
84bb0ec6b3SJim Harris 
85bb0ec6b3SJim Harris static int nvd_modevent(module_t mod, int type, void *arg)
86bb0ec6b3SJim Harris {
87bb0ec6b3SJim Harris 	int error = 0;
88bb0ec6b3SJim Harris 
89bb0ec6b3SJim Harris 	switch (type) {
90bb0ec6b3SJim Harris 	case MOD_LOAD:
91bb0ec6b3SJim Harris 		error = nvd_load();
92bb0ec6b3SJim Harris 		break;
93bb0ec6b3SJim Harris 	case MOD_UNLOAD:
94bb0ec6b3SJim Harris 		nvd_unload();
95bb0ec6b3SJim Harris 		break;
96bb0ec6b3SJim Harris 	default:
97bb0ec6b3SJim Harris 		break;
98bb0ec6b3SJim Harris 	}
99bb0ec6b3SJim Harris 
100bb0ec6b3SJim Harris 	return (error);
101bb0ec6b3SJim Harris }
102bb0ec6b3SJim Harris 
103bb0ec6b3SJim Harris moduledata_t nvd_mod = {
104bb0ec6b3SJim Harris 	"nvd",
105bb0ec6b3SJim Harris 	(modeventhand_t)nvd_modevent,
1069823d527SKevin Lo 	0
107bb0ec6b3SJim Harris };
108bb0ec6b3SJim Harris 
109bb0ec6b3SJim Harris DECLARE_MODULE(nvd, nvd_mod, SI_SUB_DRIVERS, SI_ORDER_ANY);
110bb0ec6b3SJim Harris MODULE_VERSION(nvd, 1);
111bb0ec6b3SJim Harris MODULE_DEPEND(nvd, nvme, 1, 1, 1);
112bb0ec6b3SJim Harris 
113bb0ec6b3SJim Harris static int
114bb0ec6b3SJim Harris nvd_load()
115bb0ec6b3SJim Harris {
116bb0ec6b3SJim Harris 
117*ec84ecbbSJim Harris 	TAILQ_INIT(&ctrlr_head);
118*ec84ecbbSJim Harris 	TAILQ_INIT(&disk_head);
119*ec84ecbbSJim Harris 
120*ec84ecbbSJim Harris 	consumer_handle = nvme_register_consumer(nvd_new_disk,
121*ec84ecbbSJim Harris 	    nvd_new_controller, NULL);
122bb0ec6b3SJim Harris 
123bb0ec6b3SJim Harris 	return (consumer_handle != NULL ? 0 : -1);
124bb0ec6b3SJim Harris }
125bb0ec6b3SJim Harris 
126bb0ec6b3SJim Harris static void
127bb0ec6b3SJim Harris nvd_unload()
128bb0ec6b3SJim Harris {
129*ec84ecbbSJim Harris 	struct nvd_controller	*ctrlr;
130*ec84ecbbSJim Harris 	struct nvd_disk		*disk;
131bb0ec6b3SJim Harris 
132*ec84ecbbSJim Harris 	while (!TAILQ_EMPTY(&ctrlr_head)) {
133*ec84ecbbSJim Harris 		ctrlr = TAILQ_FIRST(&ctrlr_head);
134*ec84ecbbSJim Harris 		TAILQ_REMOVE(&ctrlr_head, ctrlr, tailq);
135*ec84ecbbSJim Harris 		free(ctrlr, M_NVD);
136*ec84ecbbSJim Harris 	}
137*ec84ecbbSJim Harris 
138*ec84ecbbSJim Harris 	while (!TAILQ_EMPTY(&disk_head)) {
139*ec84ecbbSJim Harris 		disk = TAILQ_FIRST(&disk_head);
140*ec84ecbbSJim Harris 		TAILQ_REMOVE(&disk_head, disk, global_tailq);
141*ec84ecbbSJim Harris 		destroy_geom_disk(disk);
142*ec84ecbbSJim Harris 		free(disk, M_NVD);
143bb0ec6b3SJim Harris 	}
144bb0ec6b3SJim Harris 
145bb0ec6b3SJim Harris 	nvme_unregister_consumer(consumer_handle);
146bb0ec6b3SJim Harris }
147bb0ec6b3SJim Harris 
148bb0ec6b3SJim Harris static void
149bb0ec6b3SJim Harris nvd_strategy(struct bio *bp)
150bb0ec6b3SJim Harris {
151bb0ec6b3SJim Harris 	struct nvd_disk *ndisk;
152bb0ec6b3SJim Harris 
153bb0ec6b3SJim Harris 	ndisk = (struct nvd_disk *)bp->bio_disk->d_drv1;
154bb0ec6b3SJim Harris 
155bb0ec6b3SJim Harris 	mtx_lock(&ndisk->bioqlock);
156bb0ec6b3SJim Harris 	bioq_insert_tail(&ndisk->bioq, bp);
157bb0ec6b3SJim Harris 	mtx_unlock(&ndisk->bioqlock);
158bb0ec6b3SJim Harris 	taskqueue_enqueue(ndisk->tq, &ndisk->bioqtask);
159bb0ec6b3SJim Harris }
160bb0ec6b3SJim Harris 
161bb0ec6b3SJim Harris static int
162bb0ec6b3SJim Harris nvd_ioctl(struct disk *ndisk, u_long cmd, void *data, int fflag,
163bb0ec6b3SJim Harris     struct thread *td)
164bb0ec6b3SJim Harris {
165bb0ec6b3SJim Harris 	int ret = 0;
166bb0ec6b3SJim Harris 
167bb0ec6b3SJim Harris 	switch (cmd) {
168bb0ec6b3SJim Harris 	default:
169bb0ec6b3SJim Harris 		ret = EIO;
170bb0ec6b3SJim Harris 	}
171bb0ec6b3SJim Harris 
172bb0ec6b3SJim Harris 	return (ret);
173bb0ec6b3SJim Harris }
174bb0ec6b3SJim Harris 
175bb0ec6b3SJim Harris static void
176cf81529cSJim Harris nvd_done(void *arg, const struct nvme_completion *cpl)
177bb0ec6b3SJim Harris {
178bb0ec6b3SJim Harris 	struct bio *bp;
179bb0ec6b3SJim Harris 	struct nvd_disk *ndisk;
180bb0ec6b3SJim Harris 
181bb0ec6b3SJim Harris 	bp = (struct bio *)arg;
182bb0ec6b3SJim Harris 
183bb0ec6b3SJim Harris 	ndisk = bp->bio_disk->d_drv1;
184bb0ec6b3SJim Harris 
1850f71ecf7SJim Harris 	atomic_add_int(&ndisk->cur_depth, -1);
186bb0ec6b3SJim Harris 
187bb0ec6b3SJim Harris 	/*
188bb0ec6b3SJim Harris 	 * TODO: add more extensive translation of NVMe status codes
189bb0ec6b3SJim Harris 	 *  to different bio error codes (i.e. EIO, EINVAL, etc.)
190bb0ec6b3SJim Harris 	 */
191cf81529cSJim Harris 	if (nvme_completion_is_error(cpl)) {
192bb0ec6b3SJim Harris 		bp->bio_error = EIO;
193bb0ec6b3SJim Harris 		bp->bio_flags |= BIO_ERROR;
194bb0ec6b3SJim Harris 		bp->bio_resid = bp->bio_bcount;
195bb0ec6b3SJim Harris 	} else
196bb0ec6b3SJim Harris 		bp->bio_resid = 0;
197bb0ec6b3SJim Harris 
198bb0ec6b3SJim Harris 	biodone(bp);
199bb0ec6b3SJim Harris }
200bb0ec6b3SJim Harris 
201bb0ec6b3SJim Harris static void
202bb0ec6b3SJim Harris nvd_bioq_process(void *arg, int pending)
203bb0ec6b3SJim Harris {
204bb0ec6b3SJim Harris 	struct nvd_disk *ndisk = arg;
205bb0ec6b3SJim Harris 	struct bio *bp;
206bb0ec6b3SJim Harris 	int err;
207bb0ec6b3SJim Harris 
208bb0ec6b3SJim Harris 	for (;;) {
209bb0ec6b3SJim Harris 		mtx_lock(&ndisk->bioqlock);
210bb0ec6b3SJim Harris 		bp = bioq_takefirst(&ndisk->bioq);
211bb0ec6b3SJim Harris 		mtx_unlock(&ndisk->bioqlock);
212bb0ec6b3SJim Harris 		if (bp == NULL)
213bb0ec6b3SJim Harris 			break;
214bb0ec6b3SJim Harris 
215bb0ec6b3SJim Harris #ifdef BIO_ORDERED
216bb0ec6b3SJim Harris 		/*
217bb0ec6b3SJim Harris 		 * BIO_ORDERED flag dictates that all outstanding bios
218bb0ec6b3SJim Harris 		 *  must be completed before processing the bio with
219bb0ec6b3SJim Harris 		 *  BIO_ORDERED flag set.
220bb0ec6b3SJim Harris 		 */
221bb0ec6b3SJim Harris 		if (bp->bio_flags & BIO_ORDERED) {
222bb0ec6b3SJim Harris 			while (ndisk->cur_depth > 0) {
223bb0ec6b3SJim Harris 				pause("nvd flush", 1);
224bb0ec6b3SJim Harris 			}
225bb0ec6b3SJim Harris 		}
226bb0ec6b3SJim Harris #endif
227bb0ec6b3SJim Harris 
228bb0ec6b3SJim Harris 		bp->bio_driver1 = NULL;
2290f71ecf7SJim Harris 		atomic_add_int(&ndisk->cur_depth, 1);
230bb0ec6b3SJim Harris 
231bb0ec6b3SJim Harris 		err = nvme_ns_bio_process(ndisk->ns, bp, nvd_done);
232bb0ec6b3SJim Harris 
233bb0ec6b3SJim Harris 		if (err) {
2340f71ecf7SJim Harris 			atomic_add_int(&ndisk->cur_depth, -1);
2359eb93f29SJim Harris 			bp->bio_error = err;
236bb0ec6b3SJim Harris 			bp->bio_flags |= BIO_ERROR;
237bb0ec6b3SJim Harris 			bp->bio_resid = bp->bio_bcount;
238bb0ec6b3SJim Harris 			biodone(bp);
239bb0ec6b3SJim Harris 		}
240bb0ec6b3SJim Harris 
241bb0ec6b3SJim Harris #ifdef BIO_ORDERED
242bb0ec6b3SJim Harris 		/*
243bb0ec6b3SJim Harris 		 * BIO_ORDERED flag dictates that the bio with BIO_ORDERED
244bb0ec6b3SJim Harris 		 *  flag set must be completed before proceeding with
245bb0ec6b3SJim Harris 		 *  additional bios.
246bb0ec6b3SJim Harris 		 */
247bb0ec6b3SJim Harris 		if (bp->bio_flags & BIO_ORDERED) {
248bb0ec6b3SJim Harris 			while (ndisk->cur_depth > 0) {
249bb0ec6b3SJim Harris 				pause("nvd flush", 1);
250bb0ec6b3SJim Harris 			}
251bb0ec6b3SJim Harris 		}
252bb0ec6b3SJim Harris #endif
253bb0ec6b3SJim Harris 	}
254bb0ec6b3SJim Harris }
255bb0ec6b3SJim Harris 
256038a5ee4SJim Harris static void *
257*ec84ecbbSJim Harris nvd_new_controller(struct nvme_controller *ctrlr)
258*ec84ecbbSJim Harris {
259*ec84ecbbSJim Harris 	struct nvd_controller	*nvd_ctrlr;
260*ec84ecbbSJim Harris 
261*ec84ecbbSJim Harris 	nvd_ctrlr = malloc(sizeof(struct nvd_controller), M_NVD,
262*ec84ecbbSJim Harris 	    M_ZERO | M_NOWAIT);
263*ec84ecbbSJim Harris 
264*ec84ecbbSJim Harris 	TAILQ_INIT(&nvd_ctrlr->disk_head);
265*ec84ecbbSJim Harris 	TAILQ_INSERT_TAIL(&ctrlr_head, nvd_ctrlr, tailq);
266*ec84ecbbSJim Harris 
267*ec84ecbbSJim Harris 	return (nvd_ctrlr);
268*ec84ecbbSJim Harris }
269*ec84ecbbSJim Harris 
270*ec84ecbbSJim Harris static void *
271*ec84ecbbSJim Harris nvd_new_disk(struct nvme_namespace *ns, void *ctrlr_arg)
272bb0ec6b3SJim Harris {
273bb0ec6b3SJim Harris 	struct nvd_disk		*ndisk;
274bb0ec6b3SJim Harris 	struct disk		*disk;
275*ec84ecbbSJim Harris 	struct nvd_controller	*ctrlr = ctrlr_arg;
276bb0ec6b3SJim Harris 
277bb0ec6b3SJim Harris 	ndisk = malloc(sizeof(struct nvd_disk), M_NVD, M_ZERO | M_NOWAIT);
278bb0ec6b3SJim Harris 
279bb0ec6b3SJim Harris 	disk = disk_alloc();
280bb0ec6b3SJim Harris 	disk->d_strategy = nvd_strategy;
281bb0ec6b3SJim Harris 	disk->d_ioctl = nvd_ioctl;
282bb0ec6b3SJim Harris 	disk->d_name = "nvd";
283bb0ec6b3SJim Harris 	disk->d_drv1 = ndisk;
284bb0ec6b3SJim Harris 
285bb0ec6b3SJim Harris 	disk->d_maxsize = nvme_ns_get_max_io_xfer_size(ns);
286bb0ec6b3SJim Harris 	disk->d_sectorsize = nvme_ns_get_sector_size(ns);
287bb0ec6b3SJim Harris 	disk->d_mediasize = (off_t)nvme_ns_get_size(ns);
288bb0ec6b3SJim Harris 
289*ec84ecbbSJim Harris 	if (TAILQ_EMPTY(&disk_head))
290bb0ec6b3SJim Harris 		disk->d_unit = 0;
291bb0ec6b3SJim Harris 	else
292*ec84ecbbSJim Harris 		disk->d_unit =
293*ec84ecbbSJim Harris 		    TAILQ_LAST(&disk_head, disk_list)->disk->d_unit + 1;
294bb0ec6b3SJim Harris 
295bb0ec6b3SJim Harris 	disk->d_flags = 0;
296bb0ec6b3SJim Harris 
297bb0ec6b3SJim Harris 	if (nvme_ns_get_flags(ns) & NVME_NS_DEALLOCATE_SUPPORTED)
298bb0ec6b3SJim Harris 		disk->d_flags |= DISKFLAG_CANDELETE;
299bb0ec6b3SJim Harris 
300bb0ec6b3SJim Harris 	if (nvme_ns_get_flags(ns) & NVME_NS_FLUSH_SUPPORTED)
301bb0ec6b3SJim Harris 		disk->d_flags |= DISKFLAG_CANFLUSHCACHE;
302bb0ec6b3SJim Harris 
303bb0ec6b3SJim Harris 	strlcpy(disk->d_ident, nvme_ns_get_serial_number(ns),
304bb0ec6b3SJim Harris 	    sizeof(disk->d_ident));
305bb0ec6b3SJim Harris 
306bb0ec6b3SJim Harris #if __FreeBSD_version >= 900034
307bb0ec6b3SJim Harris 	strlcpy(disk->d_descr, nvme_ns_get_model_number(ns),
308bb0ec6b3SJim Harris 	    sizeof(disk->d_descr));
309bb0ec6b3SJim Harris #endif
310bb0ec6b3SJim Harris 
311bb0ec6b3SJim Harris 	disk_create(disk, DISK_VERSION);
312bb0ec6b3SJim Harris 
313bb0ec6b3SJim Harris 	ndisk->ns = ns;
314bb0ec6b3SJim Harris 	ndisk->disk = disk;
315bb0ec6b3SJim Harris 	ndisk->cur_depth = 0;
316bb0ec6b3SJim Harris 
317bb0ec6b3SJim Harris 	mtx_init(&ndisk->bioqlock, "NVD bioq lock", NULL, MTX_DEF);
318bb0ec6b3SJim Harris 	bioq_init(&ndisk->bioq);
319bb0ec6b3SJim Harris 
320bb0ec6b3SJim Harris 	TASK_INIT(&ndisk->bioqtask, 0, nvd_bioq_process, ndisk);
321bb0ec6b3SJim Harris 	ndisk->tq = taskqueue_create("nvd_taskq", M_WAITOK,
322bb0ec6b3SJim Harris 	    taskqueue_thread_enqueue, &ndisk->tq);
323bb0ec6b3SJim Harris 	taskqueue_start_threads(&ndisk->tq, 1, PI_DISK, "nvd taskq");
324bb0ec6b3SJim Harris 
325*ec84ecbbSJim Harris 	TAILQ_INSERT_TAIL(&disk_head, ndisk, global_tailq);
326*ec84ecbbSJim Harris 	TAILQ_INSERT_TAIL(&ctrlr->disk_head, ndisk, ctrlr_tailq);
327038a5ee4SJim Harris 
328038a5ee4SJim Harris 	return (NULL);
329bb0ec6b3SJim Harris }
330bb0ec6b3SJim Harris 
331bb0ec6b3SJim Harris static void
332bb0ec6b3SJim Harris destroy_geom_disk(struct nvd_disk *ndisk)
333bb0ec6b3SJim Harris {
334bb0ec6b3SJim Harris 	struct bio *bp;
335bb0ec6b3SJim Harris 
336bb0ec6b3SJim Harris 	taskqueue_free(ndisk->tq);
337bb0ec6b3SJim Harris 	disk_destroy(ndisk->disk);
338bb0ec6b3SJim Harris 
339bb0ec6b3SJim Harris 	mtx_lock(&ndisk->bioqlock);
340bb0ec6b3SJim Harris 	for (;;) {
341bb0ec6b3SJim Harris 		bp = bioq_takefirst(&ndisk->bioq);
342bb0ec6b3SJim Harris 		if (bp == NULL)
343bb0ec6b3SJim Harris 			break;
344bb0ec6b3SJim Harris 		bp->bio_error = EIO;
345bb0ec6b3SJim Harris 		bp->bio_flags |= BIO_ERROR;
346bb0ec6b3SJim Harris 		bp->bio_resid = bp->bio_bcount;
347bb0ec6b3SJim Harris 
348bb0ec6b3SJim Harris 		biodone(bp);
349bb0ec6b3SJim Harris 	}
350bb0ec6b3SJim Harris 	mtx_unlock(&ndisk->bioqlock);
351bb0ec6b3SJim Harris 
352bb0ec6b3SJim Harris 	mtx_destroy(&ndisk->bioqlock);
353bb0ec6b3SJim Harris }
354