xref: /freebsd/sys/dev/iwm/if_iwm_mac_ctxt.c (revision 3a970562d7f8b2506f7bcbe378e3c02a408425d7)
1 /*	$OpenBSD: if_iwm.c,v 1.39 2015/03/23 00:35:19 jsg Exp $	*/
2 
3 /*
4  * Copyright (c) 2014 genua mbh <info@genua.de>
5  * Copyright (c) 2014 Fixup Software Ltd.
6  *
7  * Permission to use, copy, modify, and distribute this software for any
8  * purpose with or without fee is hereby granted, provided that the above
9  * copyright notice and this permission notice appear in all copies.
10  *
11  * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
12  * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
13  * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
14  * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
15  * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
16  * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
17  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
18  */
19 
20 /*-
21  * Based on BSD-licensed source modules in the Linux iwlwifi driver,
22  * which were used as the reference documentation for this implementation.
23  *
24  * Driver version we are currently based off of is
25  * Linux 3.14.3 (tag id a2df521e42b1d9a23f620ac79dbfe8655a8391dd)
26  *
27  ***********************************************************************
28  *
29  * This file is provided under a dual BSD/GPLv2 license.  When using or
30  * redistributing this file, you may do so under either license.
31  *
32  * GPL LICENSE SUMMARY
33  *
34  * Copyright(c) 2007 - 2013 Intel Corporation. All rights reserved.
35  *
36  * This program is free software; you can redistribute it and/or modify
37  * it under the terms of version 2 of the GNU General Public License as
38  * published by the Free Software Foundation.
39  *
40  * This program is distributed in the hope that it will be useful, but
41  * WITHOUT ANY WARRANTY; without even the implied warranty of
42  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
43  * General Public License for more details.
44  *
45  * You should have received a copy of the GNU General Public License
46  * along with this program; if not, write to the Free Software
47  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110,
48  * USA
49  *
50  * The full GNU General Public License is included in this distribution
51  * in the file called COPYING.
52  *
53  * Contact Information:
54  *  Intel Linux Wireless <ilw@linux.intel.com>
55  * Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
56  *
57  *
58  * BSD LICENSE
59  *
60  * Copyright(c) 2005 - 2013 Intel Corporation. All rights reserved.
61  * All rights reserved.
62  *
63  * Redistribution and use in source and binary forms, with or without
64  * modification, are permitted provided that the following conditions
65  * are met:
66  *
67  *  * Redistributions of source code must retain the above copyright
68  *    notice, this list of conditions and the following disclaimer.
69  *  * Redistributions in binary form must reproduce the above copyright
70  *    notice, this list of conditions and the following disclaimer in
71  *    the documentation and/or other materials provided with the
72  *    distribution.
73  *  * Neither the name Intel Corporation nor the names of its
74  *    contributors may be used to endorse or promote products derived
75  *    from this software without specific prior written permission.
76  *
77  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
78  * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
79  * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
80  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
81  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
82  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
83  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
84  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
85  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
86  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
87  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
88  */
89 
90 /*-
91  * Copyright (c) 2007-2010 Damien Bergamini <damien.bergamini@free.fr>
92  *
93  * Permission to use, copy, modify, and distribute this software for any
94  * purpose with or without fee is hereby granted, provided that the above
95  * copyright notice and this permission notice appear in all copies.
96  *
97  * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
98  * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
99  * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
100  * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
101  * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
102  * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
103  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
104  */
105 #include <sys/cdefs.h>
106 __FBSDID("$FreeBSD$");
107 
108 #include "opt_wlan.h"
109 
110 #include <sys/param.h>
111 #include <sys/bus.h>
112 #include <sys/conf.h>
113 #include <sys/endian.h>
114 #include <sys/firmware.h>
115 #include <sys/kernel.h>
116 #include <sys/malloc.h>
117 #include <sys/mbuf.h>
118 #include <sys/mutex.h>
119 #include <sys/module.h>
120 #include <sys/proc.h>
121 #include <sys/rman.h>
122 #include <sys/socket.h>
123 #include <sys/sockio.h>
124 #include <sys/sysctl.h>
125 #include <sys/linker.h>
126 
127 #include <machine/bus.h>
128 #include <machine/endian.h>
129 #include <machine/resource.h>
130 
131 #include <dev/pci/pcivar.h>
132 #include <dev/pci/pcireg.h>
133 
134 #include <net/bpf.h>
135 
136 #include <net/if.h>
137 #include <net/if_var.h>
138 #include <net/if_arp.h>
139 #include <net/if_dl.h>
140 #include <net/if_media.h>
141 #include <net/if_types.h>
142 
143 #include <netinet/in.h>
144 #include <netinet/in_systm.h>
145 #include <netinet/if_ether.h>
146 #include <netinet/ip.h>
147 
148 #include <net80211/ieee80211_var.h>
149 #include <net80211/ieee80211_regdomain.h>
150 #include <net80211/ieee80211_ratectl.h>
151 #include <net80211/ieee80211_radiotap.h>
152 
153 #include <dev/iwm/if_iwmreg.h>
154 #include <dev/iwm/if_iwmvar.h>
155 #include <dev/iwm/if_iwm_debug.h>
156 #include <dev/iwm/if_iwm_util.h>
157 #include <dev/iwm/if_iwm_mac_ctxt.h>
158 
159 /*
160  * BEGIN mvm/mac-ctxt.c
161  */
162 
163 static void
164 iwm_mvm_ack_rates(struct iwm_softc *sc, int is2ghz,
165 	int *cck_rates, int *ofdm_rates)
166 {
167 	int lowest_present_ofdm = 100;
168 	int lowest_present_cck = 100;
169 	uint8_t cck = 0;
170 	uint8_t ofdm = 0;
171 	int i;
172 
173 	if (is2ghz) {
174 		for (i = 0; i <= IWM_LAST_CCK_RATE; i++) {
175 			cck |= (1 << i);
176 			if (lowest_present_cck > i)
177 				lowest_present_cck = i;
178 		}
179 	}
180 	for (i = IWM_FIRST_OFDM_RATE; i <= IWM_LAST_NON_HT_RATE; i++) {
181 		int adj = i - IWM_FIRST_OFDM_RATE;
182 		ofdm |= (1 << adj);
183 		if (lowest_present_ofdm > i)
184 			lowest_present_ofdm = i;
185 	}
186 
187 	/*
188 	 * Now we've got the basic rates as bitmaps in the ofdm and cck
189 	 * variables. This isn't sufficient though, as there might not
190 	 * be all the right rates in the bitmap. E.g. if the only basic
191 	 * rates are 5.5 Mbps and 11 Mbps, we still need to add 1 Mbps
192 	 * and 6 Mbps because the 802.11-2007 standard says in 9.6:
193 	 *
194 	 *    [...] a STA responding to a received frame shall transmit
195 	 *    its Control Response frame [...] at the highest rate in the
196 	 *    BSSBasicRateSet parameter that is less than or equal to the
197 	 *    rate of the immediately previous frame in the frame exchange
198 	 *    sequence ([...]) and that is of the same modulation class
199 	 *    ([...]) as the received frame. If no rate contained in the
200 	 *    BSSBasicRateSet parameter meets these conditions, then the
201 	 *    control frame sent in response to a received frame shall be
202 	 *    transmitted at the highest mandatory rate of the PHY that is
203 	 *    less than or equal to the rate of the received frame, and
204 	 *    that is of the same modulation class as the received frame.
205 	 *
206 	 * As a consequence, we need to add all mandatory rates that are
207 	 * lower than all of the basic rates to these bitmaps.
208 	 */
209 
210 	if (IWM_RATE_24M_INDEX < lowest_present_ofdm)
211 		ofdm |= IWM_RATE_BIT_MSK(24) >> IWM_FIRST_OFDM_RATE;
212 	if (IWM_RATE_12M_INDEX < lowest_present_ofdm)
213 		ofdm |= IWM_RATE_BIT_MSK(12) >> IWM_FIRST_OFDM_RATE;
214 	/* 6M already there or needed so always add */
215 	ofdm |= IWM_RATE_BIT_MSK(6) >> IWM_FIRST_OFDM_RATE;
216 
217 	/*
218 	 * CCK is a bit more complex with DSSS vs. HR/DSSS vs. ERP.
219 	 * Note, however:
220 	 *  - if no CCK rates are basic, it must be ERP since there must
221 	 *    be some basic rates at all, so they're OFDM => ERP PHY
222 	 *    (or we're in 5 GHz, and the cck bitmap will never be used)
223 	 *  - if 11M is a basic rate, it must be ERP as well, so add 5.5M
224 	 *  - if 5.5M is basic, 1M and 2M are mandatory
225 	 *  - if 2M is basic, 1M is mandatory
226 	 *  - if 1M is basic, that's the only valid ACK rate.
227 	 * As a consequence, it's not as complicated as it sounds, just add
228 	 * any lower rates to the ACK rate bitmap.
229 	 */
230 	if (IWM_RATE_11M_INDEX < lowest_present_cck)
231 		cck |= IWM_RATE_BIT_MSK(11) >> IWM_FIRST_CCK_RATE;
232 	if (IWM_RATE_5M_INDEX < lowest_present_cck)
233 		cck |= IWM_RATE_BIT_MSK(5) >> IWM_FIRST_CCK_RATE;
234 	if (IWM_RATE_2M_INDEX < lowest_present_cck)
235 		cck |= IWM_RATE_BIT_MSK(2) >> IWM_FIRST_CCK_RATE;
236 	/* 1M already there or needed so always add */
237 	cck |= IWM_RATE_BIT_MSK(1) >> IWM_FIRST_CCK_RATE;
238 
239 	*cck_rates = cck;
240 	*ofdm_rates = ofdm;
241 }
242 
243 static void
244 iwm_mvm_mac_ctxt_cmd_common(struct iwm_softc *sc, struct iwm_node *in,
245 	struct iwm_mac_ctx_cmd *cmd, uint32_t action)
246 {
247 	struct ieee80211com *ic = &sc->sc_ic;
248 	struct ieee80211vap *vap = TAILQ_FIRST(&ic->ic_vaps);
249 	struct ieee80211_node *ni = vap->iv_bss;
250 	int cck_ack_rates, ofdm_ack_rates;
251 	int i;
252 	int is2ghz;
253 
254 	/*
255 	 * id is the MAC address ID - something to do with MAC filtering.
256 	 * color - not sure.
257 	 *
258 	 * These are both functions of the vap, not of the node.
259 	 * So, for now, hard-code both to 0 (default).
260 	 */
261 	cmd->id_and_color = htole32(IWM_FW_CMD_ID_AND_COLOR(IWM_DEFAULT_MACID,
262 	    IWM_DEFAULT_COLOR));
263 	cmd->action = htole32(action);
264 
265 	cmd->mac_type = htole32(IWM_FW_MAC_TYPE_BSS_STA);
266 
267 	/*
268 	 * The TSF ID is one of four TSF tracking resources in the firmware.
269 	 * Read the iwlwifi/mvm code for more details.
270 	 *
271 	 * For now, just hard-code it to TSF tracking ID 0; we only support
272 	 * a single STA mode VAP.
273 	 *
274 	 * It's per-vap, not per-node.
275 	 */
276 	cmd->tsf_id = htole32(IWM_DEFAULT_TSFID);
277 
278 	IEEE80211_ADDR_COPY(cmd->node_addr, vap->iv_myaddr);
279 
280 	/*
281 	 * XXX should we error out if in_assoc is 1 and ni == NULL?
282 	 */
283 #if 0
284 	if (in->in_assoc) {
285 		IEEE80211_ADDR_COPY(cmd->bssid_addr, ni->ni_bssid);
286 	} else {
287 		/* eth broadcast address */
288 		IEEE80211_ADDR_COPY(cmd->bssid_addr, ieee80211broadcastaddr);
289 	}
290 #else
291 	/*
292 	 * XXX This workaround makes the firmware behave more correctly once
293 	 *     we are associated, regularly giving us statistics notifications,
294 	 *     as well as signaling missed beacons to us.
295 	 *     Since we only call iwm_mvm_mac_ctxt_add() and
296 	 *     iwm_mvm_mac_ctxt_changed() when already authenticating or
297 	 *     associating, ni->ni_bssid should always make sense here.
298 	 */
299 	IEEE80211_ADDR_COPY(cmd->bssid_addr, ni->ni_bssid);
300 #endif
301 
302 	/*
303 	 * Default to 2ghz if no node information is given.
304 	 */
305 	if (in) {
306 		is2ghz = !! IEEE80211_IS_CHAN_2GHZ(in->in_ni.ni_chan);
307 	} else {
308 		is2ghz = 1;
309 	}
310 	iwm_mvm_ack_rates(sc, is2ghz, &cck_ack_rates, &ofdm_ack_rates);
311 	cmd->cck_rates = htole32(cck_ack_rates);
312 	cmd->ofdm_rates = htole32(ofdm_ack_rates);
313 
314 	cmd->cck_short_preamble
315 	    = htole32((ic->ic_flags & IEEE80211_F_SHPREAMBLE)
316 	      ? IWM_MAC_FLG_SHORT_PREAMBLE : 0);
317 	cmd->short_slot
318 	    = htole32((ic->ic_flags & IEEE80211_F_SHSLOT)
319 	      ? IWM_MAC_FLG_SHORT_SLOT : 0);
320 
321 	/* XXX TODO: set wme parameters; also handle getting updated wme parameters */
322 	for (i = 0; i < IWM_AC_NUM+1; i++) {
323 		int txf = i;
324 
325 		cmd->ac[txf].cw_min = htole16(0x0f);
326 		cmd->ac[txf].cw_max = htole16(0x3f);
327 		cmd->ac[txf].aifsn = 1;
328 		cmd->ac[txf].fifos_mask = (1 << txf);
329 		cmd->ac[txf].edca_txop = 0;
330 	}
331 
332 	if (ic->ic_flags & IEEE80211_F_USEPROT)
333 		cmd->protection_flags |= htole32(IWM_MAC_PROT_FLG_TGG_PROTECT);
334 
335 	cmd->filter_flags = htole32(IWM_MAC_FILTER_ACCEPT_GRP);
336 }
337 
338 static int
339 iwm_mvm_mac_ctxt_send_cmd(struct iwm_softc *sc, struct iwm_mac_ctx_cmd *cmd)
340 {
341 	int ret = iwm_mvm_send_cmd_pdu(sc, IWM_MAC_CONTEXT_CMD, IWM_CMD_SYNC,
342 				       sizeof(*cmd), cmd);
343 	if (ret)
344 		device_printf(sc->sc_dev,
345 		    "%s: Failed to send MAC context (action:%d): %d\n",
346 		    __func__, le32toh(cmd->action), ret);
347 	return ret;
348 }
349 
350 /*
351  * Fill the specific data for mac context of type station or p2p client
352  */
353 static void
354 iwm_mvm_mac_ctxt_cmd_fill_sta(struct iwm_softc *sc, struct iwm_node *in,
355 	struct iwm_mac_data_sta *ctxt_sta, int force_assoc_off)
356 {
357 	struct ieee80211_node *ni = &in->in_ni;
358 	unsigned dtim_period, dtim_count;
359 	struct ieee80211com *ic = &sc->sc_ic;
360 	struct ieee80211vap *vap = TAILQ_FIRST(&ic->ic_vaps);
361 
362 	/* will this work? */
363 	dtim_period = vap->iv_dtim_period;
364 	dtim_count = vap->iv_dtim_count;
365 	IWM_DPRINTF(sc, IWM_DEBUG_RESET | IWM_DEBUG_BEACON | IWM_DEBUG_CMD,
366 	    "%s: force_assoc_off=%d\n", __func__, force_assoc_off);
367 	IWM_DPRINTF(sc, IWM_DEBUG_RESET | IWM_DEBUG_BEACON | IWM_DEBUG_CMD,
368 	    "DTIM: period=%d count=%d\n", dtim_period, dtim_count);
369 	IWM_DPRINTF(sc, IWM_DEBUG_RESET | IWM_DEBUG_BEACON | IWM_DEBUG_CMD,
370 	    "BEACON: tsf: %llu, ni_intval=%d\n",
371 	    (unsigned long long) le64toh(ni->ni_tstamp.tsf),
372 	    ni->ni_intval);
373 
374 	/* We need the dtim_period to set the MAC as associated */
375 	if (in->in_assoc && dtim_period && !force_assoc_off) {
376 		uint64_t tsf;
377 		uint32_t dtim_offs;
378 
379 		/*
380 		 * The DTIM count counts down, so when it is N that means N
381 		 * more beacon intervals happen until the DTIM TBTT. Therefore
382 		 * add this to the current time. If that ends up being in the
383 		 * future, the firmware will handle it.
384 		 *
385 		 * Also note that the system_timestamp (which we get here as
386 		 * "sync_device_ts") and TSF timestamp aren't at exactly the
387 		 * same offset in the frame -- the TSF is at the first symbol
388 		 * of the TSF, the system timestamp is at signal acquisition
389 		 * time. This means there's an offset between them of at most
390 		 * a few hundred microseconds (24 * 8 bits + PLCP time gives
391 		 * 384us in the longest case), this is currently not relevant
392 		 * as the firmware wakes up around 2ms before the TBTT.
393 		 */
394 		dtim_offs = dtim_count * ni->ni_intval;
395 		/* convert TU to usecs */
396 		dtim_offs *= 1024;
397 
398 		/*
399 		 * net80211: TSF is in 802.11 order, so convert up to local
400 		 * ordering before we manipulate things.
401 		 */
402 		tsf = le64toh(ni->ni_tstamp.tsf);
403 
404 		ctxt_sta->dtim_tsf = htole64(tsf + dtim_offs);
405 		ctxt_sta->dtim_time = htole32(tsf + dtim_offs);
406 
407 		IWM_DPRINTF(sc, IWM_DEBUG_RESET | IWM_DEBUG_BEACON | IWM_DEBUG_CMD,
408 		    "DTIM TBTT is 0x%llx/0x%x, offset %d\n",
409 		    (long long)le64toh(ctxt_sta->dtim_tsf),
410 		    le32toh(ctxt_sta->dtim_time), dtim_offs);
411 
412 		ctxt_sta->is_assoc = htole32(1);
413 	} else {
414 		ctxt_sta->is_assoc = htole32(0);
415 	}
416 
417 	IWM_DPRINTF(sc, IWM_DEBUG_RESET | IWM_DEBUG_CMD | IWM_DEBUG_BEACON,
418 	    "%s: ni_intval: %d, bi_reciprocal: %d, dtim_interval: %d, dtim_reciprocal: %d\n",
419 	    __func__,
420 	    ni->ni_intval,
421 	    iwm_mvm_reciprocal(ni->ni_intval),
422 	    ni->ni_intval * dtim_period,
423 	    iwm_mvm_reciprocal(ni->ni_intval * dtim_period));
424 
425 	ctxt_sta->bi = htole32(ni->ni_intval);
426 	ctxt_sta->bi_reciprocal = htole32(iwm_mvm_reciprocal(ni->ni_intval));
427 	ctxt_sta->dtim_interval = htole32(ni->ni_intval * dtim_period);
428 	ctxt_sta->dtim_reciprocal =
429 	    htole32(iwm_mvm_reciprocal(ni->ni_intval * dtim_period));
430 
431 	/* 10 = CONN_MAX_LISTEN_INTERVAL */
432 	ctxt_sta->listen_interval = htole32(10);
433 	IWM_DPRINTF(sc, IWM_DEBUG_RESET | IWM_DEBUG_CMD | IWM_DEBUG_BEACON,
434 	    "%s: associd=%d\n", __func__, IEEE80211_AID(ni->ni_associd));
435 	ctxt_sta->assoc_id = htole32(IEEE80211_AID(ni->ni_associd));
436 }
437 
438 static int
439 iwm_mvm_mac_ctxt_cmd_station(struct iwm_softc *sc, struct ieee80211vap *vap,
440 	uint32_t action)
441 {
442 	struct ieee80211_node *ni = vap->iv_bss;
443 	struct iwm_node *in = IWM_NODE(ni);
444 	struct iwm_mac_ctx_cmd cmd;
445 
446 	IWM_DPRINTF(sc, IWM_DEBUG_RESET,
447 	    "%s: called; action=%d\n", __func__, action);
448 
449 	memset(&cmd, 0, sizeof(cmd));
450 
451 	/* Fill the common data for all mac context types */
452 	iwm_mvm_mac_ctxt_cmd_common(sc, in, &cmd, action);
453 
454 	/* Allow beacons to pass through as long as we are not associated,or we
455 	 * do not have dtim period information */
456 	if (!in->in_assoc || !vap->iv_dtim_period)
457 		cmd.filter_flags |= htole32(IWM_MAC_FILTER_IN_BEACON);
458 	else
459 		cmd.filter_flags &= ~htole32(IWM_MAC_FILTER_IN_BEACON);
460 
461 	/* Fill the data specific for station mode */
462 	iwm_mvm_mac_ctxt_cmd_fill_sta(sc, in,
463 	    &cmd.sta, action == IWM_FW_CTXT_ACTION_ADD);
464 
465 	return iwm_mvm_mac_ctxt_send_cmd(sc, &cmd);
466 }
467 
468 static int
469 iwm_mvm_mac_ctx_send(struct iwm_softc *sc, struct ieee80211vap *vap,
470     uint32_t action)
471 {
472 	return iwm_mvm_mac_ctxt_cmd_station(sc, vap, action);
473 }
474 
475 int
476 iwm_mvm_mac_ctxt_add(struct iwm_softc *sc, struct ieee80211vap *vap)
477 {
478 	struct iwm_vap *iv = IWM_VAP(vap);
479 	int ret;
480 
481 	if (iv->is_uploaded != 0) {
482 		device_printf(sc->sc_dev, "%s: called; uploaded != 0\n",
483 		    __func__);
484 		return (EIO);
485 	}
486 
487 	ret = iwm_mvm_mac_ctx_send(sc, vap, IWM_FW_CTXT_ACTION_ADD);
488 	if (ret)
489 		return (ret);
490 	iv->is_uploaded = 1;
491 	return (0);
492 }
493 
494 int
495 iwm_mvm_mac_ctxt_changed(struct iwm_softc *sc, struct ieee80211vap *vap)
496 {
497 	struct iwm_vap *iv = IWM_VAP(vap);
498 
499 	if (iv->is_uploaded == 0) {
500 		device_printf(sc->sc_dev, "%s: called; uploaded = 0\n",
501 		    __func__);
502 		return (EIO);
503 	}
504 	return iwm_mvm_mac_ctx_send(sc, vap, IWM_FW_CTXT_ACTION_MODIFY);
505 }
506 
507 #if 0
508 static int
509 iwm_mvm_mac_ctxt_remove(struct iwm_softc *sc, struct iwm_node *in)
510 {
511 	struct iwm_mac_ctx_cmd cmd;
512 	int ret;
513 
514 	if (!in->in_uploaded) {
515 		device_printf(sc->sc_dev,
516 		    "attempt to remove !uploaded node %p", in);
517 		return EIO;
518 	}
519 
520 	memset(&cmd, 0, sizeof(cmd));
521 
522 	cmd.id_and_color = htole32(IWM_FW_CMD_ID_AND_COLOR(IWM_DEFAULT_MACID,
523 	    IWM_DEFAULT_COLOR));
524 	cmd.action = htole32(IWM_FW_CTXT_ACTION_REMOVE);
525 
526 	ret = iwm_mvm_send_cmd_pdu(sc,
527 	    IWM_MAC_CONTEXT_CMD, IWM_CMD_SYNC, sizeof(cmd), &cmd);
528 	if (ret) {
529 		device_printf(sc->sc_dev,
530 		    "Failed to remove MAC context: %d\n", ret);
531 		return ret;
532 	}
533 	in->in_uploaded = 0;
534 
535 	return 0;
536 }
537 #endif
538