xref: /freebsd/sys/dev/acpica/acpi_ec.c (revision bad36a49985c3cd7bfcb1b35ce3ae37f007843ce)
115e32d5dSMike Smith /*-
283dcc133SNate Lawson  * Copyright (c) 2003-2007 Nate Lawson
315e32d5dSMike Smith  * Copyright (c) 2000 Michael Smith
415e32d5dSMike Smith  * Copyright (c) 2000 BSDi
515e32d5dSMike Smith  * All rights reserved.
615e32d5dSMike Smith  *
715e32d5dSMike Smith  * Redistribution and use in source and binary forms, with or without
815e32d5dSMike Smith  * modification, are permitted provided that the following conditions
915e32d5dSMike Smith  * are met:
1015e32d5dSMike Smith  * 1. Redistributions of source code must retain the above copyright
1115e32d5dSMike Smith  *    notice, this list of conditions and the following disclaimer.
1215e32d5dSMike Smith  * 2. Redistributions in binary form must reproduce the above copyright
1315e32d5dSMike Smith  *    notice, this list of conditions and the following disclaimer in the
1415e32d5dSMike Smith  *    documentation and/or other materials provided with the distribution.
1515e32d5dSMike Smith  *
1615e32d5dSMike Smith  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
1715e32d5dSMike Smith  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
1815e32d5dSMike Smith  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
1915e32d5dSMike Smith  * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
2015e32d5dSMike Smith  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
2115e32d5dSMike Smith  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
2215e32d5dSMike Smith  * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
2315e32d5dSMike Smith  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
2415e32d5dSMike Smith  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
2515e32d5dSMike Smith  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
2615e32d5dSMike Smith  * SUCH DAMAGE.
2715e32d5dSMike Smith  */
2815e32d5dSMike Smith 
29aad970f1SDavid E. O'Brien #include <sys/cdefs.h>
3015e32d5dSMike Smith #include "opt_acpi.h"
3115e32d5dSMike Smith #include <sys/param.h>
3215e32d5dSMike Smith #include <sys/kernel.h>
33daec9284SConrad Meyer #include <sys/ktr.h>
3415e32d5dSMike Smith #include <sys/bus.h>
354e7f640dSJohn Baldwin #include <sys/lock.h>
360025fb0fSNate Lawson #include <sys/malloc.h>
37b0eefa38SNate Lawson #include <sys/module.h>
38b0eefa38SNate Lawson #include <sys/sx.h>
3915e32d5dSMike Smith 
4015e32d5dSMike Smith #include <machine/bus.h>
4115e32d5dSMike Smith #include <machine/resource.h>
4215e32d5dSMike Smith #include <sys/rman.h>
4315e32d5dSMike Smith 
44129d3046SJung-uk Kim #include <contrib/dev/acpica/include/acpi.h>
45129d3046SJung-uk Kim #include <contrib/dev/acpica/include/accommon.h>
46129d3046SJung-uk Kim 
4715e32d5dSMike Smith #include <dev/acpica/acpivar.h>
4815e32d5dSMike Smith 
49f4b7de15SNate Lawson /* Hooks for the ACPI CA debugging infrastructure */
50a9cf0dffSMike Smith #define _COMPONENT	ACPI_EC
51dbd0058aSMike Smith ACPI_MODULE_NAME("EC")
520ae55423SMike Smith 
53da3b867eSMike Smith /*
54da3b867eSMike Smith  * EC_COMMAND:
55da3b867eSMike Smith  * -----------
56da3b867eSMike Smith  */
57da3b867eSMike Smith typedef UINT8				EC_COMMAND;
58da3b867eSMike Smith 
59da3b867eSMike Smith #define EC_COMMAND_UNKNOWN		((EC_COMMAND) 0x00)
60da3b867eSMike Smith #define EC_COMMAND_READ			((EC_COMMAND) 0x80)
61da3b867eSMike Smith #define EC_COMMAND_WRITE		((EC_COMMAND) 0x81)
62da3b867eSMike Smith #define EC_COMMAND_BURST_ENABLE		((EC_COMMAND) 0x82)
63da3b867eSMike Smith #define EC_COMMAND_BURST_DISABLE	((EC_COMMAND) 0x83)
64da3b867eSMike Smith #define EC_COMMAND_QUERY		((EC_COMMAND) 0x84)
65da3b867eSMike Smith 
66da3b867eSMike Smith /*
67da3b867eSMike Smith  * EC_STATUS:
68da3b867eSMike Smith  * ----------
69da3b867eSMike Smith  * The encoding of the EC status register is illustrated below.
70da3b867eSMike Smith  * Note that a set bit (1) indicates the property is TRUE
71da3b867eSMike Smith  * (e.g. if bit 0 is set then the output buffer is full).
72da3b867eSMike Smith  * +-+-+-+-+-+-+-+-+
73da3b867eSMike Smith  * |7|6|5|4|3|2|1|0|
74da3b867eSMike Smith  * +-+-+-+-+-+-+-+-+
75da3b867eSMike Smith  *  | | | | | | | |
76da3b867eSMike Smith  *  | | | | | | | +- Output Buffer Full?
77da3b867eSMike Smith  *  | | | | | | +--- Input Buffer Full?
78da3b867eSMike Smith  *  | | | | | +----- <reserved>
79da3b867eSMike Smith  *  | | | | +------- Data Register is Command Byte?
80da3b867eSMike Smith  *  | | | +--------- Burst Mode Enabled?
81da3b867eSMike Smith  *  | | +----------- SCI Event?
82da3b867eSMike Smith  *  | +------------- SMI Event?
83ef2374f7SNate Lawson  *  +--------------- <reserved>
84da3b867eSMike Smith  *
85da3b867eSMike Smith  */
86da3b867eSMike Smith typedef UINT8				EC_STATUS;
87da3b867eSMike Smith 
88da3b867eSMike Smith #define EC_FLAG_OUTPUT_BUFFER		((EC_STATUS) 0x01)
89da3b867eSMike Smith #define EC_FLAG_INPUT_BUFFER		((EC_STATUS) 0x02)
90ef2374f7SNate Lawson #define EC_FLAG_DATA_IS_CMD		((EC_STATUS) 0x08)
91da3b867eSMike Smith #define EC_FLAG_BURST_MODE		((EC_STATUS) 0x10)
92da3b867eSMike Smith 
93da3b867eSMike Smith /*
94da3b867eSMike Smith  * EC_EVENT:
95da3b867eSMike Smith  * ---------
96da3b867eSMike Smith  */
97da3b867eSMike Smith typedef UINT8				EC_EVENT;
98da3b867eSMike Smith 
99da3b867eSMike Smith #define EC_EVENT_UNKNOWN		((EC_EVENT) 0x00)
100da3b867eSMike Smith #define EC_EVENT_OUTPUT_BUFFER_FULL	((EC_EVENT) 0x01)
101da3b867eSMike Smith #define EC_EVENT_INPUT_BUFFER_EMPTY	((EC_EVENT) 0x02)
102da3b867eSMike Smith #define EC_EVENT_SCI			((EC_EVENT) 0x20)
103ef2374f7SNate Lawson #define EC_EVENT_SMI			((EC_EVENT) 0x40)
104ef2374f7SNate Lawson 
105ef2374f7SNate Lawson /* Data byte returned after burst enable indicating it was successful. */
106ef2374f7SNate Lawson #define EC_BURST_ACK			0x90
107da3b867eSMike Smith 
108da3b867eSMike Smith /*
109da3b867eSMike Smith  * Register access primitives
110da3b867eSMike Smith  */
111da3b867eSMike Smith #define EC_GET_DATA(sc)							\
112da3b867eSMike Smith 	bus_space_read_1((sc)->ec_data_tag, (sc)->ec_data_handle, 0)
113da3b867eSMike Smith 
114da3b867eSMike Smith #define EC_SET_DATA(sc, v)						\
115da3b867eSMike Smith 	bus_space_write_1((sc)->ec_data_tag, (sc)->ec_data_handle, 0, (v))
116da3b867eSMike Smith 
117da3b867eSMike Smith #define EC_GET_CSR(sc)							\
118da3b867eSMike Smith 	bus_space_read_1((sc)->ec_csr_tag, (sc)->ec_csr_handle, 0)
119da3b867eSMike Smith 
120da3b867eSMike Smith #define EC_SET_CSR(sc, v)						\
121da3b867eSMike Smith 	bus_space_write_1((sc)->ec_csr_tag, (sc)->ec_csr_handle, 0, (v))
122da3b867eSMike Smith 
1230025fb0fSNate Lawson /* Additional params to pass from the probe routine */
1240025fb0fSNate Lawson struct acpi_ec_params {
1250025fb0fSNate Lawson     int		glk;
1260025fb0fSNate Lawson     int		gpe_bit;
1270025fb0fSNate Lawson     ACPI_HANDLE	gpe_handle;
1280025fb0fSNate Lawson     int		uid;
1290025fb0fSNate Lawson };
1300025fb0fSNate Lawson 
131da3b867eSMike Smith /*
132da3b867eSMike Smith  * Driver softc.
133da3b867eSMike Smith  */
13415e32d5dSMike Smith struct acpi_ec_softc {
13515e32d5dSMike Smith     device_t		ec_dev;
13615e32d5dSMike Smith     ACPI_HANDLE		ec_handle;
1370025fb0fSNate Lawson     int			ec_uid;
1380025fb0fSNate Lawson     ACPI_HANDLE		ec_gpehandle;
1393a371f32SNate Lawson     UINT8		ec_gpebit;
14015e32d5dSMike Smith 
14115e32d5dSMike Smith     int			ec_data_rid;
14215e32d5dSMike Smith     struct resource	*ec_data_res;
14315e32d5dSMike Smith     bus_space_tag_t	ec_data_tag;
14415e32d5dSMike Smith     bus_space_handle_t	ec_data_handle;
14515e32d5dSMike Smith 
14615e32d5dSMike Smith     int			ec_csr_rid;
14715e32d5dSMike Smith     struct resource	*ec_csr_res;
14815e32d5dSMike Smith     bus_space_tag_t	ec_csr_tag;
14915e32d5dSMike Smith     bus_space_handle_t	ec_csr_handle;
15015e32d5dSMike Smith 
1511f04e8f5SNate Lawson     int			ec_glk;
1521f04e8f5SNate Lawson     int			ec_glkhandle;
153ef2374f7SNate Lawson     int			ec_burstactive;
154ef2374f7SNate Lawson     int			ec_sci_pend;
1555ff14fa9SAndriy Gapon     volatile u_int	ec_gencount;
1560bfeadedSTakanori Watanabe     int			ec_suspending;
15715e32d5dSMike Smith };
15815e32d5dSMike Smith 
1591f04e8f5SNate Lawson /*
160f4b7de15SNate Lawson  * XXX njl
1611f04e8f5SNate Lawson  * I couldn't find it in the spec but other implementations also use a
1621f04e8f5SNate Lawson  * value of 1 ms for the time to acquire global lock.
1631f04e8f5SNate Lawson  */
1641f04e8f5SNate Lawson #define EC_LOCK_TIMEOUT	1000
1654690674eSMitsuru IWASAKI 
166ef2374f7SNate Lawson /* Default delay in microseconds between each run of the status polling loop. */
1675ff14fa9SAndriy Gapon #define EC_POLL_DELAY	50
168ef2374f7SNate Lawson 
169ef2374f7SNate Lawson /* Total time in ms spent waiting for a response from EC. */
17083dcc133SNate Lawson #define EC_TIMEOUT	750
17115e32d5dSMike Smith 
172ff40920eSNate Lawson #define EVENT_READY(event, status)			\
173ff40920eSNate Lawson 	(((event) == EC_EVENT_OUTPUT_BUFFER_FULL &&	\
174ff40920eSNate Lawson 	 ((status) & EC_FLAG_OUTPUT_BUFFER) != 0) ||	\
175ff40920eSNate Lawson 	 ((event) == EC_EVENT_INPUT_BUFFER_EMPTY && 	\
176ff40920eSNate Lawson 	 ((status) & EC_FLAG_INPUT_BUFFER) == 0))
177ff40920eSNate Lawson 
178f4b7de15SNate Lawson ACPI_SERIAL_DECL(ec, "ACPI embedded controller");
179f4b7de15SNate Lawson 
1807029da5cSPawel Biernacki static SYSCTL_NODE(_debug_acpi, OID_AUTO, ec,
1817029da5cSPawel Biernacki     CTLFLAG_RD | CTLFLAG_MPSAFE, NULL,
1827029da5cSPawel Biernacki     "EC debugging");
183ef2374f7SNate Lawson 
184675e5627SNate Lawson static int	ec_burst_mode;
185af3b2549SHans Petter Selasky SYSCTL_INT(_debug_acpi_ec, OID_AUTO, burst, CTLFLAG_RWTUN, &ec_burst_mode, 0,
186ef2374f7SNate Lawson     "Enable use of burst mode (faster for nearly all systems)");
18783dcc133SNate Lawson static int	ec_polled_mode;
188af3b2549SHans Petter Selasky SYSCTL_INT(_debug_acpi_ec, OID_AUTO, polled, CTLFLAG_RWTUN, &ec_polled_mode, 0,
18983dcc133SNate Lawson     "Force use of polled mode (only if interrupt mode doesn't work)");
190ef2374f7SNate Lawson static int	ec_timeout = EC_TIMEOUT;
191af3b2549SHans Petter Selasky SYSCTL_INT(_debug_acpi_ec, OID_AUTO, timeout, CTLFLAG_RWTUN, &ec_timeout,
192ef2374f7SNate Lawson     EC_TIMEOUT, "Total time spent waiting for a response (poll+sleep)");
193ef2374f7SNate Lawson 
19483dcc133SNate Lawson static ACPI_STATUS
19583dcc133SNate Lawson EcLock(struct acpi_ec_softc *sc)
19615e32d5dSMike Smith {
197f4b7de15SNate Lawson     ACPI_STATUS	status;
19815e32d5dSMike Smith 
19935440dd3SNate Lawson     /* If _GLK is non-zero, acquire the global lock. */
20035440dd3SNate Lawson     status = AE_OK;
20135440dd3SNate Lawson     if (sc->ec_glk) {
20235440dd3SNate Lawson 	status = AcpiAcquireGlobalLock(EC_LOCK_TIMEOUT, &sc->ec_glkhandle);
20335440dd3SNate Lawson 	if (ACPI_FAILURE(status))
20435440dd3SNate Lawson 	    return (status);
20535440dd3SNate Lawson     }
206f4b7de15SNate Lawson     ACPI_SERIAL_BEGIN(ec);
20715e32d5dSMike Smith     return (status);
20815e32d5dSMike Smith }
20915e32d5dSMike Smith 
21083dcc133SNate Lawson static void
21115e32d5dSMike Smith EcUnlock(struct acpi_ec_softc *sc)
21215e32d5dSMike Smith {
213f4b7de15SNate Lawson     ACPI_SERIAL_END(ec);
21435440dd3SNate Lawson     if (sc->ec_glk)
21535440dd3SNate Lawson 	AcpiReleaseGlobalLock(sc->ec_glkhandle);
21615e32d5dSMike Smith }
21715e32d5dSMike Smith 
2185a77b11bSJung-uk Kim static UINT32		EcGpeHandler(ACPI_HANDLE, UINT32, void *);
21915e32d5dSMike Smith static ACPI_STATUS	EcSpaceSetup(ACPI_HANDLE Region, UINT32 Function,
22015e32d5dSMike Smith 				void *Context, void **return_Context);
221464c662eSNate Lawson static ACPI_STATUS	EcSpaceHandler(UINT32 Function,
222464c662eSNate Lawson 				ACPI_PHYSICAL_ADDRESS Address,
223e115a49fSJung-uk Kim 				UINT32 Width, UINT64 *Value,
22415e32d5dSMike Smith 				void *Context, void *RegionContext);
22583dcc133SNate Lawson static ACPI_STATUS	EcWaitEvent(struct acpi_ec_softc *sc, EC_EVENT Event,
22683dcc133SNate Lawson 				u_int gen_count);
2271f04e8f5SNate Lawson static ACPI_STATUS	EcCommand(struct acpi_ec_softc *sc, EC_COMMAND cmd);
228464c662eSNate Lawson static ACPI_STATUS	EcRead(struct acpi_ec_softc *sc, UINT8 Address,
229464c662eSNate Lawson 				UINT8 *Data);
230464c662eSNate Lawson static ACPI_STATUS	EcWrite(struct acpi_ec_softc *sc, UINT8 Address,
231e115a49fSJung-uk Kim 				UINT8 Data);
23215e32d5dSMike Smith static int		acpi_ec_probe(device_t dev);
23315e32d5dSMike Smith static int		acpi_ec_attach(device_t dev);
2340bfeadedSTakanori Watanabe static int		acpi_ec_suspend(device_t dev);
2350bfeadedSTakanori Watanabe static int		acpi_ec_resume(device_t dev);
236340a7f6aSNate Lawson static int		acpi_ec_shutdown(device_t dev);
237e33bea8dSNate Lawson static int		acpi_ec_read_method(device_t dev, u_int addr,
2389a179dd8SJung-uk Kim 				UINT64 *val, int width);
239e33bea8dSNate Lawson static int		acpi_ec_write_method(device_t dev, u_int addr,
2409a179dd8SJung-uk Kim 				UINT64 val, int width);
24115e32d5dSMike Smith 
24215e32d5dSMike Smith static device_method_t acpi_ec_methods[] = {
24315e32d5dSMike Smith     /* Device interface */
24415e32d5dSMike Smith     DEVMETHOD(device_probe,	acpi_ec_probe),
24515e32d5dSMike Smith     DEVMETHOD(device_attach,	acpi_ec_attach),
2460bfeadedSTakanori Watanabe     DEVMETHOD(device_suspend,	acpi_ec_suspend),
2470bfeadedSTakanori Watanabe     DEVMETHOD(device_resume,	acpi_ec_resume),
248340a7f6aSNate Lawson     DEVMETHOD(device_shutdown,	acpi_ec_shutdown),
24915e32d5dSMike Smith 
250e33bea8dSNate Lawson     /* Embedded controller interface */
251e33bea8dSNate Lawson     DEVMETHOD(acpi_ec_read,	acpi_ec_read_method),
252e33bea8dSNate Lawson     DEVMETHOD(acpi_ec_write,	acpi_ec_write_method),
253e33bea8dSNate Lawson 
25461bfd867SSofian Brabez     DEVMETHOD_END
25515e32d5dSMike Smith };
25615e32d5dSMike Smith 
25715e32d5dSMike Smith static driver_t acpi_ec_driver = {
25815e32d5dSMike Smith     "acpi_ec",
25915e32d5dSMike Smith     acpi_ec_methods,
26015e32d5dSMike Smith     sizeof(struct acpi_ec_softc),
26115e32d5dSMike Smith };
26215e32d5dSMike Smith 
263916a5d8aSJohn Baldwin DRIVER_MODULE(acpi_ec, acpi, acpi_ec_driver, 0, 0);
26464278df5SNate Lawson MODULE_DEPEND(acpi_ec, acpi, 1, 1, 1);
26515e32d5dSMike Smith 
26615e32d5dSMike Smith /*
267f8335e3aSNate Lawson  * Look for an ECDT and if we find one, set up default GPE and
268f8335e3aSNate Lawson  * space handlers to catch attempts to access EC space before
26915e32d5dSMike Smith  * we have a real driver instance in place.
27083dcc133SNate Lawson  *
27183dcc133SNate Lawson  * TODO: Some old Gateway laptops need us to fake up an ECDT or
27283dcc133SNate Lawson  * otherwise attach early so that _REG methods can run.
27315e32d5dSMike Smith  */
274f8335e3aSNate Lawson void
275f8335e3aSNate Lawson acpi_ec_ecdt_probe(device_t parent)
27615e32d5dSMike Smith {
277f8335e3aSNate Lawson     ACPI_TABLE_ECDT *ecdt;
278f8335e3aSNate Lawson     ACPI_STATUS	     status;
279f8335e3aSNate Lawson     device_t	     child;
280f8335e3aSNate Lawson     ACPI_HANDLE	     h;
2810025fb0fSNate Lawson     struct acpi_ec_params *params;
282f8335e3aSNate Lawson 
283b4a05238SPeter Wemm     ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__);
28415e32d5dSMike Smith 
285f8335e3aSNate Lawson     /* Find and validate the ECDT. */
2862be4e471SJung-uk Kim     status = AcpiGetTable(ACPI_SIG_ECDT, 1, (ACPI_TABLE_HEADER **)&ecdt);
287f8335e3aSNate Lawson     if (ACPI_FAILURE(status) ||
2882be4e471SJung-uk Kim 	ecdt->Control.BitWidth != 8 ||
2892be4e471SJung-uk Kim 	ecdt->Data.BitWidth != 8) {
290f8335e3aSNate Lawson 	return;
29115e32d5dSMike Smith     }
29215e32d5dSMike Smith 
293f8335e3aSNate Lawson     /* Create the child device with the given unit number. */
294404b0d10SJung-uk Kim     child = BUS_ADD_CHILD(parent, 3, "acpi_ec", ecdt->Uid);
295f8335e3aSNate Lawson     if (child == NULL) {
2960025fb0fSNate Lawson 	printf("%s: can't add child\n", __func__);
297f8335e3aSNate Lawson 	return;
298f8335e3aSNate Lawson     }
299f8335e3aSNate Lawson 
300f8335e3aSNate Lawson     /* Find and save the ACPI handle for this device. */
3012be4e471SJung-uk Kim     status = AcpiGetHandle(NULL, ecdt->Id, &h);
302f8335e3aSNate Lawson     if (ACPI_FAILURE(status)) {
303f8335e3aSNate Lawson 	device_delete_child(parent, child);
3040025fb0fSNate Lawson 	printf("%s: can't get handle\n", __func__);
305f8335e3aSNate Lawson 	return;
306f8335e3aSNate Lawson     }
307f8335e3aSNate Lawson     acpi_set_handle(child, h);
308f8335e3aSNate Lawson 
309f8335e3aSNate Lawson     /* Set the data and CSR register addresses. */
3102be4e471SJung-uk Kim     bus_set_resource(child, SYS_RES_IOPORT, 0, ecdt->Data.Address,
311f8335e3aSNate Lawson 	/*count*/1);
3122be4e471SJung-uk Kim     bus_set_resource(child, SYS_RES_IOPORT, 1, ecdt->Control.Address,
313f8335e3aSNate Lawson 	/*count*/1);
314f8335e3aSNate Lawson 
31515e32d5dSMike Smith     /*
316f8335e3aSNate Lawson      * Store values for the probe/attach routines to use.  Store the
317c868ac7dSNate Lawson      * ECDT GPE bit and set the global lock flag according to _GLK.
3180025fb0fSNate Lawson      * Note that it is not perfectly correct to be evaluating a method
3190025fb0fSNate Lawson      * before initializing devices, but in practice this function
3200025fb0fSNate Lawson      * should be safe to call at this point.
32115e32d5dSMike Smith      */
3220025fb0fSNate Lawson     params = malloc(sizeof(struct acpi_ec_params), M_TEMP, M_WAITOK | M_ZERO);
3230025fb0fSNate Lawson     params->gpe_handle = NULL;
3242be4e471SJung-uk Kim     params->gpe_bit = ecdt->Gpe;
3252be4e471SJung-uk Kim     params->uid = ecdt->Uid;
3260025fb0fSNate Lawson     acpi_GetInteger(h, "_GLK", &params->glk);
3270025fb0fSNate Lawson     acpi_set_private(child, params);
328f8335e3aSNate Lawson 
329f8335e3aSNate Lawson     /* Finish the attach process. */
330f8335e3aSNate Lawson     if (device_probe_and_attach(child) != 0)
331f8335e3aSNate Lawson 	device_delete_child(parent, child);
332f8335e3aSNate Lawson }
333f8335e3aSNate Lawson 
33415e32d5dSMike Smith static int
33515e32d5dSMike Smith acpi_ec_probe(device_t dev)
33615e32d5dSMike Smith {
3370025fb0fSNate Lawson     ACPI_BUFFER buf;
338f8335e3aSNate Lawson     ACPI_HANDLE h;
3390025fb0fSNate Lawson     ACPI_OBJECT *obj;
340f8335e3aSNate Lawson     ACPI_STATUS status;
341f8335e3aSNate Lawson     device_t	peer;
342f6eb382cSAndriy Gapon     int		ecdt;
3434aed5630SConrad Meyer     int		ret, rc;
3440025fb0fSNate Lawson     struct acpi_ec_params *params;
3455fcc8a58SNate Lawson     static char *ec_ids[] = { "PNP0C09", NULL };
3460ae55423SMike Smith 
3471a305bdaSBen Widawsky     ret = ENXIO;
3481a305bdaSBen Widawsky 
349c72508e2SNate Lawson     /* Check that this is a device and that EC is not disabled. */
350c72508e2SNate Lawson     if (acpi_get_type(dev) != ACPI_TYPE_DEVICE || acpi_disabled("ec"))
3511a305bdaSBen Widawsky 	return (ret);
35215e32d5dSMike Smith 
3531a305bdaSBen Widawsky     if (device_is_devclass_fixed(dev)) {
35415e32d5dSMike Smith 	/*
3551a305bdaSBen Widawsky 	 * If probed via ECDT, set description and continue. Otherwise, we can
3561a305bdaSBen Widawsky 	 * access the namespace and make sure this is not a duplicate probe.
35715e32d5dSMike Smith 	 */
358f6eb382cSAndriy Gapon         ecdt = 1;
3591a305bdaSBen Widawsky         params = acpi_get_private(dev);
3601a305bdaSBen Widawsky 	if (params != NULL)
3611f04e8f5SNate Lawson 	    ret = 0;
3621a305bdaSBen Widawsky 
3631a305bdaSBen Widawsky 	goto out;
364ec60b7f9SBen Widawsky     } else
365ec60b7f9SBen Widawsky 	ecdt = 0;
3661a305bdaSBen Widawsky 
3674aed5630SConrad Meyer     rc = ACPI_ID_PROBE(device_get_parent(dev), dev, ec_ids, NULL);
3684aed5630SConrad Meyer     if (rc > 0)
3694aed5630SConrad Meyer 	return (rc);
3701a305bdaSBen Widawsky 
3711a305bdaSBen Widawsky     params = malloc(sizeof(struct acpi_ec_params), M_TEMP, M_WAITOK | M_ZERO);
3721a305bdaSBen Widawsky 
3731a305bdaSBen Widawsky     buf.Pointer = NULL;
3741a305bdaSBen Widawsky     buf.Length = ACPI_ALLOCATE_BUFFER;
375f8335e3aSNate Lawson     h = acpi_get_handle(dev);
376f8335e3aSNate Lawson 
377f8335e3aSNate Lawson     /*
3781a305bdaSBen Widawsky      * Read the unit ID to check for duplicate attach and the global lock value
3791a305bdaSBen Widawsky      * to see if we should acquire it when accessing the EC.
380f8335e3aSNate Lawson      */
3810025fb0fSNate Lawson     status = acpi_GetInteger(h, "_UID", &params->uid);
382f8335e3aSNate Lawson     if (ACPI_FAILURE(status))
3830025fb0fSNate Lawson 	params->uid = 0;
3841a305bdaSBen Widawsky 
385ec60b7f9SBen Widawsky     /*
386ec60b7f9SBen Widawsky      * Check for a duplicate probe. This can happen when a probe via ECDT
387ec60b7f9SBen Widawsky      * succeeded already. If this is a duplicate, disable this device.
388ec60b7f9SBen Widawsky      *
389ec60b7f9SBen Widawsky      * NB: It would seem device_disable would be sufficient to not get
390ec60b7f9SBen Widawsky      * duplicated devices, and ENXIO isn't needed, however, device_probe() only
391ec60b7f9SBen Widawsky      * checks DF_ENABLED at the start and so disabling it here is too late to
392ec60b7f9SBen Widawsky      * prevent device_attach() from being called.
393ec60b7f9SBen Widawsky      */
39497c076d2SJohn Baldwin     peer = devclass_get_device(device_get_devclass(dev), params->uid);
395ec60b7f9SBen Widawsky     if (peer != NULL && device_is_alive(peer)) {
396ec60b7f9SBen Widawsky 	device_disable(dev);
397ec60b7f9SBen Widawsky 	goto out;
398ec60b7f9SBen Widawsky     }
399ec60b7f9SBen Widawsky 
4000025fb0fSNate Lawson     status = acpi_GetInteger(h, "_GLK", &params->glk);
401f8335e3aSNate Lawson     if (ACPI_FAILURE(status))
4020025fb0fSNate Lawson 	params->glk = 0;
403f8335e3aSNate Lawson 
404f8335e3aSNate Lawson     /*
4051a305bdaSBen Widawsky      * Evaluate the _GPE method to find the GPE bit used by the EC to signal
4061a305bdaSBen Widawsky      * status (SCI).  If it's a package, it contains a reference and GPE bit,
4071a305bdaSBen Widawsky      * similar to _PRW.
408f8335e3aSNate Lawson      */
4090025fb0fSNate Lawson     status = AcpiEvaluateObject(h, "_GPE", NULL, &buf);
410f8335e3aSNate Lawson     if (ACPI_FAILURE(status)) {
4111a305bdaSBen Widawsky 	device_printf(dev, "can't evaluate _GPE - %s\n", AcpiFormatException(status));
412a6761eb3SNate Lawson 	goto out;
413f8335e3aSNate Lawson     }
4141a305bdaSBen Widawsky 
4150025fb0fSNate Lawson     obj = (ACPI_OBJECT *)buf.Pointer;
4160025fb0fSNate Lawson     if (obj == NULL)
417a6761eb3SNate Lawson 	goto out;
4180025fb0fSNate Lawson 
4190025fb0fSNate Lawson     switch (obj->Type) {
4200025fb0fSNate Lawson     case ACPI_TYPE_INTEGER:
4210025fb0fSNate Lawson 	params->gpe_handle = NULL;
4220025fb0fSNate Lawson 	params->gpe_bit = obj->Integer.Value;
4230025fb0fSNate Lawson 	break;
4240025fb0fSNate Lawson     case ACPI_TYPE_PACKAGE:
4250025fb0fSNate Lawson 	if (!ACPI_PKG_VALID(obj, 2))
4260025fb0fSNate Lawson 	    goto out;
4271a305bdaSBen Widawsky 	params->gpe_handle = acpi_GetReference(NULL, &obj->Package.Elements[0]);
4280025fb0fSNate Lawson 	if (params->gpe_handle == NULL ||
4290025fb0fSNate Lawson 	    acpi_PkgInt32(obj, 1, &params->gpe_bit) != 0)
4300025fb0fSNate Lawson 		goto out;
4310025fb0fSNate Lawson 	break;
4320025fb0fSNate Lawson     default:
4330025fb0fSNate Lawson 	device_printf(dev, "_GPE has invalid type %d\n", obj->Type);
4340025fb0fSNate Lawson 	goto out;
4350025fb0fSNate Lawson     }
436f8335e3aSNate Lawson 
437f8335e3aSNate Lawson     /* Store the values we got from the namespace for attach. */
4380025fb0fSNate Lawson     acpi_set_private(dev, params);
439f8335e3aSNate Lawson 
4401a305bdaSBen Widawsky     if (buf.Pointer)
4411a305bdaSBen Widawsky 	AcpiOsFree(buf.Pointer);
442401ae7caSConrad Meyer 
443401ae7caSConrad Meyer     ret = rc;
4440025fb0fSNate Lawson out:
4455efca36fSTakanori Watanabe     if (ret <= 0) {
446*bad36a49SMark Johnston 	device_set_descf(dev, "Embedded Controller: GPE %#x%s%s",
4470025fb0fSNate Lawson 			 params->gpe_bit, (params->glk) ? ", GLK" : "",
448f6eb382cSAndriy Gapon 			 ecdt ? ", ECDT" : "");
4492f977ab4SJung-uk Kim     } else
4500025fb0fSNate Lawson 	free(params, M_TEMP);
4511a305bdaSBen Widawsky 
4521f04e8f5SNate Lawson     return (ret);
45315e32d5dSMike Smith }
45415e32d5dSMike Smith 
45515e32d5dSMike Smith static int
45615e32d5dSMike Smith acpi_ec_attach(device_t dev)
45715e32d5dSMike Smith {
45815e32d5dSMike Smith     struct acpi_ec_softc	*sc;
4590025fb0fSNate Lawson     struct acpi_ec_params	*params;
46015e32d5dSMike Smith     ACPI_STATUS			Status;
461dbd0058aSMike Smith 
462b4a05238SPeter Wemm     ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__);
4630ae55423SMike Smith 
4641f04e8f5SNate Lawson     /* Fetch/initialize softc (assumes softc is pre-zeroed). */
46515e32d5dSMike Smith     sc = device_get_softc(dev);
4660025fb0fSNate Lawson     params = acpi_get_private(dev);
46715e32d5dSMike Smith     sc->ec_dev = dev;
46815e32d5dSMike Smith     sc->ec_handle = acpi_get_handle(dev);
46915e32d5dSMike Smith 
470f8335e3aSNate Lawson     /* Retrieve previously probed values via device ivars. */
4710025fb0fSNate Lawson     sc->ec_glk = params->glk;
4720025fb0fSNate Lawson     sc->ec_gpebit = params->gpe_bit;
4730025fb0fSNate Lawson     sc->ec_gpehandle = params->gpe_handle;
4740025fb0fSNate Lawson     sc->ec_uid = params->uid;
47568fb6c48STakanori Watanabe     sc->ec_suspending = FALSE;
476943124d3SAndriy Gapon     acpi_set_private(dev, NULL);
4770025fb0fSNate Lawson     free(params, M_TEMP);
478f8335e3aSNate Lawson 
4791f04e8f5SNate Lawson     /* Attach bus resources for data and command/status ports. */
48015e32d5dSMike Smith     sc->ec_data_rid = 0;
4815f96beb9SNate Lawson     sc->ec_data_res = bus_alloc_resource_any(sc->ec_dev, SYS_RES_IOPORT,
4825f96beb9SNate Lawson 			&sc->ec_data_rid, RF_ACTIVE);
483464c662eSNate Lawson     if (sc->ec_data_res == NULL) {
48415e32d5dSMike Smith 	device_printf(dev, "can't allocate data port\n");
485f3fc4f8bSNate Lawson 	goto error;
48615e32d5dSMike Smith     }
48715e32d5dSMike Smith     sc->ec_data_tag = rman_get_bustag(sc->ec_data_res);
48815e32d5dSMike Smith     sc->ec_data_handle = rman_get_bushandle(sc->ec_data_res);
48915e32d5dSMike Smith 
49015e32d5dSMike Smith     sc->ec_csr_rid = 1;
4915f96beb9SNate Lawson     sc->ec_csr_res = bus_alloc_resource_any(sc->ec_dev, SYS_RES_IOPORT,
4925f96beb9SNate Lawson 			&sc->ec_csr_rid, RF_ACTIVE);
493464c662eSNate Lawson     if (sc->ec_csr_res == NULL) {
49415e32d5dSMike Smith 	device_printf(dev, "can't allocate command/status port\n");
495f3fc4f8bSNate Lawson 	goto error;
49615e32d5dSMike Smith     }
49715e32d5dSMike Smith     sc->ec_csr_tag = rman_get_bustag(sc->ec_csr_res);
49815e32d5dSMike Smith     sc->ec_csr_handle = rman_get_bushandle(sc->ec_csr_res);
49915e32d5dSMike Smith 
50015e32d5dSMike Smith     /*
5011f04e8f5SNate Lawson      * Install a handler for this EC's GPE bit.  We want edge-triggered
5021f04e8f5SNate Lawson      * behavior.
50315e32d5dSMike Smith      */
5041f04e8f5SNate Lawson     ACPI_DEBUG_PRINT((ACPI_DB_RESOURCES, "attaching GPE handler\n"));
5050025fb0fSNate Lawson     Status = AcpiInstallGpeHandler(sc->ec_gpehandle, sc->ec_gpebit,
5065a77b11bSJung-uk Kim 		ACPI_GPE_EDGE_TRIGGERED, EcGpeHandler, sc);
507464c662eSNate Lawson     if (ACPI_FAILURE(Status)) {
50876d1dff4SMike Smith 	device_printf(dev, "can't install GPE handler for %s - %s\n",
509bfae45aaSMike Smith 		      acpi_name(sc->ec_handle), AcpiFormatException(Status));
510f3fc4f8bSNate Lawson 	goto error;
51115e32d5dSMike Smith     }
51215e32d5dSMike Smith 
51315e32d5dSMike Smith     /*
51415e32d5dSMike Smith      * Install address space handler
51515e32d5dSMike Smith      */
5164c1cdee6SMike Smith     ACPI_DEBUG_PRINT((ACPI_DB_RESOURCES, "attaching address space handler\n"));
517464c662eSNate Lawson     Status = AcpiInstallAddressSpaceHandler(sc->ec_handle, ACPI_ADR_SPACE_EC,
5181f04e8f5SNate Lawson 		&EcSpaceHandler, &EcSpaceSetup, sc);
519464c662eSNate Lawson     if (ACPI_FAILURE(Status)) {
52076d1dff4SMike Smith 	device_printf(dev, "can't install address space handler for %s - %s\n",
521bfae45aaSMike Smith 		      acpi_name(sc->ec_handle), AcpiFormatException(Status));
522f3fc4f8bSNate Lawson 	goto error;
523f3fc4f8bSNate Lawson     }
524f3fc4f8bSNate Lawson 
525f3fc4f8bSNate Lawson     /* Enable runtime GPEs for the handler. */
526a88e22b7SJung-uk Kim     Status = AcpiEnableGpe(sc->ec_gpehandle, sc->ec_gpebit);
527f3fc4f8bSNate Lawson     if (ACPI_FAILURE(Status)) {
528f3fc4f8bSNate Lawson 	device_printf(dev, "AcpiEnableGpe failed: %s\n",
529f3fc4f8bSNate Lawson 		      AcpiFormatException(Status));
530f3fc4f8bSNate Lawson 	goto error;
53115e32d5dSMike Smith     }
5321f04e8f5SNate Lawson 
5331f04e8f5SNate Lawson     ACPI_DEBUG_PRINT((ACPI_DB_RESOURCES, "acpi_ec_attach complete\n"));
5341f04e8f5SNate Lawson     return (0);
535464c662eSNate Lawson 
536f3fc4f8bSNate Lawson error:
5375a77b11bSJung-uk Kim     AcpiRemoveGpeHandler(sc->ec_gpehandle, sc->ec_gpebit, EcGpeHandler);
538f3fc4f8bSNate Lawson     AcpiRemoveAddressSpaceHandler(sc->ec_handle, ACPI_ADR_SPACE_EC,
539f3fc4f8bSNate Lawson 	EcSpaceHandler);
540f8372adeSTakanori Watanabe     if (sc->ec_csr_res)
541f8372adeSTakanori Watanabe 	bus_release_resource(sc->ec_dev, SYS_RES_IOPORT, sc->ec_csr_rid,
542f8372adeSTakanori Watanabe 			     sc->ec_csr_res);
543f8372adeSTakanori Watanabe     if (sc->ec_data_res)
544f8372adeSTakanori Watanabe 	bus_release_resource(sc->ec_dev, SYS_RES_IOPORT, sc->ec_data_rid,
545f8372adeSTakanori Watanabe 			     sc->ec_data_res);
546f3fc4f8bSNate Lawson     return (ENXIO);
5471f04e8f5SNate Lawson }
5481f04e8f5SNate Lawson 
549340a7f6aSNate Lawson static int
5500bfeadedSTakanori Watanabe acpi_ec_suspend(device_t dev)
5510bfeadedSTakanori Watanabe {
5520bfeadedSTakanori Watanabe     struct acpi_ec_softc	*sc;
5530bfeadedSTakanori Watanabe 
5540bfeadedSTakanori Watanabe     sc = device_get_softc(dev);
55568fb6c48STakanori Watanabe     sc->ec_suspending = TRUE;
5560bfeadedSTakanori Watanabe     return (0);
5570bfeadedSTakanori Watanabe }
5580bfeadedSTakanori Watanabe 
5590bfeadedSTakanori Watanabe static int
5600bfeadedSTakanori Watanabe acpi_ec_resume(device_t dev)
5610bfeadedSTakanori Watanabe {
5620bfeadedSTakanori Watanabe     struct acpi_ec_softc	*sc;
5630bfeadedSTakanori Watanabe 
5640bfeadedSTakanori Watanabe     sc = device_get_softc(dev);
56568fb6c48STakanori Watanabe     sc->ec_suspending = FALSE;
5660bfeadedSTakanori Watanabe     return (0);
5670bfeadedSTakanori Watanabe }
5680bfeadedSTakanori Watanabe 
5690bfeadedSTakanori Watanabe static int
570340a7f6aSNate Lawson acpi_ec_shutdown(device_t dev)
571340a7f6aSNate Lawson {
572340a7f6aSNate Lawson     struct acpi_ec_softc	*sc;
573340a7f6aSNate Lawson 
574340a7f6aSNate Lawson     /* Disable the GPE so we don't get EC events during shutdown. */
575340a7f6aSNate Lawson     sc = device_get_softc(dev);
576a88e22b7SJung-uk Kim     AcpiDisableGpe(sc->ec_gpehandle, sc->ec_gpebit);
577340a7f6aSNate Lawson     return (0);
578340a7f6aSNate Lawson }
579340a7f6aSNate Lawson 
580e33bea8dSNate Lawson /* Methods to allow other devices (e.g., smbat) to read/write EC space. */
581e33bea8dSNate Lawson static int
5829a179dd8SJung-uk Kim acpi_ec_read_method(device_t dev, u_int addr, UINT64 *val, int width)
583e33bea8dSNate Lawson {
584e33bea8dSNate Lawson     struct acpi_ec_softc *sc;
585e33bea8dSNate Lawson     ACPI_STATUS status;
586e33bea8dSNate Lawson 
587e33bea8dSNate Lawson     sc = device_get_softc(dev);
588e33bea8dSNate Lawson     status = EcSpaceHandler(ACPI_READ, addr, width * 8, val, sc, NULL);
589e33bea8dSNate Lawson     if (ACPI_FAILURE(status))
590e33bea8dSNate Lawson 	return (ENXIO);
591e33bea8dSNate Lawson     return (0);
592e33bea8dSNate Lawson }
593e33bea8dSNate Lawson 
594e33bea8dSNate Lawson static int
5959a179dd8SJung-uk Kim acpi_ec_write_method(device_t dev, u_int addr, UINT64 val, int width)
596e33bea8dSNate Lawson {
597e33bea8dSNate Lawson     struct acpi_ec_softc *sc;
598e33bea8dSNate Lawson     ACPI_STATUS status;
599e33bea8dSNate Lawson 
600e33bea8dSNate Lawson     sc = device_get_softc(dev);
601e33bea8dSNate Lawson     status = EcSpaceHandler(ACPI_WRITE, addr, width * 8, &val, sc, NULL);
602e33bea8dSNate Lawson     if (ACPI_FAILURE(status))
603e33bea8dSNate Lawson 	return (ENXIO);
604e33bea8dSNate Lawson     return (0);
605e33bea8dSNate Lawson }
606e33bea8dSNate Lawson 
6075ff14fa9SAndriy Gapon static ACPI_STATUS
6085ff14fa9SAndriy Gapon EcCheckStatus(struct acpi_ec_softc *sc, const char *msg, EC_EVENT event)
6095ff14fa9SAndriy Gapon {
6105ff14fa9SAndriy Gapon     ACPI_STATUS status;
6115ff14fa9SAndriy Gapon     EC_STATUS ec_status;
6125ff14fa9SAndriy Gapon 
6135ff14fa9SAndriy Gapon     status = AE_NO_HARDWARE_RESPONSE;
6145ff14fa9SAndriy Gapon     ec_status = EC_GET_CSR(sc);
6155ff14fa9SAndriy Gapon     if (sc->ec_burstactive && !(ec_status & EC_FLAG_BURST_MODE)) {
6165ff14fa9SAndriy Gapon 	CTR1(KTR_ACPI, "ec burst disabled in waitevent (%s)", msg);
6175ff14fa9SAndriy Gapon 	sc->ec_burstactive = FALSE;
6185ff14fa9SAndriy Gapon     }
6195ff14fa9SAndriy Gapon     if (EVENT_READY(event, ec_status)) {
6205ff14fa9SAndriy Gapon 	CTR2(KTR_ACPI, "ec %s wait ready, status %#x", msg, ec_status);
6215ff14fa9SAndriy Gapon 	status = AE_OK;
6225ff14fa9SAndriy Gapon     }
6235ff14fa9SAndriy Gapon     return (status);
6245ff14fa9SAndriy Gapon }
6255ff14fa9SAndriy Gapon 
62615e32d5dSMike Smith static void
627c6e6b4feSHans Petter Selasky EcGpeQueryHandlerSub(struct acpi_ec_softc *sc)
62815e32d5dSMike Smith {
62915e32d5dSMike Smith     UINT8			Data;
63015e32d5dSMike Smith     ACPI_STATUS			Status;
6314552fccbSJung-uk Kim     int				retry;
63215e32d5dSMike Smith     char			qxx[5];
63315e32d5dSMike Smith 
634b4a05238SPeter Wemm     ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__);
63515e32d5dSMike Smith 
636ef2374f7SNate Lawson     /* Serialize user access with EcSpaceHandler(). */
63783dcc133SNate Lawson     Status = EcLock(sc);
6383a371f32SNate Lawson     if (ACPI_FAILURE(Status)) {
63983dcc133SNate Lawson 	device_printf(sc->ec_dev, "GpeQuery lock error: %s\n",
64083dcc133SNate Lawson 	    AcpiFormatException(Status));
6413a371f32SNate Lawson 	return;
6423a371f32SNate Lawson     }
6433a371f32SNate Lawson 
64415e32d5dSMike Smith     /*
6453a371f32SNate Lawson      * Send a query command to the EC to find out which _Qxx call it
6463a371f32SNate Lawson      * wants to make.  This command clears the SCI bit and also the
64783dcc133SNate Lawson      * interrupt source since we are edge-triggered.  To prevent the GPE
64883dcc133SNate Lawson      * that may arise from running the query from causing another query
64983dcc133SNate Lawson      * to be queued, we clear the pending flag only after running it.
6503a371f32SNate Lawson      */
6515ff14fa9SAndriy Gapon     for (retry = 0; retry < 2; retry++) {
6523a371f32SNate Lawson 	Status = EcCommand(sc, EC_COMMAND_QUERY);
6535ff14fa9SAndriy Gapon 	if (ACPI_SUCCESS(Status))
6545ff14fa9SAndriy Gapon 	    break;
655ae1ef64fSJung-uk Kim 	if (ACPI_FAILURE(EcCheckStatus(sc, "retr_check",
6569ad56977SJung-uk Kim 	    EC_EVENT_INPUT_BUFFER_EMPTY)))
6575ff14fa9SAndriy Gapon 	    break;
6585ff14fa9SAndriy Gapon     }
659dbd0058aSMike Smith     if (ACPI_FAILURE(Status)) {
6603a371f32SNate Lawson 	EcUnlock(sc);
66183dcc133SNate Lawson 	device_printf(sc->ec_dev, "GPE query failed: %s\n",
66283dcc133SNate Lawson 	    AcpiFormatException(Status));
66383dcc133SNate Lawson 	return;
66415e32d5dSMike Smith     }
6653a371f32SNate Lawson     Data = EC_GET_DATA(sc);
666ef2374f7SNate Lawson 
66783dcc133SNate Lawson     /*
66883dcc133SNate Lawson      * We have to unlock before running the _Qxx method below since that
66983dcc133SNate Lawson      * method may attempt to read/write from EC address space, causing
67083dcc133SNate Lawson      * recursive acquisition of the lock.
67183dcc133SNate Lawson      */
6723a371f32SNate Lawson     EcUnlock(sc);
67315e32d5dSMike Smith 
6741f04e8f5SNate Lawson     /* Ignore the value for "no outstanding event". (13.3.5) */
67583dcc133SNate Lawson     CTR2(KTR_ACPI, "ec query ok,%s running _Q%02X", Data ? "" : " not", Data);
6761f04e8f5SNate Lawson     if (Data == 0)
67783dcc133SNate Lawson 	return;
6781f04e8f5SNate Lawson 
6791f04e8f5SNate Lawson     /* Evaluate _Qxx to respond to the controller. */
68083dcc133SNate Lawson     snprintf(qxx, sizeof(qxx), "_Q%02X", Data);
681b3919c8dSMark Santcroos     AcpiUtStrupr(qxx);
682ee785aa9SJohn Baldwin     Status = AcpiEvaluateObject(sc->ec_handle, qxx, NULL, NULL);
6831f04e8f5SNate Lawson     if (ACPI_FAILURE(Status) && Status != AE_NOT_FOUND) {
68483dcc133SNate Lawson 	device_printf(sc->ec_dev, "evaluation of query method %s failed: %s\n",
685bfae45aaSMike Smith 	    qxx, AcpiFormatException(Status));
68615e32d5dSMike Smith     }
687c07572e7STakanori Watanabe }
68842f6d122SMike Smith 
689c6e6b4feSHans Petter Selasky static void
690c6e6b4feSHans Petter Selasky EcGpeQueryHandler(void *Context)
691c6e6b4feSHans Petter Selasky {
692c6e6b4feSHans Petter Selasky     struct acpi_ec_softc *sc = (struct acpi_ec_softc *)Context;
693c6e6b4feSHans Petter Selasky     int pending;
694c6e6b4feSHans Petter Selasky 
695c6e6b4feSHans Petter Selasky     KASSERT(Context != NULL, ("EcGpeQueryHandler called with NULL"));
696c6e6b4feSHans Petter Selasky 
697c6e6b4feSHans Petter Selasky     do {
698c6e6b4feSHans Petter Selasky 	/* Read the current pending count */
699c6e6b4feSHans Petter Selasky 	pending = atomic_load_acq_int(&sc->ec_sci_pend);
700c6e6b4feSHans Petter Selasky 
701c6e6b4feSHans Petter Selasky 	/* Call GPE handler function */
702c6e6b4feSHans Petter Selasky 	EcGpeQueryHandlerSub(sc);
703c6e6b4feSHans Petter Selasky 
704c6e6b4feSHans Petter Selasky 	/*
705c6e6b4feSHans Petter Selasky 	 * Try to reset the pending count to zero. If this fails we
706c6e6b4feSHans Petter Selasky 	 * know another GPE event has occurred while handling the
707c6e6b4feSHans Petter Selasky 	 * current GPE event and need to loop.
708c6e6b4feSHans Petter Selasky 	 */
709c6e6b4feSHans Petter Selasky     } while (!atomic_cmpset_int(&sc->ec_sci_pend, pending, 0));
710c6e6b4feSHans Petter Selasky }
711c6e6b4feSHans Petter Selasky 
712a9cf0dffSMike Smith /*
71383dcc133SNate Lawson  * The GPE handler is called when IBE/OBF or SCI events occur.  We are
71483dcc133SNate Lawson  * called from an unknown lock context.
715a9cf0dffSMike Smith  */
7165a77b11bSJung-uk Kim static UINT32
7175a77b11bSJung-uk Kim EcGpeHandler(ACPI_HANDLE GpeDevice, UINT32 GpeNumber, void *Context)
718c07572e7STakanori Watanabe {
719c07572e7STakanori Watanabe     struct acpi_ec_softc *sc = Context;
7201f04e8f5SNate Lawson     ACPI_STATUS		       Status;
721ef2374f7SNate Lawson     EC_STATUS		       EcStatus;
722a9cf0dffSMike Smith 
7231f04e8f5SNate Lawson     KASSERT(Context != NULL, ("EcGpeHandler called with NULL"));
72483dcc133SNate Lawson     CTR0(KTR_ACPI, "ec gpe handler start");
7251f04e8f5SNate Lawson 
7261395b555SNate Lawson     /*
72783dcc133SNate Lawson      * Notify EcWaitEvent() that the status register is now fresh.  If we
72883dcc133SNate Lawson      * didn't do this, it wouldn't be possible to distinguish an old IBE
72983dcc133SNate Lawson      * from a new one, for example when doing a write transaction (writing
73083dcc133SNate Lawson      * address and then data values.)
7311395b555SNate Lawson      */
73283dcc133SNate Lawson     atomic_add_int(&sc->ec_gencount, 1);
73380b1151eSJung-uk Kim     wakeup(sc);
734ef2374f7SNate Lawson 
735ef2374f7SNate Lawson     /*
73683dcc133SNate Lawson      * If the EC_SCI bit of the status register is set, queue a query handler.
73783dcc133SNate Lawson      * It will run the query and _Qxx method later, under the lock.
738ef2374f7SNate Lawson      */
739ef2374f7SNate Lawson     EcStatus = EC_GET_CSR(sc);
740c6e6b4feSHans Petter Selasky     if ((EcStatus & EC_EVENT_SCI) &&
741c6e6b4feSHans Petter Selasky 	atomic_fetchadd_int(&sc->ec_sci_pend, 1) == 0) {
74283dcc133SNate Lawson 	CTR0(KTR_ACPI, "ec gpe queueing query handler");
7432be4e471SJung-uk Kim 	Status = AcpiOsExecute(OSL_GPE_HANDLER, EcGpeQueryHandler, Context);
744c6e6b4feSHans Petter Selasky 	if (ACPI_FAILURE(Status)) {
74583dcc133SNate Lawson 	    printf("EcGpeHandler: queuing GPE query handler failed\n");
746c6e6b4feSHans Petter Selasky 	    atomic_store_rel_int(&sc->ec_sci_pend, 0);
747c6e6b4feSHans Petter Selasky 	}
7486e141df2SNate Lawson     }
7495a77b11bSJung-uk Kim     return (ACPI_REENABLE_GPE);
75015e32d5dSMike Smith }
75115e32d5dSMike Smith 
75215e32d5dSMike Smith static ACPI_STATUS
753464c662eSNate Lawson EcSpaceSetup(ACPI_HANDLE Region, UINT32 Function, void *Context,
754464c662eSNate Lawson 	     void **RegionContext)
75515e32d5dSMike Smith {
75642f6d122SMike Smith 
757b4a05238SPeter Wemm     ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__);
75842f6d122SMike Smith 
75915e32d5dSMike Smith     /*
76016844a97SNate Lawson      * If deactivating a region, always set the output to NULL.  Otherwise,
76116844a97SNate Lawson      * just pass the context through.
76215e32d5dSMike Smith      */
76316844a97SNate Lawson     if (Function == ACPI_REGION_DEACTIVATE)
76416844a97SNate Lawson 	*RegionContext = NULL;
76516844a97SNate Lawson     else
76615e32d5dSMike Smith 	*RegionContext = Context;
76715e32d5dSMike Smith 
76842f6d122SMike Smith     return_ACPI_STATUS (AE_OK);
76915e32d5dSMike Smith }
77015e32d5dSMike Smith 
77115e32d5dSMike Smith static ACPI_STATUS
772e115a49fSJung-uk Kim EcSpaceHandler(UINT32 Function, ACPI_PHYSICAL_ADDRESS Address, UINT32 Width,
7739a179dd8SJung-uk Kim 	       UINT64 *Value, void *Context, void *RegionContext)
77415e32d5dSMike Smith {
77515e32d5dSMike Smith     struct acpi_ec_softc	*sc = (struct acpi_ec_softc *)Context;
77634622ff1SJung-uk Kim     ACPI_PHYSICAL_ADDRESS	EcAddr;
777e115a49fSJung-uk Kim     UINT8			*EcData;
77834622ff1SJung-uk Kim     ACPI_STATUS			Status;
77915e32d5dSMike Smith 
780b4a05238SPeter Wemm     ACPI_FUNCTION_TRACE_U32((char *)(uintptr_t)__func__, (UINT32)Address);
7810ae55423SMike Smith 
78234622ff1SJung-uk Kim     if (Function != ACPI_READ && Function != ACPI_WRITE)
78334622ff1SJung-uk Kim 	return_ACPI_STATUS (AE_BAD_PARAMETER);
784e115a49fSJung-uk Kim     if (Width % 8 != 0 || Value == NULL || Context == NULL)
7850ae55423SMike Smith 	return_ACPI_STATUS (AE_BAD_PARAMETER);
78634622ff1SJung-uk Kim     if (Address + Width / 8 > 256)
7874ed391b8SNate Lawson 	return_ACPI_STATUS (AE_BAD_ADDRESS);
78815e32d5dSMike Smith 
78983dcc133SNate Lawson     /*
79083dcc133SNate Lawson      * If booting, check if we need to run the query handler.  If so, we
79183dcc133SNate Lawson      * we call it directly here since our thread taskq is not active yet.
79283dcc133SNate Lawson      */
793c66d2b38SJung-uk Kim     if (cold || rebooting || sc->ec_suspending) {
794c6e6b4feSHans Petter Selasky 	if ((EC_GET_CSR(sc) & EC_EVENT_SCI) &&
795c6e6b4feSHans Petter Selasky 	    atomic_fetchadd_int(&sc->ec_sci_pend, 1) == 0) {
79683dcc133SNate Lawson 	    CTR0(KTR_ACPI, "ec running gpe handler directly");
79783dcc133SNate Lawson 	    EcGpeQueryHandler(sc);
79883dcc133SNate Lawson 	}
79983dcc133SNate Lawson     }
80083dcc133SNate Lawson 
80183dcc133SNate Lawson     /* Serialize with EcGpeQueryHandler() at transaction granularity. */
80283dcc133SNate Lawson     Status = EcLock(sc);
803464c662eSNate Lawson     if (ACPI_FAILURE(Status))
804f4b7de15SNate Lawson 	return_ACPI_STATUS (Status);
8051f04e8f5SNate Lawson 
80634622ff1SJung-uk Kim     /* If we can't start burst mode, continue anyway. */
80734622ff1SJung-uk Kim     Status = EcCommand(sc, EC_COMMAND_BURST_ENABLE);
80834622ff1SJung-uk Kim     if (ACPI_SUCCESS(Status)) {
80934622ff1SJung-uk Kim 	if (EC_GET_DATA(sc) == EC_BURST_ACK) {
81034622ff1SJung-uk Kim 	    CTR0(KTR_ACPI, "ec burst enabled");
81134622ff1SJung-uk Kim 	    sc->ec_burstactive = TRUE;
81234622ff1SJung-uk Kim 	}
81334622ff1SJung-uk Kim     }
81434622ff1SJung-uk Kim 
815e115a49fSJung-uk Kim     /* Perform the transaction(s), based on Width. */
81634622ff1SJung-uk Kim     EcAddr = Address;
81734622ff1SJung-uk Kim     EcData = (UINT8 *)Value;
81834622ff1SJung-uk Kim     if (Function == ACPI_READ)
81934622ff1SJung-uk Kim 	*Value = 0;
82034622ff1SJung-uk Kim     do {
8211f04e8f5SNate Lawson 	switch (Function) {
8221f04e8f5SNate Lawson 	case ACPI_READ:
823e115a49fSJung-uk Kim 	    Status = EcRead(sc, EcAddr, EcData);
824ee785aa9SJohn Baldwin 	    break;
8251f04e8f5SNate Lawson 	case ACPI_WRITE:
826e115a49fSJung-uk Kim 	    Status = EcWrite(sc, EcAddr, *EcData);
8271f04e8f5SNate Lawson 	    break;
8281f04e8f5SNate Lawson 	}
8291f04e8f5SNate Lawson 	if (ACPI_FAILURE(Status))
8304ed391b8SNate Lawson 	    break;
83134622ff1SJung-uk Kim 	EcAddr++;
83234622ff1SJung-uk Kim 	EcData++;
83334622ff1SJung-uk Kim     } while (EcAddr < Address + Width / 8);
83434622ff1SJung-uk Kim 
83534622ff1SJung-uk Kim     if (sc->ec_burstactive) {
83634622ff1SJung-uk Kim 	sc->ec_burstactive = FALSE;
83734622ff1SJung-uk Kim 	if (ACPI_SUCCESS(EcCommand(sc, EC_COMMAND_BURST_DISABLE)))
83834622ff1SJung-uk Kim 	    CTR0(KTR_ACPI, "ec disabled burst ok");
839ee785aa9SJohn Baldwin     }
8404ed391b8SNate Lawson 
841f4b7de15SNate Lawson     EcUnlock(sc);
8420ae55423SMike Smith     return_ACPI_STATUS (Status);
84315e32d5dSMike Smith }
8442a4ac806SMike Smith 
84515e32d5dSMike Smith static ACPI_STATUS
84683dcc133SNate Lawson EcWaitEvent(struct acpi_ec_softc *sc, EC_EVENT Event, u_int gen_count)
84783dcc133SNate Lawson {
8485ff14fa9SAndriy Gapon     static int	no_intr = 0;
8491f04e8f5SNate Lawson     ACPI_STATUS	Status;
8505ff14fa9SAndriy Gapon     int		count, i, need_poll, slp_ival;
85115e32d5dSMike Smith 
852f4b7de15SNate Lawson     ACPI_SERIAL_ASSERT(ec);
8531f04e8f5SNate Lawson     Status = AE_NO_HARDWARE_RESPONSE;
8545ff14fa9SAndriy Gapon     need_poll = cold || rebooting || ec_polled_mode || sc->ec_suspending;
85583dcc133SNate Lawson 
85683dcc133SNate Lawson     /* Wait for event by polling or GPE (interrupt). */
8571de5ce99STakanori Watanabe     if (need_poll) {
85883dcc133SNate Lawson 	count = (ec_timeout * 1000) / EC_POLL_DELAY;
85983dcc133SNate Lawson 	if (count == 0)
860ef2374f7SNate Lawson 	    count = 1;
8615ff14fa9SAndriy Gapon 	DELAY(10);
862ef2374f7SNate Lawson 	for (i = 0; i < count; i++) {
86383dcc133SNate Lawson 	    Status = EcCheckStatus(sc, "poll", Event);
8649ad56977SJung-uk Kim 	    if (ACPI_SUCCESS(Status))
86515e32d5dSMike Smith 		break;
8665ff14fa9SAndriy Gapon 	    DELAY(EC_POLL_DELAY);
8671f04e8f5SNate Lawson 	}
86883dcc133SNate Lawson     } else {
869ef2374f7SNate Lawson 	slp_ival = hz / 1000;
870ef2374f7SNate Lawson 	if (slp_ival != 0) {
87183dcc133SNate Lawson 	    count = ec_timeout;
872ef2374f7SNate Lawson 	} else {
87383dcc133SNate Lawson 	    /* hz has less than 1 ms resolution so scale timeout. */
874b0eefa38SNate Lawson 	    slp_ival = 1;
875ef2374f7SNate Lawson 	    count = ec_timeout / (1000 / hz);
876ef2374f7SNate Lawson 	}
87783dcc133SNate Lawson 
87883dcc133SNate Lawson 	/*
87983dcc133SNate Lawson 	 * Wait for the GPE to signal the status changed, checking the
88083dcc133SNate Lawson 	 * status register each time we get one.  It's possible to get a
88183dcc133SNate Lawson 	 * GPE for an event we're not interested in here (i.e., SCI for
88283dcc133SNate Lawson 	 * EC query).
88383dcc133SNate Lawson 	 */
884b0eefa38SNate Lawson 	for (i = 0; i < count; i++) {
8855ff14fa9SAndriy Gapon 	    if (gen_count == sc->ec_gencount)
88680b1151eSJung-uk Kim 		tsleep(sc, 0, "ecgpe", slp_ival);
88783dcc133SNate Lawson 	    /*
88883dcc133SNate Lawson 	     * Record new generation count.  It's possible the GPE was
88983dcc133SNate Lawson 	     * just to notify us that a query is needed and we need to
89083dcc133SNate Lawson 	     * wait for a second GPE to signal the completion of the
89183dcc133SNate Lawson 	     * event we are actually waiting for.
89283dcc133SNate Lawson 	     */
89383dcc133SNate Lawson 	    Status = EcCheckStatus(sc, "sleep", Event);
8949ad56977SJung-uk Kim 	    if (ACPI_SUCCESS(Status)) {
8955ff14fa9SAndriy Gapon 		if (gen_count == sc->ec_gencount)
8965ff14fa9SAndriy Gapon 		    no_intr++;
8975ff14fa9SAndriy Gapon 		else
8985ff14fa9SAndriy Gapon 		    no_intr = 0;
899ff40920eSNate Lawson 		break;
900ff40920eSNate Lawson 	    }
9015ff14fa9SAndriy Gapon 	    gen_count = sc->ec_gencount;
9021f04e8f5SNate Lawson 	}
9031f04e8f5SNate Lawson 
90483dcc133SNate Lawson 	/*
90583dcc133SNate Lawson 	 * We finished waiting for the GPE and it never arrived.  Try to
90683dcc133SNate Lawson 	 * read the register once and trust whatever value we got.  This is
9075ff14fa9SAndriy Gapon 	 * the best we can do at this point.
90883dcc133SNate Lawson 	 */
9099ad56977SJung-uk Kim 	if (ACPI_FAILURE(Status))
91083dcc133SNate Lawson 	    Status = EcCheckStatus(sc, "sleep_end", Event);
91183dcc133SNate Lawson     }
9125ff14fa9SAndriy Gapon     if (!need_poll && no_intr > 10) {
9135ff14fa9SAndriy Gapon 	device_printf(sc->ec_dev,
9145ff14fa9SAndriy Gapon 	    "not getting interrupts, switched to polled mode\n");
9155ff14fa9SAndriy Gapon 	ec_polled_mode = 1;
91683dcc133SNate Lawson     }
9179ad56977SJung-uk Kim     if (ACPI_FAILURE(Status))
91883dcc133SNate Lawson 	    CTR0(KTR_ACPI, "error: ec wait timed out");
9191f04e8f5SNate Lawson     return (Status);
9201f04e8f5SNate Lawson }
9211f04e8f5SNate Lawson 
9221f04e8f5SNate Lawson static ACPI_STATUS
9231f04e8f5SNate Lawson EcCommand(struct acpi_ec_softc *sc, EC_COMMAND cmd)
9241f04e8f5SNate Lawson {
925ef2374f7SNate Lawson     ACPI_STATUS	status;
926ef2374f7SNate Lawson     EC_EVENT	event;
927ef2374f7SNate Lawson     EC_STATUS	ec_status;
92883dcc133SNate Lawson     u_int	gen_count;
9291f04e8f5SNate Lawson 
930f4b7de15SNate Lawson     ACPI_SERIAL_ASSERT(ec);
9311f04e8f5SNate Lawson 
932ef2374f7SNate Lawson     /* Don't use burst mode if user disabled it. */
933ef2374f7SNate Lawson     if (!ec_burst_mode && cmd == EC_COMMAND_BURST_ENABLE)
934ef2374f7SNate Lawson 	return (AE_ERROR);
935ef2374f7SNate Lawson 
9361f04e8f5SNate Lawson     /* Decide what to wait for based on command type. */
9371f04e8f5SNate Lawson     switch (cmd) {
9381f04e8f5SNate Lawson     case EC_COMMAND_READ:
93915e32d5dSMike Smith     case EC_COMMAND_WRITE:
9401f04e8f5SNate Lawson     case EC_COMMAND_BURST_DISABLE:
941ef2374f7SNate Lawson 	event = EC_EVENT_INPUT_BUFFER_EMPTY;
9421f04e8f5SNate Lawson 	break;
9431f04e8f5SNate Lawson     case EC_COMMAND_QUERY:
9441f04e8f5SNate Lawson     case EC_COMMAND_BURST_ENABLE:
945ef2374f7SNate Lawson 	event = EC_EVENT_OUTPUT_BUFFER_FULL;
94615e32d5dSMike Smith 	break;
94715e32d5dSMike Smith     default:
94883dcc133SNate Lawson 	device_printf(sc->ec_dev, "EcCommand: invalid command %#x\n", cmd);
9491f04e8f5SNate Lawson 	return (AE_BAD_PARAMETER);
950464c662eSNate Lawson     }
9511f04e8f5SNate Lawson 
9525ff14fa9SAndriy Gapon     /*
9535ff14fa9SAndriy Gapon      * Ensure empty input buffer before issuing command.
9545ff14fa9SAndriy Gapon      * Use generation count of zero to force a quick check.
9555ff14fa9SAndriy Gapon      */
9565ff14fa9SAndriy Gapon     status = EcWaitEvent(sc, EC_EVENT_INPUT_BUFFER_EMPTY, 0);
9575ff14fa9SAndriy Gapon     if (ACPI_FAILURE(status))
9585ff14fa9SAndriy Gapon 	return (status);
9595ff14fa9SAndriy Gapon 
9601f04e8f5SNate Lawson     /* Run the command and wait for the chosen event. */
961ef2374f7SNate Lawson     CTR1(KTR_ACPI, "ec running command %#x", cmd);
96283dcc133SNate Lawson     gen_count = sc->ec_gencount;
9631f04e8f5SNate Lawson     EC_SET_CSR(sc, cmd);
96483dcc133SNate Lawson     status = EcWaitEvent(sc, event, gen_count);
965ef2374f7SNate Lawson     if (ACPI_SUCCESS(status)) {
966ef2374f7SNate Lawson 	/* If we succeeded, burst flag should now be present. */
967ef2374f7SNate Lawson 	if (cmd == EC_COMMAND_BURST_ENABLE) {
968ef2374f7SNate Lawson 	    ec_status = EC_GET_CSR(sc);
969ef2374f7SNate Lawson 	    if ((ec_status & EC_FLAG_BURST_MODE) == 0)
970ef2374f7SNate Lawson 		status = AE_ERROR;
971ef2374f7SNate Lawson 	}
97283dcc133SNate Lawson     } else
97383dcc133SNate Lawson 	device_printf(sc->ec_dev, "EcCommand: no response to %#x\n", cmd);
974ef2374f7SNate Lawson     return (status);
97515e32d5dSMike Smith }
97615e32d5dSMike Smith 
97715e32d5dSMike Smith static ACPI_STATUS
97815e32d5dSMike Smith EcRead(struct acpi_ec_softc *sc, UINT8 Address, UINT8 *Data)
97915e32d5dSMike Smith {
980ef2374f7SNate Lawson     ACPI_STATUS	status;
98183dcc133SNate Lawson     u_int gen_count;
9825ff14fa9SAndriy Gapon     int retry;
98315e32d5dSMike Smith 
984f4b7de15SNate Lawson     ACPI_SERIAL_ASSERT(ec);
985c4a9fa45SNate Lawson     CTR1(KTR_ACPI, "ec read from %#x", Address);
98615e32d5dSMike Smith 
9875ff14fa9SAndriy Gapon     for (retry = 0; retry < 2; retry++) {
988ef2374f7SNate Lawson 	status = EcCommand(sc, EC_COMMAND_READ);
989ef2374f7SNate Lawson 	if (ACPI_FAILURE(status))
990ef2374f7SNate Lawson 	    return (status);
99115e32d5dSMike Smith 
99283dcc133SNate Lawson 	gen_count = sc->ec_gencount;
99315e32d5dSMike Smith 	EC_SET_DATA(sc, Address);
99483dcc133SNate Lawson 	status = EcWaitEvent(sc, EC_EVENT_OUTPUT_BUFFER_FULL, gen_count);
995ae1ef64fSJung-uk Kim 	if (ACPI_SUCCESS(status)) {
996464c662eSNate Lawson 	    *Data = EC_GET_DATA(sc);
99715e32d5dSMike Smith 	    return (AE_OK);
99815e32d5dSMike Smith 	}
999ae1ef64fSJung-uk Kim 	if (ACPI_FAILURE(EcCheckStatus(sc, "retr_check",
1000ae1ef64fSJung-uk Kim 	    EC_EVENT_INPUT_BUFFER_EMPTY)))
1001ae1ef64fSJung-uk Kim 	    break;
1002ae1ef64fSJung-uk Kim     }
10035ff14fa9SAndriy Gapon     device_printf(sc->ec_dev, "EcRead: failed waiting to get data\n");
10045ff14fa9SAndriy Gapon     return (status);
10055ff14fa9SAndriy Gapon }
100615e32d5dSMike Smith 
100715e32d5dSMike Smith static ACPI_STATUS
1008e115a49fSJung-uk Kim EcWrite(struct acpi_ec_softc *sc, UINT8 Address, UINT8 Data)
100915e32d5dSMike Smith {
1010ef2374f7SNate Lawson     ACPI_STATUS	status;
101183dcc133SNate Lawson     u_int gen_count;
101215e32d5dSMike Smith 
1013f4b7de15SNate Lawson     ACPI_SERIAL_ASSERT(ec);
1014e115a49fSJung-uk Kim     CTR2(KTR_ACPI, "ec write to %#x, data %#x", Address, Data);
101515e32d5dSMike Smith 
1016ef2374f7SNate Lawson     status = EcCommand(sc, EC_COMMAND_WRITE);
1017ef2374f7SNate Lawson     if (ACPI_FAILURE(status))
1018ef2374f7SNate Lawson 	return (status);
101915e32d5dSMike Smith 
102083dcc133SNate Lawson     gen_count = sc->ec_gencount;
102115e32d5dSMike Smith     EC_SET_DATA(sc, Address);
102283dcc133SNate Lawson     status = EcWaitEvent(sc, EC_EVENT_INPUT_BUFFER_EMPTY, gen_count);
1023ef2374f7SNate Lawson     if (ACPI_FAILURE(status)) {
10245ff14fa9SAndriy Gapon 	device_printf(sc->ec_dev, "EcWrite: failed waiting for sent address\n");
1025ef2374f7SNate Lawson 	return (status);
102615e32d5dSMike Smith     }
102715e32d5dSMike Smith 
102883dcc133SNate Lawson     gen_count = sc->ec_gencount;
1029e115a49fSJung-uk Kim     EC_SET_DATA(sc, Data);
103083dcc133SNate Lawson     status = EcWaitEvent(sc, EC_EVENT_INPUT_BUFFER_EMPTY, gen_count);
1031ef2374f7SNate Lawson     if (ACPI_FAILURE(status)) {
103283dcc133SNate Lawson 	device_printf(sc->ec_dev, "EcWrite: failed waiting for sent data\n");
1033ef2374f7SNate Lawson 	return (status);
103415e32d5dSMike Smith     }
103515e32d5dSMike Smith 
103615e32d5dSMike Smith     return (AE_OK);
103715e32d5dSMike Smith }
1038